Re: Review Request 31397: [HELIX-570] Add default state model definitions if not already exists when controller starts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31397/ --- (Updated Feb. 26, 2015, 2:23 a.m.) Review request for helix, Kishore Gopalakrishna and Shi Lu. Changes --- apply comments Bugs: 570 Repository: helix-git Description --- When controller starts, we can add missing default state model definitions to the cluster. This is useful for example, a legacy cluster is created without some new default state model definitions. Instead of building a tool to populate the new default state model definitions to existing clusters, controller can check this and add it if necessary. Diffs (updated) - helix-core/src/main/java/org/apache/helix/controller/HelixControllerMain.java b6c16b5 helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java 3328279 helix-core/src/main/java/org/apache/helix/model/BuildInSMD.java e69de29 helix-core/src/main/java/org/apache/helix/model/LeaderStandbySMD.java e69de29 helix-core/src/main/java/org/apache/helix/model/MasterSlaveSMD.java e69de29 helix-core/src/main/java/org/apache/helix/model/OnlineOfflineSMD.java e69de29 helix-core/src/main/java/org/apache/helix/model/ScheduledTaskSMD.java e69de29 helix-core/src/main/java/org/apache/helix/model/StorageSchemataSMD.java e69de29 helix-core/src/main/java/org/apache/helix/model/TaskSMD.java e69de29 helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 40bc398 helix-core/src/main/java/org/apache/helix/tools/StateModelConfigGenerator.java b8b3aeb helix-core/src/test/java/org/apache/helix/manager/zk/TestAddDefaultStateModelDef.java e69de29 Diff: https://reviews.apache.org/r/31397/diff/ Testing --- mvn test Thanks, Zhen Zhang
Re: Review Request 31397: [HELIX-570] Add default state model definitions if not already exists when controller starts
On Feb. 25, 2015, 11:13 p.m., Zhen Zhang wrote: helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java, line 153 https://reviews.apache.org/r/31397/diff/1/?file=874721#file874721line153 how about BuildinStateModelDefinitions BuiltInSMD works. - Kishore --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31397/#review74136 --- On Feb. 25, 2015, 1:39 a.m., Zhen Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31397/ --- (Updated Feb. 25, 2015, 1:39 a.m.) Review request for helix, Kishore Gopalakrishna and Shi Lu. Bugs: 570 Repository: helix-git Description --- When controller starts, we can add missing default state model definitions to the cluster. This is useful for example, a legacy cluster is created without some new default state model definitions. Instead of building a tool to populate the new default state model definitions to existing clusters, controller can check this and add it if necessary. Diffs - helix-core/src/main/java/org/apache/helix/controller/HelixControllerMain.java b6c16b5 helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java 3328279 helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 40bc398 helix-core/src/main/java/org/apache/helix/tools/StateModelConfigGenerator.java b8b3aeb helix-core/src/test/java/org/apache/helix/manager/zk/TestAddDefaultStateModelDef.java e69de29 Diff: https://reviews.apache.org/r/31397/diff/ Testing --- mvn test Thanks, Zhen Zhang
RE: 0.7.2 release
+1 for a release Unfortunately I don't have a computer capable of running all the tests (and am thus unable to do a release), but I can help with the website and javadocs. From: zzh...@linkedin.com To: u...@helix.apache.org; dev@helix.apache.org Subject: RE: 0.7.2 release Date: Wed, 25 Feb 2015 01:23:02 + I can cherry pick all the fixes. From: kishore g [g.kish...@gmail.com] Sent: Tuesday, February 24, 2015 5:08 PM To: dev@helix.apache.org Cc: u...@helix.apache.org Subject: Re: 0.7.2 release how do we know the things that we have pushed to 0.6.x but not to 0.7? On Tue, Feb 24, 2015 at 4:48 PM, Zhen Zhang zzh...@linkedin.com.invalid wrote: +1 As far as I can think of, here are a few things we need to complete before releasing 0.7.2 - merge fixes that have been done on 0.6.x but haven't been ported to master yet - fix 1 test failure - fix any other critical bugs we have in 0.7 - Jason From: Greg Brandt [brandt.g...@gmail.com] Sent: Tuesday, February 24, 2015 4:05 PM To: u...@helix.apache.org Cc: dev@helix.apache.org Subject: Re: 0.7.2 release Bump. What needs to be done for this? -Greg On Feb 18, 2015 9:02 PM, kishore g g.kish...@gmail.commailto:g.kish...@gmail.com wrote: +1 The recent bug we found is critical and would love to see that in the release. Thanks Kishore G On Feb 18, 2015 1:17 PM, Greg Brandt brandt.g...@gmail.commailto:brandt.g...@gmail.com wrote: Hey guys, Would it be possible to get an 0.7.2 release? I have a use case that uses helix-ipc, for which there were a few critical patches after 0.7.1 release. Thanks, -Greg
