[GitHub] hive pull request: HIVE-11179: HIVE should allow custom converting...
Github user sundapeng closed the pull request at: https://github.com/apache/hive/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (HIVE-11206) CBO (Calcite Return Path): Join translation should update all ExprNode recursively
Jesus Camacho Rodriguez created HIVE-11206: -- Summary: CBO (Calcite Return Path): Join translation should update all ExprNode recursively Key: HIVE-11206 URL: https://issues.apache.org/jira/browse/HIVE-11206 Project: Hive Issue Type: Sub-task Reporter: Jesus Camacho Rodriguez Assignee: Jesus Camacho Rodriguez -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-11203) Beeline force option doesn't force execution when errors occurred in a script.
Ferdinand Xu created HIVE-11203: --- Summary: Beeline force option doesn't force execution when errors occurred in a script. Key: HIVE-11203 URL: https://issues.apache.org/jira/browse/HIVE-11203 Project: Hive Issue Type: Bug Components: Beeline Reporter: Ferdinand Xu Assignee: Ferdinand Xu The force option doesn't function as wiki described. https://cwiki.apache.org/confluence/display/Hive/HiveServer2+Clients -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-11204) Research on recent failed qtests[Spark Branch]
Chengxiang Li created HIVE-11204: Summary: Research on recent failed qtests[Spark Branch] Key: HIVE-11204 URL: https://issues.apache.org/jira/browse/HIVE-11204 Project: Hive Issue Type: Sub-task Components: Spark Affects Versions: spark-branch Reporter: Chengxiang Li Priority: Minor Found some strange failed qtests in HIVE-11053 Hive QA, as it's pretty sure that failed qtests are not related to HIVE-11053 patch, so just reproduce and research it here. Failed tests: org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_groupby_bigdata org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_groupby_resolution org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_groupby_sort_1_23 org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_join_literals org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_mapreduce1 org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_skewjoinopt2 org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_smb_mapjoin_15 org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_union_remove_19 org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_union_remove_4 org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_union_remove_8 org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_union_view -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-11207) org.apache.hadoop.hive.hbase.TestHBaseSerDe should use numeric data types instead strings
Svetozar Ivanov created HIVE-11207: -- Summary: org.apache.hadoop.hive.hbase.TestHBaseSerDe should use numeric data types instead strings Key: HIVE-11207 URL: https://issues.apache.org/jira/browse/HIVE-11207 Project: Hive Issue Type: Bug Reporter: Svetozar Ivanov Assignee: Svetozar Ivanov Priority: Minor {code} byte [] cfa = cola.getBytes(); byte [] cfb = colb.getBytes(); byte [] cfc = colc.getBytes(); byte [] qualByte = byte.getBytes(); byte [] qualShort = short.getBytes(); byte [] qualInt = int.getBytes(); byte [] qualLong = long.getBytes(); byte [] qualFloat = float.getBytes(); byte [] qualDouble = double.getBytes(); byte [] qualString = string.getBytes(); byte [] qualBool = boolean.getBytes(); byte [] rowKey = Bytes.toBytes(test-row1); // Data ListKeyValue kvs = new ArrayListKeyValue(); kvs.add(new KeyValue(rowKey, cfa, qualByte, Bytes.toBytes(123))); kvs.add(new KeyValue(rowKey, cfb, qualShort, Bytes.toBytes(456))); kvs.add(new KeyValue(rowKey, cfc, qualInt, Bytes.toBytes(789))); kvs.add(new KeyValue(rowKey, cfa, qualLong, Bytes.toBytes(1000))); kvs.add(new KeyValue(rowKey, cfb, qualFloat, Bytes.toBytes(-0.01))); kvs.add(new KeyValue(rowKey, cfc, qualDouble, Bytes.toBytes(5.3))); kvs.add(new KeyValue(rowKey, cfa, qualString, Bytes.toBytes(Hadoop, HBase, and Hive))); kvs.add(new KeyValue(rowKey, cfb, qualBool, Bytes.toBytes(true))); Collections.sort(kvs, KeyValue.COMPARATOR); Result r = new Result(kvs); Put p = new Put(rowKey); p.add(cfa, qualByte, Bytes.toBytes(123)); p.add(cfb, qualShort, Bytes.toBytes(456)); p.add(cfc, qualInt, Bytes.toBytes(789)); p.add(cfa, qualLong, Bytes.toBytes(1000)); p.add(cfb, qualFloat, Bytes.toBytes(-0.01)); p.add(cfc, qualDouble, Bytes.toBytes(5.3)); p.add(cfa, qualString, Bytes.toBytes(Hadoop, HBase, and Hive)); p.add(cfb, qualBool, Bytes.toBytes(true)); {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 36300: HIVE-11191 Beeline-cli: support hive.cli.errors.ignore in new CLI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36300/ --- Review request for hive and Xuefu Zhang. Bugs: HIVE-11191 https://issues.apache.org/jira/browse/HIVE-11191 Repository: hive-git Description --- Summary: 1. Add option update stage after connection established in CLI mode 2. Update the getHiveConf API Diffs - beeline/src/java/org/apache/hive/beeline/BeeLine.java 1d468eb beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java c1ec82a beeline/src/java/org/apache/hive/beeline/Commands.java d490273 beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java ff8ab17 Diff: https://reviews.apache.org/r/36300/diff/ Testing --- Partial UT passed and local cluster test passed. Thanks, cheng xu
[jira] [Created] (HIVE-11205) Unable to create table being in read-only database
Mariusz Strzelecki created HIVE-11205: - Summary: Unable to create table being in read-only database Key: HIVE-11205 URL: https://issues.apache.org/jira/browse/HIVE-11205 Project: Hive Issue Type: Bug Reporter: Mariusz Strzelecki Assignee: Mariusz Strzelecki With enabled Legacy Authorization I cannot create table being in database that is read-only to me. For example: {noformat} use ro_db; No rows affected (1.222 seconds) create table rw_db.test (s string); Error: Error while compiling statement: No privilege 'Create' found for outputs { database:ro_db} (state=42000,code=403) use rw_db; No rows affected (0.407 seconds) create table rw_db.test (s string); No rows affected (2.216 seconds) {noformat} This happens because doAuthorization method checks write permissions against current database and then againts output database. Check for current database is not needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 36284: HIVE-11197
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36284/#review90886 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java (line 185) https://reviews.apache.org/r/36284/#comment144052 Should we add a message here (DEBUG or WARN level) with the Exception, to know exactly what was going on? - Jesús Camacho Rodríguez On July 7, 2015, 11:09 p.m., Ashutosh Chauhan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36284/ --- (Updated July 7, 2015, 11:09 p.m.) Review request for hive and Jesús Camacho Rodríguez. Bugs: HIVE-11197 https://issues.apache.org/jira/browse/HIVE-11197 Repository: hive-git Description --- While extracting join conditions follow Hive rules for type conversion instead of Calcite Diffs - ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 024097e ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java 9ebb24f ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java c5e0e11 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSelectivity.java 960ec40 Diff: https://reviews.apache.org/r/36284/diff/ Testing --- Existing tests. Thanks, Ashutosh Chauhan
[jira] [Created] (HIVE-11208) Can not drop a default partition __HIVE_DEFAULT_PARTITION__ which is not a string type
Yongzhi Chen created HIVE-11208: --- Summary: Can not drop a default partition __HIVE_DEFAULT_PARTITION__ which is not a string type Key: HIVE-11208 URL: https://issues.apache.org/jira/browse/HIVE-11208 Project: Hive Issue Type: Bug Components: Parser Affects Versions: 1.1.0 Reporter: Yongzhi Chen When partition is not a string type, for example, if it is a int type, when drop the default partition __HIVE_DEFAULT_PARTITION__, you will get: SemanticException Unexpected unknown partitions Reproduce: {noformat} SET hive.exec.dynamic.partition=true; SET hive.exec.dynamic.partition.mode=nonstrict; set hive.exec.max.dynamic.partitions.pernode=1; DROP TABLE IF EXISTS test; CREATE TABLE test (col1 string) PARTITIONED BY (p1 int) ROW FORMAT DELIMITED FIELDS TERMINATED BY '\001' STORED AS TEXTFILE; INSERT OVERWRITE TABLE test PARTITION (p1) SELECT code, IF(salary 600, 100, null) as p1 FROM jsmall; hive SHOW PARTITIONS test; OK p1=100 p1=__HIVE_DEFAULT_PARTITION__ Time taken: 0.124 seconds, Fetched: 2 row(s) hive ALTER TABLE test DROP partition (p1 = '__HIVE_DEFAULT_PARTITION__'); FAILED: SemanticException Unexpected unknown partitions for (p1 = null) {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 36300: HIVE-11191 Beeline-cli: support hive.cli.errors.ignore in new CLI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36300/#review90889 --- beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java (line 228) https://reviews.apache.org/r/36300/#comment144056 Since we are getting configurations when connection is first made, we should probably store them for later use so that we don't need to make another again. beeline/src/java/org/apache/hive/beeline/Commands.java (line 759) https://reviews.apache.org/r/36300/#comment144054 Why do we provide two way to do the same thing? When do we choose to use one or the other? - Xuefu Zhang On July 8, 2015, 8:44 a.m., cheng xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36300/ --- (Updated July 8, 2015, 8:44 a.m.) Review request for hive and Xuefu Zhang. Bugs: HIVE-11191 https://issues.apache.org/jira/browse/HIVE-11191 Repository: hive-git Description --- Summary: 1. Add option update stage after connection established in CLI mode 2. Update the getHiveConf API Diffs - beeline/src/java/org/apache/hive/beeline/BeeLine.java 1d468eb beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java c1ec82a beeline/src/java/org/apache/hive/beeline/Commands.java d490273 beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java ff8ab17 Diff: https://reviews.apache.org/r/36300/diff/ Testing --- Partial UT passed and local cluster test passed. Thanks, cheng xu
Re: Review Request 36300: HIVE-11191 Beeline-cli: support hive.cli.errors.ignore in new CLI
On July 8, 2015, 9:27 p.m., Xuefu Zhang wrote: beeline/src/java/org/apache/hive/beeline/Commands.java, line 759 https://reviews.apache.org/r/36300/diff/1/?file=1002091#file1002091line759 Why do we provide two way to do the same thing? When do we choose to use one or the other? This part of code is very tricky and blocked me quite some time. If you use the call method, seems data is not synchronized with the server side. And if you use the sql method, it will override the console of the beeline. I referred the code logic from executeInternal method. To be honest, I am not quite follow the original purpose of this code logic but it works. - cheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36300/#review90889 --- On July 8, 2015, 4:44 p.m., cheng xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36300/ --- (Updated July 8, 2015, 4:44 p.m.) Review request for hive and Xuefu Zhang. Bugs: HIVE-11191 https://issues.apache.org/jira/browse/HIVE-11191 Repository: hive-git Description --- Summary: 1. Add option update stage after connection established in CLI mode 2. Update the getHiveConf API Diffs - beeline/src/java/org/apache/hive/beeline/BeeLine.java 1d468eb beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java c1ec82a beeline/src/java/org/apache/hive/beeline/Commands.java d490273 beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java ff8ab17 Diff: https://reviews.apache.org/r/36300/diff/ Testing --- Partial UT passed and local cluster test passed. Thanks, cheng xu
[jira] [Created] (HIVE-11209) Clean up dependencies in HiveDecimalWritable
Owen O'Malley created HIVE-11209: Summary: Clean up dependencies in HiveDecimalWritable Key: HIVE-11209 URL: https://issues.apache.org/jira/browse/HIVE-11209 Project: Hive Issue Type: Sub-task Reporter: Owen O'Malley Assignee: Owen O'Malley Currently HiveDecimalWritable depends on: * org.apache.hadoop.hive.serde2.ByteStream * org.apache.hadoop.hive.serde2.lazybinary.LazyBinaryUtils * org.apache.hadoop.hive.serde2.typeinfo.HiveDecimalUtils since we need HiveDecimalWritable for the decimal VectorizedColumnBatch, breaking these dependencies will improve things. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-11210) Remove dependency on HiveConf from Orc reader writer
Owen O'Malley created HIVE-11210: Summary: Remove dependency on HiveConf from Orc reader writer Key: HIVE-11210 URL: https://issues.apache.org/jira/browse/HIVE-11210 Project: Hive Issue Type: Sub-task Reporter: Owen O'Malley Assignee: Owen O'Malley Currently the ORC reader and writer get their default values from HiveConf. I propose that we make the reader and writer have their own programatic defaults and the OrcInputFormat and OrcOutputFormat can use the version in HiveConf. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Hive-0.14 - Build # 1006 - Still Failing
Changes for Build #986 Changes for Build #987 Changes for Build #988 Changes for Build #989 Changes for Build #990 Changes for Build #991 Changes for Build #992 Changes for Build #993 Changes for Build #994 Changes for Build #995 Changes for Build #996 Changes for Build #997 Changes for Build #998 Changes for Build #999 Changes for Build #1000 Changes for Build #1001 Changes for Build #1002 Changes for Build #1003 Changes for Build #1004 Changes for Build #1005 Changes for Build #1006 No tests ran. The Apache Jenkins build system has built Hive-0.14 (build #1006) Status: Still Failing Check console output at https://builds.apache.org/job/Hive-0.14/1006/ to view the results.
Re: Review Request 34666: HIVE-9152 - Dynamic Partition Pruning [Spark Branch]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34666/ --- (Updated July 8, 2015, 6:04 p.m.) Review request for hive, chengxiang li and Xuefu Zhang. Bugs: HIVE-9152 https://issues.apache.org/jira/browse/HIVE-9152 Repository: hive-git Description --- Tez implemented dynamic partition pruning in HIVE-7826. This is a nice optimization and we should implement the same in HOS. Diffs (updated) - common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 27f68df itests/src/test/resources/testconfiguration.properties 4f2de12 ql/if/queryplan.thrift c8dfa35 ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/OperatorType.java e18f935 ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorFactory.java f58a10b ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveSparkClientFactory.java 21398d8 ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkDynamicPartitionPruner.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkUtilities.java ca0ffb6 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorSparkPartitionPruningSinkOperator.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java 1de7e40 ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 2ff3951 ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java 8546d21 ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java a7cf8b7 ql/src/java/org/apache/hadoop/hive/ql/optimizer/SparkRemoveDynamicPruningBySize.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java ad47547 ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkPartitionPruningSinkDesc.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkProcContext.java 447f104 ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkUtils.java 7992c88 ql/src/java/org/apache/hadoop/hive/ql/parse/spark/OptimizeSparkProcContext.java f7586a4 ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java 7f2c079 ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkPartitionPruningSinkOperator.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SplitOpTreeForDPP.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 3217df2 ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 9e9a2a2 ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java 363e49e ql/src/test/queries/clientpositive/spark_dynamic_partition_pruning.q PRE-CREATION ql/src/test/queries/clientpositive/spark_dynamic_partition_pruning_2.q PRE-CREATION ql/src/test/queries/clientpositive/spark_vectorized_dynamic_partition_pruning.q PRE-CREATION ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning_2.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/spark_vectorized_dynamic_partition_pruning.q.out PRE-CREATION ql/src/test/results/clientpositive/spark/vectorized_dynamic_partition_pruning.q.out PRE-CREATION Diff: https://reviews.apache.org/r/34666/diff/ Testing --- spark_dynamic_partition_pruning.q, spark_dynamic_partition_pruning_2.q - both are clone from tez's test. Thanks, Chao Sun
Re: Review Request 36069: HIVE-11141 : Improve RuleRegExp when the Expression node stack gets huge
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36069/#review90982 --- Ship it! +1 conditional on QA clean run on Patch 5. - John Pullokkaran On July 7, 2015, 7:54 p.m., Hari Sankar Sivarama Subramaniyan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36069/ --- (Updated July 7, 2015, 7:54 p.m.) Review request for hive, John Pullokkaran and Mostafa Mokhtar. Repository: hive-git Description --- Improve RuleRegExp when the Expression node stack gets huge Diffs - ql/src/java/org/apache/hadoop/hive/ql/lib/RuleRegExp.java ddc96c2 ql/src/test/org/apache/hadoop/hive/ql/lib/TestRuleRegExp.java PRE-CREATION Diff: https://reviews.apache.org/r/36069/diff/ Testing --- Local testing. Thanks, Hari Sankar Sivarama Subramaniyan
[jira] [Created] (HIVE-11211) Reset the static fields in static class JoinStatsRule in StatsRulesProcFactory
Pengcheng Xiong created HIVE-11211: -- Summary: Reset the static fields in static class JoinStatsRule in StatsRulesProcFactory Key: HIVE-11211 URL: https://issues.apache.org/jira/browse/HIVE-11211 Project: Hive Issue Type: Bug Reporter: Pengcheng Xiong Assignee: Pengcheng Xiong -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-11213) LLAP: more out file changes compared to master
Sergey Shelukhin created HIVE-11213: --- Summary: LLAP: more out file changes compared to master Key: HIVE-11213 URL: https://issues.apache.org/jira/browse/HIVE-11213 Project: Hive Issue Type: Sub-task Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: llap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-11201) HCatalog is ignoring user specified avro schema in the table definition
Bing Li created HIVE-11201: -- Summary: HCatalog is ignoring user specified avro schema in the table definition Key: HIVE-11201 URL: https://issues.apache.org/jira/browse/HIVE-11201 Project: Hive Issue Type: Bug Components: HCatalog Affects Versions: 1.2.0 Reporter: Bing Li Assignee: Bing Li Priority: Critical HCatalog is ignoring user specified avro schema in the table definition , instead generating its own avro based from hive meta store. By generating its own schema will result in mismatch names. For exmple Avro fields name are Case Sensitive. By generating it's own schema will result in incorrect schema written to the avro file , and result select fail on read. And also Even if user specified schema does not allow null , when data is written using Hcatalog , it will write a schema that will allow null. For example in the table , user specified , all CAPITAL letters in the schema , and record name as LINEITEM. The schema should be written as it is. Instead Hcatalog ignores it and generated its own avro schema from the hive table case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-11202) Update golden files on master
Ashutosh Chauhan created HIVE-11202: --- Summary: Update golden files on master Key: HIVE-11202 URL: https://issues.apache.org/jira/browse/HIVE-11202 Project: Hive Issue Type: Bug Components: Tests Affects Versions: 2.0.0 Reporter: Ashutosh Chauhan Assignee: Ashutosh Chauhan Few golden files updates missed in HIVE-11171 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HIVE-11212) Create vectorized types for complex types
Owen O'Malley created HIVE-11212: Summary: Create vectorized types for complex types Key: HIVE-11212 URL: https://issues.apache.org/jira/browse/HIVE-11212 Project: Hive Issue Type: Sub-task Reporter: Owen O'Malley Assignee: Owen O'Malley We need vectorized types for structs, maps, lists, and unions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 36335: Reset the static fields in static class JoinStatsRule in StatsRulesProcFactory
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36335/ --- Review request for hive, John Pullokkaran and Mostafa Mokhtar. Repository: hive-git Description --- The static fields in static class JoinStatsRule in StatsRulesProcFactory were carried on in between different calls. It would be better to move it inside the function, just like all the other StatsRuls do. Diffs - ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 0982059 Diff: https://reviews.apache.org/r/36335/diff/ Testing --- Thanks, pengcheng xiong
Re: Review Request 36335: Reset the fields in class JoinStatsRule in StatsRulesProcFactory
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36335/ --- (Updated July 8, 2015, 11:37 p.m.) Review request for hive, John Pullokkaran and Mostafa Mokhtar. Repository: hive-git Description --- The static fields in static class JoinStatsRule in StatsRulesProcFactory were carried on in between different calls. It would be better to move it inside the function, just like all the other StatsRuls do. Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 0982059 Diff: https://reviews.apache.org/r/36335/diff/ Testing --- Thanks, pengcheng xiong
Re: Review Request 36335: Reset the fields in class JoinStatsRule in StatsRulesProcFactory
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36335/#review91057 --- Ship it! Ship It! - Mostafa Mokhtar On July 8, 2015, 11:37 p.m., pengcheng xiong wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36335/ --- (Updated July 8, 2015, 11:37 p.m.) Review request for hive, John Pullokkaran and Mostafa Mokhtar. Repository: hive-git Description --- The static fields in static class JoinStatsRule in StatsRulesProcFactory were carried on in between different calls. It would be better to move it inside the function, just like all the other StatsRuls do. Diffs - ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 0982059 Diff: https://reviews.apache.org/r/36335/diff/ Testing --- Thanks, pengcheng xiong
How to use LineageInfo.java in personal module
Hi: I am new to hive. There are many hive sql command in a file. I want to figure out what input table and output table names are in each hive sql command. There is a class LineageInfo.java in $HIVE_HOME/ql/src/java/org/apache/hadoop/hive/ql/tools The feature I want is like this: But how do I use LineageInfo.java? Do I have to compile ql module, or do I have to compile the whole hive project. Does anyone has any suggestions on how to make this feature? Hope you'll reply soon! 2015-07-09 baishaoqi
来自白少琦的邮件
Re: Review Request 36335: Reset the static fields in static class JoinStatsRule in StatsRulesProcFactory
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36335/#review91020 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java (line 1246) https://reviews.apache.org/r/36335/#comment144238 Could you change the name of getSelectivity to getCardinality or some thing similar. This method is actually returning cardinality as opposed to selectivity. - John Pullokkaran On July 8, 2015, 10:10 p.m., pengcheng xiong wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36335/ --- (Updated July 8, 2015, 10:10 p.m.) Review request for hive, John Pullokkaran and Mostafa Mokhtar. Repository: hive-git Description --- The static fields in static class JoinStatsRule in StatsRulesProcFactory were carried on in between different calls. It would be better to move it inside the function, just like all the other StatsRuls do. Diffs - ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 0982059 Diff: https://reviews.apache.org/r/36335/diff/ Testing --- Thanks, pengcheng xiong
Re: Review Request 36280: HIVE-11196
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36280/#review91021 --- ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java (line 1212) https://reviews.apache.org/r/36280/#comment144243 What happens when Table/Part Desc changes (due to alter commands)? Since there is no invalidation mechanisms, caching it in a static map seems bad. Instead may be in the caller pass in TableDesc obj thus reusing it. - John Pullokkaran On July 7, 2015, 9:35 p.m., Hari Sankar Sivarama Subramaniyan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36280/ --- (Updated July 7, 2015, 9:35 p.m.) Review request for hive and John Pullokkaran. Repository: hive-git Description --- Utilities.getPartitionDesc() should try to reuse TableDesc object Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java afecb1e ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 08ff2e9 Diff: https://reviews.apache.org/r/36280/diff/ Testing --- Thanks, Hari Sankar Sivarama Subramaniyan
Re: Review Request 36335: Reset the fields in class JoinStatsRule in StatsRulesProcFactory
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36335/ --- (Updated July 8, 2015, 11:32 p.m.) Review request for hive, John Pullokkaran and Mostafa Mokhtar. Summary (updated) - Reset the fields in class JoinStatsRule in StatsRulesProcFactory Repository: hive-git Description --- The static fields in static class JoinStatsRule in StatsRulesProcFactory were carried on in between different calls. It would be better to move it inside the function, just like all the other StatsRuls do. Diffs - ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 0982059 Diff: https://reviews.apache.org/r/36335/diff/ Testing --- Thanks, pengcheng xiong
[jira] [Created] (HIVE-11214) Insert into ACID table switches vectorization off
Matt McCline created HIVE-11214: --- Summary: Insert into ACID table switches vectorization off Key: HIVE-11214 URL: https://issues.apache.org/jira/browse/HIVE-11214 Project: Hive Issue Type: Bug Components: Hive Reporter: Matt McCline Assignee: Matt McCline Priority: Critical PROBLEM: vectorization is switched off automatically after run insert into ACID table. STEPS TO REPRODUCE: set hive.vectorized.execution.enabled=true; create table testv (id int, name string) clustered by (id) into 2 buckets stored as orc tblproperties(transactional=true); insert into testv values(1,'a'); set hive.vectorized.execution.enabled; false -- This message was sent by Atlassian JIRA (v6.3.4#6332)