Re: Review Request 48159: HIVE-13901: Hivemetastore add partitions can be slow depending on filesystems

2016-06-13 Thread Rajesh Balamohan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48159/
---

(Updated June 14, 2016, 5:06 a.m.)


Review request for hive and Ashutosh Chauhan.


Changes
---

1. HCatalog tests were failing as they ended up creating client/HMS too many 
times and threadPool was getting created every time. This caused rejection 
exceptions. FS threadpool created here can be static and be shared across. Made 
it static.

2. Renamed variable to "hive.metastore.fshandler.threads" as Ashutosh suggested.

3. Ran HCatalog tests locally to ensure it passes.


Bugs: HIVE-13901
https://issues.apache.org/jira/browse/HIVE-13901


Repository: hive-git


Description
---

Depending on FS, creating external tables & adding partitions can be expensive 
(e.g msck which adds all partitions).


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 285caa3 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
c0827ea 

Diff: https://reviews.apache.org/r/48159/diff/


Testing
---


Thanks,

Rajesh Balamohan



Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-13 Thread Mohit Sabharwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48233/#review137434
---



LGTM, but couple comments regarding breaking backward compatibility.


metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 
3179)


Since we are moving the functionality from driver to HMS, should we 
deprecate 
hive.limit.query.max.table.partition and introduce a new config called 
hive.metastore.retrieve.max.partitions ?

All metastore configs have "hive.metastore" prefix. 

Otherwise:
1) The change is backward incompatible for existing users that
are setting this config at HS2 level and are now expected to set it
at HMS level to get the same functionality.
2) Name would be confusing.

We could do the following:
1) Mark hive.limit.query.max.table.partition as deprecated in HiveConf and 
suggest that user 
move to hive.metastore.retrieve.max.partitions
2) Do not remove the functionality associated with 
hive.limit.query.max.table.partition in PartitionPruner.
It does do what the description promises - i.e. fail the query before 
execution stage if number of 
partitions associated with any scan operator exceed configured value.
3) Add new config hive.metastore.retrieve.max.partitions to configure 
functionality in this patch.

Makes sense ?



metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 2524)


As Brock suggested, it's worth figuring out the latency impact of this 
select count query - which will be issued for every getPartitions request.


- Mohit Sabharwal


On June 13, 2016, 6:28 p.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48233/
> ---
> 
> (Updated June 13, 2016, 6:28 p.m.)
> 
> 
> Review request for hive, Mohit Sabharwal and Naveen Gangam.
> 
> 
> Bugs: HIVE-13884
> https://issues.apache.org/jira/browse/HIVE-13884
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The patch verifies the # of partitions a table has before fetching any from 
> the metastore. I
> t checks that limit from 'hive.limit.query.max.table.partition'.
> 
> A limitation added here is that the variable must be on hive-site.xml in 
> order to work, and it does not accept to set this through beeline because 
> HiveMetaStore.java does not read the variables set through beeline. I think 
> it is better to keep it this way to avoid users changing the value on fly, 
> and crashing the metastore.
> 
> Another change is that EXPLAIN commands won't be executed either. EXPLAIN 
> commands need to fetch partitions in order to create the operator tree. If we 
> allow EXPLAIN to do that, then we may have the same OOM situations for large 
> partitions.
> 
> 
> Diffs
> -
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
> c0827ea9d47e569d9697649a7e16d196de3de14d 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 
> c135179b97354108f842a5ca2de0c6f0ef28b7fc 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
> f98de1326956b19b9d28fc9b1fcdede8d851180d 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 
> a6d3f5385b33b8a4e31ee20ca5cb8f58c97c8702 
>   metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 
> 31f0d7b89670b8a749bbe8a7ff2b4ff9f059a8e2 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
>  3152e77c3c7152ac4dbe7e779ce35f28044fe3c9 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
>  86a243609b23e2ca9bb8849f0da863a95e477d5c 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> cd3c86064df3e7febcc16e03aab6ce407e0dc8a0 
> 
> Diff: https://reviews.apache.org/r/48233/diff/
> 
> 
> Testing
> ---
> 
> Waiting for HiveQA.
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>



[jira] [Created] (HIVE-14009) Acid DB creation error in HiveQA

2016-06-13 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14009:
---

 Summary: Acid DB creation error in HiveQA
 Key: HIVE-14009
 URL: https://issues.apache.org/jira/browse/HIVE-14009
 Project: Hive
  Issue Type: Bug
Reporter: Sergey Shelukhin


Seen when running TestEncryptedHDFSCliDriver, at least with Hadoop 2.7.2 
(HIVE-13930). 

Looks like such issues are usually caused by concurrent db creation from 
multiple threads.
{noformat}
java.lang.RuntimeException: Unable to set up transaction database for testing: 
Exception during creation of file 
/home/hiveptest/54.219.24.101-hiveptest-0/apache-github-source-source/itests/qtest/target/tmp/junit_metastore_db/seg0/cc60.dat
 for container
at 
org.apache.hadoop.hive.metastore.txn.TxnHandler.checkQFileTestHack(TxnHandler.java:2172)
 ~[hive-metastore-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at 
org.apache.hadoop.hive.metastore.txn.TxnHandler.setConf(TxnHandler.java:228) 
~[hive-metastore-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at 
org.apache.hadoop.hive.metastore.txn.TxnUtils.getTxnStore(TxnUtils.java:96) 
[hive-metastore-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at 
org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.getTxnHandler(HiveMetaStore.java:557)
 [hive-metastore-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at 
org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.heartbeat(HiveMetaStore.java:5902)
 [hive-metastore-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[?:1.8.0_25]
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
~[?:1.8.0_25]
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[?:1.8.0_25]
at java.lang.reflect.Method.invoke(Method.java:483) ~[?:1.8.0_25]
at 
org.apache.hadoop.hive.metastore.RetryingHMSHandler.invokeInternal(RetryingHMSHandler.java:140)
 [hive-metastore-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at 
org.apache.hadoop.hive.metastore.RetryingHMSHandler.invoke(RetryingHMSHandler.java:99)
 [hive-metastore-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at com.sun.proxy.$Proxy111.heartbeat(Unknown Source) [?:?]
at 
org.apache.hadoop.hive.metastore.HiveMetaStoreClient.heartbeat(HiveMetaStoreClient.java:2140)
 [hive-metastore-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[?:1.8.0_25]
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
~[?:1.8.0_25]
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[?:1.8.0_25]
at java.lang.reflect.Method.invoke(Method.java:483) ~[?:1.8.0_25]
at 
org.apache.hadoop.hive.metastore.RetryingMetaStoreClient.invoke(RetryingMetaStoreClient.java:154)
 [hive-metastore-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at com.sun.proxy.$Proxy112.heartbeat(Unknown Source) [?:?]
at 
org.apache.hadoop.hive.ql.lockmgr.DbTxnManager$SynchronizedMetaStoreClient.heartbeat(DbTxnManager.java:663)
 [hive-exec-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.lockmgr.DbTxnManager.heartbeat(DbTxnManager.java:423) 
[hive-exec-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.lockmgr.DbTxnManager$Heartbeater.run(DbTxnManager.java:633)
 [hive-exec-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
[?:1.8.0_25]
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) 
[?:1.8.0_25]
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
 [?:1.8.0_25]
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
 [?:1.8.0_25]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) 
[?:1.8.0_25]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) 
[?:1.8.0_25]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_25]
Caused by: java.sql.SQLException: Exception during creation of file 
/home/hiveptest/54.219.24.101-hiveptest-0/apache-github-source-source/itests/qtest/target/tmp/junit_metastore_db/seg0/cc60.dat
 for container
at 
org.apache.derby.impl.jdbc.SQLExceptionFactory40.getSQLException(Unknown 
Source) ~[derby-10.10.2.0.jar:?]
at org.apache.derby.impl.jdbc.Util.newEmbedSQLException(Unknown Source) 
~[derby-10.10.2.0.jar:?]
at org.apache.derby.impl.jdbc.Util.seeNextException(Unknown Source) 
~[derby-10.10.2.0.jar:?]
at 
org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown 
Source) ~[derby-10.10.2.0.jar:?]
at 
org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown 

[jira] [Created] (HIVE-14008) Duplicate line in LLAP SecretManager

2016-06-13 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-14008:
---

 Summary: Duplicate line in LLAP SecretManager
 Key: HIVE-14008
 URL: https://issues.apache.org/jira/browse/HIVE-14008
 Project: Hive
  Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Trivial






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] hive pull request #81: HIVE-14007. Replace ORC module with ORC 1.1.1 release

2016-06-13 Thread omalley
GitHub user omalley opened a pull request:

https://github.com/apache/hive/pull/81

HIVE-14007. Replace ORC module with ORC 1.1.1 release

This patch replaces the inline ORC module with the ORC 1.1.1 release.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omalley/hive hive-14007

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/hive/pull/81.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #81


commit 4fde122f06709a750dcbbe867be754f04698e9d9
Author: Owen O'Malley 
Date:   2016-06-13T21:53:56Z

HIVE-14007. Replace ORC module with ORC 1.1.1 release




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (HIVE-14007) Replace ORC module with ORC release

2016-06-13 Thread Owen O'Malley (JIRA)
Owen O'Malley created HIVE-14007:


 Summary: Replace ORC module with ORC release
 Key: HIVE-14007
 URL: https://issues.apache.org/jira/browse/HIVE-14007
 Project: Hive
  Issue Type: Bug
  Components: ORC
Affects Versions: 2.2.0
Reporter: Owen O'Malley
Assignee: Owen O'Malley
 Fix For: 2.2.0


This completes moving the core ORC reader & writer to the ORC project.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-14006) Hive query with UNION ALL fails with ArrayIndexOutOfBoundsException

2016-06-13 Thread Naveen Gangam (JIRA)
Naveen Gangam created HIVE-14006:


 Summary: Hive query with UNION ALL fails with 
ArrayIndexOutOfBoundsException
 Key: HIVE-14006
 URL: https://issues.apache.org/jira/browse/HIVE-14006
 Project: Hive
  Issue Type: Bug
  Components: Hive
Affects Versions: 2.0.0
Reporter: Naveen Gangam


set hive.cbo.enable=false;
DROP VIEW IF EXISTS a_view;

DROP TABLE IF EXISTS table_a1;
DROP TABLE IF EXISTS table_a2;
DROP TABLE IF EXISTS table_b1;
DROP TABLE IF EXISTS table_b2;

CREATE TABLE table_a1
(composite_key STRING);

CREATE TABLE table_a2
(composite_key STRING);

CREATE TABLE table_b1
(composite_key STRING, col1 STRING);

CREATE TABLE table_b2
(composite_key STRING);

CREATE VIEW a_view AS
SELECT
substring(a1.composite_key, 1, locate('|',a1.composite_key) - 1) AS autoname,
NULL AS col1
FROM table_a1 a1
FULL OUTER JOIN table_a2 a2
ON a1.composite_key = a2.composite_key
UNION ALL
SELECT
substring(b1.composite_key, 1, locate('|',b1.composite_key) - 1) AS autoname,
b1.col1 AS col1
FROM table_b1 b1
FULL OUTER JOIN table_b2 b2
ON b1.composite_key = b2.composite_key;

INSERT INTO TABLE table_b1
SELECT * FROM (
SELECT 'something|awful', 'col1'
)s ;

SELECT autoname
FROM a_view
WHERE autoname='something';

fails with 
Diagnostic Messages for this Task:
Error: java.lang.RuntimeException: 
org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error while 
processing row {"_col0":"something"}
at org.apache.hadoop.hive.ql.exec.mr.ExecMapper.map(ExecMapper.java:179)
at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:54)
at org.apache.hadoop.mapred.MapTask.runOldMapper(MapTask.java:453)
at org.apache.hadoop.mapred.MapTask.run(MapTask.java:343)
at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:164)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:415)
at 
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1693)
at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:158)
Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Hive Runtime Error 
while processing row {"_col0":"something"}
at 
org.apache.hadoop.hive.ql.exec.MapOperator.process(MapOperator.java:507)
at org.apache.hadoop.hive.ql.exec.mr.ExecMapper.map(ExecMapper.java:170)
... 8 more
Caused by: java.lang.ArrayIndexOutOfBoundsException: 0
at 
org.apache.hadoop.hive.ql.exec.UnionOperator.processOp(UnionOperator.java:134)
at org.apache.hadoop.hive.ql.exec.Operator.forward(Operator.java:815)
at 
org.apache.hadoop.hive.ql.exec.TableScanOperator.processOp(TableScanOperator.java:95)
at 
org.apache.hadoop.hive.ql.exec.MapOperator$MapOpCtx.forward(MapOperator.java:157)
at 
org.apache.hadoop.hive.ql.exec.MapOperator.process(MapOperator.java:497)

The same query succeeds when {{hive.ppd.remove.duplicatefilters=false}} with or 
without CBO on. It also succeeds with just CBO on.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-13 Thread Sergio Pena

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48233/
---

(Updated June 13, 2016, 6:28 p.m.)


Review request for hive, Mohit Sabharwal and Naveen Gangam.


Changes
---

Addressed feedback changes from Kapil and Reuben.


Bugs: HIVE-13884
https://issues.apache.org/jira/browse/HIVE-13884


Repository: hive-git


Description
---

The patch verifies the # of partitions a table has before fetching any from the 
metastore. I
t checks that limit from 'hive.limit.query.max.table.partition'.

A limitation added here is that the variable must be on hive-site.xml in order 
to work, and it does not accept to set this through beeline because 
HiveMetaStore.java does not read the variables set through beeline. I think it 
is better to keep it this way to avoid users changing the value on fly, and 
crashing the metastore.

Another change is that EXPLAIN commands won't be executed either. EXPLAIN 
commands need to fetch partitions in order to create the operator tree. If we 
allow EXPLAIN to do that, then we may have the same OOM situations for large 
partitions.


Diffs (updated)
-

  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
c0827ea9d47e569d9697649a7e16d196de3de14d 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 
c135179b97354108f842a5ca2de0c6f0ef28b7fc 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
f98de1326956b19b9d28fc9b1fcdede8d851180d 
  metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 
a6d3f5385b33b8a4e31ee20ca5cb8f58c97c8702 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 
31f0d7b89670b8a749bbe8a7ff2b4ff9f059a8e2 
  
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
 3152e77c3c7152ac4dbe7e779ce35f28044fe3c9 
  
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
 86a243609b23e2ca9bb8849f0da863a95e477d5c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
cd3c86064df3e7febcc16e03aab6ce407e0dc8a0 

Diff: https://reviews.apache.org/r/48233/diff/


Testing
---

Waiting for HiveQA.


Thanks,

Sergio Pena



[jira] [Created] (HIVE-14005) Changing a string column of ORC table to boolean change values to be 'NULL'

2016-06-13 Thread Takahiko Saito (JIRA)
Takahiko Saito created HIVE-14005:
-

 Summary: Changing a string column of ORC table to boolean change 
values to be 'NULL'
 Key: HIVE-14005
 URL: https://issues.apache.org/jira/browse/HIVE-14005
 Project: Hive
  Issue Type: Bug
  Components: Hive
Affects Versions: 2.1.1
Reporter: Takahiko Saito


{noformat]
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2>
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2> set 
hive.metastore.disallow.incompatible.col.type.changes=false;
No rows affected (0.015 seconds)
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2>
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2> set 
hive.exec.dynamic.partition.mode=nonstrict;
No rows affected (0.003 seconds)
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2>
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2> drop table test;
No rows affected (0.224 seconds)
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2>
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2> create table test (s string) 
stored as orc;
No rows affected (0.098 seconds)
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2>
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2> insert into table test values 
('true');
No rows affected (1.091 seconds)
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2>
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2> select * from test;
+-+--+
| test.s  |
+-+--+
| true|
+-+--+
1 row selected (0.114 seconds)
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2>
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2> alter table test change column s 
s boolean;
No rows affected (0.167 seconds)
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2>
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2> select * from test;
+-+--+
| test.s  |
+-+--+
| NULL|
+-+--+
1 row selected (0.098 seconds)
{noformat}

The issue is NOT seen with textfile formatted table:
{noformat}
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2> set 
hive.metastore.disallow.incompatible.col.type.changes=false;
No rows affected (0.013 seconds)
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2>
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2> set 
hive.exec.dynamic.partition.mode=nonstrict;
No rows affected (0.006 seconds)
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2>
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2> drop table test;
No rows affected (0.224 seconds)
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2>
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2> create table test (s string) 
stored as textfile;
No rows affected (0.116 seconds)
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2>
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2> insert into table test values 
('true');
No rows affected (1.799 seconds)
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2>
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2> select * from test;
+-+--+
| test.s  |
+-+--+
| true|
+-+--+
1 row selected (0.085 seconds)
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2>
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2> alter table test change column s 
s boolean;
No rows affected (0.141 seconds)
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2>
0: jdbc:hive2://os-r7-rcmpc-nat-u-hiveserver2> select * from test;
+-+--+
| test.s  |
+-+--+
| true|
+-+--+
1 row selected (0.093 seconds)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-13 Thread Sergio Pena


> On June 9, 2016, 3:18 p.m., Reuben Kuhnert wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java, line 
> > 2830
> > 
> >
> > Maybe StringUtils.isEmpty? I think it will do both of these checks for 
> > you.

Seems I need to add a new mvn dependency for that. I will skip it for now.


- Sergio


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48233/#review136810
---


On June 6, 2016, 6:19 p.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48233/
> ---
> 
> (Updated June 6, 2016, 6:19 p.m.)
> 
> 
> Review request for hive, Mohit Sabharwal and Naveen Gangam.
> 
> 
> Bugs: HIVE-13884
> https://issues.apache.org/jira/browse/HIVE-13884
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The patch verifies the # of partitions a table has before fetching any from 
> the metastore. I
> t checks that limit from 'hive.limit.query.max.table.partition'.
> 
> A limitation added here is that the variable must be on hive-site.xml in 
> order to work, and it does not accept to set this through beeline because 
> HiveMetaStore.java does not read the variables set through beeline. I think 
> it is better to keep it this way to avoid users changing the value on fly, 
> and crashing the metastore.
> 
> Another change is that EXPLAIN commands won't be executed either. EXPLAIN 
> commands need to fetch partitions in order to create the operator tree. If we 
> allow EXPLAIN to do that, then we may have the same OOM situations for large 
> partitions.
> 
> 
> Diffs
> -
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
> 94dd72e6624d13d2503f68d2fd2d2a84859a4500 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 
> 8e0bba60cc73890c1566e0f5df965f0f0bcfe0ec 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
> b6d5276e49356f30147cb4f10262a2730ba99566 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 
> a6d3f5385b33b8a4e31ee20ca5cb8f58c97c8702 
>   metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 
> 31f0d7b89670b8a749bbe8a7ff2b4ff9f059a8e2 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
>  3152e77c3c7152ac4dbe7e779ce35f28044fe3c9 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
>  86a243609b23e2ca9bb8849f0da863a95e477d5c 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> c3d903b8cc8197ba8bea17145bec1444ed14eb22 
> 
> Diff: https://reviews.apache.org/r/48233/diff/
> 
> 
> Testing
> ---
> 
> Waiting for HiveQA.
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>



Review Request 48656: HIVE-13958: Support prohibiting string to decimal auto-casts.

2016-06-13 Thread Takuma Wakamori

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48656/
---

Review request for hive.


Repository: hive-git


Description
---

HIVE-13958: Support prohibiting string to decimal auto-casts.


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java 
aef46da4564808fd2c17fdd0a1cab442366587a3 
  ql/src/test/queries/clientnegative/compare_double_bigint_between.q 
PRE-CREATION 
  ql/src/test/queries/clientnegative/compare_double_bigint_in.q PRE-CREATION 
  ql/src/test/queries/clientnegative/compare_string_bigint.q 
810f65d4d2b448b99cdb8907c016e36b1d9e276e 
  ql/src/test/queries/clientnegative/compare_string_bigint_between.q 
PRE-CREATION 
  ql/src/test/queries/clientnegative/compare_string_bigint_in.q PRE-CREATION 
  ql/src/test/results/clientnegative/compare_double_bigint_between.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/compare_double_bigint_in.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/compare_string_bigint3.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/compare_string_bigint_between.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/compare_string_bigint_in.q.out 
PRE-CREATION 

Diff: https://reviews.apache.org/r/48656/diff/


Testing
---


Thanks,

Takuma Wakamori



[jira] [Created] (HIVE-14004) Minor compaction produces ArrayIndexOutOfBoundsException: 7 in SchemaEvolution.getFileType

2016-06-13 Thread Eugene Koifman (JIRA)
Eugene Koifman created HIVE-14004:
-

 Summary: Minor compaction produces ArrayIndexOutOfBoundsException: 
7 in SchemaEvolution.getFileType
 Key: HIVE-14004
 URL: https://issues.apache.org/jira/browse/HIVE-14004
 Project: Hive
  Issue Type: Bug
  Components: Transactions
Affects Versions: 2.2.0
Reporter: Eugene Koifman
Assignee: Eugene Koifman


Easiest way to repro is to add TestTxnCommands2
{noformat}
  @Test
  public void testCompactWithDelete() throws Exception {
int[][] tableData = {{1,2},{3,4}};
runStatementOnDriver("insert into " + Table.ACIDTBL + "(a,b) " + 
makeValuesClause(tableData));
runStatementOnDriver("alter table "+ Table.ACIDTBL + " compact 'MAJOR'");
Worker t = new Worker();
t.setThreadId((int) t.getId());
t.setHiveConf(hiveConf);
AtomicBoolean stop = new AtomicBoolean();
AtomicBoolean looped = new AtomicBoolean();
stop.set(true);
t.init(stop, looped);
t.run();
runStatementOnDriver("delete from " + Table.ACIDTBL + " where b = 4");
runStatementOnDriver("update " + Table.ACIDTBL + " set b = -2 where b = 2");
runStatementOnDriver("alter table "+ Table.ACIDTBL + " compact 'MINOR'");
t.run();
  }
{noformat}
to TestTxnCommands2 and run it.
Test won't fail but if you look 
in target/tmp/log/hive.log for the following exception (from Minor compaction).


{noformat}
2016-06-09T18:36:39,071 WARN  [Thread-190[]]: mapred.LocalJobRunner 
(LocalJobRunner.java:run(560)) - job_local1233973168_0005
java.lang.Exception: java.lang.ArrayIndexOutOfBoundsException: 7
at 
org.apache.hadoop.mapred.LocalJobRunner$Job.runTasks(LocalJobRunner.java:462) 
~[hadoop-mapreduce-client-common-2.6.1.jar:?]
at 
org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:522) 
[hadoop-mapreduce-client-common-2.6.1.jar:?]
Caused by: java.lang.ArrayIndexOutOfBoundsException: 7
at 
org.apache.orc.impl.SchemaEvolution.getFileType(SchemaEvolution.java:67) 
~[hive-orc-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at 
org.apache.orc.impl.TreeReaderFactory.createTreeReader(TreeReaderFactory.java:2031)
 ~[hive-orc-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at 
org.apache.orc.impl.TreeReaderFactory$StructTreeReader.(TreeReaderFactory.java:1716)
 ~[hive-orc-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at 
org.apache.orc.impl.TreeReaderFactory.createTreeReader(TreeReaderFactory.java:2077)
 ~[hive-orc-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at 
org.apache.orc.impl.TreeReaderFactory$StructTreeReader.(TreeReaderFactory.java:1716)
 ~[hive-orc-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at 
org.apache.orc.impl.TreeReaderFactory.createTreeReader(TreeReaderFactory.java:2077)
 ~[hive-orc-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at 
org.apache.orc.impl.RecordReaderImpl.(RecordReaderImpl.java:208) 
~[hive-orc-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.io.orc.RecordReaderImpl.(RecordReaderImpl.java:63)
 ~[classes/:?]
at 
org.apache.hadoop.hive.ql.io.orc.ReaderImpl.rowsOptions(ReaderImpl.java:365) 
~[classes/:?]
at 
org.apache.hadoop.hive.ql.io.orc.OrcRawRecordMerger$ReaderPair.(OrcRawRecordMerger.java:207)
 ~[classes/:?]
at 
org.apache.hadoop.hive.ql.io.orc.OrcRawRecordMerger.(OrcRawRecordMerger.java:508)
 ~[classes/:?]
at 
org.apache.hadoop.hive.ql.io.orc.OrcInputFormat.getRawReader(OrcInputFormat.java:1977)
 ~[classes/:?]
at 
org.apache.hadoop.hive.ql.txn.compactor.CompactorMR$CompactorMap.map(CompactorMR.java:630)
 ~[classes/:?]
at 
org.apache.hadoop.hive.ql.txn.compactor.CompactorMR$CompactorMap.map(CompactorMR.java:609)
 ~[classes/:?]
at org.apache.hadoop.mapred.MapRunner.run(MapRunner.java:54) 
~[hadoop-mapreduce-client-core-2.6.1.jar:?]
at org.apache.hadoop.mapred.MapTask.runOldMapper(MapTask.java:450) 
~[hadoop-mapreduce-client-core-2.6.1.jar:?]
at org.apache.hadoop.mapred.MapTask.run(MapTask.java:343) 
~[hadoop-mapreduce-client-core-2.6.1.jar:?]
at 
org.apache.hadoop.mapred.LocalJobRunner$Job$MapTaskRunnable.run(LocalJobRunner.java:243)
 ~[hadoop-mapreduce-client-common-2.6.1.jar:?]
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) 
~[?:1.7.0_71]
at java.util.concurrent.FutureTask.run(FutureTask.java:262) 
~[?:1.7.0_71]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) 
~[?:1.7.0_71]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) 
~[?:1.7.0_71]
at java.lang.Thread.run(Thread.java:745) ~[?:1.7.0_71]
{noformat}

I observed the same on a real cluster.

Based on my observations, running Major compaction instead of minor, works fine.
Replacing the DELETE operation with update, makes both Major/Minor run fine.

The issue itself should be addressed by HIVE-13974 but need to make 

Re: Review Request 48233: HIVE-13884: Disallow queries fetching more than a configured number of partitions in PartitionPruner

2016-06-13 Thread Sergio Pena


> On June 10, 2016, 4:31 a.m., Kapil Rastogi wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, 
> > line 3176
> > 
> >
> > what is the default for getIntVar if the configuration doesn't exist. 
> > -1, 0?

It is -1, and is defined on HiveConf.

HIVELIMITTABLESCANPARTITION("hive.limit.query.max.table.partition", -1,
"This controls how many partitions can be scanned for each partitioned 
table.\n" +
"The default value \"-1\" means no limit."),


- Sergio


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48233/#review136927
---


On June 6, 2016, 6:19 p.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48233/
> ---
> 
> (Updated June 6, 2016, 6:19 p.m.)
> 
> 
> Review request for hive, Mohit Sabharwal and Naveen Gangam.
> 
> 
> Bugs: HIVE-13884
> https://issues.apache.org/jira/browse/HIVE-13884
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The patch verifies the # of partitions a table has before fetching any from 
> the metastore. I
> t checks that limit from 'hive.limit.query.max.table.partition'.
> 
> A limitation added here is that the variable must be on hive-site.xml in 
> order to work, and it does not accept to set this through beeline because 
> HiveMetaStore.java does not read the variables set through beeline. I think 
> it is better to keep it this way to avoid users changing the value on fly, 
> and crashing the metastore.
> 
> Another change is that EXPLAIN commands won't be executed either. EXPLAIN 
> commands need to fetch partitions in order to create the operator tree. If we 
> allow EXPLAIN to do that, then we may have the same OOM situations for large 
> partitions.
> 
> 
> Diffs
> -
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
> 94dd72e6624d13d2503f68d2fd2d2a84859a4500 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 
> 8e0bba60cc73890c1566e0f5df965f0f0bcfe0ec 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
> b6d5276e49356f30147cb4f10262a2730ba99566 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 
> a6d3f5385b33b8a4e31ee20ca5cb8f58c97c8702 
>   metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 
> 31f0d7b89670b8a749bbe8a7ff2b4ff9f059a8e2 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
>  3152e77c3c7152ac4dbe7e779ce35f28044fe3c9 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
>  86a243609b23e2ca9bb8849f0da863a95e477d5c 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> c3d903b8cc8197ba8bea17145bec1444ed14eb22 
> 
> Diff: https://reviews.apache.org/r/48233/diff/
> 
> 
> Testing
> ---
> 
> Waiting for HiveQA.
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>



Re: Review Request 48520: Use multi-threaded approach to listing files for msck

2016-06-13 Thread pengcheng xiong

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48520/
---

(Updated June 13, 2016, 4:57 p.m.)


Review request for hive and Hari Sankar Sivarama Subramaniyan.


Changes
---

Address Rajesh and Hari's comments.


Repository: hive-git


Description
---

HIVE-13984


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 285caa3 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java 
10fa561 

Diff: https://reviews.apache.org/r/48520/diff/


Testing
---


Thanks,

pengcheng xiong



Re: Review Request 48520: Use multi-threaded approach to listing files for msck

2016-06-13 Thread pengcheng xiong


> On June 11, 2016, 1:06 a.m., Hari Sankar Sivarama Subramaniyan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java, 
> > line 385
> > 
> >
> > My bad for the not catching this earlier. Realized this could be 
> > dangerous as it is inside a recursive call. For each level of the 
> > directory, you are creating a new thread pool, which means that you can 
> > potentially go all the way to create (#THREADS)^(#levels) worker threads 
> > instead of (#THREADS) and effectively choke the system. You need to share 
> > the thread pool amongst all the recursive calls, so that way you dont 
> > create a new pool for each level of recursion.

No, pool is closed at the end of each level. Thus, it will not be 
(#THREADS)^(#levels) but (#THREADS). Moreover, as Rajesh points out, i will 
make them to share the pool.


- pengcheng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48520/#review137096
---


On June 10, 2016, 11:58 p.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48520/
> ---
> 
> (Updated June 10, 2016, 11:58 p.m.)
> 
> 
> Review request for hive and Hari Sankar Sivarama Subramaniyan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-13984
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 285caa3 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java 
> 10fa561 
> 
> Diff: https://reviews.apache.org/r/48520/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>



Re: Review Request 48520: Use multi-threaded approach to listing files for msck

2016-06-13 Thread pengcheng xiong


> On June 11, 2016, 12:43 a.m., Rajesh Balamohan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java, 
> > line 383
> > 
> >
> > May be we can create HIVE_LIST_FILES_THREAD_COUNT which can have a min 
> > thread of 1. So that way, we dont need to maintain serial codepath.

AFAIK, there is no solution to prevent the user from setting it as 0 or 
negative number?


> On June 11, 2016, 12:43 a.m., Rajesh Balamohan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java, 
> > line 384
> > 
> >
> > This can be passed from previous function to avoid creating executor 
> > pool, in case of recursion at the end of this method.

Good point. Thanks.


- pengcheng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48520/#review136987
---


On June 10, 2016, 11:58 p.m., pengcheng xiong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48520/
> ---
> 
> (Updated June 10, 2016, 11:58 p.m.)
> 
> 
> Review request for hive and Hari Sankar Sivarama Subramaniyan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-13984
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 285caa3 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java 
> 10fa561 
> 
> Diff: https://reviews.apache.org/r/48520/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>



[jira] [Created] (HIVE-14003) queries running against llap hang at times - likely due to preemption'

2016-06-13 Thread Takahiko Saito (JIRA)
Takahiko Saito created HIVE-14003:
-

 Summary: queries running against llap hang at times - likely due 
to preemption'
 Key: HIVE-14003
 URL: https://issues.apache.org/jira/browse/HIVE-14003
 Project: Hive
  Issue Type: Bug
  Components: llap
Affects Versions: 2.1.0
Reporter: Takahiko Saito


The preemption logic in the Hive processor needs some more work. There are 
definitely windows where the abort flag is completely dropped within the Hive 
processor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-14002) Extend limit propagation to subsequent RS operators

2016-06-13 Thread Nita Dembla (JIRA)
Nita Dembla created HIVE-14002:
--

 Summary: Extend limit propagation to subsequent RS operators
 Key: HIVE-14002
 URL: https://issues.apache.org/jira/browse/HIVE-14002
 Project: Hive
  Issue Type: Bug
  Components: Hive
Affects Versions: 2.2.0
Reporter: Nita Dembla
Priority: Blocker






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (HIVE-14001) beeline doesn't give out an error when takes either "-e" or "-f" in command instead of both

2016-06-13 Thread Peter Vary (JIRA)
Peter Vary created HIVE-14001:
-

 Summary: beeline doesn't give out an error when takes either "-e" 
or "-f" in command instead of both
 Key: HIVE-14001
 URL: https://issues.apache.org/jira/browse/HIVE-14001
 Project: Hive
  Issue Type: Improvement
  Components: Beeline
Affects Versions: 2.0.1, 0.10.0
Reporter: Peter Vary
Priority: Trivial


When providing both arguments there should be an error message



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 48500: HIVE-13982

2016-06-13 Thread Jesús Camacho Rodríguez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48500/
---

(Updated June 13, 2016, 12:06 p.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-13982
https://issues.apache.org/jira/browse/HIVE-13982


Repository: hive-git


Description
---

HIVE-13982


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
 353d8db41af10512c94c0700a9bb06a07d660190 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java
 1c3eb8155defa99a223ccf4ee4b072abb40a 
  ql/src/test/queries/clientpositive/limit_pushdown2.q PRE-CREATION 
  ql/src/test/results/clientpositive/bucket_groupby.q.out 
e198617c82b8ab4c3ad3d8b255975413fbdc382d 
  ql/src/test/results/clientpositive/limit_pushdown2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/lineage3.q.out 
12ae13e388b3cb9c051cb419b75682fa4296d211 
  ql/src/test/results/clientpositive/perf/query45.q.out 
04f9b02b019b6cf591dee48964a73fdb4a4b285f 
  ql/src/test/results/clientpositive/spark/vectorization_14.q.out 
cb3d9a4da84a379e00550ce7e31893b304d5e560 
  ql/src/test/results/clientpositive/tez/explainuser_1.q.out 
1871c7e443cf775b09badc4cbf4b86e23ad9e525 
  ql/src/test/results/clientpositive/tez/explainuser_2.q.out 
553066039881f225634c08d93a9054df5636e5d2 
  ql/src/test/results/clientpositive/tez/vector_groupby_reduce.q.out 
7f00b064e5a91b45282823e2725e11ab7f508b01 
  ql/src/test/results/clientpositive/tez/vectorization_14.q.out 
2a598332207f4540defa21a107642aa0502e1a58 
  ql/src/test/results/clientpositive/vector_groupby_reduce.q.out 
bc23b365b02b505d0f8e79cdacca3449bf46ead3 
  ql/src/test/results/clientpositive/vectorization_14.q.out 
6d4f13a23de5c184cd100af07ac19f24ba9fac4a 

Diff: https://reviews.apache.org/r/48500/diff/


Testing
---


Thanks,

Jesús Camacho Rodríguez