> On June 11, 2016, 1:06 a.m., Hari Sankar Sivarama Subramaniyan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java, > > line 385 > > <https://reviews.apache.org/r/48520/diff/2/?file=1415364#file1415364line385> > > > > My bad for the not catching this earlier. Realized this could be > > dangerous as it is inside a recursive call. For each level of the > > directory, you are creating a new thread pool, which means that you can > > potentially go all the way to create (#THREADS)^(#levels) worker threads > > instead of (#THREADS) and effectively choke the system. You need to share > > the thread pool amongst all the recursive calls, so that way you dont > > create a new pool for each level of recursion.
No, pool is closed at the end of each level. Thus, it will not be (#THREADS)^(#levels) but (#THREADS). Moreover, as Rajesh points out, i will make them to share the pool. - pengcheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48520/#review137096 ----------------------------------------------------------- On June 10, 2016, 11:58 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48520/ > ----------------------------------------------------------- > > (Updated June 10, 2016, 11:58 p.m.) > > > Review request for hive and Hari Sankar Sivarama Subramaniyan. > > > Repository: hive-git > > > Description > ------- > > HIVE-13984 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 285caa3 > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java > 10fa561 > > Diff: https://reviews.apache.org/r/48520/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
