Re: Review Request 63442: HIVE-17934 Merging Statistics are promoted to COMPLETE (most of the time)

2017-11-09 Thread Zoltan Haindrich


> On Nov. 9, 2017, 7:51 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/lateral_view_onview.q.out
> > Lines 234-239 (original), 234-239 (patched)
> > 
> >
> > Do we expect this to change? Basic stats are complete for all operators 
> > prior to it.

the reason behind this change is that stats for constants in an `array()` is 
`0`.

https://issues.apache.org/jira/browse/HIVE-18005 should address that


> On Nov. 9, 2017, 7:51 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_12.q.out
> > Line 160 (original), 160 (patched)
> > 
> >
> > bucket_small has no stats gathered. This should be NONE.

`hive.stats.autogather` is enabled by default from `HiveConf`


> On Nov. 9, 2017, 7:51 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_12.q.out
> > Line 238 (original), 238 (patched)
> > 
> >
> > bucket_medium has no stats gathered. This should be NONE.

`hive.stats.autogather` is enabled by default from `HiveConf`


> On Nov. 9, 2017, 7:51 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_12.q.out
> > Line 316 (original), 316 (patched)
> > 
> >
> > bucket_big has no stats gathered. This should be NONE.

`hive.stats.autogather` is enabled by default from `HiveConf`


> On Nov. 9, 2017, 7:51 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out
> > Line 193 (original), 193 (patched)
> > 
> >
> > srcpart_small has all stats. Infact, even column stats. Should be 
> > complete for both.

these problems arise from the fact that `srcpart_small` has an explicitly added 
empty partition 
https://github.com/kgyrtkirk/hive/blob/HIVE-17934-stats-partial/ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q#L25

and earlier the `downgrade` of the stat state were lost;

In this case especially I think the state would be better to be `COMPLETE`, so 
I've opened https://issues.apache.org/jira/browse/HIVE-18033 to address the 
empty table issues separetly.


> On Nov. 9, 2017, 7:51 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_sw.q.out
> > Line 322 (original), 322 (patched)
> > 
> >
> > srcpart_small has both basic as well as column stats.

explicit empty partition


> On Nov. 9, 2017, 7:51 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/dynamic_semijoin_user_level.q.out
> > Line 185 (original), 185 (patched)
> > 
> >
> > srcpoart_small has both table and col stats.

explicit empty partition


> On Nov. 9, 2017, 7:51 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/dynpart_sort_optimization_acid.q.out
> > Line 894 (original), 894 (patched)
> > 
> >
> > This table has basic stats.

the previous operation on this table was a delete; 
https://github.com/kgyrtkirk/hive/blob/HIVE-17934-stats-partial/ql/src/test/results/clientpositive/llap/dynpart_sort_optimization_acid.q.out#L849-L859
so I consider the degradation of the basic stat state in this case as an 
improvement.


> On Nov. 9, 2017, 7:51 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/llap_nullscan.q.out
> > Line 204 (original), 204 (patched)
> > 
> >
> > Basic stats state should be complete.

one of the inputs to this merge is marked as `NONE`; 
https://issues.apache.org/jira/browse/HIVE-18032 will probably make this go away


> On Nov. 9, 2017, 7:51 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/mapjoin_hint.q.out
> > Line 167 (original), 167 (patched)
> > 
> >
> > It has both basic and col stats.

`srcpart_small` has an empty partition


> On Nov. 9, 2017, 7:51 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/metadataonly1.q.out
> > Line 123 (original), 123 (patched)
> > 
> >
> > Basic stats should be complete. Since with create table we set stats 
> > with complete. However, for column stats it should be None.

basic stats: the table has an explictly added empty partition prior to this 
command

columns stats are 

Re: Review Request 63711: HIVE-17528 Add more q-tests for Hive-on-Spark with Parquet vectorized reader

2017-11-09 Thread cheng xu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63711/
---

(Updated Nov. 10, 2017, 1:18 p.m.)


Review request for hive and Vihang Karajgaonkar.


Repository: hive-git


Description
---

Most of the vectorization related q-tests operate on ORC tables using Tez. It 
would be good to add more coverage on a different combination of engine and 
file-format. We can model existing q-tests using parquet tables and run it 
using TestSparkCliDriver


Diffs (updated)
-

  data/scripts/q_test_cleanup.sql 4620dcd 
  data/scripts/q_test_init.sql f763c12 
  itests/src/test/resources/testconfiguration.properties 1d16b65 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java f1d90ff 
  pom.xml dfb29ce 
  ql/src/test/queries/clientpositive/parquet_vectorization_0.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_10.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_11.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_12.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_13.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_14.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_15.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_16.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_17.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_3.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_4.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_5.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_6.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_7.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_8.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_9.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_decimal_date.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_div0.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_limit.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_nested_udf.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_not.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_offset_limit.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_part.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_part_project.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_part_varchar.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_pushdown.q 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_0.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_10.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_11.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_12.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_13.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_14.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_15.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_16.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_17.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_3.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_4.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_5.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_6.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_7.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_8.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_9.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_decimal_date.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_div0.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_limit.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_nested_udf.q.out 
PRE-CREATION 
  

[jira] [Created] (HIVE-18041) Add SORT_QUERY_RESULTS to subquery_multi

2017-11-09 Thread Rui Li (JIRA)
Rui Li created HIVE-18041:
-

 Summary: Add SORT_QUERY_RESULTS to subquery_multi
 Key: HIVE-18041
 URL: https://issues.apache.org/jira/browse/HIVE-18041
 Project: Hive
  Issue Type: Test
Reporter: Rui Li
Priority: Trivial






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (HIVE-18040) the index can't be deleted if we make the table and the index are in the different databases.

2017-11-09 Thread iBenny (JIRA)
iBenny created HIVE-18040:
-

 Summary:  the index can't be deleted if we make the table and the 
index are in the different databases.
 Key: HIVE-18040
 URL: https://issues.apache.org/jira/browse/HIVE-18040
 Project: Hive
  Issue Type: Bug
Affects Versions: 1.2.1
Reporter: iBenny


If we made the table and the index are in the different databases, for example: 
create table db1.t -> create index t_i on db1.t -> rename db1.t to db2.t. In 
this case this knid of index can't be deleted successfully.

Workaround:
* Created the same index table in db1 (using create table t1 as select * from).
* DROPPED the index using HIVE CLI (did not work via Beeline or HUE).
* DROPPED the newly created indexed table on db1.
* Checked the index - it was gone.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (HIVE-18039) Use ConcurrentHashMap for CachedStore

2017-11-09 Thread Alexander Kolbasov (JIRA)
Alexander Kolbasov created HIVE-18039:
-

 Summary: Use ConcurrentHashMap for CachedStore
 Key: HIVE-18039
 URL: https://issues.apache.org/jira/browse/HIVE-18039
 Project: Hive
  Issue Type: Improvement
  Components: Hive
Affects Versions: 3.0.0
Reporter: Alexander Kolbasov


SharedCache used by CachedStore uses single big lock to synchronize all access. 
This looks like an overkill - looks like it is possible to use 
ConcurrentHashMap instead. Also it makes sense to move deepCopy() operations 
outside the lock to reduce lock hold times.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: Review Request 63711: HIVE-17528 Add more q-tests for Hive-on-Spark with Parquet vectorized reader

2017-11-09 Thread cheng xu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63711/
---

(Updated Nov. 10, 2017, 9:45 a.m.)


Review request for hive and Vihang Karajgaonkar.


Repository: hive-git


Description
---

Most of the vectorization related q-tests operate on ORC tables using Tez. It 
would be good to add more coverage on a different combination of engine and 
file-format. We can model existing q-tests using parquet tables and run it 
using TestSparkCliDriver


Diffs (updated)
-

  data/scripts/q_test_cleanup.sql 4620dcd 
  data/scripts/q_test_init.sql f763c12 
  itests/src/test/resources/testconfiguration.properties 1d16b65 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java f1d90ff 
  pom.xml dfb29ce 
  ql/src/test/queries/clientpositive/parquet_vectorization_0.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_10.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_11.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_12.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_13.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_14.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_15.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_16.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_17.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_3.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_4.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_5.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_6.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_7.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_8.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_9.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_decimal_date.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_div0.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_limit.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_nested_udf.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_not.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_offset_limit.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_part.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_part_project.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_part_varchar.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_pushdown.q 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_0.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_10.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_11.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_12.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_13.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_14.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_15.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_16.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_17.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_3.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_4.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_5.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_6.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_7.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_8.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_9.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_decimal_date.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_div0.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_limit.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_nested_udf.q.out 
PRE-CREATION 
  

Re: Review Request 63711: HIVE-17528 Add more q-tests for Hive-on-Spark with Parquet vectorized reader

2017-11-09 Thread cheng xu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63711/
---

(Updated Nov. 10, 2017, 9:39 a.m.)


Review request for hive and Vihang Karajgaonkar.


Repository: hive-git


Description
---

Most of the vectorization related q-tests operate on ORC tables using Tez. It 
would be good to add more coverage on a different combination of engine and 
file-format. We can model existing q-tests using parquet tables and run it 
using TestSparkCliDriver


Diffs (updated)
-

  data/scripts/q_test_cleanup.sql 4620dcd 
  data/scripts/q_test_init.sql f763c12 
  itests/src/test/resources/testconfiguration.properties 1d16b65 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java f1d90ff 
  pom.xml dfb29ce 
  ql/src/test/queries/clientpositive/parquet_vectorization_0.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_10.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_11.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_12.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_13.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_14.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_15.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_16.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_17.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_3.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_4.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_5.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_6.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_7.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_8.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_9.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_decimal_date.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_div0.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_limit.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_nested_udf.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_not.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_offset_limit.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_part.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_part_project.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_part_varchar.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_pushdown.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_short_regress.q 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_0.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_10.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_11.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_12.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_13.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_14.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_15.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_16.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_17.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_3.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_4.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_5.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_6.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_7.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_8.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_9.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_decimal_date.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_div0.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/parquet_vectorization_limit.q.out 
PRE-CREATION 
  

[jira] [Created] (HIVE-18038) org.apache.hadoop.hive.ql.session.OperationLog - Review

2017-11-09 Thread BELUGA BEHR (JIRA)
BELUGA BEHR created HIVE-18038:
--

 Summary: org.apache.hadoop.hive.ql.session.OperationLog - Review
 Key: HIVE-18038
 URL: https://issues.apache.org/jira/browse/HIVE-18038
 Project: Hive
  Issue Type: Improvement
  Components: HiveServer2
Affects Versions: 3.0.0
Reporter: BELUGA BEHR
Priority: Trivial


Simplifications, improve readability



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Review Request 63711: HIVE-17528 Add more q-tests for Hive-on-Spark with Parquet vectorized reader

2017-11-09 Thread cheng xu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63711/
---

Review request for hive and Vihang Karajgaonkar.


Repository: hive-git


Description
---

Most of the vectorization related q-tests operate on ORC tables using Tez. It 
would be good to add more coverage on a different combination of engine and 
file-format. We can model existing q-tests using parquet tables and run it 
using TestSparkCliDriver


Diffs
-

  data/scripts/q_test_cleanup.sql 4620dcd 
  data/scripts/q_test_init.sql f763c12 
  itests/src/test/resources/testconfiguration.properties 42c17f4 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java f1d90ff 
  pom.xml 006e8f8 
  ql/src/test/queries/clientpositive/parquet_vectorization_0.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_10.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_11.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_12.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_13.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_14.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_15.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_16.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_17.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_3.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_4.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_5.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_6.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_7.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_8.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_9.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_decimal_date.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_div0.q PRE-CREATION 
  
ql/src/test/queries/clientpositive/parquet_vectorization_input_format_excludes.q
 PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_limit.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_nested_udf.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_not.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_offset_limit.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_parquet_projection.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_part.q PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_part_project.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_part_varchar.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_pushdown.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/parquet_vectorization_short_regress.q 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_0.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_1.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_10.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_11.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_12.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_13.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_14.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_15.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_16.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_17.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_2.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_3.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_4.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_5.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_6.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_7.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_8.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/spark/parquet_vectorization_9.q.out 
PRE-CREATION 
  

[VOTE] Apache Hive 2.3.2 Release Candidate 0

2017-11-09 Thread Sahil Takiar
Apache Hive 2.3.2 Release Candidate 0 is available here:
http://people.apache.org/~stakiar/hive-2.3.2/

Maven artifacts are available here:
https://repository.apache.org/content/repositories/orgapachehive-1082/

Source tag for RCN is at:https://github.com/apache/hive/tree/release-2.3.2

Voting will conclude in 72 hours.

Hive PMC Members: Please test and vote.

Thanks.


[jira] [Created] (HIVE-18037) Migrate Slider LLAP package to YARN Service framework for Hadoop 3.x

2017-11-09 Thread Gour Saha (JIRA)
Gour Saha created HIVE-18037:


 Summary: Migrate Slider LLAP package to YARN Service framework for 
Hadoop 3.x
 Key: HIVE-18037
 URL: https://issues.apache.org/jira/browse/HIVE-18037
 Project: Hive
  Issue Type: Sub-task
Reporter: Gour Saha
 Fix For: 3.0.0


Apache Slider has been migrated to Hadoop-3.x and is referred to as YARN 
Service (YARN-4692). Most of the classic Slider features are now going to be 
supported in a first-class manner by core YARN. It includes several new 
features like a RESTful API. Command line equivalents of classic Slider are 
supported by YARN Service as well.

This jira will take care of all changes required to Slider LLAP packaging and 
scripts to make it work against Hadoop 3.x.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: Review Request 63533: HIVE-17906 use kill query mechanics to kill queries in WM

2017-11-09 Thread Sergey Shelukhin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63533/
---

(Updated Nov. 9, 2017, 10:33 p.m.)


Review request for hive and Prasanth_J.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java 03a068257e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java 0dd1433a6c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
16f5dce10a 
  ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
84a35cc78c 


Diff: https://reviews.apache.org/r/63533/diff/4/

Changes: https://reviews.apache.org/r/63533/diff/3-4/


Testing
---


Thanks,

Sergey Shelukhin



Re: Review Request 63533: HIVE-17906 use kill query mechanics to kill queries in WM

2017-11-09 Thread Sergey Shelukhin


> On Nov. 9, 2017, 2:05 a.m., Prasanth_J wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
> > Lines 494 (patched)
> > 
> >
> > why are we putting back if NOT_FOUND? should this be destroyed instead? 
> > this session will still be NOT_FOUND in next iteration of event processing 
> > right?

No, it closes the old session and opens a new one


- Sergey


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63533/#review190530
---


On Nov. 8, 2017, 9:12 p.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63533/
> ---
> 
> (Updated Nov. 8, 2017, 9:12 p.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java 
> fa0eedb1e2 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java 0dd1433a6c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
> 169991c639 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
> 0347e914bc 
> 
> 
> Diff: https://reviews.apache.org/r/63533/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>



Re: Review Request 63442: HIVE-17934 Merging Statistics are promoted to COMPLETE (most of the time)

2017-11-09 Thread Ashutosh Chauhan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63442/#review190633
---




ql/src/test/results/clientpositive/lateral_view_onview.q.out
Lines 234-239 (original), 234-239 (patched)


Do we expect this to change? Basic stats are complete for all operators 
prior to it.



ql/src/test/results/clientpositive/llap/auto_sortmerge_join_12.q.out
Line 160 (original), 160 (patched)


bucket_small has no stats gathered. This should be NONE.



ql/src/test/results/clientpositive/llap/auto_sortmerge_join_12.q.out
Line 238 (original), 238 (patched)


bucket_medium has no stats gathered. This should be NONE.



ql/src/test/results/clientpositive/llap/auto_sortmerge_join_12.q.out
Line 316 (original), 316 (patched)


bucket_big has no stats gathered. This should be NONE.



ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out
Line 193 (original), 193 (patched)


srcpart_small has all stats. Infact, even column stats. Should be complete 
for both.



ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_sw.q.out
Line 322 (original), 322 (patched)


srcpart_small has both basic as well as column stats.



ql/src/test/results/clientpositive/llap/dynamic_semijoin_user_level.q.out
Line 185 (original), 185 (patched)


srcpoart_small has both table and col stats.



ql/src/test/results/clientpositive/llap/dynpart_sort_optimization_acid.q.out
Line 894 (original), 894 (patched)


This table has basic stats.



ql/src/test/results/clientpositive/llap/llap_nullscan.q.out
Line 204 (original), 204 (patched)


Basic stats state should be complete.



ql/src/test/results/clientpositive/llap/mapjoin_hint.q.out
Line 167 (original), 167 (patched)


It has both basic and col stats.



ql/src/test/results/clientpositive/llap/metadataonly1.q.out
Line 123 (original), 123 (patched)


Basic stats should be complete. Since with create table we set stats with 
complete. However, for column stats it should be None.


- Ashutosh Chauhan


On Nov. 9, 2017, 5:39 p.m., Zoltan Haindrich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63442/
> ---
> 
> (Updated Nov. 9, 2017, 5:39 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-17934
> https://issues.apache.org/jira/browse/HIVE-17934
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> * remove the reactive stat state guessing method
> * make the guessing only work when a new object is created
> * change the way stat objects are merged
> 
> this patch will most probably break almost all qtest outputs
> 
> 
> Diffs
> -
> 
>   accumulo-handler/src/test/results/positive/accumulo_queries.q.out 
> b3adf4e504 
>   hbase-handler/src/test/results/positive/hbase_queries.q.out b2eda12e95 
>   hbase-handler/src/test/results/positive/hbasestats.q.out 29eefd43a9 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java
>  7a3fae65e8 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
>  a4f60accce 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java 8ffb4ce44b 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ce7c96c639 
>   ql/src/test/queries/clientpositive/lateral_view_onview2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/stats_empty_partition2.q PRE-CREATION 
>   ql/src/test/results/clientpositive/acid_table_stats.q.out 351ff0da0a 
>   ql/src/test/results/clientpositive/alterColumnStatsPart.q.out 858e16fe22 
>   ql/src/test/results/clientpositive/annotate_stats_part.q.out 3a94a6a4e3 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 7875e9693a 
>   ql/src/test/results/clientpositive/cbo_const.q.out e9f885b363 
>   ql/src/test/results/clientpositive/cbo_input26.q.out 77fc194829 
>   ql/src/test/results/clientpositive/columnstats_partlvl_dp.q.out 414b715b7a 
>   ql/src/test/results/clientpositive/columnstats_quoting.q.out 683c1e274f 
>   ql/src/test/results/clientpositive/columnstats_tbllvl.q.out a2c6ead293 
>   ql/src/test/results/clientpositive/constGby.q.out c633624935 
>   

Re: Review Request 63442: HIVE-17934 Merging Statistics are promoted to COMPLETE (most of the time)

2017-11-09 Thread Zoltan Haindrich


> On Nov. 3, 2017, 11:54 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
> > Line 1656 (original), 1656 (patched)
> > 
> >
> > why are we setting state to partial here? For operators other than 
> > TableScan we derive stats and we keep state as is.

this turned out to be a really bad idea...and caused a lot of regressions.
the new patch is much more conservative; and tries to only degrade the stats 
state if its neccessary.


- Zoltan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63442/#review190080
---


On Nov. 9, 2017, 5:39 p.m., Zoltan Haindrich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63442/
> ---
> 
> (Updated Nov. 9, 2017, 5:39 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-17934
> https://issues.apache.org/jira/browse/HIVE-17934
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> * remove the reactive stat state guessing method
> * make the guessing only work when a new object is created
> * change the way stat objects are merged
> 
> this patch will most probably break almost all qtest outputs
> 
> 
> Diffs
> -
> 
>   accumulo-handler/src/test/results/positive/accumulo_queries.q.out 
> b3adf4e504 
>   hbase-handler/src/test/results/positive/hbase_queries.q.out b2eda12e95 
>   hbase-handler/src/test/results/positive/hbasestats.q.out 29eefd43a9 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java
>  7a3fae65e8 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
>  a4f60accce 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java 8ffb4ce44b 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ce7c96c639 
>   ql/src/test/queries/clientpositive/lateral_view_onview2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/stats_empty_partition2.q PRE-CREATION 
>   ql/src/test/results/clientpositive/acid_table_stats.q.out 351ff0da0a 
>   ql/src/test/results/clientpositive/alterColumnStatsPart.q.out 858e16fe22 
>   ql/src/test/results/clientpositive/annotate_stats_part.q.out 3a94a6a4e3 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 7875e9693a 
>   ql/src/test/results/clientpositive/cbo_const.q.out e9f885b363 
>   ql/src/test/results/clientpositive/cbo_input26.q.out 77fc194829 
>   ql/src/test/results/clientpositive/columnstats_partlvl_dp.q.out 414b715b7a 
>   ql/src/test/results/clientpositive/columnstats_quoting.q.out 683c1e274f 
>   ql/src/test/results/clientpositive/columnstats_tbllvl.q.out a2c6ead293 
>   ql/src/test/results/clientpositive/constGby.q.out c633624935 
>   ql/src/test/results/clientpositive/constant_prop_3.q.out cba4744866 
>   ql/src/test/results/clientpositive/constprog3.q.out f54168d0ee 
>   ql/src/test/results/clientpositive/correlationoptimizer10.q.out a03acd38a7 
>   ql/src/test/results/clientpositive/correlationoptimizer11.q.out cf2250790a 
>   ql/src/test/results/clientpositive/correlationoptimizer13.q.out 6d4f931213 
>   ql/src/test/results/clientpositive/correlationoptimizer14.q.out 149f33fee8 
>   ql/src/test/results/clientpositive/correlationoptimizer15.q.out 2d813b239f 
>   ql/src/test/results/clientpositive/correlationoptimizer5.q.out 68d6a54862 
>   ql/src/test/results/clientpositive/correlationoptimizer7.q.out 82fecab594 
>   ql/src/test/results/clientpositive/correlationoptimizer8.q.out f3cb988a03 
>   ql/src/test/results/clientpositive/correlationoptimizer9.q.out 5372408d2a 
>   ql/src/test/results/clientpositive/cte_mat_5.q.out 3747cec891 
>   ql/src/test/results/clientpositive/display_colstats_tbllvl.q.out 8e2e77b077 
>   ql/src/test/results/clientpositive/druid_basic2.q.out 753ccb456f 
>   ql/src/test/results/clientpositive/empty_join.q.out a4a9976a7f 
>   ql/src/test/results/clientpositive/filter_cond_pushdown_HIVE_15647.q.out 
> 779bea3a26 
>   ql/src/test/results/clientpositive/groupby_sort_6.q.out a66ec97642 
>   ql/src/test/results/clientpositive/having2.q.out 80301bfc04 
>   ql/src/test/results/clientpositive/input23.q.out 80ee81b654 
>   ql/src/test/results/clientpositive/input26.q.out 1ac082eedf 
>   ql/src/test/results/clientpositive/join_cond_pushdown_unqual1.q.out 
> 74f45e58c0 
>   ql/src/test/results/clientpositive/join_cond_pushdown_unqual2.q.out 
> 2ac67b294c 
>   ql/src/test/results/clientpositive/join_cond_pushdown_unqual3.q.out 
> b8d9b408d7 
>   ql/src/test/results/clientpositive/join_cond_pushdown_unqual4.q.out 
> e5ddc3507f 
>   

Re: Review Request 63442: HIVE-17934 Merging Statistics are promoted to COMPLETE (most of the time)

2017-11-09 Thread Zoltan Haindrich

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63442/
---

(Updated Nov. 9, 2017, 5:39 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
---

updated patch#06 with q.out changes

* currently: if a partitioned table has at least 1 empty partition; it will be 
considered PARTIAL - this seemed to be the preffered earlier
* if partition pruning removes all partition; the result is COMPLETE
* there are some folloup issues which have been exposed by the correction of 
the merge logic


Bugs: HIVE-17934
https://issues.apache.org/jira/browse/HIVE-17934


Repository: hive-git


Description
---

* remove the reactive stat state guessing method
* make the guessing only work when a new object is created
* change the way stat objects are merged

this patch will most probably break almost all qtest outputs


Diffs (updated)
-

  accumulo-handler/src/test/results/positive/accumulo_queries.q.out b3adf4e504 
  hbase-handler/src/test/results/positive/hbase_queries.q.out b2eda12e95 
  hbase-handler/src/test/results/positive/hbasestats.q.out 29eefd43a9 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java
 7a3fae65e8 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
 a4f60accce 
  ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java 8ffb4ce44b 
  ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ce7c96c639 
  ql/src/test/queries/clientpositive/lateral_view_onview2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/stats_empty_partition2.q PRE-CREATION 
  ql/src/test/results/clientpositive/acid_table_stats.q.out 351ff0da0a 
  ql/src/test/results/clientpositive/alterColumnStatsPart.q.out 858e16fe22 
  ql/src/test/results/clientpositive/annotate_stats_part.q.out 3a94a6a4e3 
  ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 7875e9693a 
  ql/src/test/results/clientpositive/cbo_const.q.out e9f885b363 
  ql/src/test/results/clientpositive/cbo_input26.q.out 77fc194829 
  ql/src/test/results/clientpositive/columnstats_partlvl_dp.q.out 414b715b7a 
  ql/src/test/results/clientpositive/columnstats_quoting.q.out 683c1e274f 
  ql/src/test/results/clientpositive/columnstats_tbllvl.q.out a2c6ead293 
  ql/src/test/results/clientpositive/constGby.q.out c633624935 
  ql/src/test/results/clientpositive/constant_prop_3.q.out cba4744866 
  ql/src/test/results/clientpositive/constprog3.q.out f54168d0ee 
  ql/src/test/results/clientpositive/correlationoptimizer10.q.out a03acd38a7 
  ql/src/test/results/clientpositive/correlationoptimizer11.q.out cf2250790a 
  ql/src/test/results/clientpositive/correlationoptimizer13.q.out 6d4f931213 
  ql/src/test/results/clientpositive/correlationoptimizer14.q.out 149f33fee8 
  ql/src/test/results/clientpositive/correlationoptimizer15.q.out 2d813b239f 
  ql/src/test/results/clientpositive/correlationoptimizer5.q.out 68d6a54862 
  ql/src/test/results/clientpositive/correlationoptimizer7.q.out 82fecab594 
  ql/src/test/results/clientpositive/correlationoptimizer8.q.out f3cb988a03 
  ql/src/test/results/clientpositive/correlationoptimizer9.q.out 5372408d2a 
  ql/src/test/results/clientpositive/cte_mat_5.q.out 3747cec891 
  ql/src/test/results/clientpositive/display_colstats_tbllvl.q.out 8e2e77b077 
  ql/src/test/results/clientpositive/druid_basic2.q.out 753ccb456f 
  ql/src/test/results/clientpositive/empty_join.q.out a4a9976a7f 
  ql/src/test/results/clientpositive/filter_cond_pushdown_HIVE_15647.q.out 
779bea3a26 
  ql/src/test/results/clientpositive/groupby_sort_6.q.out a66ec97642 
  ql/src/test/results/clientpositive/having2.q.out 80301bfc04 
  ql/src/test/results/clientpositive/input23.q.out 80ee81b654 
  ql/src/test/results/clientpositive/input26.q.out 1ac082eedf 
  ql/src/test/results/clientpositive/join_cond_pushdown_unqual1.q.out 
74f45e58c0 
  ql/src/test/results/clientpositive/join_cond_pushdown_unqual2.q.out 
2ac67b294c 
  ql/src/test/results/clientpositive/join_cond_pushdown_unqual3.q.out 
b8d9b408d7 
  ql/src/test/results/clientpositive/join_cond_pushdown_unqual4.q.out 
e5ddc3507f 
  ql/src/test/results/clientpositive/join_view.q.out 1d83742dd4 
  ql/src/test/results/clientpositive/lateral_view_onview.q.out 423885e442 
  ql/src/test/results/clientpositive/lateral_view_onview2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/list_bucket_query_oneskew_2.q.out 
876434fb4e 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_12.q.out 
3acbb207a7 
  ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out 
67fe41e223 
  ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_sw.q.out 
1c672ef068 
  ql/src/test/results/clientpositive/llap/dynamic_semijoin_user_level.q.out 
a51637a2b9 
  ql/src/test/results/clientpositive/llap/dynpart_sort_optimization_acid.q.out 

[jira] [Created] (HIVE-18036) Stats: Remove usage of clone() methods

2017-11-09 Thread Zoltan Haindrich (JIRA)
Zoltan Haindrich created HIVE-18036:
---

 Summary: Stats: Remove usage of clone() methods
 Key: HIVE-18036
 URL: https://issues.apache.org/jira/browse/HIVE-18036
 Project: Hive
  Issue Type: Sub-task
  Components: Statistics
Reporter: Zoltan Haindrich


{{Statistics}} and {{ColStats}} implements cloneable; however they never throw 
clonenotsupported; and this causes try / catch blocks which are just noise



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: Review Request 63586: Fix HIVE-17942: HiveAlterHandler should use the conf from HMS Handler

2017-11-09 Thread Janaki Lahorani via Review Board


> On Nov. 9, 2017, 1:08 a.m., Alexander Kolbasov wrote:
> > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreAlterColumnPar.java
> > Lines 37 (patched)
> > 
> >
> > It is unclear from the test that that's what is testing, so it would be 
> > good to explain how your test actually tests for this.

Comments added to explain the test.


> On Nov. 9, 2017, 1:08 a.m., Alexander Kolbasov wrote:
> > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
> > Line 109 (original), 109 (patched)
> > 
> >
> > Can you add a comment at the top of the class explaining that only the 
> > handler's config should be used and never the local stashed config?
> > 
> > Do we need to support local config at all?

Comments added.


- Janaki


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63586/#review190522
---


On Nov. 9, 2017, 5:04 p.m., Janaki Lahorani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63586/
> ---
> 
> (Updated Nov. 9, 2017, 5:04 p.m.)
> 
> 
> Review request for hive, Alexander Kolbasov, Andrew Sherman, Sahil Takiar, 
> and Vihang Karajgaonkar.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HMS handler thread local will have the configuration changes from the user 
> local only to that connection.  HiveAlterHandler should use the thread local 
> to pick up user's configuration changes.
> 
> 
> Diffs
> -
> 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreAlterColumnPar.java
>  PRE-CREATION 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
>  921cfc00343807179340fbdf40f21e2a46d936ab 
> 
> 
> Diff: https://reviews.apache.org/r/63586/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Janaki Lahorani
> 
>



Re: Review Request 63586: Fix HIVE-17942: HiveAlterHandler should use the conf from HMS Handler

2017-11-09 Thread Janaki Lahorani via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63586/
---

(Updated Nov. 9, 2017, 5:04 p.m.)


Review request for hive, Alexander Kolbasov, Andrew Sherman, Sahil Takiar, and 
Vihang Karajgaonkar.


Changes
---

Addressed comments from Alexander Kolbasov.


Repository: hive-git


Description
---

HMS handler thread local will have the configuration changes from the user 
local only to that connection.  HiveAlterHandler should use the thread local to 
pick up user's configuration changes.


Diffs (updated)
-

  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreAlterColumnPar.java
 PRE-CREATION 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
 921cfc00343807179340fbdf40f21e2a46d936ab 


Diff: https://reviews.apache.org/r/63586/diff/5/

Changes: https://reviews.apache.org/r/63586/diff/4-5/


Testing
---


Thanks,

Janaki Lahorani



Re: Review Request 63586: Fix HIVE-17942: HiveAlterHandler should use the conf from HMS Handler

2017-11-09 Thread Janaki Lahorani via Review Board


> On Nov. 9, 2017, 1:08 a.m., Alexander Kolbasov wrote:
> > With this change, do we still need Config stored in the HiveAlterHandle 
> > itself? What is the value of returning such config in getConf() Should  the 
> > new HiveAlterHandle extend COnfigurable? Do we need setConf method?

AlterHandler is a public interface.  Changing that to not extend Configurable 
is a significant change, arguable as backward incompatible.  This is something 
that will result in cleaner code, but not necessarily needed for the bug to be 
fixed.  So, I chose not to change AlterHandler.


- Janaki


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63586/#review190522
---


On Nov. 8, 2017, 7:17 p.m., Janaki Lahorani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63586/
> ---
> 
> (Updated Nov. 8, 2017, 7:17 p.m.)
> 
> 
> Review request for hive, Alexander Kolbasov, Andrew Sherman, Sahil Takiar, 
> and Vihang Karajgaonkar.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HMS handler thread local will have the configuration changes from the user 
> local only to that connection.  HiveAlterHandler should use the thread local 
> to pick up user's configuration changes.
> 
> 
> Diffs
> -
> 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreAlterColumnPar.java
>  PRE-CREATION 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
>  921cfc00343807179340fbdf40f21e2a46d936ab 
> 
> 
> Diff: https://reviews.apache.org/r/63586/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Janaki Lahorani
> 
>



[jira] [Created] (HIVE-18035) NullPointerException on querying a table with a compact index

2017-11-09 Thread Brecht Machiels (JIRA)
Brecht Machiels created HIVE-18035:
--

 Summary: NullPointerException on querying a table with a compact 
index
 Key: HIVE-18035
 URL: https://issues.apache.org/jira/browse/HIVE-18035
 Project: Hive
  Issue Type: Bug
  Components: Indexing
Affects Versions: 1.1.0
 Environment: CDH 5.8.3 on RHEL Server 6.8
Reporter: Brecht Machiels


After creating an index on a table (sys_created_on is a STRING column):

{{CREATE INDEX test_sys_audit_index_sys_created_on
ON TABLE servicenow_stg.sys_audit_distinct_tmp (sys_created_on)
AS 'org.apache.hadoop.hive.ql.index.compact.CompactIndexHandler'
WITH DEFERRED REBUILD;
ALTER INDEX test_sys_audit_index_sys_created_on ON 
servicenow_stg.sys_audit_distinct_tmp REBUILD;}}

... the following query fails:

{{SELECT sys_created_on FROM servicenow_stg.sys_audit_distinct_tmp
WHERE sys_created_on > '2017-01-01'}}

... with this stack trace:

{{[Cloudera][HiveJDBCDriver](500051) ERROR processing query/statement. Error 
Code: 4, SQL state: TStatus(statusCode:ERROR_STATUS, 
infoMessages:[*org.apache.hive.service.cli.HiveSQLException:Error while 
compiling statement: FAILED: NullPointerException null:17:16, 
org.apache.hive.service.cli.operation.Operation:toSQLException:Operation.java:385,
 
org.apache.hive.service.cli.operation.SQLOperation:prepare:SQLOperation.java:136,
 
org.apache.hive.service.cli.operation.SQLOperation:runInternal:SQLOperation.java:206,
 org.apache.hive.service.cli.operation.Operation:run:Operation.java:327, 
org.apache.hive.service.cli.session.HiveSessionImpl:executeStatementInternal:HiveSessionImpl.java:424,
 
org.apache.hive.service.cli.session.HiveSessionImpl:executeStatementAsync:HiveSessionImpl.java:401,
 
org.apache.hive.service.cli.CLIService:executeStatementAsync:CLIService.java:258,
 
org.apache.hive.service.cli.thrift.ThriftCLIService:ExecuteStatement:ThriftCLIService.java:500,
 
org.apache.hive.service.cli.thrift.TCLIService$Processor$ExecuteStatement:getResult:TCLIService.java:1313,
 
org.apache.hive.service.cli.thrift.TCLIService$Processor$ExecuteStatement:getResult:TCLIService.java:1298,
 org.apache.thrift.ProcessFunction:process:ProcessFunction.java:39, 
org.apache.thrift.TBaseProcessor:process:TBaseProcessor.java:39, 
org.apache.hadoop.hive.thrift.HadoopThriftAuthBridge$Server$TUGIAssumingProcessor:process:HadoopThriftAuthBridge.java:746,
 
org.apache.thrift.server.TThreadPoolServer$WorkerProcess:run:TThreadPoolServer.java:286,
 
java.util.concurrent.ThreadPoolExecutor:runWorker:ThreadPoolExecutor.java:1142, 
java.util.concurrent.ThreadPoolExecutor$Worker:run:ThreadPoolExecutor.java:617, 
java.lang.Thread:run:Thread.java:745, 
*java.lang.NullPointerException:null:40:24, 
org.apache.hadoop.hive.ql.index.compact.CompactIndexHandler:generateIndexQuery:CompactIndexHandler.java:199,
 
org.apache.hadoop.hive.ql.optimizer.physical.index.IndexWhereProcessor:rewriteForIndexes:IndexWhereProcessor.java:215,
 
org.apache.hadoop.hive.ql.optimizer.physical.index.IndexWhereProcessor:process:IndexWhereProcessor.java:146,
 
org.apache.hadoop.hive.ql.lib.DefaultRuleDispatcher:dispatch:DefaultRuleDispatcher.java:90,
 
org.apache.hadoop.hive.ql.lib.DefaultGraphWalker:dispatchAndReturn:DefaultGraphWalker.java:94,
 
org.apache.hadoop.hive.ql.lib.DefaultGraphWalker:dispatch:DefaultGraphWalker.java:78,
 
org.apache.hadoop.hive.ql.lib.DefaultGraphWalker:walk:DefaultGraphWalker.java:132,
 
org.apache.hadoop.hive.ql.lib.DefaultGraphWalker:startWalking:DefaultGraphWalker.java:109,
 
org.apache.hadoop.hive.ql.optimizer.physical.index.IndexWhereTaskDispatcher:dispatch:IndexWhereTaskDispatcher.java:102,
 
org.apache.hadoop.hive.ql.lib.DefaultGraphWalker:dispatchAndReturn:DefaultGraphWalker.java:94,
 
org.apache.hadoop.hive.ql.lib.DefaultGraphWalker:dispatch:DefaultGraphWalker.java:78,
 
org.apache.hadoop.hive.ql.lib.DefaultGraphWalker:walk:DefaultGraphWalker.java:132,
 
org.apache.hadoop.hive.ql.lib.DefaultGraphWalker:startWalking:DefaultGraphWalker.java:109,
 
org.apache.hadoop.hive.ql.optimizer.physical.IndexWhereResolver:resolve:IndexWhereResolver.java:38,
 
org.apache.hadoop.hive.ql.optimizer.physical.PhysicalOptimizer:optimize:PhysicalOptimizer.java:107,
 
org.apache.hadoop.hive.ql.parse.MapReduceCompiler:optimizeTaskPlan:MapReduceCompiler.java:273,
 org.apache.hadoop.hive.ql.parse.TaskCompiler:compile:TaskCompiler.java:225, 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer:analyzeInternal:SemanticAnalyzer.java:10109,
 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzer:analyzeInternal:SemanticAnalyzer.java:9902,
 
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer:analyze:BaseSemanticAnalyzer.java:223,
 org.apache.hadoop.hive.ql.Driver:compile:Driver.java:446, 
org.apache.hadoop.hive.ql.Driver:compile:Driver.java:312, 
org.apache.hadoop.hive.ql.Driver:compileInternal:Driver.java:1201, 

Re: MERGE Statement help plz

2017-11-09 Thread Eugene Koifman
There is no specific restriction against it being a view.  You may be hitting a 
bug.  Can you provide more details about the error/SQL?

On 11/8/17, 9:55 PM, "Narendra Singh"  wrote:

Hello Team,

I am doing one poc on SCD concept and trying to solve proble using MERGE
concept explained here
https://issues.apache.org/jira/browse/HIVE-10924

Wanted to check if source (right side table) can be a View, definition says
it is expression or table.

in RDBMS world source cab be a view, I tried with view but getting error.

please help !!!



-- 
Regards,
Narendra Singh




[jira] [Created] (HIVE-18034) Improving logging with HoS executors spend lots of time in GC

2017-11-09 Thread Sahil Takiar (JIRA)
Sahil Takiar created HIVE-18034:
---

 Summary: Improving logging with HoS executors spend lots of time 
in GC
 Key: HIVE-18034
 URL: https://issues.apache.org/jira/browse/HIVE-18034
 Project: Hive
  Issue Type: Sub-task
  Components: Spark
Reporter: Sahil Takiar


There are times when Spark will spend lots of time doing GC. The Spark History 
UI shows a bunch of red flags when too much time is spent in GC. It would be 
nice if those warnings are propagated to Hive.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (HIVE-18033) Tables which are known to be empty should not have NONE basic stat state

2017-11-09 Thread Zoltan Haindrich (JIRA)
Zoltan Haindrich created HIVE-18033:
---

 Summary: Tables which are known to be empty should not have NONE 
basic stat state
 Key: HIVE-18033
 URL: https://issues.apache.org/jira/browse/HIVE-18033
 Project: Hive
  Issue Type: Improvement
Reporter: Zoltan Haindrich


this would aid situations where an empty table is being joined.

consider also external tables



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (HIVE-18032) Stats: Consolidate stat state for limit 0 and where false

2017-11-09 Thread Zoltan Haindrich (JIRA)
Zoltan Haindrich created HIVE-18032:
---

 Summary: Stats: Consolidate stat state for limit 0 and where false
 Key: HIVE-18032
 URL: https://issues.apache.org/jira/browse/HIVE-18032
 Project: Hive
  Issue Type: Sub-task
Reporter: Zoltan Haindrich


query (from llap_nullscan.q):
{code}
explain
 select * from (select key from src_orc where false) a left outer join (select 
key from src_orc limit 0)
 b on a.key=b.key
{code}

currently:

* limit 0 produces
  Statistics: Num rows: 0 Data size: 0 Basic stats: COMPLETE Column stats: NONE
* where false
  Statistics: Num rows: 0 Data size: 0 Basic stats: NONE Column stats: NONE




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (HIVE-18031) Support replication for Alter Database operation.

2017-11-09 Thread Sankar Hariappan (JIRA)
Sankar Hariappan created HIVE-18031:
---

 Summary: Support replication for Alter Database operation.
 Key: HIVE-18031
 URL: https://issues.apache.org/jira/browse/HIVE-18031
 Project: Hive
  Issue Type: Sub-task
  Components: HiveServer2, repl
Affects Versions: 3.0.0
Reporter: Sankar Hariappan
Assignee: Sankar Hariappan
 Fix For: 3.0.0


Currently alter database operations to alter the database properties or 
description are not generating any events due to which it is not getting 
replicated.
Need to add an event for this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (HIVE-18030) HCatalog can't be used with Pig on Spark

2017-11-09 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18030:
-

 Summary: HCatalog can't be used with Pig on Spark
 Key: HIVE-18030
 URL: https://issues.apache.org/jira/browse/HIVE-18030
 Project: Hive
  Issue Type: Bug
  Components: HCatalog
Reporter: Adam Szita
Assignee: Adam Szita


When using Pig on Spark in cluster mode, all queries containing HCatalog access 
are failing:
{code}
2017-11-03 12:39:19,268 [dispatcher-event-loop-19] INFO  
org.apache.spark.storage.BlockManagerInfo - Added broadcast_6_piece0 in memory 
on <>:<> (size: 83.0 KB, free: 408.5 MB)
2017-11-03 12:39:19,277 [task-result-getter-0] WARN  
org.apache.spark.scheduler.TaskSetManager - Lost task 0.0 in stage 0.0 (TID 0, 
vc0918.halxg.cloudera.com, executor 2): java.lang.NullPointerException
at org.apache.hadoop.security.Credentials.addAll(Credentials.java:401)
at org.apache.hadoop.security.Credentials.addAll(Credentials.java:388)
at 
org.apache.hive.hcatalog.pig.HCatLoader.setLocation(HCatLoader.java:128)
at 
org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigInputFormat.mergeSplitSpecificConf(PigInputFormat.java:147)
at 
org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigInputFormat$RecordReaderFactory.(PigInputFormat.java:115)
at 
org.apache.pig.backend.hadoop.executionengine.spark.running.PigInputFormatSpark$SparkRecordReaderFactory.(PigInputFormatSpark.java:126)
at 
org.apache.pig.backend.hadoop.executionengine.spark.running.PigInputFormatSpark.createRecordReader(PigInputFormatSpark.java:70)
at 
org.apache.spark.rdd.NewHadoopRDD$$anon$1.liftedTree1$1(NewHadoopRDD.scala:180)
at 
org.apache.spark.rdd.NewHadoopRDD$$anon$1.(NewHadoopRDD.scala:179)
at org.apache.spark.rdd.NewHadoopRDD.compute(NewHadoopRDD.scala:134)
at org.apache.spark.rdd.NewHadoopRDD.compute(NewHadoopRDD.scala:69)
at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:323)
at org.apache.spark.rdd.RDD.iterator(RDD.scala:287)
at 
org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:38)
at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:323)
at org.apache.spark.rdd.RDD.iterator(RDD.scala:287)
at 
org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:38)
at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:323)
at org.apache.spark.rdd.RDD.iterator(RDD.scala:287)
at 
org.apache.spark.rdd.MapPartitionsRDD.compute(MapPartitionsRDD.scala:38)
at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:323)
at org.apache.spark.rdd.RDD.iterator(RDD.scala:287)
at 
org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:96)
at 
org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:53)
at org.apache.spark.scheduler.Task.run(Task.scala:108)
at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:338)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)