> On Nov. 9, 2017, 1:08 a.m., Alexander Kolbasov wrote: > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreAlterColumnPar.java > > Lines 37 (patched) > > <https://reviews.apache.org/r/63586/diff/4/?file=1885054#file1885054line37> > > > > It is unclear from the test that that's what is testing, so it would be > > good to explain how your test actually tests for this.
Comments added to explain the test. > On Nov. 9, 2017, 1:08 a.m., Alexander Kolbasov wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Line 109 (original), 109 (patched) > > <https://reviews.apache.org/r/63586/diff/4/?file=1885055#file1885055line109> > > > > Can you add a comment at the top of the class explaining that only the > > handler's config should be used and never the local stashed config? > > > > Do we need to support local config at all? Comments added. - Janaki ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63586/#review190522 ----------------------------------------------------------- On Nov. 9, 2017, 5:04 p.m., Janaki Lahorani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63586/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2017, 5:04 p.m.) > > > Review request for hive, Alexander Kolbasov, Andrew Sherman, Sahil Takiar, > and Vihang Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > HMS handler thread local will have the configuration changes from the user > local only to that connection. HiveAlterHandler should use the thread local > to pick up user's configuration changes. > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreAlterColumnPar.java > PRE-CREATION > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 921cfc00343807179340fbdf40f21e2a46d936ab > > > Diff: https://reviews.apache.org/r/63586/diff/5/ > > > Testing > ------- > > > Thanks, > > Janaki Lahorani > >
