[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847104#comment-13847104 ] Gunther Hagleitner commented on HIVE-2093: -- [~thejas] This is breaking the build. I think you might have forgotten to add some files (UnlockDatabaseDesc/LockDatabaseDesc)? create/drop database should populate inputs/outputs and check concurrency and user permission - Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: New Feature Components: Authorization, Locking, Metastore, Security Reporter: Namit Jain Assignee: Navis Fix For: 0.13.0 Attachments: D12807.3.patch, D12807.4.patch, HIVE-2093.6.patch, HIVE-2093.7.patch.txt, HIVE-2093.8.patch.txt, HIVE-2093.9.patch.txt, HIVE-2093.D12807.1.patch, HIVE-2093.D12807.2.patch, HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch concurrency and authorization are needed for create/drop table. Also to make concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847110#comment-13847110 ] Gunther Hagleitner commented on HIVE-2093: -- I think it's just the two files. I will commit those (from patch .9) create/drop database should populate inputs/outputs and check concurrency and user permission - Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: New Feature Components: Authorization, Locking, Metastore, Security Reporter: Namit Jain Assignee: Navis Fix For: 0.13.0 Attachments: D12807.3.patch, D12807.4.patch, HIVE-2093.6.patch, HIVE-2093.7.patch.txt, HIVE-2093.8.patch.txt, HIVE-2093.9.patch.txt, HIVE-2093.D12807.1.patch, HIVE-2093.D12807.2.patch, HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch concurrency and authorization are needed for create/drop table. Also to make concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847113#comment-13847113 ] Gunther Hagleitner commented on HIVE-2093: -- Committed UnlockDatabaseDesc and LockDatabaseDesc. Build is working again for me. create/drop database should populate inputs/outputs and check concurrency and user permission - Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: New Feature Components: Authorization, Locking, Metastore, Security Reporter: Namit Jain Assignee: Navis Fix For: 0.13.0 Attachments: D12807.3.patch, D12807.4.patch, HIVE-2093.6.patch, HIVE-2093.7.patch.txt, HIVE-2093.8.patch.txt, HIVE-2093.9.patch.txt, HIVE-2093.D12807.1.patch, HIVE-2093.D12807.2.patch, HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch concurrency and authorization are needed for create/drop table. Also to make concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846046#comment-13846046 ] Phabricator commented on HIVE-2093: --- thejas has commented on the revision HIVE-2093 [jira] create/drop database should populate inputs/outputs and check concurrency and user permission. +1 REVISION DETAIL https://reviews.facebook.net/D12807 To: JIRA, navis Cc: thejas create/drop database should populate inputs/outputs and check concurrency and user permission - Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Components: Authorization, Locking, Metastore, Security Reporter: Namit Jain Assignee: Navis Attachments: D12807.3.patch, D12807.4.patch, HIVE-2093.6.patch, HIVE-2093.7.patch.txt, HIVE-2093.8.patch.txt, HIVE-2093.9.patch.txt, HIVE-2093.D12807.1.patch, HIVE-2093.D12807.2.patch, HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch concurrency and authorization are needed for create/drop table. Also to make concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844138#comment-13844138 ] Hive QA commented on HIVE-2093: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12617996/D12807.4.patch {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 4767 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.ql.security.TestClientSideAuthorizationProvider.testSimplePrivileges org.apache.hadoop.hive.ql.security.TestMetastoreAuthorizationProvider.testSimplePrivileges {noformat} Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/596/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/596/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12617996 create/drop database should populate inputs/outputs and check concurrency and user permission - Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Components: Authorization, Locking, Metastore, Security Reporter: Namit Jain Assignee: Navis Attachments: D12807.3.patch, D12807.4.patch, HIVE-2093.6.patch, HIVE-2093.7.patch.txt, HIVE-2093.8.patch.txt, HIVE-2093.D12807.1.patch, HIVE-2093.D12807.2.patch, HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch concurrency and authorization are needed for create/drop table. Also to make concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13845148#comment-13845148 ] Hive QA commented on HIVE-2093: --- {color:green}Overall{color}: +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12618162/HIVE-2093.9.patch.txt {color:green}SUCCESS:{color} +1 4768 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/608/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/608/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12618162 create/drop database should populate inputs/outputs and check concurrency and user permission - Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Components: Authorization, Locking, Metastore, Security Reporter: Namit Jain Assignee: Navis Attachments: D12807.3.patch, D12807.4.patch, HIVE-2093.6.patch, HIVE-2093.7.patch.txt, HIVE-2093.8.patch.txt, HIVE-2093.9.patch.txt, HIVE-2093.D12807.1.patch, HIVE-2093.D12807.2.patch, HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch concurrency and authorization are needed for create/drop table. Also to make concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843900#comment-13843900 ] Phabricator commented on HIVE-2093: --- navis has commented on the revision HIVE-2093 [jira] create/drop database should populate inputs/outputs and check concurrency and user permission. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/Driver.java:510 I've copied it from somewhere, forget where it was. Could you suggest better state code? ql/src/java/org/apache/hadoop/hive/ql/Driver.java:737 Ah, sure. ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:257 This method seemed not used in anywhere in current codebase, so it's hard to say the intent of initial contributor(Siying Dong). But this method seemed useful and I'll change it to return URI for database, too. ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:83 Some complex operations like import need different privilege checks with that of initiative operation. I think this part is from HIVE-2818 and mistakenly mixed with this issue. I'll remove it. ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:2290 ok. ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java:1233 ok. ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java:104 ok. REVISION DETAIL https://reviews.facebook.net/D12807 To: JIRA, navis Cc: thejas create/drop database should populate inputs/outputs and check concurrency and user permission - Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Components: Authorization, Locking, Metastore, Security Reporter: Namit Jain Assignee: Navis Attachments: D12807.3.patch, HIVE-2093.6.patch, HIVE-2093.7.patch.txt, HIVE-2093.8.patch.txt, HIVE-2093.D12807.1.patch, HIVE-2093.D12807.2.patch, HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch concurrency and authorization are needed for create/drop table. Also to make concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841841#comment-13841841 ] Thejas M Nair commented on HIVE-2093: - I have added some comments on reviewboard. Is there a way to grant these permissions for the database ? Specifically the global create permission needed for creating databases. Is that a follow-up work ? create/drop database should populate inputs/outputs and check concurrency and user permission - Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Components: Authorization, Locking, Metastore, Security Reporter: Namit Jain Assignee: Navis Attachments: D12807.3.patch, HIVE-2093.6.patch, HIVE-2093.7.patch.txt, HIVE-2093.8.patch.txt, HIVE-2093.D12807.1.patch, HIVE-2093.D12807.2.patch, HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch concurrency and authorization are needed for create/drop table. Also to make concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841839#comment-13841839 ] Phabricator commented on HIVE-2093: --- thejas has commented on the revision HIVE-2093 [jira] create/drop database should populate inputs/outputs and check concurrency and user permission. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:257 why not return the location uri here ? ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java:1233 what qnName means becomes clear only after reading the code, can you expand the variable name or add a javadoc comment ? ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:2290 can you update comment to say SHOW LOCKS DATABASE [database] [extended] ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java:104 you can use - new Path(toURI) Its there since hadoop 0.20.2 ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:83 why is this block of changes needed ? It does not seem to be used anyway. I think the separation between entity and privileges is a good thing. REVISION DETAIL https://reviews.facebook.net/D12807 To: JIRA, navis Cc: thejas create/drop database should populate inputs/outputs and check concurrency and user permission - Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Components: Authorization, Locking, Metastore, Security Reporter: Namit Jain Assignee: Navis Attachments: D12807.3.patch, HIVE-2093.6.patch, HIVE-2093.7.patch.txt, HIVE-2093.8.patch.txt, HIVE-2093.D12807.1.patch, HIVE-2093.D12807.2.patch, HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch concurrency and authorization are needed for create/drop table. Also to make concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841854#comment-13841854 ] Thejas M Nair commented on HIVE-2093: - btw, thanks for helping improve the authorization codebase! create/drop database should populate inputs/outputs and check concurrency and user permission - Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Components: Authorization, Locking, Metastore, Security Reporter: Namit Jain Assignee: Navis Attachments: D12807.3.patch, HIVE-2093.6.patch, HIVE-2093.7.patch.txt, HIVE-2093.8.patch.txt, HIVE-2093.D12807.1.patch, HIVE-2093.D12807.2.patch, HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch concurrency and authorization are needed for create/drop table. Also to make concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13839983#comment-13839983 ] Hive QA commented on HIVE-2093: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12617123/HIVE-2093.7.patch.txt {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 4463 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestHBaseNegativeCliDriver.testCliDriver_cascade_dbdrop_hadoop20 {noformat} Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/529/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/529/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12617123 create/drop database should populate inputs/outputs and check concurrency and user permission - Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Components: Authorization, Locking, Metastore, Security Reporter: Namit Jain Assignee: Navis Attachments: D12807.3.patch, HIVE-2093.6.patch, HIVE-2093.7.patch.txt, HIVE-2093.D12807.1.patch, HIVE-2093.D12807.2.patch, HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch concurrency and authorization are needed for create/drop table. Also to make concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13840943#comment-13840943 ] Phabricator commented on HIVE-2093: --- thejas has commented on the revision HIVE-2093 [jira] create/drop database should populate inputs/outputs and check concurrency and user permission. I have reviewed half of it, looks good mostly. I will complete the review tomorrow. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/Driver.java:510 What is the basis of the SQLState value ? what does it mean? Isn't class 01 warning ? But this is an error. ql/src/java/org/apache/hadoop/hive/ql/Driver.java:737 can you update the javadoc for this param ? REVISION DETAIL https://reviews.facebook.net/D12807 To: JIRA, navis Cc: thejas create/drop database should populate inputs/outputs and check concurrency and user permission - Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Components: Authorization, Locking, Metastore, Security Reporter: Namit Jain Assignee: Navis Attachments: D12807.3.patch, HIVE-2093.6.patch, HIVE-2093.7.patch.txt, HIVE-2093.8.patch.txt, HIVE-2093.D12807.1.patch, HIVE-2093.D12807.2.patch, HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch concurrency and authorization are needed for create/drop table. Also to make concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841015#comment-13841015 ] Hive QA commented on HIVE-2093: --- {color:green}Overall{color}: +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12617281/HIVE-2093.8.patch.txt {color:green}SUCCESS:{color} +1 4436 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/539/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/539/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12617281 create/drop database should populate inputs/outputs and check concurrency and user permission - Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Components: Authorization, Locking, Metastore, Security Reporter: Namit Jain Assignee: Navis Attachments: D12807.3.patch, HIVE-2093.6.patch, HIVE-2093.7.patch.txt, HIVE-2093.8.patch.txt, HIVE-2093.D12807.1.patch, HIVE-2093.D12807.2.patch, HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch concurrency and authorization are needed for create/drop table. Also to make concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13761676#comment-13761676 ] Hive QA commented on HIVE-2093: --- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12602091/HIVE-2093.D12807.1.patch {color:red}ERROR:{color} -1 due to 25 failed/errored test(s), 3092 tests executed *Failed tests:* {noformat} org.apache.hcatalog.security.TestHdfsAuthorizationProvider.testDropDatabaseFail1 org.apache.hive.hcatalog.security.TestHdfsAuthorizationProvider.testShowDatabases org.apache.hcatalog.security.TestHdfsAuthorizationProvider.testDropDatabaseFail2 org.apache.hive.hcatalog.security.TestHdfsAuthorizationProvider.testDropTableFail4 org.apache.hive.hcatalog.fileformats.TestOrcDynamicPartitioned.testHCatDynamicPartitionedTable org.apache.hive.hcatalog.mapreduce.TestHCatExternalDynamicPartitioned.testHCatDynamicPartitionedTable org.apache.hcatalog.security.TestHdfsAuthorizationProvider.testShowDatabases org.apache.hive.hcatalog.security.TestHdfsAuthorizationProvider.testShowTablesFail org.apache.hcatalog.security.TestHdfsAuthorizationProvider.testShowTablesFail org.apache.hcatalog.pig.TestHCatLoaderComplexSchema.testMapWithComplexData org.apache.hive.hcatalog.security.TestHdfsAuthorizationProvider.testDropDatabaseFail1 org.apache.hcatalog.security.TestHdfsAuthorizationProvider.testDatabaseOps org.apache.hive.hcatalog.security.TestHdfsAuthorizationProvider.testTableOps org.apache.hcatalog.security.TestHdfsAuthorizationProvider.testDescSwitchDatabaseFail org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_19_00_part_external_location org.apache.hcatalog.security.TestHdfsAuthorizationProvider.testCreateTableFail4 org.apache.hive.hcatalog.security.TestHdfsAuthorizationProvider.testDropDatabaseFail2 org.apache.hive.hcatalog.security.TestHdfsAuthorizationProvider.testCreateTableFail4 org.apache.hcatalog.security.TestHdfsAuthorizationProvider.testDropTableFail4 org.apache.hive.hcatalog.security.TestHdfsAuthorizationProvider.testDatabaseOps org.apache.hive.hcatalog.security.TestHdfsAuthorizationProvider.testDescSwitchDatabaseFail org.apache.hive.hcatalog.security.TestHdfsAuthorizationProvider.testCreateTableFail3 org.apache.hcatalog.security.TestHdfsAuthorizationProvider.testCreateTableFail3 org.apache.hcatalog.security.TestHdfsAuthorizationProvider.testTableOps org.apache.hadoop.hive.cli.TestHBaseNegativeCliDriver.testCliDriver_cascade_dbdrop_hadoop20 {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/666/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/666/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests failed with: TestsFailedException: 25 tests failed {noformat} This message is automatically generated. create/drop database should populate inputs/outputs and check concurrency and user permission - Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Components: Authorization, Locking, Metastore, Security Reporter: Namit Jain Assignee: Navis Attachments: HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch, HIVE-2093.6.patch, HIVE-2093.D12807.1.patch concurrency and authorization are needed for create/drop table. Also to make concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13762594#comment-13762594 ] Navis commented on HIVE-2093: - create table/partition does not have input/output entities in PREHOOK stage. IMO, database should act in same manner. create/drop database should populate inputs/outputs and check concurrency and user permission - Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Components: Authorization, Locking, Metastore, Security Reporter: Namit Jain Assignee: Navis Attachments: HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch, HIVE-2093.6.patch, HIVE-2093.D12807.1.patch concurrency and authorization are needed for create/drop table. Also to make concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13024738#comment-13024738 ] Carl Steinbach commented on HIVE-2093: -- +1. Will commit if tests pass. create/drop database should populate inputs/outputs and check concurrency and user permission - Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Components: Metastore, Security Reporter: Namit Jain Assignee: Siying Dong Attachments: HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch concurrency and authorization are needed for create/drop table. Also to make concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13022670#comment-13022670 ] jirapos...@reviews.apache.org commented on HIVE-2093: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/566/#review517 --- trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java https://reviews.apache.org/r/566/#comment1053 Spelling trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java https://reviews.apache.org/r/566/#comment1058 Why not make this a boolean function? I understand that the convention in this class is to have functions that return 0, or something more than 0, but it looks like all of the other functions can be boolean valued as well. Returning an integer in this situation is confusing. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java https://reviews.apache.org/r/566/#comment1059 Same deal here. Can you change this to return a boolean value? trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java https://reviews.apache.org/r/566/#comment1061 You can eliminate a couple lines of code by using foreach syntax instead of an explicit iterator. trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/ReadEntity.java https://reviews.apache.org/r/566/#comment1062 I draw the line at nested ternary statements. Can you please use if/else instead? trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java https://reviews.apache.org/r/566/#comment1063 Nice to have: move DATABASE to the beginning of the list. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java https://reviews.apache.org/r/566/#comment1064 Why do you need to initialize the lock manager here, but not above in analyzeLockDatabase()? trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g https://reviews.apache.org/r/566/#comment1065 should be unlock database statement trunk/ql/src/test/queries/clientnegative/lockneg6.q https://reviews.apache.org/r/566/#comment1066 Please add some comments explaining what it is you're trying to test so that I can quickly tell how this differs from lockneg5, lockneg7, etc, etc. Please also consider changing the name of the file to something more descriptive so that I don't even have to read the comments. trunk/ql/src/test/results/clientnegative/authorization_fail_create_db.q.out https://reviews.apache.org/r/566/#comment1067 Please make this less ambiguous and easier to parse by capitalizing SHOW GRANT. trunk/ql/src/test/results/clientnegative/exim_15_part_nonpart.q.out https://reviews.apache.org/r/566/#comment1068 Any chance I can get a look at closed-source-hive? ;) - Carl On 2011-04-19 19:25:22, Siying Dong wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/566/ bq. --- bq. bq. (Updated 2011-04-19 19:25:22) bq. bq. bq. Review request for hive, Yongqiang He and namit jain. bq. bq. bq. Summary bq. --- bq. bq. Still need to change some old tests' outputs. bq. bq. bq. This addresses bug HIVE-2093. bq. https://issues.apache.org/jira/browse/HIVE-2093 bq. bq. bq. Diffs bq. - bq. bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1095164 bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1095164 bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1095164 bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/ReadEntity.java 1095164 bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 1095164 bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java 1095164 bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1095164 bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1095164 bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1095164 bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 1095164 bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 1095164 bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LockDatabaseDesc.java PRE-CREATION bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ShowLocksDesc.java 1095164 bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/UnlockDatabaseDesc.java PRE-CREATION bq.trunk/ql/src/test/queries/clientnegative/authorization_fail_create_db.q PRE-CREATION bq.trunk/ql/src/test/queries/clientnegative/authorization_fail_drop_db.q
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13022958#comment-13022958 ] jirapos...@reviews.apache.org commented on HIVE-2093: - bq. On 2011-04-21 07:41:22, Carl Steinbach wrote: bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java, line 2080 bq. https://reviews.apache.org/r/566/diff/3/?file=15972#file15972line2080 bq. bq. Same deal here. Can you change this to return a boolean value? I'm going to follow convention this time, instead of making radical changes in such a JIRA. If you feel we should cleaning them up, we should open a separate JIRA. bq. On 2011-04-21 07:41:22, Carl Steinbach wrote: bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java, line 699 bq. https://reviews.apache.org/r/566/diff/3/?file=15976#file15976line699 bq. bq. Why do you need to initialize the lock manager here, but not above in analyzeLockDatabase()? If inputs and outputs are not empty, lock manager will automatically start. I look at the codes again. We probably don't need to put Db in inputs and outputs in such query, so that I remove them and set this value. - Siying --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/566/#review517 --- On 2011-04-19 19:25:22, Siying Dong wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/566/ bq. --- bq. bq. (Updated 2011-04-19 19:25:22) bq. bq. bq. Review request for hive, Yongqiang He and namit jain. bq. bq. bq. Summary bq. --- bq. bq. Still need to change some old tests' outputs. bq. bq. bq. This addresses bug HIVE-2093. bq. https://issues.apache.org/jira/browse/HIVE-2093 bq. bq. bq. Diffs bq. - bq. bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1095164 bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1095164 bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1095164 bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/ReadEntity.java 1095164 bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 1095164 bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java 1095164 bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1095164 bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1095164 bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1095164 bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 1095164 bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 1095164 bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LockDatabaseDesc.java PRE-CREATION bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ShowLocksDesc.java 1095164 bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/UnlockDatabaseDesc.java PRE-CREATION bq.trunk/ql/src/test/queries/clientnegative/authorization_fail_create_db.q PRE-CREATION bq.trunk/ql/src/test/queries/clientnegative/authorization_fail_drop_db.q PRE-CREATION bq.trunk/ql/src/test/queries/clientnegative/lockneg6.q PRE-CREATION bq.trunk/ql/src/test/queries/clientnegative/lockneg7.q PRE-CREATION bq.trunk/ql/src/test/queries/clientnegative/lockneg8.q PRE-CREATION bq.trunk/ql/src/test/queries/clientnegative/lockneg9.q PRE-CREATION bq.trunk/ql/src/test/queries/clientpositive/database.q 1095164 bq. trunk/ql/src/test/results/clientnegative/authorization_fail_create_db.q.out PRE-CREATION bq. trunk/ql/src/test/results/clientnegative/authorization_fail_drop_db.q.out PRE-CREATION bq. trunk/ql/src/test/results/clientnegative/database_create_already_exists.q.out 1095164 bq. trunk/ql/src/test/results/clientnegative/database_create_invalid_name.q.out 1095164 bq. trunk/ql/src/test/results/clientnegative/database_drop_does_not_exist.q.out 1095164 bq.trunk/ql/src/test/results/clientnegative/database_drop_not_empty.q.out 1095164 bq. trunk/ql/src/test/results/clientnegative/exim_01_nonpart_over_loaded.q.out 1095164 bq. trunk/ql/src/test/results/clientnegative/exim_02_all_part_over_overlap.q.out 1095164 bq. trunk/ql/src/test/results/clientnegative/exim_03_nonpart_noncompat_colschema.q.out 1095164 bq. trunk/ql/src/test/results/clientnegative/exim_04_nonpart_noncompat_colnumber.q.out 1095164 bq. trunk/ql/src/test/results/clientnegative/exim_05_nonpart_noncompat_coltype.q.out 1095164 bq.
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13022959#comment-13022959 ] jirapos...@reviews.apache.org commented on HIVE-2093: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/566/ --- (Updated 2011-04-21 22:21:03.518662) Review request for hive, Yongqiang He and namit jain. Changes --- addressing most of Carl's comments except incline. Summary --- Still need to change some old tests' outputs. This addresses bug HIVE-2093. https://issues.apache.org/jira/browse/HIVE-2093 Diffs (updated) - trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1095795 trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1095795 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1095795 trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/ReadEntity.java 1095795 trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 1095795 trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java 1095795 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1095795 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1095795 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1095795 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 1095795 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 1095795 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LockDatabaseDesc.java PRE-CREATION trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ShowLocksDesc.java 1095795 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/UnlockDatabaseDesc.java PRE-CREATION trunk/ql/src/test/queries/clientnegative/authorization_fail_create_db.q PRE-CREATION trunk/ql/src/test/queries/clientnegative/authorization_fail_drop_db.q PRE-CREATION trunk/ql/src/test/queries/clientnegative/lockneg_query_tbl_in_locked_db.q PRE-CREATION trunk/ql/src/test/queries/clientnegative/lockneg_try_db_lock_conflict.q PRE-CREATION trunk/ql/src/test/queries/clientnegative/lockneg_try_drop_locked_db.q PRE-CREATION trunk/ql/src/test/queries/clientnegative/lockneg_try_lock_db_in_use.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/database.q 1095795 trunk/ql/src/test/results/clientnegative/authorization_fail_2.q.out 1095795 trunk/ql/src/test/results/clientnegative/authorization_fail_3.q.out 1095795 trunk/ql/src/test/results/clientnegative/authorization_fail_4.q.out 1095795 trunk/ql/src/test/results/clientnegative/authorization_fail_5.q.out 1095795 trunk/ql/src/test/results/clientnegative/authorization_fail_6.q.out 1095795 trunk/ql/src/test/results/clientnegative/authorization_fail_7.q.out 1095795 trunk/ql/src/test/results/clientnegative/authorization_fail_create_db.q.out PRE-CREATION trunk/ql/src/test/results/clientnegative/authorization_fail_drop_db.q.out PRE-CREATION trunk/ql/src/test/results/clientnegative/authorization_part.q.out 1095795 trunk/ql/src/test/results/clientnegative/database_create_already_exists.q.out 1095795 trunk/ql/src/test/results/clientnegative/database_create_invalid_name.q.out 1095795 trunk/ql/src/test/results/clientnegative/database_drop_does_not_exist.q.out 1095795 trunk/ql/src/test/results/clientnegative/database_drop_not_empty.q.out 1095795 trunk/ql/src/test/results/clientnegative/exim_01_nonpart_over_loaded.q.out 1095795 trunk/ql/src/test/results/clientnegative/exim_02_all_part_over_overlap.q.out 1095795 trunk/ql/src/test/results/clientnegative/exim_03_nonpart_noncompat_colschema.q.out 1095795 trunk/ql/src/test/results/clientnegative/exim_04_nonpart_noncompat_colnumber.q.out 1095795 trunk/ql/src/test/results/clientnegative/exim_05_nonpart_noncompat_coltype.q.out 1095795 trunk/ql/src/test/results/clientnegative/exim_06_nonpart_noncompat_storage.q.out 1095795 trunk/ql/src/test/results/clientnegative/exim_07_nonpart_noncompat_ifof.q.out 1095795 trunk/ql/src/test/results/clientnegative/exim_08_nonpart_noncompat_serde.q.out 1095795 trunk/ql/src/test/results/clientnegative/exim_09_nonpart_noncompat_serdeparam.q.out 1095795 trunk/ql/src/test/results/clientnegative/exim_10_nonpart_noncompat_bucketing.q.out 1095795 trunk/ql/src/test/results/clientnegative/exim_11_nonpart_noncompat_sorting.q.out 1095795 trunk/ql/src/test/results/clientnegative/exim_13_nonnative_import.q.out 1095795 trunk/ql/src/test/results/clientnegative/exim_14_nonpart_part.q.out 1095795 trunk/ql/src/test/results/clientnegative/exim_15_part_nonpart.q.out 1095795
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13021502#comment-13021502 ] He Yongqiang commented on HIVE-2093: The change looks good to me. Siying, can you rebase? (Carl, since you are looking at the other one, can you please also take a look at this one as well?) create/drop database should populate inputs/outputs and check concurrency and user permission - Key: HIVE-2093 URL: https://issues.apache.org/jira/browse/HIVE-2093 Project: Hive Issue Type: Bug Components: Metastore, Security Reporter: Namit Jain Assignee: Siying Dong Attachments: HIVE.2093.1.patch, HIVE.2093.2.patch, HIVE.2093.3.patch concurrency and authorization are needed for create/drop table. Also to make concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS DATABASE -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2093) create/drop database should populate inputs/outputs and check concurrency and user permission
[ https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13021743#comment-13021743 ] jirapos...@reviews.apache.org commented on HIVE-2093: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/566/ --- (Updated 2011-04-19 19:25:22.632716) Review request for hive, Yongqiang He and namit jain. Summary --- Still need to change some old tests' outputs. This addresses bug HIVE-2093. https://issues.apache.org/jira/browse/HIVE-2093 Diffs (updated) - trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1095164 trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1095164 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1095164 trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/ReadEntity.java 1095164 trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 1095164 trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java 1095164 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1095164 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1095164 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1095164 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 1095164 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 1095164 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LockDatabaseDesc.java PRE-CREATION trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ShowLocksDesc.java 1095164 trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/UnlockDatabaseDesc.java PRE-CREATION trunk/ql/src/test/queries/clientnegative/authorization_fail_create_db.q PRE-CREATION trunk/ql/src/test/queries/clientnegative/authorization_fail_drop_db.q PRE-CREATION trunk/ql/src/test/queries/clientnegative/lockneg6.q PRE-CREATION trunk/ql/src/test/queries/clientnegative/lockneg7.q PRE-CREATION trunk/ql/src/test/queries/clientnegative/lockneg8.q PRE-CREATION trunk/ql/src/test/queries/clientnegative/lockneg9.q PRE-CREATION trunk/ql/src/test/queries/clientpositive/database.q 1095164 trunk/ql/src/test/results/clientnegative/authorization_fail_create_db.q.out PRE-CREATION trunk/ql/src/test/results/clientnegative/authorization_fail_drop_db.q.out PRE-CREATION trunk/ql/src/test/results/clientnegative/database_create_already_exists.q.out 1095164 trunk/ql/src/test/results/clientnegative/database_create_invalid_name.q.out 1095164 trunk/ql/src/test/results/clientnegative/database_drop_does_not_exist.q.out 1095164 trunk/ql/src/test/results/clientnegative/database_drop_not_empty.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_01_nonpart_over_loaded.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_02_all_part_over_overlap.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_03_nonpart_noncompat_colschema.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_04_nonpart_noncompat_colnumber.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_05_nonpart_noncompat_coltype.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_06_nonpart_noncompat_storage.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_07_nonpart_noncompat_ifof.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_08_nonpart_noncompat_serde.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_09_nonpart_noncompat_serdeparam.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_10_nonpart_noncompat_bucketing.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_11_nonpart_noncompat_sorting.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_13_nonnative_import.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_14_nonpart_part.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_15_part_nonpart.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_16_part_noncompat_schema.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_17_part_spec_underspec.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_18_part_spec_missing.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_19_external_over_existing.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_20_managed_location_over_existing.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_21_part_managed_external.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_23_import_exist_authfail.q.out 1095164 trunk/ql/src/test/results/clientnegative/exim_24_import_part_authfail.q.out 1095164