[jira] [Commented] (HIVE-2194) Add actions for alter table and alter partition events for metastore event listeners
[ https://issues.apache.org/jira/browse/HIVE-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072676#comment-13072676 ] Hudson commented on HIVE-2194: -- Integrated in Hive-trunk-h0.21 #858 (See [https://builds.apache.org/job/Hive-trunk-h0.21/858/]) HIVE-2276. Fix Inconsistency between RB and JIRA patches for HIVE-2194 (Sohan Jain via cws) cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1152007 Files : * /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java Add actions for alter table and alter partition events for metastore event listeners Key: HIVE-2194 URL: https://issues.apache.org/jira/browse/HIVE-2194 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Sohan Jain Assignee: Sohan Jain Fix For: 0.8.0 Attachments: HIVE-2194.1.patch, HIVE-2194.3.patch, HIVE-2194.4.patch HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2194) Add actions for alter table and alter partition events for metastore event listeners
[ https://issues.apache.org/jira/browse/HIVE-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13062239#comment-13062239 ] Paul Yang commented on HIVE-2194: - Sohan just mentioned that there was a mismatch between the RB and JIRA versions for this one too. This will require another patch. Add actions for alter table and alter partition events for metastore event listeners Key: HIVE-2194 URL: https://issues.apache.org/jira/browse/HIVE-2194 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Sohan Jain Assignee: Sohan Jain Fix For: 0.8.0 Attachments: HIVE-2194.1.patch, HIVE-2194.3.patch, HIVE-2194.4.patch HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2194) Add actions for alter table and alter partition events for metastore event listeners
[ https://issues.apache.org/jira/browse/HIVE-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13062296#comment-13062296 ] Hudson commented on HIVE-2194: -- Integrated in Hive-trunk-h0.21 #817 (See [https://builds.apache.org/job/Hive-trunk-h0.21/817/]) Adding files that were missing from the commit for HIVE-2194 HIVE-2194. Add actions for alter table and alter partition events for metastore event listeners (Sohan Jain via pauly) pauly : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1144534 Files : * /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterPartitionEvent.java * /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterTableEvent.java pauly : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1144504 Files : * /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java * /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java * /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java * /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java * /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java * /hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java Add actions for alter table and alter partition events for metastore event listeners Key: HIVE-2194 URL: https://issues.apache.org/jira/browse/HIVE-2194 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Sohan Jain Assignee: Sohan Jain Fix For: 0.8.0 Attachments: HIVE-2194.1.patch, HIVE-2194.3.patch, HIVE-2194.4.patch HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2194) Add actions for alter table and alter partition events for metastore event listeners
[ https://issues.apache.org/jira/browse/HIVE-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13060720#comment-13060720 ] Paul Yang commented on HIVE-2194: - +1 Will test and commit. Add actions for alter table and alter partition events for metastore event listeners Key: HIVE-2194 URL: https://issues.apache.org/jira/browse/HIVE-2194 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Sohan Jain Assignee: Sohan Jain Attachments: HIVE-2194.1.patch, HIVE-2194.3.patch HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2194) Add actions for alter table and alter partition events for metastore event listeners
[ https://issues.apache.org/jira/browse/HIVE-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13057463#comment-13057463 ] jirapos...@reviews.apache.org commented on HIVE-2194: - bq. On 2011-06-27 22:47:07, Paul Yang wrote: bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java, lines 142-144 bq. https://reviews.apache.org/r/853/diff/3/?file=21427#file21427line142 bq. bq. Can we check for equality between origP and the old partition instead of comparing fields? The equals() method fails, because the parameter transient_lastDdlTime is sometimes off by one. Otherwise, the two objects are entirely equal. I think the db name, table name, and list of values also ensures equality. bq. On 2011-06-27 22:47:07, Paul Yang wrote: bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java, lines 183-194 bq. https://reviews.apache.org/r/853/diff/3/?file=21427#file21427line183 bq. bq. origCols.equals(oldCols)? Fixed bq. On 2011-06-27 22:47:07, Paul Yang wrote: bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java, lines 159-161 bq. https://reviews.apache.org/r/853/diff/3/?file=21427#file21427line159 bq. bq. Same here The equals() method also fails here, even though the tables are logically equal. In the case above, tbl does not have a PrincipalPrivilegeSet. oldTable has a PrincipalPrivilegeSet, but all of it's fields are set to null. This discrepancy comes from how we get the tables, but I think they should still be considered equal. - Sohan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/853/#review920 --- On 2011-06-21 20:25:04, Sohan Jain wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/853/ bq. --- bq. bq. (Updated 2011-06-21 20:25:04) bq. bq. bq. Review request for hive and Paul Yang. bq. bq. bq. Summary bq. --- bq. bq. HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. Also, update the hive metastore to call the appropriate functions of the listeners when the events happen. bq. bq. bq. This addresses bug HIVE-2194. bq. https://issues.apache.org/jira/browse/HIVE-2194 bq. bq. bq. Diffs bq. - bq. bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1138144 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1138144 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 1138144 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1138144 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterPartitionEvent.java PRE-CREATION bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterTableEvent.java PRE-CREATION bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 1138144 bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1138144 bq. bq. Diff: https://reviews.apache.org/r/853/diff bq. bq. bq. Testing bq. --- bq. bq. Added test cases to TestMetaStoreEventListener. bq. bq. bq. Thanks, bq. bq. Sohan bq. bq. Add actions for alter table and alter partition events for metastore event listeners Key: HIVE-2194 URL: https://issues.apache.org/jira/browse/HIVE-2194 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Sohan Jain Assignee: Sohan Jain Attachments: HIVE-2194.1.patch, HIVE-2194.3.patch HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2194) Add actions for alter table and alter partition events for metastore event listeners
[ https://issues.apache.org/jira/browse/HIVE-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13057464#comment-13057464 ] jirapos...@reviews.apache.org commented on HIVE-2194: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/853/ --- (Updated 2011-06-29 20:48:43.096053) Review request for hive and Paul Yang. Changes --- -fixed Paul's comments Summary --- HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. Also, update the hive metastore to call the appropriate functions of the listeners when the events happen. This addresses bug HIVE-2194. https://issues.apache.org/jira/browse/HIVE-2194 Diffs (updated) - trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1140399 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1140399 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 1140399 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1140399 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterPartitionEvent.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterTableEvent.java PRE-CREATION trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 1140399 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1140399 Diff: https://reviews.apache.org/r/853/diff Testing --- Added test cases to TestMetaStoreEventListener. Thanks, Sohan Add actions for alter table and alter partition events for metastore event listeners Key: HIVE-2194 URL: https://issues.apache.org/jira/browse/HIVE-2194 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Sohan Jain Assignee: Sohan Jain Attachments: HIVE-2194.1.patch, HIVE-2194.3.patch HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2194) Add actions for alter table and alter partition events for metastore event listeners
[ https://issues.apache.org/jira/browse/HIVE-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13055983#comment-13055983 ] jirapos...@reviews.apache.org commented on HIVE-2194: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/853/#review920 --- trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java https://reviews.apache.org/r/853/#comment1983 Can we check for equality between origP and the old partition instead of comparing fields? trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java https://reviews.apache.org/r/853/#comment1982 Same here trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java https://reviews.apache.org/r/853/#comment1981 origCols.equals(oldCols)? - Paul On 2011-06-21 20:25:04, Sohan Jain wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/853/ bq. --- bq. bq. (Updated 2011-06-21 20:25:04) bq. bq. bq. Review request for hive and Paul Yang. bq. bq. bq. Summary bq. --- bq. bq. HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. Also, update the hive metastore to call the appropriate functions of the listeners when the events happen. bq. bq. bq. This addresses bug HIVE-2194. bq. https://issues.apache.org/jira/browse/HIVE-2194 bq. bq. bq. Diffs bq. - bq. bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1138144 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1138144 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 1138144 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1138144 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterPartitionEvent.java PRE-CREATION bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterTableEvent.java PRE-CREATION bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 1138144 bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1138144 bq. bq. Diff: https://reviews.apache.org/r/853/diff bq. bq. bq. Testing bq. --- bq. bq. Added test cases to TestMetaStoreEventListener. bq. bq. bq. Thanks, bq. bq. Sohan bq. bq. Add actions for alter table and alter partition events for metastore event listeners Key: HIVE-2194 URL: https://issues.apache.org/jira/browse/HIVE-2194 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Sohan Jain Assignee: Sohan Jain Attachments: HIVE-2194.1.patch, HIVE-2194.3.patch HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2194) Add actions for alter table and alter partition events for metastore event listeners
[ https://issues.apache.org/jira/browse/HIVE-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052805#comment-13052805 ] jirapos...@reviews.apache.org commented on HIVE-2194: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/853/ --- (Updated 2011-06-21 20:25:04.600512) Review request for hive and Paul Yang. Changes --- -updated test cases to resolve conflicts with new commits to trunk. Summary --- HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. Also, update the hive metastore to call the appropriate functions of the listeners when the events happen. This addresses bug HIVE-2194. https://issues.apache.org/jira/browse/HIVE-2194 Diffs (updated) - trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1138144 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1138144 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 1138144 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1138144 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterPartitionEvent.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterTableEvent.java PRE-CREATION trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 1138144 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1138144 Diff: https://reviews.apache.org/r/853/diff Testing --- Added test cases to TestMetaStoreEventListener. Thanks, Sohan Add actions for alter table and alter partition events for metastore event listeners Key: HIVE-2194 URL: https://issues.apache.org/jira/browse/HIVE-2194 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Sohan Jain Assignee: Sohan Jain Attachments: HIVE-2194.1.patch HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2194) Add actions for alter table and alter partition events for metastore event listeners
[ https://issues.apache.org/jira/browse/HIVE-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13048658#comment-13048658 ] jirapos...@reviews.apache.org commented on HIVE-2194: - bq. On 2011-06-03 20:55:01, Carl Steinbach wrote: bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java, line 54 bq. https://reviews.apache.org/r/853/diff/1/?file=20442#file20442line54 bq. bq. This method should either succeed or throw an exception. Since it already throws checked exceptions, adding a boolean return value makes things more complicated for the caller, and signals the same type of failure as an exception but without the ability to include information about what caused the failure. I think it would be better to modify the code so that an exception is always thrown when success==FALSE. bq. bq. This comment also applies to the various alterTable and alterPartition methods located in other classes. bq. bq. Sohan Jain wrote: bq. Thanks for your feedback, Carl. I understand your point about the return value of those functions. Is throwing a MetaException in the case of failure appropriate? bq. bq. Furthermore, I noticed that a few other RawStore operations return boolean values, such as dropDatabase, alterDatabase, dropTable, addPartition, etc. The return value in each case corresponds to successfully committing the transaction. Should we adopt a uniform interface across these functions? Hi, is there any update on this? Thanks for looking! - Sohan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/853/#review758 --- On 2011-06-06 23:23:50, Sohan Jain wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/853/ bq. --- bq. bq. (Updated 2011-06-06 23:23:50) bq. bq. bq. Review request for hive and Paul Yang. bq. bq. bq. Summary bq. --- bq. bq. HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. Also, update the hive metastore to call the appropriate functions of the listeners when the events happen. bq. bq. bq. This addresses bug HIVE-2194. bq. https://issues.apache.org/jira/browse/HIVE-2194 bq. bq. bq. Diffs bq. - bq. bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 1130342 bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterTableEvent.java PRE-CREATION bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/AlterHandler.java 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterPartitionEvent.java PRE-CREATION bq. bq. Diff: https://reviews.apache.org/r/853/diff bq. bq. bq. Testing bq. --- bq. bq. Added test cases to TestMetaStoreEventListener. bq. bq. bq. Thanks, bq. bq. Sohan bq. bq. Add actions for alter table and alter partition events for metastore event listeners Key: HIVE-2194 URL: https://issues.apache.org/jira/browse/HIVE-2194 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Sohan Jain Assignee: Sohan Jain Attachments: HIVE-2194.1.patch HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2194) Add actions for alter table and alter partition events for metastore event listeners
[ https://issues.apache.org/jira/browse/HIVE-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13045207#comment-13045207 ] jirapos...@reviews.apache.org commented on HIVE-2194: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/853/ --- (Updated 2011-06-06 23:23:50.520460) Review request for hive and Paul Yang. Changes --- - changed interface for alterTable and alterPartition back to void return type Summary --- HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. Also, update the hive metastore to call the appropriate functions of the listeners when the events happen. This addresses bug HIVE-2194. https://issues.apache.org/jira/browse/HIVE-2194 Diffs (updated) - trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 1130342 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1130342 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterTableEvent.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/AlterHandler.java 1130342 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1130342 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1130342 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 1130342 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1130342 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterPartitionEvent.java PRE-CREATION Diff: https://reviews.apache.org/r/853/diff Testing --- Added test cases to TestMetaStoreEventListener. Thanks, Sohan Add actions for alter table and alter partition events for metastore event listeners Key: HIVE-2194 URL: https://issues.apache.org/jira/browse/HIVE-2194 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Sohan Jain Assignee: Sohan Jain Attachments: HIVE-2194.1.patch HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2194) Add actions for alter table and alter partition events for metastore event listeners
[ https://issues.apache.org/jira/browse/HIVE-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13045208#comment-13045208 ] jirapos...@reviews.apache.org commented on HIVE-2194: - bq. On 2011-06-03 20:55:01, Carl Steinbach wrote: bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java, line 54 bq. https://reviews.apache.org/r/853/diff/1/?file=20442#file20442line54 bq. bq. This method should either succeed or throw an exception. Since it already throws checked exceptions, adding a boolean return value makes things more complicated for the caller, and signals the same type of failure as an exception but without the ability to include information about what caused the failure. I think it would be better to modify the code so that an exception is always thrown when success==FALSE. bq. bq. This comment also applies to the various alterTable and alterPartition methods located in other classes. Thanks for your feedback, Carl. I understand your point about the return value of those functions. Is throwing a MetaException in the case of failure appropriate? Furthermore, I noticed that a few other RawStore operations return boolean values, such as dropDatabase, alterDatabase, dropTable, addPartition, etc. The return value in each case corresponds to successfully committing the transaction. Should we adopt a uniform interface across these functions? - Sohan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/853/#review758 --- On 2011-06-03 20:20:03, Sohan Jain wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/853/ bq. --- bq. bq. (Updated 2011-06-03 20:20:03) bq. bq. bq. Review request for hive and Paul Yang. bq. bq. bq. Summary bq. --- bq. bq. HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. Also, update the hive metastore to call the appropriate functions of the listeners when the events happen. bq. bq. bq. This addresses bug HIVE-2194. bq. https://issues.apache.org/jira/browse/HIVE-2194 bq. bq. bq. Diffs bq. - bq. bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/AlterHandler.java 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1130342 bq.trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterPartitionEvent.java PRE-CREATION bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterTableEvent.java PRE-CREATION bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 1130342 bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1130342 bq. bq. Diff: https://reviews.apache.org/r/853/diff bq. bq. bq. Testing bq. --- bq. bq. Added test cases to TestMetaStoreEventListener. bq. bq. bq. Thanks, bq. bq. Sohan bq. bq. Add actions for alter table and alter partition events for metastore event listeners Key: HIVE-2194 URL: https://issues.apache.org/jira/browse/HIVE-2194 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Sohan Jain Assignee: Sohan Jain Attachments: HIVE-2194.1.patch HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2194) Add actions for alter table and alter partition events for metastore event listeners
[ https://issues.apache.org/jira/browse/HIVE-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13044016#comment-13044016 ] jirapos...@reviews.apache.org commented on HIVE-2194: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/853/ --- Review request for hive and Paul Yang. Summary --- HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. Also, update the hive metastore to call the appropriate functions of the listeners when the events happen. This addresses bug HIVE-2194. https://issues.apache.org/jira/browse/HIVE-2194 Diffs - trunk/metastore/src/java/org/apache/hadoop/hive/metastore/AlterHandler.java 1130342 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1130342 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1130342 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 1130342 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1130342 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1130342 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterPartitionEvent.java PRE-CREATION trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterTableEvent.java PRE-CREATION trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 1130342 trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1130342 Diff: https://reviews.apache.org/r/853/diff Testing --- Added test cases to TestMetaStoreEventListener. Thanks, Sohan Add actions for alter table and alter partition events for metastore event listeners Key: HIVE-2194 URL: https://issues.apache.org/jira/browse/HIVE-2194 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Sohan Jain Assignee: Sohan Jain Attachments: HIVE-2194.1.patch HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2194) Add actions for alter table and alter partition events for metastore event listeners
[ https://issues.apache.org/jira/browse/HIVE-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13044041#comment-13044041 ] jirapos...@reviews.apache.org commented on HIVE-2194: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/853/#review758 --- trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java https://reviews.apache.org/r/853/#comment1598 This method should either succeed or throw an exception. Since it already throws checked exceptions, adding a boolean return value makes things more complicated for the caller, and signals the same type of failure as an exception but without the ability to include information about what caused the failure. I think it would be better to modify the code so that an exception is always thrown when success==FALSE. This comment also applies to the various alterTable and alterPartition methods located in other classes. - Carl On 2011-06-03 20:20:03, Sohan Jain wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/853/ bq. --- bq. bq. (Updated 2011-06-03 20:20:03) bq. bq. bq. Review request for hive and Paul Yang. bq. bq. bq. Summary bq. --- bq. bq. HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. Also, update the hive metastore to call the appropriate functions of the listeners when the events happen. bq. bq. bq. This addresses bug HIVE-2194. bq. https://issues.apache.org/jira/browse/HIVE-2194 bq. bq. bq. Diffs bq. - bq. bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/AlterHandler.java 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1130342 bq.trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterPartitionEvent.java PRE-CREATION bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterTableEvent.java PRE-CREATION bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java 1130342 bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java 1130342 bq. bq. Diff: https://reviews.apache.org/r/853/diff bq. bq. bq. Testing bq. --- bq. bq. Added test cases to TestMetaStoreEventListener. bq. bq. bq. Thanks, bq. bq. Sohan bq. bq. Add actions for alter table and alter partition events for metastore event listeners Key: HIVE-2194 URL: https://issues.apache.org/jira/browse/HIVE-2194 Project: Hive Issue Type: Improvement Components: Metastore Reporter: Sohan Jain Assignee: Sohan Jain Attachments: HIVE-2194.1.patch HIVE-2038 introduced the MetaStoreEventListener abstract class that defines actions to be performed after particular events on a metastore. Improve upon that class by adding events to be performed on alter table and alter partition actions. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
