[jira] [Commented] (HIVE-243) ^C breaks out of running query, but not whole CLI

2011-06-10 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047043#comment-13047043
 ] 

Hudson commented on HIVE-243:
-

Integrated in Hive-trunk-h0.21 #771 (See 
[https://builds.apache.org/job/Hive-trunk-h0.21/771/])
HIVE-2211. Fix a bug caused by HIVE-243 (Siying Dong via Ning Zhang)

nzhang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134179
Files : 
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java


> ^C breaks out of running query, but not whole CLI
> -
>
> Key: HIVE-243
> URL: https://issues.apache.org/jira/browse/HIVE-243
> Project: Hive
>  Issue Type: Wish
>  Components: Query Processor
>Affects Versions: 0.8.0
>Reporter: Adam Kramer
>Assignee: George Djabarov
> Fix For: 0.8.0
>
> Attachments: HIVE-243.patch
>
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it. 
> I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was 
> some control character to break out of a query without breaking out of the 
> CLI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-243) ^C breaks out of running query, but not whole CLI

2011-05-17 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035190#comment-13035190
 ] 

Hudson commented on HIVE-243:
-

Integrated in Hive-trunk-h0.21 #735 (See 
[https://builds.apache.org/hudson/job/Hive-trunk-h0.21/735/])
HIVE-243. ^C breaks out of running query, but not whole CLI (George 
Djabarov via Ning Zhang)

nzhang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1104625
Files : 
* 
/hive/trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptUtils.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
* 
/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
* /hive/trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
* 
/hive/trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java


> ^C breaks out of running query, but not whole CLI
> -
>
> Key: HIVE-243
> URL: https://issues.apache.org/jira/browse/HIVE-243
> Project: Hive
>  Issue Type: Wish
>  Components: Query Processor
>Affects Versions: 0.8.0
>Reporter: Adam Kramer
>Assignee: George Djabarov
> Fix For: 0.8.0
>
> Attachments: HIVE-243.patch
>
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it. 
> I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was 
> some control character to break out of a query without breaking out of the 
> CLI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-243) ^C breaks out of running query, but not whole CLI

2011-05-17 Thread jirapos...@reviews.apache.org (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034973#comment-13034973
 ] 

jirapos...@reviews.apache.org commented on HIVE-243:



---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/
---

(Updated 2011-05-17 18:56:20.310048)


Review request for hive.


Changes
---

updating diff against the latest trunk


Summary
---

Fixed by adding INT signal hander that interrupts the CLI thread. The CLI 
thread gets InterruptedException and it stops the current command.


This addresses bug HIVE-243.
https://issues.apache.org/jira/browse/HIVE-243


Diffs (updated)
-

  trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1104456 
  
trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java 
PRE-CREATION 
  trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptUtils.java 
PRE-CREATION 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 
1104456 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1104456 

Diff: https://reviews.apache.org/r/626/diff


Testing
---

Manual test Ctrl+C on bunch of command (show tables, select, etc)
Tested interrupting the command on large data set in different stages of the 
processing (JDO, MapReduce, building the input summary).
example queries:
explain select count(*) from xyz where ds = '2011-02-01';
select count(*) from xyz where ds = '2011-02-01';


Thanks,

georgedj



> ^C breaks out of running query, but not whole CLI
> -
>
> Key: HIVE-243
> URL: https://issues.apache.org/jira/browse/HIVE-243
> Project: Hive
>  Issue Type: Wish
>  Components: Query Processor
>Affects Versions: 0.8.0
>Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it. 
> I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was 
> some control character to break out of a query without breaking out of the 
> CLI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-243) ^C breaks out of running query, but not whole CLI

2011-05-14 Thread jirapos...@reviews.apache.org (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033481#comment-13033481
 ] 

jirapos...@reviews.apache.org commented on HIVE-243:



---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/#review670
---



trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java


Is this comment correct?



trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java


typo: interrup -> interrupt.



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java


We shouldn't check interrupt here since ObjectStore should be run at the 
metastore server side (if Hive is running non-local mode for metastore). So ^C 
on CLI won't be detected here. Instead we should check it in 
HiveMetaStoreClient.java. 

Since interrupting JDO is quite complicated, I suggest removing the 
interrupt handling for JDO completely in this JIRA and file a separate JIRA for 
that. 



trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java


typo: interrup -> interrupt



trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java


why these are removed?


- Ning


On 2011-05-10 21:55:56, georgedj wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/626/
bq.  ---
bq.  
bq.  (Updated 2011-05-10 21:55:56)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  Fixed by adding INT signal hander that interrupts the CLI thread. The CLI 
thread gets InterruptedException and it stops the current command.
bq.  
bq.  
bq.  This addresses bug HIVE-243.
bq.  https://issues.apache.org/jira/browse/HIVE-243
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1100312 
bq.
trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java 
PRE-CREATION 
bq.
trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptUtils.java 
PRE-CREATION 
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
1100312 
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 
1100312 
bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1100312 
bq.  
bq.  Diff: https://reviews.apache.org/r/626/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Manual test Ctrl+C on bunch of command (show tables, select, etc)
bq.  Tested interrupting the command on large data set in different stages of 
the processing (JDO, MapReduce, building the input summary).
bq.  example queries:
bq.  explain select count(*) from xyz where ds = '2011-02-01';
bq.  select count(*) from xyz where ds = '2011-02-01';
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  georgedj
bq.  
bq.



> ^C breaks out of running query, but not whole CLI
> -
>
> Key: HIVE-243
> URL: https://issues.apache.org/jira/browse/HIVE-243
> Project: Hive
>  Issue Type: Wish
>  Components: Query Processor
>Affects Versions: 0.8.0
>Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it. 
> I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was 
> some control character to break out of a query without breaking out of the 
> CLI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-243) ^C breaks out of running query, but not whole CLI

2011-05-10 Thread jirapos...@reviews.apache.org (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031404#comment-13031404
 ] 

jirapos...@reviews.apache.org commented on HIVE-243:



---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/
---

(Updated 2011-05-10 21:55:56.707055)


Review request for hive.


Changes
---

Fixed some white space formatting


Summary
---

Fixed by adding INT signal hander that interrupts the CLI thread. The CLI 
thread gets InterruptedException and it stops the current command.


This addresses bug HIVE-243.
https://issues.apache.org/jira/browse/HIVE-243


Diffs (updated)
-

  trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1100312 
  
trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java 
PRE-CREATION 
  trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptUtils.java 
PRE-CREATION 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
1100312 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 
1100312 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1100312 

Diff: https://reviews.apache.org/r/626/diff


Testing
---

Manual test Ctrl+C on bunch of command (show tables, select, etc)
Tested interrupting the command on large data set in different stages of the 
processing (JDO, MapReduce, building the input summary).
example queries:
explain select count(*) from xyz where ds = '2011-02-01';
select count(*) from xyz where ds = '2011-02-01';


Thanks,

georgedj



> ^C breaks out of running query, but not whole CLI
> -
>
> Key: HIVE-243
> URL: https://issues.apache.org/jira/browse/HIVE-243
> Project: Hive
>  Issue Type: Wish
>  Components: Query Processor
>Affects Versions: 0.8.0
>Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it. 
> I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was 
> some control character to break out of a query without breaking out of the 
> CLI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-243) ^C breaks out of running query, but not whole CLI

2011-05-10 Thread jirapos...@reviews.apache.org (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031394#comment-13031394
 ] 

jirapos...@reviews.apache.org commented on HIVE-243:



---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/
---

(Updated 2011-05-10 21:33:17.693931)


Review request for hive.


Summary
---

Fixed by adding INT signal hander that interrupts the CLI thread. The CLI 
thread gets InterruptedException and it stops the current command.


This addresses bug HIVE-243.
https://issues.apache.org/jira/browse/HIVE-243


Diffs
-

  trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1100312 
  
trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java 
PRE-CREATION 
  trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptUtils.java 
PRE-CREATION 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
1100312 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 
1100312 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1100312 

Diff: https://reviews.apache.org/r/626/diff


Testing (updated)
---

Manual test Ctrl+C on bunch of command (show tables, select, etc)
Tested interrupting the command on large data set in different stages of the 
processing (JDO, MapReduce, building the input summary).
example queries:
explain select count(*) from xyz where ds = '2011-02-01';
select count(*) from xyz where ds = '2011-02-01';


Thanks,

georgedj



> ^C breaks out of running query, but not whole CLI
> -
>
> Key: HIVE-243
> URL: https://issues.apache.org/jira/browse/HIVE-243
> Project: Hive
>  Issue Type: Wish
>  Components: Query Processor
>Affects Versions: 0.8.0
>Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it. 
> I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was 
> some control character to break out of a query without breaking out of the 
> CLI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-243) ^C breaks out of running query, but not whole CLI

2011-05-10 Thread jirapos...@reviews.apache.org (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031386#comment-13031386
 ] 

jirapos...@reviews.apache.org commented on HIVE-243:



---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/
---

(Updated 2011-05-10 21:25:03.998477)


Review request for hive.


Changes
---

- First ctrl+c will print a message and try to stop the current command. Second 
ctrl+c will kill the jvm
- Added code that stops some of the JDO processing
- Now the code can also stop generating input summary.
- Fixed loop in Utilities.getInputSummary that hangs under some conditions


Summary
---

Fixed by adding INT signal hander that interrupts the CLI thread. The CLI 
thread gets InterruptedException and it stops the current command.


This addresses bug HIVE-243.
https://issues.apache.org/jira/browse/HIVE-243


Diffs (updated)
-

  trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1100312 
  
trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java 
PRE-CREATION 
  trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptUtils.java 
PRE-CREATION 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
1100312 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 
1100312 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1100312 

Diff: https://reviews.apache.org/r/626/diff


Testing
---

Manual test Ctrl+C on bunch of command (show tables, select, etc)


Thanks,

georgedj



> ^C breaks out of running query, but not whole CLI
> -
>
> Key: HIVE-243
> URL: https://issues.apache.org/jira/browse/HIVE-243
> Project: Hive
>  Issue Type: Wish
>  Components: Query Processor
>Affects Versions: 0.8.0
>Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it. 
> I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was 
> some control character to break out of a query without breaking out of the 
> CLI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-243) ^C breaks out of running query, but not whole CLI

2011-05-10 Thread jirapos...@reviews.apache.org (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031388#comment-13031388
 ] 

jirapos...@reviews.apache.org commented on HIVE-243:




bq.  On 2011-04-20 17:51:59, Ning Zhang wrote:
bq.  > trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java, line 313
bq.  > 
bq.  >
bq.  > Does this handle the case when a MapReduce job is launched and CLI 
got a CTL+C? Currently we have a JVM shutdownHook defined in 
HadoopJobExecHelper.java to kill the MR job before the JVM shut down (the old 
behavior when hitting a CTL+C). 
bq.  > 
bq.  > Here if we don't shut down the JVM, you should do the same thing to 
kill the running MR jobs.

Sorry for the delayed response, I didn't get email notification for the 
comment. Let me try to hookup the running jobs kill to the ctrl+c handler. I 
don't think it will do it with the current code as it will prevent the shutdown 
hook of being called.


- georgedj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/#review505
---


On 2011-05-10 21:25:03, georgedj wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/626/
bq.  ---
bq.  
bq.  (Updated 2011-05-10 21:25:03)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  Fixed by adding INT signal hander that interrupts the CLI thread. The CLI 
thread gets InterruptedException and it stops the current command.
bq.  
bq.  
bq.  This addresses bug HIVE-243.
bq.  https://issues.apache.org/jira/browse/HIVE-243
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1100312 
bq.
trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java 
PRE-CREATION 
bq.
trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptUtils.java 
PRE-CREATION 
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
1100312 
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 
1100312 
bq.trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1100312 
bq.  
bq.  Diff: https://reviews.apache.org/r/626/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Manual test Ctrl+C on bunch of command (show tables, select, etc)
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  georgedj
bq.  
bq.



> ^C breaks out of running query, but not whole CLI
> -
>
> Key: HIVE-243
> URL: https://issues.apache.org/jira/browse/HIVE-243
> Project: Hive
>  Issue Type: Wish
>  Components: Query Processor
>Affects Versions: 0.8.0
>Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it. 
> I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was 
> some control character to break out of a query without breaking out of the 
> CLI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-243) ^C breaks out of running query, but not whole CLI

2011-04-28 Thread jirapos...@reviews.apache.org (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026743#comment-13026743
 ] 

jirapos...@reviews.apache.org commented on HIVE-243:



---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/#review609
---



trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java


This change kills the launched MR job. however the following interrupt() 
only called to the current thread. This does not really behaves what it is 
expected to be when there are multiple threads running. 

For example when we are getting partitions from metastore (JDO may use its 
thread pool) and when getting HDFS summaries (we are also using thread pool). 
For these situations we probably need to interrupt all child threads. 


- Ning


On 2011-04-28 20:54:48, georgedj wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/626/
bq.  ---
bq.  
bq.  (Updated 2011-04-28 20:54:48)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  Fixed by adding INT signal hander that interrupts the CLI thread. The CLI 
thread gets InterruptedException and it stops the current command.
bq.  
bq.  
bq.  This addresses bug HIVE-243.
bq.  https://issues.apache.org/jira/browse/HIVE-243
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1097569 
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 
1097569 
bq.  
bq.  Diff: https://reviews.apache.org/r/626/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Manual test Ctrl+C on bunch of command (show tables, select, etc)
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  georgedj
bq.  
bq.



> ^C breaks out of running query, but not whole CLI
> -
>
> Key: HIVE-243
> URL: https://issues.apache.org/jira/browse/HIVE-243
> Project: Hive
>  Issue Type: Wish
>  Components: Query Processor
>Affects Versions: 0.8.0
>Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it. 
> I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was 
> some control character to break out of a query without breaking out of the 
> CLI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-243) ^C breaks out of running query, but not whole CLI

2011-04-28 Thread jirapos...@reviews.apache.org (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026671#comment-13026671
 ] 

jirapos...@reviews.apache.org commented on HIVE-243:



---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/
---

(Updated 2011-04-28 20:54:48.288055)


Review request for hive.


Changes
---

Added code to kill all running jobs before interrupting the current CLI thread.


Summary
---

Fixed by adding INT signal hander that interrupts the CLI thread. The CLI 
thread gets InterruptedException and it stops the current command.


This addresses bug HIVE-243.
https://issues.apache.org/jira/browse/HIVE-243


Diffs (updated)
-

  trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1097569 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 
1097569 

Diff: https://reviews.apache.org/r/626/diff


Testing
---

Manual test Ctrl+C on bunch of command (show tables, select, etc)


Thanks,

georgedj



> ^C breaks out of running query, but not whole CLI
> -
>
> Key: HIVE-243
> URL: https://issues.apache.org/jira/browse/HIVE-243
> Project: Hive
>  Issue Type: Wish
>  Components: Query Processor
>Affects Versions: 0.8.0
>Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it. 
> I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was 
> some control character to break out of a query without breaking out of the 
> CLI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-243) ^C breaks out of running query, but not whole CLI

2011-04-20 Thread Ning Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022259#comment-13022259
 ] 

Ning Zhang commented on HIVE-243:
-

@George, thanks for taking this! I've updated the review board with a comment. 
Mostly to make sure that this patch kills the MR job also when getting a CTL+C. 

> ^C breaks out of running query, but not whole CLI
> -
>
> Key: HIVE-243
> URL: https://issues.apache.org/jira/browse/HIVE-243
> Project: Hive
>  Issue Type: Wish
>  Components: Query Processor
>Affects Versions: 0.8.0
>Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it. 
> I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was 
> some control character to break out of a query without breaking out of the 
> CLI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-243) ^C breaks out of running query, but not whole CLI

2011-04-20 Thread jirapos...@reviews.apache.org (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022256#comment-13022256
 ] 

jirapos...@reviews.apache.org commented on HIVE-243:



---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/#review505
---



trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java


Does this handle the case when a MapReduce job is launched and CLI got a 
CTL+C? Currently we have a JVM shutdownHook defined in HadoopJobExecHelper.java 
to kill the MR job before the JVM shut down (the old behavior when hitting a 
CTL+C). 

Here if we don't shut down the JVM, you should do the same thing to kill 
the running MR jobs. 


- Ning


On 2011-04-20 16:49:05, georgedj wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/626/
bq.  ---
bq.  
bq.  (Updated 2011-04-20 16:49:05)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  Fixed by adding INT signal hander that interrupts the CLI thread. The CLI 
thread gets InterruptedException and it stops the current command.
bq.  
bq.  
bq.  This addresses bug HIVE-243.
bq.  https://issues.apache.org/jira/browse/HIVE-243
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1095439 
bq.  
bq.  Diff: https://reviews.apache.org/r/626/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Manual test Ctrl+C on bunch of command (show tables, select, etc)
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  georgedj
bq.  
bq.



> ^C breaks out of running query, but not whole CLI
> -
>
> Key: HIVE-243
> URL: https://issues.apache.org/jira/browse/HIVE-243
> Project: Hive
>  Issue Type: Wish
>  Components: Query Processor
>Affects Versions: 0.8.0
>Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it. 
> I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was 
> some control character to break out of a query without breaking out of the 
> CLI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-243) ^C breaks out of running query, but not whole CLI

2011-04-20 Thread jirapos...@reviews.apache.org (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022216#comment-13022216
 ] 

jirapos...@reviews.apache.org commented on HIVE-243:



---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/
---

(Updated 2011-04-20 16:49:05.429702)


Review request for hive.


Summary (updated)
---

Fixed by adding INT signal hander that interrupts the CLI thread. The CLI 
thread gets InterruptedException and it stops the current command.


This addresses bug HIVE-243.
https://issues.apache.org/jira/browse/HIVE-243


Diffs
-

  trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1095439 

Diff: https://reviews.apache.org/r/626/diff


Testing
---

Manual test Ctrl+C on bunch of command (show tables, select, etc)


Thanks,

georgedj



> ^C breaks out of running query, but not whole CLI
> -
>
> Key: HIVE-243
> URL: https://issues.apache.org/jira/browse/HIVE-243
> Project: Hive
>  Issue Type: Wish
>  Components: Query Processor
>Affects Versions: 0.8.0
>Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it. 
> I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was 
> some control character to break out of a query without breaking out of the 
> CLI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-243) ^C breaks out of running query, but not whole CLI

2011-04-20 Thread jirapos...@reviews.apache.org (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022215#comment-13022215
 ] 

jirapos...@reviews.apache.org commented on HIVE-243:



---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/
---

Review request for hive.


Summary
---

Fixed by adding INT signal hander that interrupts the CLI thread. The CLI 
thread gets InterruptedException and it stops the current command.


This addresses bug HIVE-243.
https://issues.apache.org/jira/browse/HIVE-243


Diffs
-

  trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1095439 

Diff: https://reviews.apache.org/r/626/diff


Testing
---

Manual test Ctrl+C on bunch of command (show tables, select, etc)


Thanks,

georgedj



> ^C breaks out of running query, but not whole CLI
> -
>
> Key: HIVE-243
> URL: https://issues.apache.org/jira/browse/HIVE-243
> Project: Hive
>  Issue Type: Wish
>  Components: Query Processor
>Affects Versions: 0.8.0
>Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it. 
> I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was 
> some control character to break out of a query without breaking out of the 
> CLI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-243) ^C breaks out of running query, but not whole CLI

2011-04-19 Thread George Djabarov (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021891#comment-13021891
 ] 

George Djabarov commented on HIVE-243:
--

I have a patch that fixes this by handling the INT signal and interrupting the 
CLI thread. Most commands do behave when interrupted (with some error message).

> ^C breaks out of running query, but not whole CLI
> -
>
> Key: HIVE-243
> URL: https://issues.apache.org/jira/browse/HIVE-243
> Project: Hive
>  Issue Type: Wish
>  Components: Query Processor
>Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it. 
> I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was 
> some control character to break out of a query without breaking out of the 
> CLI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira