Re: Review Request 17163: HIVE-5929 - SQL std auth - Access control statement updates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17163/ --- (Updated Jan. 27, 2014, 11:22 p.m.) Review request for hive and Ashutosh Chauhan. Changes --- HIVE-5929.5.patch - fixes the unit test failures (change in SessionState.start, to create a copy of HiveConf before calling Hive.get(conf) ). Bugs: HIVE-5929 https://issues.apache.org/jira/browse/HIVE-5929 Repository: hive-git Description --- Subtask for sql standard based auth, for performing the updates to metastore from newly supported access control statements . Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/Driver.java cb0c1a5 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 92ed55b ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java c65bf28 ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java c41cd0f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/DefaultHiveAuthorizerFactory.java 7470e9d ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java 8e4114f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationPluginException.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 63046f5 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c10a2ac ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java ca95bfc ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactory.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 08f7fec ql/src/test/queries/clientpositive/authorization_1_sql_std.q PRE-CREATION ql/src/test/queries/clientpositive/authorization_role_grant1.q 1a375a5 ql/src/test/results/clientpositive/authorization_1_sql_std.q.out PRE-CREATION ql/src/test/results/clientpositive/authorization_role_grant1.q.out 496687c Diff: https://reviews.apache.org/r/17163/diff/ Testing --- .q tests included. Thanks, Thejas Nair
Re: Review Request 17163: HIVE-5929 - SQL std auth - Access control statement updates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17163/#review32912 --- ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java https://reviews.apache.org/r/17163/#comment61936 Anytime we are doing a switch on an enum and the default condition is illegal, the default should throw AssertionError(). ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java https://reviews.apache.org/r/17163/#comment61939 Thanks for cleaning this up! ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java https://reviews.apache.org/r/17163/#comment61937 same ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java https://reviews.apache.org/r/17163/#comment61938 same ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java https://reviews.apache.org/r/17163/#comment61943 space missing in error message ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java https://reviews.apache.org/r/17163/#comment61940 same - Brock Noland On Jan. 27, 2014, 11:22 p.m., Thejas Nair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17163/ --- (Updated Jan. 27, 2014, 11:22 p.m.) Review request for hive and Ashutosh Chauhan. Bugs: HIVE-5929 https://issues.apache.org/jira/browse/HIVE-5929 Repository: hive-git Description --- Subtask for sql standard based auth, for performing the updates to metastore from newly supported access control statements . Diffs - ql/src/java/org/apache/hadoop/hive/ql/Driver.java cb0c1a5 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 92ed55b ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java c65bf28 ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java c41cd0f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/DefaultHiveAuthorizerFactory.java 7470e9d ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java 8e4114f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationPluginException.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 63046f5 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c10a2ac ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java ca95bfc ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactory.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 08f7fec ql/src/test/queries/clientpositive/authorization_1_sql_std.q PRE-CREATION ql/src/test/queries/clientpositive/authorization_role_grant1.q 1a375a5 ql/src/test/results/clientpositive/authorization_1_sql_std.q.out PRE-CREATION ql/src/test/results/clientpositive/authorization_role_grant1.q.out 496687c Diff: https://reviews.apache.org/r/17163/diff/ Testing --- .q tests included. Thanks, Thejas Nair
Re: Review Request 17163: HIVE-5929 - SQL std auth - Access control statement updates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17163/ --- (Updated Jan. 28, 2014, 12:35 a.m.) Review request for hive and Ashutosh Chauhan. Changes --- HIVE-5929.6.patch - address review comments Bugs: HIVE-5929 https://issues.apache.org/jira/browse/HIVE-5929 Repository: hive-git Description --- Subtask for sql standard based auth, for performing the updates to metastore from newly supported access control statements . Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/Driver.java cb0c1a5 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 92ed55b ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java c65bf28 ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java c41cd0f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/DefaultHiveAuthorizerFactory.java 7470e9d ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java 8e4114f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationPluginException.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 63046f5 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c10a2ac ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java ca95bfc ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactory.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 08f7fec ql/src/test/queries/clientpositive/authorization_1_sql_std.q PRE-CREATION ql/src/test/queries/clientpositive/authorization_role_grant1.q 1a375a5 ql/src/test/results/clientpositive/authorization_1_sql_std.q.out PRE-CREATION ql/src/test/results/clientpositive/authorization_role_grant1.q.out 496687c Diff: https://reviews.apache.org/r/17163/diff/ Testing --- .q tests included. Thanks, Thejas Nair
Re: Review Request 17163: HIVE-5929 - SQL std auth - Access control statement updates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17163/#review32517 --- ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationPluginException.java https://reviews.apache.org/r/17163/#comment61384 If we make it extend HiveException than we can avoid all those try-catches which catch this exception and rethrow HiveException. ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java https://reviews.apache.org/r/17163/#comment61385 This can be removed. ql/src/test/queries/clientpositive/authorization_1_sql_std.q https://reviews.apache.org/r/17163/#comment61392 If you don't intent to have this in test case, better to just delete it. ql/src/test/queries/clientpositive/authorization_1_sql_std.q https://reviews.apache.org/r/17163/#comment61393 Same as above. - Ashutosh Chauhan On Jan. 22, 2014, 12:17 a.m., Thejas Nair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17163/ --- (Updated Jan. 22, 2014, 12:17 a.m.) Review request for hive and Ashutosh Chauhan. Bugs: HIVE-5929 https://issues.apache.org/jira/browse/HIVE-5929 Repository: hive-git Description --- Subtask for sql standard based auth, for performing the updates to metastore from newly supported access control statements . Diffs - ql/src/java/org/apache/hadoop/hive/ql/Driver.java bd95161 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 92ed55b ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java c65bf28 ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java c41cd0f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/DefaultHiveAuthorizerFactory.java 7470e9d ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java 8e4114f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationPluginException.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 63046f5 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c10a2ac ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java ca95bfc ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactory.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 08f7fec ql/src/test/queries/clientpositive/authorization_1_sql_std.q PRE-CREATION ql/src/test/queries/clientpositive/authorization_role_grant1.q 1a375a5 ql/src/test/results/clientpositive/authorization_1_sql_std.q.out PRE-CREATION ql/src/test/results/clientpositive/authorization_role_grant1.q.out 496687c Diff: https://reviews.apache.org/r/17163/diff/ Testing --- .q tests included. Thanks, Thejas Nair
Re: Review Request 17163: HIVE-5929 - SQL std auth - Access control statement updates
On Jan. 22, 2014, 7:58 p.m., Ashutosh Chauhan wrote: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationPluginException.java, line 27 https://reviews.apache.org/r/17163/diff/2/?file=433855#file433855line27 If we make it extend HiveException than we can avoid all those try-catches which catch this exception and rethrow HiveException. If we extend HiveException, HiveException has to become a public API, and so does ErrorMsg . It didn't seem like a good idea to make ErrorMsg public. Let me know if you think otherwise. On Jan. 22, 2014, 7:58 p.m., Ashutosh Chauhan wrote: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java, line 32 https://reviews.apache.org/r/17163/diff/2/?file=433861#file433861line32 This can be removed. fixing On Jan. 22, 2014, 7:58 p.m., Ashutosh Chauhan wrote: ql/src/test/queries/clientpositive/authorization_1_sql_std.q, line 13 https://reviews.apache.org/r/17163/diff/2/?file=433864#file433864line13 If you don't intent to have this in test case, better to just delete it. fixing On Jan. 22, 2014, 7:58 p.m., Ashutosh Chauhan wrote: ql/src/test/queries/clientpositive/authorization_1_sql_std.q, line 27 https://reviews.apache.org/r/17163/diff/2/?file=433864#file433864line27 Same as above. fixing - Thejas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17163/#review32517 --- On Jan. 22, 2014, 12:17 a.m., Thejas Nair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17163/ --- (Updated Jan. 22, 2014, 12:17 a.m.) Review request for hive and Ashutosh Chauhan. Bugs: HIVE-5929 https://issues.apache.org/jira/browse/HIVE-5929 Repository: hive-git Description --- Subtask for sql standard based auth, for performing the updates to metastore from newly supported access control statements . Diffs - ql/src/java/org/apache/hadoop/hive/ql/Driver.java bd95161 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 92ed55b ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java c65bf28 ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java c41cd0f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/DefaultHiveAuthorizerFactory.java 7470e9d ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java 8e4114f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationPluginException.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 63046f5 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c10a2ac ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java ca95bfc ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactory.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 08f7fec ql/src/test/queries/clientpositive/authorization_1_sql_std.q PRE-CREATION ql/src/test/queries/clientpositive/authorization_role_grant1.q 1a375a5 ql/src/test/results/clientpositive/authorization_1_sql_std.q.out PRE-CREATION ql/src/test/results/clientpositive/authorization_role_grant1.q.out 496687c Diff: https://reviews.apache.org/r/17163/diff/ Testing --- .q tests included. Thanks, Thejas Nair
Re: Review Request 17163: HIVE-5929 - SQL std auth - Access control statement updates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17163/ --- (Updated Jan. 22, 2014, 8:19 p.m.) Review request for hive and Ashutosh Chauhan. Bugs: HIVE-5929 https://issues.apache.org/jira/browse/HIVE-5929 Repository: hive-git Description --- Subtask for sql standard based auth, for performing the updates to metastore from newly supported access control statements . Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/Driver.java bd95161 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 92ed55b ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java c65bf28 ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java c41cd0f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/DefaultHiveAuthorizerFactory.java 7470e9d ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java 8e4114f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationPluginException.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 63046f5 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c10a2ac ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java ca95bfc ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactory.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 08f7fec ql/src/test/queries/clientpositive/authorization_1_sql_std.q PRE-CREATION ql/src/test/queries/clientpositive/authorization_role_grant1.q 1a375a5 ql/src/test/results/clientpositive/authorization_1_sql_std.q.out PRE-CREATION ql/src/test/results/clientpositive/authorization_role_grant1.q.out 496687c Diff: https://reviews.apache.org/r/17163/diff/ Testing --- .q tests included. Thanks, Thejas Nair
Re: Review Request 17163: HIVE-5929 - SQL std auth - Access control statement updates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17163/ --- (Updated Jan. 22, 2014, 10:53 p.m.) Review request for hive and Ashutosh Chauhan. Changes --- also changeing the pluginexception to inherit from HiveException. On second thoughts, the change does not really expose HiveException api's to the user. Bugs: HIVE-5929 https://issues.apache.org/jira/browse/HIVE-5929 Repository: hive-git Description --- Subtask for sql standard based auth, for performing the updates to metastore from newly supported access control statements . Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/Driver.java bd95161 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 92ed55b ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java c65bf28 ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java c41cd0f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/DefaultHiveAuthorizerFactory.java 7470e9d ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java 8e4114f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationPluginException.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 63046f5 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c10a2ac ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java ca95bfc ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactory.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 08f7fec ql/src/test/queries/clientpositive/authorization_1_sql_std.q PRE-CREATION ql/src/test/queries/clientpositive/authorization_role_grant1.q 1a375a5 ql/src/test/results/clientpositive/authorization_1_sql_std.q.out PRE-CREATION ql/src/test/results/clientpositive/authorization_role_grant1.q.out 496687c Diff: https://reviews.apache.org/r/17163/diff/ Testing --- .q tests included. Thanks, Thejas Nair
Re: Review Request 17163: HIVE-5929 - SQL std auth - Access control statement updates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17163/#review32579 --- Ship it! Ship It! - Ashutosh Chauhan On Jan. 22, 2014, 10:53 p.m., Thejas Nair wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17163/ --- (Updated Jan. 22, 2014, 10:53 p.m.) Review request for hive and Ashutosh Chauhan. Bugs: HIVE-5929 https://issues.apache.org/jira/browse/HIVE-5929 Repository: hive-git Description --- Subtask for sql standard based auth, for performing the updates to metastore from newly supported access control statements . Diffs - ql/src/java/org/apache/hadoop/hive/ql/Driver.java bd95161 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 92ed55b ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java c65bf28 ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java c41cd0f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/DefaultHiveAuthorizerFactory.java 7470e9d ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java 8e4114f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationPluginException.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 63046f5 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c10a2ac ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java ca95bfc ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactory.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 08f7fec ql/src/test/queries/clientpositive/authorization_1_sql_std.q PRE-CREATION ql/src/test/queries/clientpositive/authorization_role_grant1.q 1a375a5 ql/src/test/results/clientpositive/authorization_1_sql_std.q.out PRE-CREATION ql/src/test/results/clientpositive/authorization_role_grant1.q.out 496687c Diff: https://reviews.apache.org/r/17163/diff/ Testing --- .q tests included. Thanks, Thejas Nair
Re: Review Request 17163: HIVE-5929 - SQL std auth - Access control statement updates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17163/ --- (Updated Jan. 22, 2014, 12:17 a.m.) Review request for hive and Ashutosh Chauhan. Changes --- removing trailing whitespace, and other cosmetic cleanup Bugs: HIVE-5929 https://issues.apache.org/jira/browse/HIVE-5929 Repository: hive-git Description --- Subtask for sql standard based auth, for performing the updates to metastore from newly supported access control statements . Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/Driver.java bd95161 ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 92ed55b ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java c65bf28 ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java c41cd0f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/DefaultHiveAuthorizerFactory.java 7470e9d ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java 8e4114f ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationPluginException.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 63046f5 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java c10a2ac ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java ca95bfc ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeInfo.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactory.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 08f7fec ql/src/test/queries/clientpositive/authorization_1_sql_std.q PRE-CREATION ql/src/test/queries/clientpositive/authorization_role_grant1.q 1a375a5 ql/src/test/results/clientpositive/authorization_1_sql_std.q.out PRE-CREATION ql/src/test/results/clientpositive/authorization_role_grant1.q.out 496687c Diff: https://reviews.apache.org/r/17163/diff/ Testing --- .q tests included. Thanks, Thejas Nair
