Re: Review Request 27900: HIVE-8739
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27900/ --- (Updated Nov. 15, 2014, 12:14 a.m.) Review request for hive. Repository: hive-git Description --- see jira Diffs (updated) - metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 82f504f Diff: https://reviews.apache.org/r/27900/diff/ Testing --- Thanks, Sergey Shelukhin
Re: Review Request 27900: HIVE-8739
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27900/ --- (Updated Nov. 13, 2014, 10:26 p.m.) Review request for hive. Repository: hive-git Description --- see jira Diffs (updated) - metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 82f504f Diff: https://reviews.apache.org/r/27900/diff/ Testing --- Thanks, Sergey Shelukhin
Re: Review Request 27900: HIVE-8739
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27900/#review61329 --- metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java https://reviews.apache.org/r/27900/#comment102897 Wondering if this method can be used to determine other DBs as well like MSSQL, ORACLE? Seems like method getDBProdName() is meant specificly for this purpose. This requires testing on other DBs, so perhaps this could be done in a follow-up jira. But, it will be good to leave a TODO here. metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java https://reviews.apache.org/r/27900/#comment102895 Better name since its not limited to Derby: stopDBFromPushingCastAboveJoin? - Ashutosh Chauhan On Nov. 13, 2014, 10:26 p.m., Sergey Shelukhin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27900/ --- (Updated Nov. 13, 2014, 10:26 p.m.) Review request for hive. Repository: hive-git Description --- see jira Diffs - metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 82f504f Diff: https://reviews.apache.org/r/27900/diff/ Testing --- Thanks, Sergey Shelukhin
Re: Review Request 27900: HIVE-8739
On Nov. 12, 2014, 2:30 a.m., Ashutosh Chauhan wrote: metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java, line 330 https://reviews.apache.org/r/27900/diff/1/?file=759059#file759059line330 Are we sure about Oracle? Till now this worked on Oracle. Do we have evidence for otherwise? Yes, from HIVE-8293 - Sergey --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27900/#review60933 --- On Nov. 12, 2014, 2:02 a.m., Sergey Shelukhin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27900/ --- (Updated Nov. 12, 2014, 2:02 a.m.) Review request for hive. Repository: hive-git Description --- see jira Diffs - metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java b6c633c Diff: https://reviews.apache.org/r/27900/diff/ Testing --- Thanks, Sergey Shelukhin
Re: Review Request 27900: HIVE-8739
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27900/#review60933 --- metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java https://reviews.apache.org/r/27900/#comment102350 Are we sure about Oracle? Till now this worked on Oracle. Do we have evidence for otherwise? - Ashutosh Chauhan On Nov. 12, 2014, 2:02 a.m., Sergey Shelukhin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27900/ --- (Updated Nov. 12, 2014, 2:02 a.m.) Review request for hive. Repository: hive-git Description --- see jira Diffs - metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java b6c633c Diff: https://reviews.apache.org/r/27900/diff/ Testing --- Thanks, Sergey Shelukhin
