Re: Review Request 38663: HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are registered one at a time in Hive

2015-12-10 Thread Anthony Hsu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38663/#review109782
---

Ship it!


Revision looks good to me.


itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java
 (line 92)


Nit: trailing whitespace


- Anthony Hsu


On 十二月 9, 2015, 8:33 a.m., Ratandeep Ratti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38663/
> ---
> 
> (Updated 十二月 9, 2015, 8:33 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-11878
> https://issues.apache.org/jira/browse/HIVE-11878
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are 
> registered one at a time in Hive
> 
> 
> Diffs
> -
> 
>   conf/ivysettings.xml bda842a 
>   itests/custom-udfs/pom.xml PRE-CREATION 
>   itests/custom-udfs/udf-classloader-udf1/pom.xml PRE-CREATION 
>   
> itests/custom-udfs/udf-classloader-udf1/src/main/java/hive/it/custom/udfs/UDF1.java
>  PRE-CREATION 
>   itests/custom-udfs/udf-classloader-udf2/pom.xml PRE-CREATION 
>   
> itests/custom-udfs/udf-classloader-udf2/src/main/java/hive/it/custom/udfs/UDF2.java
>  PRE-CREATION 
>   itests/custom-udfs/udf-classloader-util/pom.xml PRE-CREATION 
>   
> itests/custom-udfs/udf-classloader-util/src/main/java/hive/it/custom/udfs/Util.java
>  PRE-CREATION 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java
>  0c03a00 
>   itests/pom.xml 5d8249f 
>   itests/qtest/pom.xml 8f6807a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/UDFClassLoader.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java c01994f 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 5c69fb6 
>   ql/src/test/queries/clientpositive/udf_classloader.q PRE-CREATION 
>   
> ql/src/test/queries/clientpositive/udf_classloader_dynamic_dependency_resolution.q
>  PRE-CREATION 
>   ql/src/test/results/clientpositive/udf_classloader.q.out PRE-CREATION 
>   
> ql/src/test/results/clientpositive/udf_classloader_dynamic_dependency_resolution.q.out
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38663/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ratandeep Ratti
> 
>

Re: Review Request 38663: HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are registered one at a time in Hive

2015-12-09 Thread Ratandeep Ratti 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38663/
---

(Updated Dec. 9, 2015, 8:33 a.m.)


Review request for hive.


Changes
---

Addressed failing tests


Bugs: HIVE-11878
https://issues.apache.org/jira/browse/HIVE-11878


Repository: hive-git


Description
---

HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are 
registered one at a time in Hive


Diffs (updated)
-

  conf/ivysettings.xml bda842a 
  itests/custom-udfs/pom.xml PRE-CREATION 
  itests/custom-udfs/udf-classloader-udf1/pom.xml PRE-CREATION 
  
itests/custom-udfs/udf-classloader-udf1/src/main/java/hive/it/custom/udfs/UDF1.java
 PRE-CREATION 
  itests/custom-udfs/udf-classloader-udf2/pom.xml PRE-CREATION 
  
itests/custom-udfs/udf-classloader-udf2/src/main/java/hive/it/custom/udfs/UDF2.java
 PRE-CREATION 
  itests/custom-udfs/udf-classloader-util/pom.xml PRE-CREATION 
  
itests/custom-udfs/udf-classloader-util/src/main/java/hive/it/custom/udfs/Util.java
 PRE-CREATION 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java
 0c03a00 
  itests/pom.xml 5d8249f 
  itests/qtest/pom.xml 8f6807a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/UDFClassLoader.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java c01994f 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 5c69fb6 
  ql/src/test/queries/clientpositive/udf_classloader.q PRE-CREATION 
  
ql/src/test/queries/clientpositive/udf_classloader_dynamic_dependency_resolution.q
 PRE-CREATION 
  ql/src/test/results/clientpositive/udf_classloader.q.out PRE-CREATION 
  
ql/src/test/results/clientpositive/udf_classloader_dynamic_dependency_resolution.q.out
 PRE-CREATION 

Diff: https://reviews.apache.org/r/38663/diff/


Testing
---


Thanks,

Ratandeep Ratti

Re: Review Request 38663: HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are registered one at a time in Hive

2015-11-24 Thread Ratandeep Ratti 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38663/#review107745
---



ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java (line 371)


Makes sense. ContextClassLoader will be set when ever SessionState.start() 
will be called (which internally will call attach).

I'll remove it from the Constructor.


- Ratandeep Ratti


On Nov. 18, 2015, 5:21 a.m., Ratandeep Ratti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38663/
> ---
> 
> (Updated Nov. 18, 2015, 5:21 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-11878
> https://issues.apache.org/jira/browse/HIVE-11878
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are 
> registered one at a time in Hive
> 
> 
> Diffs
> -
> 
>   conf/ivysettings.xml bda842a89bb07710fdcd7180a00833a7388ada8f 
>   itests/custom-udfs/pom.xml PRE-CREATION 
>   itests/custom-udfs/udf-classloader-udf1/pom.xml PRE-CREATION 
>   
> itests/custom-udfs/udf-classloader-udf1/src/main/java/hive/it/custom/udfs/UDF1.java
>  PRE-CREATION 
>   itests/custom-udfs/udf-classloader-udf2/pom.xml PRE-CREATION 
>   
> itests/custom-udfs/udf-classloader-udf2/src/main/java/hive/it/custom/udfs/UDF2.java
>  PRE-CREATION 
>   itests/custom-udfs/udf-classloader-util/pom.xml PRE-CREATION 
>   
> itests/custom-udfs/udf-classloader-util/src/main/java/hive/it/custom/udfs/Util.java
>  PRE-CREATION 
>   itests/pom.xml 0686f1fd58c2be26b2ee645c4e244159aec565e5 
>   itests/qtest/pom.xml 8db6fb04d0a5d4600bc23543a0215d31c1cd0648 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/UDFClassLoader.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
> de2eb984159526048e8dacf71d3ff8b0647394a3 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 
> ff875df98e1dd64a8af3ad22f4b38dbc1d6a1923 
>   ql/src/test/queries/clientpositive/udf_classloader.q PRE-CREATION 
>   
> ql/src/test/queries/clientpositive/udf_classloader_dynamic_dependency_resolution.q
>  PRE-CREATION 
>   ql/src/test/results/clientpositive/udf_classloader.q.out PRE-CREATION 
>   
> ql/src/test/results/clientpositive/udf_classloader_dynamic_dependency_resolution.q.out
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38663/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ratandeep Ratti
> 
>

Re: Review Request 38663: HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are registered one at a time in Hive

2015-11-24 Thread Ratandeep Ratti 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38663/
---

(Updated Nov. 24, 2015, 9:56 a.m.)


Review request for hive.


Changes
---

Addressed Jason's comments


Bugs: HIVE-11878
https://issues.apache.org/jira/browse/HIVE-11878


Repository: hive-git


Description
---

HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are 
registered one at a time in Hive


Diffs (updated)
-

  conf/ivysettings.xml bda842a89bb07710fdcd7180a00833a7388ada8f 
  itests/custom-udfs/pom.xml PRE-CREATION 
  itests/custom-udfs/udf-classloader-udf1/pom.xml PRE-CREATION 
  
itests/custom-udfs/udf-classloader-udf1/src/main/java/hive/it/custom/udfs/UDF1.java
 PRE-CREATION 
  itests/custom-udfs/udf-classloader-udf2/pom.xml PRE-CREATION 
  
itests/custom-udfs/udf-classloader-udf2/src/main/java/hive/it/custom/udfs/UDF2.java
 PRE-CREATION 
  itests/custom-udfs/udf-classloader-util/pom.xml PRE-CREATION 
  
itests/custom-udfs/udf-classloader-util/src/main/java/hive/it/custom/udfs/Util.java
 PRE-CREATION 
  itests/pom.xml 0686f1fd58c2be26b2ee645c4e244159aec565e5 
  itests/qtest/pom.xml 8db6fb04d0a5d4600bc23543a0215d31c1cd0648 
  ql/src/java/org/apache/hadoop/hive/ql/exec/UDFClassLoader.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
de2eb984159526048e8dacf71d3ff8b0647394a3 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 
ff875df98e1dd64a8af3ad22f4b38dbc1d6a1923 
  ql/src/test/queries/clientpositive/udf_classloader.q PRE-CREATION 
  
ql/src/test/queries/clientpositive/udf_classloader_dynamic_dependency_resolution.q
 PRE-CREATION 
  ql/src/test/results/clientpositive/udf_classloader.q.out PRE-CREATION 
  
ql/src/test/results/clientpositive/udf_classloader_dynamic_dependency_resolution.q.out
 PRE-CREATION 

Diff: https://reviews.apache.org/r/38663/diff/


Testing
---


Thanks,

Ratandeep Ratti

Re: Review Request 38663: HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are registered one at a time in Hive

2015-11-23 Thread Jason Dere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38663/#review107570
---



ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java (line 371)


Does context class loader need to be set here? Is there some place that 
already sets it (attach())?


- Jason Dere


On Nov. 18, 2015, 5:21 a.m., Ratandeep Ratti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38663/
> ---
> 
> (Updated Nov. 18, 2015, 5:21 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-11878
> https://issues.apache.org/jira/browse/HIVE-11878
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are 
> registered one at a time in Hive
> 
> 
> Diffs
> -
> 
>   conf/ivysettings.xml bda842a89bb07710fdcd7180a00833a7388ada8f 
>   itests/custom-udfs/pom.xml PRE-CREATION 
>   itests/custom-udfs/udf-classloader-udf1/pom.xml PRE-CREATION 
>   
> itests/custom-udfs/udf-classloader-udf1/src/main/java/hive/it/custom/udfs/UDF1.java
>  PRE-CREATION 
>   itests/custom-udfs/udf-classloader-udf2/pom.xml PRE-CREATION 
>   
> itests/custom-udfs/udf-classloader-udf2/src/main/java/hive/it/custom/udfs/UDF2.java
>  PRE-CREATION 
>   itests/custom-udfs/udf-classloader-util/pom.xml PRE-CREATION 
>   
> itests/custom-udfs/udf-classloader-util/src/main/java/hive/it/custom/udfs/Util.java
>  PRE-CREATION 
>   itests/pom.xml 0686f1fd58c2be26b2ee645c4e244159aec565e5 
>   itests/qtest/pom.xml 8db6fb04d0a5d4600bc23543a0215d31c1cd0648 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/UDFClassLoader.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
> de2eb984159526048e8dacf71d3ff8b0647394a3 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 
> ff875df98e1dd64a8af3ad22f4b38dbc1d6a1923 
>   ql/src/test/queries/clientpositive/udf_classloader.q PRE-CREATION 
>   
> ql/src/test/queries/clientpositive/udf_classloader_dynamic_dependency_resolution.q
>  PRE-CREATION 
>   ql/src/test/results/clientpositive/udf_classloader.q.out PRE-CREATION 
>   
> ql/src/test/results/clientpositive/udf_classloader_dynamic_dependency_resolution.q.out
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38663/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ratandeep Ratti
> 
>

Re: Review Request 38663: HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are registered one at a time in Hive

2015-11-18 Thread Anthony Hsu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38663/#review107063
---

Ship it!


Revision looks good to me.


ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java (lines 369 - 
370)


You could also use `new String[0]`.


- Anthony Hsu


On 十一月 18, 2015, 5:21 a.m., Ratandeep Ratti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38663/
> ---
> 
> (Updated 十一月 18, 2015, 5:21 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-11878
> https://issues.apache.org/jira/browse/HIVE-11878
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are 
> registered one at a time in Hive
> 
> 
> Diffs
> -
> 
>   conf/ivysettings.xml bda842a89bb07710fdcd7180a00833a7388ada8f 
>   itests/custom-udfs/pom.xml PRE-CREATION 
>   itests/custom-udfs/udf-classloader-udf1/pom.xml PRE-CREATION 
>   
> itests/custom-udfs/udf-classloader-udf1/src/main/java/hive/it/custom/udfs/UDF1.java
>  PRE-CREATION 
>   itests/custom-udfs/udf-classloader-udf2/pom.xml PRE-CREATION 
>   
> itests/custom-udfs/udf-classloader-udf2/src/main/java/hive/it/custom/udfs/UDF2.java
>  PRE-CREATION 
>   itests/custom-udfs/udf-classloader-util/pom.xml PRE-CREATION 
>   
> itests/custom-udfs/udf-classloader-util/src/main/java/hive/it/custom/udfs/Util.java
>  PRE-CREATION 
>   itests/pom.xml 0686f1fd58c2be26b2ee645c4e244159aec565e5 
>   itests/qtest/pom.xml 8db6fb04d0a5d4600bc23543a0215d31c1cd0648 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/UDFClassLoader.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
> de2eb984159526048e8dacf71d3ff8b0647394a3 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 
> ff875df98e1dd64a8af3ad22f4b38dbc1d6a1923 
>   ql/src/test/queries/clientpositive/udf_classloader.q PRE-CREATION 
>   
> ql/src/test/queries/clientpositive/udf_classloader_dynamic_dependency_resolution.q
>  PRE-CREATION 
>   ql/src/test/results/clientpositive/udf_classloader.q.out PRE-CREATION 
>   
> ql/src/test/results/clientpositive/udf_classloader_dynamic_dependency_resolution.q.out
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38663/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ratandeep Ratti
> 
>

Re: Review Request 38663: HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are registered one at a time in Hive

2015-11-17 Thread Ratandeep Ratti 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38663/
---

(Updated Nov. 18, 2015, 5:21 a.m.)


Review request for hive.


Changes
---

Using SystemClassloder as parent of per session classloader


Summary (updated)
-

HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are 
registered one at a time in Hive


Bugs: HIVE-11878
https://issues.apache.org/jira/browse/HIVE-11878


Repository: hive-git


Description (updated)
---

HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are 
registered one at a time in Hive


Diffs (updated)
-

  conf/ivysettings.xml bda842a89bb07710fdcd7180a00833a7388ada8f 
  itests/custom-udfs/pom.xml PRE-CREATION 
  itests/custom-udfs/udf-classloader-udf1/pom.xml PRE-CREATION 
  
itests/custom-udfs/udf-classloader-udf1/src/main/java/hive/it/custom/udfs/UDF1.java
 PRE-CREATION 
  itests/custom-udfs/udf-classloader-udf2/pom.xml PRE-CREATION 
  
itests/custom-udfs/udf-classloader-udf2/src/main/java/hive/it/custom/udfs/UDF2.java
 PRE-CREATION 
  itests/custom-udfs/udf-classloader-util/pom.xml PRE-CREATION 
  
itests/custom-udfs/udf-classloader-util/src/main/java/hive/it/custom/udfs/Util.java
 PRE-CREATION 
  itests/pom.xml 0686f1fd58c2be26b2ee645c4e244159aec565e5 
  itests/qtest/pom.xml 8db6fb04d0a5d4600bc23543a0215d31c1cd0648 
  ql/src/java/org/apache/hadoop/hive/ql/exec/UDFClassLoader.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
de2eb984159526048e8dacf71d3ff8b0647394a3 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 
ff875df98e1dd64a8af3ad22f4b38dbc1d6a1923 
  ql/src/test/queries/clientpositive/udf_classloader.q PRE-CREATION 
  
ql/src/test/queries/clientpositive/udf_classloader_dynamic_dependency_resolution.q
 PRE-CREATION 
  ql/src/test/results/clientpositive/udf_classloader.q.out PRE-CREATION 
  
ql/src/test/results/clientpositive/udf_classloader_dynamic_dependency_resolution.q.out
 PRE-CREATION 

Diff: https://reviews.apache.org/r/38663/diff/


Testing
---


Thanks,

Ratandeep Ratti

Re: Review Request 38663: HIVE-11878

2015-10-01 Thread Ratandeep Ratti 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38663/
---

(Updated Oct. 1, 2015, 6:24 p.m.)


Review request for hive.


Summary (updated)
-

HIVE-11878


Bugs: HIVE-11878
https://issues.apache.org/jira/browse/HIVE-11878


Repository: hive-git


Description (updated)
---

HIVE-11878


Diffs (updated)
-

  .reviewboardrc abc33f91a44b76573cbba334c33417307c63956f 
  conf/ivysettings.xml bda842a89bb07710fdcd7180a00833a7388ada8f 
  itests/custom-udfs/pom.xml PRE-CREATION 
  itests/custom-udfs/udf-classloader-udf1/pom.xml PRE-CREATION 
  
itests/custom-udfs/udf-classloader-udf1/src/main/java/hive/it/custom/udfs/UDF1.java
 PRE-CREATION 
  itests/custom-udfs/udf-classloader-udf2/pom.xml PRE-CREATION 
  
itests/custom-udfs/udf-classloader-udf2/src/main/java/hive/it/custom/udfs/UDF2.java
 PRE-CREATION 
  itests/custom-udfs/udf-classloader-util/pom.xml PRE-CREATION 
  
itests/custom-udfs/udf-classloader-util/src/main/java/hive/it/custom/udfs/Util.java
 PRE-CREATION 
  itests/pom.xml acce7131948edd5aeab34af6879d781daa12ba30 
  itests/qtest/pom.xml 74ca88f586b7ff9ddc38e8bc22a9445c85790c87 
  ql/src/java/org/apache/hadoop/hive/ql/exec/UDFClassLoader.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
bcf85a471c421dd0de62a894fd6c90024dff5691 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 
dc8c336c01921c8e4ae251f3627a80ce95a66182 
  ql/src/test/queries/clientpositive/udf_classloader.q PRE-CREATION 
  
ql/src/test/queries/clientpositive/udf_classloader_dynamic_dependency_resolution.q
 PRE-CREATION 
  ql/src/test/results/clientpositive/udf_classloader.q.out PRE-CREATION 
  
ql/src/test/results/clientpositive/udf_classloader_dynamic_dependency_resolution.q.out
 PRE-CREATION 

Diff: https://reviews.apache.org/r/38663/diff/


Testing
---


Thanks,

Ratandeep Ratti

Re: Review Request 38663: HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are registered one at a time in Hive

2015-09-23 Thread Carl Steinbach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38663/#review100268
---



contrib/src/java/org/apache/hadoop/hive/contrib/classloader/ClassA.java (line 1)


Since this is test code I think it would be good to create a new 
"custom-udfs" module (with several submodules) in the itest module and move the 
code there. There are several qfile tests that show how to access itest modules 
in the local cache (e.g. alter1.q). It's also possible that we can access them 
more succinctly using the ivy:// notation.



ql/src/java/org/apache/hadoop/hive/ql/exec/UDFClassLoader.java (line 26)


Please add a comment that explains why it's necessary to modify the 
URLClassLoader.



ql/src/test/queries/clientpositive/test_classloader.q (line 1)


Change the name to "udf_classloader.q"

Is it possible to test the ivy:// codepath as well? I realize that right 
now there shouldn't be much difference, but who knows what changes people will 
make in the future...


- Carl Steinbach


On Sept. 23, 2015, 5:38 a.m., Ratandeep Ratti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38663/
> ---
> 
> (Updated Sept. 23, 2015, 5:38 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-11878
> https://issues.apache.org/jira/browse/HIVE-11878
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are 
> registered one at a time in Hive
> 
> 
> Diffs
> -
> 
>   contrib/src/java/org/apache/hadoop/hive/contrib/classloader/ClassA.java 
> PRE-CREATION 
>   contrib/src/java/org/apache/hadoop/hive/contrib/classloader/UDF1.java 
> PRE-CREATION 
>   contrib/src/java/org/apache/hadoop/hive/contrib/classloader/UDF2.java 
> PRE-CREATION 
>   itests/pom.xml acce7131948edd5aeab34af6879d781daa12ba30 
>   itests/qtest/pom.xml 0588233b250f7c78f594bb36554a80990e907550 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/UDFClassLoader.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
> ca863019f3347c94852dcad2a21c43758aed30a7 
>   ql/src/test/queries/clientpositive/test_classloader.q PRE-CREATION 
>   ql/src/test/results/clientpositive/test_classloader.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38663/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ratandeep Ratti
> 
>

Re: Review Request 38663: HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are registered one at a time in Hive

2015-09-23 Thread Anthony Hsu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38663/#review100274
---



contrib/src/java/org/apache/hadoop/hive/contrib/classloader/UDF2.java (line 32)


Should UDF1 be replaced with UDF2?


- Anthony Hsu


On 九月 23, 2015, 5:38 a.m., Ratandeep Ratti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38663/
> ---
> 
> (Updated 九月 23, 2015, 5:38 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-11878
> https://issues.apache.org/jira/browse/HIVE-11878
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-11878: ClassNotFoundException can possibly occur if multiple jars are 
> registered one at a time in Hive
> 
> 
> Diffs
> -
> 
>   contrib/src/java/org/apache/hadoop/hive/contrib/classloader/ClassA.java 
> PRE-CREATION 
>   contrib/src/java/org/apache/hadoop/hive/contrib/classloader/UDF1.java 
> PRE-CREATION 
>   contrib/src/java/org/apache/hadoop/hive/contrib/classloader/UDF2.java 
> PRE-CREATION 
>   itests/pom.xml acce7131948edd5aeab34af6879d781daa12ba30 
>   itests/qtest/pom.xml 0588233b250f7c78f594bb36554a80990e907550 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/UDFClassLoader.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
> ca863019f3347c94852dcad2a21c43758aed30a7 
>   ql/src/test/queries/clientpositive/test_classloader.q PRE-CREATION 
>   ql/src/test/results/clientpositive/test_classloader.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38663/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ratandeep Ratti
> 
>