Re: Review Request 67974: HIVE-20164

[Deepak Jaiswal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67974/
---

(Updated July 23, 2018, 6:06 p.m.)


Review request for hive, Gopal V and Jason Dere.


Changes
---

Made the data set smaller for easier verification.


Bugs: HIVE-20164
https://issues.apache.org/jira/browse/HIVE-20164


Repository: hive-git


Description
---

Murmur Hash : Make sure CTAS and IAS use correct bucketing version


Diffs (updated)
-

  itests/src/test/resources/testconfiguration.properties 654185d962 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 1661aeccd7 
  ql/src/java/org/apache/hadoop/hive/ql/plan/TableDesc.java bbce940c2e 
  ql/src/test/queries/clientpositive/murmur_hash_migration.q PRE-CREATION 
  ql/src/test/results/clientpositive/llap/murmur_hash_migration.q.out 
PRE-CREATION 


Diff: https://reviews.apache.org/r/67974/diff/4/

Changes: https://reviews.apache.org/r/67974/diff/3-4/


Testing
---


Thanks,

Deepak Jaiswal

Re: Review Request 67974: HIVE-20164

[Deepak Jaiswal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67974/
---

(Updated July 23, 2018, 5:48 p.m.)


Review request for hive, Gopal V and Jason Dere.


Changes
---

Sort results for easy verification and to avoid order change due to other 
possible changes.


Bugs: HIVE-20164
https://issues.apache.org/jira/browse/HIVE-20164


Repository: hive-git


Description
---

Murmur Hash : Make sure CTAS and IAS use correct bucketing version


Diffs (updated)
-

  itests/src/test/resources/testconfiguration.properties 654185d962 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 1661aeccd7 
  ql/src/java/org/apache/hadoop/hive/ql/plan/TableDesc.java bbce940c2e 
  ql/src/test/queries/clientpositive/murmur_hash_migration.q PRE-CREATION 
  ql/src/test/results/clientpositive/llap/murmur_hash_migration.q.out 
PRE-CREATION 


Diff: https://reviews.apache.org/r/67974/diff/3/

Changes: https://reviews.apache.org/r/67974/diff/2-3/


Testing
---


Thanks,

Deepak Jaiswal

Re: Review Request 67974: HIVE-20164

[Jason Dere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67974/#review206321
---




ql/src/test/queries/clientpositive/murmur_hash_migration.q
Lines 57 (patched)


Can you make this count(*)? Kind of hard to verify.


- Jason Dere


On July 20, 2018, 11:10 p.m., Deepak Jaiswal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67974/
> ---
> 
> (Updated July 20, 2018, 11:10 p.m.)
> 
> 
> Review request for hive, Gopal V and Jason Dere.
> 
> 
> Bugs: HIVE-20164
> https://issues.apache.org/jira/browse/HIVE-20164
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Murmur Hash : Make sure CTAS and IAS use correct bucketing version
> 
> 
> Diffs
> -
> 
>   itests/src/test/resources/testconfiguration.properties d5a33bd8ca 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 1661aeccd7 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/TableDesc.java bbce940c2e 
>   ql/src/test/queries/clientpositive/murmur_hash_migration.q PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/murmur_hash_migration.q.out 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67974/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Deepak Jaiswal
> 
>

Re: Review Request 67974: HIVE-20164

[Deepak Jaiswal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67974/
---

(Updated July 20, 2018, 11:10 p.m.)


Review request for hive, Gopal V and Jason Dere.


Changes
---

Implemented review comments.


Bugs: HIVE-20164
https://issues.apache.org/jira/browse/HIVE-20164


Repository: hive-git


Description
---

Murmur Hash : Make sure CTAS and IAS use correct bucketing version


Diffs (updated)
-

  itests/src/test/resources/testconfiguration.properties d5a33bd8ca 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 1661aeccd7 
  ql/src/java/org/apache/hadoop/hive/ql/plan/TableDesc.java bbce940c2e 
  ql/src/test/queries/clientpositive/murmur_hash_migration.q PRE-CREATION 
  ql/src/test/results/clientpositive/llap/murmur_hash_migration.q.out 
PRE-CREATION 


Diff: https://reviews.apache.org/r/67974/diff/2/

Changes: https://reviews.apache.org/r/67974/diff/1-2/


Testing
---


Thanks,

Deepak Jaiswal

Re: Review Request 67974: HIVE-20164

[Jason Dere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67974/#review206291
---




ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java
Lines 1672 (patched)


Remove these comments?



ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java
Lines 1695 (patched)


please add curly braces



ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java
Lines 1701 (patched)


curly braces



ql/src/test/queries/clientpositive/murmur_hash_migration.q
Lines 36 (patched)


Does this test also need to query the inserted tables to show that things 
are working properly?


- Jason Dere


On July 19, 2018, 6:02 p.m., Deepak Jaiswal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67974/
> ---
> 
> (Updated July 19, 2018, 6:02 p.m.)
> 
> 
> Review request for hive, Gopal V and Jason Dere.
> 
> 
> Bugs: HIVE-20164
> https://issues.apache.org/jira/browse/HIVE-20164
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Murmur Hash : Make sure CTAS and IAS use correct bucketing version
> 
> 
> Diffs
> -
> 
>   itests/src/test/resources/testconfiguration.properties d08528f319 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 1b433c7498 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/TableDesc.java bbce940c2e 
>   ql/src/test/queries/clientpositive/murmur_hash_migration.q PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/murmur_hash_migration.q.out 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67974/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Deepak Jaiswal
> 
>