Re: Review Request 11046: HIVE-4233- The TGT gotten from class 'CLIService' should be renewed on time

[Thejas Nair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11046/
---

(Updated Aug. 7, 2013, 12:36 a.m.)


Review request for hive.


Changes
---

Addressing review comments.


Bugs: HIVE-4233
https://issues.apache.org/jira/browse/HIVE-4233


Repository: hive-git


Description
---

HIVE-4233- The TGT gotten from class 'CLIService'  should be renewed on time


Diffs (updated)
-

  
metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java
 76b1989 
  shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java a837e33 
  
shims/src/common-secure/java/org/apache/hadoop/hive/shims/HadoopShimsSecure.java
 a649221 
  shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java 6a7da82 

Diff: https://reviews.apache.org/r/11046/diff/


Testing
---

manually tested on secure hadoop cluster.


Thanks,

Thejas Nair

Re: Review Request 11046: HIVE-4233- The TGT gotten from class 'CLIService' should be renewed on time

[Thejas Nair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11046/#review24708
---



metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java


Yes, as seen in the exception in the description, the new instance tries to 
make a connection to metastore.



metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java


I think prevention is better than cure. This is not an expensive method, 
failure will result in some time spent sleeping before retrying.

I will move the base.reconnect() here so that relogin happens before it is 
called.




metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java


will call it reloginExpiringKeytabUser



shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java


This is the message other similar functions report. I can change the rest 
of them in a separate patch.



- Thejas Nair


On Aug. 3, 2013, 3 a.m., Thejas Nair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11046/
> ---
> 
> (Updated Aug. 3, 2013, 3 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-4233
> https://issues.apache.org/jira/browse/HIVE-4233
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-4233- The TGT gotten from class 'CLIService'  should be renewed on time
> 
> 
> Diffs
> -
> 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java
>  76b1989 
>   shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java c9baa7f 
>   
> shims/src/common-secure/java/org/apache/hadoop/hive/shims/HadoopShimsSecure.java
>  9edcafd 
>   shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java b0f5077 
> 
> Diff: https://reviews.apache.org/r/11046/diff/
> 
> 
> Testing
> ---
> 
> manually tested on secure hadoop cluster.
> 
> 
> Thanks,
> 
> Thejas Nair
> 
>

Re: Review Request 11046: HIVE-4233- The TGT gotten from class 'CLIService' should be renewed on time

[Gunther Hagleitner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11046/#review24628
---



metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java


is this necessary to create a new instance?



metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java


do you really need to call this in two places? can't you just let the call 
below take care of things? (fail - relogin - reconnect - succeed).



metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java


minor: checkAndRelogin or similar would say in the name that the method 
doesn't actually relogin every time.



shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java


can you say hadoop v 20 or use the actual version of the user? or maybe 
before version 1.0.0. This message sounds like there's still no version that 
supports it.

Same for message below.


- Gunther Hagleitner


On Aug. 3, 2013, 3 a.m., Thejas Nair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11046/
> ---
> 
> (Updated Aug. 3, 2013, 3 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-4233
> https://issues.apache.org/jira/browse/HIVE-4233
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-4233- The TGT gotten from class 'CLIService'  should be renewed on time
> 
> 
> Diffs
> -
> 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java
>  76b1989 
>   shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java c9baa7f 
>   
> shims/src/common-secure/java/org/apache/hadoop/hive/shims/HadoopShimsSecure.java
>  9edcafd 
>   shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java b0f5077 
> 
> Diff: https://reviews.apache.org/r/11046/diff/
> 
> 
> Testing
> ---
> 
> manually tested on secure hadoop cluster.
> 
> 
> Thanks,
> 
> Thejas Nair
> 
>

Re: Review Request 11046: HIVE-4233- The TGT gotten from class 'CLIService' should be renewed on time

[Thejas Nair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11046/
---

(Updated Aug. 3, 2013, 3 a.m.)


Review request for hive.


Changes
---

Now checks if security is enabled before trying to reloginFromKeytab


Bugs: HIVE-4233
https://issues.apache.org/jira/browse/HIVE-4233


Repository: hive-git


Description
---

HIVE-4233- The TGT gotten from class 'CLIService'  should be renewed on time


Diffs (updated)
-

  
metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java
 76b1989 
  shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java c9baa7f 
  
shims/src/common-secure/java/org/apache/hadoop/hive/shims/HadoopShimsSecure.java
 9edcafd 
  shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java b0f5077 

Diff: https://reviews.apache.org/r/11046/diff/


Testing
---

manually tested on secure hadoop cluster.


Thanks,

Thejas Nair