Re: Review Request 32920: HIVE-10189: Create a micro benchmark tool for vectorization to evaluate the performance gain after SIMD optimization
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32920/ --- (Updated April 8, 2015, 6:26 a.m.) Review request for hive and chengxiang li. Repository: hive-git Description --- Add microbenchmark tool to show performance improvement by JMH Diffs (updated) - itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/VectorizationBench.java PRE-CREATION Diff: https://reviews.apache.org/r/32920/diff/ Testing --- Thanks, cheng xu
Re: Review Request 32920: HIVE-10189: Create a micro benchmark tool for vectorization to evaluate the performance gain after SIMD optimization
On April 8, 2015, 9:22 a.m., chengxiang li wrote: itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/VectorizationBench.java, line 73 https://reviews.apache.org/r/32920/diff/3/?file=920776#file920776line73 This static variables is specified for expressions of 2 paramater operator, i think we can move it to each setup() method. Thank you for your comments. These variables are reused and will be initialized in setup method of the VectorizationBench. - cheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32920/#review79327 --- On April 8, 2015, 8:42 a.m., cheng xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32920/ --- (Updated April 8, 2015, 8:42 a.m.) Review request for hive and chengxiang li. Repository: hive-git Description --- Add microbenchmark tool to show performance improvement by JMH Diffs - itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/VectorizationBench.java PRE-CREATION Diff: https://reviews.apache.org/r/32920/diff/ Testing --- Thanks, cheng xu
Re: Review Request 32920: HIVE-10189: Create a micro benchmark tool for vectorization to evaluate the performance gain after SIMD optimization
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32920/#review79327 --- itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/VectorizationBench.java https://reviews.apache.org/r/32920/#comment128590 This static variables is specified for expressions of 2 paramater operator, i think we can move it to each setup() method. - chengxiang li On 四月 8, 2015, 8:42 a.m., cheng xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32920/ --- (Updated 四月 8, 2015, 8:42 a.m.) Review request for hive and chengxiang li. Repository: hive-git Description --- Add microbenchmark tool to show performance improvement by JMH Diffs - itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/VectorizationBench.java PRE-CREATION Diff: https://reviews.apache.org/r/32920/diff/ Testing --- Thanks, cheng xu
Re: Review Request 32920: HIVE-10189: Create a micro benchmark tool for vectorization to evaluate the performance gain after SIMD optimization
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32920/ --- (Updated April 8, 2015, 8:42 a.m.) Review request for hive and chengxiang li. Repository: hive-git Description --- Add microbenchmark tool to show performance improvement by JMH Diffs (updated) - itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/VectorizationBench.java PRE-CREATION Diff: https://reviews.apache.org/r/32920/diff/ Testing --- Thanks, cheng xu
Re: Review Request 32920: HIVE-10189: Create a micro benchmark tool for vectorization to evaluate the performance gain after SIMD optimization
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32920/#review79341 --- Ship it! Ship It! - chengxiang li On 四月 8, 2015, 8:42 a.m., cheng xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32920/ --- (Updated 四月 8, 2015, 8:42 a.m.) Review request for hive and chengxiang li. Repository: hive-git Description --- Add microbenchmark tool to show performance improvement by JMH Diffs - itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/VectorizationBench.java PRE-CREATION Diff: https://reviews.apache.org/r/32920/diff/ Testing --- Thanks, cheng xu
Re: Review Request 32920: HIVE-10189: Create a micro benchmark tool for vectorization to evaluate the performance gain after SIMD optimization
On 四月 8, 2015, 9:22 a.m., chengxiang li wrote: itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/VectorizationBench.java, line 73 https://reviews.apache.org/r/32920/diff/3/?file=920776#file920776line73 This static variables is specified for expressions of 2 paramater operator, i think we can move it to each setup() method. cheng xu wrote: Thank you for your comments. These variables are reused and will be initialized in setup method of the VectorizationBench. The variables initialization is not time comsuming, and it's beyond the measured time of benchmark method, so it should be ok to initiate for each benchmark. Anyway, we can fix this while add one input column expression or three column expression. - chengxiang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32920/#review79327 --- On 四月 8, 2015, 8:42 a.m., cheng xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32920/ --- (Updated 四月 8, 2015, 8:42 a.m.) Review request for hive and chengxiang li. Repository: hive-git Description --- Add microbenchmark tool to show performance improvement by JMH Diffs - itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/VectorizationBench.java PRE-CREATION Diff: https://reviews.apache.org/r/32920/diff/ Testing --- Thanks, cheng xu
Re: Review Request 32920: HIVE-10189: Create a micro benchmark tool for vectorization to evaluate the performance gain after SIMD optimization
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32920/ --- (Updated April 7, 2015, 6:06 a.m.) Review request for hive and chengxiang li. Summary (updated) - HIVE-10189: Create a micro benchmark tool for vectorization to evaluate the performance gain after SIMD optimization Repository: hive-git Description --- Add microbenchmark tool to show performance improvement by JMH Diffs - itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/VectorizationBench.java PRE-CREATION Diff: https://reviews.apache.org/r/32920/diff/ Testing --- Thanks, cheng xu
Re: Review Request 32920: HIVE-10189: Create a micro benchmark tool for vectorization to evaluate the performance gain after SIMD optimization
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32920/#review79136 --- itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/VectorizationBench.java https://reviews.apache.org/r/32920/#comment128267 The benchmark look good, my only concern is that how could we expand this benchmark to other expressions? - chengxiang li On April 7, 2015, 6:06 a.m., cheng xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32920/ --- (Updated April 7, 2015, 6:06 a.m.) Review request for hive and chengxiang li. Repository: hive-git Description --- Add microbenchmark tool to show performance improvement by JMH Diffs - itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/VectorizationBench.java PRE-CREATION Diff: https://reviews.apache.org/r/32920/diff/ Testing --- Thanks, cheng xu
Re: Review Request 32920: HIVE-10189: Create a micro benchmark tool for vectorization to evaluate the performance gain after SIMD optimization
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32920/#review79241 --- itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/VectorizationBench.java https://reviews.apache.org/r/32920/#comment128472 I believe you meant to check for 'Double', right? itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/VectorizationBench.java https://reviews.apache.org/r/32920/#comment128475 Did you mean to check for 'Long' here? - Sergio Pena On April 7, 2015, 6:06 a.m., cheng xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32920/ --- (Updated April 7, 2015, 6:06 a.m.) Review request for hive and chengxiang li. Repository: hive-git Description --- Add microbenchmark tool to show performance improvement by JMH Diffs - itests/hive-jmh/src/main/java/org/apache/hive/benchmark/vectorization/VectorizationBench.java PRE-CREATION Diff: https://reviews.apache.org/r/32920/diff/ Testing --- Thanks, cheng xu
