Re: Review Request 61604: HIVE-17265

2017-08-22 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61604/
---

(Updated Aug. 23, 2017, 1:52 a.m.)


Review request for hive, Ashutosh Chauhan and Vineet Garg.


Bugs: HIVE-17265
https://issues.apache.org/jira/browse/HIVE-17265


Repository: hive-git


Description
---

HIVE-17265


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/CompilationOpContext.java 
949f8738f8bf2a707e0b4514ef2aa5ca48ed7dd6 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
 5dff242a17eab126267c8333860fcf9dfc3b89be 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 
1d49568c8cda2aa6c27568f023dc39ec20ab1949 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableScan.java
 fed1664ca32a0dc50e84812341f4d2f204d3747e 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java
 1801b830b15b6cb4b8b2917c235b42deb093cdad 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 
66248654e8c0b7d242a089f5ac1a624dfb06598d 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
 6cb0559ea04abebb1da38e93c2162666cdf95af9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
c9cb298a6f8b284e3fab2b84c7eba88e9c341e6e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsList.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
565fbef0aa1a63c50679a4057cb23e8c0092bc7d 
  ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java 
da2e1e2d8b06d04992763288709c423a4f048b4e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
4faec05bb0f7c728453fa8bd3a5ca2a6966048d4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java 
c46ea70e10902f05bac93a53b24996402827bcb0 
  ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 
3b9ab41bed25cc4cb0122842897fffbcd0ec15c4 
  ql/src/test/results/clientpositive/llap/tez_smb_empty.q.out 
e4c246afec59ae36282c89d730cc23d73bbc13ab 
  ql/src/test/results/clientpositive/llap/vector_mr_diff_schema_alias.q.out 
03c6d3fe541251ab593db989f423c6a73faa6bc5 


Diff: https://reviews.apache.org/r/61604/diff/4/

Changes: https://reviews.apache.org/r/61604/diff/3-4/


Testing
---


Thanks,

Jesús Camacho Rodríguez

Re: Review Request 61604: HIVE-17265

2017-08-22 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61604/
---

(Updated Aug. 22, 2017, 9:07 p.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-17265
https://issues.apache.org/jira/browse/HIVE-17265


Repository: hive-git


Description
---

HIVE-17265


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/CompilationOpContext.java 
949f8738f8bf2a707e0b4514ef2aa5ca48ed7dd6 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
 5dff242a17eab126267c8333860fcf9dfc3b89be 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 
1d49568c8cda2aa6c27568f023dc39ec20ab1949 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableScan.java
 fed1664ca32a0dc50e84812341f4d2f204d3747e 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java
 1801b830b15b6cb4b8b2917c235b42deb093cdad 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 
66248654e8c0b7d242a089f5ac1a624dfb06598d 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
 6cb0559ea04abebb1da38e93c2162666cdf95af9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
c9cb298a6f8b284e3fab2b84c7eba88e9c341e6e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsList.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
565fbef0aa1a63c50679a4057cb23e8c0092bc7d 
  ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java 
da2e1e2d8b06d04992763288709c423a4f048b4e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
4faec05bb0f7c728453fa8bd3a5ca2a6966048d4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java 
c46ea70e10902f05bac93a53b24996402827bcb0 
  ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 
3b9ab41bed25cc4cb0122842897fffbcd0ec15c4 
  ql/src/test/results/clientpositive/llap/tez_smb_empty.q.out 
e4c246afec59ae36282c89d730cc23d73bbc13ab 
  ql/src/test/results/clientpositive/llap/vector_mr_diff_schema_alias.q.out 
03c6d3fe541251ab593db989f423c6a73faa6bc5 


Diff: https://reviews.apache.org/r/61604/diff/3/

Changes: https://reviews.apache.org/r/61604/diff/2-3/


Testing
---


Thanks,

Jesús Camacho Rodríguez

Re: Review Request 61604: HIVE-17265

2017-08-17 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61604/
---

(Updated Aug. 18, 2017, 12:57 a.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-17265
https://issues.apache.org/jira/browse/HIVE-17265


Repository: hive-git


Description
---

HIVE-17265


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/CompilationOpContext.java 
949f8738f8bf2a707e0b4514ef2aa5ca48ed7dd6 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
 5dff242a17eab126267c8333860fcf9dfc3b89be 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 
1d49568c8cda2aa6c27568f023dc39ec20ab1949 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 
66248654e8c0b7d242a089f5ac1a624dfb06598d 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
 6cb0559ea04abebb1da38e93c2162666cdf95af9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
d6695ccbf2611551d2038582df7faa69efd4013f 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
565fbef0aa1a63c50679a4057cb23e8c0092bc7d 
  ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java 
da2e1e2d8b06d04992763288709c423a4f048b4e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
4faec05bb0f7c728453fa8bd3a5ca2a6966048d4 
  ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 
3b9ab41bed25cc4cb0122842897fffbcd0ec15c4 


Diff: https://reviews.apache.org/r/61604/diff/2/

Changes: https://reviews.apache.org/r/61604/diff/1-2/


Testing
---


Thanks,

Jesús Camacho Rodríguez

Re: Review Request 61604: HIVE-17265

2017-08-14 Thread Ashutosh Chauhan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61604/#review182926
---




ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java
Line 36 (original), 37-40 (patched)


Instead of storing and using prunerExpr in PrunedPartitionList, using tbl 
Name, db Name and pruner expr might be better.

This way this pruned partition list can track its own key and callers need 
to not construct this key everytime they need to look in cache.



ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java
Lines 278 (patched)


I wonder if we can pass an indicator field with different values from 
logical compiler vs physical compiler which throws exception in strict (or 
test) mode for physical compiler call. That way we can make sure we can fail 
query if we are making 2nd call.


- Ashutosh Chauhan


On Aug. 12, 2017, 2:16 a.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61604/
> ---
> 
> (Updated Aug. 12, 2017, 2:16 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-17265
> https://issues.apache.org/jira/browse/HIVE-17265
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-17265
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/CompilationOpContext.java 
> 949f8738f8bf2a707e0b4514ef2aa5ca48ed7dd6 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
>  56c016311d8141071a60d2a431749e4856ffbb66 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 
> 1d49568c8cda2aa6c27568f023dc39ec20ab1949 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 
> 66248654e8c0b7d242a089f5ac1a624dfb06598d 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
>  6cb0559ea04abebb1da38e93c2162666cdf95af9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
> d6695ccbf2611551d2038582df7faa69efd4013f 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
> 565fbef0aa1a63c50679a4057cb23e8c0092bc7d 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java 
> da2e1e2d8b06d04992763288709c423a4f048b4e 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> 4faec05bb0f7c728453fa8bd3a5ca2a6966048d4 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 
> 3b9ab41bed25cc4cb0122842897fffbcd0ec15c4 
> 
> 
> Diff: https://reviews.apache.org/r/61604/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>

Re: Review Request 61604: HIVE-17265

2017-08-11 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61604/
---

(Updated Aug. 12, 2017, 2:16 a.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-17265
https://issues.apache.org/jira/browse/HIVE-17265


Repository: hive-git


Description
---

HIVE-17265


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/CompilationOpContext.java 
949f8738f8bf2a707e0b4514ef2aa5ca48ed7dd6 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
 56c016311d8141071a60d2a431749e4856ffbb66 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 
1d49568c8cda2aa6c27568f023dc39ec20ab1949 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 
66248654e8c0b7d242a089f5ac1a624dfb06598d 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
 6cb0559ea04abebb1da38e93c2162666cdf95af9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
d6695ccbf2611551d2038582df7faa69efd4013f 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
565fbef0aa1a63c50679a4057cb23e8c0092bc7d 
  ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java 
da2e1e2d8b06d04992763288709c423a4f048b4e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
4faec05bb0f7c728453fa8bd3a5ca2a6966048d4 
  ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 
3b9ab41bed25cc4cb0122842897fffbcd0ec15c4 


Diff: https://reviews.apache.org/r/61604/diff/1/


Testing
---


Thanks,

Jesús Camacho Rodríguez

Review Request 61604: HIVE-17265

2017-08-11 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61604/
---

Review request for hive.


Repository: hive-git


Description
---

HIVE-17265


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/CompilationOpContext.java 
949f8738f8bf2a707e0b4514ef2aa5ca48ed7dd6 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
 56c016311d8141071a60d2a431749e4856ffbb66 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 
1d49568c8cda2aa6c27568f023dc39ec20ab1949 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 
66248654e8c0b7d242a089f5ac1a624dfb06598d 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
 6cb0559ea04abebb1da38e93c2162666cdf95af9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
d6695ccbf2611551d2038582df7faa69efd4013f 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
565fbef0aa1a63c50679a4057cb23e8c0092bc7d 
  ql/src/java/org/apache/hadoop/hive/ql/parse/PrunedPartitionList.java 
da2e1e2d8b06d04992763288709c423a4f048b4e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
4faec05bb0f7c728453fa8bd3a5ca2a6966048d4 
  ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 
3b9ab41bed25cc4cb0122842897fffbcd0ec15c4 


Diff: https://reviews.apache.org/r/61604/diff/1/


Testing
---


Thanks,

Jesús Camacho Rodríguez