Re: Review Request 68115: HIVE-20274: HiveServer2 ObjectInspectorFactory leaks for Struct and List object inspectors

2018-08-01 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68115/
---

(Updated Aug. 1, 2018, 10:32 p.m.)


Review request for hive, Gopal V and Sergey Shelukhin.


Changes
---

made oi cache unbounded soft valued cache.


Bugs: HIVE-20274
https://issues.apache.org/jira/browse/HIVE-20274


Repository: hive-git


Description
---

HIVE-20274: HiveServer2 ObjectInspectorFactory leaks for Struct and List object 
inspectors


Diffs (updated)
-

  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java
 b45a9de 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java
 3a88a40 
  
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestReflectionObjectInspectors.java
 cb1440e 


Diff: https://reviews.apache.org/r/68115/diff/2/

Changes: https://reviews.apache.org/r/68115/diff/1-2/


Testing
---


Thanks,

Prasanth_J

Re: Review Request 68115: HIVE-20274: HiveServer2 ObjectInspectorFactory leaks for Struct and List object inspectors

2018-07-30 Thread j . prasanth . j 


> On July 31, 2018, 12:17 a.m., Gopal V wrote:
> > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java
> > Lines 76 (patched)
> > 
> >
> > The type -> ObjectInspector is the only one which I think looks like it 
> > is there for "intern-ing" of object inpsectors (So that object == can be 
> > used instead of a deep equals check).
> > 
> > Of course, I'm not sure that's a "real" problem unless a query takes > 
> > 5 minutes to compile.
> > 
> > If that doesn't show up in the leaks, it might better to leave that one 
> > alone.

but, unbounded cache adversely affect the query compile if HS2 goes in GC 
pause? It is still softvalues but that doesn't get cleaned up aggressively 
(until full GC). Being bounded also gives predictable perf (doesn't reach the 
point of GC). right?


- Prasanth_J


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68115/#review206627
---


On July 31, 2018, 12:08 a.m., Prasanth_J wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68115/
> ---
> 
> (Updated July 31, 2018, 12:08 a.m.)
> 
> 
> Review request for hive, Gopal V and Sergey Shelukhin.
> 
> 
> Bugs: HIVE-20274
> https://issues.apache.org/jira/browse/HIVE-20274
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-20274: HiveServer2 ObjectInspectorFactory leaks for Struct and List 
> object inspectors
> 
> 
> Diffs
> -
> 
>   
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java
>  b45a9dee72f5fb3a139ee205a05e23c068b1fa0c 
>   
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java
>  3a88a400250afa0e29001ec118e006f937678089 
>   
> serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestReflectionObjectInspectors.java
>  cb1440e98b8fad399c4c02a7440d2a30483455f4 
> 
> 
> Diff: https://reviews.apache.org/r/68115/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Prasanth_J
> 
>

Re: Review Request 68115: HIVE-20274: HiveServer2 ObjectInspectorFactory leaks for Struct and List object inspectors

2018-07-30 Thread Gopal V 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68115/#review206627
---




serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java
Lines 76 (patched)


The type -> ObjectInspector is the only one which I think looks like it is 
there for "intern-ing" of object inpsectors (So that object == can be used 
instead of a deep equals check).

Of course, I'm not sure that's a "real" problem unless a query takes > 5 
minutes to compile.

If that doesn't show up in the leaks, it might better to leave that one 
alone.


- Gopal V


On July 31, 2018, 12:08 a.m., Prasanth_J wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68115/
> ---
> 
> (Updated July 31, 2018, 12:08 a.m.)
> 
> 
> Review request for hive, Gopal V and Sergey Shelukhin.
> 
> 
> Bugs: HIVE-20274
> https://issues.apache.org/jira/browse/HIVE-20274
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-20274: HiveServer2 ObjectInspectorFactory leaks for Struct and List 
> object inspectors
> 
> 
> Diffs
> -
> 
>   
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java
>  b45a9dee72f5fb3a139ee205a05e23c068b1fa0c 
>   
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java
>  3a88a400250afa0e29001ec118e006f937678089 
>   
> serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestReflectionObjectInspectors.java
>  cb1440e98b8fad399c4c02a7440d2a30483455f4 
> 
> 
> Diff: https://reviews.apache.org/r/68115/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Prasanth_J
> 
>

Re: Review Request 68115: HIVE-20274: HiveServer2 ObjectInspectorFactory leaks for Struct and List object inspectors

2018-07-30 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68115/
---

(Updated July 31, 2018, 12:08 a.m.)


Review request for hive, Gopal V and Sergey Shelukhin.


Bugs: HIVE-20274
https://issues.apache.org/jira/browse/HIVE-20274


Repository: hive-git


Description
---

HIVE-20274: HiveServer2 ObjectInspectorFactory leaks for Struct and List object 
inspectors


Diffs
-

  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java
 b45a9dee72f5fb3a139ee205a05e23c068b1fa0c 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java
 3a88a400250afa0e29001ec118e006f937678089 
  
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestReflectionObjectInspectors.java
 cb1440e98b8fad399c4c02a7440d2a30483455f4 


Diff: https://reviews.apache.org/r/68115/diff/1/


Testing
---


Thanks,

Prasanth_J

Review Request 68115: HIVE-20274: HiveServer2 ObjectInspectorFactory leaks for Struct and List object inspectors

2018-07-30 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68115/
---

Review request for hive, Gopal V and Sergey Shelukhin.


Repository: hive-git


Description
---

HIVE-20274: HiveServer2 ObjectInspectorFactory leaks for Struct and List object 
inspectors


Diffs
-

  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java
 b45a9dee72f5fb3a139ee205a05e23c068b1fa0c 
  
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java
 3a88a400250afa0e29001ec118e006f937678089 
  
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestReflectionObjectInspectors.java
 cb1440e98b8fad399c4c02a7440d2a30483455f4 


Diff: https://reviews.apache.org/r/68115/diff/1/


Testing
---


Thanks,

Prasanth_J