Re: svn commit: r1748888 - /httpd/httpd/trunk/modules/proxy/config.m4

2016-06-20 Thread William A Rowe Jr 
On Mon, Jun 20, 2016 at 10:03 PM, William A Rowe Jr 
wrote:

> On Mon, Jun 20, 2016 at 9:30 PM, William A Rowe Jr 
> wrote:
>
>> On Mon, Jun 20, 2016 at 1:46 PM, Ruediger Pluem 
>> wrote:
>>
>>>
>>> On 06/20/2016 07:04 PM, William A Rowe Jr wrote:
>>> > Did we miss this build breakage fix in 2.4.22?
>>>
>>> I guess so, but it only should happen with --enable-mods-shared=few
>>> which I guess is not that common.
>>>
>>
>> No, also happens with --enable-modules=none - something used to build
>> only the core, or explicitly listed modules, as you might expect out of
>> any
>> more sophisticated/component-oriented build schema...
>>
>> checking whether to enable mod_proxy_hcheck... checking dependencies
>> configure: WARNING: "mod_watchdog is disabled but required for
>> mod_proxy_hcheck"
>> checking whether to enable mod_proxy_hcheck... configure: error:
>> mod_proxy_hcheck has been requested but can not be built due to
>> prerequisite failures
>>
>
> Something else bothersome, but not a showstopper (and not a regression)...
>
> "../../httpd-2.4/configure" \
> "--prefix=/opt/apache24-apr15-ossl102" \
> "--with-apr=/opt/apr15-ossl102" \
> "--with-apr-util=/opt/apr15-ossl102"
>
> checking whether to enable mod_lbmethod_byrequests... shared
> checking whether to enable mod_lbmethod_bytraffic... shared
> checking whether to enable mod_lbmethod_bybusyness... shared
> checking whether to enable mod_lbmethod_heartbeat... shared
>
> Huh??? What does an lbmethod do with no proxy balancer?
>

More specifically...

 "../../httpd-2.4/configure" \
"--prefix=/opt/apache24-apr15-ossl102" \
"--with-apr=/opt/apr15-ossl102" \
"--with-apr-util=/opt/apr15-ossl102" \
"--enable-proxy=no"

(The default is --enable-mods-shared=most, including proxy)

Note that in most other scenarios, the ./configure proceeded, with warnings
about

"configure: WARNING: "mod_watchdog is disabled but required for
mod_proxy_hcheck"
 checking whether to enable mod_proxy_hcheck... no (disabled)"

which was fine.  Halting ./configure entirely in an unexpected way, under
some
of the scenarios, was the reason I believe this candidate is not viable.

Re: svn commit: r1748888 - /httpd/httpd/trunk/modules/proxy/config.m4

2016-06-20 Thread William A Rowe Jr 
On Mon, Jun 20, 2016 at 9:30 PM, William A Rowe Jr 
wrote:

> On Mon, Jun 20, 2016 at 1:46 PM, Ruediger Pluem  wrote:
>
>>
>> On 06/20/2016 07:04 PM, William A Rowe Jr wrote:
>> > Did we miss this build breakage fix in 2.4.22?
>>
>> I guess so, but it only should happen with --enable-mods-shared=few which
>> I guess is not that common.
>>
>
> No, also happens with --enable-modules=none - something used to build
> only the core, or explicitly listed modules, as you might expect out of any
> more sophisticated/component-oriented build schema...
>
> checking whether to enable mod_proxy_hcheck... checking dependencies
> configure: WARNING: "mod_watchdog is disabled but required for
> mod_proxy_hcheck"
> checking whether to enable mod_proxy_hcheck... configure: error:
> mod_proxy_hcheck has been requested but can not be built due to
> prerequisite failures
>

Something else bothersome, but not a showstopper (and not a regression)...

"../../httpd-2.4/configure" \
"--prefix=/opt/apache24-apr15-ossl102" \
"--with-apr=/opt/apr15-ossl102" \
"--with-apr-util=/opt/apr15-ossl102"

checking whether to enable mod_lbmethod_byrequests... shared
checking whether to enable mod_lbmethod_bytraffic... shared
checking whether to enable mod_lbmethod_bybusyness... shared
checking whether to enable mod_lbmethod_heartbeat... shared

Huh??? What does an lbmethod do with no proxy balancer?

Re: [VOTE] Release Apache httpd 2.4.22 as GA

2016-06-20 Thread William A Rowe Jr 
On Mon, Jun 20, 2016 at 8:20 AM, Jim Jagielski  wrote:

> The pre-release test tarballs for Apache httpd 2.4.22 can be found
> at the usual place:
>
> http://httpd.apache.org/dev/dist/
>
> I'm calling a VOTE on releasing these as Apache httpd 2.4.22 GA.
>
> [ ] +1: Good to go
> [ ] +0: meh
> [X] -1: Danger Will Robinson. And why.
>

Given the lengths Jens Schleusener needed to go through to diagnose
this during the original release candidate vote, and the availability of
the patch prior to this tag to fix the RM's own defect (demonstrated
easily with any --enable-modules of few or none, after this community
went to great lengths to re-think the appropriate categorization of all
modules under all/most/few schema) this candidate is clearly not
ready for prime time.

In all other respects, I see no significant regressions or new issues.
Thanks for RM'ing (2x now)!

Re: svn commit: r1748888 - /httpd/httpd/trunk/modules/proxy/config.m4

2016-06-20 Thread William A Rowe Jr 
On Mon, Jun 20, 2016 at 1:46 PM, Ruediger Pluem  wrote:

>
> On 06/20/2016 07:04 PM, William A Rowe Jr wrote:
> > Did we miss this build breakage fix in 2.4.22?
>
> I guess so, but it only should happen with --enable-mods-shared=few which
> I guess is not that common.
>

No, also happens with --enable-modules=none - something used to build
only the core, or explicitly listed modules, as you might expect out of any
more sophisticated/component-oriented build schema...

checking whether to enable mod_proxy_hcheck... checking dependencies
configure: WARNING: "mod_watchdog is disabled but required for
mod_proxy_hcheck"
checking whether to enable mod_proxy_hcheck... configure: error:
mod_proxy_hcheck has been requested but can not be built due to
prerequisite failures

Re: Question about mod_sed

2016-06-20 Thread Christophe JAILLET 

Le 17/06/2016 à 14:35, Ruediger Pluem a écrit :


On 06/17/2016 02:24 PM, Marion et Christophe JAILLET wrote:

Hi,

  


The code in trunk and 2.4 don't have the 3 last lines:

memcpy(eval->gspend, sz, len + 1);
/* hspend will now point to NULL character */
eval->gspend += len;

  


See:


http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/sed1.c?revision=1326984=markup#l231

  

  


The code in my first post is what I think is correct.

Sorry for not being clear.

Sorry for not reading your mail correctly :-). It was in there.
Yes, I agree that the copy stuff is missing. Weird. Nevertheless I think

eval->gspend += len;

in your proposal is wrong as eval->gspend looks like the buffer base pointer
for me that should not be changed.

Regards

Rüdiger


Updated (and now compiled and tested :) ) patch applied in r1749401
Thx for the feedback.

CJ

Re: svn commit: r1748888 - /httpd/httpd/trunk/modules/proxy/config.m4

2016-06-20 Thread Ruediger Pluem 


On 06/20/2016 07:04 PM, William A Rowe Jr wrote:
> Did we miss this build breakage fix in 2.4.22?

I guess so, but it only should happen with --enable-mods-shared=few which I 
guess is not that common.

Regards

Rüdiger

Re: svn commit: r1748888 - /httpd/httpd/trunk/modules/proxy/config.m4

2016-06-20 Thread William A Rowe Jr 
Did we miss this build breakage fix in 2.4.22?

On Fri, Jun 17, 2016 at 1:29 PM,  wrote:

> Author: rpluem
> Date: Fri Jun 17 18:29:16 2016
> New Revision: 174
>
> URL: http://svn.apache.org/viewvc?rev=174=rev
> Log:
> * If enable_proxy_hcheck is unset handle it like other proxy modules
>
> Modified:
> httpd/httpd/trunk/modules/proxy/config.m4
>
> Modified: httpd/httpd/trunk/modules/proxy/config.m4
> URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/config.m4?rev=174=1748887=174=diff
>
> ==
> --- httpd/httpd/trunk/modules/proxy/config.m4 (original)
> +++ httpd/httpd/trunk/modules/proxy/config.m4 Fri Jun 17 18:29:16 2016
> @@ -13,6 +13,10 @@ fi
>  if test "$proxy_mods_enable" = "no"; then
>enable_proxy_hcheck=no
>  fi
> +dnl If enable_proxy_hcheck is unset handle it like other proxy modules
> +if test -z "$enable_proxy_hcheck" ; then
> +  enable_proxy_hcheck="$proxy_mods_enable"
> +fi
>
>  proxy_objs="mod_proxy.lo proxy_util.lo"
>  APACHE_MODULE(proxy, Apache proxy module, $proxy_objs, ,
> $proxy_mods_enable)
>
>
>

Re: [VOTE] Release Apache httpd 2.4.22 as GA

2016-06-20 Thread Reindl Harald 



Am 20.06.2016 um 15:20 schrieb Jim Jagielski:

The pre-release test tarballs for Apache httpd 2.4.22 can be found
at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.22 GA.

[x] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why


+1

looks good on Fedora 23 x86_64



signature.asc
Description: OpenPGP digital signature

Re: [VOTE] Release Apache httpd 2.4.22 as GA

2016-06-20 Thread Jan Ehrhardt 
Jim Jagielski in gmane.comp.apache.devel (Mon, 20 Jun 2016 09:20:43
-0400):
>The pre-release test tarballs for Apache httpd 2.4.22 can be found
>at the usual place:
>
>   http://httpd.apache.org/dev/dist/
>
>I'm calling a VOTE on releasing these as Apache httpd 2.4.22 GA.
>
>[ ] +1: Good to go

Running on a Windows 2008R2 server now, built with VC9 x86. OpenSSl 1.0.2h
Fips, mod_http2.
-- 
Jan

Re: [VOTE] Release Apache httpd 2.4.22 as GA

2016-06-20 Thread Stefan Eissing 

> Am 20.06.2016 um 15:20 schrieb Jim Jagielski :
> 
> The pre-release test tarballs for Apache httpd 2.4.22 can be found
> at the usual place:
> 
>   http://httpd.apache.org/dev/dist/
> 
> I'm calling a VOTE on releasing these as Apache httpd 2.4.22 GA.
> 
> [ ] +1: Good to go
> [ ] +0: meh
> [ ] -1: Danger Will Robinson. And why.
> 
> Vote will last the normal 72 hrs.
> 
> NOTE: The *-deps are only there for convenience.
> 
> Thx!

Tested:
* 14.04.1-Ubuntu, x86_64

Re: [VOTE] Release Apache httpd 2.4.22 as GA

2016-06-20 Thread Jim Jagielski 

> On Jun 20, 2016, at 9:20 AM, Jim Jagielski  wrote:
> 
> The pre-release test tarballs for Apache httpd 2.4.22 can be found
> at the usual place:
> 
>   http://httpd.apache.org/dev/dist/
> 
> I'm calling a VOTE on releasing these as Apache httpd 2.4.22 GA.
> 
> [X] +1: Good to go

Tested:
 o CentOS6, x64
 o CentOS7, x64
 o OSX 10.11.5 / Xcode 7.3.1, x64

[VOTE] Release Apache httpd 2.4.22 as GA

2016-06-20 Thread Jim Jagielski 
The pre-release test tarballs for Apache httpd 2.4.22 can be found
at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.22 GA.

[ ] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why.

Vote will last the normal 72 hrs.

NOTE: The *-deps are only there for convenience.

Thx!

Re: [VOTE] Release Apache httpd 2.4.21 as GA

2016-06-20 Thread Jim Jagielski 
Due to a last-minute regression, I am cancelling this VOTE.

Instead, the plan is to get the regression fix approved for
backport (http://svn.apache.org/viewvc?view=revision=1749151)
and release 2.4.22.

Thx to all testers... and keep your eyes open for the next VOTE to
come hopefully later on today.

Re: [VOTE] Release Apache httpd 2.4.21 as GA

2016-06-20 Thread Jim Jagielski 
Yes, I am trending the same way...

> On Jun 20, 2016, at 7:58 AM, Steffen  wrote:
> 
> Is a regression. Better to have the fix in GA. 
> 
>> Op 20 jun. 2016 om 13:51 heeft Stefan Eissing  
>> het volgende geschreven:
>> 
>> Yes. Everything else is +1. Just this. Just wanted to express that I do not 
>> see it as blocking, but am not happy about it either.
>> 
>>> Am 20.06.2016 um 13:49 schrieb Jim Jagielski :
>>> 
>>> Although not required, I am curious about the +0 vote. Is it
>>> due totally to the non-release breaking bug? (the one fixed
>>> w/ the 'h2_beam_abort(stream->input);' line added to h2_mplx.c) ?
>>> 
 On Jun 20, 2016, at 4:07 AM, Stefan Eissing  
 wrote:
 
 Tested:
 (15.5.0 Darwin): event, prefork, worker
 (14.04.1-Ubuntu, x86_64): event, worker 
 
 Vote: +0
 
 The bug discovered by Michael Kaufmann is not release breaking for me. If 
 we'd find another issue, I would bring in the fix.
 
 -Stefan
 
> Am 16.06.2016 um 19:07 schrieb Jim Jagielski :
> 
> The pre-release test tarballs for Apache httpd 2.4.21 can be found
> at the usual place:
> 
>   http://httpd.apache.org/dev/dist/
> 
> I'm calling a VOTE on releasing these as Apache httpd 2.4.21 GA.
> 
> [ ] +1: Good to go
> [ ] +0: meh
> [ ] -1: Danger Will Robinson. And why.
> 
> Vote will last the normal 72 hrs.
> 
> NOTE: The *-deps are only there for convenience.
> 
> Thx!
>> 
>

Re: [VOTE] Release Apache httpd 2.4.21 as GA

2016-06-20 Thread Steffen 
Is a regression. Better to have the fix in GA. 

> Op 20 jun. 2016 om 13:51 heeft Stefan Eissing  
> het volgende geschreven:
> 
> Yes. Everything else is +1. Just this. Just wanted to express that I do not 
> see it as blocking, but am not happy about it either.
> 
>> Am 20.06.2016 um 13:49 schrieb Jim Jagielski :
>> 
>> Although not required, I am curious about the +0 vote. Is it
>> due totally to the non-release breaking bug? (the one fixed
>> w/ the 'h2_beam_abort(stream->input);' line added to h2_mplx.c) ?
>> 
>>> On Jun 20, 2016, at 4:07 AM, Stefan Eissing  
>>> wrote:
>>> 
>>> Tested:
>>> (15.5.0 Darwin): event, prefork, worker
>>> (14.04.1-Ubuntu, x86_64): event, worker 
>>> 
>>> Vote: +0
>>> 
>>> The bug discovered by Michael Kaufmann is not release breaking for me. If 
>>> we'd find another issue, I would bring in the fix.
>>> 
>>> -Stefan
>>> 
 Am 16.06.2016 um 19:07 schrieb Jim Jagielski :
 
 The pre-release test tarballs for Apache httpd 2.4.21 can be found
 at the usual place:
 
http://httpd.apache.org/dev/dist/
 
 I'm calling a VOTE on releasing these as Apache httpd 2.4.21 GA.
 
 [ ] +1: Good to go
 [ ] +0: meh
 [ ] -1: Danger Will Robinson. And why.
 
 Vote will last the normal 72 hrs.
 
 NOTE: The *-deps are only there for convenience.
 
 Thx!
>

Re: [VOTE] Release Apache httpd 2.4.21 as GA

2016-06-20 Thread Stefan Eissing 
Yes. Everything else is +1. Just this. Just wanted to express that I do not see 
it as blocking, but am not happy about it either.

> Am 20.06.2016 um 13:49 schrieb Jim Jagielski :
> 
> Although not required, I am curious about the +0 vote. Is it
> due totally to the non-release breaking bug? (the one fixed
> w/ the 'h2_beam_abort(stream->input);' line added to h2_mplx.c) ?
> 
>> On Jun 20, 2016, at 4:07 AM, Stefan Eissing  
>> wrote:
>> 
>> Tested:
>> (15.5.0 Darwin): event, prefork, worker
>> (14.04.1-Ubuntu, x86_64): event, worker 
>> 
>> Vote: +0
>> 
>> The bug discovered by Michael Kaufmann is not release breaking for me. If 
>> we'd find another issue, I would bring in the fix.
>> 
>> -Stefan
>> 
>>> Am 16.06.2016 um 19:07 schrieb Jim Jagielski :
>>> 
>>> The pre-release test tarballs for Apache httpd 2.4.21 can be found
>>> at the usual place:
>>> 
>>> http://httpd.apache.org/dev/dist/
>>> 
>>> I'm calling a VOTE on releasing these as Apache httpd 2.4.21 GA.
>>> 
>>> [ ] +1: Good to go
>>> [ ] +0: meh
>>> [ ] -1: Danger Will Robinson. And why.
>>> 
>>> Vote will last the normal 72 hrs.
>>> 
>>> NOTE: The *-deps are only there for convenience.
>>> 
>>> Thx!
>> 
>

Re: [VOTE] Release Apache httpd 2.4.21 as GA

2016-06-20 Thread Jim Jagielski 
Although not required, I am curious about the +0 vote. Is it
due totally to the non-release breaking bug? (the one fixed
w/ the 'h2_beam_abort(stream->input);' line added to h2_mplx.c) ?

> On Jun 20, 2016, at 4:07 AM, Stefan Eissing  
> wrote:
> 
> Tested:
> (15.5.0 Darwin): event, prefork, worker
> (14.04.1-Ubuntu, x86_64): event, worker 
> 
> Vote: +0
> 
> The bug discovered by Michael Kaufmann is not release breaking for me. If 
> we'd find another issue, I would bring in the fix.
> 
> -Stefan
> 
>> Am 16.06.2016 um 19:07 schrieb Jim Jagielski :
>> 
>> The pre-release test tarballs for Apache httpd 2.4.21 can be found
>> at the usual place:
>> 
>>  http://httpd.apache.org/dev/dist/
>> 
>> I'm calling a VOTE on releasing these as Apache httpd 2.4.21 GA.
>> 
>> [ ] +1: Good to go
>> [ ] +0: meh
>> [ ] -1: Danger Will Robinson. And why.
>> 
>> Vote will last the normal 72 hrs.
>> 
>> NOTE: The *-deps are only there for convenience.
>> 
>> Thx!
>

Re: [VOTE] Release Apache httpd 2.4.21 as GA

2016-06-20 Thread Steffen 


All fine on Windows.


On Thursday 16/06/2016 at 19:07, Jim Jagielski  wrote:

The pre-release test tarballs for Apache httpd 2.4.21 can be found
at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.21 GA.

[ ] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why.

Vote will last the normal 72 hrs.

NOTE: The *-deps are only there for convenience.

Thx!

Re: [VOTE] Release Apache httpd 2.4.21 as GA

2016-06-20 Thread Stefan Eissing 
Tested:
(15.5.0 Darwin): event, prefork, worker
(14.04.1-Ubuntu, x86_64): event, worker 

Vote: +0

The bug discovered by Michael Kaufmann is not release breaking for me. If we'd 
find another issue, I would bring in the fix.

-Stefan

> Am 16.06.2016 um 19:07 schrieb Jim Jagielski :
> 
> The pre-release test tarballs for Apache httpd 2.4.21 can be found
> at the usual place:
> 
>   http://httpd.apache.org/dev/dist/
> 
> I'm calling a VOTE on releasing these as Apache httpd 2.4.21 GA.
> 
> [ ] +1: Good to go
> [ ] +0: meh
> [ ] -1: Danger Will Robinson. And why.
> 
> Vote will last the normal 72 hrs.
> 
> NOTE: The *-deps are only there for convenience.
> 
> Thx!