Re: Welcome Evgeny Kotkov as a new committer

2016-09-20 Thread Christophe JAILLET 

Welcome Evgeny and thanks for sharing the work on brotli.

CJ

Re: [PATCH] Introducing mod_brotli

2016-09-20 Thread Evgeny Kotkov 
Evgeny Kotkov  writes:

>>> Wow! This is great stuff. Brotli support has been in my TODO
>>> queue for awhile.
>>>
>>> Thanks!
>>
>> +1, cool stuff and thanks!
>
> Glad to hear that, thanks everyone.
>
> I would be happy to continue the work on this module, for instance, by
> adding the necessary documentation and the ability to log compression ratio.

So, my current plan is to commit the V1 patch, prepare the necessary bits
of documentation (marking the module as experimental), and then continue
shaping it up by adding the optional, but important things, such as the
compression ratio logging.

I'll start doing this tomorrow.


Regards,
Evgeny Kotkov

Re: Welcome Evgeny Kotkov as a new committer

2016-09-20 Thread Evgeny Kotkov 
Jacob Champion  writes:

>> Please welcome Evgeny Kotkov as a new committer!
>
> Excellent, welcome to the team!

Thanks everyone!


Regards,
Evgeny Kotkov

Re: Welcome Evgeny Kotkov as a new committer

2016-09-20 Thread Jacob Champion 

On 09/20/2016 05:35 AM, Eric Covener wrote:

Please welcome Evgeny Kotkov as a new committer!


Excellent, welcome to the team!

--Jacob

Re: mod_fcgid: Immediate HTTP error 503 if the max total process count is reached

2016-09-20 Thread Eric Covener 
On Mon, Sep 19, 2016 at 4:30 AM, Ivan Zahariev  wrote:
> Hello devs,
>
> It's been four months since I originally proposed this new feature in
> "mod_fcgid". During this time I've tested and deployed it on hundreds of
> busy production servers. It works as expected. If enabled, web visitors get
> an immediate response when FastCGI is overloaded, and no RAM is
> over-utilized.
>
> You can find all the information and a patch in the enhancement request at
> Bugzilla: https://bz.apache.org/bugzilla/show_bug.cgi?id=59656
>
> Can we get this merged into "mod_fcgid"?
>
> Best regards.
> --Ivan

Unfortunately there are not many reviewers for mod_fcgid.

I tried to take as a relative laymen and had a few comments/questions:

* a few C99 // comments were added and should be zapped
* the assert looks funny -- no assert.   maybe ap_debug_assert() so it
blows up in maintainer builds only?
* The new flag is merged, but cannot be unset?
** Probably need to make it look like an AP_INIT_FLAG
* I couldn't follow the concept in the comments around
max_process_count moving or being per-request. Is it maybe out of
date? I think the current impl takes an existing global only and
merges it with vhost server confs but it will always be a copy.

Re: Welcome Evgeny Kotkov as a new committer

2016-09-20 Thread Stefan Eissing 
Welcome!

> Am 20.09.2016 um 15:06 schrieb Yann Ylavic :
> 
> On Tue, Sep 20, 2016 at 2:35 PM, Eric Covener  wrote:
>> Please welcome Evgeny Kotkov as a new committer!
> 
> Great, welcome Evgeny!
> 
> Regards,
> Yann.

Re: Welcome Evgeny Kotkov as a new committer

2016-09-20 Thread Yann Ylavic 
On Tue, Sep 20, 2016 at 2:35 PM, Eric Covener  wrote:
> Please welcome Evgeny Kotkov as a new committer!

Great, welcome Evgeny!

Regards,
Yann.

Welcome Evgeny Kotkov as a new committer

2016-09-20 Thread Eric Covener 
Please welcome Evgeny Kotkov as a new committer!

-- 
Eric Covener
cove...@gmail.com

Re: [PATCH] Introducing mod_brotli

2016-09-20 Thread Evgeny Kotkov 
Reindl Harald  writes:

> agreed - however, below some configs where my brain rumours how have that
> identically behavior by just use "brotli" compression in case the cient
> supports it - maybe someone with deeper insights as my pure adiminstrator
> view has a idea by looking at it
>
> the "no-gzip dont-vary" stuff is for long running scripts with
> output-flushing to give "realtime" feedback instead have it all buffered
>
> one brainstorming: "AddOutputCompressionByType" provided by whatever module,
> proceed the Accept-Encoding of the client and deciding the compression algo

Adding the new output filter to the AddOutputFilterByType directive will
result in what you're looking for.  For instance, changing

  AddOutputFilterByType DEFLATE text/html

to

  AddOutputFilterByType BROTLI_COMPRESS;DEFLATE text/html

means that the server will send Brotli-compressed data to clients that have
"br" in their Accept-Encoding request header, and Deflate data to other
clients that indicate gzip/deflate support.

> SetEnvIfNoCase Request_URI (download.php)$ no-gzip dont-vary
> SetEnvIfNoCase Request_URI (download_imgzip.php)$ no-gzip dont-vary
> SetEnvIfNoCase Request_URI (presse_download_zip.php)$ no-gzip dont-vary
> SetEnvIfNoCase Request_URI (content_sub_move.php)$ no-gzip dont-vary
> SetEnvIfNoCase Request_URI (synch.php)$ no-gzip dont-vary
> SetEnvIfNoCase Request_URI (import.php)$ no-gzip dont-vary
> SetEnvIfNoCase Request_URI (admin_imagecopyrights.php)$ no-gzip dont-vary
> SetEnvIfNoCase Request_URI (newsletter.php)$ no-gzip dont-vary
> SetEnvIfNoCase Request_URI (importer.php)$ no-gzip dont-vary
> SetEnvIfNoCase Request_URI (create.php)$ no-gzip dont-vary

The V1 patch doesn't add the equivalent of "no-gzip" (like, "no-brotli") env
variable.  This is left out for future work, and until then these statements
cannot be migrated seamlessly.  However, I think that the wanted behavior
here could be achieved with mod_filter's FilterProvider directive using
an expression that doesn't install any compression filters for the scripts.


Regards,
Evgeny Kotkov