Re: Trunk errors
Patch gives errors, but was given me the direction, Thanks! htdbm and htpasswd got it running !! by adding in support/passwd_common.h : #if !defined(WIN32) && !defined(NETWARE) #include "ap_config_auto.h" #endif Your patch not used it is giving other errors, for example ab is not building, get ab.obj : error LNK2001: unresolved external symbol __imp__ap_real_exit_code So left issues : mod_ssl : ssl\ssl_engine_io.c(33,10): fatal error C1083: Cannot open include file: 'core.h' When I copy server/core.h to mod_ssl dir, then error: ssl_engine_io.obj : error LNK2019: unresolved external symbol _ap_filter_adopt_brigade referenced in function _char_buffer_insert Tried also link with libhttpd.lib, no go. And the ones with Greggs answer. Tried revision 1877505. libhttpd : miss in trunk modules\http\http_etag.c. Moved the one from Branches to include, libhttpd builds then, is that ok ? Gregg: Yes to get it to build for now. Question is why isn't it in trunk, modules/http like it is in branches or anywhere (quick look and I can't see it). mod_cache : #include "test_char.h" not found. Copied the generated server/test_char.h to /include, mod_cache builds then, is that ok ? Gregg: Yes to get it to build for now. We may just need to change the location it's generated to, or just point to it's location in the build. If it's not a public header then we do the second option. I'll look at that. Steffen, trying to be a human Travis :) On Saturday 09/05/2020 at 14:59, Yann Ylavic wrote: On Sat, May 9, 2020 at 1:10 AM Gregg Smith wrote: htdbm and htpasswd : support\passwd_common.h(31,10): fatal error C1083: Cannot open include file: 'ap_config_auto.h': No such file or directory. This gives me a deja vu feeling with what stopped mod_ssl from building in 2.4.42. The winbuilds dsp/mak files generate headers by copying a .h.in file of the same name like ap_config_layout.h.in. This deja vu feeling tells me just feeding it an empty ap_config_auto.h will not do. It might build at least and seem to work but wouldn't be correct. Yann? :) I think we should not #include ap_config_auto.h directly, but ap_config.h instead (which has the necessary #ifnot WINW32..). So how about the attached patch? Regards, Yann.
Re: Trunk errors
On Sat, May 9, 2020 at 1:10 AM Gregg Smith wrote: > > > htdbm and htpasswd : > > support\passwd_common.h(31,10): fatal error C1083: Cannot open include > > file: 'ap_config_auto.h': No such file or directory. > > > This gives me a deja vu feeling with what stopped mod_ssl from building > in 2.4.42. The winbuilds dsp/mak files generate headers by copying a > .h.in file of the same name like ap_config_layout.h.in. This deja vu > feeling tells me just feeding it an empty ap_config_auto.h will not do. > It might build at least and seem to work but wouldn't be correct. > Yann? :) I think we should not #include ap_config_auto.h directly, but ap_config.h instead (which has the necessary #ifnot WINW32..). So how about the attached patch? Regards, Yann. Index: modules/dav/fs/mod_dav_fs.c === --- modules/dav/fs/mod_dav_fs.c (revision 1876933) +++ modules/dav/fs/mod_dav_fs.c (working copy) @@ -17,9 +17,7 @@ #include "httpd.h" #include "http_config.h" #include "apr_strings.h" -#if !defined(_MSC_VER) && !defined(NETWARE) -#include "ap_config_auto.h" -#endif +#include "ap_config.h" #include "mod_dav.h" #include "repos.h" Index: modules/proxy/mod_serf.h === --- modules/proxy/mod_serf.h (revision 1876933) +++ modules/proxy/mod_serf.h (working copy) @@ -23,9 +23,7 @@ #include "httpd.h" #include "http_config.h" -#if !defined(WIN32) && !defined(NETWARE) -#include "ap_config_auto.h" -#endif +#include "ap_config.h" #ifdef HAVE_SERF #include "serf.h" #endif Index: support/ab.c === --- support/ab.c (revision 1876933) +++ support/ab.c (working copy) @@ -153,9 +153,7 @@ #include /* for getpid() */ #endif -#if !defined(WIN32) && !defined(NETWARE) -#include "ap_config_auto.h" -#endif +#include "ap_config.h" #if defined(HAVE_OPENSSL) Index: support/passwd_common.h === --- support/passwd_common.h (revision 1876933) +++ support/passwd_common.h (working copy) @@ -28,7 +28,7 @@ #include "apu_version.h" #endif -#include "ap_config_auto.h" +#include "ap_config.h" #define MAX_STRING_LEN 256
Re: Trunk errors
Forget mod_ssl error below for now. The first error is: ssl\ssl_engine_io.c(33,10): fatal error C1083: Cannot open include file: 'core.h' When I copy core.h to mod_ssl dir, then I get below error. Tried also link with libhttpd.lib, no go. So first solve the core.h error. On Saturday 09/05/2020 at 01:10, Gregg Smith wrote: Hi Steffen, Assuming your building in the IDE as I know to be your usual; On 5/8/2020 4:59 AM, Steffen wrote: Tried revision 1877505. libhttpd : miss in trunk modules\http\http_etag.c. Moved the one from Branches to include, libhttpd builds then, is that ok ? Yes to get it to build for now. Question is why isn't it in trunk, modules/http like it is in branches or anywhere (quick look and I can't see it). mod_cache : #include "test_char.h" not found. Copied the generated server/test_char.h to /include, mod_cache builds then, is that ok ? Yes to get it to build for now. We may just need to change the location it's generated to, or just point to it's location in the build. If it's not a public header then we do the second option. I'll look at that. htdbm and htpasswd : support\passwd_common.h(31,10): fatal error C1083: Cannot open include file: 'ap_config_auto.h': No such file or directory. This gives me a deja vu feeling with what stopped mod_ssl from building in 2.4.42. The winbuilds dsp/mak files generate headers by copying a .h.in file of the same name like ap_config_layout.h.in. This deja vu feeling tells me just feeding it an empty ap_config_auto.h will not do. It might build at least and seem to work but wouldn't be correct. Yann? :) mod_ssl : ssl_engine_io.obj : error LNK2019: unresolved external symbol _ap_filter_adopt_brigade referenced in function _char_buffer_insert AFAIK all ap_* functions are in libhttpd, maybe we're not compiling/linking a new file. It looks to be in util_filters.c and that shows as being compiled/linked to libhttpd. ???Huh??? Looks like all the errors are related to changes in/after 2018. In 2018 I build it without errors. Did not build all yet and only Win32 VS16, so maybe more to come. Let's get it building on one version first, worry about any nuances in the various VC versions second. Gregg
