Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
+1 for beta On Jun 26, 2008, at 10:28 PM, William A. Rowe, Jr. wrote: Sander Temme wrote: [X] +1 to release as 0.9.2-beta, and ready to tag GA (1.0.0) Compiles cleanly (no emits) on httpd 2.2.9 w/ APR and APU 1.3.x r671971 built w/ libtool 1.5.26. Module loads, config loads with all defaults, I can connect and be denied login access, which seems a comfortable level of default lockdown. Good to hear, and thanks for testing. Unfortunately that's 2 binding +1's with a little over 18 hours left in the vote. I'll probably swing my vote to beta if a third beta vote came in beta. My main reason for choosing -alpha was the revert of the old ABOR handling that Jim had wedged into the cmd table (BOR, ABO etc with some binary nuggets that broke HELP). So many client authors were clueless about telnet and out of band data that I think some users would be frustrated by the broken ^C behavior, we could probably get more coherent reports if it was -alpha. But I'm happy either way. Thanks too to Jorge and Takashi for their review. I'd be +1 on seeing this out there, but would fix Takashi San's observations before GA. Agreed, I'd actually want to address them all before 0.9.3-whatever, but it's certainly not broad enough to hold up at least something as beta or alpha. He was correct that it's not GA until those are fixed.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Jim Jagielski wrote: +1 for beta That's three; and as promised I'll promote my vote from alpha to beta. At 2200 GMT I'll collect any final votes and promote to released. Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0^H2
Takashi Sato wrote: ftp_commands.c: In function 'ftp_cmd_pbsz': ftp_commands.c:1706: warning: comparison is always false due to limited range of data type If 'arg' is 2147483647 on the sizeof(int) == 4 == sizeof(long) system, fc-pbsz == LONG_MAX. But on the sizeof(int) == 4 sizeof(long) system, fc-pbsz != LONG_MAX. I have not read the code deeply, but I think this is not quite dangerous. There is no code using pbsz. I have found other assignments of resutl of strtol to int. mod_ftp.c line 406 *(int *) ((char *) fsc + offset) = strtol(arg, endptr, 10); line 436 umask = strtol(arg, endp, 8); line 459 umask = strtol(arg, endp, 8); My environment: FreeBSD 7-STABLE AMD64 gcc version 4.2.1 20070719 [FreeBSD] All good bugs to fix, thanks Takashi. None look like showstoppers to an alpha quality release though ;-) Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
William A. Rowe, Jr. wrote: review, take it for a spin, and cast your choice [X] +1 to release as 0.9.2-alpha My vote, of course. Going to declare this vote done tomorrow night and rm the candidates if it fails. Caught up with Jorge, his vhost confusion stemmed from old docs (long ago updated on the site and in trunk/). He's reported success (interestingly with ServerName but not ServerAlias, I suspect misconfig but will review.) Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
On Jun 17, 2008, at 2:43 PM, William A. Rowe, Jr. wrote: review, take it for a spin, and cast your choice [ ] -1 for any release of 0.9.2 [ ] +1 to release as 0.9.2-alpha [ ] +1 to release as 0.9.2-beta [X] +1 to release as 0.9.2-beta, and ready to tag GA (1.0.0) Compiles cleanly (no emits) on httpd 2.2.9 w/ APR and APU 1.3.x r671971 built w/ libtool 1.5.26. Module loads, config loads with all defaults, I can connect and be denied login access, which seems a comfortable level of default lockdown. I'd be +1 on seeing this out there, but would fix Takashi San's observations before GA. S. -- Sander Temme [EMAIL PROTECTED] PGP FP: 51B4 8727 466A 0BC3 69F4 B7B8 B2BE BC40 1529 24AF smime.p7s Description: S/MIME cryptographic signature
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Compiles fine and is working as before on gentoo... named vhosting still broken though [ X ] +1 to release as 0.9.2-beta ~Jorge On Sat, Jun 21, 2008 at 9:17 AM, Takashi Sato [EMAIL PROTECTED] wrote: On Tue, 17 Jun 2008 16:43:14 -0500 William A. Rowe, Jr. [EMAIL PROTECTED] wrote: [ ] -1 for any release of 0.9.2 [ ] +1 to release as 0.9.2-alpha [ ] +1 to release as 0.9.2-beta [ ] +1 to release as 0.9.2-beta, and ready to tag GA (1.0.0) -0 ftp_commands.c: In function 'ftp_cmd_pbsz': ftp_commands.c:1706: warning: comparison is always false due to limited range of data type If 'arg' is 2147483647 on the sizeof(int) == 4 == sizeof(long) system, fc-pbsz == LONG_MAX. But on the sizeof(int) == 4 sizeof(long) system, fc-pbsz != LONG_MAX. I have not read the code deeply, but I think this is not quite dangerous. There is no code using pbsz. I have found other assignments of resutl of strtol to int. mod_ftp.c line 406 *(int *) ((char *) fsc + offset) = strtol(arg, endptr, 10); line 436 umask = strtol(arg, endp, 8); line 459 umask = strtol(arg, endp, 8); My environment: FreeBSD 7-STABLE AMD64 gcc version 4.2.1 20070719 [FreeBSD]
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
William A. Rowe, Jr. wrote: Please fetch up the newly prepared httpd-mod_ftp-0.9.2.tar.gz (available now), or the win32/netware/os2 suitable package httpd-mod_ftp-0.9.2-crlf.zip (still needs to sync in the next hour) from: http://httpd.apache.org/dev/dist/mod_ftp/ review, take it for a spin, and cast your choice Gonna let this vote spin a good 10 days to give people a chance to try this out and review, there's no rush. So we'll call it on the 27th, a week from today.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Niklas Edmundsson wrote: On Sun, 23 Dec 2007, Ruediger Pluem wrote: On 12/21/2007 08:01 PM, Niklas Edmundsson wrote: However, I found a slight bug that might be my configuration or something worse: httpd won't serve http when I have mod_ftp with accompanying config enabled. It reads the request and then closes the connection, it doesn't even log anything in the error log despite logging at debug level... I guess this is PR44133. Yup. Not surprisingly http while mod_ftp is loaded works much better now ;) Absolutely - sorry was overaggressive during my pool refactoring, that was quite an insidious change I committed. Thanks to Tom for pinning this down so quickly. I'd say +1 to tag what's in trunk now as an alpha, it needs a bit more testing to shake out embarrasing issues like this before we'd want to call it beta IMHO. Well, I'll roll again by tomorrow, I'm actually 'offline' booted into win32 most of this week, experimenting with VS2008 for multiple purposes, including tracking down the build failures for multicast.c in apr, working out the MPM fixes for logging (Tom's added more notations in bugzilla) and planning a Makefile.win for mod_ftp to really round-out this 0.9.1 tag (easier said than done, given the absence of apxs, another project I'd like to close ;-) Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
On Sun, 23 Dec 2007, Ruediger Pluem wrote:
On 12/21/2007 08:01 PM, Niklas Edmundsson wrote:
However, I found a slight bug that might be my configuration or
something worse: httpd won't serve http when I have mod_ftp with
accompanying config enabled. It reads the request and then closes the
connection, it doesn't even log anything in the error log despite
logging at debug level...
I guess this is PR44133.
Yup. Not surprisingly http while mod_ftp is loaded works much better
now ;)
I'd say +1 to tag what's in trunk now as an alpha, it needs a bit more
testing to shake out embarrasing issues like this before we'd want to
call it beta IMHO.
/Nikke
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED]
---
I am Paul Simon of Borg. ... must be 50 ways to assimilate your lover.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
On 12/21/2007 08:01 PM, Niklas Edmundsson wrote: However, I found a slight bug that might be my configuration or something worse: httpd won't serve http when I have mod_ftp with accompanying config enabled. It reads the request and then closes the connection, it doesn't even log anything in the error log despite logging at debug level... I guess this is PR44133. https://issues.apache.org/bugzilla/show_bug.cgi?id=44133 Regards Rüdiger
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Niklas Edmundsson wrote: However, I found a slight bug that might be my configuration or something worse: httpd won't serve http when I have mod_ftp with accompanying config enabled. It reads the request and then closes the connection, it doesn't even log anything in the error log despite logging at debug level... You aren't imagining things. My first gutcheck suggested this was some fail-over VirtualHost happening, but changing my host didn't affect it. LogLevel debug isn't being helpful, so I have some tracing to do, and the 1.9.1 candidate is pended until I can find that quirk. Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
On Thu, 20 Dec 2007, William A. Rowe, Jr. wrote:
- IMHO the example file should not override the default DocumentRoot,
ErrorLog etc. As most other things in the file, it should be
commented out by default.
We have a specialized ftproot so we don't make assumptions for the user,
and the install creates that empty dir (alongside in parallel to docroot)
although we could add an ftproot/SUCCESS file or something pretty easily
by adding that to docs/ftproot/ of the project.
Keep in mind all the fools who put their scripts and secret content in
the docroot, I don't know that docroot is really a valid default unless
they take 10 minutes to think about it, eh?
Ah, good point.
- ftp should be added as a valid Anonymous ftp access username (the
Anonymous directive).
e.g. user ftp pass blah? Ok, not so familiar with that semantic myself,
but feel free to commit.
It's pretty common. Not a biggie though.
However, starting the thing yields:
Invalid command 'Anonymous', perhaps misspelled or defined by a module not
included in the server configuration
Missing mod_authn_anon?
Indeed. Which means the the anonftp-stuff should be wrapped inside a
suiting IfModule clause...
Commenting out the whole Anonymous ftp access block makes the thing
start, accepting anonymous access.
So I didn't see this problem, but I'm using stock builds and fedora 8 to
check this out, so far running that tree authless (meaning it's whatever
user/pass they provide) and read only (just as you had).
Whatever user/pass suits us fine for readonly access, it's probably
even documented somewhere if I am competent in reading ;)
However, I found a slight bug that might be my configuration or
something worse: httpd won't serve http when I have mod_ftp with
accompanying config enabled. It reads the request and then closes the
connection, it doesn't even log anything in the error log despite
logging at debug level...
I'll probably wont get around to debugging this until next year, just
wanted to give you a heads up that there is something fishy going
on...
/Nikke
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED]
---
I'm McMahon of Borg. You may already have been assimilated.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
On Tue, 18 Dec 2007, William A. Rowe, Jr. wrote:
On the positive side, the thing builds on both Linux and AIX (out of tree,
for httpd 2.2.6). I'll await the 0.9.1 tag before doing more elaborate
tests though.
Trunk should also be stable now, if you want to take a crack at that
before the tag;
http://svn.apache.org/repos/asf/httpd/mod_ftp/trunk/
Looking at it now, I'm starting with configuring the thing as an
anonymous FTP server according to the installed extra/ftpd.conf.
And of course have a few notes on the shipped sample config:
- IMHO the example file should not override the default DocumentRoot,
ErrorLog etc. As most other things in the file, it should be
commented out by default.
- ftp should be added as a valid Anonymous ftp access username (the
Anonymous directive).
However, starting the thing yields:
Invalid command 'Anonymous', perhaps misspelled or defined by a module not
included in the server configuration
Commenting out the whole Anonymous ftp access block makes the thing
start, accepting anonymous access.
After that I seem to have basic working molecules, I have only tested
on Linux (ubuntu710-i386) so far.
I found an old patch I had made to fix the REST command (it didn't
grok large files) that seems to work, at least I managed to download
all 4571090944 bytes of revelations-2.iso with numerous interruptions
and still have the correct md5sum afterwards. I'll try to cuddle svn
into becoming my friend and commit it to trunk.
I'm still a little bit confused on the access control situation
though, so pointer to docco or clarification would be nice.
/Nikke
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED]
---
Does the Little Mermaid wear an algebra?
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Niklas Edmundsson wrote: On Tue, 18 Dec 2007, William A. Rowe, Jr. wrote: On the positive side, the thing builds on both Linux and AIX (out of tree, for httpd 2.2.6). I'll await the 0.9.1 tag before doing more elaborate tests though. Trunk should also be stable now, if you want to take a crack at that before the tag; http://svn.apache.org/repos/asf/httpd/mod_ftp/trunk/ Looking at it now, I'm starting with configuring the thing as an anonymous FTP server according to the installed extra/ftpd.conf. And of course have a few notes on the shipped sample config: - IMHO the example file should not override the default DocumentRoot, ErrorLog etc. As most other things in the file, it should be commented out by default. We have a specialized ftproot so we don't make assumptions for the user, and the install creates that empty dir (alongside in parallel to docroot) although we could add an ftproot/SUCCESS file or something pretty easily by adding that to docs/ftproot/ of the project. Keep in mind all the fools who put their scripts and secret content in the docroot, I don't know that docroot is really a valid default unless they take 10 minutes to think about it, eh? - ftp should be added as a valid Anonymous ftp access username (the Anonymous directive). e.g. user ftp pass blah? Ok, not so familiar with that semantic myself, but feel free to commit. However, starting the thing yields: Invalid command 'Anonymous', perhaps misspelled or defined by a module not included in the server configuration Missing mod_authn_anon? Commenting out the whole Anonymous ftp access block makes the thing start, accepting anonymous access. So I didn't see this problem, but I'm using stock builds and fedora 8 to check this out, so far running that tree authless (meaning it's whatever user/pass they provide) and read only (just as you had). But where you want both explicit and anon access, you'll need authn_anon. Maybe add a comment to the conf example? Sander Temme pioneered the auth example work and maybe can chime in here. I found an old patch I had made to fix the REST command (it didn't grok large files) that seems to work, at least I managed to download all 4571090944 bytes of revelations-2.iso with numerous interruptions and still have the correct md5sum afterwards. I'll try to cuddle svn into becoming my friend and commit it to trunk. That's fantastic - thank you for the commit!
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
I'm not good at English. If you can't catch what I say, please see the attached
patch.
This doesn't have to meet 0.9.1, but may affect performance.
modules/ftp/ftp_message.c line 53:
strncpy(outptr, time_str, outlen);
if (outlen APR_CTIME_LEN - 1) {
*(outptr + APR_CTIME_LEN - 1) = '\0';
}
When the condition is true, outptr has been NULL-terminated by strncpy.
I thought it should be outlen APR_CTIME_LEN...
But though outptr hasn't when the condition is false,
line 109:
outptr[outlen - 1] = '\0';
will NULL-terminate. So this if block is useless.
Moreover, strncpy fills '\0'. outlen is often BUFSIZ, which is very large
number.
apr_cpystrn is better.
Index: modules/ftp/ftp_message.c
===
--- modules/ftp/ftp_message.c (revision 605569)
+++ modules/ftp/ftp_message.c (working copy)
@@ -50,10 +50,7 @@
switch(*++inptr) {
case 'T':
apr_ctime(time_str, apr_time_now());
-strncpy(outptr, time_str, outlen);
-if (outlen APR_CTIME_LEN - 1) {
-*(outptr + APR_CTIME_LEN - 1) = '\0';
-}
+apr_cpystrn(outptr, time_str, outlen);
break;
case 'C':
apr_snprintf(outptr, outlen, %s, fc-cwd);
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Takashi Sato wrote: apr_cpystrn is better. Agreed. FYI - it's easier to follow if you change the subject and prefix that subject with [PATCH] when you offer these up :) Committed and thanks! Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
William A. Rowe, Jr. wrote: mod_ftp fans; At last, I came up with a trivial strategy for doing autoconf-like tests, using nothing except apxs httpd/build/ elements, so mod_ftp is really ready for feedback across any platform. Please fetch up the newly prepared httpd-mod_ftp-0.9.0.tar.[gz|bz2] (and its md5/asc sigs) from: http://httpd.apache.org/dev/dist/mod_ftp/ review, take it for a spin, and cast your choice As I mentioned, the perms of the installed httpd include directory were corrupted to 664 by the first candidate, so I've withdrawn it. Proceeding to tag the next crack at an alpha/beta 0.9.1 tomorrow, based on Guenter's changed to NW and mine to Win32, plus some more enhancements to the conf/extra/ftpd.conf paths. If anyone has any issues with a new alpha/beta tag, please speak before tomorrow eve. Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
On Tue, 18 Dec 2007, William A. Rowe, Jr. wrote:
Please fetch up the newly prepared httpd-mod_ftp-0.9.0.tar.[gz|bz2]
(and its md5/asc sigs) from:
http://httpd.apache.org/dev/dist/mod_ftp/
review, take it for a spin, and cast your choice
As I mentioned, the perms of the installed httpd include directory
were corrupted to 664 by the first candidate, so I've withdrawn it.
Proceeding to tag the next crack at an alpha/beta 0.9.1 tomorrow,
You might want to have a go at the configure.apxs before doing that.
It seems to contain some bashisms that shows up on debian/ubuntu
machines which uses dash as /bin/sh:
% ./configure.apxs
test: 8: ==: unexpected operator
test: 19: ==: unexpected operator
Configuring mod_ftp for APXS
...
The thing is that == is not a valid /bin/sh style test expression. It
should probably be just =, or test -z $var ...
On the positive side, the thing builds on both Linux and AIX (out of
tree, for httpd 2.2.6). I'll await the 0.9.1 tag before doing more
elaborate tests though.
/Nikke
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | [EMAIL PROTECTED]
---
I'm not crazy, I just don't give a s#!t
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Niklas Edmundsson wrote: You might want to have a go at the configure.apxs before doing that. It seems to contain some bashisms that shows up on debian/ubuntu machines which uses dash as /bin/sh: % ./configure.apxs test: 8: ==: unexpected operator test: 19: ==: unexpected operator Configuring mod_ftp for APXS Fixed, good catch. Thank you! The thing is that == is not a valid /bin/sh style test expression. It should probably be just =, or test -z $var ... Went with '=', I remember hitting -z portability issues before. On the positive side, the thing builds on both Linux and AIX (out of tree, for httpd 2.2.6). I'll await the 0.9.1 tag before doing more elaborate tests though. Trunk should also be stable now, if you want to take a crack at that before the tag; http://svn.apache.org/repos/asf/httpd/mod_ftp/trunk/ Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Hello. I just compiled mod_ftp trunk with httpd 2.2.7-dev on Fedora 8. gcc 4.1.2 with -Wmissing-declarations says: mod_ftp.c:831: warning: no previous prototype for 'ftp_epsv_ignore_family' No headers declare ftp_epsv_ignore_family, it is without AP_DECLARE and no sources except mod_ftp.c call or use it. It is not clear where it is a function intended to be called from. 1) the other sources of FTP module 2) the outside of FTP module 3) only mod_ftp.c
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Takashi Sato wrote: mod_ftp.c:831: warning: no previous prototype for 'ftp_epsv_ignore_family' No headers declare ftp_epsv_ignore_family, it is without AP_DECLARE and no sources except mod_ftp.c call or use it. It is not clear where it is a function intended to be called from. 3) only mod_ftp.c 3 - it's a cmd rec entry, made it static. Thanks for the report! Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Hi Bill, Please fetch up the newly prepared httpd-mod_ftp-0.9.0.tar.[gz|bz2] (and its md5/asc sigs) from: http://httpd.apache.org/dev/dist/mod_ftp/ review, take it for a spin, and cast your choice [ ] -1 for release of 0.9.0 [ ] +1 to release as 0.9.0-alpha [ ] +1 to release as 0.9.0-beta [ ] +1 to release as 0.9.0-beta, and ready to tag GA (1.0.0) See http://svn.apache.org/repos/asf/httpd/mod_ftp/tags/0.9.0/STATUS-FTP identifying several issues (I don't plan to vote for better than -beta just yet). Supporting -beta means +1 to -alpha instead if that's the majority opinion. For getting started, http://svn.apache.org/repos/asf/httpd/mod_ftp/tags/0.9.0/README-FTP describes the various ways you can use this package; note that there are no netware comments yet, so I decided to move ahead with a tarball, in the expectation that these comments would be added later. I'm sure working around the -DFTP_APXS_BUILD plus setting up an appropriate ftp_config.h for out of tree netware builds won't be that hard. For in-tree netware builds it should be a matter of adding the subdir; in-tree builds never use ftp_config.h (in tree builds rely on httpd ./configure to perform mod_ftp related autoconf tests, and load ap_config.h/ap_config_auto.h instead of ftp_config.h). the files from the tarball compile cleanly for NetWare without any change for both 2.0.x and 2.2.x; nothing more yet tested for the moment... Guen.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.0
Guenter Knauf wrote: the files from the tarball compile cleanly for NetWare without any change for both 2.0.x and 2.2.x; nothing more yet tested for the moment... That's in-tree, then, or using ./configure.apxs? The reason this couldn't work out-of-tree without defining FTP_APXS_BUILD is that we do those moronic gymnastics to get at mod_log_config.h (../../modules/ftp). The reason it couldn't work out-of-tree once that is defined is that you need a silly out-of-tree target which either 'echo /* no config needed */ ftp_config.h or if netware does support it, 'echo #define HAVE_FCHMOD ftp_config.h since we load that file when we see FTP_APXS_BUILD defined. I have to work on httpd 2.2.7/.0.62 mpm issues for the afternoon, but plan to roll 0.9.1 tomorrow. If you would like to add netware notes to README-FTP before then, please be my guest!!! If you want to only consider certain kinds of builds for now, and ignore others, then just note those in STATUS-FTP as something nice to resolve later. Bill
