Re: Absence of unsigned integer read/write support in IBinaryRawReader/Writer
Hi Dmitry, Thanks for the answer, I suspected this might be the case. I am curious that unsigned ints would not be a universally supported type on all platforms. Is that really the case? Thanks, Raymond. Sent from my iPhone > On 10/10/2018, at 10:22 AM, Dmitriy Setrakyan wrote: > > This is not about what "Java" supports. This is about the protocol working > seamlessly across Java, .NET, and C++ environments, so we had to remove the > types that are not supported on some platforms. > > D. > > On Tue, Oct 9, 2018 at 7:57 AM Ilya Kasnacheev > wrote: > >> Hello! >> >> I think this is because Ignite marshallers stick to what Java supports. >> Java only supports signed numbers and it only supports nullable composite >> values (no structs). >> >> Thus on the C# side you can use those types which intersect between Java >> and .Net runtimes. >> >> I can see how this can be inconvenient, unfortunately we don't have that >> strong C# lobby to make the difference currently. >> >> Regards, >> -- >> Ilya Kasnacheev >> >> >> вт, 9 окт. 2018 г. в 0:04, Raymond Wilson : >> >>> I’m using Ignite IBinarizable raw serialization in Ignite v2.6 with C# >>> client. >>> >>> >>> >>> I notice there is no support for unsigned short, int and long integer >> types >>> (both single values and arrays). >>> >>> >>> >>> I also noticed that Decimal, DateTime and Guid read/write methods only >>> support nullable values. >>> >>> >>> >>> Currently I have code that writes a ushort value into an into to preserve >>> its value range. Similarly I have non-nullable Guid values and need to do >>> the nullable dance to on the read side to transform them back to >>> non-nullable. >>> >>> >>> >>> Is there a particular reason these are not supported? >>> >>> >>> >>> Thanks, >>> >>> Raymond. >>> >>
Re: Absence of unsigned integer read/write support in IBinaryRawReader/Writer
This is not about what "Java" supports. This is about the protocol working seamlessly across Java, .NET, and C++ environments, so we had to remove the types that are not supported on some platforms. D. On Tue, Oct 9, 2018 at 7:57 AM Ilya Kasnacheev wrote: > Hello! > > I think this is because Ignite marshallers stick to what Java supports. > Java only supports signed numbers and it only supports nullable composite > values (no structs). > > Thus on the C# side you can use those types which intersect between Java > and .Net runtimes. > > I can see how this can be inconvenient, unfortunately we don't have that > strong C# lobby to make the difference currently. > > Regards, > -- > Ilya Kasnacheev > > > вт, 9 окт. 2018 г. в 0:04, Raymond Wilson : > > > I’m using Ignite IBinarizable raw serialization in Ignite v2.6 with C# > > client. > > > > > > > > I notice there is no support for unsigned short, int and long integer > types > > (both single values and arrays). > > > > > > > > I also noticed that Decimal, DateTime and Guid read/write methods only > > support nullable values. > > > > > > > > Currently I have code that writes a ushort value into an into to preserve > > its value range. Similarly I have non-nullable Guid values and need to do > > the nullable dance to on the read side to transform them back to > > non-nullable. > > > > > > > > Is there a particular reason these are not supported? > > > > > > > > Thanks, > > > > Raymond. > > >
[GitHub] dspavlov opened a new pull request #31: Ignite 9800 2 - Make navigation more easy, provide buttons only for runned build
dspavlov opened a new pull request #31: Ignite 9800 2 - Make navigation more easy, provide buttons only for runned build URL: https://github.com/apache/ignite-teamcity-bot/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: PHP thin client
Great work guys, thanks! I've noticed TC fails in the build plan "Licenses Headers" which Igor have fixed already by excluding Doxyfile from checking. I've filled a ticket [1] and I'd suggest fixing the test in another way by adding the license header to Doxyfile. Igor, please, have a look at prepared PR [2] (tests passed [3]). [1] https://issues.apache.org/jira/browse/IGNITE-9832 [2] https://github.com/apache/ignite/pull/4938/files [3] https://ci.ignite.apache.org/viewLog.html?buildId=2046206 On Tue, Oct 9, 2018 at 6:31 PM Igor Sapego wrote: > > As the seem to be everything OK with the code and tests and > no one had any comment for quite some time, I've merged the > PHP to Ignite's master. > > Great job, guys! > > > Best Regards, > Igor > > > On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg wrote: > > > Hi Stephan, Alexey > > > > That's exactly what readme.io contains - installation instructions, > > configuration, and examples for key-value, sql, etc. for thin clients. For > > example, see these documentation pages for Node.js (currently hidden in the > > latest version of the doc) : > > > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client > > > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security > > > > This how Python and PHP thin clients will also be documented on readme.io > > > > -Prachi > > > > > > > > > > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov < > > pilshchikov@gmail.com> wrote: > > > > > > You know, I'm confused with all this documentation stuff... > > > > For nodejs client all docs were moved from the repo to readme.io but > > > the > > > > readme.md keeps the installation instructions (duplicated with > > > > readme.io). Probably, that's ok. > > > > Will add similar short readme.md to the PHP PR. > > > > > > Its good > > > > > > What i think (and how it partially now): > > > All user documentation should be on readme.io (how to install, use it, > > > configurate, description for examples) > > > All developers documentation (how to release, how to start develop) > > and(!) > > > basic description should be in repository > > > > > > > > > > > > > > > -- > > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ > > > > > -- Best Regards, Vyacheslav D.
[GitHub] ignite pull request #4938: IGNITE-9832 MTCGA: AL header added to Doxyfile
GitHub user daradurvs opened a pull request: https://github.com/apache/ignite/pull/4938 IGNITE-9832 MTCGA: AL header added to Doxyfile You can merge this pull request into a Git repository by running: $ git pull https://github.com/daradurvs/ignite ignite-9832 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4938.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4938 commit 5b7ad36140be91e3d5e447fbaf6758090829304b Author: Vyacheslav Daradur Date: 2018-10-09T19:51:10Z AL header added ---
[jira] [Created] (IGNITE-9832) MTCGA: Licenses Headers failed
Vyacheslav Daradur created IGNITE-9832: -- Summary: MTCGA: Licenses Headers failed Key: IGNITE-9832 URL: https://issues.apache.org/jira/browse/IGNITE-9832 Project: Ignite Issue Type: Bug Affects Versions: 2.6 Reporter: Vyacheslav Daradur Assignee: Vyacheslav Daradur Fix For: 2.8 Attachments: rat.zip TeamCity's build plan "Licenses Headers" failed with errors. (report|^rat.zip) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: TDE. Phase-1 Merged to master
Nikolay, The TDE development on vacation should not remain unnoticed. My congratulations! On Tue, 9 Oct 2018 at 19:39 Vyacheslav Daradur wrote: > Nikolay, awesome! Congrats! > > > > вт, 9 окт. 2018 г. в 19:18, Nikolay Izhikov : > > > Hello, Igniters. > > > > I merged to master TDE.Phase 1 that has been actively discussed on > > dev-list. > > > > I want to thank all guys that helped me with the implementation: > > > > 1. Dmitriy Ryabov - initial design. > > 2. Anton Vinogradov - an initial review. wisdom sharing. > > 3. Vladimir Ozerov - final review. priceless advices and knowledge of > > Ignite codebase and trends. > > 4. Dmitriy Pavlov - security and process help. > > 5. Petr Ivanov - Team City configuration. > > > > Guys, this improvement wouldn't be done without your help. > > Thank you! > > > -- > Best Regards, Vyacheslav D. > -- -- Maxim Muzafarov
Re: TDE. Phase-1 Merged to master
Congrats! Great effort by everyone involved. On Tue, Oct 9, 2018 at 9:18 AM Nikolay Izhikov wrote: > Hello, Igniters. > > I merged to master TDE.Phase 1 that has been actively discussed on > dev-list. > > I want to thank all guys that helped me with the implementation: > > 1. Dmitriy Ryabov - initial design. > 2. Anton Vinogradov - an initial review. wisdom sharing. > 3. Vladimir Ozerov - final review. priceless advices and knowledge of > Ignite codebase and trends. > 4. Dmitriy Pavlov - security and process help. > 5. Petr Ivanov - Team City configuration. > > Guys, this improvement wouldn't be done without your help. > Thank you! >
[GitHub] ignite pull request #4937: Ignite 9606 normalize refactoring
GitHub user pavel-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/4937 Ignite 9606 normalize refactoring You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9606-normalize-refactoring Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4937.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4937 commit 5d144b2f57933b96dc4ccb68be119f7c205bb6f7 Author: Pavel Kuznetsov Date: 2018-10-02T14:43:31Z ignite-9606: Added test that reproduces the bug. commit 0bf7d1c8265e681cdc5ea8b7d27c013844724be6 Author: Pavel Kuznetsov Date: 2018-10-03T13:02:42Z ignite-9606: fixed COLUMN_NAME metadata result. Earlier, if key was of SQL type (so not wrapped), corresponding property thought that it is not a key. This behaviour affected what COLUMN_NAME JDBC metadata would contain. commit d350c5f3ab45849f608b6bab2335d33a84f78078 Author: Pavel Kuznetsov Date: 2018-10-05T19:56:27Z ignite-9606: Workaround for validation. prop.name() used to return UPPERCASED name of the field. So comparison with keyFieldName/valueFieldName (which are not uppercased) was incorrect. Probably, this validation logic should be revisited. commit c81622e804fe9ecd6e25d697d46ca9e063e774d7 Author: Pavel Kuznetsov Date: 2018-10-09T15:22:16Z Revert "ignite-9606: Workaround for validation." This reverts commit d350c5f3ab45849f608b6bab2335d33a84f78078. commit 6a10c7fdf7ab8e4bba31399a93864bf931a08c70 Author: Pavel Kuznetsov Date: 2018-10-09T15:24:09Z ignite-9606-normalize-refactoring: uppercase all fields. Now all the fields are uppercased during normalization. ---
Re: TDE. Phase-1 Merged to master
Nikolay, awesome! Congrats! вт, 9 окт. 2018 г. в 19:18, Nikolay Izhikov : > Hello, Igniters. > > I merged to master TDE.Phase 1 that has been actively discussed on > dev-list. > > I want to thank all guys that helped me with the implementation: > > 1. Dmitriy Ryabov - initial design. > 2. Anton Vinogradov - an initial review. wisdom sharing. > 3. Vladimir Ozerov - final review. priceless advices and knowledge of > Ignite codebase and trends. > 4. Dmitriy Pavlov - security and process help. > 5. Petr Ivanov - Team City configuration. > > Guys, this improvement wouldn't be done without your help. > Thank you! > -- Best Regards, Vyacheslav D.
Re: Volunteer needed: AWS Elastic Load Balancer IP Findersimplemented
Hi Stanislav, I have removed extended the TcpDiscoveryApplicationElbIpFinder from TcpDiscoveryClassicElbIpFinder to limi the code duplication. Please share your feedback. Thanks, Uday On Wed, Oct 3, 2018 at 1:12 AM Dmitriy Pavlov wrote: > Hi Uday, > > We should keep classes name as is within all minor releases (2.x). We can > schedule rename only to 3.0. We need to keep both classes and methods > naming as is to provide compilation guarantee. If someone used existing > TcpDiscoveryElbIpFinder from 2.6 release than his or her code should > compile and run well. > > I've updated checklist, thank you for pointing to this. > > So I suggest keeping existing naming of TcpDiscoveryElbIpFinder as it is > part of API. > > Sincerely, > Dmitriy Pavlov > > вт, 2 окт. 2018 г. в 21:04, uday kale : > > > Thanks for the review Stan. > > I renamed the existing class TcpDiscoveryElbIpFinder since the name is > not > > clear regarding the actual load balancer being used. The names > > TcpDiscoveryClassicElbIpFinder > > and TcpDiscoveryApplicationElbIpFinder provide a clear distinction. > > I deprecated the existing class because of review checklist [1] point 1.a > > under checklist. It requires methods to be deprecated instead of being > > renamed. I assumed this will extend to classes too. > > Regarding the your suggestion for having the tests I agree. It will be > > helpful to know whether TC can accept properties while initiating a run. > > > > [1] https://cwiki.apache.org/confluence/display/IGNITE/Review+Checklist > > > > Uday > > > > On Tue, Oct 2, 2018 at 9:58 PM Stanislav Lukyanov < > stanlukya...@gmail.com> > > wrote: > > > > > Also, it makes me nervous that we’re lacking any sort of functional > tests > > > for AWS-based IP finders (same for GCE, actually). > > > I understand that it’s hard to include tests like that in regular TC > runs > > > because we’d have to include some sort of credentials. > > > But let’s think of some sort of a middle ground. > > > > > > I’m thinking about a functional test suite in the ignite-aws module > that > > > would pick up a properties file with AWS credentials. > > > It wouldn’t be included in any of the TC runs, but someone making > changes > > > to ignite-aws would be able to run it locally providing their own > > > credentials. > > > They’d then share the results of their testing together with the usual > TC > > > link. > > > > > > Stan > > > > > > From: Stanislav Lukyanov > > > Sent: 2 октября 2018 г. 19:08 > > > To: dev@ignite.apache.org > > > Subject: RE: Volunteer needed: AWS Elastic Load Balancer IP > > > Findersimplemented > > > > > > Hi, > > > > > > I took a look at the code, and I believe the patch needs to be > enhanced. > > > > > > The patch is about adding TcpDiscoveryApplicationElbIpFinder, but it > also > > > deprecates the existing TcpDiscoveryElbIpFinder > > > and replaces it with its copy named TcpDiscoveryClassicElbIpFinder. > > > > > > I’d really prefer if the existing class were enhanced to support both > > > classic ELB and Application ELB. > > > If it can’t be done, let’s use inheritance to reduce the copypaste. > > > In any case, let’s avoid deprecating the existing class – I don’t think > > > that changing the name is that important in this case. > > > > > > Thanks, > > > Stan > > > > > > From: Denis Magda > > > Sent: 26 сентября 2018 г. 18:52 > > > To: dev > > > Subject: Re: Volunteer needed: AWS Elastic Load Balancer IP > > > Findersimplemented > > > > > > Igniters, > > > > > > Don't we have experts in our networking component? I do believe that's > a > > > small improvement that can be verified and merged quickly. > > > > > > -- > > > Denis > > > > > > On Wed, Sep 26, 2018 at 8:50 AM Dmitriy Pavlov > > > wrote: > > > > > > > Igniters, Friendly reminder. > > > > > > > > Denis, could you advice how to proceed in this case? It seems feature > > can > > > > be useful, but committers are not involved in a review. > > > > > > > > Should we send a proposal with lazy consensus and automatically > merge? > > > Any > > > > alternative ideas on how to proceed with issues stuck in the review > > > process > > > > are strongly appreciated. > > > > > > > > Sincerely, > > > > Dmitriy Pavlov > > > > > > > > ср, 15 авг. 2018 г. в 19:38, Dmitriy Pavlov : > > > > > > > > > Hi Igniters, > > > > > > > > > > I took a look at the proposed contribution > > > > > https://issues.apache.org/jira/browse/IGNITE-8617 and PR > > > > > https://github.com/apache/ignite/pull/4076. > > > > > > > > > > I found this change reasonable and I can update code according to > > code > > > > > style. > > > > > > > > > > But I would ask someone from the community with experience with AWS > > ELB > > > > to > > > > > join the review. It would also benefit us if someone could try to > > run a > > > > > cluster with AWS ELB IP Finder. > > > > > > > > > > Sincerely, > > > > > Dmitriy Pavlov > > > > > > > > > > > > > > > > > > > > >
TDE. Phase-1 Merged to master
Hello, Igniters. I merged to master TDE.Phase 1 that has been actively discussed on dev-list. I want to thank all guys that helped me with the implementation: 1. Dmitriy Ryabov - initial design. 2. Anton Vinogradov - an initial review. wisdom sharing. 3. Vladimir Ozerov - final review. priceless advices and knowledge of Ignite codebase and trends. 4. Dmitriy Pavlov - security and process help. 5. Petr Ivanov - Team City configuration. Guys, this improvement wouldn't be done without your help. Thank you! signature.asc Description: This is a digitally signed message part
Re: Upsource lags and connection timeouts
I am glad to help. > On 9 Oct 2018, at 19:21, Dmitriy Pavlov wrote: > > Hi Petr, > > I can't stress this enough, but this modification had a really positive > impact to TC bot performance. > > Now it provides responses much faster. I hope it will help us to use this > tool and integrate into our processes. > > Thank you for your efforts. > > Sincerely, > Dmitriy Pavlov > > вт, 9 окт. 2018 г. в 18:00, Anton Vinogradov : > >> Thank you very much! >> >> вт, 9 окт. 2018 г. в 17:43, Petr Ivanov : >> >>> New dedicated disk subsystem is installed for MTCGA utility, hope that'll >>> help to free resources for other services. >>> >>> On 21 Sep 2018, at 21:10, Anton Vinogradov wrote: Folks, Thanks for the investigation! Could you please let us know once the problem will be solved? пт, 21 сент. 2018 г. в 19:28, Dmitriy Pavlov : > Hi Anton, Petr, > > I confirm that TC Bot writes a lot of stuff, so it may create problems >>> for > Cassandra storage. > > The latest version of Bot has optimization of data saving, and its >>> reduces > amount of data to be saved to disk. But still, disc separation is a >>> better > solution. > > Sincerely, > Dmitriy Pavlov > > пт, 21 сент. 2018 г. в 19:19, Petr Ivanov : > >> Anton, >> >> >> We shared this issue with Jetbrains and they found no current >> problems >>> in >> logs, except possible problems with database connection (Apache > Cassandra). >> Currently there are no errors in logs. >> >> Possible troublemakers though exist: >> - MTCGA utility “lives” on the same server, possible resource race >> condition, will try to separate services (at least on disk subsystem > level) >> - connection to GitHub is an issue too — sometimes fetch speed drops >> significantly, that will be investigated also >> >> >>> On 20 Sep 2018, at 22:18, Anton Vinogradov wrote: >>> >>> Still, see the same issues. >>> >>> Denis, >>> >>> Could you please prioritize the fix? >>> >>> вт, 18 сент. 2018 г. в 14:01, Anton Vinogradov : >>> Also, I see following on each resolve attempt. UpsourceRequestExceptionImpl: 108: Internal error: An error >> occurred during flushing data to database вт, 18 сент. 2018 г. в 13:56, Anton Vinogradov : > Folks, > > Who is responsible for Upsouce [1]? > I see a performance issues last week. > Can we check Upsource health? > > [1] https://reviews.ignite.apache.org > >> >> > >>> >>> >>
Re: Upsource lags and connection timeouts
Hi Petr, I can't stress this enough, but this modification had a really positive impact to TC bot performance. Now it provides responses much faster. I hope it will help us to use this tool and integrate into our processes. Thank you for your efforts. Sincerely, Dmitriy Pavlov вт, 9 окт. 2018 г. в 18:00, Anton Vinogradov : > Thank you very much! > > вт, 9 окт. 2018 г. в 17:43, Petr Ivanov : > > > New dedicated disk subsystem is installed for MTCGA utility, hope that'll > > help to free resources for other services. > > > > > > > On 21 Sep 2018, at 21:10, Anton Vinogradov wrote: > > > > > > Folks, > > > > > > Thanks for the investigation! > > > Could you please let us know once the problem will be solved? > > > > > > пт, 21 сент. 2018 г. в 19:28, Dmitriy Pavlov : > > > > > >> Hi Anton, Petr, > > >> > > >> I confirm that TC Bot writes a lot of stuff, so it may create problems > > for > > >> Cassandra storage. > > >> > > >> The latest version of Bot has optimization of data saving, and its > > reduces > > >> amount of data to be saved to disk. But still, disc separation is a > > better > > >> solution. > > >> > > >> Sincerely, > > >> Dmitriy Pavlov > > >> > > >> пт, 21 сент. 2018 г. в 19:19, Petr Ivanov : > > >> > > >>> Anton, > > >>> > > >>> > > >>> We shared this issue with Jetbrains and they found no current > problems > > in > > >>> logs, except possible problems with database connection (Apache > > >> Cassandra). > > >>> Currently there are no errors in logs. > > >>> > > >>> Possible troublemakers though exist: > > >>> - MTCGA utility “lives” on the same server, possible resource race > > >>> condition, will try to separate services (at least on disk subsystem > > >> level) > > >>> - connection to GitHub is an issue too — sometimes fetch speed drops > > >>> significantly, that will be investigated also > > >>> > > >>> > > On 20 Sep 2018, at 22:18, Anton Vinogradov wrote: > > > > Still, see the same issues. > > > > Denis, > > > > Could you please prioritize the fix? > > > > вт, 18 сент. 2018 г. в 14:01, Anton Vinogradov : > > > > > Also, I see following on each resolve attempt. > > > UpsourceRequestExceptionImpl: 108: Internal error: An error > occurred > > > during flushing data to database > > > > > > > > > > > > вт, 18 сент. 2018 г. в 13:56, Anton Vinogradov : > > > > > >> Folks, > > >> > > >> Who is responsible for Upsouce [1]? > > >> I see a performance issues last week. > > >> Can we check Upsource health? > > >> > > >> [1] https://reviews.ignite.apache.org > > >> > > > > > >>> > > >>> > > >> > > > > >
Re: Apache Ignite 2.7 release
+1 from me.
В Вт, 09/10/2018 в 19:16 +0300, Alexey Goncharuk пишет:
> Igniters, Nikolay,
>
> I've recently discovered an issue [1] which was causing test suite to quit
> on TC. The root cause of the issue was an incorrect handling of WAL
> archiver stop, which causes a failure propagated to the failure processor
> and lead to a JVM halt on each node stop. This is a regression compared
> from 2.6.
> I think it is worth including this fix to 2.7 given that the fix is ready
> and verified on TC.
>
> Please let me know if you have any objections.
>
> вт, 9 окт. 2018 г. в 19:00, Andrey Kuznetsov :
>
> > Igniters,
> >
> > Recently, I have filed an issue [1] that deals with possible hanging of WAL
> > logging. I will appreciate your thoughts on its severity. To make logging
> > hang two conditions should be satisfied: WAL mode is {{FSYNC}}, and WAL
> > archiving is disabled. Should we investigate and fix this immediately or is
> > it possible to postpone till 2.8?
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-9776
> >
> > вт, 9 окт. 2018 г. в 11:17, Andrey Kuznetsov :
> >
> > > Ignite committers,
> > >
> > > I have prepared a PR for 2.7 blocker [1]. Could anybody merge it to 2.7
> > > and master?
> > >
> > > [1] https://issues.apache.org/jira/browse/IGNITE-9737
> > >
> > >
> > > ср, 3 окт. 2018 г. в 14:02, Nikolay Izhikov :
> > >
> > > > Alexey.
> > > >
> > > > Sorry, I lost link to IGNITE-9760 in this thread :)
> > > >
> > > > Thanks, for a clarification.
> > > >
> > > >
> > > > В Ср, 03/10/2018 в 13:58 +0300, Alexey Goncharuk пишет:
> > > > > Nikolay, both commits fixed a regression compared to ignite-2.6. First
> > > >
> > > > one was mentioned by Anton Kalashnikov before (java-level deadlock
> >
> > during
> > > > WAL flush), another - by Andrey Kuznetsov (NPE during a concurrent WAL
> > > > flush).
> > > > >
> > > > > --AG
> > > > >
> > > > > ср, 3 окт. 2018 г. в 13:38, Nikolay Izhikov :
> > > > > > Hello, Igniters.
> > > > > >
> > > > > > Release scope is frozen.
> > > > > > Please, if you include some new issues in release - discuss it in
> > > >
> > > > this thread.
> > > > > >
> > > > > > Alexey, can you, please, comment on including fix for IGNITE-9760,
> > > >
> > > > IGNITE-9761 in 2.7 branch.
> > > > > >
> > > > > >
> >
> > https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=3355201f3e8cafd23b2250aaf3b91b8b8ed1
> > > > > >
> >
> > https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=9d6e6ff394c05ddf7ef31a9d9ed1b492d9eeba69
> > > > > >
> > > > > > В Ср, 03/10/2018 в 13:24 +0300, Vladimir Ozerov пишет:
> > > > > > > Nobody vetos anything, let's stop use this term unless some really
> > > > > > > important problem is discussed.
> > > > > > >
> > > > > > > At this point we are in situation when new tickets are still
> > > >
> > > > included into
> > > > > > > the scope. All want to ask is to stop including new tickets
> >
> > without
> > > > > > > explaining on why they should be in AI 2.7. Regression between is
> > > >
> > > > AI 2.6
> > > > > > > and AI 2.7 is enough. But "I found new NPE" is not.
> > > > > > >
> > > > > > > On Wed, Oct 3, 2018 at 11:10 AM Dmitriy Pavlov <
> > > >
> > > > dpavlov@gmail.com>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Nikolay,
> > > > > > > >
> > > > > > > > this has nothing about scaring someone. Let me explain about
> > > >
> > > > Apache Way.
> > > > > > > >
> > > > > > > > Voting -1 to release does not mean blocking it, release can't be
> > > >
> > > > vetoed.
> > > > > > > > Approving release is done by policy: majority approval. 3+1
> > > >
> > > > binding and
> > > > > > > > more +1 than -1. Consensus approval is better but not mandatory.
> > > > > > > >
> > > > > > > > Instead, if PMC says -1 to code modification it means veto and
> > > >
> > > > can't be
> > > > > > > > bypassed to anyone. This is a very strong statement, which
> >
> > should
> > > > be
> > > > > > > > applied reasonably and with technical justification. Lack of
> > > > > > > > understanding is not a justification.
> > > > > > > >
> > > > > > > > So my point instead of vetoing bugfix let's veto commits where
> > > >
> > > > the bugs
> > > > > > > > were introduced. I feel a number of bugs reported recently are
> >
> > all
> > > > > > > > connected to WalManager, and these bugs may come from just a
> > > >
> > > > couple of
> > > > > > > > fixes. PDS tests were quite stable last time, so I think it is
> > > >
> > > > possible to
> > > > > > > > find out why WAL crashes and hangs.
> > > > > > > >
> > > > > > > > Sincerely,
> > > > > > > > Dmitriy Pavlov
> > > > > > > >
> > > > > > > > ср, 3 окт. 2018 г. в 10:05, Andrey Kuznetsov > >
> > > :
> > > > > > > >
> > > > > > > > > Vladimir, Nikolay,
> > > > > > > > >
> > > > > > > > > For sure, I'm not an experienced Ignite contributor, so I'm
> > > >
> > > > sorry for
> > > > > > > > > intervening. I've just run the reproducer from [1] against
>
Re: Apache Ignite 2.7 release
Igniters, Nikolay,
I've recently discovered an issue [1] which was causing test suite to quit
on TC. The root cause of the issue was an incorrect handling of WAL
archiver stop, which causes a failure propagated to the failure processor
and lead to a JVM halt on each node stop. This is a regression compared
from 2.6.
I think it is worth including this fix to 2.7 given that the fix is ready
and verified on TC.
Please let me know if you have any objections.
вт, 9 окт. 2018 г. в 19:00, Andrey Kuznetsov :
> Igniters,
>
> Recently, I have filed an issue [1] that deals with possible hanging of WAL
> logging. I will appreciate your thoughts on its severity. To make logging
> hang two conditions should be satisfied: WAL mode is {{FSYNC}}, and WAL
> archiving is disabled. Should we investigate and fix this immediately or is
> it possible to postpone till 2.8?
>
> [1] https://issues.apache.org/jira/browse/IGNITE-9776
>
> вт, 9 окт. 2018 г. в 11:17, Andrey Kuznetsov :
>
> > Ignite committers,
> >
> > I have prepared a PR for 2.7 blocker [1]. Could anybody merge it to 2.7
> > and master?
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-9737
> >
> >
> > ср, 3 окт. 2018 г. в 14:02, Nikolay Izhikov :
> >
> >> Alexey.
> >>
> >> Sorry, I lost link to IGNITE-9760 in this thread :)
> >>
> >> Thanks, for a clarification.
> >>
> >>
> >> В Ср, 03/10/2018 в 13:58 +0300, Alexey Goncharuk пишет:
> >> > Nikolay, both commits fixed a regression compared to ignite-2.6. First
> >> one was mentioned by Anton Kalashnikov before (java-level deadlock
> during
> >> WAL flush), another - by Andrey Kuznetsov (NPE during a concurrent WAL
> >> flush).
> >> >
> >> > --AG
> >> >
> >> > ср, 3 окт. 2018 г. в 13:38, Nikolay Izhikov :
> >> > > Hello, Igniters.
> >> > >
> >> > > Release scope is frozen.
> >> > > Please, if you include some new issues in release - discuss it in
> >> this thread.
> >> > >
> >> > > Alexey, can you, please, comment on including fix for IGNITE-9760,
> >> IGNITE-9761 in 2.7 branch.
> >> > >
> >> > >
> >>
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=3355201f3e8cafd23b2250aaf3b91b8b8ed1
> >> > >
> >>
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=9d6e6ff394c05ddf7ef31a9d9ed1b492d9eeba69
> >> > >
> >> > > В Ср, 03/10/2018 в 13:24 +0300, Vladimir Ozerov пишет:
> >> > > > Nobody vetos anything, let's stop use this term unless some really
> >> > > > important problem is discussed.
> >> > > >
> >> > > > At this point we are in situation when new tickets are still
> >> included into
> >> > > > the scope. All want to ask is to stop including new tickets
> without
> >> > > > explaining on why they should be in AI 2.7. Regression between is
> >> AI 2.6
> >> > > > and AI 2.7 is enough. But "I found new NPE" is not.
> >> > > >
> >> > > > On Wed, Oct 3, 2018 at 11:10 AM Dmitriy Pavlov <
> >> dpavlov@gmail.com>
> >> > > > wrote:
> >> > > >
> >> > > > > Nikolay,
> >> > > > >
> >> > > > > this has nothing about scaring someone. Let me explain about
> >> Apache Way.
> >> > > > >
> >> > > > > Voting -1 to release does not mean blocking it, release can't be
> >> vetoed.
> >> > > > > Approving release is done by policy: majority approval. 3+1
> >> binding and
> >> > > > > more +1 than -1. Consensus approval is better but not mandatory.
> >> > > > >
> >> > > > > Instead, if PMC says -1 to code modification it means veto and
> >> can't be
> >> > > > > bypassed to anyone. This is a very strong statement, which
> should
> >> be
> >> > > > > applied reasonably and with technical justification. Lack of
> >> > > > > understanding is not a justification.
> >> > > > >
> >> > > > > So my point instead of vetoing bugfix let's veto commits where
> >> the bugs
> >> > > > > were introduced. I feel a number of bugs reported recently are
> all
> >> > > > > connected to WalManager, and these bugs may come from just a
> >> couple of
> >> > > > > fixes. PDS tests were quite stable last time, so I think it is
> >> possible to
> >> > > > > find out why WAL crashes and hangs.
> >> > > > >
> >> > > > > Sincerely,
> >> > > > > Dmitriy Pavlov
> >> > > > >
> >> > > > > ср, 3 окт. 2018 г. в 10:05, Andrey Kuznetsov >:
> >> > > > >
> >> > > > > > Vladimir, Nikolay,
> >> > > > > >
> >> > > > > > For sure, I'm not an experienced Ignite contributor, so I'm
> >> sorry for
> >> > > > > > intervening. I've just run the reproducer from [1] against
> >> ignite-2.6
> >> > > > > > branch and it has passed. So, it's not an legacy bug, we've
> >> brought it
> >> > > > >
> >> > > > > with
> >> > > > > > some change of 2.7 scope. Is it still ok to ignore the bug?
> >> > > > > >
> >> > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9776
> >> > > > > >
> >> > > > > > ср, 3 окт. 2018 г. в 2:07, Nikolay Izhikov <
> nizhi...@apache.org
> >> >:
> >> > > > > >
> >> > > > > > > Hello, Dmitriy.
> >> > > > > > >
> >> > > > > > > I'm sorry, but I don't understand your concern.
> >> > > > > > >
> >> > > > > > > Vladimir just
[GitHub] ignite pull request #4929: IGNITE-9821 rebuildIndexesFromHash should not thr...
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4929 ---
[GitHub] ignite pull request #4930: IGNITE-9822 Fix WAL archiver stop logic
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4930 ---
[GitHub] ignite pull request #4936: IGNITE-9756
GitHub user xtern opened a pull request: https://github.com/apache/ignite/pull/4936 IGNITE-9756 You can merge this pull request into a Git repository by running: $ git pull https://github.com/xtern/ignite IGNITE-9756 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4936.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4936 commit bcdf1dc039a985f4ceeb39338be7eb0718c2a6a4 Author: pereslegin-pa Date: 2018-10-09T15:25:53Z IGNITE-9756 Problematic deduplication in eviction manager (wip). ---
Re: Apache Ignite 2.7 release
Igniters,
Recently, I have filed an issue [1] that deals with possible hanging of WAL
logging. I will appreciate your thoughts on its severity. To make logging
hang two conditions should be satisfied: WAL mode is {{FSYNC}}, and WAL
archiving is disabled. Should we investigate and fix this immediately or is
it possible to postpone till 2.8?
[1] https://issues.apache.org/jira/browse/IGNITE-9776
вт, 9 окт. 2018 г. в 11:17, Andrey Kuznetsov :
> Ignite committers,
>
> I have prepared a PR for 2.7 blocker [1]. Could anybody merge it to 2.7
> and master?
>
> [1] https://issues.apache.org/jira/browse/IGNITE-9737
>
>
> ср, 3 окт. 2018 г. в 14:02, Nikolay Izhikov :
>
>> Alexey.
>>
>> Sorry, I lost link to IGNITE-9760 in this thread :)
>>
>> Thanks, for a clarification.
>>
>>
>> В Ср, 03/10/2018 в 13:58 +0300, Alexey Goncharuk пишет:
>> > Nikolay, both commits fixed a regression compared to ignite-2.6. First
>> one was mentioned by Anton Kalashnikov before (java-level deadlock during
>> WAL flush), another - by Andrey Kuznetsov (NPE during a concurrent WAL
>> flush).
>> >
>> > --AG
>> >
>> > ср, 3 окт. 2018 г. в 13:38, Nikolay Izhikov :
>> > > Hello, Igniters.
>> > >
>> > > Release scope is frozen.
>> > > Please, if you include some new issues in release - discuss it in
>> this thread.
>> > >
>> > > Alexey, can you, please, comment on including fix for IGNITE-9760,
>> IGNITE-9761 in 2.7 branch.
>> > >
>> > >
>> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=3355201f3e8cafd23b2250aaf3b91b8b8ed1
>> > >
>> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=9d6e6ff394c05ddf7ef31a9d9ed1b492d9eeba69
>> > >
>> > > В Ср, 03/10/2018 в 13:24 +0300, Vladimir Ozerov пишет:
>> > > > Nobody vetos anything, let's stop use this term unless some really
>> > > > important problem is discussed.
>> > > >
>> > > > At this point we are in situation when new tickets are still
>> included into
>> > > > the scope. All want to ask is to stop including new tickets without
>> > > > explaining on why they should be in AI 2.7. Regression between is
>> AI 2.6
>> > > > and AI 2.7 is enough. But "I found new NPE" is not.
>> > > >
>> > > > On Wed, Oct 3, 2018 at 11:10 AM Dmitriy Pavlov <
>> dpavlov@gmail.com>
>> > > > wrote:
>> > > >
>> > > > > Nikolay,
>> > > > >
>> > > > > this has nothing about scaring someone. Let me explain about
>> Apache Way.
>> > > > >
>> > > > > Voting -1 to release does not mean blocking it, release can't be
>> vetoed.
>> > > > > Approving release is done by policy: majority approval. 3+1
>> binding and
>> > > > > more +1 than -1. Consensus approval is better but not mandatory.
>> > > > >
>> > > > > Instead, if PMC says -1 to code modification it means veto and
>> can't be
>> > > > > bypassed to anyone. This is a very strong statement, which should
>> be
>> > > > > applied reasonably and with technical justification. Lack of
>> > > > > understanding is not a justification.
>> > > > >
>> > > > > So my point instead of vetoing bugfix let's veto commits where
>> the bugs
>> > > > > were introduced. I feel a number of bugs reported recently are all
>> > > > > connected to WalManager, and these bugs may come from just a
>> couple of
>> > > > > fixes. PDS tests were quite stable last time, so I think it is
>> possible to
>> > > > > find out why WAL crashes and hangs.
>> > > > >
>> > > > > Sincerely,
>> > > > > Dmitriy Pavlov
>> > > > >
>> > > > > ср, 3 окт. 2018 г. в 10:05, Andrey Kuznetsov :
>> > > > >
>> > > > > > Vladimir, Nikolay,
>> > > > > >
>> > > > > > For sure, I'm not an experienced Ignite contributor, so I'm
>> sorry for
>> > > > > > intervening. I've just run the reproducer from [1] against
>> ignite-2.6
>> > > > > > branch and it has passed. So, it's not an legacy bug, we've
>> brought it
>> > > > >
>> > > > > with
>> > > > > > some change of 2.7 scope. Is it still ok to ignore the bug?
>> > > > > >
>> > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9776
>> > > > > >
>> > > > > > ср, 3 окт. 2018 г. в 2:07, Nikolay Izhikov > >:
>> > > > > >
>> > > > > > > Hello, Dmitriy.
>> > > > > > >
>> > > > > > > I'm sorry, but I don't understand your concern.
>> > > > > > >
>> > > > > > > Vladimir just asks experienced Ignite contributor to *explain
>> impact*
>> > > > >
>> > > > > of
>> > > > > > a
>> > > > > > > bug.
>> > > > > > >
>> > > > > > > Why are you scaring us with your "-1"?
>> > > > > > > Is it Apache Way to do so?
>> > > > > > > What should be done for you to return to a constructive
>> discussion?
>> > > > > > >
>> > > > > > > В Ср, 03/10/2018 в 00:23 +0300, Dmitriy Pavlov пишет:
>> > > > > > > > Hi Igniters, Vladimir,
>> > > > > > > >
>> > > > > > > > NPEs or hangs in WAL is a completely non-functional grid (if
>> > > > > >
>> > > > > > persistence
>> > > > > > > > enabled).
>> > > > > > > >
>> > > > > > > > I see no reasons to release 2.7 with such symptoms until
>> we're sure
>> > > > >
>> > > > > it
>> > > > > > is
>> > > > > > > > too rare/impossible to
Re: PHP thin client
As the seem to be everything OK with the code and tests and no one had any comment for quite some time, I've merged the PHP to Ignite's master. Great job, guys! Best Regards, Igor On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg wrote: > Hi Stephan, Alexey > > That's exactly what readme.io contains - installation instructions, > configuration, and examples for key-value, sql, etc. for thin clients. For > example, see these documentation pages for Node.js (currently hidden in the > latest version of the doc) : > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client > > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-initialization-and-configuration > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-key-value > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-sql > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-binary-types > https://apacheignite.readme.io/v2.6/docs/nodejs-thin-client-security > > This how Python and PHP thin clients will also be documented on readme.io > > -Prachi > > > > > On Tue, Sep 18, 2018 at 3:26 AM, Stepan Pilshchikov < > pilshchikov@gmail.com> wrote: > > > > You know, I'm confused with all this documentation stuff... > > > For nodejs client all docs were moved from the repo to readme.io but > > the > > > readme.md keeps the installation instructions (duplicated with > > > readme.io). Probably, that's ok. > > > Will add similar short readme.md to the PHP PR. > > > > Its good > > > > What i think (and how it partially now): > > All user documentation should be on readme.io (how to install, use it, > > configurate, description for examples) > > All developers documentation (how to release, how to start develop) > and(!) > > basic description should be in repository > > > > > > > > > > -- > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ > > >
[GitHub] ignite pull request #4935: Ignite 6677
GitHub user SGrimstad opened a pull request: https://github.com/apache/ignite/pull/4935 Ignite 6677 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6677 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4935.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4935 commit 4a832136c752fbf980b5f9a8fdc049b2c17e8fe7 Author: ezhuravl Date: 2018-09-21T08:44:11Z wip commit 1f82d59126f96d62ae02794e6cb658c114c2bf21 Author: SGrimstad Date: 2018-09-28T12:30:03Z Merge branch 'master' into ignite-6677 commit 4386ea363b1735ec4cf177b6b610a7cb39e613f3 Author: SGrimstad Date: 2018-10-09T15:10:55Z IGNITE-6677 implementation commit e8a9d57bdd5fcd90e7345b8c72d92c31e1e1e2b2 Author: SGrimstad Date: 2018-10-09T15:26:26Z Merge branch 'master' into ignite-6677 ---
Re: Apache Ignite 2.7 release
Igniters, I reviewed Spring Session integration [1] and propose to move it to the next release. The reason is that current implementation has a number of performance issues, had potential bugs which are yet to be covered with tests, and possible lacks some features which other vendors like Hazelcast or GemFire have. I left respective comments in the ticket. As our goal is to have competitive implementation, it is better to exclude it out of AI 2.7 scope to have enough time. Vladimir. [1] https://issues.apache.org/jira/browse/IGNITE-9676 On Tue, Oct 9, 2018 at 11:17 AM Andrey Kuznetsov wrote: > Ignite committers, > > I have prepared a PR for 2.7 blocker [1]. Could anybody merge it to 2.7 and > master? > > [1] https://issues.apache.org/jira/browse/IGNITE-9737 > > > ср, 3 окт. 2018 г. в 14:02, Nikolay Izhikov : > > > Alexey. > > > > Sorry, I lost link to IGNITE-9760 in this thread :) > > > > Thanks, for a clarification. > > > > > > В Ср, 03/10/2018 в 13:58 +0300, Alexey Goncharuk пишет: > > > Nikolay, both commits fixed a regression compared to ignite-2.6. First > > one was mentioned by Anton Kalashnikov before (java-level deadlock during > > WAL flush), another - by Andrey Kuznetsov (NPE during a concurrent WAL > > flush). > > > > > > --AG > > > > > > ср, 3 окт. 2018 г. в 13:38, Nikolay Izhikov : > > > > Hello, Igniters. > > > > > > > > Release scope is frozen. > > > > Please, if you include some new issues in release - discuss it in > this > > thread. > > > > > > > > Alexey, can you, please, comment on including fix for IGNITE-9760, > > IGNITE-9761 in 2.7 branch. > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=3355201f3e8cafd23b2250aaf3b91b8b8ed1 > > > > > > > https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=9d6e6ff394c05ddf7ef31a9d9ed1b492d9eeba69 > > > > > > > > В Ср, 03/10/2018 в 13:24 +0300, Vladimir Ozerov пишет: > > > > > Nobody vetos anything, let's stop use this term unless some really > > > > > important problem is discussed. > > > > > > > > > > At this point we are in situation when new tickets are still > > included into > > > > > the scope. All want to ask is to stop including new tickets without > > > > > explaining on why they should be in AI 2.7. Regression between is > AI > > 2.6 > > > > > and AI 2.7 is enough. But "I found new NPE" is not. > > > > > > > > > > On Wed, Oct 3, 2018 at 11:10 AM Dmitriy Pavlov < > > dpavlov@gmail.com> > > > > > wrote: > > > > > > > > > > > Nikolay, > > > > > > > > > > > > this has nothing about scaring someone. Let me explain about > > Apache Way. > > > > > > > > > > > > Voting -1 to release does not mean blocking it, release can't be > > vetoed. > > > > > > Approving release is done by policy: majority approval. 3+1 > > binding and > > > > > > more +1 than -1. Consensus approval is better but not mandatory. > > > > > > > > > > > > Instead, if PMC says -1 to code modification it means veto and > > can't be > > > > > > bypassed to anyone. This is a very strong statement, which should > > be > > > > > > applied reasonably and with technical justification. Lack of > > > > > > understanding is not a justification. > > > > > > > > > > > > So my point instead of vetoing bugfix let's veto commits where > the > > bugs > > > > > > were introduced. I feel a number of bugs reported recently are > all > > > > > > connected to WalManager, and these bugs may come from just a > > couple of > > > > > > fixes. PDS tests were quite stable last time, so I think it is > > possible to > > > > > > find out why WAL crashes and hangs. > > > > > > > > > > > > Sincerely, > > > > > > Dmitriy Pavlov > > > > > > > > > > > > ср, 3 окт. 2018 г. в 10:05, Andrey Kuznetsov >: > > > > > > > > > > > > > Vladimir, Nikolay, > > > > > > > > > > > > > > For sure, I'm not an experienced Ignite contributor, so I'm > > sorry for > > > > > > > intervening. I've just run the reproducer from [1] against > > ignite-2.6 > > > > > > > branch and it has passed. So, it's not an legacy bug, we've > > brought it > > > > > > > > > > > > with > > > > > > > some change of 2.7 scope. Is it still ok to ignore the bug? > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9776 > > > > > > > > > > > > > > ср, 3 окт. 2018 г. в 2:07, Nikolay Izhikov < > nizhi...@apache.org > > >: > > > > > > > > > > > > > > > Hello, Dmitriy. > > > > > > > > > > > > > > > > I'm sorry, but I don't understand your concern. > > > > > > > > > > > > > > > > Vladimir just asks experienced Ignite contributor to *explain > > impact* > > > > > > > > > > > > of > > > > > > > a > > > > > > > > bug. > > > > > > > > > > > > > > > > Why are you scaring us with your "-1"? > > > > > > > > Is it Apache Way to do so? > > > > > > > > What should be done for you to return to a constructive > > discussion? > > > > > > > > > > > > > > > > В Ср, 03/10/2018 в 00:23 +0300, Dmitriy Pavlov пишет: > > > > > > > > > Hi Igniters, Vladimir, > > > > > > > > > > > > > > > > > >
[GitHub] ignite pull request #4934: Ignite-9777
GitHub user ygerzhedovich opened a pull request: https://github.com/apache/ignite/pull/4934 Ignite-9777 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9777 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4934.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4934 commit ead1ebc782a563992d7ce02a7327ab59f328f3c1 Author: Yury Gerzhedovich Date: 2018-09-25T09:09:34Z ignite-8580: Print page read/write metrics splitted by type commit 5154940d4d62a9c30a9669b40f663869824b2922 Author: Yury Gerzhedovich Date: 2018-09-25T09:11:29Z Merge branch 'master' into ignite-8580 commit 49ca777b210be22cee57843858db76bba280262d Author: Yury Gerzhedovich Date: 2018-09-25T09:55:03Z ignite-8580: javadoc fix commit 0daa030f9dc9c532c317eb725d6a1bd31e997270 Author: Yury Gerzhedovich Date: 2018-09-25T11:36:02Z ignite-8580: fix NPE in tests commit 7da1db38c9d93c82c5fc74e54394218038e9585e Author: Yury Gerzhedovich Date: 2018-09-26T07:56:41Z Merge branch 'master' into ignite-8580 # Conflicts: # modules/core/src/main/java/org/apache/ignite/IgniteSystemProperties.java commit 9813ec1275cfdf952bc8dcb044fe5c26d98e9caa Author: Yury Gerzhedovich Date: 2018-09-28T10:46:16Z Merge branch 'master' into ignite-8580 # Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/GridKernalContext.java commit 0e4618a405cc1aef0e204136215d65ba3495bb6e Author: Yury Gerzhedovich Date: 2018-10-01T08:34:57Z Merge branch 'master' into ignite-8580 commit df552471d1292e70b9968375ad9440b6c97b7103 Author: Yury Gerzhedovich Date: 2018-10-01T10:33:20Z ignite-8580: expose fine grain and aggregated IO statistics through JMX. commit 041db4bdd98570aafd46a1308a77cf73f73b6ba9 Author: Yury Gerzhedovich Date: 2018-10-01T11:25:22Z ignite-8580: minor fix commit aa232a1d27a7b0a84ad8d2fca48bb792727a6fee Author: Yury Gerzhedovich Date: 2018-10-01T13:13:28Z ignite-8580: minor fix commit 3c78dba8cef56d8728e24108acbc3c0a32e67bee Author: Yury Gerzhedovich Date: 2018-10-01T13:14:34Z Merge branch 'master' into ignite-8580 commit ab0bf51bd758690a0d3c38ca8700cba75f90675c Author: Yury Gerzhedovich Date: 2018-10-05T08:19:44Z ignite-9777: add infrastructure to gather statistics by types ( index, cache, table, ...). Add gathering stat for indexes. commit 0c1a1ed76a2d69f9c8be459ebc689b86e5ed1885 Author: Yury Gerzhedovich Date: 2018-10-08T10:17:21Z ignite-9777: Add gathering stat for caches and cache groups. commit 346cff2be04197e9a15c679132dbd157d42e12d6 Author: Yury Gerzhedovich Date: 2018-10-08T10:19:12Z Merge branch 'master' into ignite-9777 # Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/processors/cache/IgniteCacheOffheapManagerImpl.java commit 595249ce54277e81c9bc2f768a2784cbc93a26cc Author: Yury Gerzhedovich Date: 2018-10-08T10:26:37Z ignite-9777: minors commit 69da4db2fc1f1f3bd6d60147c4ba62f7084076be Author: Yury Gerzhedovich Date: 2018-10-09T14:48:00Z ignite-9777: Performance optimizations + tests. commit 6b9d064fafef7e4a17837d34fa1daf84bec99ec8 Author: Yury Gerzhedovich Date: 2018-10-09T14:50:54Z Merge branch 'master' into ignite-9777 # Conflicts: # modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/database/H2TreeIndex.java commit 372faf69176940c01b1690fc1458f62bdfb48cc2 Author: Yury Gerzhedovich Date: 2018-10-09T14:57:02Z ignite-9777: minors ---
[jira] [Created] (IGNITE-9831) Document how to work with Java 11
Vladimir Ozerov created IGNITE-9831: --- Summary: Document how to work with Java 11 Key: IGNITE-9831 URL: https://issues.apache.org/jira/browse/IGNITE-9831 Project: Ignite Issue Type: Task Components: documentation Reporter: Vladimir Ozerov Fix For: 2.7 TBD -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Upsource lags and connection timeouts
Thank you very much! вт, 9 окт. 2018 г. в 17:43, Petr Ivanov : > New dedicated disk subsystem is installed for MTCGA utility, hope that'll > help to free resources for other services. > > > > On 21 Sep 2018, at 21:10, Anton Vinogradov wrote: > > > > Folks, > > > > Thanks for the investigation! > > Could you please let us know once the problem will be solved? > > > > пт, 21 сент. 2018 г. в 19:28, Dmitriy Pavlov : > > > >> Hi Anton, Petr, > >> > >> I confirm that TC Bot writes a lot of stuff, so it may create problems > for > >> Cassandra storage. > >> > >> The latest version of Bot has optimization of data saving, and its > reduces > >> amount of data to be saved to disk. But still, disc separation is a > better > >> solution. > >> > >> Sincerely, > >> Dmitriy Pavlov > >> > >> пт, 21 сент. 2018 г. в 19:19, Petr Ivanov : > >> > >>> Anton, > >>> > >>> > >>> We shared this issue with Jetbrains and they found no current problems > in > >>> logs, except possible problems with database connection (Apache > >> Cassandra). > >>> Currently there are no errors in logs. > >>> > >>> Possible troublemakers though exist: > >>> - MTCGA utility “lives” on the same server, possible resource race > >>> condition, will try to separate services (at least on disk subsystem > >> level) > >>> - connection to GitHub is an issue too — sometimes fetch speed drops > >>> significantly, that will be investigated also > >>> > >>> > On 20 Sep 2018, at 22:18, Anton Vinogradov wrote: > > Still, see the same issues. > > Denis, > > Could you please prioritize the fix? > > вт, 18 сент. 2018 г. в 14:01, Anton Vinogradov : > > > Also, I see following on each resolve attempt. > > UpsourceRequestExceptionImpl: 108: Internal error: An error occurred > > during flushing data to database > > > > > > > > вт, 18 сент. 2018 г. в 13:56, Anton Vinogradov : > > > >> Folks, > >> > >> Who is responsible for Upsouce [1]? > >> I see a performance issues last week. > >> Can we check Upsource health? > >> > >> [1] https://reviews.ignite.apache.org > >> > > > >>> > >>> > >> > >
Re: Absence of unsigned integer read/write support in IBinaryRawReader/Writer
Hello! I think this is because Ignite marshallers stick to what Java supports. Java only supports signed numbers and it only supports nullable composite values (no structs). Thus on the C# side you can use those types which intersect between Java and .Net runtimes. I can see how this can be inconvenient, unfortunately we don't have that strong C# lobby to make the difference currently. Regards, -- Ilya Kasnacheev вт, 9 окт. 2018 г. в 0:04, Raymond Wilson : > I’m using Ignite IBinarizable raw serialization in Ignite v2.6 with C# > client. > > > > I notice there is no support for unsigned short, int and long integer types > (both single values and arrays). > > > > I also noticed that Decimal, DateTime and Guid read/write methods only > support nullable values. > > > > Currently I have code that writes a ushort value into an into to preserve > its value range. Similarly I have non-nullable Guid values and need to do > the nullable dance to on the read side to transform them back to > non-nullable. > > > > Is there a particular reason these are not supported? > > > > Thanks, > > Raymond. >
[GitHub] ignite pull request #4649: IGNITE-7783 PHP Thin Client
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4649 ---
Re: Upsource lags and connection timeouts
New dedicated disk subsystem is installed for MTCGA utility, hope that'll help to free resources for other services. > On 21 Sep 2018, at 21:10, Anton Vinogradov wrote: > > Folks, > > Thanks for the investigation! > Could you please let us know once the problem will be solved? > > пт, 21 сент. 2018 г. в 19:28, Dmitriy Pavlov : > >> Hi Anton, Petr, >> >> I confirm that TC Bot writes a lot of stuff, so it may create problems for >> Cassandra storage. >> >> The latest version of Bot has optimization of data saving, and its reduces >> amount of data to be saved to disk. But still, disc separation is a better >> solution. >> >> Sincerely, >> Dmitriy Pavlov >> >> пт, 21 сент. 2018 г. в 19:19, Petr Ivanov : >> >>> Anton, >>> >>> >>> We shared this issue with Jetbrains and they found no current problems in >>> logs, except possible problems with database connection (Apache >> Cassandra). >>> Currently there are no errors in logs. >>> >>> Possible troublemakers though exist: >>> - MTCGA utility “lives” on the same server, possible resource race >>> condition, will try to separate services (at least on disk subsystem >> level) >>> - connection to GitHub is an issue too — sometimes fetch speed drops >>> significantly, that will be investigated also >>> >>> On 20 Sep 2018, at 22:18, Anton Vinogradov wrote: Still, see the same issues. Denis, Could you please prioritize the fix? вт, 18 сент. 2018 г. в 14:01, Anton Vinogradov : > Also, I see following on each resolve attempt. > UpsourceRequestExceptionImpl: 108: Internal error: An error occurred > during flushing data to database > > > > вт, 18 сент. 2018 г. в 13:56, Anton Vinogradov : > >> Folks, >> >> Who is responsible for Upsouce [1]? >> I see a performance issues last week. >> Can we check Upsource health? >> >> [1] https://reviews.ignite.apache.org >> > >>> >>> >>
[jira] [Created] (IGNITE-9830) o.a.i.i.b.BinaryReaderExImpl#getOrCreateSchema sometimes misses latest metadata version resulting in failed tx commit because of missed schema.
Alexei Scherbakov created IGNITE-9830: - Summary: o.a.i.i.b.BinaryReaderExImpl#getOrCreateSchema sometimes misses latest metadata version resulting in failed tx commit because of missed schema. Key: IGNITE-9830 URL: https://issues.apache.org/jira/browse/IGNITE-9830 Project: Ignite Issue Type: Improvement Reporter: Alexei Scherbakov Assignee: Alexei Scherbakov Fix For: 2.8 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zzzadruga opened a new pull request #30: IGNITE-9805 Animation v1
zzzadruga opened a new pull request #30: IGNITE-9805 Animation v1 URL: https://github.com/apache/ignite-teamcity-bot/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (IGNITE-9829) Add validation error distinction to TcpDiscoveryCheckFailedMessage
Alexey Platonov created IGNITE-9829: --- Summary: Add validation error distinction to TcpDiscoveryCheckFailedMessage Key: IGNITE-9829 URL: https://issues.apache.org/jira/browse/IGNITE-9829 Project: Ignite Issue Type: Improvement Components: messaging Reporter: Alexey Platonov Fix For: 3.0 There is no way to define validation error type during joining on client side after node validation on server side. TcpDiscoveryCheckFailedMessage just aggregates error messages to one string. For example: if there was auth error while joining then client receive TcpDiscoveryCheckFailedMessage instead of TcpDiscoveryAuthFailedMessage. This is due to server validation protocol supports just IgniteNodeValidationResult as string-wrapper without additional information about types of validation errors. Set of enum values representing validation errors may be good solution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-9827) Assertion error due historical rebalance
ARomantsov created IGNITE-9827: -- Summary: Assertion error due historical rebalance Key: IGNITE-9827 URL: https://issues.apache.org/jira/browse/IGNITE-9827 Project: Ignite Issue Type: Bug Components: persistence Affects Versions: 2.7 Reporter: ARomantsov Fix For: 2.8 I work with next situation 1) Start two nodes with '-DIGNITE_PDS_WAL_REBALANCE_THRESHOLD=0', 2) Preload 3) Stop node 2 4) Load 5) Corrupt all wal archive file in node 1 5) Start node 2 And found assertion in log coordinator - is it ok? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Python thin client
Hi, all Tried to compare new thin client performance and made similar benchmarks for each one And result not so good for python Ticket with results and bench code: https://issues.apache.org/jira/browse/IGNITE-9824 Py code src: https://gist.github.com/pilshchikov/8aff4e30d83f8bac20c5a4a9c3917abb Dmitry, please review results and bench code, maybe somthing wrong or it's expected numbers? -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
[jira] [Created] (IGNITE-9826) Ignite node with TcpDiscoveryS3IpFinder can hang while stopping
Roman Guseinov created IGNITE-9826:
--
Summary: Ignite node with TcpDiscoveryS3IpFinder can hang while
stopping
Key: IGNITE-9826
URL: https://issues.apache.org/jira/browse/IGNITE-9826
Project: Ignite
Issue Type: Bug
Components: aws
Affects Versions: 2.6
Reporter: Roman Guseinov
Assignee: Roman Guseinov
Attachments: S3IpFinderReproducer.java
Here is stack trace:
{code:java}
[15:46:11,081][SEVERE][tcp-disco-ip-finder-cleaner-#4%node1%][TcpDiscoverySpi]
Failed to clean IP finder up.
class org.apache.ignite.spi.IgniteSpiException: Failed to list objects in the
bucket: rguseinov-ipfinder
at
org.apache.ignite.spi.discovery.tcp.ipfinder.s3.TcpDiscoveryS3IpFinder.getRegisteredAddresses(TcpDiscoveryS3IpFinder.java:200)
at
org.apache.ignite.spi.discovery.tcp.ipfinder.s3.S3IpFinderReproducer$CustomS3IpFinder.getRegisteredAddresses(S3IpFinderReproducer.java:103)
at
org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi.registeredAddresses(TcpDiscoverySpi.java:1900)
at
org.apache.ignite.spi.discovery.tcp.ServerImpl$IpFinderCleaner.cleanIpFinder(ServerImpl.java:1998)
at
org.apache.ignite.spi.discovery.tcp.ServerImpl$IpFinderCleaner.body(ServerImpl.java:1973)
at org.apache.ignite.spi.IgniteSpiThread.run(IgniteSpiThread.java:62)
Caused by: com.amazonaws.SdkClientException: Failed to sanitize XML document
destined for handler class
com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser$ListBucketHandler
at
com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser.sanitizeXmlDocument(XmlResponsesSaxParser.java:214)
at
com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser.parseListBucketObjectsResponse(XmlResponsesSaxParser.java:298)
at
com.amazonaws.services.s3.model.transform.Unmarshallers$ListObjectsUnmarshaller.unmarshall(Unmarshallers.java:70)
at
com.amazonaws.services.s3.model.transform.Unmarshallers$ListObjectsUnmarshaller.unmarshall(Unmarshallers.java:59)
at
com.amazonaws.services.s3.internal.S3XmlResponseHandler.handle(S3XmlResponseHandler.java:62)
at
com.amazonaws.services.s3.internal.S3XmlResponseHandler.handle(S3XmlResponseHandler.java:31)
at
com.amazonaws.http.response.AwsResponseHandlerAdapter.handle(AwsResponseHandlerAdapter.java:70)
at
com.amazonaws.http.AmazonHttpClient$RequestExecutor.handleResponse(AmazonHttpClient.java:1501)
at
com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeOneRequest(AmazonHttpClient.java:1222)
at
com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeHelper(AmazonHttpClient.java:1035)
at
com.amazonaws.http.AmazonHttpClient$RequestExecutor.doExecute(AmazonHttpClient.java:747)
at
com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeWithTimer(AmazonHttpClient.java:721)
at
com.amazonaws.http.AmazonHttpClient$RequestExecutor.execute(AmazonHttpClient.java:704)
at
com.amazonaws.http.AmazonHttpClient$RequestExecutor.access$500(AmazonHttpClient.java:672)
at
com.amazonaws.http.AmazonHttpClient$RequestExecutionBuilderImpl.execute(AmazonHttpClient.java:654)
at
com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:518)
at
com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4137)
at
com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4079)
at
com.amazonaws.services.s3.AmazonS3Client.listObjects(AmazonS3Client.java:819)
at
com.amazonaws.services.s3.AmazonS3Client.listObjects(AmazonS3Client.java:791)
at
org.apache.ignite.spi.discovery.tcp.ipfinder.s3.TcpDiscoveryS3IpFinder.getRegisteredAddresses(TcpDiscoveryS3IpFinder.java:148)
... 5 more
Caused by: com.amazonaws.AbortedException:
at
com.amazonaws.internal.SdkFilterInputStream.abortIfNeeded(SdkFilterInputStream.java:51)
at
com.amazonaws.internal.SdkFilterInputStream.read(SdkFilterInputStream.java:71)
at
com.amazonaws.event.ProgressInputStream.read(ProgressInputStream.java:181)
at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:284)
at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:326)
at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178)
at java.io.InputStreamReader.read(InputStreamReader.java:184)
at java.io.BufferedReader.read1(BufferedReader.java:210)
at java.io.BufferedReader.read(BufferedReader.java:286)
at java.io.Reader.read(Reader.java:140)
at
com.amazonaws.services.s3.model.transform.XmlResponsesSaxParser.sanitizeXmlDocument(XmlResponsesSaxParser.java:186)
... 25 more
{code}
Reproducer is attached [^S3IpFinderReproducer.java] .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] ignite pull request #4928: IGNITE-8870: Example of usage of encrypted cache.
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4928 ---
[jira] [Created] (IGNITE-9825) Need test for cache writes on unstable topology
Stanislav Lukyanov created IGNITE-9825: -- Summary: Need test for cache writes on unstable topology Key: IGNITE-9825 URL: https://issues.apache.org/jira/browse/IGNITE-9825 Project: Ignite Issue Type: Test Reporter: Stanislav Lukyanov Assignee: Stanislav Lukyanov It appears that ignite-core test suites have no tests for a simple case - cache writes on unstable topology. Need to add a simple test covering this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-9824) Thin clients benches
Stepan Pilschikov created IGNITE-9824: - Summary: Thin clients benches Key: IGNITE-9824 URL: https://issues.apache.org/jira/browse/IGNITE-9824 Project: Ignite Issue Type: Test Components: thin client Environment: Ignite 2.7 Java 8 NodeJS 10.+ PHP 7.2.7 Python 3.6 Reporter: Stepan Pilschikov Benchmarks for all existed ignite thin clients Case: - Running 1 or 3 nodes on first host - Running code on second host Code: - [NodeJS|https://gist.github.com/pilshchikov/8a4bdb03a8304136c22c9bf7217ee447] - [PHP|https://gist.github.com/pilshchikov/b4351d78ad59e9cd923689c2e387bc80] - [Python|https://gist.github.com/pilshchikov/8aff4e30d83f8bac20c5a4a9c3917abb] - [Java|https://gist.github.com/pilshchikov/08096c78b425e00166a2ffa2aa5f49ce] Results in attachments and comments -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #4907: IGNITE-9785 Introduce read-only state in local no...
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4907 ---
[GitHub] SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run possible blockers' button
SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r223661071
##
File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
##
@@ -321,93 +343,82 @@ function notifyGit() {
});
}
-function triggerBuild(serverId, suiteId, branchName, top, observe, ticketId) {
+function triggerBuilds(serverId, suiteIdList, branchName, top, observe,
ticketId) {
var queueAtTop = isDefinedAndFilled(top) && top;
+var observeJira = isDefinedAndFilled(observe) && observe;
+var suiteIdsNotFound = suiteIdList.length === 0;
Review comment:
Will not work if `suiteIdList` is undefined.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run possible blockers' button
SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r223661071
##
File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
##
@@ -321,93 +343,82 @@ function notifyGit() {
});
}
-function triggerBuild(serverId, suiteId, branchName, top, observe, ticketId) {
+function triggerBuilds(serverId, suiteIdList, branchName, top, observe,
ticketId) {
var queueAtTop = isDefinedAndFilled(top) && top;
+var observeJira = isDefinedAndFilled(observe) && observe;
+var suiteIdsNotFound = suiteIdList.length === 0;
Review comment:
Will not work if `suiteIdList` is a single suite or undefined.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ignite pull request #4933: IGNITE-9558
GitHub user ilantukh opened a pull request: https://github.com/apache/ignite/pull/4933 IGNITE-9558 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9558 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4933.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4933 commit 16b231dfe56042d612f32e8162b59d374c55c037 Author: Ilya Lantukh Date: 2018-10-08T11:31:45Z IGNITE-9558 : Changed remap check. commit 031919f172613a458eae520e14d03672acaa4d5a Author: Ilya Lantukh Date: 2018-10-08T12:17:08Z IGNITE-9558 : Aff ready future. ---
[jira] [Created] (IGNITE-9823) Create TeamCity suite for PHP thin client
Igor Sapego created IGNITE-9823: --- Summary: Create TeamCity suite for PHP thin client Key: IGNITE-9823 URL: https://issues.apache.org/jira/browse/IGNITE-9823 Project: Ignite Issue Type: Task Components: thin client Reporter: Igor Sapego Fix For: 2.7 Implementation of PHP client is almost ready (IGNITE-7783). We need to figure out how to integrate it with TeamCity: 1) New suite for PHP thin client is needed along with required environment 2) Suite should be able to run tests as described in the readme [1] 3) Currently all tests rely on manually started external node. We need to create a set of scripts (bash?) to start/stop nodes locally just like in IGNITE-8463 [1] https://github.com/nobitlost/ignite/blob/ignite-7783-docs/modules/platforms/php/README.md#tests -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] SomeFire opened a new pull request #29: IGNITE-9815: Muted tests shouldn't considered as blocker
SomeFire opened a new pull request #29: IGNITE-9815: Muted tests shouldn't considered as blocker URL: https://github.com/apache/ignite-teamcity-bot/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ignite pull request #4932: IGNITE-9221 Uncomment Cache Query tests, delete a...
GitHub user alamar opened a pull request: https://github.com/apache/ignite/pull/4932 IGNITE-9221 Uncomment Cache Query tests, delete and rename suites You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9221 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4932.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4932 commit 8603fdde56e60dcd807f634c2af247038062ba27 Author: Ilya Kasnacheev Date: 2018-10-09T10:20:57Z IGNITE-9221 Uncomment Cache Query tests, delete and rename suites to simplify layout. ---
[GitHub] ignite pull request #4931: IGNITE-9802
GitHub user NSAmelchev opened a pull request: https://github.com/apache/ignite/pull/4931 IGNITE-9802 Fix for the test. The problem was that PME happens and prevent to closing idle connections. The test needs close connections to recreate comm client. There was only 1s sleep. I replace it with **awaitPartitionMapExchange** and **waitForCondition**. Also, code style and inspections fix. You can merge this pull request into a Git repository by running: $ git pull https://github.com/NSAmelchev/ignite ignite-9802 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4931.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4931 commit 6899735ed5e7bcb85d06021f3bae95b38b25052d Author: NSAmelchev Date: 2018-10-09T09:49:42Z Fix TcpCommunicationSpiFaultyClientTest.testNotAcceptedConnection test ---
[GitHub] ignite pull request #4930: IGNITE-9822 Fix WAL archiver stop logic
GitHub user agoncharuk opened a pull request: https://github.com/apache/ignite/pull/4930 IGNITE-9822 Fix WAL archiver stop logic You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9822 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4930.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4930 commit fc6b1b4fd4bccadf850f73e3286f593e6d8c2617 Author: Alexey Goncharuk Date: 2018-10-09T09:31:18Z IGNITE-9822 Fix WAL archiver stop logic ---
[GitHub] ignite pull request #4929: IGNITE-9821 rebuildIndexesFromHash should not thr...
GitHub user agoncharuk opened a pull request: https://github.com/apache/ignite/pull/4929 IGNITE-9821 rebuildIndexesFromHash should not throw exception â¦tion You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9821 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4929.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4929 commit 59eee5fb1fc636f97ca7817a80e93893ec28a6bc Author: Alexey Goncharuk Date: 2018-10-09T08:30:26Z IGNITE-9821 rebuildIndexesFromHash should not throw IllegalStateException ---
Re: Apache Ignite 2.7 release
Ignite committers, I have prepared a PR for 2.7 blocker [1]. Could anybody merge it to 2.7 and master? [1] https://issues.apache.org/jira/browse/IGNITE-9737 ср, 3 окт. 2018 г. в 14:02, Nikolay Izhikov : > Alexey. > > Sorry, I lost link to IGNITE-9760 in this thread :) > > Thanks, for a clarification. > > > В Ср, 03/10/2018 в 13:58 +0300, Alexey Goncharuk пишет: > > Nikolay, both commits fixed a regression compared to ignite-2.6. First > one was mentioned by Anton Kalashnikov before (java-level deadlock during > WAL flush), another - by Andrey Kuznetsov (NPE during a concurrent WAL > flush). > > > > --AG > > > > ср, 3 окт. 2018 г. в 13:38, Nikolay Izhikov : > > > Hello, Igniters. > > > > > > Release scope is frozen. > > > Please, if you include some new issues in release - discuss it in this > thread. > > > > > > Alexey, can you, please, comment on including fix for IGNITE-9760, > IGNITE-9761 in 2.7 branch. > > > > > > > https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=3355201f3e8cafd23b2250aaf3b91b8b8ed1 > > > > https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=9d6e6ff394c05ddf7ef31a9d9ed1b492d9eeba69 > > > > > > В Ср, 03/10/2018 в 13:24 +0300, Vladimir Ozerov пишет: > > > > Nobody vetos anything, let's stop use this term unless some really > > > > important problem is discussed. > > > > > > > > At this point we are in situation when new tickets are still > included into > > > > the scope. All want to ask is to stop including new tickets without > > > > explaining on why they should be in AI 2.7. Regression between is AI > 2.6 > > > > and AI 2.7 is enough. But "I found new NPE" is not. > > > > > > > > On Wed, Oct 3, 2018 at 11:10 AM Dmitriy Pavlov < > dpavlov@gmail.com> > > > > wrote: > > > > > > > > > Nikolay, > > > > > > > > > > this has nothing about scaring someone. Let me explain about > Apache Way. > > > > > > > > > > Voting -1 to release does not mean blocking it, release can't be > vetoed. > > > > > Approving release is done by policy: majority approval. 3+1 > binding and > > > > > more +1 than -1. Consensus approval is better but not mandatory. > > > > > > > > > > Instead, if PMC says -1 to code modification it means veto and > can't be > > > > > bypassed to anyone. This is a very strong statement, which should > be > > > > > applied reasonably and with technical justification. Lack of > > > > > understanding is not a justification. > > > > > > > > > > So my point instead of vetoing bugfix let's veto commits where the > bugs > > > > > were introduced. I feel a number of bugs reported recently are all > > > > > connected to WalManager, and these bugs may come from just a > couple of > > > > > fixes. PDS tests were quite stable last time, so I think it is > possible to > > > > > find out why WAL crashes and hangs. > > > > > > > > > > Sincerely, > > > > > Dmitriy Pavlov > > > > > > > > > > ср, 3 окт. 2018 г. в 10:05, Andrey Kuznetsov : > > > > > > > > > > > Vladimir, Nikolay, > > > > > > > > > > > > For sure, I'm not an experienced Ignite contributor, so I'm > sorry for > > > > > > intervening. I've just run the reproducer from [1] against > ignite-2.6 > > > > > > branch and it has passed. So, it's not an legacy bug, we've > brought it > > > > > > > > > > with > > > > > > some change of 2.7 scope. Is it still ok to ignore the bug? > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9776 > > > > > > > > > > > > ср, 3 окт. 2018 г. в 2:07, Nikolay Izhikov >: > > > > > > > > > > > > > Hello, Dmitriy. > > > > > > > > > > > > > > I'm sorry, but I don't understand your concern. > > > > > > > > > > > > > > Vladimir just asks experienced Ignite contributor to *explain > impact* > > > > > > > > > > of > > > > > > a > > > > > > > bug. > > > > > > > > > > > > > > Why are you scaring us with your "-1"? > > > > > > > Is it Apache Way to do so? > > > > > > > What should be done for you to return to a constructive > discussion? > > > > > > > > > > > > > > В Ср, 03/10/2018 в 00:23 +0300, Dmitriy Pavlov пишет: > > > > > > > > Hi Igniters, Vladimir, > > > > > > > > > > > > > > > > NPEs or hangs in WAL is a completely non-functional grid (if > > > > > > > > > > > > persistence > > > > > > > > enabled). > > > > > > > > > > > > > > > > I see no reasons to release 2.7 with such symptoms until > we're sure > > > > > > > > > > it > > > > > > is > > > > > > > > too rare/impossible to reproduce. But it seems it is not the > case. I > > > > > > > > > > > > will > > > > > > > > definitely vote -1 for the release if I'm aware of such > problems > > > > > > > > > > exist > > > > > > > and > > > > > > > > were not researched. Community guarantees the quality and > usability > > > > > > > > > > of > > > > > > > the > > > > > > > > product. > > > > > > > > > > > > > > > > We should ask and answer other questions: > > > > > > > > 1) why there are a lot of NPEs and hangs reported recently > in the > > > > > > > > > > same > > > > > > > area > > > > > > > > 2) and why we
[jira] [Created] (IGNITE-9820) Web console: unit test sourcemaps
Ilya Borisov created IGNITE-9820: Summary: Web console: unit test sourcemaps Key: IGNITE-9820 URL: https://issues.apache.org/jira/browse/IGNITE-9820 Project: Ignite Issue Type: Improvement Components: wizards Reporter: Ilya Borisov Assignee: Ilya Borisov Debugging unit tests without sourcemaps is cumbersome, so let's fix this. I've already tried [karma-sourcemap-loader|https://www.npmjs.com/package/karma-sourcemap-loader] and [this|https://stackoverflow.com/a/39175635/333777], but without success. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-9819) SQL: document recomendation to use TIMESTAMP instead of DATE
Vladimir Ozerov created IGNITE-9819: --- Summary: SQL: document recomendation to use TIMESTAMP instead of DATE Key: IGNITE-9819 URL: https://issues.apache.org/jira/browse/IGNITE-9819 Project: Ignite Issue Type: Task Components: documentation Reporter: Vladimir Ozerov Assignee: Artem Budnikov Fix For: 2.7 We support both DATE (date only) and TIMESTAMP (date + time) data types. Unfortunately, DATE data type is serialized/deserialized very inefficiently, what leads to performance degradation. We need to warn users in documentation, that it is better to use TIMESTAMP than DATE. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #4901: IGNITE-9728: fix setup IGNITE_HOME for tests
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4901 ---
[GitHub] ignite pull request #4925: IGNITE-9814: JDK11: HadoopClassLoader#nativeLibra...
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4925 ---
