Re: beforeTestsStarted() was deprecated, what should we use instead?
Hi Anton, I re-checked details of the JIRA task you mentioned [1] and it looks like finished to me, sorry. Ticket description is a list of specific items to be addressed and as far as I can tell all of them are done. Since you mentioned review, changes made per this ticket were fairly thoroughly reviewed: for example respective PR [2] lists five commits that were done to address review comments. And as far as I remember at the time of review we had a solid consensus that scope of these changes is determined by concrete items listed in task description. Note by the way that after merge of these changes it became impossible to write JUnit3 tests inheriting GridAbstractTest. One can probably call this part of the changes final. --- Speaking of JUnit3TestLegacySupport, TODOs are there to help readers see that some specific parts of code in this class are expected to change per particular JIRA task. That it should be (eventually) completely removed or somehow reworked in the future is irrelevant here because this can be done gradually, in different time, for different reasons and by different JIRA tasks. --- With regards to what you call "final Junit3 removal", I find it hard to comprehend what exactly you want nor how this can be expressed in practical actions of changing concrete code. In contrast, the way how migration effort was explained at dev list discussion that started it looks clear and understandable: "Is it time to start translating tests to Unit 4 style?" (worth noting that it further goes into even more concrete and practical explanation of what change is desired and why, explaining that we want to be able to use @Ignore annotation to simplify maintenance at Teamcity) And umbrella JIRA task that followed this discussion [4] also has actionable description of what is to be done: "This task is to migrate all tests to single uniform version Junit 4". Speaking in terms of mentioned discussion and JIRA task, this is all done and over - finished and verified ([5]). In fact, anyone can verify whether migration is completed by doing plain text search for "junit.framework" in project files and reviewing search results to make sure that there are no test classes / suites inheriting the old API (JUnit 3 package names start with junit.framework). It's very easy, just give it a try. Summing up, I don't know what you have in mind speaking of what else should be done or finalized, but whatever it is, I can't see how it would fit into the scope of our original discussion here and of original JIRA task. [1] https://issues.apache.org/jira/browse/IGNITE-10177 [2] https://github.com/apache/ignite/pull/5615 [3] http://apache-ignite-developers.2346864.n4.nabble.com/Is-it-time-to-move-forward-to-JUnit4-5-td29608.html [4] https://issues.apache.org/jira/browse/IGNITE-10173 [5] https://issues.apache.org/jira/browse/IGNITE-10629 regards, Oleg Anton Vinogradov-2 wrote > Oleg, > > You may use TODO if it is really necessary. > I see no reason to have any todo at JUnit3TestLegacySupport class since > it's already marked as legacy and should be removed in the future. > And we should have an issue about this removal. > > Why you closed GNITE-10177 "cleanup Junit 3 from the project" since you're > not finished work? > Why now we discuss incorrect deprecation instead of making proper fix > design in advance? > > One more question to the committer. > Dmitriy, > > Why incomplete fix was merged to master without any issues responsible for > finalization? > Who's now responsible for final Junit3 removal? > > On Mon, Feb 18, 2019 at 4:22 PM oignatenko > oignatenko@ > wrote: > >> Hi Anton, >> >> I removed @deprecated from javadoc, thanks for noticing. PR #6122 [1] is >> updated. >> >> As for TODOs, I think you are wrong here because Ignite coding guidelines >> [2] not only explicitly allow these but also explain the format in which >> these should be presented. If you find violations of recommended TODOs >> format, please let me know. >> >> regards, Oleg >> >> [1]: https://github.com/apache/ignite/pull/6122 >> [2]: >> >> https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-TODOs >> >> >> >> -- >> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ >> -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: beforeTestsStarted() was deprecated, what should we use instead?
Hi Anton, I removed @deprecated from javadoc, thanks for noticing. PR #6122 [1] is updated. As for TODOs, I think you are wrong here because Ignite coding guidelines [2] not only explicitly allow these but also explain the format in which these should be presented. If you find violations of recommended TODOs format, please let me know. regards, Oleg [1]: https://github.com/apache/ignite/pull/6122 [2]: https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-TODOs -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: beforeTestsStarted() was deprecated, what should we use instead?
Hi Anton, There you go: PR to remove deprecation: https://github.com/apache/ignite/pull/6122 JIRA: https://issues.apache.org/jira/browse/IGNITE-11345 If anything there is not as you expected, please let me know. regards, Oleg -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: beforeTestsStarted() was deprecated, what should we use instead?
Hi Anton, I would like to re-check if I correctly understand the plan. So, we are going to remove deprecation from these two methods - and the reason for this is that the way recommended instead of these methods makes it less convenient to start and stop the grid. Now, regarding the mentioned inconvenient way, we also plan to improve it (JIRA task IGNITE-11240 if memory serves). My understanding is, after we are done with it, we will recover deprecation for these methods because as follows from above, inconvenience of using the recommended way was the only reason to remove it. Please feel free to correct if I missed something. regards, Oleg -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: Code inspection
Hi Maxim,
I believe that whatever style checks we establish at Teamcity, we better
take care of making it easy for developers to find and fix violations in
their typical dev environment (for Ignite this means, in IDEA). I think it
is important that developers can maintain required style with minimal effort
on their side.
If above is doable then I am 200% for migrating our Teamcity inspections to
checkstyle / maven.
This is because I am very disappointed observing how it stays broken for so
long. And worst of all, even when (if) it is fixed, I feel we will always be
at risk that it breaks again and that we will have to again wait for months
for it to be fixed.
This is such a stark contrast with my experience regarding checkstyle based
inspections. These just work and you just never fear that it is going to
break for some obscure reason, this is so much better than what I observe
now.
One suggestion in case if we pick checkstyle - I recommend keeping its
config file somewhere in the project under version control. I used to
maintain such a shared style config at one of past jobs and after some
experimenting it turned out most convenient to have it this way - so that
developers could easily assess and discuss style settings and keep track of
changes in these. (note how Kafka folks from your link [5] appear to be
doing it this way)
regards, Oleg
Mmuzaf wrote
> Igniters,
>
> I've found that some of the community members have faced with
> `[Inspections] Core suite [1]` is not working well enough on TC. The
> suite has a `FAILED` status for more than 2 months due to some issues
> in TeamCity application [2]. Current suite behaviour confuses not only
> new contributors but also other community members. Moreover, this
> suite is no longer checks rules we previously configured. For
> instance, in the master branch, I've found 11 `Unused imports` which
> should have been caught earlier (e.g. for
> {{IgniteCachePutAllRestartTest} [3]).
>
> I think we should make the next step to enable an automatic code style
> checks. As an example, we can consider the Apache Kafka code style [5]
> way and configure for the Ignite project a maven-checkstyle-plugin
> with its own maven profile and run it simultaneously with other TC. We
> can also enable the previously configured inspection rules, so no
> coding style violations will be missed.
>
> I see some advantages of using a maven plugin:
> - an IDE agnostic way for code checks
> - can be used with different CI and build tools (Jenkins, TC)
> - executable from the command line
> - the entry single point to configure new rules
>
> I've created the ticket [4] and will prepare PR for it.
>
> WDYT?
>
> [1]
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_InspectionsCore_IgniteTests24Java8=%3Cdefault%3E=buildTypeStatusDiv
> [2] https://youtrack.jetbrains.com/issue/TW-58504
> [3]https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCachePutAllRestartTest.java#L29
> [4] https://issues.apache.org/jira/browse/IGNITE-11277
> [5] https://github.com/apache/kafka/tree/trunk/checkstyle
>
> On Fri, 21 Dec 2018 at 16:03, Petr Ivanov
> mr.weider@
> wrote:
>>
>> It seems there is bug in latest 2018.2 TeamCity
>> Bug is filed [1]
>>
>>
>> [1] https://youtrack.jetbrains.com/issue/TW-58504
>>
>> > On 19 Dec 2018, at 11:31, Petr Ivanov
> mr.weider@
> wrote:
>> >
>> > Investigating problem, stand by.
>> >
>> >
>> >> On 18 Dec 2018, at 19:41, Dmitriy Pavlov
> dpavlov@
> wrote:
>> >>
>> >> Both patches were applied. Maxim, thank you!
>> >>
>> >> What about 1. An `Unexpected error during build messages processing in
>> >> TeamCity`, what can we do as the next step to fix it?
>> >>
>> >> Sincerely,
>> >> Dmitriy Pavlov
>> >>[cut]
>> >
>>
--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: beforeTestsStarted() was deprecated, what should we use instead?
Hi Ivan, For the sake of precision, startGrid() is currently overridden in one of subclasses of GridAbstractTest. This means that we would have to somehow handle that when changing this method to static. Same thing is with another solid candidate to making static, stopAllGrids(boolean), which is also currently overridden in another subclass. That said, above issues look relatively minor and manageable and overall I think it would be better to redesign GridAbstractTest as you suggested. regards, Oleg Павлухин Иван wrote > Hi, > > AFAIK various startGrid* methods of GridAbstractTest are not tied to > concrete instance of test class. I think that a we can make them > static. Also same can be done for some other methods and all they can > be extracted into static utility class like GridTestSupport in order > to reduce GridAbstractTest class size and separate concerns. > > What do you think? > > чт, 7 февр. 2019 г. в 09:44, oignatenko > oignatenko@ > : >> >> Hi Anton, >> >> You can start and stop grid from static context required by mentioned >> annotations using code like: >> >> MyTestClass.class.newInstance().startGrid(); >> >> This way doesn't look very convenient and I created JIRA task to address >> that: >> >> https://issues.apache.org/jira/browse/IGNITE-11240 >> >> Does that address your question? >> >> regards, Oleg >> >> >> >> -- >> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ > > > > -- > Best regards, > Ivan Pavlukhin -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: beforeTestsStarted() was deprecated, what should we use instead?
Hi Anton, You can start and stop grid from static context required by mentioned annotations using code like: MyTestClass.class.newInstance().startGrid(); This way doesn't look very convenient and I created JIRA task to address that: https://issues.apache.org/jira/browse/IGNITE-11240 Does that address your question? regards, Oleg -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: edit access to Apache Ignite wiki
Thank you Dmitriy! I updated the wiki. regards, Oleg PS. Also thanks for the reference to "How To document" guidelines, that's a useful read. Dmitriy Pavlov-3 wrote > Done, I've added permission for Oleg Ignatenko user. > > Just in case, let me share > https://cwiki.apache.org/confluence/display/IGNITE/How+to+Document with > you > :) > > пт, 25 янв. 2019 г. в 20:55, oignatenko > oignatenko@ > : > >> Hello, >> >> Is it possible to get edit access to Apache Ignite wiki? >> >> I've been working on particular JIRA ticket [1] and one of reviewers >> suggested me update particular wiki page [2] after the ticket is done. >> >> Now that the ticket is done I would like to make proposed edits to wiki >> page. >> >> TIA, >> regards, Oleg >> >> [1]: https://issues.apache.org/jira/browse/IGNITE-10178 >> [2]: https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines >> >> >> >> -- >> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ >> -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
edit access to Apache Ignite wiki
Hello, Is it possible to get edit access to Apache Ignite wiki? I've been working on particular JIRA ticket [1] and one of reviewers suggested me update particular wiki page [2] after the ticket is done. Now that the ticket is done I would like to make proposed edits to wiki page. TIA, regards, Oleg [1]: https://issues.apache.org/jira/browse/IGNITE-10178 [2]: https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: Is it time to move forward to JUnit4 (5)?
Hi Ivan, While I have your attention, I would like to say huge thanks for your contribution to migration efforts. I am specifically talking about trick you proposed when it started, with using TestRule in GridAbstractTest to enable switching between JUnit 3 and 4 execution modes. Looking back, I think that approach I originally planned (before you proposed this way) would cause us much more hassle in migration. REGARDS, Oleg Павлухин Иван wrote > Cheers! > > вт, 22 янв. 2019 г. в 20:19, oignatenko > oignatenko@ > : >> >> ...sort of a follow-up. I gave folks a bit more leeway than originally >> planned week or two. >> >> It's been about a month since master was changed in a way that wouldn't >> allow JUnit 3 tests execute anymore (per IGNITE-10177) and I just started >> progress on IGNITE-10629 and made a promised inspection for tests that >> could >> slip through without required annotation while we were migrating the >> project >> to JUnit 4. >> >> Results of this check look pretty good, IDEA reported only 6 (six) >> troublesome test cases (4 of which were by the way annotated @Ignore, >> meaning that even with added @Test these won't run anyway). Compared to >> over >> 11,600 properly annotated test cases this looks really minor. We probably >> can say that tests in master migrated to JUnit 4 quite smoothly. >> >> regards, Oleg >> >> >> Vladimir Ozerov wrote >> > Hi Oleg, >> > >> > Yes, makes perfect sense. Thank you. >> > >> > On Mon, Dec 10, 2018 at 10:14 PM oignatenko >> >> > oignatenko@ >> >> > wrote: >> > >> >> Hi Vovan, >> >> >> >> I just created JIRA ticket to address your concerns: >> >> - https://issues.apache.org/jira/browse/IGNITE-10629 >> >> >> >> In brief, the plan is that a week or two after migration is over we >> will >> >> run >> >> code inspection that detects JUnit 3 style tests that lack @Test >> >> annotation >> >> and fix these tests if there are any. >> >> >> >> Does that answer your question? >> >> >> >> regards, Oleg >> >> Vladimir Ozerov wrote >> >> > Ed, >> >> > >> >> > Several questions from my side: >> >> > 1) When the change is expected to be merged? >> >> > 2) What contributors with opened PRs and new or updated JUnit3 tests >> >> are >> >> > supposed to do? Rewrite to JUnit4? >> >> > >> >> > If yes, then we should give them time to have a chance to get used >> to >> >> new >> >> > approach and resolve possible conflicts. >> >> > >> >> > Vladimir. >> >> > >> >> [cut] >> >> >> >> -- >> >> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ >> >> >> >> >> >> >> >> -- >> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ > > > > -- > Best regards, > Ivan Pavlukhin -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: IgniteCacheTestSuite3 on TeamCity
Semen, As a follow up, fix for discovered regression was merged tto master per https://issues.apache.org/jira/browse/IGNITE-11038 If this doesn't fully resolve the issue you observe, please let us know. regards, Oleg -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: IgniteCacheTestSuite3 on TeamCity
Hi Semen, Thanks for heads up! What you observe is a regression introduced in the course of doing changes per IGNITE-10796 [1]. In file IgniteBinaryObjectsCacheTestSuite3.java line 64 currently reads: List> suite = new ArrayList<>(); Above is wrong, correct code at this line should be: List> suite = new ArrayList<>(IgniteCacheTestSuite3.suite(ignoredTests)); I plan to create a ticket and fix this right now. regards, Oleg [1]: https://issues.apache.org/jira/browse/IGNITE-10776 -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: Is it time to move forward to JUnit4 (5)?
...sort of a follow-up. I gave folks a bit more leeway than originally planned week or two. It's been about a month since master was changed in a way that wouldn't allow JUnit 3 tests execute anymore (per IGNITE-10177) and I just started progress on IGNITE-10629 and made a promised inspection for tests that could slip through without required annotation while we were migrating the project to JUnit 4. Results of this check look pretty good, IDEA reported only 6 (six) troublesome test cases (4 of which were by the way annotated @Ignore, meaning that even with added @Test these won't run anyway). Compared to over 11,600 properly annotated test cases this looks really minor. We probably can say that tests in master migrated to JUnit 4 quite smoothly. regards, Oleg Vladimir Ozerov wrote > Hi Oleg, > > Yes, makes perfect sense. Thank you. > > On Mon, Dec 10, 2018 at 10:14 PM oignatenko > oignatenko@ > wrote: > >> Hi Vovan, >> >> I just created JIRA ticket to address your concerns: >> - https://issues.apache.org/jira/browse/IGNITE-10629 >> >> In brief, the plan is that a week or two after migration is over we will >> run >> code inspection that detects JUnit 3 style tests that lack @Test >> annotation >> and fix these tests if there are any. >> >> Does that answer your question? >> >> regards, Oleg >> Vladimir Ozerov wrote >> > Ed, >> > >> > Several questions from my side: >> > 1) When the change is expected to be merged? >> > 2) What contributors with opened PRs and new or updated JUnit3 tests >> are >> > supposed to do? Rewrite to JUnit4? >> > >> > If yes, then we should give them time to have a chance to get used to >> new >> > approach and resolve possible conflicts. >> > >> > Vladimir. >> > >> [cut] >> >> -- >> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ >> -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: Time to remove automated messages from the devlist?
Hi Denis, Mixing JIRA and human mails in one list seems to be inconvenient both for those interested in monitoring human and JIRA mails and from this perspective separate lists approach looks superior. Also, your mention of filtering made me wonder if "mixed" approach may have effect opposite to what you want, that is folks will just blindly filter out JIRA mails so that these will be effectively hidden from target audience. That said, your reasons for sending JIRA notifications to mailing list readers look important to me and that also makes me unhappy with approach of separate JIRA list. Trying to figure if there is a way to somehow resolve above contradiction I re-checked Apache mailing lists documentation for maybe they have something to address these matters somehow. >From what I read it looks that we can try sort of combined solution, when JIRA notification feed to separate mailing list which in turn forwards daily digest to human list. [1] WDYT? regards, Oleg [1]: https://apache.org/foundation/mailinglists.html#digest-subscriptions Denis Magda-2 wrote > -1 for this action. > > JIRA notifications are sent on purpose to the dev list - someone came > across an issue and want to report it to the dev community. The community > has to be aware of this. That's the purpose of the community to improve > and > fix the project. It's just wrong to force to subscribe to 2 lists, people > won't do this, we're lazy by nature. Just use email filters, that's XXI > century but please don't separate discussions from issues reporting. > > -- > Denis > > > On Thu, Jan 10, 2019 at 3:55 AM Dmitriy Pavlov > dpavlov@ > wrote: > >> Hi Igniters, >> >> After removal of GitHub Comments from the list I have (a very subjective) >> feeling, that there became more human-human interaction, which is >> definitely more important that opportunity to control new JIRA tickets >> using the list. >> >> I suggest coming back to the idea of moving JIRA to a separate list. >> Please >> share your vision on this topic. Should it be > jira@.apache > or we >> should reuse > notifications@.apache >> >> Sincerely, >> Dmitriy Pavlov >> -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: Apache Ignite TeamCity Bot - muted tests
Hi Andrey,
As far as I know tests annotated by @Ignore can be conveniently tracked on
Teamcity but this requires such tests to be included into JUnit 4 test suite
(org.junit.runners.Suite).
Above requirement currently isn't met by many Ignite tests which are
included in JUnit 3 suites (junit.framework.TestSuite). This means that test
cases annotated @Ignore simply are hidden when present in such old-fashioned
suites.
We are currently working on migrating Junit 3 suites to JUnit 4. If you are
interested, work breakdown and progress can be found in JIRA:
- https://issues.apache.org/jira/browse/IGNITE-10762
-
With regards to Assume API, it seems more complicated. I have recently read
that tests that are conditionally skipped using this API are reported by
JUnit 4 test framework as passed. This is not very convenient.
I think I have seen somewhere mentioned that proper reporting of
conditionally skipped tests can be achieved only with JUnit 5. But I didn't
dig deeper there because we haven't yet decided whether it is worth it for
Ignite to move to JUnit 5
(https://issues.apache.org/jira/browse/IGNITE-10180).
Given above, I believe that the proper way to mute tests is currently with
@Ignore and Assume API. It's not 100% ideal but overall looks better than
the old one.
regards, Oleg
Andrew Mashenkov wrote
> Dmitry,
>
> As far as I understand, @IgniteIgnore and fail("") works in similar way
> and
> requires test to be muted on TC manually.
> And we have to unmute these tests on TC right after fix will be merged to
> master, isn't it?
>
> @Ignore and Assume.that works different way comparing to previous two.
> Junit just exclude such tests from run.
> So, there is no need to mute\unmute them on TC at all, but...
> Does TC treat such tests as muted ones and we can see them on "muted
> tests"
> page?
> This may be useful to track tests state if someone forget to remove
> @ignore
> while fixing related ticket.
>
>
> On Mon, Dec 17, 2018 at 5:54 PM Anton Vinogradov
> av@
> wrote:
>
>> >> In this case, we will not need TeamCity mutes anymore.
>> Sounds great!
>>
>> On Mon, Dec 17, 2018 at 5:23 PM Dmitrii Ryabov
> somefireone@
>
>> wrote:
>>
>> > Dmitriy,
>> >
>> > with ignore annotations we will need to check forgotten tests
>> > manually. Thats bad, but we will save some machine time in common
>> > runs.
>> > пн, 17 дек. 2018 г. в 17:06, Dmitriy Pavlov
> dpavlov@
> :
>> > >
>> > > Investigation parameters: Can leave as empty
>> > > Unmute: Manual (don't use auto because of flaky tests)
>> > > Text: https://issues.apache.org/jira/browse/IGNITE-N
>> > >
>> > > But anyway, I hope in the nearest future best way to mute test will
>> be
>> to
>> > > ignore it using:
>> > > @IgniteIgnore
>> > > or @Ignore
>> > > or Assume.that()
>> > >
>> > > In this case, we will not need TeamCity mutes anymore.
>> > >
>> > > I'm not sure which way of ignoring will be best.
>> > >
>> > > пн, 17 дек. 2018 г. в 17:02, Anton Vinogradov
> av@
> :
>> > >
>> > > > Dmitrii,
>> > > >
>> > > > My question was mostly about how to mute test properly.
>> > > >
>> > > >
>> > > > On Mon, Dec 17, 2018 at 4:27 PM Dmitrii Ryabov <
>>
> somefireone@
>>
>> > > > wrote:
>> > > >
>> > > > > Anton,
>> > > > >
>> > > > > In the "Mute" column you can find link to the test on TeamCity.
>> On
>> > > > > this page you can see test details like run history and current
>> > mutes.
>> > > > > Here you should be able to unmute existing mutes.
>> > > > > пн, 17 дек. 2018 г. в 16:21, Anton Vinogradov
> av@
> :
>> > > > > >
>> > > > > > Great feature!
>> > > > > >
>> > > > > > Could you please explain how to have a deal with it?
>> > > > > > How should I mite/unmute tests for now?
>> > > > > >
>> > > > > > On Fri, Dec 14, 2018 at 6:50 PM Dmitriy Pavlov <
>>
> dpavlov@
>> > >
>> > > > > wrote:
>> > > > > >
>> > > > > > > We have IgniteIgnore, so we can use it. It seems behavior is
>> the
>> > > > same.
>> > > > > We
>> > > > > > > need just to understand in which case we can get issue ID
>> from
>> TC
>> > > > REST
>> > > > > (for
>> > > > > > > the Bot).
>> > > > > > >
>> > > > > > > пт, 14 дек. 2018 г. в 17:51, Vyacheslav Daradur <
>> >
> daradurvs@
>> > > > >:
>> > > > > > >
>> > > > > > > > Dmitry Pavlov,
>> > > > > > > >
>> > > > > > > > As far as I know, we are able to use following construction
>> to
>> > > > ignore
>> > > > > > > test:
>> > > > > > > > Assume.assumeTrue("link-to-issue", false);
>> > > > > > > >
>> > > > > > > > On Fri, Dec 14, 2018 at 5:44 PM Dmitriy Pavlov <
>> >
> dpavlov@
>> > > > >
>> > > > > > > wrote:
>> > > > > > > > >
>> > > > > > > > > Thank you, Dmitrii,
>> > > > > > > > >
>> > > > > > > > > I've started unmuting tests starting from yesterday.
>> > > > > > > > >
>> > > > > > > > > Now muted test count was decreased from 3540 to 3408
>> > > > > > > > >
>> > > > > > > >
>> > > > > > >
>> > > > >
>> > > >
>> >
>>
Re: Is it time to move forward to JUnit4 (5)?
Hi Ivan, To answer your last question, yes, all the tests are to be marked with @Test annotations, and those that are meant to be ignored are going to be marked with @Ignore annotations. There is no exceptions to that, and these annotations will work just as well on tests using our home brewed beforeTestsStarted, beforeTest, afterTest, afterTestsStarted. For the sake of completeness, developers will also be able to use Before* / After* annotations on their own methods in tests. The only exception (clarified in respective javadocs) is that these annotations shouldn't be used on overrides of our home brewed methods - and these methods, in addition, will be recommended (not mandated) to avoid wia deprecation notices. - As for accessing tests which have problems running under junit4, the way how I search for these in current master is regex search in IDEA for "addTestSuite.*class", that is I search in testsuites for entries that are added using method "addTestSuite" with parameter class. Probably worth noting that some of the problems that were previously blocking addition of particular tests have been resolved in the course of working on IGNITE-10177 (https://github.com/apache/ignite/pull/5615). One riddle that currently looks particularly difficult to crack is Teamcity failures in "Queries 1", I even haven't yet figured how to reproduce these locally. regards, Oleg Павлухин Иван wrote > Hi Oleg, > > Now concerns about junit3 elimination are clear for me. And I agree > that it is worth to do it. By the way is it possible to access tests > which have problems running under junit4? I would like to take a look. > > Also a clarifying bit regarding next migration steps is needed. Sorry > if it was described but I missed it. Currently we have tons of tests > which rely on our home brewed beforeTestsStarted, beforeTest, > afterTest, afterTestsStarted. Are you going to mark them all with > corresponding junit4 annotations? > пн, 17 дек. 2018 г. в 19:13, oignatenko > oignatenko@ > : >> >> Hi Ivan, >> >> Per my cursory check of the code currently in master, we have 239 test >> classes that couldn't migrate (that's probably about 500 or something >> test >> cases). For comparison, over 1600 classes migrated without problems. This >> is >> to answer your questions about how many tests are affected by change and >> how many tests were not migrated yet. >> >> - >> >> I think we can say that only small percent of tests turned out sensitive >> to >> JUnit framework change. >> >> In the same time, due to very large overall amount of our tests we have >> quite a big number as an absolute value. I point this because if amount >> of >> troublesome tests was smaller (say, order of magnitude smaller) I would >> consider delaying migration until all tests reworked to blend totally >> seamlessly into new version JUnit. This is doable - as sort of "pilot >> exercise" me and Ed adjusted one test case this way - but the sheer >> amount >> of work on 200+ classes raises a question, whether it is worth it (I >> think >> it isn't). >> >> With regards to question 2, changes to TestCounters are farly trivial >> (and >> necessary) if you look at the code diff. Prior code counted amount of >> test >> cases in the class by JUnit 3 convention: it picked public void methods >> without parameters starting with "test". Changed code counts test cases >> as >> JUnit 4 does: by checking if method is annotated with @Test. Change is >> necessary because it will allow test developers fully use JUnit 4 >> features >> by adding test cases that don't follow old naming requirement. I >> experimented with it a little and as far as I could see the old >> TestCounters >> indeed break when there are methods following new convention, it >> triggered >> afterTestsStopped too early. >> >> The answer to your question 3 lies in javadocs I added to runSerializer >> declaration, or, more precisely, in TestCounters javadoc referred from >> there. As you can see, current plan is to get rid of TestCounters fairly >> soon (per IGNITE-10179) and this will also get rid of runSerializer so >> this >> is merely a temporary band aid to be removed soon. >> >> For the sake of completeness, my initial plan was to thoroughly >> investigate >> and test whether change from JUnit 3 to JUnit 4 would keep accessing >> counters safe or not and only introduce runSerializer if it really does >> but >> after realising that this whole thing is likely to go away in a few days >> from now I decided that it isn't wor
Re: Is it time to move forward to JUnit4 (5)?
t might affect only small number > of tests. Am I right here? > 2. Also I saw that in your experiment [1] some changes related to > TestCounters were made. What is wrong with them? > 3. Why do we need wrap test execution into critical section > (runSerializer lock)? I thought that we always run tests serially. > > I generally like an idea of having workaround falling back to old test > execution flow. But for me the most desired trait of things like > LegacySupport is being lightweight and enabled only on purpose. And > from the first glance current prototype looks a little bit > complicated. As an alternative we can keep junit3 for troublesome > tests, can't we? > > Also is there any vision how many migration problems do we have so far > and how many tests was not migrated yet? > вс, 16 дек. 2018 г. в 17:39, oignatenko > oignatenko@ > : >> >> Hi Ivan, >> >> As promised in my prior mail, here is the branch where I experimented to >> address concerns you raised: >> - >> https://github.com/gridgain/apache-ignite/tree/ignite-10177-experimental >> >> I tested it locally and on Teamcity and it worked as intended. >> >> I think I managed to exactly reproduce execution sequence of JUnit 3 test >> case so that tests designed expecting it will run exactly as it was >> before. >> >> As for troublesome APIs I used deprecation to warn developers agains >> using >> these and recommend what they need to use instead. >> >> If you are interested in closer studying the changes, class >> GridAbstractTest1 is probably best as a starting point. This class is a >> temporary copy of GridAbstractTest made to minimise amount of editing in >> dependent classes while I was experimenting; in real implementation (per >> IGNITE-10177) this code is expected to be in GridAbstractTest. >> >> Also, I used ML testsuite to debug the changes I made, because it >> contains >> convenient mix of usecases and runs fast. >> >> Your feedback is much appreciated. >> >> regards, Oleg >> > [...] >> >> -- >> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ > > > > -- > Best regards, > Ivan Pavlukhin -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: Is it time to move forward to JUnit4 (5)?
Hi Ivan, As promised in my prior mail, here is the branch where I experimented to address concerns you raised: - https://github.com/gridgain/apache-ignite/tree/ignite-10177-experimental I tested it locally and on Teamcity and it worked as intended. I think I managed to exactly reproduce execution sequence of JUnit 3 test case so that tests designed expecting it will run exactly as it was before. As for troublesome APIs I used deprecation to warn developers agains using these and recommend what they need to use instead. If you are interested in closer studying the changes, class GridAbstractTest1 is probably best as a starting point. This class is a temporary copy of GridAbstractTest made to minimise amount of editing in dependent classes while I was experimenting; in real implementation (per IGNITE-10177) this code is expected to be in GridAbstractTest. Also, I used ML testsuite to debug the changes I made, because it contains convenient mix of usecases and runs fast. Your feedback is much appreciated. regards, Oleg Павлухин Иван wrote > Hi guys, > > I started writing a junit4 test for a feature I am currently working > on. And immediately I faced a peculiarity with @Before test fixture. I > automatically named a method "setUp" and realized that I override a > method from a superclass. It can produce unwanted effects. First, it > looks reasonable to call a corresponding superclass method in an > overridden method, but in my understanding it is not a canonical way > in junit4. Second, in junit4 overriding method annotated with @Before > can lead changing order of this method execution among other @Before > method. Second point might lead to surprising effects in tests > hierarchies defining @Before methods on different levels. > > Let's return to the test I mentioned in the beginning of current > email. I decided to use a different name for my @Before method > (actually it was unpleasant "setUp1"). I think that we can do the > following to make things straightforward: > 1. Prohibit overriding base class setUp and tearDown methods by making > them final (at least in GridCommonAbstractTest and > GridSpiAbstractTest). > 2. Use common default name for @Before and @After methods defined in > concrete test classes. I do not have really good candidates for names. > Simply we can use setUp1, tearDown1. Another option initTest, > cleanupTest. Your name candidates are quite appreciated. > > WDYT? > > P.S. Also I went through other tests and found really dangerous thing. > In IgniteJmsStreamerTest (not migrated to junit4 yet) we have > beforeTest method (overriding GridAbstractTest framework method) > annotated with @Before annotation (I believe accidentally)! It means > that migrating such test to junit4 will lead to calling beforeTest > twice. Ouch! > ср, 12 дек. 2018 г. в 13:21, Павлухин Иван > vololo100@ > : >> >> Hi Oleg, >> >> Thanks your for detailed answer. Using junit4 annotations where >> possible sounds good to me. >> >> Also I would like to thank everybody involved in migration to junit4 >> process for your efforts. You were able to move a problem which looked >> mountain-heavy. I believe that is a significant milestone on Ignite >> stabilization road. >> >> Well done! >> вт, 11 дек. 2018 г. в 20:20, oignatenko > oignatenko@ > : >> > >> > Hi Ivan, >> > >> > That's a very good question and I think you spotted a point where >> Ignite >> > test developer's preferences need to change when migrating from Junit 3 >> to >> > 4. >> > >> > In brief, when developing under JUnit 3 there were good reasons to >> prefer >> > our homebrew template methods (beforeTestsStarted, beforeTest, >> afterTest, >> > afterTestsStopped) over those provided by JUnit (setUp / tearDown). To >> > answer your other question, in order to reliably understand how our >> methods >> > work one would better go to (potentially changing) code of >> GridAbstractTest >> > and check where and how these are invoked. >> > >> > But under JUnit 4 these reasons don't apply anymore and preference >> should go >> > the other way, namely in favor of annotations @Before, @After, >> @BeforeClass, >> > @AfterClass. >> > >> > In other words, when these annotations allow you implement desired test >> > logic you better use them. These annotations have stable, well >> documented >> > and widely understood semantics (and don't require one to skim through >> 3K >> > lines of code for grasping details:). >> > >> > And it makes sense to "fallback" to our
Re: Is it time to move forward to JUnit4 (5)?
Hi Ivan, The issues you mentioned are real and these issues are expected to be addressed per IGNITE-10177. I am currently experimenting with various approaches to tackle that, will post here when "early preview implementation" is ready to let others take a look and test it. Until this is completed the most reliable approach I've found is to fallback to JUnit 3 way every time that you observe unexpected test behavior and see no reasonable way to fix it. You can see how I followed this "transitional" approach in IGNITE-10176 which is expected to be merged to master soon (meanwhile the code can be seen in PR https://github.com/apache/ignite/pull/5659). - With regards to using Before* and After* annotations on overrides of before* and after* methods of GridAbstractTest, this is pure evil and should be always avoided (removed if noticed). When test runs under JUnit 3 these annotations are simply ignored which makes them totally useless (and misleading to the reader of the code) and when it runs under JUnit 4 these start doing real harm by making annotated method run twice. If you are interested, more detailed explanation with code example is available in comments under IGNITE-10176: - https://issues.apache.org/jira/browse/IGNITE-10176?focusedCommentId=16718914=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16718914 I am currently trying to figure what could be the best way to communicate this to API users, possibly in respective method javadocs. Also I plan to find and clean up all the inappropriate annotations that are already there in the project in the IGNITE-10177. If you have further questions, please let me know. regards, Oleg -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: Is it time to move forward to JUnit4 (5)?
Hi Ivan, That's a very good question and I think you spotted a point where Ignite test developer's preferences need to change when migrating from Junit 3 to 4. In brief, when developing under JUnit 3 there were good reasons to prefer our homebrew template methods (beforeTestsStarted, beforeTest, afterTest, afterTestsStopped) over those provided by JUnit (setUp / tearDown). To answer your other question, in order to reliably understand how our methods work one would better go to (potentially changing) code of GridAbstractTest and check where and how these are invoked. But under JUnit 4 these reasons don't apply anymore and preference should go the other way, namely in favor of annotations @Before, @After, @BeforeClass, @AfterClass. In other words, when these annotations allow you implement desired test logic you better use them. These annotations have stable, well documented and widely understood semantics (and don't require one to skim through 3K lines of code for grasping details:). And it makes sense to "fallback" to our old-fashioned methods only when you simply have no other choice. For example doing some quick and simple fix in a legacy code that is filled with multiple usages of our old template methods it may be okay to choose to keep old style - instead of doing cumbersome, risky and lengthy refactoring or polluting test code with inconsistent use of annotations intertwined with old style methods. That's what I think. If you're interested in why I think so, refer to boring explanation in PS. regards, Oleg - PS. With regards to old preferences I believe it is very important to keep in mind that Junit 3 didn't provide means to do initialization and cleanup once for all test methods in the class. So when one needed things to run once per test class they had to go somewhere else. In Ignite the natural way to go was GridAbstractTest which provided this functionality via beforeTestsStarted and afterTestsStopped (with some glitches as I recently learned but still). And after one had to use these methods there was no compelling reason to use JUnit's setUp and tearDown, because GridAbstractTest also provided similar methods. It was just easier to consistently use full and cohesive set of methods provided by GridAbstractTest than switch back and forth between it and JUnit 3 methods. With JUnit 4 above reasoning doesn't apply anymore because its features are just as full and cohesive and can be consistently used without having to fallback to stuff from GridAbstractTest. So we have a real choice now and can judge based on other criteria than functional completeness (since both ways now satisfy that most important criteria). And this reveals us a full spectrum of JUnit advantages over GridAbstractTest (which was obscured before, because JUnit 3 was functionally incomplete). And on that newly opened spectrum JUnit 4 API wins hands down. JUnit 4 is much better documented and "googlable", it is stable and much wider known. The last but not the least, as I already mentioned, it doesn't require one to skim through 3K lines of code for grasping details and its semantics doesn't depend on (possibly changing) implementation code. Also, initialization and cleanup methods of JUnit 4 make an organic part of wider, more comprehensive API which smoothly integrates with IDE, Maven, Teamcity and all imaginable Java tools over there. Every time one annotates @Test or @Ignore gives them a reason to prefer other JUnit annotations over something else. It works about the same as I described above for beforeTestsStarted in GridAbstractTest and how it inhibited use of JUnit 3 methods: after you picked one part of some API it naturally becomes more convenient to keep using other parts of that API. Summing up, I believe that every time you have a (sensible) choice between JUnit 4 and GridAbstractTest methods you just pick JUnit 4 and don't look back. Павлухин Иван wrote > Ed, Oleg, > > Could you please clarify on the following point: >> 3. Add @Before, @After on methods which should run before, after a >> test (setUp, tearDown in current approach). > Beforehand we used to override beforeTestsStarted, beforeTest, > afterTest, afterTestsStarted. What will happen with these methods > after migration to junit4? I can see that order of execution can > become tricky especially when both styles are used at the same time. > And an immediate suggestion is to avoid using both styles (annotations > and overridden methods) in the same test. What is your insight? > вт, 11 дек. 2018 г. в 10:27, Vladimir Ozerov > vozerov@ > : >> >> Hi Oleg, >> >> Yes, makes perfect sense. Thank you. >> >> On Mon, Dec 10, 2018 at 10:14 PM oignatenko > oignatenko@ > wrote: >> >> > Hi Vovan, >> > >> > I just created JIRA ticket to address your concerns: >> > - https://issues.apache.org/j
Re: Is it time to move forward to JUnit4 (5)?
Hi Vovan, I just created JIRA ticket to address your concerns: - https://issues.apache.org/jira/browse/IGNITE-10629 In brief, the plan is that a week or two after migration is over we will run code inspection that detects JUnit 3 style tests that lack @Test annotation and fix these tests if there are any. Does that answer your question? regards, Oleg Vladimir Ozerov wrote > Ed, > > Several questions from my side: > 1) When the change is expected to be merged? > 2) What contributors with opened PRs and new or updated JUnit3 tests are > supposed to do? Rewrite to JUnit4? > > If yes, then we should give them time to have a chance to get used to new > approach and resolve possible conflicts. > > Vladimir. > > пн, 10 дек. 2018 г. в 20:32, Eduard Shangareev > eduard.shangareev@ > : > >> Ivan, >> >> So, suggested actions with the new approach: >> 1. Add @Test annotation on test methods. >> 2. Add @RunWith(JUnit4.class) annotation on test class. >> 3. Add @Before, @After on methods which should run before, after a >> test (setUp, tearDown in current approach). >> 4. Add your test-class to a suite using suite.addTest(new >> JUnit4TestAdapter(YourTestClass.class)); >> 5. Use @Ignore instead fail(); for muting test. >> 6. You could start using @Parametrized instead of inheritance. >> >> >> On Mon, Dec 3, 2018 at 1:15 PM Павлухин Иван > vololo100@ > wrote: >> >> > Hi Oleg, >> > >> > I noticed that GridAbstractTest is now capable to run junit4 tests. >> > What are the current recommendations for writing new tests? Can we use >> > junit4 annotation for new tests? >> > пн, 12 нояб. 2018 г. в 19:58, oignatenko > oignatenko@ > : >> > > >> > > Hi Ivan, >> > > >> > > I am currently testing approach you used in pull/5354 in the "pilot" >> > > sub-task with examples tests (IGNITE-10174). >> > > >> > > So far it looks more and more like the way to go. The most promising >> > thing I >> > > observed is that after I changed classes in our test framework the >> way >> > you >> > > did, execution of (unchanged) examples tests went exactly the same as >> it >> > was >> > > before changes. >> > > >> > > This indicates that existing tests won't be affected making it indeed >> low >> > > risk. >> > > >> > > After that I converted examples tests to Junit 4 by adding @RunWith >> and >> > > @Test annotations and tried a few, and these looked okay. >> > > >> > > Currently I am running full examples test suite and after it is over >> I >> > will >> > > compare results to the reference list I made by running it prior to >> > > migration. >> > > >> > > regards, Oleg >> > > >> > > >> > > >> > > -- >> > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ >> > >> > >> > >> > -- >> > Best regards, >> > Ivan Pavlukhin >> > >> -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: Is it time to move forward to JUnit4 (5)?
Hello, I would like add few minor clarifications to what Ed wrote. 1. After transition to JUnit4 is fully over (ETA this week) there won't be a need to use @RunWith(JUnit4.class) anymore, so you will be writing test classes as a normal JUnit 4 user, without any special scaffolding. 1.1. Please keep in mind that tests that don't inherit from GridAbstractTest can (and I think should) be written full Junit 4 and don't need anything special at all - these are essentially out of scope of this discussion. 2. Note that "full JUnit 4 experience" doesn't apply to part of testsuites that currently use suite() method because in these you would still have to use JUnit4TestAdapter. Unless of course you will choose to rewrite particular suite Junit 4 style (which I would encourage everyone to do, after we complete migration). 3. As a bit of further perspective, we also considering next migration - after all tests will be uniform Junit 4 (instead of current mix of Junit 3 and 4) we will look into whether it is worth migrating to most recent version - JUnit5. Those interested can keep an eye on respective JIRA ticket: https://issues.apache.org/jira/browse/IGNITE-10180 regards, Oleg Eduard Shangareev wrote > Ivan, > > So, suggested actions with the new approach: > 1. Add @Test annotation on test methods. > 2. Add @RunWith(JUnit4.class) annotation on test class. > 3. Add @Before, @After on methods which should run before, after a > test (setUp, tearDown in current approach). > 4. Add your test-class to a suite using suite.addTest(new > JUnit4TestAdapter(YourTestClass.class)); > 5. Use @Ignore instead fail(); for muting test. > 6. You could start using @Parametrized instead of inheritance. > > > On Mon, Dec 3, 2018 at 1:15 PM Павлухин Иван > vololo100@ > wrote: > >> Hi Oleg, >> >> I noticed that GridAbstractTest is now capable to run junit4 tests. >> What are the current recommendations for writing new tests? Can we use >> junit4 annotation for new tests? >> пн, 12 нояб. 2018 г. в 19:58, oignatenko > oignatenko@ > : >> > >> > Hi Ivan, >> > >> > I am currently testing approach you used in pull/5354 in the "pilot" >> > sub-task with examples tests (IGNITE-10174). >> > >> > So far it looks more and more like the way to go. The most promising >> thing I >> > observed is that after I changed classes in our test framework the way >> you >> > did, execution of (unchanged) examples tests went exactly the same as >> it >> was >> > before changes. >> > >> > This indicates that existing tests won't be affected making it indeed >> low >> > risk. >> > >> > After that I converted examples tests to Junit 4 by adding @RunWith and >> > @Test annotations and tried a few, and these looked okay. >> > >> > Currently I am running full examples test suite and after it is over I >> will >> > compare results to the reference list I made by running it prior to >> > migration. >> > >> > regards, Oleg >> > >> > >> > >> > -- >> > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ >> >> >> >> -- >> Best regards, >> Ivan Pavlukhin >> -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
[GitHub] ignite pull request #5615: IGNITE-10177 cleanup Junit 3 from the project
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/5615 IGNITE-10177 cleanup Junit 3 from the project You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10177 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5615.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5615 commit ff4699bebf2571cbd648cbf8bccf1e957c7547e5 Author: Oleg Ignatenko Date: 2018-12-02T23:35:51Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - added @Test -- verified with diffs overview commit a72e24ea010fd7333b7425c349e3de1373aed0fc Author: Oleg Ignatenko Date: 2018-12-03T00:24:34Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit eeeba1cc2f9d9dc02065c19c7c1079008bf73e00 Author: Oleg Ignatenko Date: 2018-12-03T00:26:13Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 9304b5f31ef712708be7d04b68a963d8bf4b050d Author: Oleg Ignatenko Date: 2018-12-03T00:29:51Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 7eaf7a0252fb347f19d192859c410c3c29f7c4b6 Author: Oleg Ignatenko Date: 2018-12-03T00:39:54Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit eaee42ebf611c1617993177d6466e81399c3ebdc Author: Oleg Ignatenko Date: 2018-12-03T00:48:56Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 62738a3820d4057a9c34ad8b2c6e85959ebfc67e Author: Oleg Ignatenko Date: 2018-12-03T00:57:00Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit afb495f9e97e6e15b0c4c29f6d57dd2bbd569f1c Author: Oleg Ignatenko Date: 2018-12-03T08:39:38Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 3b56b742b52a516a4244d2a07635a99d9abeba18 Author: Oleg Ignatenko Date: 2018-12-03T09:06:45Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 3835772a72a99882f9d6cd2557001c9db94ed416 Author: Oleg Ignatenko Date: 2018-12-03T09:31:45Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit ac6be2c4e07748f34da5d83ce3e9f20786ead2fc Author: Oleg Ignatenko Date: 2018-12-03T10:46:59Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 9f663a9c857f76fcb0e56c194cc2d6ec10f6888b Author: Oleg Ignatenko Date: 2018-12-03T11:13:26Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit e2eae3201a88c3d9800b9964ce9ca4096ed3d85f Author: Oleg Ignatenko Date: 2018-12-03T11:31:35Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit f9ccc80de28fb2fc64c96d695f5f906a8cd9a946 Author: Oleg Ignatenko Date: 2018-12-03T12:40:21Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 3eadd0abf6f58a0a3d8fe8464bb08879d412bca1 Author: Oleg Ignatenko Date: 2018-12-03T13:33:00Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 28d9f854993cb99867803cfe0126cf723e071cc5 Author: Oleg Ignatenko Date: 2018-12-03T13:54:52Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit ed54719377f694d0111740c0bbd92dcf5294e6c6 Author: Oleg Ignatenko Date: 2018-12-03T14:10:26Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit fb97a8c23881d1d1c50423dcea6ac519a36c195a Author: Oleg Ignatenko Date: 2018-12-03T14:26:19Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 063f7ae0164924a775b4235ebd0f704017bc2c73 Author: Oleg Ignatenko Date: 2018-12-03T14:45:00Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 17e86cb29c3f3accc65d464a0e0de4f4eac6a19e Author: Oleg Ignatenko Date: 2018-12-03T15:05:01Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified
[GitHub] ignite pull request #5613: IGNITE-10176 migrate non-core modules tests from ...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/5613 IGNITE-10176 migrate non-core modules tests from Junit 3 to 4 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10176 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5613.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5613 commit ff4699bebf2571cbd648cbf8bccf1e957c7547e5 Author: Oleg Ignatenko Date: 2018-12-02T23:35:51Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - added @Test -- verified with diffs overview commit a72e24ea010fd7333b7425c349e3de1373aed0fc Author: Oleg Ignatenko Date: 2018-12-03T00:24:34Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit eeeba1cc2f9d9dc02065c19c7c1079008bf73e00 Author: Oleg Ignatenko Date: 2018-12-03T00:26:13Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 9304b5f31ef712708be7d04b68a963d8bf4b050d Author: Oleg Ignatenko Date: 2018-12-03T00:29:51Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 7eaf7a0252fb347f19d192859c410c3c29f7c4b6 Author: Oleg Ignatenko Date: 2018-12-03T00:39:54Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit eaee42ebf611c1617993177d6466e81399c3ebdc Author: Oleg Ignatenko Date: 2018-12-03T00:48:56Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 62738a3820d4057a9c34ad8b2c6e85959ebfc67e Author: Oleg Ignatenko Date: 2018-12-03T00:57:00Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit afb495f9e97e6e15b0c4c29f6d57dd2bbd569f1c Author: Oleg Ignatenko Date: 2018-12-03T08:39:38Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 3b56b742b52a516a4244d2a07635a99d9abeba18 Author: Oleg Ignatenko Date: 2018-12-03T09:06:45Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 3835772a72a99882f9d6cd2557001c9db94ed416 Author: Oleg Ignatenko Date: 2018-12-03T09:31:45Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit ac6be2c4e07748f34da5d83ce3e9f20786ead2fc Author: Oleg Ignatenko Date: 2018-12-03T10:46:59Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 9f663a9c857f76fcb0e56c194cc2d6ec10f6888b Author: Oleg Ignatenko Date: 2018-12-03T11:13:26Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit e2eae3201a88c3d9800b9964ce9ca4096ed3d85f Author: Oleg Ignatenko Date: 2018-12-03T11:31:35Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit f9ccc80de28fb2fc64c96d695f5f906a8cd9a946 Author: Oleg Ignatenko Date: 2018-12-03T12:40:21Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 3eadd0abf6f58a0a3d8fe8464bb08879d412bca1 Author: Oleg Ignatenko Date: 2018-12-03T13:33:00Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 28d9f854993cb99867803cfe0126cf723e071cc5 Author: Oleg Ignatenko Date: 2018-12-03T13:54:52Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit ed54719377f694d0111740c0bbd92dcf5294e6c6 Author: Oleg Ignatenko Date: 2018-12-03T14:10:26Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit fb97a8c23881d1d1c50423dcea6ac519a36c195a Author: Oleg Ignatenko Date: 2018-12-03T14:26:19Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 063f7ae0164924a775b4235ebd0f704017bc2c73 Author: Oleg Ignatenko Date: 2018-12-03T14:45:00Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 17e86cb29c3f3accc65d464a0e0de4f4eac6a19e Author: Oleg Ignatenko Date: 2018-12-03T15:05:01Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating
Re: Change code style inspections to use red mark for those used at Teamcity build checks (IGNITE-10450)
Following up prior discussion in this thread, suggested changes were merged to master as a part of IGNITE-10422 and are now included in project default inspections profile. Thanks to Maxim and Dmitriy for making it happen. As for the ticket IGNITE-10450, I plan to keep it open for a little while for just the case if we quickly decide to do some adjustments. Then I plan to close it (assuming that if we will want to change something later this could be done per new tickets). regards, Oleg -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
[GitHub] ignite pull request #5562: IGNITE-10175 migrate core module tests from Junit...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/5562 IGNITE-10175 migrate core module tests from Junit 3 to 4 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10175 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5562.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5562 commit ff4699bebf2571cbd648cbf8bccf1e957c7547e5 Author: Oleg Ignatenko Date: 2018-12-02T23:35:51Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - added @Test -- verified with diffs overview commit a72e24ea010fd7333b7425c349e3de1373aed0fc Author: Oleg Ignatenko Date: 2018-12-03T00:24:34Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit eeeba1cc2f9d9dc02065c19c7c1079008bf73e00 Author: Oleg Ignatenko Date: 2018-12-03T00:26:13Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 9304b5f31ef712708be7d04b68a963d8bf4b050d Author: Oleg Ignatenko Date: 2018-12-03T00:29:51Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 7eaf7a0252fb347f19d192859c410c3c29f7c4b6 Author: Oleg Ignatenko Date: 2018-12-03T00:39:54Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit eaee42ebf611c1617993177d6466e81399c3ebdc Author: Oleg Ignatenko Date: 2018-12-03T00:48:56Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 62738a3820d4057a9c34ad8b2c6e85959ebfc67e Author: Oleg Ignatenko Date: 2018-12-03T00:57:00Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit afb495f9e97e6e15b0c4c29f6d57dd2bbd569f1c Author: Oleg Ignatenko Date: 2018-12-03T08:39:38Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 3b56b742b52a516a4244d2a07635a99d9abeba18 Author: Oleg Ignatenko Date: 2018-12-03T09:06:45Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 3835772a72a99882f9d6cd2557001c9db94ed416 Author: Oleg Ignatenko Date: 2018-12-03T09:31:45Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit ac6be2c4e07748f34da5d83ce3e9f20786ead2fc Author: Oleg Ignatenko Date: 2018-12-03T10:46:59Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 9f663a9c857f76fcb0e56c194cc2d6ec10f6888b Author: Oleg Ignatenko Date: 2018-12-03T11:13:26Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit e2eae3201a88c3d9800b9964ce9ca4096ed3d85f Author: Oleg Ignatenko Date: 2018-12-03T11:31:35Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit f9ccc80de28fb2fc64c96d695f5f906a8cd9a946 Author: Oleg Ignatenko Date: 2018-12-03T12:40:21Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 3eadd0abf6f58a0a3d8fe8464bb08879d412bca1 Author: Oleg Ignatenko Date: 2018-12-03T13:33:00Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 28d9f854993cb99867803cfe0126cf723e071cc5 Author: Oleg Ignatenko Date: 2018-12-03T13:54:52Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit ed54719377f694d0111740c0bbd92dcf5294e6c6 Author: Oleg Ignatenko Date: 2018-12-03T14:10:26Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit fb97a8c23881d1d1c50423dcea6ac519a36c195a Author: Oleg Ignatenko Date: 2018-12-03T14:26:19Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 063f7ae0164924a775b4235ebd0f704017bc2c73 Author: Oleg Ignatenko Date: 2018-12-03T14:45:00Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 17e86cb29c3f3accc65d464a0e0de4f4eac6a19e Author: Oleg Ignatenko Date: 2018-12-03T15:05:01Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating
[GitHub] ignite pull request #5382: IGNITE-10200 GridCacheSetAbstractSelfTest#testMul...
Github user oignatenko closed the pull request at: https://github.com/apache/ignite/pull/5382 ---
Re: Change code style inspections to use red mark for those used at Teamcity build checks (IGNITE-10450)
Hi Ivan, Павлухин Иван wrote > P.S. Did not really get what was the main problem related to > IGNITE-10399 [1]. I suppose it should go: simple problem -- fast fix. Well, speaking of IGNITE-10399 it turned out that problem is indeed simple and fix was fast, just as you wrote. What looked wrong is that discovery of the problem took quite long and it turned out to be too much effort for such a simple problem and fix. To start with, it is essentially impossible to find out when coding. You can see why is that at screen shot reproducing how missing import looked like in the file that caused this issue (attached to IGNITE-10450): https://issues.apache.org/jira/secure/attachment/12950020/IDEA.inspections.TC-bot.obscured.png Please notice how mark denoting troublesome inspection violation is buried among non-critical ones which makes it very easy to miss when coding. Another problem is, the only reliable way to tell if there is an issue is to run Teamcity checks. Which means one needs to push and wait for quite a while to just find out if there is a problem or not (note by the way how this way breaks if one is working offline or if Teamcity server is down / busy for some reason). And this is not yet the end - even when you learn that some inspection failed somewhere there is no easy way to just get back to your code and find it - because as you can see from above screen shot the problem is obscured too much to notice. One needs to get to Teamcity report and read details of the failure to find out where to look for it. Above sounds a bit too much for finding and fixing a simple missing import isn't it? Do we really need to push, launch TC checks, wait for completion and read detailed report to simply find out an issue that was already reported and highlighted in IDE before all that, only hard to notice. --- When I realized that I thought maybe I would prefer if IDE could highlight such inspections more prominently to let me find it just when I introduce them during coding, without cumbersome messing with Teamcity checks and reports and I went to Maxim and he helped me find how this could be done. And after checking how it would work I created IGNITE-10450 for us to try this way - because it looked so much more convenient compared to what I observed in IGNITE-10399. regards Oleg -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: Change code style inspections to use red mark for those used at Teamcity build checks (IGNITE-10450)
Hi Ivan, You are right that these things will distract people and from this perspective it is very well justified that vast majority of style deviations (currently, all of them) are marked yellow. These are non-critical and if developer ignores them nothing immediately bad happens. (For the sake of completeness one can argue that style deviations contribute to technical debt but it's tangential to current discussion and here we can probably consider them just harmless for simplicity.) The problem with five of these inspections that are proposed to change is, these became different after IGNITE-9983 and above reasoning doesn't work for these anymore. These five inspections are now checked at Teamcity and when there are new deviations it reports problems. Essentially this means that developer introducing new violations in these inspections is going to be distracted anyway - if they ignore at the coding phase they still will be chased by the warnings from Teamcity. You can check details of IGNITE-10399 because it shows a good example of how it goes. So what we're discussing here is essentially not about whether to distract developer or not (because they will be distracted anyway) but when it is more convenient to distract - at coding time or after Teamcity check. Granted, delaying this to TC checks felt okay to me before we tried it but observing how it really goes (in mentioned above IGNITE-10399) made me curious if maybe we could try another option by raising this issue at coding time instead. This is the whole point of this change, to let us try how it would go if we warn developers about inspections impacting Teamcity in the time of coding. As I wrote in beginning of this thread I briefly tried it myself and it looked quite promising. To avoid misunderstanding, I would like to make it clear that at this point it is not supposed to be a one way change because my testing was too brief to say for sure if this is the way to go. Current plan is that we give it a try for a while and later - depending on how folks feel - decide whether to keep these inspections red or revert them back to yellow. Does that make sense Ivan? regards, Oleg -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: Change code style inspections to use red mark for those used at Teamcity build checks (IGNITE-10450)
Hi Dmitry, When we had preliminary discussion of this with Maxim we both were inclined to post it here and let it hang for a while to let dev list folks discuss this idea in more details for just in case if we missed some usability implications. Though now that you mentioned it I figured that proposed change is low risk and easy to rollback, meaning we can do it the other way round: just merge it now and keep in mind an option to revert if further discussion here shows that this way is wrong for some reason. If you prefer that we pick this way, changing priorities for TC inspections could even be done as a part of another ticket involving this config file, IGNITE-10422 - you can probably discuss with Maxim if he would be comfortable with that (last time I checked he planned to do implementation there). regards, Oleg -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Change code style inspections to use red mark for those used at Teamcity build checks (IGNITE-10450)
Hello, When discussing issues involved in IGNITE-10399 we have got an idea to change color highlighting of some code style inspections to make it easier to see which can lead to problems at Teamcity. - Screen shot of how it is supposed to work: https://issues.apache.org/jira/secure/attachment/12949868/IDEA.inspections.TC-bot.png ^^^ Violations of inspections used by TC are shown as red in IDEA Error Stripe while the rest remains yellow, looks easy to tell one from another. (It's probably not very important but for the sake of completeness a thing I noticed when testing this is that having red inspections didn't block compilation and execution of the code.) - JIRA ticket to change inspections: https://issues.apache.org/jira/browse/IGNITE-10450 - Prior discussions related to inspections checks at Teamcity: http://apache-ignite-developers.2346864.n4.nabble.com/Code-inspection-tp27709.html Your feedback is welcome. TIA, regards, Oleg PS. Special thanks to Maxim Muzafarov for help in brainstorming this matter and in drafting JIRA ticket. -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: [MTCGA]: new failures in builds [2381922] needs to be handled
Hi Dmitry, You are right - these failures are expected to be muted, I updated Teamcity to account for that. regards, Oleg PS. Readers interested in more details on that matter can find detailed discussion in comments of JIRA ticket IGNITE-10174: https://issues.apache.org/jira/browse/IGNITE-10174?focusedCommentId=16692971=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16692971 "difference in how empty test classes are reported when tests are run..." etc -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
[GitHub] ignite pull request #5460: IGNITE-10191 Incorrect comparison of lists in Ren...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/5460 IGNITE-10191 Incorrect comparison of lists in RendezvousAffinityFunctionSimpleBenchmark#testAffinityCompatibility You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10191 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5460.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5460 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fd6b659bb8be1992618ce4ce91f568a0988b3afa Author: Oleg Ignatenko Date: 2018-09-02T06:11:42Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944 Author: Oleg Ignatenko Date: 2018-09-03T10:27:35Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf Author: Oleg Ignatenko Date: 2018-09-04T09:49:44Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5 Author: Oleg Ignatenko Date: 2018-09-05T10:50:28Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2 Author: Oleg Ignatenko Date: 2018-09-05T11:45:58Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 480ed78869277d7e32f725ab71bec9621f1ac03a Author: Oleg Ignatenko Date: 2018-09-06T07:52:55Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit c99762498f617c0e98ea3062a43c0b30092166ef Author: Oleg Ignatenko Date: 2018-09-06T14:45:04Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 2e17175225c72f747d370b5fee96f8be69d6d2cb Author: Oleg Ignatenko Date: 2018-09-06T17:33:54Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f Author: Oleg Ignatenko Date:
[GitHub] ignite pull request #5435: temporary PR to verify renamed tests on Teamcity ...
Github user oignatenko closed the pull request at: https://github.com/apache/ignite/pull/5435 ---
[GitHub] ignite pull request #5435: temporary PR to verify renamed tests on Teamcity ...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/5435 temporary PR to verify renamed tests on Teamcity for review of 10174 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-renamed-tests-10174 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5435.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5435 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fd6b659bb8be1992618ce4ce91f568a0988b3afa Author: Oleg Ignatenko Date: 2018-09-02T06:11:42Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944 Author: Oleg Ignatenko Date: 2018-09-03T10:27:35Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf Author: Oleg Ignatenko Date: 2018-09-04T09:49:44Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5 Author: Oleg Ignatenko Date: 2018-09-05T10:50:28Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2 Author: Oleg Ignatenko Date: 2018-09-05T11:45:58Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 480ed78869277d7e32f725ab71bec9621f1ac03a Author: Oleg Ignatenko Date: 2018-09-06T07:52:55Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit c99762498f617c0e98ea3062a43c0b30092166ef Author: Oleg Ignatenko Date: 2018-09-06T14:45:04Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 2e17175225c72f747d370b5fee96f8be69d6d2cb Author: Oleg Ignatenko Date: 2018-09-06T17:33:54Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f Author: Oleg Ignatenko Date: 2018-09-07T13:38:51Z Me
[GitHub] ignite pull request #5434: IGNITE-10335 move ML examples datasets files to r...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/5434 IGNITE-10335 move ML examples datasets files to resources You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10335 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5434.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5434 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fd6b659bb8be1992618ce4ce91f568a0988b3afa Author: Oleg Ignatenko Date: 2018-09-02T06:11:42Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944 Author: Oleg Ignatenko Date: 2018-09-03T10:27:35Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf Author: Oleg Ignatenko Date: 2018-09-04T09:49:44Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5 Author: Oleg Ignatenko Date: 2018-09-05T10:50:28Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2 Author: Oleg Ignatenko Date: 2018-09-05T11:45:58Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 480ed78869277d7e32f725ab71bec9621f1ac03a Author: Oleg Ignatenko Date: 2018-09-06T07:52:55Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit c99762498f617c0e98ea3062a43c0b30092166ef Author: Oleg Ignatenko Date: 2018-09-06T14:45:04Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 2e17175225c72f747d370b5fee96f8be69d6d2cb Author: Oleg Ignatenko Date: 2018-09-06T17:33:54Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f Author: Oleg Ignatenko Date: 2018-09-07T13:38:51Z Merge branch 'master' of https://
Re: Time to remove automated messages from the devlist?
Personally I am comfortable with the way how things are now because mail filters appear to work well for me. However this thread made me curious about whether ASF has some guidance or recommendations on that matter. I searched quite a bit and found none of that kind. It looks like Apache leaves it at discretion of the project community to decide whether to make separate list for automated messages or not (which made a fairly good sense after I gave it a bit more thought, see below). --- After that I decided to check how other Apache projects manage their mailing lists and as far as I can tell most active ones tend to have separate mailing lists for automatic notifications from version control and / or issue tracker. I checked few top projects by number of committers from the list here: https://projects.apache.org/projects.html?number - specifically top 8 that had over 80 committers (for comparison, this list currently says Ignite has 38, I think we're fairly close to that league). - https://hadoop.apache.org/mailing_lists.html https://openoffice.apache.org/mailing-lists.html http://cloudstack.apache.org/mailing-lists.html http://ambari.apache.org/mail-lists.html ---> Separate lists for commits and for issue tracker. - http://geode.apache.org/community/#mailing-lists https://cordova.apache.org/contact/ http://subversion.apache.org/mailing-lists.html http://hive.apache.org/mailing_lists.html ---> Separate list for commits. For the sake of completeness I also sampled 4 projects having 38 committers, just like Ignite. - http://chemistry.apache.org/project/community.html ---> No lists for commits nor issues. - http://ctakes.apache.org/mailing.html ---> Separate list for commits. - http://metron.apache.org/community/ ---> Separate list for issues. - https://orc.apache.org/develop/ ---> Separate lists for commits and for issue tracker. --- Based on my personal experience this issue looks to some extent a matter of whether we consider some barrier for entry to dev list desirable or not. I could not actively use list until I learned how to setup mail filters because it was difficult to find discussions to participate. On the other hand, after setting these filters it turned out very easy. So the question is, do we want to have dev list easier or harder to use for "passers by" who aren't deeply involved in project. If we want to keep it strictly at top experience level, then we better keep all automated messages in. If we want it welcoming for any random passer by, then we better move all automated messages somewhere else. And there are of course intermediate approaches, we can basically tune ease of entry by picking which part of automated messages will stay and which will go away. --- Another important thing I learned when studying mailing lists of other projects is we better take into account that regular automated messages may help in keeping dev list "lively" in the slow times, when there are little to none discussions. At first I was tempted to propose moving all the automated messages outside - "just like big boys do" - note how top 4 projects in my list all have commits and issues in separate lists. But looking how smaller projects tend to handle it differently made me wonder if maybe it is a bit more complicated, maybe there is some difference worth considering. And as far as I can tell, the important difference is size of community / amount of committers. When there are lots of people actively involved in the project it is very likely that they can permanently maintain dev list active by natural discussions. But when the project is smaller, there is a substantial risk that sometimes most active developers are focused on issue tracker or github which means dev list may look abandoned (if it contains only discussions). If there is such a risk then keeping some (not necessarily all) automated messages in dev list will help its subscribers and visitors avoid misleading impression of "abandoned empty place" by showing that the project is indeed actively maintained. regards, Oleg -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
[GitHub] ignite pull request #5382: IGNITE-10200 GridCacheSetAbstractSelfTest#testMul...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/5382 IGNITE-10200 GridCacheSetAbstractSelfTest#testMultipleStructuresInDifferentGroups and some other tests are incorrectly muted You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10200 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5382.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5382 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fd6b659bb8be1992618ce4ce91f568a0988b3afa Author: Oleg Ignatenko Date: 2018-09-02T06:11:42Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944 Author: Oleg Ignatenko Date: 2018-09-03T10:27:35Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf Author: Oleg Ignatenko Date: 2018-09-04T09:49:44Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5 Author: Oleg Ignatenko Date: 2018-09-05T10:50:28Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2 Author: Oleg Ignatenko Date: 2018-09-05T11:45:58Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 480ed78869277d7e32f725ab71bec9621f1ac03a Author: Oleg Ignatenko Date: 2018-09-06T07:52:55Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit c99762498f617c0e98ea3062a43c0b30092166ef Author: Oleg Ignatenko Date: 2018-09-06T14:45:04Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 2e17175225c72f747d370b5fee96f8be69d6d2cb Author: Oleg Ignatenko Date: 2018-09-06T17:33:54Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f Author: Oleg Ignat
[GitHub] ignite pull request #5369: IGNITE-10174 migrate examples tests from Junit 3 ...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/5369 IGNITE-10174 migrate examples tests from Junit 3 to 4 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10174 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5369.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5369 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fd6b659bb8be1992618ce4ce91f568a0988b3afa Author: Oleg Ignatenko Date: 2018-09-02T06:11:42Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944 Author: Oleg Ignatenko Date: 2018-09-03T10:27:35Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf Author: Oleg Ignatenko Date: 2018-09-04T09:49:44Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5 Author: Oleg Ignatenko Date: 2018-09-05T10:50:28Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2 Author: Oleg Ignatenko Date: 2018-09-05T11:45:58Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 480ed78869277d7e32f725ab71bec9621f1ac03a Author: Oleg Ignatenko Date: 2018-09-06T07:52:55Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit c99762498f617c0e98ea3062a43c0b30092166ef Author: Oleg Ignatenko Date: 2018-09-06T14:45:04Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 2e17175225c72f747d370b5fee96f8be69d6d2cb Author: Oleg Ignatenko Date: 2018-09-06T17:33:54Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f Author: Oleg Ignatenko Date: 2018-09-07T13:38:51Z Merge branch 'master' of https://
Re: Is it time to move forward to JUnit4 (5)?
Hi Ivan, I am currently testing approach you used in pull/5354 in the "pilot" sub-task with examples tests (IGNITE-10174). So far it looks more and more like the way to go. The most promising thing I observed is that after I changed classes in our test framework the way you did, execution of (unchanged) examples tests went exactly the same as it was before changes. This indicates that existing tests won't be affected making it indeed low risk. After that I converted examples tests to Junit 4 by adding @RunWith and @Test annotations and tried a few, and these looked okay. Currently I am running full examples test suite and after it is over I will compare results to the reference list I made by running it prior to migration. regards, Oleg -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: Is it time to move forward to JUnit4 (5)?
Hi Jörn, Agree, it is also my understanding that after we migrate part of the tests that still use JUnit 3 (https://issues.apache.org/jira/browse/IGNITE-10173), upgrade to next version is going to be easy and low risk. With regards to asserting exceptions I think you have a good point here, I used JUnit 5 in one of recent projects and liked the way how it handles this. It felt much more convenient than in JUnit 4. regards, Oleg -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
[GitHub] ignite pull request #5359: IGNITE-10209 some tests in IgniteExamplesMLTestSu...
Github user oignatenko closed the pull request at: https://github.com/apache/ignite/pull/5359 ---
[GitHub] ignite pull request #5359: IGNITE-10209 some tests in IgniteExamplesMLTestSu...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/5359 IGNITE-10209 some tests in IgniteExamplesMLTestSuite fail with FileNotFoundException You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10209 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5359.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5359 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fd6b659bb8be1992618ce4ce91f568a0988b3afa Author: Oleg Ignatenko Date: 2018-09-02T06:11:42Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944 Author: Oleg Ignatenko Date: 2018-09-03T10:27:35Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf Author: Oleg Ignatenko Date: 2018-09-04T09:49:44Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5 Author: Oleg Ignatenko Date: 2018-09-05T10:50:28Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2 Author: Oleg Ignatenko Date: 2018-09-05T11:45:58Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 480ed78869277d7e32f725ab71bec9621f1ac03a Author: Oleg Ignatenko Date: 2018-09-06T07:52:55Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit c99762498f617c0e98ea3062a43c0b30092166ef Author: Oleg Ignatenko Date: 2018-09-06T14:45:04Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 2e17175225c72f747d370b5fee96f8be69d6d2cb Author: Oleg Ignatenko Date: 2018-09-06T17:33:54Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f Author: Oleg Ignatenko Date: 2018-09-07T13:38:51Z Me
Re: Is it time to move forward to JUnit4 (5)?
Hi Ivan, That's a very good question. I would say the primary motivation in the task we discuss is to make the change at the minimal cost and risk. Or, as stated in description of IGNITE-10173 "move... gradually, smoothly and safely". With this in mind I would say that main expected benefit is laid out at the top of ticket description: > Currently unit tests in the project are mix of two versions Junit 3 and 4. > This makes it hard to develop and maintain. Making all tests use the same > version Junit is intended to address this problem. Above goal is probably modest but given that this change is expected to take minimal effort it looks good enough for me. On a more general note I don't expect strong technical benefits of this change, at least not immediately. This is based on my studies of prior discussions related to this matter and of the existing tests. I believe that if there were any strong and obvious technical benefits we would be long aware of these and we would migrate to newer Junit long time ago. Observing that migration hasn't happened - despite JUnit 3 being obsolete for over 10 years now, and despite many more fundamental changes that successfully made it to Ignite in past years - it looks natural to assume that there are just no technical reasons that would be strong enough to justify investing much effort in the migration. --- Now about your experiment at ignite/pull/5354, I briefly skimmed it and here are some initial impressions. First the bad news, some parts look indeed "insane" to me. I am talking specifically about renames in CacheMvccDmlSimpleTest and changes to test design in IgniteCacheCommitDelayTxRecoveryTest. I believe that these are wildly out of scope of the discussed change because I firmly want to keep it limited to absolute minimum of changes (ideally only annotations with involved imports). This is because there are just too many tests to (manually) change. My rough estimate is there about 7,000 (seven thousands!) test cases to change in core module alone; and I guess there are few thousands more in other parts of the project. Doing any extra changes to these tests makes things much more complicated, effort consuming and risky than was initially supposed. On a brighter side, changes made to GridAbstractTest look worth further studying. At this point I still prefer to keep this class unchanged (because this gives us a bulletproof guarantee against regressions in all prior tests) but this may change after we do "pilot" changes to examples tests (IGNITE-10174). These pilot changes will help us estimate with concrete code how much effort could be involved in maintaining "twin" classes in sync (you are absolutely right pointing that this is concerning). If it turns out too complicated to sync we would probably switch to something like you have done in pull/5354 regards, Oleg Павлухин Иван wrote > Hi Oleg, > > Migrating to Junit 4 sounds as great idea. I believe everybody > is quite surprised when finds Junit 3 in Ignite. > But for me personally it is good to understand what problem we > are trying to solve? What benefits will Junit 4 give us? What are > the most painful moments with current testing framework? > (I my mind I draw a proposal which contains sections "Motivation", > "Alternatives", etc.) > > Also I must say that I made some experiments related to Junit4 > migration. And from the first glance it seems that the most > important Ignite test framework classes contain a huge amount of > utility methods and a little amount of code related to a test lifecycle. > These classes are GridAbstractTest and GridCommonAbstractTest. > Both are quite thick, but as already said it is mostly utility code > which could be extracted. I would be great to come to very thin base > test classes (or even to baseclass-less tests at all) and include all > kind of utilities without inheritance. > > But massive refactoring perhaps is more for future. The main point > here is that Ignite test framework is not complex at all and could be > easily adopted to Junit 4. > > Regarding twin classes. How to keep them in sync? If the migration > process will be paused halfway it could make things complicated in > future. > > Additionally, I have a wild idea how to marry junit 3 and 4 without > introducing twins. The idea looks ugly from OOP perspective, but > here it is. We can simply annotate overridden Junit 3 setUp and > tearDown methods with @Before and @After annotations. And > use runTest overridden method for Junit 3 and TestRule for Junit 4 > in order to run test methods in newly started thread. > > For all details you can see an experiment on github [1]. Among them > are ticks with @RunWith annotation making possible to run a test > inherited from TestCase as Junit 4 test. Still, I
Re: Is it time to move forward to JUnit4 (5)?
Hi Vyacheslav, GridCommonAbstractTest is expected to change too. As pointed in IGNITE-10173 our approach involves all the subclasses of GridAbstractTest - including but not limited to one you mentioned (GridCommonAbstractTest). regards, Oleg -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Re: Is it time to move forward to JUnit4 (5)?
Hello, I created JIRA task for this move, with detailed explanation and step-by-step subtasks, your comments are welcome: - https://issues.apache.org/jira/browse/IGNITE-10173 In brief, the plan is to gradually migrate the part of tests that still uses Junit 3 (hundreds if not thousands of those that depend on GridAbstractTest and its subclasses) to newer version. The trick proposed to avoid doing all this in one (big and risky) step is to introduce a Junit4-based "twin" of GridAbstractTest (and respective twins of its subclasses) and use it to gradually change tests to use that newer API instead. After above is over, Junit 3 and all its related stuff (including GridAbstractTest) could be safely removed from project. regards, Oleg -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
[GitHub] ignite pull request #5344: IGNITE-10158 Some tests in IgniteCacheAbstractQue...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/5344 IGNITE-10158 Some tests in IgniteCacheAbstractQuerySelfTest are incorrectly muted You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10158 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5344.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5344 commit fa7662e7fbc410a5064815f16838e0ef91b0683b Author: Alexey Platonov Date: 2018-11-07T11:53:58Z init commit commit 2afea369eaf285c3d42c377c46161a5041ab0bb0 Author: Alexey Platonov Date: 2018-11-07T11:56:23Z Merge branch 'master' of https://github.com/apache/ignite into ignite-10159 commit ac6414e0c5a2e2b6fe75b6b170fb988421ca1c5d Author: Oleg Ignatenko Date: 2018-11-07T14:14:22Z IGNITE-10158 Some tests in IgniteCacheAbstractQuerySelfTest are incorrectly muted - fixed as suggested in the ticket -- verified with diffs overview, clean rebuild and trial execution of modified tests on my machine ---
[GitHub] ignite pull request #5055: IGNITE-9884 Some tests are incorrectly muted
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/5055 IGNITE-9884 Some tests are incorrectly muted You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9884 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5055.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5055 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fd6b659bb8be1992618ce4ce91f568a0988b3afa Author: Oleg Ignatenko Date: 2018-09-02T06:11:42Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944 Author: Oleg Ignatenko Date: 2018-09-03T10:27:35Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf Author: Oleg Ignatenko Date: 2018-09-04T09:49:44Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5 Author: Oleg Ignatenko Date: 2018-09-05T10:50:28Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2 Author: Oleg Ignatenko Date: 2018-09-05T11:45:58Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 480ed78869277d7e32f725ab71bec9621f1ac03a Author: Oleg Ignatenko Date: 2018-09-06T07:52:55Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit c99762498f617c0e98ea3062a43c0b30092166ef Author: Oleg Ignatenko Date: 2018-09-06T14:45:04Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 2e17175225c72f747d370b5fee96f8be69d6d2cb Author: Oleg Ignatenko Date: 2018-09-06T17:33:54Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f Author: Oleg Ignatenko Date: 2018-09-07T13:38:51Z Merge branch 'master' of https://github.com/apa
[GitHub] ignite pull request #5036: IGNITE-9884 Some tests are incorrectly muted
Github user oignatenko closed the pull request at: https://github.com/apache/ignite/pull/5036 ---
[GitHub] ignite pull request #5036: IGNITE-9884 Some tests are incorrectly muted
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/5036 IGNITE-9884 Some tests are incorrectly muted You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9884 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5036.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5036 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fd6b659bb8be1992618ce4ce91f568a0988b3afa Author: Oleg Ignatenko Date: 2018-09-02T06:11:42Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944 Author: Oleg Ignatenko Date: 2018-09-03T10:27:35Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf Author: Oleg Ignatenko Date: 2018-09-04T09:49:44Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5 Author: Oleg Ignatenko Date: 2018-09-05T10:50:28Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2 Author: Oleg Ignatenko Date: 2018-09-05T11:45:58Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 480ed78869277d7e32f725ab71bec9621f1ac03a Author: Oleg Ignatenko Date: 2018-09-06T07:52:55Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit c99762498f617c0e98ea3062a43c0b30092166ef Author: Oleg Ignatenko Date: 2018-09-06T14:45:04Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 2e17175225c72f747d370b5fee96f8be69d6d2cb Author: Oleg Ignatenko Date: 2018-09-06T17:33:54Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f Author: Oleg Ignatenko Date: 2018-09-07T13:38:51Z Merge branch 'master' of https://github.com/apa
[GitHub] ignite pull request #5001: IGNITE-9884 Some tests are incorrectly muted
Github user oignatenko closed the pull request at: https://github.com/apache/ignite/pull/5001 ---
[GitHub] ignite pull request #5001: IGNITE-9884 Some tests are incorrectly muted
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/5001 IGNITE-9884 Some tests are incorrectly muted You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9884 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5001.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5001 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fd6b659bb8be1992618ce4ce91f568a0988b3afa Author: Oleg Ignatenko Date: 2018-09-02T06:11:42Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944 Author: Oleg Ignatenko Date: 2018-09-03T10:27:35Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf Author: Oleg Ignatenko Date: 2018-09-04T09:49:44Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5 Author: Oleg Ignatenko Date: 2018-09-05T10:50:28Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2 Author: Oleg Ignatenko Date: 2018-09-05T11:45:58Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 480ed78869277d7e32f725ab71bec9621f1ac03a Author: Oleg Ignatenko Date: 2018-09-06T07:52:55Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit c99762498f617c0e98ea3062a43c0b30092166ef Author: Oleg Ignatenko Date: 2018-09-06T14:45:04Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 2e17175225c72f747d370b5fee96f8be69d6d2cb Author: Oleg Ignatenko Date: 2018-09-06T17:33:54Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f Author: Oleg Ignatenko Date: 2018-09-07T13:38:51Z Merge branch 'master' of https://github.com/apa
[GitHub] ignite pull request #4992: IGNITE-9884 Some tests are incorrectly muted
Github user oignatenko closed the pull request at: https://github.com/apache/ignite/pull/4992 ---
[GitHub] ignite pull request #4992: IGNITE-9884 Some tests are incorrectly muted
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/4992 IGNITE-9884 Some tests are incorrectly muted You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9884 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4992.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4992 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fd6b659bb8be1992618ce4ce91f568a0988b3afa Author: Oleg Ignatenko Date: 2018-09-02T06:11:42Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944 Author: Oleg Ignatenko Date: 2018-09-03T10:27:35Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf Author: Oleg Ignatenko Date: 2018-09-04T09:49:44Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5 Author: Oleg Ignatenko Date: 2018-09-05T10:50:28Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2 Author: Oleg Ignatenko Date: 2018-09-05T11:45:58Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 480ed78869277d7e32f725ab71bec9621f1ac03a Author: Oleg Ignatenko Date: 2018-09-06T07:52:55Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit c99762498f617c0e98ea3062a43c0b30092166ef Author: Oleg Ignatenko Date: 2018-09-06T14:45:04Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 2e17175225c72f747d370b5fee96f8be69d6d2cb Author: Oleg Ignatenko Date: 2018-09-06T17:33:54Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f Author: Oleg Ignatenko Date: 2018-09-07T13:38:51Z Merge branch 'master' of https://github.com/apa
[GitHub] ignite pull request #4882: IGNITE-9754 Increase timeout waiting for commitLa...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/4882 IGNITE-9754 Increase timeout waiting for commitLatch in testRollbackOnTopologyLockPessimistic You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9754 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4882.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4882 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fd6b659bb8be1992618ce4ce91f568a0988b3afa Author: Oleg Ignatenko Date: 2018-09-02T06:11:42Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944 Author: Oleg Ignatenko Date: 2018-09-03T10:27:35Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf Author: Oleg Ignatenko Date: 2018-09-04T09:49:44Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5 Author: Oleg Ignatenko Date: 2018-09-05T10:50:28Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2 Author: Oleg Ignatenko Date: 2018-09-05T11:45:58Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 480ed78869277d7e32f725ab71bec9621f1ac03a Author: Oleg Ignatenko Date: 2018-09-06T07:52:55Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit c99762498f617c0e98ea3062a43c0b30092166ef Author: Oleg Ignatenko Date: 2018-09-06T14:45:04Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 2e17175225c72f747d370b5fee96f8be69d6d2cb Author: Oleg Ignatenko Date: 2018-09-06T17:33:54Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f Author: Oleg Ignatenko Date: 2018-09-07T13:38:51Z
[GitHub] ignite pull request #4853: IGNITE-9721 NPE in IgniteAuthenticationProcessor$...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/4853 IGNITE-9721 NPE in IgniteAuthenticationProcessor$RefreshUsersStorageWorker.body You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9721 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4853.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4853 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fd6b659bb8be1992618ce4ce91f568a0988b3afa Author: Oleg Ignatenko Date: 2018-09-02T06:11:42Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944 Author: Oleg Ignatenko Date: 2018-09-03T10:27:35Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf Author: Oleg Ignatenko Date: 2018-09-04T09:49:44Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5 Author: Oleg Ignatenko Date: 2018-09-05T10:50:28Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2 Author: Oleg Ignatenko Date: 2018-09-05T11:45:58Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 480ed78869277d7e32f725ab71bec9621f1ac03a Author: Oleg Ignatenko Date: 2018-09-06T07:52:55Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit c99762498f617c0e98ea3062a43c0b30092166ef Author: Oleg Ignatenko Date: 2018-09-06T14:45:04Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 2e17175225c72f747d370b5fee96f8be69d6d2cb Author: Oleg Ignatenko Date: 2018-09-06T17:33:54Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f Author: Oleg Ignatenko Date: 2018-09-07T13:38:51Z Merge bran
[GitHub] ignite pull request #4828: IGNITE-9691 testConcurrentAuthorize uses outdated...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/4828 IGNITE-9691 testConcurrentAuthorize uses outdated assumption about exception message You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9691 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4828.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4828 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fd6b659bb8be1992618ce4ce91f568a0988b3afa Author: Oleg Ignatenko Date: 2018-09-02T06:11:42Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944 Author: Oleg Ignatenko Date: 2018-09-03T10:27:35Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf Author: Oleg Ignatenko Date: 2018-09-04T09:49:44Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5 Author: Oleg Ignatenko Date: 2018-09-05T10:50:28Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2 Author: Oleg Ignatenko Date: 2018-09-05T11:45:58Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 480ed78869277d7e32f725ab71bec9621f1ac03a Author: Oleg Ignatenko Date: 2018-09-06T07:52:55Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit c99762498f617c0e98ea3062a43c0b30092166ef Author: Oleg Ignatenko Date: 2018-09-06T14:45:04Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 2e17175225c72f747d370b5fee96f8be69d6d2cb Author: Oleg Ignatenko Date: 2018-09-06T17:33:54Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f Author: Oleg Ignatenko Date: 2018-09-07T13:38:51Z Me
[GitHub] ignite pull request #4774: Ignite 8619 experimental
Github user oignatenko closed the pull request at: https://github.com/apache/ignite/pull/4774 ---
[GitHub] ignite pull request #4774: Ignite 8619 experimental
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/4774 Ignite 8619 experimental Temporary PR to try out particular test change at Teamcity You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8619-experimental Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4774.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4774 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fd6b659bb8be1992618ce4ce91f568a0988b3afa Author: Oleg Ignatenko Date: 2018-09-02T06:11:42Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944 Author: Oleg Ignatenko Date: 2018-09-03T10:27:35Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf Author: Oleg Ignatenko Date: 2018-09-04T09:49:44Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5 Author: Oleg Ignatenko Date: 2018-09-05T10:50:28Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2 Author: Oleg Ignatenko Date: 2018-09-05T11:45:58Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 480ed78869277d7e32f725ab71bec9621f1ac03a Author: Oleg Ignatenko Date: 2018-09-06T07:52:55Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit c99762498f617c0e98ea3062a43c0b30092166ef Author: Oleg Ignatenko Date: 2018-09-06T14:45:04Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 2e17175225c72f747d370b5fee96f8be69d6d2cb Author: Oleg Ignatenko Date: 2018-09-06T17:33:54Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f Author: Oleg Ignatenko Date: 2018-09-07T13:38:51Z
[GitHub] ignite pull request #4760: Ignite 9585 experimental
Github user oignatenko closed the pull request at: https://github.com/apache/ignite/pull/4760 ---
[GitHub] ignite pull request #4760: Ignite 9585 experimental
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/4760 Ignite 9585 experimental temporary branch and PR for experimenting for Teamcity You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9585-experimental Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4760.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4760 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fd6b659bb8be1992618ce4ce91f568a0988b3afa Author: Oleg Ignatenko Date: 2018-09-02T06:11:42Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944 Author: Oleg Ignatenko Date: 2018-09-03T10:27:35Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf Author: Oleg Ignatenko Date: 2018-09-04T09:49:44Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5 Author: Oleg Ignatenko Date: 2018-09-05T10:50:28Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2 Author: Oleg Ignatenko Date: 2018-09-05T11:45:58Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 480ed78869277d7e32f725ab71bec9621f1ac03a Author: Oleg Ignatenko Date: 2018-09-06T07:52:55Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit c99762498f617c0e98ea3062a43c0b30092166ef Author: Oleg Ignatenko Date: 2018-09-06T14:45:04Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 2e17175225c72f747d370b5fee96f8be69d6d2cb Author: Oleg Ignatenko Date: 2018-09-06T17:33:54Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f Author: Oleg Ignatenko Date: 2018-09-07T13:38:51Z
[GitHub] ignite pull request #4753: IGNITE-9585 Error message sometimes refers nonexi...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/4753 IGNITE-9585 Error message sometimes refers nonexisting log file when remote node fails to start You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9585 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4753.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4753 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fd6b659bb8be1992618ce4ce91f568a0988b3afa Author: Oleg Ignatenko Date: 2018-09-02T06:11:42Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 6ae6d1d3cf9743d8d466be0330511ddc8589e944 Author: Oleg Ignatenko Date: 2018-09-03T10:27:35Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit e8b27dbd3d0c1cbdb7a7659175f5c7bb447482bf Author: Oleg Ignatenko Date: 2018-09-04T09:49:44Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 622c82efdd0aa182fadea6b7ffa5d4615521a3f5 Author: Oleg Ignatenko Date: 2018-09-05T10:50:28Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit fb844fe3751e2e8ae87e6b8030b0e4bd659df9c2 Author: Oleg Ignatenko Date: 2018-09-05T11:45:58Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 480ed78869277d7e32f725ab71bec9621f1ac03a Author: Oleg Ignatenko Date: 2018-09-06T07:52:55Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit c99762498f617c0e98ea3062a43c0b30092166ef Author: Oleg Ignatenko Date: 2018-09-06T14:45:04Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 2e17175225c72f747d370b5fee96f8be69d6d2cb Author: Oleg Ignatenko Date: 2018-09-06T17:33:54Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9ebcd9a2fe5966b0bf42a95484395867c15d863f Author: Oleg Ignatenko Date: 2018-09-07T13:38:51Z
[GitHub] ignite pull request #4662: IGNITE-9396 ML Examples: can't run examples, not ...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/4662 IGNITE-9396 ML Examples: can't run examples, not enough dependencies in pom.xml You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9396 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4662.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4662 commit 1eeca908a8076a8317947dac8a46845964d1d7ea Author: Oleg Ignatenko Date: 2018-08-23T13:13:28Z IGNITE-9348 ML examples improvements - wip (logging improved) -- verified with diffs overview, executing the examples and studying execution logs commit e50b89c392568ba9b93935c4fa6c7f7f93f5ec6f Author: Oleg Ignatenko Date: 2018-08-23T14:45:57Z Revert "IGNITE-9348 ML examples improvements" This reverts commit 1eeca908a8076a8317947dac8a46845964d1d7ea. commit 474024b4c5bbdb3c0a4ed2f0a66238c8054c6674 Author: Oleg Ignatenko Date: 2018-08-23T14:57:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9642b233b5701bdad47ebea163079160227c582a Author: Oleg Ignatenko Date: 2018-08-28T14:01:11Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 7fc16d013ab725d2ff2e1a1b042c983f11d0c4d4 Author: Oleg Ignatenko Date: 2018-08-28T15:13:02Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit d2caba67b156674f051f50faebeafe0871bf0914 Author: Oleg Ignatenko Date: 2018-08-29T13:14:07Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 16775dff51d71ea68b4a3dea98be552130c493ed Author: Oleg Ignatenko Date: 2018-08-30T09:00:56Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aedb59929974fe205b949225c1a338c68c60cfc8 Author: Oleg Ignatenko Date: 2018-08-30T09:42:38Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 39c6482fcdca506aa33011ed21c98060b4a8c68b Author: Oleg Ignatenko Date: 2018-08-30T11:28:05Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 33b32a2760a6559c78283b927e3191180d8ed9e1 Author: Oleg Ignatenko Date: 2018-08-30T12:31:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 9531028ddd1aef9e95f7e8c8b528086739bbb1b0 Author: Oleg Ignatenko Date: 2018-08-30T14:06:34Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 28f22c6e2fffcb82717ba5da7be2cfd39715c4e3 Author: Oleg Ignatenko Date: 2018-08-30T16:41:51Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit aacac88db519187413b0fc5ff9d0e55b8f8cff22 Author: Oleg Ignatenko Date: 2018-08-31T10:12:32Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 897f920dde46022849b13f9fb86dba8e54119a56 Author: Oleg Ignatenko Date: 2018-08-31T13:57:14Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit 114c79e54c1b316006ccc3ff22d20d902f9313df Author: Oleg Ignatenko Date: 2018-08-31T17:39:16Z Merge branch 'master' of https://github.com/apache/ignite into master-ml commit edb68a4ae2ccd1e66d77aa3690d4e0c541cf78b4 Author: Oleg Ignatenko Date: 2018-08-31T17:56:57Z IGNITE-9396 ML Examples: can't run examples, not enough dependencies in pom.xml - documentation added as per discussion in JIRA ticket comments -- verified with diffs overview and clean build of examples per added instructions ---
[GitHub] ignite pull request #4569: IGNITE-9316 Analyse and improve code coverage in ...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/4569 IGNITE-9316 Analyse and improve code coverage in ML module You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite_9316 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4569.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4569 commit 3eee3dc164063493bae312f4c4df5d73110e5d1b Author: Oleg Ignatenko Date: 2018-08-17T20:08:07Z IGNITE-9146 follow-up (phase 2) - wip -- verified with diffs overview, rebuild and execution of unit tests commit 11c22ee340fe52277d1cf43ea8e722b744d6f585 Author: Oleg Ignatenko Date: 2018-08-17T20:51:58Z IGNITE-9146 follow-up (phase 2) - wip -- verified with diffs overview, rebuild and execution of unit tests commit f4d8b8782bbf8eae4d1689eee90f05efa807b9da Author: Oleg Ignatenko Date: 2018-08-18T07:23:18Z IGNITE-9146 follow-up (phase 2) - wip -- verified with diffs overview, rebuild and execution of unit tests commit b3964e3171bdf8dff11496c056d19c95045ce422 Author: Oleg Ignatenko Date: 2018-08-18T07:29:31Z IGNITE-9146 follow-up (phase 2) - wip (IGNITE-9261 merge follow-up) -- verified with diffs overview, rebuild and execution of unit tests commit f3d71d0fa4d462d64a5c551903e3cc0168772b18 Author: Oleg Ignatenko Date: 2018-08-18T09:43:40Z IGNITE-9146 follow-up (phase 2) - wip (per review of generated coverage report) -- verified with diffs overview, rebuild and execution of unit tests commit 494fe53d7792880feb96852079a8f1d518713ec3 Author: Oleg Ignatenko Date: 2018-08-18T11:18:47Z IGNITE-9146 follow-up (phase 2) - wip (per review of generated coverage report) -- verified with diffs overview, rebuild and execution of unit tests commit 52c1dd678564fc9877c3b51c1319591add018c28 Author: Oleg Ignatenko Date: 2018-08-18T11:56:14Z IGNITE-9146 follow-up (phase 2) - wip (per review of generated coverage report) -- verified with diffs overview, rebuild and execution of unit tests commit 401d37c2e27042079d1ada7d7c868d4610d02e30 Author: Oleg Ignatenko Date: 2018-08-18T12:04:05Z Merge branch 'master-ml' into ignite_9146_phase_2 commit a0a2db4403f954d9a09f3027f246438f61c2a5ce Author: Oleg Ignatenko Date: 2018-08-18T16:44:56Z IGNITE-9146 follow-up (phase 2) - wip (per review of generated coverage report) -- verified with diffs overview, rebuild and execution of unit tests ---
[GitHub] ignite pull request #4560: IGNITE-9297 Review ML examples javadocs as of rel...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/4560 IGNITE-9297 Review ML examples javadocs as of release 2.6 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9267 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4560.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4560 commit 926b679caa7aa3af1eb21a8621ae99a0c8cab2c7 Author: Oleg Ignatenko Date: 2018-08-08T16:42:36Z ml examples review - wip -- verified with diffs overview, executing the example and studying code and execution logs commit b98854bc84aea69f3c0881249cecc89046738e78 Author: Oleg Ignatenko Date: 2018-08-10T15:12:54Z ml examples review - wip -- verified with diffs overview, executing the example and studying code and execution logs commit a6f5f54a950a395c9c7addd5c07e189f29229628 Author: Oleg Ignatenko Date: 2018-08-10T18:21:52Z ml examples review - wip -- verified with diffs overview, executing the example and studying code and execution logs commit 504f9e21fc8ffbd3fb16214762d681621f66b5aa Author: Oleg Ignatenko Date: 2018-08-10T18:43:14Z ml examples review - wip -- verified with diffs overview, executing the example and studying code and execution logs commit 0a673b19b4486ad4b4bcd771bf2c52a69aafd3ff Author: Oleg Ignatenko Date: 2018-08-10T18:44:23Z Merge branch 'master-ml' into ml-examples-review commit 5fc0f526977478ad8b450b339bb1178ce10479f5 Author: Oleg Ignatenko Date: 2018-08-11T18:40:05Z Merge branch 'master-ml' into ml-examples-review commit 2d9b3dc6d8ac47a00c1c4d5820ac48e9545b37e1 Author: Oleg Ignatenko Date: 2018-08-13T11:58:20Z Merge branch 'master-ml' into ml-examples-review commit 7d4113f3b4f1d57e32a77c74816e50a150592851 Author: Oleg Ignatenko Date: 2018-08-13T16:19:36Z ml examples review - wip -- verified with diffs overview, executing the example and studying code and execution logs commit f97ef2e9340a37d5c57c1eef9fd3a0804ba9cedb Author: Oleg Ignatenko Date: 2018-08-13T17:00:24Z ml examples review - wip -- verified with diffs overview, executing the example and studying code and execution logs commit 0520d8ab79816fd0d2045e3a534497137b3f1635 Author: Oleg Ignatenko Date: 2018-08-14T13:34:18Z ml examples review - wip -- verified with diffs overview, executing the example and studying code and execution logs commit 315190332ee7e2d3810e80436131eaa8263cf9c1 Author: Oleg Ignatenko Date: 2018-08-14T15:20:52Z ml examples review - fixes for code style warnings (mostly duplication and javadocs) -- verified with diffs overview, executing the example and studying code and execution logs commit ea07f1e8793297e38bdf078ab76f0718bde277a8 Author: Oleg Ignatenko Date: 2018-08-14T15:22:13Z Merge branch 'master-ml' into ml-examples-review commit e7b8837df6a8d84d099b8ada7a9d97a3aff818d7 Author: Oleg Ignatenko Date: 2018-08-14T17:06:55Z ml examples review - wip -- verified with diffs overview, executing the example and studying code and execution logs commit efa7489f799778ea590a94d5ab8da7e404b66ad2 Author: Oleg Ignatenko Date: 2018-08-14T17:19:15Z ml examples review - wip -- verified with diffs overview, executing the example and studying code and execution logs commit b801edaf07c09168819800da22f021140fc5f17b Author: Oleg Ignatenko Date: 2018-08-14T17:24:17Z ml examples review - wip -- verified with diffs overview, executing the example and studying code and execution logs commit 4e3ea9f1b8ca6848f7395121f18b428180ba4284 Author: Oleg Ignatenko Date: 2018-08-14T17:50:58Z ml examples review - wip -- verified with diffs overview, executing the example and studying code and execution logs commit 7578fc0bf753d2f65fa08aef3697a9a2876fe69a Author: Oleg Ignatenko Date: 2018-08-15T12:47:49Z ml examples review - fixes for code style warnings -- verified with diffs overview, rebuild and executing the examples commit 536573ac555cf6ab7478f58ed443277ae029d76a Author: Oleg Ignatenko Date: 2018-08-15T12:52:27Z ml examples review - formatting cleanup -- verified with diffs overview commit 9105b1bf2939666eb7cc2c878160daec991a45ff Author: Oleg Ignatenko Date: 2018-08-15T12:54:28Z Merge branch 'master-ml' into ml-examples-review commit b17b0d87a27f708b34d7f617ef0c3e0e4100ce0a Author: Oleg Ignatenko Date: 2018-08-15T15:16:02Z ml examples review - wip -- verified with diffs overview, executing the example and studying code and execution logs commit 19089728d9ef5cccdd16fd5d7e7fc33ac53c183d Author: Oleg Ignatenko Date: 2018-08-15T16:06:20Z Merge branch 'master
[GitHub] ignite pull request #4489: IGNITE-9146 Analyse and improve code coverage in ...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/4489 IGNITE-9146 Analyse and improve code coverage in ML module You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9146 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4489.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4489 commit 6a92b001d65c8f39f88edf53c2487c4f32929f42 Author: Oleg Ignatenko Date: 2018-07-30T15:55:20Z IGNITE-9124 Remove some dead code in math.exceptions and optimization packages of ML module - draft removal -- verified with diffs overview and clean rebuild commit 566b8e35e92d4aa39c5a79ff12f1defae9552d1e Author: Oleg Ignatenko Date: 2018-07-31T14:00:09Z IGNITE-9124 Remove some dead code in math.exceptions and optimization packages of ML module - removal completed -- verified with diffs overview and clean rebuild commit d71ddd0c9a987d98d10b38f9cf47b5ed237977e0 Author: Oleg Ignatenko Date: 2018-07-31T14:02:00Z Merge branch 'master-ml' into ignite-9124 commit c74ec10343f197c8ecb9a7d91874667b0c057507 Author: Oleg Ignatenko Date: 2018-07-31T16:51:23Z IGNITE-9146 Analyse and improve code coverage in ML module - IgniteExamplesMLTestSuite launches all examples that are possible to run automatically. -- verified with diffs overview, rebuild, running wit coverage and results analysis commit 3eda0ff86310e5a5161dd7f4318fd50311896aca Author: Oleg Ignatenko Date: 2018-08-01T10:32:51Z IGNITE-9146 Analyse and improve code coverage in ML module - corrections and docs for IgniteMLTestSuite -- verified with diffs overview, rebuild, running with coverage and results analysis commit 06770bae55d5560bb7f23a82fc6cb50830fcfdd0 Author: Oleg Ignatenko Date: 2018-08-01T10:34:35Z Merge branch 'master-ml' into ignite-9146 commit 3319b155ba5460edf84b621e6566c47ebe7f4da9 Author: Oleg Ignatenko Date: 2018-08-01T14:52:51Z IGNITE-9146 Analyse and improve code coverage in ML module - unit tests for classes that were covered only in examples -- verified with diffs overview and test run commit 26c2d29d720c02c646b3656865a537e12a4d2e6f Author: Oleg Ignatenko Date: 2018-08-01T16:25:34Z IGNITE-9146 Analyse and improve code coverage in ML module - unit tests for classes that were covered only in examples -- verified with diffs overview, rebuild, running with coverage and results analysis commit d84305aa7da989c1586fc19367bb6c41e56e3470 Author: Oleg Ignatenko Date: 2018-08-01T16:26:46Z Merge branch 'master-ml' into ignite-9146 commit fb5b4d27e3d3714238ef6bd9ff514b2fd535690c Author: Oleg Ignatenko Date: 2018-08-01T18:54:20Z IGNITE-9146 Analyse and improve code coverage in ML module - unit tests for classes that were covered only in examples -- verified with diffs overview, rebuild, running with coverage and results analysis commit 0f87c60b253860d3d0f51bf84b575515cf799f13 Author: Oleg Ignatenko Date: 2018-08-01T19:05:18Z IGNITE-9146 Analyse and improve code coverage in ML module - force IDEA to properly record coverage for classes implementing Metric -- verified with diffs overview, rebuild, running with coverage and results analysis commit c27dea0ac1f5a7b1162920594cd96fe56782c9b9 Author: Oleg Ignatenko Date: 2018-08-02T12:57:06Z IGNITE-9146 Analyse and improve code coverage in ML module - license -- verified with diffs overview commit 71620d0cfffac177d797d182d97eb5f764b8be8f Author: Oleg Ignatenko Date: 2018-08-02T14:17:53Z IGNITE-9146 Analyse and improve code coverage in ML module - unit tests for classes that were covered only in examples -- verified with diffs overview, rebuild, running with coverage and results analysis commit 40c29205f7c43f1e7ef66fd218c2886e9b1e28e7 Author: Oleg Ignatenko Date: 2018-08-02T15:47:16Z IGNITE-9146 Analyse and improve code coverage in ML module - unit tests for classes that were covered only in examples -- verified with diffs overview, rebuild, running with coverage and results analysis commit 3bbeaba282d3a8a38080443fcdc6f8cc8210c5d1 Author: Oleg Ignatenko Date: 2018-08-03T18:31:02Z IGNITE-9146 Analyse and improve code coverage in ML module - unit tests for classes that were covered only in examples -- verified with diffs overview, rebuild, running with coverage and results analysis commit 8eacdedae1afb9f715f0023f0b5a4e3c5505dae6 Author: Oleg Ignatenko Date: 2018-08-03T18:45:45Z Merge branch 'master-ml' into ignite-9146 # Conflicts: # modules/ml/src/test/java/org/apache/ignite/ml/preprocessing/encoding/StringEncoderPreprocessorTest.java commit 261651a685cc006025c46b95b4cbb0d6e689c496
[GitHub] ignite pull request #4462: IGNITE-9124 Remove some dead code in ML module
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/4462 IGNITE-9124 Remove some dead code in ML module You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9124 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4462.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4462 commit 6a92b001d65c8f39f88edf53c2487c4f32929f42 Author: Oleg Ignatenko Date: 2018-07-30T15:55:20Z IGNITE-9124 Remove some dead code in math.exceptions and optimization packages of ML module - draft removal -- verified with diffs overview and clean rebuild commit 566b8e35e92d4aa39c5a79ff12f1defae9552d1e Author: Oleg Ignatenko Date: 2018-07-31T14:00:09Z IGNITE-9124 Remove some dead code in math.exceptions and optimization packages of ML module - removal completed -- verified with diffs overview and clean rebuild commit d71ddd0c9a987d98d10b38f9cf47b5ed237977e0 Author: Oleg Ignatenko Date: 2018-07-31T14:02:00Z Merge branch 'master-ml' into ignite-9124 ---
[GitHub] ignite pull request #3418: Ignite 6899 check
Github user oignatenko closed the pull request at: https://github.com/apache/ignite/pull/3418 ---
[GitHub] ignite pull request #3449: IGNITE-7509 Adjust documentation for ML module
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/3449 IGNITE-7509 Adjust documentation for ML module - updated docs -- verified with diffs overview and rebuild per updated instructions You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-7509 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3449.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3449 commit 88fc8e95fcfb6ead7379c1ecfaa861b286882695 Author: Oleg Ignatenko <oignatenko@...> Date: 2018-01-29T15:21:51Z IGNITE-7509 Adjust documentation for ML module - updated docs -- verified with diffs overview and rebuild per updated instructions ---
[GitHub] ignite pull request #3418: Ignite 6899 check
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/3418 Ignite 6899 check You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6899-check Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3418.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3418 commit 5c204d7b433f043fdce25be0330d7793767ea99f Author: Turik Campbell <admin@...> Date: 2018-01-09T22:06:18Z IGNITE-6899: Adding GA Grid to Apache Ignite ML module commit e30356df9e41b9d8379b8880b66b60d97458f3e9 Author: Turik Campbell <admin@...> Date: 2018-01-12T04:34:33Z IGNITE-6899: Applied Ignite code style commit fd59c65bc24733f56c5e95b5334b772a44c9b57e Author: Turik Campbell <admin@...> Date: 2018-01-12T04:38:02Z Merge branch 'master' into ignite-6899 commit aa8601f05100358de337736931b5b34566bf34af Author: Turik Campbell <admin@...> Date: 2018-01-13T15:24:55Z IGNITE-6899: Added package-info.java files to sub packages of genetic (ie: src/main/java/org/apache/ignite/ml/genetic) commit d804213debc1a027037185b07f3e5d66018b4c30 Author: Turik Campbell <admin@...> Date: 2018-01-13T15:46:13Z IGNITE-6899: Updated visibility of chromosomeCriteria and updated typo for respective accessor/mutator method. commit 7f107a8e05a5f77ee1725dda981433b8c8e56436 Author: Turik Campbell <admin@...> Date: 2018-01-13T15:47:40Z IGNITE-6899: Merge branch 'master' into ignite-6899 commit cc1943af8902cf4dc99dda631b39d6ebb5941d3d Author: Turik Campbell <admin@...> Date: 2018-01-15T02:57:36Z IGNITE-6899: Fixed Java coding conventions for comments commit 644f935ba984d47a7943025b261354790179fe52 Author: Turik Campbell <admin@...> Date: 2018-01-16T03:12:41Z Merge branch 'master' into ignite-6899 commit 7be0e3712d8db1c7042809bb33bdb39aecd1c909 Author: Turik Campbell <admin@...> Date: 2018-01-17T12:51:18Z IGNITE-6899: Merged 'master' branch into 'ignite-6899' branch and resolved conflicts commit 60a5aa6f9c8d68c19d45c70aab75a90f657eae13 Author: Turik Campbell <admin@...> Date: 2018-01-18T12:36:59Z IGNITE-6899: Merge branch 'master' into ignite-6899 commit a7a3d8071344c3c3adbc8b83d33dbb7bac5309ca Author: Turik Campbell <admin@...> Date: 2018-01-20T13:06:36Z IGNITE-6899: Deleted unwanted directory /maven_repository commit 191109734409e4391263d449ecba66ba8d49ca32 Author: Turik Campbell <admin@...> Date: 2018-01-20T13:27:36Z IGNITE-6899: Moved ML 'GAGrid' examples to examples/src/main/java directory. Updated OptimizeMakeChangeGAExample to use 'elitism' selection method (ie: set eliteCount). commit 59b55a79bb085849053bf6b736056d5485df47f7 Author: Turik Campbell <admin@...> Date: 2018-01-20T13:38:03Z IGNITE-6899: Merge branch 'master' into ignite-6899 commit b568a03ca6c7e036aba1dce6bef70acb8faa8d36 Author: Turik Campbell <admin@...> Date: 2018-01-20T16:09:44Z IGNITE-6899: Removed FITNESS_EVALUATER_TYPE (enum) in favor using boolean value to describe fitness evaluation commit 8706ef36bcda8a074b80483efd1729b468329a0b Author: Turik Campbell <admin@...> Date: 2018-01-20T16:11:36Z IGNITE-6899: Fixed comments commit 6287a890404d5262abff8fd50c11f10f4cf373e4 Author: Oleg Ignatenko <oignatenko@...> Date: 2018-01-22T15:09:35Z IGNITE-6899 GA Grid - preliminary check for licenses and javadocs - fixed javadoc issues that were picked by merge from master -- verified with diffs overview ---
[GitHub] ignite pull request #2600: IGNITE-6193 ML profile is missing in 2.1 binary r...
Github user oignatenko closed the pull request at: https://github.com/apache/ignite/pull/2600 ---
[GitHub] ignite pull request #3393: IGNITE-7454 Wrong package in IgniteExamplesMLTest...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/3393 IGNITE-7454 Wrong package in IgniteExamplesMLTestSuite - completed work for ML examples -- verified with diffs overview, clean rebuild and execution of IgniteExamplesSelfTestSuite You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-7203-ml-examples Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3393.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3393 ---
[GitHub] ignite pull request #3363: IGNITE-5725 Adapt TracerTest for TC builds.
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/3363 IGNITE-5725 Adapt TracerTest for TC builds. - implemented adaptive testing approach -- verified with diffs overview, clean rebuild and execution of unit tests in both desktop and headless environments You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-5725-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3363.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3363 commit 57ac99736f0748eab79bc408111dfb9e2d077e2e Author: Oleg Ignatenko <oignatenko@...> Date: 2018-01-12T10:02:20Z IGNITE-5725 Adapt TracerTest for TC builds. - implemented adaptive testing approach -- verified with diffs overview, clean rebuild and execution of unit tests in both desktop and headless environments ---
[GitHub] ignite pull request #3314: IGNITE-7214 performance measurement for FCM and K...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/3314 IGNITE-7214 performance measurement for FCM and KNN algorithms You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-7214 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3314.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3314 commit b328d6b2856c7998e6a3de2f8344ddefaad81196 Author: Oleg Ignatenko <oignatenko@...> Date: 2017-12-25T18:14:44Z IGNITE-7214 performance measurement for FCM and KNN algorithms - kNN benchmarks -- verified with diffs overview, clean rebuild, trial execution of the benchmarks and studying results commit 7c4b06dc2eff5c68c8bd0e05d82e98af8d9f02ab Author: Oleg Ignatenko <oignatenko@...> Date: 2017-12-26T07:10:00Z Merge branch 'master-ml' into ignite-7214-preliminary commit 9fa1c42c76e26037d5e4eab16bcbb195c5ece51d Author: Oleg Ignatenko <oignatenko@...> Date: 2017-12-26T09:49:42Z Merge branch 'master-ml' into ignite-7214-preliminary commit 7acc2db76434868bed5436aaed5243684d0f394c Author: Oleg Ignatenko <oignatenko@...> Date: 2017-12-26T10:23:35Z IGNITE-7214 performance measurement for FCM and KNN algorithms - kNN examples cleanup -- verified with diffs overview, clean rebuild, trial execution of the benchmarks and studying results commit ce5c4be654bb2e1f7ac7193ecaaf2538d1570ad0 Author: Oleg Ignatenko <oignatenko@...> Date: 2017-12-26T10:51:30Z IGNITE-7214 performance measurement for FCM and KNN algorithms - corrected data for IgniteKNNRegressionBenchmark -- verified with diffs overview commit 5ffdf8d951a9af0fa4391e17a62cd2ca764bd8e9 Author: Oleg Ignatenko <oignatenko@...> Date: 2017-12-26T15:21:35Z IGNITE-7214 performance measurement for FCM and KNN algorithms - preliminary cleanup for FCM benchmark -- verified with diffs overview commit 3901a2df34908c7f9df37932940920510989fb34 Author: Oleg Ignatenko <oignatenko@...> Date: 2017-12-26T16:03:10Z IGNITE-7214 performance measurement for FCM and KNN algorithms - drafted distributed FCM benchmark -- verified with diffs overview commit 9148e50fbe61f5c963e2c433d3a45c9af936e9fb Author: Oleg Ignatenko <oignatenko@...> Date: 2017-12-26T16:05:21Z Merge branch 'master-ml' into ignite-7214-preliminary commit b0d9c6cb58716f28913f53d3e5780824758fe558 Author: Oleg Ignatenko <oignatenko@...> Date: 2017-12-26T16:24:00Z IGNITE-7214 performance measurement for FCM and KNN algorithms - preliminary cleanup for FCM benchmark -- verified with diffs overview commit e626d194400bbadae31e2f6da0410a8bddabb5bf Author: Oleg Ignatenko <oignatenko@...> Date: 2017-12-26T16:34:00Z IGNITE-7214 performance measurement for FCM and KNN algorithms - preliminary cleanup for FCM benchmark -- verified with diffs overview commit 7cfaed9d4d5ea407c91a256100767b05bc942059 Author: Oleg Ignatenko <oignatenko@...> Date: 2017-12-27T07:22:23Z Merge branch 'master-ml' into ignite-7214-preliminary commit 353e8ab70294c599f262278c54b04c55fd2c349c Author: Oleg Ignatenko <oignatenko@...> Date: 2017-12-27T11:55:31Z Merge branch 'master-ml' into ignite-7214-preliminary commit f16a37e5a088df23a6b9b716731b14018791c534 Author: Oleg Ignatenko <oignatenko@...> Date: 2017-12-27T12:32:32Z IGNITE-7214 performance measurement for FCM and KNN algorithms - preliminary cleanup for FCM benchmark // added missing example for local FCM -- verified with diffs overview commit 50bb3d24c6001dee8351fdb8c8d68ebdd19d57bf Author: Oleg Ignatenko <oignatenko@...> Date: 2017-12-27T12:44:05Z IGNITE-7214 performance measurement for FCM and KNN algorithms - drafted local FCM benchmark -- verified with diffs overview commit 14cea0e89de17e625f526bf08338fea65d9d6a5c Author: Oleg Ignatenko <oignatenko@...> Date: 2017-12-27T13:05:32Z IGNITE-7214 performance measurement for FCM and KNN algorithms - FCM benchmarks -- verified with diffs overview, clean rebuild, trial execution of the benchmarks and studying results commit 4f71ff9d88d4f016fcbe52e49104d17687191f3f Author: Oleg Ignatenko <oignatenko@...> Date: 2017-12-28T14:34:34Z Merge branch 'master-ml' into ignite-7214 # Conflicts: # modules/ml/src/main/java/org/apache/ignite/ml/structures/LabeledDataset.java commit efbfda49a040ec290239e00a29fbc6818361e4be Author: Oleg Ignatenko <oignatenko@...> Date: 2017-12-28T14:43:21Z IGNITE-7214 performance measurement for FCM and KNN algorithms - minor cleanup -- verified with diffs overview ---
[GitHub] ignite pull request #3241: IGNITE-7097 performance measurement for SparseDis...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/3241 IGNITE-7097 performance measurement for SparseDistributedMatrix multi⦠â¦plication - optimised and unoptimised benchmarks, along with respective documentation - also a common adjustment to matrix mul benchmarks to make these more sensitive to algorithmic changes -- verified with diffs overview, clean rebuild, trial execution of the benchmarks and studying results You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-7097 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3241.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3241 commit be918641730af3738dcc4d8cd608b63ba6088732 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-12-15T15:58:43Z IGNITE-7097 performance measurement for SparseDistributedMatrix multiplication - optimised and unoptimised benchmarks, along with respective documentation - also a common adjustment to matrix mul benchmarks to make these more sensitive to algorithmic changes -- verified with diffs overview, clean rebuild, trial execution of the benchmarks and studying results ---
[GitHub] ignite pull request #3213: IGNITE-6495 performance measurement of decision t...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/3213 IGNITE-6495 performance measurement of decision trees algorithms - benchmark drafted a while ago integrated with recent changes in master -- verified with diffs overview, clean rebuild, trial execution of the benchmarks and studying results You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6495 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3213.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3213 commit f6782229ed97e848ff4770d5c8f49c5d97a4f2fb Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-12-12T16:24:41Z IGNITE-6495 performance measurement of decision trees algorithms - benchmark drafted a while ago integrated with recent changes in master -- verified with diffs overview, clean rebuild, trial execution of the benchmarks and studying results ---
[GitHub] ignite pull request #3211: IGNITE-7118 performance measurement for distribut...
Github user oignatenko closed the pull request at: https://github.com/apache/ignite/pull/3211 ---
[GitHub] ignite pull request #3211: IGNITE-7118 performance measurement for distribut...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/3211 IGNITE-7118 performance measurement for distributed k-means clustering You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-7118 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3211.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3211 commit a782ee3f944d556686e8d0a68acb3f534e3ecb13 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-12-12T13:30:11Z IGNITE-7118 performance measurement for distributed k-means clustering - enabled benchmark after integration of necessary fix from master -- verified with diffs overview, clean rebuild, trial execution of the benchmarks and studying results commit 125b3d1fe182dbaeba3ba99476e92a48f6daf9aa Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-12-12T14:04:42Z IGNITE-7118 performance measurement for distributed k-means clustering - enabled benchmark after integration of necessary fix from master -- verified with diffs overview, clean rebuild, trial execution of the benchmarks and studying results ---
[GitHub] ignite pull request #3210: IGNITE-7118 performance measurement for distribut...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/3210 IGNITE-7118 performance measurement for distributed k-means clustering - enabled benchmark after integration of necessary fix from master -- verified with diffs overview, clean rebuild, trial execution of the benchmarks and studying results You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-7118 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3210.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3210 commit a782ee3f944d556686e8d0a68acb3f534e3ecb13 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-12-12T13:30:11Z IGNITE-7118 performance measurement for distributed k-means clustering - enabled benchmark after integration of necessary fix from master -- verified with diffs overview, clean rebuild, trial execution of the benchmarks and studying results ---
[GitHub] ignite pull request #3173: IGNITE-6373 Create example for local and distribu...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/3173 IGNITE-6373 Create example for local and distributed k-means algorithm - examples implemented -- verified with diffs overview, clean build and execution of examples You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6373-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3173.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3173 commit b0cc9d74dfd664f3be11cadb0a43369819b3e8b5 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-12-07T15:56:14Z IGNITE-6373 Create example for local and distributed k-means algorithm - examples implemented -- verified with diffs overview, clean build and execution of examples ---
[GitHub] ignite pull request #3069: Ignite 6872 1
Github user oignatenko closed the pull request at: https://github.com/apache/ignite/pull/3069 ---
[GitHub] ignite pull request #3168: IGNITE-6872 Linear regression should implement Mo...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/3168 IGNITE-6872 Linear regression should implement Model API Model and Trainer API implemented for OLS regression You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6872-4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3168.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3168 commit cf6ba40c97840a28ee14f49f09f79fe3d9d5a66f Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-20T11:53:46Z IGNITE-6872 Linear regression should implement Model API - regression examples moved to more appropriate package -- verified with diffs overview, clean build and execution of unit tests commit a8dadee71e0ca2a00387cfa2dba9c656de75137f Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-20T11:57:18Z IGNITE-6872 Linear regression should implement Model API - added missing package-info -- verified with diffs overview commit cc8edfbd0ca7e20655f45dc82d576f2d21627497 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-20T14:12:03Z IGNITE-6872 Linear regression should implement Model API - implementation, tests and examples - accommodated changes done to OLS per IGNITE-5846 - fixed some issues with coding style and javadoc -- verified with diffs overview, clean build, execution of unit tests and examples commit a0f294740b78dbe354a67a1658c9877544e587ea Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-21T08:57:27Z IGNITE-6872 Linear regression should implement Model API - decision trees example moved to more appropriate package -- verified with diffs overview commit e944568849d09f2bc7fca932bc043304208ff55d Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-21T13:25:31Z IGNITE-6872 Linear regression should implement Model API - corrections per review -- verified with diffs overview commit dfa4ea896d404b7bd231b57e880b5745b9db634f Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-21T13:37:47Z IGNITE-6872 Linear regression should implement Model API - corrections per review -- verified with diffs overview commit fe79868659d9a04d73234d800b7e5b1ba9029eeb Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-21T13:38:19Z IGNITE-6872 Linear regression should implement Model API - corrections per review -- verified with diffs overview commit c69583b91eef73616827cbfe03ad9eb1ff7ccde0 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-21T13:42:56Z IGNITE-6872 Linear regression should implement Model API - corrections per review -- verified with diffs overview commit 1ca1fb030d5be32843fce9746aa7d026a81d4502 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-21T13:45:15Z IGNITE-6872 Linear regression should implement Model API - corrections per review -- verified with diffs overview commit 35918b024bca13dea3a061f623f743ab33f14cd7 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-21T13:49:53Z IGNITE-6872 Linear regression should implement Model API - corrections per review -- verified with diffs overview, clean build, execution of unit tests and examples commit 88fe344b83b9c9272eddc1c6e536febb0f8eff43 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-23T14:50:47Z IGNITE-6872 Linear regression should implement Model API - OLS regression Trainer wip - preliminary cleanup of QR decomposition -- verified with diffs overview, clean build, execution of unit tests and examples commit 24a27d9976fe5c1cf3ab876e410b4af63aec8792 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-23T15:26:20Z IGNITE-6872 Linear regression should implement Model API - OLS regression Trainer wip - adapter from QR decomposition to trainer -- verified with diffs overview, clean build and execution of unit tests commit 608d558fa33e61d86b35621ea706819621a017ba Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-27T16:16:19Z IGNITE-6872 Linear regression should implement Model API - OLS regression Trainer implemented -- verified with diffs overview, clean build, execution of unit tests and examples commit 857c0f83a281f9a37664988a50f2924f26140f47 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-12-07T11:04:41Z Merge branch 'ignite-6872-2' into ignite-6872-4 # Conflicts: # modules/ml/src/test/java/org/apache/ignite/ml/LocalModelsTest.java # modules/ml/src/test/java/org/apache/ignite/ml/regressions/DistributedBlockOLSMultipleLinearRe
[GitHub] ignite pull request #3167: IGNITE-6872 Linear regression should implement Mo...
Github user oignatenko closed the pull request at: https://github.com/apache/ignite/pull/3167 ---
[GitHub] ignite pull request #3167: IGNITE-6872 Linear regression should implement Mo...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/3167 IGNITE-6872 Linear regression should implement Model API You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6872-3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3167.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3167 commit cf6ba40c97840a28ee14f49f09f79fe3d9d5a66f Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-20T11:53:46Z IGNITE-6872 Linear regression should implement Model API - regression examples moved to more appropriate package -- verified with diffs overview, clean build and execution of unit tests commit a8dadee71e0ca2a00387cfa2dba9c656de75137f Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-20T11:57:18Z IGNITE-6872 Linear regression should implement Model API - added missing package-info -- verified with diffs overview commit cc8edfbd0ca7e20655f45dc82d576f2d21627497 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-20T14:12:03Z IGNITE-6872 Linear regression should implement Model API - implementation, tests and examples - accommodated changes done to OLS per IGNITE-5846 - fixed some issues with coding style and javadoc -- verified with diffs overview, clean build, execution of unit tests and examples commit a0f294740b78dbe354a67a1658c9877544e587ea Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-21T08:57:27Z IGNITE-6872 Linear regression should implement Model API - decision trees example moved to more appropriate package -- verified with diffs overview commit e944568849d09f2bc7fca932bc043304208ff55d Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-21T13:25:31Z IGNITE-6872 Linear regression should implement Model API - corrections per review -- verified with diffs overview commit dfa4ea896d404b7bd231b57e880b5745b9db634f Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-21T13:37:47Z IGNITE-6872 Linear regression should implement Model API - corrections per review -- verified with diffs overview commit fe79868659d9a04d73234d800b7e5b1ba9029eeb Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-21T13:38:19Z IGNITE-6872 Linear regression should implement Model API - corrections per review -- verified with diffs overview commit c69583b91eef73616827cbfe03ad9eb1ff7ccde0 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-21T13:42:56Z IGNITE-6872 Linear regression should implement Model API - corrections per review -- verified with diffs overview commit 1ca1fb030d5be32843fce9746aa7d026a81d4502 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-21T13:45:15Z IGNITE-6872 Linear regression should implement Model API - corrections per review -- verified with diffs overview commit 35918b024bca13dea3a061f623f743ab33f14cd7 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-21T13:49:53Z IGNITE-6872 Linear regression should implement Model API - corrections per review -- verified with diffs overview, clean build, execution of unit tests and examples commit 88fe344b83b9c9272eddc1c6e536febb0f8eff43 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-23T14:50:47Z IGNITE-6872 Linear regression should implement Model API - OLS regression Trainer wip - preliminary cleanup of QR decomposition -- verified with diffs overview, clean build, execution of unit tests and examples commit 24a27d9976fe5c1cf3ab876e410b4af63aec8792 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-23T15:26:20Z IGNITE-6872 Linear regression should implement Model API - OLS regression Trainer wip - adapter from QR decomposition to trainer -- verified with diffs overview, clean build and execution of unit tests commit 608d558fa33e61d86b35621ea706819621a017ba Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-27T16:16:19Z IGNITE-6872 Linear regression should implement Model API - OLS regression Trainer implemented -- verified with diffs overview, clean build, execution of unit tests and examples commit 6aca220e1a40609b5d2a283a338a9f9bdecdfe33 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-12-07T10:01:26Z Merge branch 'ignite-6872-2' into ignite-6872-3 # Conflicts: # modules/ml/src/test/java/org/apache/ignite/ml/LocalModelsTest.java # modules/ml/src/test/java/org/apache/ignite/ml/regressions/DistributedBlockOLSMultipleLinearRegressionTest.java # modules/ml/src/test/java/org/apache/ignite/ml/regressions/DistributedOLSMultipleLinearRegressionTest.java ---
[GitHub] ignite pull request #3069: Ignite 6872 1
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/3069 Ignite 6872 1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6872-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3069.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3069 commit cf6ba40c97840a28ee14f49f09f79fe3d9d5a66f Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-20T11:53:46Z IGNITE-6872 Linear regression should implement Model API - regression examples moved to more appropriate package -- verified with diffs overview, clean build and execution of unit tests commit a8dadee71e0ca2a00387cfa2dba9c656de75137f Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-20T11:57:18Z IGNITE-6872 Linear regression should implement Model API - added missing package-info -- verified with diffs overview commit cc8edfbd0ca7e20655f45dc82d576f2d21627497 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-11-20T14:12:03Z IGNITE-6872 Linear regression should implement Model API - implementation, tests and examples - accommodated changes done to OLS per IGNITE-5846 - fixed some issues with coding style and javadoc -- verified with diffs overview, clean build, execution of unit tests and examples ---
yardstick module - adding ML benchmarks (PR #2780 / IGNITE-6123)
Hello, I implemented some benchmarks for machine learning algorithms per IGNITE-6123 [1] and would want to push these to master. Changes impact "yardstick" module, more details of new benchmarks can be found in PR #2780 [2]. Yury Babak [3] did preliminary review and sanity check. These are mostly like the rest of other benchmarks, except that the source code and maven build are arranged so that ML benchmarks are available only when "ml" maven profile is activated. Here, I followed essentially the same approach as was used to integrate ml stuff into "examples" module: there is an ml.folder property in pom file that defaults to src/main/java and changes to src/main/ml if ml profile is activated. And just like it was for examples module the reason for this is that build of underlying ml module requires activation of "ml" profile. I would appreciate if you folks take a look and provide feedback on that. I am particularly interested to hear from Oleg Ostanin [4], for two reasons. First is his recent activity in benchmarks suggesting a familiarity with how things are expected to be done and second, because planned change may be interesting as it is going to impact Teamcity builds he is working at (IGNITE-6193 [5], IGNITE-6329 [6]). I am also interested in feedback from Anton Vinogradov [7] because of his prior helpful reviews of ML pull requests. [1] https://issues.apache.org/jira/browse/IGNITE-6123 [2] https://github.com/apache/ignite/pull/2780 [3] https://github.com/ybabak [4] https://github.com/oleg-ostanin [5] https://issues.apache.org/jira/browse/IGNITE-6193 [6] https://issues.apache.org/jira/browse/IGNITE-6329 [7] https://github.com/anton-vinogradov -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
[GitHub] ignite pull request #2780: Ignite 6123
GitHub user oignatenko reopened a pull request: https://github.com/apache/ignite/pull/2780 Ignite 6123 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6123 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/2780.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2780 commit af39147742c2368c3f643b161172152e1ad83db4 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-09-18T12:42:12Z IGNITE-6123 ML Grid benchmarks - wip -- verified with diffs overview, trial local build and execution of unit tests commit 9e977575547b2bdbff205973738e1c1128127768 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-09-23T09:28:05Z IGNITE-6123 ML Grid benchmarks - temporarily tweaked config to simplify debugging -- verified with diffs overview, clean build, trial execution of benchmark and studying results commit b304174d38b511573040ce44d5553c111fbb5709 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-09-23T10:28:57Z IGNITE-6123 ML Grid benchmarks - temporarily tweaked config to simplify debugging -- verified with diffs overview, clean build, trial execution of benchmark and studying results commit 9929b76aeed43920e13df3f580cdfc3d2ad261da Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-09-23T10:37:15Z IGNITE-6123 ML Grid benchmarks - wip -- verified with diffs overview commit 7dbd4c5768f554436569722a2a06f8f170614c15 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-09-23T10:46:41Z IGNITE-6123 ML Grid benchmarks - wip -- verified with diffs overview, clean build, trial execution of benchmark and studying results commit 309c8f327c0b053c7b7936849dca0598f48d8c0b Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-09-23T11:07:17Z IGNITE-6123 ML Grid benchmarks - wip -- verified with diffs overview, clean build, trial execution of benchmark and studying results commit ce34c6b11c246943bd987ffec7d89ace436566a0 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-09-23T11:26:57Z IGNITE-6123 ML Grid benchmarks - wip -- verified with diffs overview, clean build, trial execution of benchmark and studying results commit 0d1a8bec37cece371b56037d45bc27200143c06e Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-09-23T11:34:25Z IGNITE-6123 ML Grid benchmarks - wip -- verified with diffs overview, clean build, trial execution of benchmark and studying results commit 31909049ada893fecfcbf07f0d70831d7a2d39a2 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-09-23T13:17:16Z IGNITE-6123 ML Grid benchmarks - wip -- verified with diffs overview, clean build, trial execution of benchmark and studying results commit 7f911c664c024742212df3652a59b4ad628ea124 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-09-23T14:15:32Z IGNITE-6123 ML Grid benchmarks - wip -- verified with diffs overview, clean build, trial execution of benchmark and studying results commit 8c777d8edc0d847b6c96dddb1281a1bd39741b52 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-09-24T04:24:30Z IGNITE-6123 ML Grid benchmarks - wip -- verified with diffs overview, clean build, trial execution of benchmark and studying results commit 60d98dbf194cc30530948892fc0f62a9f8f2b50e Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-09-24T15:21:43Z IGNITE-6123 ML Grid benchmarks - wip -- verified with diffs overview, clean build, trial execution of benchmark and studying results commit 2cd480b8ae571d1684dc7060b36d099651f3c7fd Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-09-24T17:04:19Z IGNITE-6123 ML Grid benchmarks - wip -- verified with diffs overview, clean build, trial execution of benchmark and studying results commit da4a11c28133689dbbc40bae927483950e1ddad2 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-09-25T13:11:32Z IGNITE-6123 ML Grid benchmarks - wip -- verified with diffs overview, clean build, trial execution of benchmark and studying results commit 8ef25ab5b7019a956672ce5fcf407087beef2074 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-09-25T13:53:40Z IGNITE-6123 ML Grid benchmarks - wip -- verified with diffs overview, clean build, trial execution of benchmark and studying results commit 070d640477cd5f663682cc67ef8da3157b604dc0 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-09-25T14:45:19Z IGNITE-6123 ML Grid benchmarks - wip -- verified with diffs overview, clean build, trial execution
[GitHub] ignite pull request #2780: Ignite 6123
Github user oignatenko closed the pull request at: https://github.com/apache/ignite/pull/2780 ---
[GitHub] ignite pull request #2780: Ignite 6123
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/2780 Ignite 6123 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6123 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/2780.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2780 ---
[GitHub] ignite pull request #2604: IGNITE-6193 ML profile is missing in 2.1 binary r...
Github user oignatenko closed the pull request at: https://github.com/apache/ignite/pull/2604 ---
[GitHub] ignite pull request #2604: IGNITE-6193 ML profile is missing in 2.1 binary r...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/2604 IGNITE-6193 ML profile is missing in 2.1 binary release - porting changes to standalone and lgpl pom files from regular one -- verified with diffs overview You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6193-3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/2604.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2604 commit 1501011b5fff5e1ef136081a73488c870177a76a Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-09-06T15:56:23Z IGNITE-6193 ML profile is missing in 2.1 binary release - porting changes to standalone and lgpl pom files from regular one -- verified with diffs overview ---
[GitHub] ignite pull request #2600: IGNITE-6193 ML profile is missing in 2.1 binary r...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/2600 IGNITE-6193 ML profile is missing in 2.1 binary release You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9163-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/2600.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2600 commit 737874f65d2aa143a79dd5f6b0d223e07a4eceee Author: Ivan Rakov <ivan.glu...@gmail.com> Date: 2017-08-29T10:24:20Z IGNITE-6204 Backport optimizations of checkpointing algorithm into 2.2 commit abb675f3355494b1f1ab502718aa0ad2249cb78b Author: Pavel Tupitsyn <ptupit...@apache.org> Date: 2017-08-29T15:35:49Z IGNITE-6204 Backport optimizations of checkpointing algorithm into 2.2 (hotfix) commit c06ceba8d014ded7519a37583cb8914f2ef064d9 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-08-30T11:15:32Z IGNITE-6193 ML profile is missing in 2.1 binary release commit d51171f11a566d0019b7482d990afc23eccc9f05 Author: Igor Seliverstov <gvvinbl...@gmail.com> Date: 2017-09-01T09:48:38Z IGNITE-6182 Change default max memory size from 80% to 20% commit 1fb2fe04fd5e08bac16e79f572893f2fa7a3ad38 Author: devozerov <voze...@gridgain.com> Date: 2017-09-04T14:41:30Z IGNITE-6182: Improved message. commit 94641a9313342bdb7782690f0df6f076bc400df8 Author: oleg-ostanin <oosta...@gridgain.com> Date: 2017-09-05T10:50:55Z IGNITE-5817 deleted deploy-ignite sources profile commit e469ab6861202e88fc066608870e4a6ae2c3424e Author: Igor Sapego <isap...@gridgain.com> Date: 2017-07-27T16:39:51Z IGNITE-5771: Added Ignite::SetActive() for C++ (cherry picked from commit 47fea40) commit be126e1eee4a2d6d997213d8d705733933bb0d01 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-09-06T13:57:02Z IGNITE-6193 ML profile is missing in 2.1 binary release - porting changes to standalone and lgpl pom files from regular one -- verified with diffs overview ---
[GitHub] ignite pull request #2537: IGNITE-6193 ML profile is missing in 2.1 binary r...
Github user oignatenko closed the pull request at: https://github.com/apache/ignite/pull/2537 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] ignite pull request #2537: IGNITE-6193 ML profile is missing in 2.1 binary r...
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/2537 IGNITE-6193 ML profile is missing in 2.1 binary release - verified with diffs overview and trial local build You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-6193 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/2537.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2537 commit 8bdda9ba9146c8e12713a74eb1d1a5612655c370 Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-08-29T11:55:15Z IGNITE-6193 ML profile is missing in 2.1 binary release - verified with diffs overview and trial local build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] ignite pull request #1837: IGNITE-5018 Javadocs in Ignite ML module.
GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/1837 IGNITE-5018 Javadocs in Ignite ML module. - compliance with coding guidelines (rev 17 at https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines) - verified with diffs overview and execution of code style inspections. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-5018-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/1837.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1837 commit 38c3d60fc619e690e0b5980de98b95081576560b Author: Oleg Ignatenko <oignate...@gridgain.com> Date: 2017-04-20T10:49:58Z IGNITE-5018 Javadocs in Ignite ML module. - compliance with coding guidelines (rev 17 at https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines) - verified with diffs overview and execution of code style inspections. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Adding ML to Ignite, IGNITE-4572
Denis, As far as I can tell renames are now finalized in the way you proposed yesterday. I re-run my checks for build, module unit tests and examples (everything went fine) and updated draft doc for readme.io accordingly. You can find most recent version of the draft doc attached to JIRA IGNITE-4964 regards, Oleg Denis Magda wrote > Thanks Oleg, I’ll review the doc a bit later. > > Yuri, I’ve reopened IGNITE-5000. Please consider my latest notes and > prepare one more pull-request: > https://issues.apache.org/jira/browse/IGNITE-5000 > https://issues.apache.org/jira/browse/IGNITE-5000; > > — > Denis > >> On Apr 17, 2017, at 8:48 AM, oignatenko > oignatenko@ > wrote: >> >> Denis, I prepared preliminary draft doc for readme.io >> http://readme.io/;, it reflects proposed >> rename. You can find it attached to JIRA IGNITE-4964 >> >> With regards to merge, per my reading of recent mail from Yury it is done >> except for module rename which is on its way to master now. >> >> regards, Oleg >> >> >> Denis Magda-2 wrote >>> Oleg, Nikita, Yuri, >>> >>> Frankly, I don’t like how the module is named presently which is >>> 'ignite-math’. >>> >>> I propose to rename it to ‘ignite-ml’. Presently, it holds a small >>> fraction of all ML functionality we might have in the future and this is >>> why, thinking of future, it will be a right decision to name it >>> accordingly. >>> >>> Any concerns? >>> >>> BTW, have the module been fully merged? I want to try to build it and >>> check the examples. >>> >>> — >>> Denis >>> >>>> On Apr 14, 2017, at 7:05 AM, oignatenko >> >>> oignatenko@ >> >>> wrote: >>>> >>>> Thank you Denis, that sounds like a good plan. I am working on it now. >>>> I >>>> didn't reassign IGNITE-4964, just set a watch on it. Will comment on it >>>> when >>>> I have concrete details to share. >>>> >>>> Side note my build check completed successfully, although it took quite >>>> a >>>> bit of time: I cleaned my local maven repo to make sure that things >>>> really >>>> work from the clean state. >>>> >>>> >>>> >>>> -- >>>> View this message in context: >>>> http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16677.html >>>> Sent from the Apache Ignite Developers mailing list archive at >>>> Nabble.com. >> >> >> >> >> >> -- >> View this message in context: >> http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16758.html >> http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16758.html; >> Sent from the Apache Ignite Developers mailing list archive at Nabble.com >> http://nabble.com/;. -- View this message in context: http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16878.html Sent from the Apache Ignite Developers mailing list archive at Nabble.com.
Re: Adding ML to Ignite, IGNITE-4572
Denis, I prepared preliminary draft doc for readme.io, it reflects proposed rename. You can find it attached to JIRA IGNITE-4964 With regards to merge, per my reading of recent mail from Yury it is done except for module rename which is on its way to master now. regards, Oleg Denis Magda-2 wrote > Oleg, Nikita, Yuri, > > Frankly, I don’t like how the module is named presently which is > 'ignite-math’. > > I propose to rename it to ‘ignite-ml’. Presently, it holds a small > fraction of all ML functionality we might have in the future and this is > why, thinking of future, it will be a right decision to name it > accordingly. > > Any concerns? > > BTW, have the module been fully merged? I want to try to build it and > check the examples. > > — > Denis > >> On Apr 14, 2017, at 7:05 AM, oignatenko > oignatenko@ > wrote: >> >> Thank you Denis, that sounds like a good plan. I am working on it now. I >> didn't reassign IGNITE-4964, just set a watch on it. Will comment on it >> when >> I have concrete details to share. >> >> Side note my build check completed successfully, although it took quite a >> bit of time: I cleaned my local maven repo to make sure that things >> really >> work from the clean state. >> >> >> >> -- >> View this message in context: >> http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16677.html >> Sent from the Apache Ignite Developers mailing list archive at >> Nabble.com. -- View this message in context: http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16758.html Sent from the Apache Ignite Developers mailing list archive at Nabble.com.
Re: Adding ML to Ignite, IGNITE-4572
Thank you Denis, that sounds like a good plan. I am working on it now. I didn't reassign IGNITE-4964, just set a watch on it. Will comment on it when I have concrete details to share. Side note my build check completed successfully, although it took quite a bit of time: I cleaned my local maven repo to make sure that things really work from the clean state. -- View this message in context: http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16677.html Sent from the Apache Ignite Developers mailing list archive at Nabble.com.
Re: Adding ML to Ignite, IGNITE-4572
Yury, Denis - me and Nikita are going to take care of readme.io docs. I plan to start on this tomorrow, will keep you posted on the progress. Current plan is to briefly introduce new package and examples and explain how to run examples and possibly unit tests. With regards to build details, this will depend on how accurate is the description in project readme files: I am currently running build check to verify everything in details. If readme files are okay we will likely just refer readers to these for more details. In case if there are any discrepancies we will provide concrete build details at readme.io. If you have anything to add or correct in above plan please let me know. regards, Oleg Yury Babak wrote > As far as I know Nikita wants to provide this documentation. -- View this message in context: http://apache-ignite-developers.2346864.n4.nabble.com/Adding-ML-to-Ignite-IGNITE-4572-tp13936p16603.html Sent from the Apache Ignite Developers mailing list archive at Nabble.com.
