Re: Ignite 3227
Thank you Alexey !!! Regards Saikat On Fri, Jul 8, 2016 at 7:41 AM, Alexey Goncharuk <alexey.goncha...@gmail.com > wrote: > Saikat, > > I merged your PR to master. Thanks for the contribution! > > 2016-07-05 16:46 GMT-07:00 Dmitriy Setrakyan <dsetrak...@apache.org>: > > > I think we should add only 1 new method: > > > > long sizeLong(int partId, CachePeekMode peekMode) > > > > D. > > > > On Tue, Jul 5, 2016 at 3:24 PM, Alexander Paschenko < > > alexander.a.pasche...@gmail.com> wrote: > > > > > Alexey in Jira > > > > > > https://issues.apache.org/jira/browse/IGNITE-3227?focusedCommentId=15360787 > > > suggested that we remove int sized methods from CacheProxy, and he has > > > indeed removed them, but IgniteCache has such new methods too. Should > > > we let them be or maybe it would be better to get rid of them? Please > > > advise. Dmitriy Setrakyan, your opinion on the matter is of particular > > > interest. > > > > > > 2016-07-04 19:30 GMT+03:00 Saikat Maitra <saikat.mai...@gmail.com>: > > > > Thanks a lot Alexey. > > > > > > > > Regards > > > > Saikat > > > > > > > > On Mon, Jul 4, 2016 at 12:01 PM, Alexey Goncharuk < > > > > alexey.goncha...@gmail.com> wrote: > > > > > > > >> Saikat, > > > >> > > > >> Thanks for the contribution. I will make some minor changes to your > > > patch > > > >> and push it to master soon. > > > >> > > > >> 2016-06-26 9:57 GMT-07:00 Saikat Maitra <saikat.mai...@gmail.com>: > > > >> > > > >> > Hi Alexey, Ilya > > > >> > > > > >> > As discussed I have made the changes in the PR[1]. Please review > and > > > let > > > >> me > > > >> > know any feedback. > > > >> > > > > >> > [1] https://github.com/apache/ignite/pull/815 > > > >> > [2] https://issues.apache.org/jira/browse/IGNITE-3227 > > > >> > > > > >> > > > > >> > Regards > > > >> > Saikat > > > >> > > > > >> > On Mon, Jun 20, 2016 at 10:40 PM, Saikat Maitra < > > > saikat.mai...@gmail.com > > > >> > > > > >> > wrote: > > > >> > > > > >> > > Sure Alexey, > > > >> > > > > > >> > > Thank you > > > >> > > Saikat > > > >> > > > > > >> > > On Mon, Jun 20, 2016 at 10:36 PM, Alexey Goncharuk < > > > >> > > alexey.goncha...@gmail.com> wrote: > > > >> > > > > > >> > >> Saikat, > > > >> > >> > > > >> > >> Please also correct the test to check new methods for > PARTITIONED > > > and > > > >> > >> REPLICATED cache - I see that you only test them for local > cache > > > and > > > >> > >> partition 0 (I added a comment to the ticket). > > > >> > >> > > > >> > >> 2016-06-20 9:17 GMT-07:00 Saikat Maitra < > saikat.mai...@gmail.com > > >: > > > >> > >> > > > >> > >> > Thank you Ilya, I will review and update PR accordingly. > > > >> > >> > > > > >> > >> > Regards > > > >> > >> > Saikat > > > >> > >> > > > > >> > >> > On Mon, Jun 20, 2016 at 8:36 PM, Ilya Lantukh < > > > >> ilant...@gridgain.com> > > > >> > >> > wrote: > > > >> > >> > > > > >> > >> > > Hi Saikat, > > > >> > >> > > > > > >> > >> > > I've added a comment to the jira ticket regarding > > > implementation > > > >> of > > > >> > >> > > GridCacheAdapter#localSizeLong(int partition, > CachePeekMode[] > > > >> > >> peekModes) > > > >> > >> > > method. > > > >> > >> > > > > > >> > >> > > On Sat, Jun 18, 2016 at 12:19 PM, Saikat Maitra < > > > >> > >> saikat.mai...@gmail.com > > > >> > >> > > > > > >> > >> > > wrote: > > > >> > >> > > > > > >> > >> > > > Hi > > > >> > >> > > > > > > >> > >> > > > I have raised the PR[1] for the jira ticket Ignite 3227 > [2] > > > and > > > >> > >> wanted > > > >> > >> > to > > > >> > >> > > > discuss further on this issue. > > > >> > >> > > > > > > >> > >> > > > 1. I am running 2 nodes cluster and running in client > mode > > > >> another > > > >> > >> node > > > >> > >> > > for > > > >> > >> > > > functional test. I added 20 keys and keys are distributed > > in > > > 2 > > > >> > >> nodes as > > > >> > >> > > 11 > > > >> > >> > > > keys in node 1 and 9 keys in node 2. When I am printing > > > >> partition > > > >> > 1 > > > >> > >> > size > > > >> > >> > > > and partition 2 size I can get correct values but incase > I > > > >> provide > > > >> > >> some > > > >> > >> > > > other partition like 5 I am observing that I am getting > 11 > > as > > > >> > value. > > > >> > >> > > > > > > >> > >> > > > 2. I have added unit test testpartitionsize() similar to > > > >> > testSize() > > > >> > >> but > > > >> > >> > > > similar tests are failing for both the tests. Need > further > > > >> > >> > investigation > > > >> > >> > > on > > > >> > >> > > > the same. > > > >> > >> > > > > > > >> > >> > > > > > > >> > >> > > > Regards > > > >> > >> > > > Saikat > > > >> > >> > > > > > > >> > >> > > > [1] https://github.com/apache/ignite/pull/815 > > > >> > >> > > > [2] https://issues.apache.org/jira/browse/IGNITE-3227 > > > >> > >> > > > > > > >> > >> > > > > > >> > >> > > > > > >> > >> > > > > > >> > >> > > -- > > > >> > >> > > Best regards, > > > >> > >> > > Ilya > > > >> > >> > > > > > >> > >> > > > > >> > >> > > > >> > > > > > >> > > > > > >> > > > > >> > > > > > >
Re: Ignite 3227
Saikat, I merged your PR to master. Thanks for the contribution! 2016-07-05 16:46 GMT-07:00 Dmitriy Setrakyan <dsetrak...@apache.org>: > I think we should add only 1 new method: > > long sizeLong(int partId, CachePeekMode peekMode) > > D. > > On Tue, Jul 5, 2016 at 3:24 PM, Alexander Paschenko < > alexander.a.pasche...@gmail.com> wrote: > > > Alexey in Jira > > > https://issues.apache.org/jira/browse/IGNITE-3227?focusedCommentId=15360787 > > suggested that we remove int sized methods from CacheProxy, and he has > > indeed removed them, but IgniteCache has such new methods too. Should > > we let them be or maybe it would be better to get rid of them? Please > > advise. Dmitriy Setrakyan, your opinion on the matter is of particular > > interest. > > > > 2016-07-04 19:30 GMT+03:00 Saikat Maitra <saikat.mai...@gmail.com>: > > > Thanks a lot Alexey. > > > > > > Regards > > > Saikat > > > > > > On Mon, Jul 4, 2016 at 12:01 PM, Alexey Goncharuk < > > > alexey.goncha...@gmail.com> wrote: > > > > > >> Saikat, > > >> > > >> Thanks for the contribution. I will make some minor changes to your > > patch > > >> and push it to master soon. > > >> > > >> 2016-06-26 9:57 GMT-07:00 Saikat Maitra <saikat.mai...@gmail.com>: > > >> > > >> > Hi Alexey, Ilya > > >> > > > >> > As discussed I have made the changes in the PR[1]. Please review and > > let > > >> me > > >> > know any feedback. > > >> > > > >> > [1] https://github.com/apache/ignite/pull/815 > > >> > [2] https://issues.apache.org/jira/browse/IGNITE-3227 > > >> > > > >> > > > >> > Regards > > >> > Saikat > > >> > > > >> > On Mon, Jun 20, 2016 at 10:40 PM, Saikat Maitra < > > saikat.mai...@gmail.com > > >> > > > >> > wrote: > > >> > > > >> > > Sure Alexey, > > >> > > > > >> > > Thank you > > >> > > Saikat > > >> > > > > >> > > On Mon, Jun 20, 2016 at 10:36 PM, Alexey Goncharuk < > > >> > > alexey.goncha...@gmail.com> wrote: > > >> > > > > >> > >> Saikat, > > >> > >> > > >> > >> Please also correct the test to check new methods for PARTITIONED > > and > > >> > >> REPLICATED cache - I see that you only test them for local cache > > and > > >> > >> partition 0 (I added a comment to the ticket). > > >> > >> > > >> > >> 2016-06-20 9:17 GMT-07:00 Saikat Maitra <saikat.mai...@gmail.com > >: > > >> > >> > > >> > >> > Thank you Ilya, I will review and update PR accordingly. > > >> > >> > > > >> > >> > Regards > > >> > >> > Saikat > > >> > >> > > > >> > >> > On Mon, Jun 20, 2016 at 8:36 PM, Ilya Lantukh < > > >> ilant...@gridgain.com> > > >> > >> > wrote: > > >> > >> > > > >> > >> > > Hi Saikat, > > >> > >> > > > > >> > >> > > I've added a comment to the jira ticket regarding > > implementation > > >> of > > >> > >> > > GridCacheAdapter#localSizeLong(int partition, CachePeekMode[] > > >> > >> peekModes) > > >> > >> > > method. > > >> > >> > > > > >> > >> > > On Sat, Jun 18, 2016 at 12:19 PM, Saikat Maitra < > > >> > >> saikat.mai...@gmail.com > > >> > >> > > > > >> > >> > > wrote: > > >> > >> > > > > >> > >> > > > Hi > > >> > >> > > > > > >> > >> > > > I have raised the PR[1] for the jira ticket Ignite 3227 [2] > > and > > >> > >> wanted > > >> > >> > to > > >> > >> > > > discuss further on this issue. > > >> > >> > > > > > >> > >> > > > 1. I am running 2 nodes cluster and running in client mode > > >> another > > >> > >> node > > >> > >> > > for > > >> > >> > > > functional test. I added 20 keys and keys are distributed > in > > 2 > > >> > >> nodes as > > >> > >> > > 11 > > >> > >> > > > keys in node 1 and 9 keys in node 2. When I am printing > > >> partition > > >> > 1 > > >> > >> > size > > >> > >> > > > and partition 2 size I can get correct values but incase I > > >> provide > > >> > >> some > > >> > >> > > > other partition like 5 I am observing that I am getting 11 > as > > >> > value. > > >> > >> > > > > > >> > >> > > > 2. I have added unit test testpartitionsize() similar to > > >> > testSize() > > >> > >> but > > >> > >> > > > similar tests are failing for both the tests. Need further > > >> > >> > investigation > > >> > >> > > on > > >> > >> > > > the same. > > >> > >> > > > > > >> > >> > > > > > >> > >> > > > Regards > > >> > >> > > > Saikat > > >> > >> > > > > > >> > >> > > > [1] https://github.com/apache/ignite/pull/815 > > >> > >> > > > [2] https://issues.apache.org/jira/browse/IGNITE-3227 > > >> > >> > > > > > >> > >> > > > > >> > >> > > > > >> > >> > > > > >> > >> > > -- > > >> > >> > > Best regards, > > >> > >> > > Ilya > > >> > >> > > > > >> > >> > > > >> > >> > > >> > > > > >> > > > > >> > > > >> > > >
[GitHub] ignite pull request #815: IGNITE-3227 IgniteCache: add method to calculate s...
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/815 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Ignite 3227
I think we should add only 1 new method: long sizeLong(int partId, CachePeekMode peekMode) D. On Tue, Jul 5, 2016 at 3:24 PM, Alexander Paschenko < alexander.a.pasche...@gmail.com> wrote: > Alexey in Jira > https://issues.apache.org/jira/browse/IGNITE-3227?focusedCommentId=15360787 > suggested that we remove int sized methods from CacheProxy, and he has > indeed removed them, but IgniteCache has such new methods too. Should > we let them be or maybe it would be better to get rid of them? Please > advise. Dmitriy Setrakyan, your opinion on the matter is of particular > interest. > > 2016-07-04 19:30 GMT+03:00 Saikat Maitra <saikat.mai...@gmail.com>: > > Thanks a lot Alexey. > > > > Regards > > Saikat > > > > On Mon, Jul 4, 2016 at 12:01 PM, Alexey Goncharuk < > > alexey.goncha...@gmail.com> wrote: > > > >> Saikat, > >> > >> Thanks for the contribution. I will make some minor changes to your > patch > >> and push it to master soon. > >> > >> 2016-06-26 9:57 GMT-07:00 Saikat Maitra <saikat.mai...@gmail.com>: > >> > >> > Hi Alexey, Ilya > >> > > >> > As discussed I have made the changes in the PR[1]. Please review and > let > >> me > >> > know any feedback. > >> > > >> > [1] https://github.com/apache/ignite/pull/815 > >> > [2] https://issues.apache.org/jira/browse/IGNITE-3227 > >> > > >> > > >> > Regards > >> > Saikat > >> > > >> > On Mon, Jun 20, 2016 at 10:40 PM, Saikat Maitra < > saikat.mai...@gmail.com > >> > > >> > wrote: > >> > > >> > > Sure Alexey, > >> > > > >> > > Thank you > >> > > Saikat > >> > > > >> > > On Mon, Jun 20, 2016 at 10:36 PM, Alexey Goncharuk < > >> > > alexey.goncha...@gmail.com> wrote: > >> > > > >> > >> Saikat, > >> > >> > >> > >> Please also correct the test to check new methods for PARTITIONED > and > >> > >> REPLICATED cache - I see that you only test them for local cache > and > >> > >> partition 0 (I added a comment to the ticket). > >> > >> > >> > >> 2016-06-20 9:17 GMT-07:00 Saikat Maitra <saikat.mai...@gmail.com>: > >> > >> > >> > >> > Thank you Ilya, I will review and update PR accordingly. > >> > >> > > >> > >> > Regards > >> > >> > Saikat > >> > >> > > >> > >> > On Mon, Jun 20, 2016 at 8:36 PM, Ilya Lantukh < > >> ilant...@gridgain.com> > >> > >> > wrote: > >> > >> > > >> > >> > > Hi Saikat, > >> > >> > > > >> > >> > > I've added a comment to the jira ticket regarding > implementation > >> of > >> > >> > > GridCacheAdapter#localSizeLong(int partition, CachePeekMode[] > >> > >> peekModes) > >> > >> > > method. > >> > >> > > > >> > >> > > On Sat, Jun 18, 2016 at 12:19 PM, Saikat Maitra < > >> > >> saikat.mai...@gmail.com > >> > >> > > > >> > >> > > wrote: > >> > >> > > > >> > >> > > > Hi > >> > >> > > > > >> > >> > > > I have raised the PR[1] for the jira ticket Ignite 3227 [2] > and > >> > >> wanted > >> > >> > to > >> > >> > > > discuss further on this issue. > >> > >> > > > > >> > >> > > > 1. I am running 2 nodes cluster and running in client mode > >> another > >> > >> node > >> > >> > > for > >> > >> > > > functional test. I added 20 keys and keys are distributed in > 2 > >> > >> nodes as > >> > >> > > 11 > >> > >> > > > keys in node 1 and 9 keys in node 2. When I am printing > >> partition > >> > 1 > >> > >> > size > >> > >> > > > and partition 2 size I can get correct values but incase I > >> provide > >> > >> some > >> > >> > > > other partition like 5 I am observing that I am getting 11 as > >> > value. > >> > >> > > > > >> > >> > > > 2. I have added unit test testpartitionsize() similar to > >> > testSize() > >> > >> but > >> > >> > > > similar tests are failing for both the tests. Need further > >> > >> > investigation > >> > >> > > on > >> > >> > > > the same. > >> > >> > > > > >> > >> > > > > >> > >> > > > Regards > >> > >> > > > Saikat > >> > >> > > > > >> > >> > > > [1] https://github.com/apache/ignite/pull/815 > >> > >> > > > [2] https://issues.apache.org/jira/browse/IGNITE-3227 > >> > >> > > > > >> > >> > > > >> > >> > > > >> > >> > > > >> > >> > > -- > >> > >> > > Best regards, > >> > >> > > Ilya > >> > >> > > > >> > >> > > >> > >> > >> > > > >> > > > >> > > >> >
Re: Ignite 3227
Alexey in Jira https://issues.apache.org/jira/browse/IGNITE-3227?focusedCommentId=15360787 suggested that we remove int sized methods from CacheProxy, and he has indeed removed them, but IgniteCache has such new methods too. Should we let them be or maybe it would be better to get rid of them? Please advise. Dmitriy Setrakyan, your opinion on the matter is of particular interest. 2016-07-04 19:30 GMT+03:00 Saikat Maitra <saikat.mai...@gmail.com>: > Thanks a lot Alexey. > > Regards > Saikat > > On Mon, Jul 4, 2016 at 12:01 PM, Alexey Goncharuk < > alexey.goncha...@gmail.com> wrote: > >> Saikat, >> >> Thanks for the contribution. I will make some minor changes to your patch >> and push it to master soon. >> >> 2016-06-26 9:57 GMT-07:00 Saikat Maitra <saikat.mai...@gmail.com>: >> >> > Hi Alexey, Ilya >> > >> > As discussed I have made the changes in the PR[1]. Please review and let >> me >> > know any feedback. >> > >> > [1] https://github.com/apache/ignite/pull/815 >> > [2] https://issues.apache.org/jira/browse/IGNITE-3227 >> > >> > >> > Regards >> > Saikat >> > >> > On Mon, Jun 20, 2016 at 10:40 PM, Saikat Maitra <saikat.mai...@gmail.com >> > >> > wrote: >> > >> > > Sure Alexey, >> > > >> > > Thank you >> > > Saikat >> > > >> > > On Mon, Jun 20, 2016 at 10:36 PM, Alexey Goncharuk < >> > > alexey.goncha...@gmail.com> wrote: >> > > >> > >> Saikat, >> > >> >> > >> Please also correct the test to check new methods for PARTITIONED and >> > >> REPLICATED cache - I see that you only test them for local cache and >> > >> partition 0 (I added a comment to the ticket). >> > >> >> > >> 2016-06-20 9:17 GMT-07:00 Saikat Maitra <saikat.mai...@gmail.com>: >> > >> >> > >> > Thank you Ilya, I will review and update PR accordingly. >> > >> > >> > >> > Regards >> > >> > Saikat >> > >> > >> > >> > On Mon, Jun 20, 2016 at 8:36 PM, Ilya Lantukh < >> ilant...@gridgain.com> >> > >> > wrote: >> > >> > >> > >> > > Hi Saikat, >> > >> > > >> > >> > > I've added a comment to the jira ticket regarding implementation >> of >> > >> > > GridCacheAdapter#localSizeLong(int partition, CachePeekMode[] >> > >> peekModes) >> > >> > > method. >> > >> > > >> > >> > > On Sat, Jun 18, 2016 at 12:19 PM, Saikat Maitra < >> > >> saikat.mai...@gmail.com >> > >> > > >> > >> > > wrote: >> > >> > > >> > >> > > > Hi >> > >> > > > >> > >> > > > I have raised the PR[1] for the jira ticket Ignite 3227 [2] and >> > >> wanted >> > >> > to >> > >> > > > discuss further on this issue. >> > >> > > > >> > >> > > > 1. I am running 2 nodes cluster and running in client mode >> another >> > >> node >> > >> > > for >> > >> > > > functional test. I added 20 keys and keys are distributed in 2 >> > >> nodes as >> > >> > > 11 >> > >> > > > keys in node 1 and 9 keys in node 2. When I am printing >> partition >> > 1 >> > >> > size >> > >> > > > and partition 2 size I can get correct values but incase I >> provide >> > >> some >> > >> > > > other partition like 5 I am observing that I am getting 11 as >> > value. >> > >> > > > >> > >> > > > 2. I have added unit test testpartitionsize() similar to >> > testSize() >> > >> but >> > >> > > > similar tests are failing for both the tests. Need further >> > >> > investigation >> > >> > > on >> > >> > > > the same. >> > >> > > > >> > >> > > > >> > >> > > > Regards >> > >> > > > Saikat >> > >> > > > >> > >> > > > [1] https://github.com/apache/ignite/pull/815 >> > >> > > > [2] https://issues.apache.org/jira/browse/IGNITE-3227 >> > >> > > > >> > >> > > >> > >> > > >> > >> > > >> > >> > > -- >> > >> > > Best regards, >> > >> > > Ilya >> > >> > > >> > >> > >> > >> >> > > >> > > >> > >>
Re: Ignite 3227
Thanks a lot Alexey. Regards Saikat On Mon, Jul 4, 2016 at 12:01 PM, Alexey Goncharuk < alexey.goncha...@gmail.com> wrote: > Saikat, > > Thanks for the contribution. I will make some minor changes to your patch > and push it to master soon. > > 2016-06-26 9:57 GMT-07:00 Saikat Maitra <saikat.mai...@gmail.com>: > > > Hi Alexey, Ilya > > > > As discussed I have made the changes in the PR[1]. Please review and let > me > > know any feedback. > > > > [1] https://github.com/apache/ignite/pull/815 > > [2] https://issues.apache.org/jira/browse/IGNITE-3227 > > > > > > Regards > > Saikat > > > > On Mon, Jun 20, 2016 at 10:40 PM, Saikat Maitra <saikat.mai...@gmail.com > > > > wrote: > > > > > Sure Alexey, > > > > > > Thank you > > > Saikat > > > > > > On Mon, Jun 20, 2016 at 10:36 PM, Alexey Goncharuk < > > > alexey.goncha...@gmail.com> wrote: > > > > > >> Saikat, > > >> > > >> Please also correct the test to check new methods for PARTITIONED and > > >> REPLICATED cache - I see that you only test them for local cache and > > >> partition 0 (I added a comment to the ticket). > > >> > > >> 2016-06-20 9:17 GMT-07:00 Saikat Maitra <saikat.mai...@gmail.com>: > > >> > > >> > Thank you Ilya, I will review and update PR accordingly. > > >> > > > >> > Regards > > >> > Saikat > > >> > > > >> > On Mon, Jun 20, 2016 at 8:36 PM, Ilya Lantukh < > ilant...@gridgain.com> > > >> > wrote: > > >> > > > >> > > Hi Saikat, > > >> > > > > >> > > I've added a comment to the jira ticket regarding implementation > of > > >> > > GridCacheAdapter#localSizeLong(int partition, CachePeekMode[] > > >> peekModes) > > >> > > method. > > >> > > > > >> > > On Sat, Jun 18, 2016 at 12:19 PM, Saikat Maitra < > > >> saikat.mai...@gmail.com > > >> > > > > >> > > wrote: > > >> > > > > >> > > > Hi > > >> > > > > > >> > > > I have raised the PR[1] for the jira ticket Ignite 3227 [2] and > > >> wanted > > >> > to > > >> > > > discuss further on this issue. > > >> > > > > > >> > > > 1. I am running 2 nodes cluster and running in client mode > another > > >> node > > >> > > for > > >> > > > functional test. I added 20 keys and keys are distributed in 2 > > >> nodes as > > >> > > 11 > > >> > > > keys in node 1 and 9 keys in node 2. When I am printing > partition > > 1 > > >> > size > > >> > > > and partition 2 size I can get correct values but incase I > provide > > >> some > > >> > > > other partition like 5 I am observing that I am getting 11 as > > value. > > >> > > > > > >> > > > 2. I have added unit test testpartitionsize() similar to > > testSize() > > >> but > > >> > > > similar tests are failing for both the tests. Need further > > >> > investigation > > >> > > on > > >> > > > the same. > > >> > > > > > >> > > > > > >> > > > Regards > > >> > > > Saikat > > >> > > > > > >> > > > [1] https://github.com/apache/ignite/pull/815 > > >> > > > [2] https://issues.apache.org/jira/browse/IGNITE-3227 > > >> > > > > > >> > > > > >> > > > > >> > > > > >> > > -- > > >> > > Best regards, > > >> > > Ilya > > >> > > > > >> > > > >> > > > > > > > > >
Re: Ignite 3227
Saikat, Thanks for the contribution. I will make some minor changes to your patch and push it to master soon. 2016-06-26 9:57 GMT-07:00 Saikat Maitra <saikat.mai...@gmail.com>: > Hi Alexey, Ilya > > As discussed I have made the changes in the PR[1]. Please review and let me > know any feedback. > > [1] https://github.com/apache/ignite/pull/815 > [2] https://issues.apache.org/jira/browse/IGNITE-3227 > > > Regards > Saikat > > On Mon, Jun 20, 2016 at 10:40 PM, Saikat Maitra <saikat.mai...@gmail.com> > wrote: > > > Sure Alexey, > > > > Thank you > > Saikat > > > > On Mon, Jun 20, 2016 at 10:36 PM, Alexey Goncharuk < > > alexey.goncha...@gmail.com> wrote: > > > >> Saikat, > >> > >> Please also correct the test to check new methods for PARTITIONED and > >> REPLICATED cache - I see that you only test them for local cache and > >> partition 0 (I added a comment to the ticket). > >> > >> 2016-06-20 9:17 GMT-07:00 Saikat Maitra <saikat.mai...@gmail.com>: > >> > >> > Thank you Ilya, I will review and update PR accordingly. > >> > > >> > Regards > >> > Saikat > >> > > >> > On Mon, Jun 20, 2016 at 8:36 PM, Ilya Lantukh <ilant...@gridgain.com> > >> > wrote: > >> > > >> > > Hi Saikat, > >> > > > >> > > I've added a comment to the jira ticket regarding implementation of > >> > > GridCacheAdapter#localSizeLong(int partition, CachePeekMode[] > >> peekModes) > >> > > method. > >> > > > >> > > On Sat, Jun 18, 2016 at 12:19 PM, Saikat Maitra < > >> saikat.mai...@gmail.com > >> > > > >> > > wrote: > >> > > > >> > > > Hi > >> > > > > >> > > > I have raised the PR[1] for the jira ticket Ignite 3227 [2] and > >> wanted > >> > to > >> > > > discuss further on this issue. > >> > > > > >> > > > 1. I am running 2 nodes cluster and running in client mode another > >> node > >> > > for > >> > > > functional test. I added 20 keys and keys are distributed in 2 > >> nodes as > >> > > 11 > >> > > > keys in node 1 and 9 keys in node 2. When I am printing partition > 1 > >> > size > >> > > > and partition 2 size I can get correct values but incase I provide > >> some > >> > > > other partition like 5 I am observing that I am getting 11 as > value. > >> > > > > >> > > > 2. I have added unit test testpartitionsize() similar to > testSize() > >> but > >> > > > similar tests are failing for both the tests. Need further > >> > investigation > >> > > on > >> > > > the same. > >> > > > > >> > > > > >> > > > Regards > >> > > > Saikat > >> > > > > >> > > > [1] https://github.com/apache/ignite/pull/815 > >> > > > [2] https://issues.apache.org/jira/browse/IGNITE-3227 > >> > > > > >> > > > >> > > > >> > > > >> > > -- > >> > > Best regards, > >> > > Ilya > >> > > > >> > > >> > > > > >
Re: Ignite 3227
Hi Alexey, Ilya As discussed I have made the changes in the PR[1]. Please review and let me know any feedback. [1] https://github.com/apache/ignite/pull/815 [2] https://issues.apache.org/jira/browse/IGNITE-3227 Regards Saikat On Mon, Jun 20, 2016 at 10:40 PM, Saikat Maitra <saikat.mai...@gmail.com> wrote: > Sure Alexey, > > Thank you > Saikat > > On Mon, Jun 20, 2016 at 10:36 PM, Alexey Goncharuk < > alexey.goncha...@gmail.com> wrote: > >> Saikat, >> >> Please also correct the test to check new methods for PARTITIONED and >> REPLICATED cache - I see that you only test them for local cache and >> partition 0 (I added a comment to the ticket). >> >> 2016-06-20 9:17 GMT-07:00 Saikat Maitra <saikat.mai...@gmail.com>: >> >> > Thank you Ilya, I will review and update PR accordingly. >> > >> > Regards >> > Saikat >> > >> > On Mon, Jun 20, 2016 at 8:36 PM, Ilya Lantukh <ilant...@gridgain.com> >> > wrote: >> > >> > > Hi Saikat, >> > > >> > > I've added a comment to the jira ticket regarding implementation of >> > > GridCacheAdapter#localSizeLong(int partition, CachePeekMode[] >> peekModes) >> > > method. >> > > >> > > On Sat, Jun 18, 2016 at 12:19 PM, Saikat Maitra < >> saikat.mai...@gmail.com >> > > >> > > wrote: >> > > >> > > > Hi >> > > > >> > > > I have raised the PR[1] for the jira ticket Ignite 3227 [2] and >> wanted >> > to >> > > > discuss further on this issue. >> > > > >> > > > 1. I am running 2 nodes cluster and running in client mode another >> node >> > > for >> > > > functional test. I added 20 keys and keys are distributed in 2 >> nodes as >> > > 11 >> > > > keys in node 1 and 9 keys in node 2. When I am printing partition 1 >> > size >> > > > and partition 2 size I can get correct values but incase I provide >> some >> > > > other partition like 5 I am observing that I am getting 11 as value. >> > > > >> > > > 2. I have added unit test testpartitionsize() similar to testSize() >> but >> > > > similar tests are failing for both the tests. Need further >> > investigation >> > > on >> > > > the same. >> > > > >> > > > >> > > > Regards >> > > > Saikat >> > > > >> > > > [1] https://github.com/apache/ignite/pull/815 >> > > > [2] https://issues.apache.org/jira/browse/IGNITE-3227 >> > > > >> > > >> > > >> > > >> > > -- >> > > Best regards, >> > > Ilya >> > > >> > >> > >
Re: Ignite 3227
Sure Alexey, Thank you Saikat On Mon, Jun 20, 2016 at 10:36 PM, Alexey Goncharuk < alexey.goncha...@gmail.com> wrote: > Saikat, > > Please also correct the test to check new methods for PARTITIONED and > REPLICATED cache - I see that you only test them for local cache and > partition 0 (I added a comment to the ticket). > > 2016-06-20 9:17 GMT-07:00 Saikat Maitra <saikat.mai...@gmail.com>: > > > Thank you Ilya, I will review and update PR accordingly. > > > > Regards > > Saikat > > > > On Mon, Jun 20, 2016 at 8:36 PM, Ilya Lantukh <ilant...@gridgain.com> > > wrote: > > > > > Hi Saikat, > > > > > > I've added a comment to the jira ticket regarding implementation of > > > GridCacheAdapter#localSizeLong(int partition, CachePeekMode[] > peekModes) > > > method. > > > > > > On Sat, Jun 18, 2016 at 12:19 PM, Saikat Maitra < > saikat.mai...@gmail.com > > > > > > wrote: > > > > > > > Hi > > > > > > > > I have raised the PR[1] for the jira ticket Ignite 3227 [2] and > wanted > > to > > > > discuss further on this issue. > > > > > > > > 1. I am running 2 nodes cluster and running in client mode another > node > > > for > > > > functional test. I added 20 keys and keys are distributed in 2 nodes > as > > > 11 > > > > keys in node 1 and 9 keys in node 2. When I am printing partition 1 > > size > > > > and partition 2 size I can get correct values but incase I provide > some > > > > other partition like 5 I am observing that I am getting 11 as value. > > > > > > > > 2. I have added unit test testpartitionsize() similar to testSize() > but > > > > similar tests are failing for both the tests. Need further > > investigation > > > on > > > > the same. > > > > > > > > > > > > Regards > > > > Saikat > > > > > > > > [1] https://github.com/apache/ignite/pull/815 > > > > [2] https://issues.apache.org/jira/browse/IGNITE-3227 > > > > > > > > > > > > > > > > -- > > > Best regards, > > > Ilya > > > > > >
Re: Ignite 3227
Saikat, Please also correct the test to check new methods for PARTITIONED and REPLICATED cache - I see that you only test them for local cache and partition 0 (I added a comment to the ticket). 2016-06-20 9:17 GMT-07:00 Saikat Maitra <saikat.mai...@gmail.com>: > Thank you Ilya, I will review and update PR accordingly. > > Regards > Saikat > > On Mon, Jun 20, 2016 at 8:36 PM, Ilya Lantukh <ilant...@gridgain.com> > wrote: > > > Hi Saikat, > > > > I've added a comment to the jira ticket regarding implementation of > > GridCacheAdapter#localSizeLong(int partition, CachePeekMode[] peekModes) > > method. > > > > On Sat, Jun 18, 2016 at 12:19 PM, Saikat Maitra <saikat.mai...@gmail.com > > > > wrote: > > > > > Hi > > > > > > I have raised the PR[1] for the jira ticket Ignite 3227 [2] and wanted > to > > > discuss further on this issue. > > > > > > 1. I am running 2 nodes cluster and running in client mode another node > > for > > > functional test. I added 20 keys and keys are distributed in 2 nodes as > > 11 > > > keys in node 1 and 9 keys in node 2. When I am printing partition 1 > size > > > and partition 2 size I can get correct values but incase I provide some > > > other partition like 5 I am observing that I am getting 11 as value. > > > > > > 2. I have added unit test testpartitionsize() similar to testSize() but > > > similar tests are failing for both the tests. Need further > investigation > > on > > > the same. > > > > > > > > > Regards > > > Saikat > > > > > > [1] https://github.com/apache/ignite/pull/815 > > > [2] https://issues.apache.org/jira/browse/IGNITE-3227 > > > > > > > > > > > -- > > Best regards, > > Ilya > > >
Re: Ignite 3227
Thank you Ilya, I will review and update PR accordingly. Regards Saikat On Mon, Jun 20, 2016 at 8:36 PM, Ilya Lantukh <ilant...@gridgain.com> wrote: > Hi Saikat, > > I've added a comment to the jira ticket regarding implementation of > GridCacheAdapter#localSizeLong(int partition, CachePeekMode[] peekModes) > method. > > On Sat, Jun 18, 2016 at 12:19 PM, Saikat Maitra <saikat.mai...@gmail.com> > wrote: > > > Hi > > > > I have raised the PR[1] for the jira ticket Ignite 3227 [2] and wanted to > > discuss further on this issue. > > > > 1. I am running 2 nodes cluster and running in client mode another node > for > > functional test. I added 20 keys and keys are distributed in 2 nodes as > 11 > > keys in node 1 and 9 keys in node 2. When I am printing partition 1 size > > and partition 2 size I can get correct values but incase I provide some > > other partition like 5 I am observing that I am getting 11 as value. > > > > 2. I have added unit test testpartitionsize() similar to testSize() but > > similar tests are failing for both the tests. Need further investigation > on > > the same. > > > > > > Regards > > Saikat > > > > [1] https://github.com/apache/ignite/pull/815 > > [2] https://issues.apache.org/jira/browse/IGNITE-3227 > > > > > > -- > Best regards, > Ilya >
[GitHub] ignite pull request #815: Ignite 3227 - IgniteCache: add method to calculate...
GitHub user samaitra opened a pull request:
https://github.com/apache/ignite/pull/815
Ignite 3227 - IgniteCache: add method to calculate size per partition
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/samaitra/ignite IGNITE-3227
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/815.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #815
commit 155f7dd0f478d86757ebba5a6d957c2c5fb72ca0
Author: samaitra <saikat.mai...@gmail.com>
Date: 2016-06-16T20:08:37Z
IGNITE-3227 IgniteCache: add method to calculate size per partition
commit 3fb7cbfd7a751b738d2699f1d46c583b4669e45a
Author: samaitra <saikat.mai...@gmail.com>
Date: 2016-06-18T07:27:01Z
IGNITE-3227 IgniteCache: add method to calculate size per partition
commit 5d2f32a740156027438382a8ef5d3e763d3a948a
Author: samaitra <saikat.mai...@gmail.com>
Date: 2016-06-18T08:34:15Z
IGNITE-3227 IgniteCache: add method to calculate size per partition
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Created] (IGNITE-3227) IgniteCache: add method to calculate size per partition
Denis Magda created IGNITE-3227:
---
Summary: IgniteCache: add method to calculate size per partition
Key: IGNITE-3227
URL: https://issues.apache.org/jira/browse/IGNITE-3227
Project: Ignite
Issue Type: Improvement
Reporter: Denis Magda
It makes sense to add size calculation per partition. Actually the following
methods should be added to the {{IgniteCache}} API.
{code}
public int size(int partition, CachePeekMode... peekModes) throws
CacheException;
public int localSize(int partition, CachePeekMode... peekModes);
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
