Re: Null check removal in IGNITE-5779

[Dmitry Pavlov]

Hi Igor,

Could you please help with answering to this question?

Sincerely,
Dmitriy Pavlov

вт, 15 мая 2018 г. в 5:18, Sunny Chan, CLSA :

> Hello,
>
>
>
> In Ignite-5779 patch, CassandraSessionImpl.java line 289 a null check for row 
> has been removed (before the change: 
> https://github.com/apache/ignite/blob/924b1faa64026107bf933ba441e743cf52cb94d1/modules/cassandra/store/src/main/java/org/apache/ignite/cache/store/cassandra/session/CassandraSessionImpl.java#L289
>
> )
>
>
>
> I cannot tell immediately why the null check is no longer needed,
> especially the row assignment in line 289 can definitely return a null. Is
> it a mistake or we are expecting BatchExecutionAssistant is able to deal
> with null?
>
>
>
> Thanks.
>
>
>
> *Sunny Chan*
>
> *Senior Lead Engineer, Executive Services*
>
> D  +852 2600 8907 <+852%202600%208907>  |  M  +852 6386 1835
> <+852%206386%201835>  |  T  +852 2600  <+852%202600%20>
>
> 5/F, One Island East, 18 Westlands Road
> ,
> Island East, Hong Kong
>
>
>
> [image: :1. Social Media Icons:CLSA_Social Media Icons_linkedin.png]
> [image: :1. Social Media
> Icons:CLSA_Social Media Icons_twitter.png]
> [image: :1. Social Media
> Icons:CLSA_Social Media Icons_youtube.png]
> [image: :1.
> Social Media Icons:CLSA_Social Media Icons_facebook.png]
> 
>
>
>
> *clsa.com* 
>
> *Insights. Liquidity. Capital. *
>
>
>
> [image: CLSA_RGB] 
>
>
>
> *A CITIC Securities Company*
>
>
>
> The content of this communication is intended for the recipient and is
> subject to CLSA Legal and Regulatory Notices.
> These can be viewed at https://www.clsa.com/disclaimer.html or sent to
> you upon request.
> Please consider before printing. CLSA is ISO14001 certified and committed
> to reducing its impact on the environment.
>

Null check removal in IGNITE-5779

[Sunny Chan, CLSA]

Hello,


In Ignite-5779 patch, CassandraSessionImpl.java line 289 a null check for row 
has been removed (before the change: 
https://github.com/apache/ignite/blob/924b1faa64026107bf933ba441e743cf52cb94d1/modules/cassandra/store/src/main/java/org/apache/ignite/cache/store/cassandra/session/CassandraSessionImpl.java#L289
)

I cannot tell immediately why the null check is no longer needed, especially 
the row assignment in line 289 can definitely return a null. Is it a mistake or 
we are expecting BatchExecutionAssistant is able to deal with null?

Thanks.

Sunny Chan
Senior Lead Engineer, Executive Services
D  +852 2600 8907  |  M  +852 6386 1835  |  T  +852 2600 
5/F, One Island East, 18 Westlands Road, Island East, Hong Kong

[:1. Social Media Icons:CLSA_Social Media 
Icons_linkedin.png][:1. Social Media 
Icons:CLSA_Social Media 
Icons_twitter.png][:1. Social Media 
Icons:CLSA_Social Media 
Icons_youtube.png][:1.
 Social Media Icons:CLSA_Social Media 
Icons_facebook.png]

clsa.com
Insights. Liquidity. Capital.

[CLSA_RGB]

A CITIC Securities Company

The content of this communication is intended for the recipient and is subject 
to CLSA Legal and Regulatory Notices.
These can be viewed at https://www.clsa.com/disclaimer.html or sent to you upon 
request.
Please consider before printing. CLSA is ISO14001 certified and committed to 
reducing its impact on the environment.