Re: Visor plugin
+1 > Hi, All! > > I think that the best way is to do the following: > 1. Move controls.sh to separate module (this will allow us to use any third > party libs for argument parsing, interactive mode, and other stuff). > 2. Move all colde from visorcmd to controls.sh > 3. Drop visorcmd пт, 27 дек. 2019 г. в 13:01, Alexey Goncharuk : > > Here are my two cents on the topic: > * Obviously it is bad to have two different management console utilities, > so visorcmd and control.sh should be merged into a single utility > * In my personal opinion, this utility should _not_ be interactive. In the > current state it is impossible to use visorcmd in any kind of automation. > On the other hand, I know a few users who successfully use control.sh in > scripts > * Daemon nodes is definitely not the way how the utility should interact > with the cluster. There were a few discussions here on the dev-list related > to the daemon nodes solely and they are in the "to be removed" wishlist for > 3.0 [1] > * We should get rid of the scala code unless it is absolutely required > (like in Spark integration, for example). Multi-language modules are hard > to maintain and they set significantly higher entry barrier for new and > existing contributors. We may expect the utility to be used and hopefully > supported by many people, so the entry barrier here should be as low as > possible. Currently, scala usage in the module adds absolutely no value to > the project. > > Having said all that, I incline to have control.sh to be used as a baseline > and move functionality from visorcmd to the new utility as needed/wanted. > > --AG > > [1] > https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+3.0+Wishlist > > пт, 27 дек. 2019 г. в 09:40, Николай Ижиков : > > > > 2. Move all colde from visorcmd to controls.sh > > > 3. Drop visorcm > > > > Hello, Zhenya, Alexey, can you, please, clarify, why you suggest dropping > > of visorcmd? > > What are the problems of the visorcmd that can’t be solved? > > > > > > > 27 дек. 2019 г., в 09:26, Zhenya Stanilovsky > > написал(а): > > > > > > > > > +1 here. > > > > > > > > >> Hi, All! > > >> > > >> I think that the best way is to do the following: > > >> 1. Move controls.sh to separate module (this will allow us to use any > > third > > >> party libs for argument parsing, interactive mode, and other stuff). > > >> 2. Move all colde from visorcmd to controls.sh > > >> 3. Drop visorcmd > > >> > > >> On Thu, Dec 26, 2019 at 11:29 PM Николай Ижиков < nizhi...@apache.org > > > wrote: > > >> > > >>> +1 to keep visor cmd and fix it’s issues. > > >>> > > >>>> 26 дек. 2019 г., в 19:23, Denis Magda < dma...@apache.org > > > написал(а): > > >>>> > > >>>> Personally, I see no reason for deprecating Visor CLI and moving all > > its > > >>>> capabilities to the control.sh script. It's better to merge the > > script's > > >>>> capabilities into Visor CLI and rework the connectivity/communication > > >>>> protocol of the latter. If to recall the reason for the control.sh > > >>> creation > > >>>> it was the Visor's daemon-mode way of interaction with the cluster > > that > > >>> is > > >>>> cumbersome and complicated. > > >>>> > > >>>> - > > >>>> Denis > > >>>> > > >>>> > > >>>> On Thu, Dec 26, 2019 at 1:49 AM Ilya Kasnacheev < > > >>> ilya.kasnach...@gmail.com > > > >>>> wrote: > > >>>> > > >>>>> Hello! > > >>>>> > > >>>>> I think that control.sh should be extended instead of Visor CLI, it > > is a > > >>>>> tool which sees a lot more activity currently. > > >>>>> > > >>>>> Regards, > > >>>>> -- > > >>>>> Ilya Kasnacheev > > >>>>> > > >>>>> > > >>>>> чт, 26 дек. 2019 г. в 12:45, Ivan Pavlukhin < vololo...@gmail.com >: > > >>>>> > > >>>>>> Folks, > > >>>>>> > > >>>>>> Do not we have plans to discontinue Visor? If so, it might be better > > >>>>>> to add a desired funct
Re: Visor plugin
Here are my two cents on the topic: * Obviously it is bad to have two different management console utilities, so visorcmd and control.sh should be merged into a single utility * In my personal opinion, this utility should _not_ be interactive. In the current state it is impossible to use visorcmd in any kind of automation. On the other hand, I know a few users who successfully use control.sh in scripts * Daemon nodes is definitely not the way how the utility should interact with the cluster. There were a few discussions here on the dev-list related to the daemon nodes solely and they are in the "to be removed" wishlist for 3.0 [1] * We should get rid of the scala code unless it is absolutely required (like in Spark integration, for example). Multi-language modules are hard to maintain and they set significantly higher entry barrier for new and existing contributors. We may expect the utility to be used and hopefully supported by many people, so the entry barrier here should be as low as possible. Currently, scala usage in the module adds absolutely no value to the project. Having said all that, I incline to have control.sh to be used as a baseline and move functionality from visorcmd to the new utility as needed/wanted. --AG [1] https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+3.0+Wishlist пт, 27 дек. 2019 г. в 09:40, Николай Ижиков : > > 2. Move all colde from visorcmd to controls.sh > > 3. Drop visorcm > > Hello, Zhenya, Alexey, can you, please, clarify, why you suggest dropping > of visorcmd? > What are the problems of the visorcmd that can’t be solved? > > > > 27 дек. 2019 г., в 09:26, Zhenya Stanilovsky > написал(а): > > > > > > +1 here. > > > > > >> Hi, All! > >> > >> I think that the best way is to do the following: > >> 1. Move controls.sh to separate module (this will allow us to use any > third > >> party libs for argument parsing, interactive mode, and other stuff). > >> 2. Move all colde from visorcmd to controls.sh > >> 3. Drop visorcmd > >> > >> On Thu, Dec 26, 2019 at 11:29 PM Николай Ижиков < nizhi...@apache.org > > wrote: > >> > >>> +1 to keep visor cmd and fix it’s issues. > >>> > >>>> 26 дек. 2019 г., в 19:23, Denis Magda < dma...@apache.org > > написал(а): > >>>> > >>>> Personally, I see no reason for deprecating Visor CLI and moving all > its > >>>> capabilities to the control.sh script. It's better to merge the > script's > >>>> capabilities into Visor CLI and rework the connectivity/communication > >>>> protocol of the latter. If to recall the reason for the control.sh > >>> creation > >>>> it was the Visor's daemon-mode way of interaction with the cluster > that > >>> is > >>>> cumbersome and complicated. > >>>> > >>>> - > >>>> Denis > >>>> > >>>> > >>>> On Thu, Dec 26, 2019 at 1:49 AM Ilya Kasnacheev < > >>> ilya.kasnach...@gmail.com > > >>>> wrote: > >>>> > >>>>> Hello! > >>>>> > >>>>> I think that control.sh should be extended instead of Visor CLI, it > is a > >>>>> tool which sees a lot more activity currently. > >>>>> > >>>>> Regards, > >>>>> -- > >>>>> Ilya Kasnacheev > >>>>> > >>>>> > >>>>> чт, 26 дек. 2019 г. в 12:45, Ivan Pavlukhin < vololo...@gmail.com >: > >>>>> > >>>>>> Folks, > >>>>>> > >>>>>> Do not we have plans to discontinue Visor? If so, it might be better > >>>>>> to add a desired functionality to another management API? > >>>>>> > >>>>>> вт, 24 дек. 2019 г. в 08:02, Denis Magda < dma...@apache.org >: > >>>>>>> > >>>>>>> Forwarding to the dev list. How exactly would you like to expand > Visor > >>>>>> CMD? > >>>>>>> Please describe your idea and we can mover from that point. > >>>>>>> > >>>>>>> Denis > >>>>>>> > >>>>>>> On Monday, December 23, 2019, sgtech19 < rajado...@gmail.com > > wrote: > >>>>>>> > >>>>>>>> Hello team, > >>>>>>>> I would like to add a new feature to the existing > >>>>>> visor > >>>>>>>> commands. Could you give me some direction on how to achieve this > if > >>>>>> its > >>>>>>>> possible? Do we need a visor plugin ? if so,please provide any > >>>>> example > >>>>>> of > >>>>>>>> this plugin . > >>>>>>>> > >>>>>>>> Thanks > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> -- > >>>>>>>> Sent from: http://apache-ignite-users.70518.x6.nabble.com/ > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> -- > >>>>>>> - > >>>>>>> Denis > >>>>>> > >>>>>> > >>>>>> > >>>>>> -- > >>>>>> Best regards, > >>>>>> Ivan Pavlukhin > >>>>>> > >>>>> > >>> > >>> > >> -- > >> Alexey Kuznetsov > >> > > > > > > > > > >
Re: Visor plugin
> 2. Move all colde from visorcmd to controls.sh > 3. Drop visorcm Hello, Zhenya, Alexey, can you, please, clarify, why you suggest dropping of visorcmd? What are the problems of the visorcmd that can’t be solved? > 27 дек. 2019 г., в 09:26, Zhenya Stanilovsky > написал(а): > > > +1 here. > > >> Hi, All! >> >> I think that the best way is to do the following: >> 1. Move controls.sh to separate module (this will allow us to use any third >> party libs for argument parsing, interactive mode, and other stuff). >> 2. Move all colde from visorcmd to controls.sh >> 3. Drop visorcmd >> >> On Thu, Dec 26, 2019 at 11:29 PM Николай Ижиков < nizhi...@apache.org > >> wrote: >> >>> +1 to keep visor cmd and fix it’s issues. >>> >>>> 26 дек. 2019 г., в 19:23, Denis Magda < dma...@apache.org > написал(а): >>>> >>>> Personally, I see no reason for deprecating Visor CLI and moving all its >>>> capabilities to the control.sh script. It's better to merge the script's >>>> capabilities into Visor CLI and rework the connectivity/communication >>>> protocol of the latter. If to recall the reason for the control.sh >>> creation >>>> it was the Visor's daemon-mode way of interaction with the cluster that >>> is >>>> cumbersome and complicated. >>>> >>>> - >>>> Denis >>>> >>>> >>>> On Thu, Dec 26, 2019 at 1:49 AM Ilya Kasnacheev < >>> ilya.kasnach...@gmail.com > >>>> wrote: >>>> >>>>> Hello! >>>>> >>>>> I think that control.sh should be extended instead of Visor CLI, it is a >>>>> tool which sees a lot more activity currently. >>>>> >>>>> Regards, >>>>> -- >>>>> Ilya Kasnacheev >>>>> >>>>> >>>>> чт, 26 дек. 2019 г. в 12:45, Ivan Pavlukhin < vololo...@gmail.com >: >>>>> >>>>>> Folks, >>>>>> >>>>>> Do not we have plans to discontinue Visor? If so, it might be better >>>>>> to add a desired functionality to another management API? >>>>>> >>>>>> вт, 24 дек. 2019 г. в 08:02, Denis Magda < dma...@apache.org >: >>>>>>> >>>>>>> Forwarding to the dev list. How exactly would you like to expand Visor >>>>>> CMD? >>>>>>> Please describe your idea and we can mover from that point. >>>>>>> >>>>>>> Denis >>>>>>> >>>>>>> On Monday, December 23, 2019, sgtech19 < rajado...@gmail.com > wrote: >>>>>>> >>>>>>>> Hello team, >>>>>>>> I would like to add a new feature to the existing >>>>>> visor >>>>>>>> commands. Could you give me some direction on how to achieve this if >>>>>> its >>>>>>>> possible? Do we need a visor plugin ? if so,please provide any >>>>> example >>>>>> of >>>>>>>> this plugin . >>>>>>>> >>>>>>>> Thanks >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Sent from: http://apache-ignite-users.70518.x6.nabble.com/ >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> - >>>>>>> Denis >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Best regards, >>>>>> Ivan Pavlukhin >>>>>> >>>>> >>> >>> >> -- >> Alexey Kuznetsov >> > > > >
Re[2]: Visor plugin
+1 here. >Hi, All! > >I think that the best way is to do the following: >1. Move controls.sh to separate module (this will allow us to use any third >party libs for argument parsing, interactive mode, and other stuff). >2. Move all colde from visorcmd to controls.sh >3. Drop visorcmd > >On Thu, Dec 26, 2019 at 11:29 PM Николай Ижиков < nizhi...@apache.org > wrote: > >> +1 to keep visor cmd and fix it’s issues. >> >> > 26 дек. 2019 г., в 19:23, Denis Magda < dma...@apache.org > написал(а): >> > >> > Personally, I see no reason for deprecating Visor CLI and moving all its >> > capabilities to the control.sh script. It's better to merge the script's >> > capabilities into Visor CLI and rework the connectivity/communication >> > protocol of the latter. If to recall the reason for the control.sh >> creation >> > it was the Visor's daemon-mode way of interaction with the cluster that >> is >> > cumbersome and complicated. >> > >> > - >> > Denis >> > >> > >> > On Thu, Dec 26, 2019 at 1:49 AM Ilya Kasnacheev < >> ilya.kasnach...@gmail.com > >> > wrote: >> > >> >> Hello! >> >> >> >> I think that control.sh should be extended instead of Visor CLI, it is a >> >> tool which sees a lot more activity currently. >> >> >> >> Regards, >> >> -- >> >> Ilya Kasnacheev >> >> >> >> >> >> чт, 26 дек. 2019 г. в 12:45, Ivan Pavlukhin < vololo...@gmail.com >: >> >> >> >>> Folks, >> >>> >> >>> Do not we have plans to discontinue Visor? If so, it might be better >> >>> to add a desired functionality to another management API? >> >>> >> >>> вт, 24 дек. 2019 г. в 08:02, Denis Magda < dma...@apache.org >: >> >>>> >> >>>> Forwarding to the dev list. How exactly would you like to expand Visor >> >>> CMD? >> >>>> Please describe your idea and we can mover from that point. >> >>>> >> >>>> Denis >> >>>> >> >>>> On Monday, December 23, 2019, sgtech19 < rajado...@gmail.com > wrote: >> >>>> >> >>>>> Hello team, >> >>>>> I would like to add a new feature to the existing >> >>> visor >> >>>>> commands. Could you give me some direction on how to achieve this if >> >>> its >> >>>>> possible? Do we need a visor plugin ? if so,please provide any >> >> example >> >>> of >> >>>>> this plugin . >> >>>>> >> >>>>> Thanks >> >>>>> >> >>>>> >> >>>>> >> >>>>> -- >> >>>>> Sent from: http://apache-ignite-users.70518.x6.nabble.com/ >> >>>>> >> >>>> >> >>>> >> >>>> -- >> >>>> - >> >>>> Denis >> >>> >> >>> >> >>> >> >>> -- >> >>> Best regards, >> >>> Ivan Pavlukhin >> >>> >> >> >> >> >-- >Alexey Kuznetsov >
Re: Visor plugin
Hi, All! I think that the best way is to do the following: 1. Move controls.sh to separate module (this will allow us to use any third party libs for argument parsing, interactive mode, and other stuff). 2. Move all colde from visorcmd to controls.sh 3. Drop visorcmd On Thu, Dec 26, 2019 at 11:29 PM Николай Ижиков wrote: > +1 to keep visor cmd and fix it’s issues. > > > 26 дек. 2019 г., в 19:23, Denis Magda написал(а): > > > > Personally, I see no reason for deprecating Visor CLI and moving all its > > capabilities to the control.sh script. It's better to merge the script's > > capabilities into Visor CLI and rework the connectivity/communication > > protocol of the latter. If to recall the reason for the control.sh > creation > > it was the Visor's daemon-mode way of interaction with the cluster that > is > > cumbersome and complicated. > > > > - > > Denis > > > > > > On Thu, Dec 26, 2019 at 1:49 AM Ilya Kasnacheev < > ilya.kasnach...@gmail.com> > > wrote: > > > >> Hello! > >> > >> I think that control.sh should be extended instead of Visor CLI, it is a > >> tool which sees a lot more activity currently. > >> > >> Regards, > >> -- > >> Ilya Kasnacheev > >> > >> > >> чт, 26 дек. 2019 г. в 12:45, Ivan Pavlukhin : > >> > >>> Folks, > >>> > >>> Do not we have plans to discontinue Visor? If so, it might be better > >>> to add a desired functionality to another management API? > >>> > >>> вт, 24 дек. 2019 г. в 08:02, Denis Magda : > >>>> > >>>> Forwarding to the dev list. How exactly would you like to expand Visor > >>> CMD? > >>>> Please describe your idea and we can mover from that point. > >>>> > >>>> Denis > >>>> > >>>> On Monday, December 23, 2019, sgtech19 wrote: > >>>> > >>>>> Hello team, > >>>>> I would like to add a new feature to the existing > >>> visor > >>>>> commands. Could you give me some direction on how to achieve this if > >>> its > >>>>> possible? Do we need a visor plugin ? if so,please provide any > >> example > >>> of > >>>>> this plugin . > >>>>> > >>>>> Thanks > >>>>> > >>>>> > >>>>> > >>>>> -- > >>>>> Sent from: http://apache-ignite-users.70518.x6.nabble.com/ > >>>>> > >>>> > >>>> > >>>> -- > >>>> - > >>>> Denis > >>> > >>> > >>> > >>> -- > >>> Best regards, > >>> Ivan Pavlukhin > >>> > >> > > -- Alexey Kuznetsov
Re: Visor plugin
+1 to keep visor cmd and fix it’s issues. > 26 дек. 2019 г., в 19:23, Denis Magda написал(а): > > Personally, I see no reason for deprecating Visor CLI and moving all its > capabilities to the control.sh script. It's better to merge the script's > capabilities into Visor CLI and rework the connectivity/communication > protocol of the latter. If to recall the reason for the control.sh creation > it was the Visor's daemon-mode way of interaction with the cluster that is > cumbersome and complicated. > > - > Denis > > > On Thu, Dec 26, 2019 at 1:49 AM Ilya Kasnacheev > wrote: > >> Hello! >> >> I think that control.sh should be extended instead of Visor CLI, it is a >> tool which sees a lot more activity currently. >> >> Regards, >> -- >> Ilya Kasnacheev >> >> >> чт, 26 дек. 2019 г. в 12:45, Ivan Pavlukhin : >> >>> Folks, >>> >>> Do not we have plans to discontinue Visor? If so, it might be better >>> to add a desired functionality to another management API? >>> >>> вт, 24 дек. 2019 г. в 08:02, Denis Magda : >>>> >>>> Forwarding to the dev list. How exactly would you like to expand Visor >>> CMD? >>>> Please describe your idea and we can mover from that point. >>>> >>>> Denis >>>> >>>> On Monday, December 23, 2019, sgtech19 wrote: >>>> >>>>> Hello team, >>>>> I would like to add a new feature to the existing >>> visor >>>>> commands. Could you give me some direction on how to achieve this if >>> its >>>>> possible? Do we need a visor plugin ? if so,please provide any >> example >>> of >>>>> this plugin . >>>>> >>>>> Thanks >>>>> >>>>> >>>>> >>>>> -- >>>>> Sent from: http://apache-ignite-users.70518.x6.nabble.com/ >>>>> >>>> >>>> >>>> -- >>>> - >>>> Denis >>> >>> >>> >>> -- >>> Best regards, >>> Ivan Pavlukhin >>> >>
Re: Visor plugin
Personally, I see no reason for deprecating Visor CLI and moving all its capabilities to the control.sh script. It's better to merge the script's capabilities into Visor CLI and rework the connectivity/communication protocol of the latter. If to recall the reason for the control.sh creation it was the Visor's daemon-mode way of interaction with the cluster that is cumbersome and complicated. - Denis On Thu, Dec 26, 2019 at 1:49 AM Ilya Kasnacheev wrote: > Hello! > > I think that control.sh should be extended instead of Visor CLI, it is a > tool which sees a lot more activity currently. > > Regards, > -- > Ilya Kasnacheev > > > чт, 26 дек. 2019 г. в 12:45, Ivan Pavlukhin : > > > Folks, > > > > Do not we have plans to discontinue Visor? If so, it might be better > > to add a desired functionality to another management API? > > > > вт, 24 дек. 2019 г. в 08:02, Denis Magda : > > > > > > Forwarding to the dev list. How exactly would you like to expand Visor > > CMD? > > > Please describe your idea and we can mover from that point. > > > > > > Denis > > > > > > On Monday, December 23, 2019, sgtech19 wrote: > > > > > > > Hello team, > > > > I would like to add a new feature to the existing > > visor > > > > commands. Could you give me some direction on how to achieve this if > > its > > > > possible? Do we need a visor plugin ? if so,please provide any > example > > of > > > > this plugin . > > > > > > > > Thanks > > > > > > > > > > > > > > > > -- > > > > Sent from: http://apache-ignite-users.70518.x6.nabble.com/ > > > > > > > > > > > > > -- > > > - > > > Denis > > > > > > > > -- > > Best regards, > > Ivan Pavlukhin > > >
Re: Visor plugin
Hello! I think that control.sh should be extended instead of Visor CLI, it is a tool which sees a lot more activity currently. Regards, -- Ilya Kasnacheev чт, 26 дек. 2019 г. в 12:45, Ivan Pavlukhin : > Folks, > > Do not we have plans to discontinue Visor? If so, it might be better > to add a desired functionality to another management API? > > вт, 24 дек. 2019 г. в 08:02, Denis Magda : > > > > Forwarding to the dev list. How exactly would you like to expand Visor > CMD? > > Please describe your idea and we can mover from that point. > > > > Denis > > > > On Monday, December 23, 2019, sgtech19 wrote: > > > > > Hello team, > > > I would like to add a new feature to the existing > visor > > > commands. Could you give me some direction on how to achieve this if > its > > > possible? Do we need a visor plugin ? if so,please provide any example > of > > > this plugin . > > > > > > Thanks > > > > > > > > > > > > -- > > > Sent from: http://apache-ignite-users.70518.x6.nabble.com/ > > > > > > > > > -- > > - > > Denis > > > > -- > Best regards, > Ivan Pavlukhin >
Re: Visor plugin
Folks, Do not we have plans to discontinue Visor? If so, it might be better to add a desired functionality to another management API? вт, 24 дек. 2019 г. в 08:02, Denis Magda : > > Forwarding to the dev list. How exactly would you like to expand Visor CMD? > Please describe your idea and we can mover from that point. > > Denis > > On Monday, December 23, 2019, sgtech19 wrote: > > > Hello team, > > I would like to add a new feature to the existing visor > > commands. Could you give me some direction on how to achieve this if its > > possible? Do we need a visor plugin ? if so,please provide any example of > > this plugin . > > > > Thanks > > > > > > > > -- > > Sent from: http://apache-ignite-users.70518.x6.nabble.com/ > > > > > -- > - > Denis -- Best regards, Ivan Pavlukhin
Re: Visor plugin
Forwarding to the dev list. How exactly would you like to expand Visor CMD? Please describe your idea and we can mover from that point. Denis On Monday, December 23, 2019, sgtech19 wrote: > Hello team, > I would like to add a new feature to the existing visor > commands. Could you give me some direction on how to achieve this if its > possible? Do we need a visor plugin ? if so,please provide any example of > this plugin . > > Thanks > > > > -- > Sent from: http://apache-ignite-users.70518.x6.nabble.com/ > -- - Denis
