Re: Great job on the restructuring!

2023-07-29 Thread Xiangdong Huang
welcome to continuously refactor and optimize the project structure :D

---
Xiangdong Huang

Christofer Dutz  于2023年7月27日周四 22:48写道:
>
> Hi Folks,
>
> I sort of missed most of it as git tends to keep the moved directories, if 
> there’s something in there … as they all contained “target” directories,
> I just noticed the cleaned-up structure of the project … awesome work.
>
> I took the liberty of applying the same structural changes on the reactor (No 
> worries, in a branch)
> There I introduced intermediate sub-parent poms.
> Also did I clean up the pom structure, where it needed some cleaning up.
>
> Now in IntelliJ (and probably every other Maven-Enabled IDE) the project 
> should also be structured nicely, and the modules have equally formatted 
> names.
>
> The changes should not have any real impact on the project and the build.
>
> In general, I would prefer adjusting the artifact-ids to replicate the module 
> structure, but this is already a lot better, and I wasn’t sure of the 
> implications of artifact renaming in upstream builds.
>
> Chris


Great job on the restructuring!

2023-07-27 Thread Christofer Dutz
Hi Folks,

I sort of missed most of it as git tends to keep the moved directories, if 
there’s something in there … as they all contained “target” directories,
I just noticed the cleaned-up structure of the project … awesome work.

I took the liberty of applying the same structural changes on the reactor (No 
worries, in a branch)
There I introduced intermediate sub-parent poms.
Also did I clean up the pom structure, where it needed some cleaning up.

Now in IntelliJ (and probably every other Maven-Enabled IDE) the project should 
also be structured nicely, and the modules have equally formatted names.

The changes should not have any real impact on the project and the build.

In general, I would prefer adjusting the artifact-ids to replicate the module 
structure, but this is already a lot better, and I wasn’t sure of the 
implications of artifact renaming in upstream builds.

Chris