Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
Hi, Given that it causes a lot of confusion, I updated the file to the latest version in maven-wrapper project with its origin header. And update the LICENSE: ``` The following class is copied from maven-wrapper (https://github.com/takari/maven-wrapper), which is under Apache License 2.0: ./.mvn/wrapper/MavenWrapperDownloader.java ``` If no more problems, I will prepare to release RC3. Thanks, -- Jialin Qiao School of Software, Tsinghua University 乔嘉林 清华大学 软件学院 > -原始邮件- > 发件人: "Christofer Dutz" > 发送时间: 2019-11-20 16:48:32 (星期三) > 收件人: "dev@iotdb.apache.org" > 抄送: > 主题: Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release > > Hi Justin, > > Sure, we could do that, but I just wanted to point out that your -1 for that > wasn't justified ;-) > If the file is replaced, it would need to be mentioned. > > Chris > > > Am 20.11.19, 09:38 schrieb "Justin Mclean" : > > Hi, > > > But thanks for pointing that out ... I should fix at least the typos > ... and update to the latest Maven-Wrapper version ;-) > > Why not use their latest? It’s already listed in LICENSE so all you would > need to do is replace the file with the latest. > > Thanks, > Justin >
Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
Hi Justin, Sure, we could do that, but I just wanted to point out that your -1 for that wasn't justified ;-) If the file is replaced, it would need to be mentioned. Chris Am 20.11.19, 09:38 schrieb "Justin Mclean" : Hi, > But thanks for pointing that out ... I should fix at least the typos ... and update to the latest Maven-Wrapper version ;-) Why not use their latest? It’s already listed in LICENSE so all you would need to do is replace the file with the latest. Thanks, Justin
Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
Hi, > But thanks for pointing that out ... I should fix at least the typos ... and > update to the latest Maven-Wrapper version ;-) Why not use their latest? It’s already listed in LICENSE so all you would need to do is replace the file with the latest. Thanks, Justin
Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
Hi Justin, If you compare the two you will see that none of the changes applied to the file in the original one are contained in the version I put there. So it IS the original file I put there. But thanks for pointing that out ... I should fix at least the typos ... and update to the latest Maven-Wrapper version ;-) Chris Am 20.11.19, 07:08 schrieb "Justin Mclean" : Hi, > Given that I wrote every line of that code, I'm allowed to stick whatever header I want on it. Are you 100% sure about that for this version of the file? if it was copied from here [1] and it’s the latest then there are 4 contributors to that file over 20 odd commits. Thanks, Justin 1. https://github.com/takari/maven-wrapper/blob/master/.mvn/wrapper/MavenWrapperDownloader.java
Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
Hi, > Given that I wrote every line of that code, I'm allowed to stick whatever > header I want on it. Are you 100% sure about that for this version of the file? if it was copied from here [1] and it’s the latest then there are 4 contributors to that file over 20 odd commits. Thanks, Justin 1. https://github.com/takari/maven-wrapper/blob/master/.mvn/wrapper/MavenWrapperDownloader.java
Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
Hi Justin, Given that I wrote every line of that code, I'm allowed to stick whatever header I want on it. Please let me be clear: I'm only talking about the Java file. Chris Am 19.11.19, 10:57 schrieb "Justin Mclean" : Hi, Given the priject is not an ASF one why would it have an ASF header? Thanks, Justin On Tue, 19 Nov 2019, 19:52 Christofer Dutz, wrote: > Hi Justin, > > this is a file I personally wrote and submitted to the maven-wrapper > project. > So technically it could have the Apache header ... after all, I put it > there. So I think the Apache header doesn't have to be replaced. > > Chris > > > > Am 18.11.19, 21:21 schrieb "Justin Mclean" : > > HI, > > I’m -1 on this as the maven wrapper [1] is still not being handled > correctly, please read my previous comments. This is a 3rd party file and > should not have an ASF header, you can't alter the header of a 3rd party > file without permission. Thanks for fixing the other issues. > > Thanks, > Justin > > 1. .mvn/wrapper/MavenWrapperDownloader.java > > > >
Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
Hi, Given the priject is not an ASF one why would it have an ASF header? Thanks, Justin On Tue, 19 Nov 2019, 19:52 Christofer Dutz, wrote: > Hi Justin, > > this is a file I personally wrote and submitted to the maven-wrapper > project. > So technically it could have the Apache header ... after all, I put it > there. So I think the Apache header doesn't have to be replaced. > > Chris > > > > Am 18.11.19, 21:21 schrieb "Justin Mclean" : > > HI, > > I’m -1 on this as the maven wrapper [1] is still not being handled > correctly, please read my previous comments. This is a 3rd party file and > should not have an ASF header, you can't alter the header of a 3rd party > file without permission. Thanks for fixing the other issues. > > Thanks, > Justin > > 1. .mvn/wrapper/MavenWrapperDownloader.java > > > >
Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
Hi Chris, So, sounds that we need to remove the declaration in the LICENSE file? ``` The following class is modified from Maven Wrapper, which is under Apache License 2.0: ./.mvn/wrapper/MavenWrapperDownloader.java ``` Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Christofer Dutz 于2019年11月19日周二 下午4:52写道： > Hi Justin, > > this is a file I personally wrote and submitted to the maven-wrapper > project. > So technically it could have the Apache header ... after all, I put it > there. So I think the Apache header doesn't have to be replaced. > > Chris > > > > Am 18.11.19, 21:21 schrieb "Justin Mclean" : > > HI, > > I’m -1 on this as the maven wrapper [1] is still not being handled > correctly, please read my previous comments. This is a 3rd party file and > should not have an ASF header, you can't alter the header of a 3rd party > file without permission. Thanks for fixing the other issues. > > Thanks, > Justin > > 1. .mvn/wrapper/MavenWrapperDownloader.java > > > >
Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
Hi Justin, this is a file I personally wrote and submitted to the maven-wrapper project. So technically it could have the Apache header ... after all, I put it there. So I think the Apache header doesn't have to be replaced. Chris Am 18.11.19, 21:21 schrieb "Justin Mclean" : HI, I’m -1 on this as the maven wrapper [1] is still not being handled correctly, please read my previous comments. This is a 3rd party file and should not have an ASF header, you can't alter the header of a 3rd party file without permission. Thanks for fixing the other issues. Thanks, Justin 1. .mvn/wrapper/MavenWrapperDownloader.java
Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
Hi, So, remove the current header, put its original header back, and exclude the file from apache-rat-plugin. (The file has been claimed in iotdb's LICENSE file) Is that ok? Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Justin Mclean 于2019年11月19日周二 上午4:21写道： > HI, > > I’m -1 on this as the maven wrapper [1] is still not being handled > correctly, please read my previous comments. This is a 3rd party file and > should not have an ASF header, you can't alter the header of a 3rd party > file without permission. Thanks for fixing the other issues. > > Thanks, > Justin > > 1. .mvn/wrapper/MavenWrapperDownloader.java > >
Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
HI, I’m -1 on this as the maven wrapper [1] is still not being handled correctly, please read my previous comments. This is a 3rd party file and should not have an ASF header, you can't alter the header of a 3rd party file without permission. Thanks for fixing the other issues. Thanks, Justin 1. .mvn/wrapper/MavenWrapperDownloader.java
Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
Hi all,
I get a faling IT when running mvn clean install.
It is:
[INFO] Running org.apache.iotdb.db.integration.IoTDBDeletionIT
ERROR [2019-11-18 14:12:34,244] [pool-285-IoTDB-JDBC-Client-thread-1]
org.apache.iotdb.db.service.TSServiceImpl:653 - meet error while parsing SQL to
physical plan:
org.apache.iotdb.db.exception.query.QueryProcessException: number of
measurement is NOT EQUAL TO the number of values
at
org.apache.iotdb.db.qp.strategy.LogicalGenerator.analyzeInsert(LogicalGenerator.java:577)
at
org.apache.iotdb.db.qp.strategy.LogicalGenerator.analyze(LogicalGenerator.java:162)
at
org.apache.iotdb.db.qp.strategy.LogicalGenerator.getLogicalPlan(LogicalGenerator.java:144)
at
org.apache.iotdb.db.qp.QueryProcessor.parseASTToOperator(QueryProcessor.java:86)
at
org.apache.iotdb.db.qp.QueryProcessor.parseSQLToPhysicalPlan(QueryProcessor.java:70)
at
org.apache.iotdb.db.service.TSServiceImpl.executeStatement(TSServiceImpl.java:633)
at
org.apache.iotdb.service.rpc.thrift.TSIService$Processor$executeStatement.getResult(TSIService.java:1465)
at
org.apache.iotdb.service.rpc.thrift.TSIService$Processor$executeStatement.getResult(TSIService.java:1450)
at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39)
at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:39)
at
org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:286)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
[ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.184 s
<<< FAILURE! - in org.apache.iotdb.db.integration.IoTDBDeletionIT
[ERROR] testMerge(org.apache.iotdb.db.integration.IoTDBDeletionIT) Time
elapsed: 0.049 s <<< ERROR!
org.apache.iotdb.jdbc.IoTDBSQLException: Statement format is not right: number
of measurement is NOT EQUAL TO the number of values
at
org.apache.iotdb.db.integration.IoTDBDeletionIT.prepareMerge(IoTDBDeletionIT.java:239)
at
org.apache.iotdb.db.integration.IoTDBDeletionIT.testMerge(IoTDBDeletionIT.java:118)
Is something wrong with my setup or is this something we should also look into
when doing the next RC?
Thanks!
Julian
Am 18.11.19, 14:07 schrieb "Jialin Qiao" :
Hi,
Thank you Gouwang, this is a critical bug. In this case, I will close this
voting and prepare RC3.
Besides, I suggest to change the default compression to SNAPPY instead of
UNCOMPRESSED,
which is more frequently used.
Thanks,
--
Jialin Qiao
School of Software, Tsinghua University
乔嘉林
清华大学 软件学院
> -原始邮件-
> 发件人: "勾王敏浩"
> 发送时间: 2019-11-18 20:51:51 (星期一)
> 收件人: dev@iotdb.apache.org
> 抄送:
> 主题: Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
>
> Hi,
> My vote is -1 .
> Because the upgrade module has a bug when upgrading a old tsfile with
SNAPPY CompressionType. I have submitted a PR to fix the problem.
> The PR link: https://github.com/apache/incubator-iotdb/pull/565/commits.
>
>
> > -原始邮件-
> > 发件人: suyue
> > 发送时间: 2019-11-18 19:41:56 (星期一)
> > 收件人: dev@iotdb.apache.org
> > 抄送:
> > 主题: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
> >
> > Hi,
> >
> > +1 (PPMC vote)
> >
> > I checked:
> >
> > Binary distribution:
> > 1. verify ASC
> > 2. verify hash
> > 3. verity rat
> > 4.start iotdb server
> > 5.start client and execute some sqls
> > 6. python client
> >
> > Source release:
> > 1. NOTICE, LICENSE and RELEASE_NOTES
> > 2. rat
> > 3. mvn clean test install
> > 4. start iotdb server
> > 5. start client and execute some sqls
> > 6. python client
> > Execute:
> > SET STORAGE GROUP TO root.ln.wf01.wt01;
> > CREATE TIMESERIES root.ln.wf01.wt01.status WITH DATATYPE=BOOLEAN,
ENCODING=PLAIN
> > CREATE TIMESERIES root.ln.wf01.wt01.temperature WITH DATATYPE=FLOAT,
ENCODING=PLAIN
> > CREATE TIMESERIES root.ln.wf01.wt01.hardware WITH DATATYPE=INT32,
ENCODING=PLAIN
> > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(1, 1.1, false, 11)
> > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(2, 2.2, true, 22)
> > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware)
values(3, 3.3, false, 33 )
> > INSERT I
Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
Hi, Thank you Gouwang, this is a critical bug. In this case, I will close this voting and prepare RC3. Besides, I suggest to change the default compression to SNAPPY instead of UNCOMPRESSED, which is more frequently used. Thanks, -- Jialin Qiao School of Software, Tsinghua University 乔嘉林 清华大学 软件学院 > -原始邮件- > 发件人: "勾王敏浩" > 发送时间: 2019-11-18 20:51:51 (星期一) > 收件人: dev@iotdb.apache.org > 抄送: > 主题: Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release > > Hi, > My vote is -1 . > Because the upgrade module has a bug when upgrading a old tsfile with > SNAPPY CompressionType. I have submitted a PR to fix the problem. > The PR link: https://github.com/apache/incubator-iotdb/pull/565/commits. > > > > -原始邮件- > > 发件人: suyue > > 发送时间: 2019-11-18 19:41:56 (星期一) > > 收件人: dev@iotdb.apache.org > > 抄送: > > 主题: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release > > > > Hi, > > > > +1 (PPMC vote) > > > > I checked: > > > > Binary distribution: > > 1. verify ASC > > 2. verify hash > > 3. verity rat > > 4.start iotdb server > > 5.start client and execute some sqls > > 6. python client > > > > Source release: > > 1. NOTICE, LICENSE and RELEASE_NOTES > > 2. rat > > 3. mvn clean test install > > 4. start iotdb server > > 5. start client and execute some sqls > > 6. python client > > Execute: > > SET STORAGE GROUP TO root.ln.wf01.wt01; > > CREATE TIMESERIES root.ln.wf01.wt01.status WITH DATATYPE=BOOLEAN, > > ENCODING=PLAIN > > CREATE TIMESERIES root.ln.wf01.wt01.temperature WITH DATATYPE=FLOAT, > > ENCODING=PLAIN > > CREATE TIMESERIES root.ln.wf01.wt01.hardware WITH DATATYPE=INT32, > > ENCODING=PLAIN > > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > > values(1, 1.1, false, 11) > > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > > values(2, 2.2, true, 22) > > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > > values(3, 3.3, false, 33 ) > > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > > values(4, 4.4, false, 44) > > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > > values(5, 5.5, false, 55) > > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > > values(6, 1.1, false, 11) > > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > > values(7, 2.2, true, 22) > > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > > values(8, 3.3, false, 33 ) > > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > > values(9, 4.4, false, 44) > > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > > values(10, 5.5, false, 55) > > Select * from root; > > > > Best regards, > > Yue Su > >
Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
Hi, My vote is -1 . Because the upgrade module has a bug when upgrading a old tsfile with SNAPPY CompressionType. I have submitted a PR to fix the problem. The PR link: https://github.com/apache/incubator-iotdb/pull/565/commits. > -原始邮件- > 发件人: suyue > 发送时间: 2019-11-18 19:41:56 (星期一) > 收件人: dev@iotdb.apache.org > 抄送: > 主题: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release > > Hi, > > +1 (PPMC vote) > > I checked: > > Binary distribution: > 1. verify ASC > 2. verify hash > 3. verity rat > 4.start iotdb server > 5.start client and execute some sqls > 6. python client > > Source release: > 1. NOTICE, LICENSE and RELEASE_NOTES > 2. rat > 3. mvn clean test install > 4. start iotdb server > 5. start client and execute some sqls > 6. python client > Execute: > SET STORAGE GROUP TO root.ln.wf01.wt01; > CREATE TIMESERIES root.ln.wf01.wt01.status WITH DATATYPE=BOOLEAN, > ENCODING=PLAIN > CREATE TIMESERIES root.ln.wf01.wt01.temperature WITH DATATYPE=FLOAT, > ENCODING=PLAIN > CREATE TIMESERIES root.ln.wf01.wt01.hardware WITH DATATYPE=INT32, > ENCODING=PLAIN > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > values(1, 1.1, false, 11) > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > values(2, 2.2, true, 22) > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > values(3, 3.3, false, 33 ) > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > values(4, 4.4, false, 44) > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > values(5, 5.5, false, 55) > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > values(6, 1.1, false, 11) > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > values(7, 2.2, true, 22) > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > values(8, 3.3, false, 33 ) > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > values(9, 4.4, false, 44) > INSERT INTO root.ln.wf01.wt01(timestamp,temperature,status, hardware) > values(10, 5.5, false, 55) > Select * from root; > > Best regards, > Yue Su >
Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
Hi, +1 (PPMC vote) I have checked following items: Source release: 1. Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle (Correct) 2. Compile and build code with command: mvn clean package. (Correct) 3. Verifying the signature (ASC) (Correct) 4. Verifying the hashes (SHA512) (Correct) 5. Running RAT(mvn apache-rat:check) (Correct) Binary distribution: 1. Verifying the signature (ASC) (Correct) 2. Verifying the hashes (SHA512) (Correct) 3. Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files (Correct) Functionality： 1. Run server and client script: sh start-server.sh, start-client.sh -h 127.0.0.1 -p 6667 -u root -pw root (Correct) 2. REBOOT 3. Execuet some basic operations: (Correct) 1) SET STORAGE GROUP TO root.vehicle 2) CREATE TIMESERIES root.vehicle.d0.s0 WITH DATATYPE=INT32, ENCODING=RLE 3) insert into root.vehicle.d0(timestamp,s0) values(10,100) 4) insert into root.vehicle.d0(timestamp,s0) values(1,101) 5) select * from root.vehicle 6) select * from root.vehicle where time > 5 7) show timeseries 8) show timeseries root.* 9) delete from root.vehicle.d0.s0 where time < 9 10) select * from root.vehicle Best Regards, — Tianan Li School of Software, Tsinghua University 李天安 清华大学 软件学院 > 2019年11月16日 下午10:43，Jialin Qiao 写道： > > Hi all, > > > Now I open a new ticket for Apache IoTDB (incubating) 0.9.0 RC2, which fixs > some issues comparing with RC1. You can find the details at the end of this > email. > > > Apache IoTDB (incubating) 0.9.0 is a major version with many exciting > features. > You can get the release notes in [5]. > > > Apache IoTDB (Incubating) 0.9.0 has been staged under [2] and it’s time to > vote on accepting it for release. All Maven artifacts are available under > [1]. > If approved we will seek final release approval from the IPMC. > > > Voting will be open for 72hr. > > > A minimum of 3 binding +1 votes and more binding +1 than binding -1 are > required to pass. > > > Release tag: release/0.9.0 > > > Hash for the release tag: 0eb718f4587c824838e39dd53f16ba93a9ea90a8 > > > Per [3] "Before voting +1 PMC/PPMC members are required to download the > signed source code package, compile it as provided, and test the resulting > executable on their own platform, along with also verifying that the package > meets the requirements of the ASF policy on releases." > > > Difference with RC1: > > >> - There an unexpected binary file in the release [4] && There is a "jar" >> file in the build. > Remov ./.mvn/wrapper/maven-wrapper.jar in the source release. >> - LICENSE need to mention license of Maven Wrapper > Add maven-wrapper in LICENSE >> - NOTICE is incorrect "Copyright 2019 and onwards” is not valid to say > Fix IoTDB NOTICE copyright to: Copyright 2018-2019 The Apache Software > Foundation. >> - NOTICE is missing information from from the common NOTICE file [1][3] > Add Commons-collections in NOTICE and NOTICE-binary >> - A large number of files have the incorrect ASF header. There should be no >> "Copyright © 2019 Apache IoTDB(incubating) (dev@iotdb.apache.org)” notice in >> the files. > Fix incorrect ASF header in some files, remove : Copyright © 2019 Apache > IoTDB(incubating) (dev@iotdb.apache.org) > > > > > You can achieve the above by following [4]. > > > [ ] +1 accept (indicate what you validated - e.g. performed the non-RM items > in [4]) > [ ] -1 reject (explanation required) > > > [1] https://repository.apache.org/content/repositories/orgapacheiotdb-1013 > [2] https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.9.0/rc2 > [3] https://www.apache.org/dev/release.html#approving-a-release > [4] > https://cwiki.apache.org/confluence/display/IOTDB/Validating+a+staged+Release > [5] > https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.9.0/rc2/RELEASE_NOTES.md > > > Thanks, > -- > Jialin Qiao > School of Software, Tsinghua University > > > 乔嘉林 > 清华大学 软件学院
Re:[VOTE] Apache IoTDB 0.9.0 (incubating) RC2 release
Hi, +1 (PPMC vote) The followings are successfully verified: Source release: 1. ASC sinature 2. Hashes 3. LICENSE, NOTICE, README, RELEASE_NOTES 4. RAT 5. mvn clean package 6. start server and client 7. execute basic operations and reboot 8. python client Binary distribution: 1. ASC sinature 2. Hashes 3. start server and client 4. execute basic operations and reboot 5. python client PS: If you encountered any problem, first check if there is any space “ “ in your path, which may fail the download of thrift or other staff. Best, Tian Jiang | | Tian Jiang | | jt2594...@163.com | 签名由网易邮箱大师定制 On 11/16/2019 22:43，Jialin Qiao wrote： Hi all, Now I open a new ticket for Apache IoTDB (incubating) 0.9.0 RC2, which fixs some issues comparing with RC1. You can find the details at the end of this email. Apache IoTDB (incubating) 0.9.0 is a major version with many exciting features. You can get the release notes in [5]. Apache IoTDB (Incubating) 0.9.0 has been staged under [2] and it’s time to vote on accepting it for release. All Maven artifacts are available under [1]. If approved we will seek final release approval from the IPMC. Voting will be open for 72hr. A minimum of 3 binding +1 votes and more binding +1 than binding -1 are required to pass. Release tag: release/0.9.0 Hash for the release tag: 0eb718f4587c824838e39dd53f16ba93a9ea90a8 Per [3] "Before voting +1 PMC/PPMC members are required to download the signed source code package, compile it as provided, and test the resulting executable on their own platform, along with also verifying that the package meets the requirements of the ASF policy on releases." Difference with RC1: - There an unexpected binary file in the release [4] && There is a "jar" file in the build. Remov ./.mvn/wrapper/maven-wrapper.jar in the source release. - LICENSE need to mention license of Maven Wrapper Add maven-wrapper in LICENSE - NOTICE is incorrect "Copyright 2019 and onwards” is not valid to say Fix IoTDB NOTICE copyright to: Copyright 2018-2019 The Apache Software Foundation. - NOTICE is missing information from from the common NOTICE file [1][3] Add Commons-collections in NOTICE and NOTICE-binary - A large number of files have the incorrect ASF header. There should be no "Copyright © 2019 Apache IoTDB(incubating) (dev@iotdb.apache.org)” notice in the files. Fix incorrect ASF header in some files, remove : Copyright © 2019 Apache IoTDB(incubating) (dev@iotdb.apache.org) You can achieve the above by following [4]. [ ] +1 accept (indicate what you validated - e.g. performed the non-RM items in [4]) [ ] -1 reject (explanation required) [1] https://repository.apache.org/content/repositories/orgapacheiotdb-1013 [2] https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.9.0/rc2 [3] https://www.apache.org/dev/release.html#approving-a-release [4] https://cwiki.apache.org/confluence/display/IOTDB/Validating+a+staged+Release [5] https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.9.0/rc2/RELEASE_NOTES.md Thanks, -- Jialin Qiao School of Software, Tsinghua University 乔嘉林 清华大学 软件学院
