[jira] [Commented] (ISIS-547) Provide better error logging from the Wicket applicaiton init() method if Isis fails to boot.
[
https://issues.apache.org/jira/browse/ISIS-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13779863#comment-13779863
]
Martin Grigorov commented on ISIS-547:
--
---
i/wicket-core/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
+++
w/wicket-core/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java
@@ -435,7 +435,8 @@ public class WicketFilter implements Filter
{
// #destroy() might not be called by the web container
when #init() fails,
// so destroy now
- log.warn(initialization failed, destroying now);
+ log.error(String.format(The initialization of an
application with name '%s' has failed,
+ filterConfig.getFilterName()), e);
try
{
@@ -443,7 +444,7 @@ public class WicketFilter implements Filter
}
catch (Exception destroyException)
{
- log.warn(Unable to destroy after
initialization failure, destroyException);
+ log.error(Unable to destroy after
initialization failure, destroyException);
}
The log level of the message should be an ERROR.
Provide better error logging from the Wicket applicaiton init() method if
Isis fails to boot.
-
Key: ISIS-547
URL: https://issues.apache.org/jira/browse/ISIS-547
Project: Isis
Issue Type: Improvement
Components: Viewer: Wicket
Affects Versions: viewer-wicket-1.2.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Priority: Minor
Fix For: viewer-wicket-1.3.0
This is a work-around for the fact that the Wicket framework's WicketFilter,
that calls Application#init(), does not log any runtime exception that is
thrown.
For example, if a missing JDBC driver has not been configured, then this fact
is never logged explicitly.
The fix is to catch the runtime exception in the IsisWicketApplicaiton, and
have it log before propogating the exception up to its caller (WicketFilter).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (ISIS-548) Remove logging introduced in ISIS-547 once the proposed fix to Wicket itself has been implemented.
Dan Haywood created ISIS-548: Summary: Remove logging introduced in ISIS-547 once the proposed fix to Wicket itself has been implemented. Key: ISIS-548 URL: https://issues.apache.org/jira/browse/ISIS-548 Project: Isis Issue Type: Task Components: Viewer: Wicket Reporter: Dan Haywood Assignee: Dan Haywood Priority: Trivial Fix For: viewer-wicket-2.0.0 See ISIS-547 comment by Martin Grigorov. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ISIS-547) Provide better error logging from the Wicket applicaiton init() method if Isis fails to boot.
[ https://issues.apache.org/jira/browse/ISIS-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13779876#comment-13779876 ] Dan Haywood commented on ISIS-547: -- Hi Martin... yup, that's the change I think should be made to Wicket. Assuming that this gets done to Wicket, I've raised ISIS-548 to back out the change done in this ticket (at some point in the future). Cheers Dan Provide better error logging from the Wicket applicaiton init() method if Isis fails to boot. - Key: ISIS-547 URL: https://issues.apache.org/jira/browse/ISIS-547 Project: Isis Issue Type: Improvement Components: Viewer: Wicket Affects Versions: viewer-wicket-1.2.0 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: viewer-wicket-1.3.0 This is a work-around for the fact that the Wicket framework's WicketFilter, that calls Application#init(), does not log any runtime exception that is thrown. For example, if a missing JDBC driver has not been configured, then this fact is never logged explicitly. The fix is to catch the runtime exception in the IsisWicketApplicaiton, and have it log before propogating the exception up to its caller (WicketFilter). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ISIS-469) Provide implementations of certain layout facets that read from a Xxx.layout.properties file
[ https://issues.apache.org/jira/browse/ISIS-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13779880#comment-13779880 ] ASF subversion and git services commented on ISIS-469: -- Commit 1526874 from [~danhaywood] in branch 'site/trunk' [ https://svn.apache.org/r1526874 ] re ISIS-469, ISIS-475, update to pom.xml for dynamic layouts Provide implementations of certain layout facets that read from a Xxx.layout.properties file -- Key: ISIS-469 URL: https://issues.apache.org/jira/browse/ISIS-469 Project: Isis Issue Type: New Feature Components: Core Affects Versions: core-1.2.0 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: core-1.3.0 Specifically, the two layout facets to capture are MemberOrderFacet and MemberGroupLayoutFacet (see ISIS-468). The idea of this ticket is that information is pulled in from a separate file, sitting alongside the domain class. This makes it easier to see this layout information in one place. And, in conjunction with ISIS-470, this would allow dynamic updates to the layout, without a recompile/redeploy. This ticket defines the metadata informatino in an Xxx.layout.properties file. (Note that ISIS-475 takes this idea further and specifies a JSON file. This latter idea is probably to be preferred in most cases). The format of the property file (Xxx.layout.properties) is: ### # MemberGroupLayout ### memberGroupLayout.columnSpans=3,4,0,5 memberGroupLayout.left=General memberGroupLayout.middle=Detail memberGroupLayout.right= ### # MemberOrder ### # Properties memberOrder.description.sequence=1 memberOrder.category.sequence=2 memberOrder.complete.sequence=3 # Properties (Detail) memberOrder.dueBy.name=Detail memberOrder.cost.name=Detail memberOrder.notes.name=Detail memberOrder.attachment.name=Detail memberOrder.dueBy.sequence=1 memberOrder.cost.sequence=2 memberOrder.notes.sequence=3 memberOrder.attachment.sequence=4 # Properties (Misc) memberOrder.versionSequence.name=Misc memberOrder.versionSequence.sequence=99 #Collections memberOrder.dependencies.sequence=1 memberOrder.similarItems.sequence=2 #Actions (freestanding) memberOrder.delete.sequence=1 memberOrder.duplicate.sequence=2 #Actions (associated with properties) memberOrder.completed.name=complete memberOrder.notYetCompleted.name=complete memberOrder.completed.sequence=1 memberOrder.notYetCompleted.sequence=2 memberOrder.updateCost.name=cost #Actions (associated with collections) memberOrder.add.name=dependencies memberOrder.remove.name=dependencies -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ISIS-475) Dynamic layout using JSON, using an Xxx.layout.json file
[
https://issues.apache.org/jira/browse/ISIS-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13779881#comment-13779881
]
ASF subversion and git services commented on ISIS-475:
--
Commit 1526874 from [~danhaywood] in branch 'site/trunk'
[ https://svn.apache.org/r1526874 ]
re ISIS-469, ISIS-475, update to pom.xml for dynamic layouts
Dynamic layout using JSON, using an Xxx.layout.json file
Key: ISIS-475
URL: https://issues.apache.org/jira/browse/ISIS-475
Project: Isis
Issue Type: New Feature
Components: Archetypes, Core, Examples, Viewer: Wicket
Affects Versions: archetype-wrj-1.0.3, viewer-wicket-1.2.0, core-1.2.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Fix For: archetype-wrj-1.0.4, viewer-wicket-1.3.0, core-1.3.0
Load layout metadata from a .layout.json file (this is a successor to
ISIS-469)
Also allow this .layout.json file to be downloaded (using
DeveloperUtilitiesService), either for an individual class, or a zip of all
the classes in the metamodel
Dynamically reload metadata; log any errors if does not parse etc.
~~~
The format of the Xxx.layout.json file (eg for ToDoItem example class) is:
{
columns: [
{
span: 3,
memberGroups: {
General: {
members: {
description: {},
category: {},
complete: {
actions: {
completed: {},
notYetCompleted: {}
}
}
}
},
Misc: {
members: {
versionSequence: {}
}
}
}
},
{
span: 4,
memberGroups: {
Detail: {
members: {
dueBy: {},
cost: {
actions: {
updateCost:{}
}
},
notes: {},
attachment: {}
}
}
}
},
{
span: 0
},
{
span: 5,
collections: {
dependencies: {
actions: {
add:{},
delete: {}
}
},
similarItems: {}
}
}
],
actions: {
delete: {},
duplicate: {}
}
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
