[jira] [Resolved] (ISIS-804) [INVALID] Make (entity) properties read-only by default.

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-804.
--
Resolution: Invalid

This was fixed in previous releases ... can properties make read-only through 
config property

> [INVALID] Make (entity) properties read-only by default.
> 
>
> Key: ISIS-804
> URL: https://issues.apache.org/jira/browse/ISIS-804
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: core-1.5.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>
> Currently properties are read/write by default; the programmer has to 
> annotate with @Disabled (or equivalent) to make read-only.
> While this "subtractive programming" approach is nice for demo's, the truth 
> is that with larger applications, if not rigorously and completely tested, 
> the end-user may get the opportunity to change something that they ought not; 
> potentially corrupting data.
> It would be better (and safer) for properties to be read-only by default.
> The presence of the modifyXxx(...)/clearXxx() supporting methods would then 
> indicate that they are read-write.
> Another possible benefit is that - if we implement ISIS-273 (to read from 
> fields) then the amount of boilerplate would substantially be reduced if a 
> tool like Lombok was used.  That is, read-only properties would consist 
> solely of a private field; read-write properties would be the field plus the 
> modify/clear.
> It might also make sense for the clearXxx() method to be optional; that is, 
> to allow modifyXxx(..) to be called with null.
> NB: for view models, properties could (perhaps) remain as read-write; there 
> are no side-effects.
> This change requires discussion on the mailing list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-804) Make (entity) properties read-only by default.

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-804:
-
Fix Version/s: (was: 3.0.0)
   1.16.1

> Make (entity) properties read-only by default.
> --
>
> Key: ISIS-804
> URL: https://issues.apache.org/jira/browse/ISIS-804
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: core-1.5.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>
> Currently properties are read/write by default; the programmer has to 
> annotate with @Disabled (or equivalent) to make read-only.
> While this "subtractive programming" approach is nice for demo's, the truth 
> is that with larger applications, if not rigorously and completely tested, 
> the end-user may get the opportunity to change something that they ought not; 
> potentially corrupting data.
> It would be better (and safer) for properties to be read-only by default.
> The presence of the modifyXxx(...)/clearXxx() supporting methods would then 
> indicate that they are read-write.
> Another possible benefit is that - if we implement ISIS-273 (to read from 
> fields) then the amount of boilerplate would substantially be reduced if a 
> tool like Lombok was used.  That is, read-only properties would consist 
> solely of a private field; read-write properties would be the field plus the 
> modify/clear.
> It might also make sense for the clearXxx() method to be optional; that is, 
> to allow modifyXxx(..) to be called with null.
> NB: for view models, properties could (perhaps) remain as read-write; there 
> are no side-effects.
> This change requires discussion on the mailing list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-804) [INVALID] Make (entity) properties read-only by default.

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-804:
-
Summary: [INVALID] Make (entity) properties read-only by default.  (was: 
Make (entity) properties read-only by default.)

> [INVALID] Make (entity) properties read-only by default.
> 
>
> Key: ISIS-804
> URL: https://issues.apache.org/jira/browse/ISIS-804
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: core-1.5.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>
> Currently properties are read/write by default; the programmer has to 
> annotate with @Disabled (or equivalent) to make read-only.
> While this "subtractive programming" approach is nice for demo's, the truth 
> is that with larger applications, if not rigorously and completely tested, 
> the end-user may get the opportunity to change something that they ought not; 
> potentially corrupting data.
> It would be better (and safer) for properties to be read-only by default.
> The presence of the modifyXxx(...)/clearXxx() supporting methods would then 
> indicate that they are read-write.
> Another possible benefit is that - if we implement ISIS-273 (to read from 
> fields) then the amount of boilerplate would substantially be reduced if a 
> tool like Lombok was used.  That is, read-only properties would consist 
> solely of a private field; read-write properties would be the field plus the 
> modify/clear.
> It might also make sense for the clearXxx() method to be optional; that is, 
> to allow modifyXxx(..) to be called with null.
> NB: for view models, properties could (perhaps) remain as read-write; there 
> are no side-effects.
> This change requires discussion on the mailing list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ISIS-505) [INVALID] Wicket error handling returns only a 500 if encounter an unenhanced object

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-505.
--
Resolution: Invalid

Fixed in previous releases ... we use a MetaModelValidator to fail-fast if 
discover unenhanced classes

> [INVALID] Wicket error handling returns only a 500 if encounter an unenhanced 
> object
> 
>
> Key: ISIS-505
> URL: https://issues.apache.org/jira/browse/ISIS-505
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-505) [DUPLICATE] Wicket error handling returns only a 500 if encounter an unenhanced object

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-505:
-
Summary: [DUPLICATE] Wicket error handling returns only a 500 if encounter 
an unenhanced object  (was: Wicket error handling returns only a 500 if 
encounter an unenhanced object)

> [DUPLICATE] Wicket error handling returns only a 500 if encounter an 
> unenhanced object
> --
>
> Key: ISIS-505
> URL: https://issues.apache.org/jira/browse/ISIS-505
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-505) [INVALID] Wicket error handling returns only a 500 if encounter an unenhanced object

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-505:
-
Summary: [INVALID] Wicket error handling returns only a 500 if encounter an 
unenhanced object  (was: [DUPLICATE] Wicket error handling returns only a 500 
if encounter an unenhanced object)

> [INVALID] Wicket error handling returns only a 500 if encounter an unenhanced 
> object
> 
>
> Key: ISIS-505
> URL: https://issues.apache.org/jira/browse/ISIS-505
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-505) [DUPLICATE] Wicket error handling returns only a 500 if encounter an unenhanced object

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-505:
-
Fix Version/s: (was: 3.0.0)
   1.16.1

> [DUPLICATE] Wicket error handling returns only a 500 if encounter an 
> unenhanced object
> --
>
> Key: ISIS-505
> URL: https://issues.apache.org/jira/browse/ISIS-505
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ISIS-834) Ensure that only a single implementation of a DomainService is registered.

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-834.
--
   Resolution: Won't Fix
Fix Version/s: (was: 3.0.0)
   1.16.1

> Ensure that only a single implementation of a DomainService is registered.
> --
>
> Key: ISIS-834
> URL: https://issues.apache.org/jira/browse/ISIS-834
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: core-1.5.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>
> Two complications:
> - ExceptionRecognizers require multiple implementations (are chained together)
> - for each implementation we identify all the types it implements, so the 
> check isn't a simple 1:1 map (at the limit all implementations extend 
> java.lang.Object).  Therefore need to take into account the set of injection 
> points that the services are injected into.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-834) [WON'T FIX] Ensure that only a single implementation of a DomainService is registered.

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-834:
-
Summary: [WON'T FIX] Ensure that only a single implementation of a 
DomainService is registered.  (was: Ensure that only a single implementation of 
a DomainService is registered.)

> [WON'T FIX] Ensure that only a single implementation of a DomainService is 
> registered.
> --
>
> Key: ISIS-834
> URL: https://issues.apache.org/jira/browse/ISIS-834
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: core-1.5.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>
> Two complications:
> - ExceptionRecognizers require multiple implementations (are chained together)
> - for each implementation we identify all the types it implements, so the 
> check isn't a simple 1:1 map (at the limit all implementations extend 
> java.lang.Object).  Therefore need to take into account the set of injection 
> points that the services are injected into.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-888) Remove Wicket viewer action prompt page, instead just rely on action prompt.

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-888:
-
Fix Version/s: (was: 3.0.0)
   2.0.0

> Remove Wicket viewer action prompt page, instead just rely on action prompt.
> 
>
> Key: ISIS-888
> URL: https://issues.apache.org/jira/browse/ISIS-888
> Project: Isis
>  Issue Type: Improvement
>  Components: Core: Viewer: Wicket
>Affects Versions: viewer-wicket-1.6.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0
>
>
> However... we still use the action prompt page for any bookmarked actions 
> that take args.  So would need to figure out what to do with those.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ISIS-888) Remove Wicket viewer action prompt page, instead just rely on action prompt.

[Dan Haywood (JIRA)]

[ 
https://issues.apache.org/jira/browse/ISIS-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368252#comment-16368252
 ] 

Dan Haywood commented on ISIS-888:
--

It's possible this has been done already.

> Remove Wicket viewer action prompt page, instead just rely on action prompt.
> 
>
> Key: ISIS-888
> URL: https://issues.apache.org/jira/browse/ISIS-888
> Project: Isis
>  Issue Type: Improvement
>  Components: Core: Viewer: Wicket
>Affects Versions: viewer-wicket-1.6.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0
>
>
> However... we still use the action prompt page for any bookmarked actions 
> that take args.  So would need to figure out what to do with those.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-1056) [DUPLICATE] Support user-defined annotations (as per Spring and JSR-303 etc).

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1056:
--

duplicate in ISIS-1726

> [DUPLICATE] Support user-defined annotations (as per Spring and JSR-303 etc).
> -
>
> Key: ISIS-1056
> URL: https://issues.apache.org/jira/browse/ISIS-1056
> Project: Isis
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: core-1.8.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> eg, instead of:
> @Action(semantics=SemanticsOf.SAFE)
> @ActionLayout(contributed=Contributed.AS_ASSOCIATION)
> @CollectionLayout(render=RenderType.EAGERLY)
> public List someFoos() { ... }
> we could allow custom annotations like this to be defined:
> @Action(semantics=SemanticsOf.SAFE)
> @ActionLayout(contributed=Contributed.AS_ASSOCIATION)
> @CollectionLayout(render=RenderType.EAGERLY)
> public @interface ContributedCollection {
> }
> which would then allow:
> @ContributedCollection
> public List someFoos() { ... }
> 
> This might also be a good way to support value types, eg by introducing a new 
> ValueObject and ValueObjectLayout annotations:
> @ValueObject (
> mustSatisfy=MoneySpec.class,
> appliesTo={BigDecimal.class}
> )
> @ValueObjectLayout(
> named="Money"
> )
> public @interface Money {
> }
> and then:
> public void deposit(@Money BigDecimal bd) { ... }
> Behind the scenes, Isis would just be copying facets from the 
> ObjectSpecification that represents the @Money annotation onto the parameter 
> or property feature..



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-1277) setAccessible() will be gone with JDK 9

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1277:
--
Fix Version/s: (was: 3.0.0)
   2.0.0

> setAccessible() will be gone with JDK 9
> ---
>
> Key: ISIS-1277
> URL: https://issues.apache.org/jira/browse/ISIS-1277
> Project: Isis
>  Issue Type: Task
>  Components: Core
>Affects Versions: 1.10.0
>Reporter: Jörg Rade
>Priority: Minor
> Fix For: 2.0.0
>
>
> https://github.com/apache/isis/search?utf8=%E2%9C%93=setAccessible%28%29 
> yields 9 hits.
> According to [1] this will be a problem with Java 9.
> [1] 
> https://jaxenter.de/java-9-release-verschoben-warum-jigsaw-noch-nicht-fertig-ist-31687
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-1056) [DUPLICATE] Support user-defined annotations (as per Spring and JSR-303 etc).

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1056:
--
Fix Version/s: (was: 3.0.0)
   2.0.0-M1
  Summary: [DUPLICATE] Support user-defined annotations (as per Spring 
and JSR-303 etc).  (was: Support user-defined annotations (as per Spring and 
JSR-303 etc).)

> [DUPLICATE] Support user-defined annotations (as per Spring and JSR-303 etc).
> -
>
> Key: ISIS-1056
> URL: https://issues.apache.org/jira/browse/ISIS-1056
> Project: Isis
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: core-1.8.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.0.0-M1
>
>
> eg, instead of:
> @Action(semantics=SemanticsOf.SAFE)
> @ActionLayout(contributed=Contributed.AS_ASSOCIATION)
> @CollectionLayout(render=RenderType.EAGERLY)
> public List someFoos() { ... }
> we could allow custom annotations like this to be defined:
> @Action(semantics=SemanticsOf.SAFE)
> @ActionLayout(contributed=Contributed.AS_ASSOCIATION)
> @CollectionLayout(render=RenderType.EAGERLY)
> public @interface ContributedCollection {
> }
> which would then allow:
> @ContributedCollection
> public List someFoos() { ... }
> 
> This might also be a good way to support value types, eg by introducing a new 
> ValueObject and ValueObjectLayout annotations:
> @ValueObject (
> mustSatisfy=MoneySpec.class,
> appliesTo={BigDecimal.class}
> )
> @ValueObjectLayout(
> named="Money"
> )
> public @interface Money {
> }
> and then:
> public void deposit(@Money BigDecimal bd) { ... }
> Behind the scenes, Isis would just be copying facets from the 
> ObjectSpecification that represents the @Money annotation onto the parameter 
> or property feature..



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-926) [WON'T FIX] Allow integration tests to run in parallel, each with a different user. Part of this to include a ProgrammableClockService as a replacement for ClockService, p

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-926:
-
Summary: [WON'T FIX] Allow integration tests to run in parallel, each with 
a different user.  Part of this to include a ProgrammableClockService as a 
replacement for ClockService, partiitioned by user (to allow concurrent 
integration tests to run etc).  (was: Allow integration tests to run in 
parallel, each with a different user.  Part of this to include a 
ProgrammableClockService as a replacement for ClockService, partiitioned by 
user (to allow concurrent integration tests to run etc).)

> [WON'T FIX] Allow integration tests to run in parallel, each with a different 
> user.  Part of this to include a ProgrammableClockService as a replacement 
> for ClockService, partiitioned by user (to allow concurrent integration tests 
> to run etc).
> ---
>
> Key: ISIS-926
> URL: https://issues.apache.org/jira/browse/ISIS-926
> Project: Isis
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: core-1.6.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-894) Remove @NotPersistable annotation and corresponding facet

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-894:
-
Fix Version/s: (was: 3.0.0)
   2.0.0

> Remove @NotPersistable annotation and corresponding facet
> -
>
> Key: ISIS-894
> URL: https://issues.apache.org/jira/browse/ISIS-894
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: core-1.6.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0
>
>
> This annotation is a no-op (tested in Wicket and Restful Objects) and should 
> be removed from the applib
> ... perhaps.  Looking again at the code, there's a check in 
> PersistenceSession#makePersistent() and throws exception if attempt to 
> explicitly persist.
> However, JDO might persist anyway due to persistence-by-reachability, so the 
> check would need to be added to the appropriate JDO lifecycle callback.
> As I think all the above is marginal benefit, think we should just remove in 
> 2.0.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ISIS-926) Allow integration tests to run in parallel, each with a different user. Part of this to include a ProgrammableClockService as a replacement for ClockService, partiitioned

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-926.
--
   Resolution: Won't Fix
Fix Version/s: (was: 3.0.0)
   1.16.1

> Allow integration tests to run in parallel, each with a different user.  Part 
> of this to include a ProgrammableClockService as a replacement for 
> ClockService, partiitioned by user (to allow concurrent integration tests to 
> run etc).
> ---
>
> Key: ISIS-926
> URL: https://issues.apache.org/jira/browse/ISIS-926
> Project: Isis
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: core-1.6.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-890) Get rid of exploration mode, treat as synonym for prototype. Ditto with @Exploration annotation.

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-890:
-
Fix Version/s: (was: 3.0.0)
   2.0.0

> Get rid of exploration mode, treat as synonym for prototype.  Ditto with 
> @Exploration annotation.
> -
>
> Key: ISIS-890
> URL: https://issues.apache.org/jira/browse/ISIS-890
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: core-1.6.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.0.0
>
>
> The main rationale here is to simplify and reduce number of concepts for 
> developer to grapple with.
> Another part of the rationale is to make Isis consistent with Wicket, that 
> only has two modes, not three (DEVELOPMENT and DEPLOYMENT).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-841) Remove mention of a "loading()" callback; this can never fire (for JDO objectstore).

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-841:
-
Fix Version/s: (was: 3.0.0)
   2.0.0

> Remove mention of a "loading()" callback; this can never fire (for JDO 
> objectstore).
> 
>
> Key: ISIS-841
> URL: https://issues.apache.org/jira/browse/ISIS-841
> Project: Isis
>  Issue Type: Improvement
>  Components: Core: Objectstore: JDO
>Affects Versions: core-1.5.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0
>
>
> Delete the LoadingCallbackFacet and update documentation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-1200) [DUPLICATE] Improve support for BDD tests, factoring out domain service to act as context.

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1200:
--
Summary: [DUPLICATE] Improve support for BDD tests, factoring out domain 
service to act as context.  (was: Improve support for BDD tests, factoring out 
domain service to act as context.)

> [DUPLICATE] Improve support for BDD tests, factoring out domain service to 
> act as context.
> --
>
> Key: ISIS-1200
> URL: https://issues.apache.org/jira/browse/ISIS-1200
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.9.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>
> move the scenarioExecution functionality (getVar, putVar etc to support BDD 
> cucumber steps) into a separate domain service.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-1200) [DUPLICATE] Improve support for BDD tests, factoring out domain service to act as context.

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1200:
--
Description: 
move the scenarioExecution functionality (getVar, putVar etc to support BDD 
cucumber steps) into a separate domain service.

 

done as part of Isis 1.16.0, with fix in this release of ISIS-1820

  was:
move the scenarioExecution functionality (getVar, putVar etc to support BDD 
cucumber steps) into a separate domain service.



> [DUPLICATE] Improve support for BDD tests, factoring out domain service to 
> act as context.
> --
>
> Key: ISIS-1200
> URL: https://issues.apache.org/jira/browse/ISIS-1200
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.9.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>
> move the scenarioExecution functionality (getVar, putVar etc to support BDD 
> cucumber steps) into a separate domain service.
>  
> done as part of Isis 1.16.0, with fix in this release of ISIS-1820



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ISIS-1200) Improve support for BDD tests, factoring out domain service to act as context.

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-1200.
---
Resolution: Duplicate

done as part of 1.16.0, actually, for the reworked BDD stuff

> Improve support for BDD tests, factoring out domain service to act as context.
> --
>
> Key: ISIS-1200
> URL: https://issues.apache.org/jira/browse/ISIS-1200
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.9.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>
> move the scenarioExecution functionality (getVar, putVar etc to support BDD 
> cucumber steps) into a separate domain service.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-1200) Improve support for BDD tests, factoring out domain service to act as context.

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1200:
--
Fix Version/s: (was: 2.7.0)
   1.16.1
   Issue Type: Improvement  (was: New Feature)

> Improve support for BDD tests, factoring out domain service to act as context.
> --
>
> Key: ISIS-1200
> URL: https://issues.apache.org/jira/browse/ISIS-1200
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.9.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>
> move the scenarioExecution functionality (getVar, putVar etc to support BDD 
> cucumber steps) into a separate domain service.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ISIS-949) Refactor Bulk.Interaction to remove special case handling (make into a regular request-scoped service).

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-949.
--
Resolution: Fixed

done as part of other tickets to remove deprecated services etc.

> Refactor Bulk.Interaction to remove special case handling (make into a 
> regular request-scoped service).
> ---
>
> Key: ISIS-949
> URL: https://issues.apache.org/jira/browse/ISIS-949
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: core-1.7.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M1
>
>
> specifically, the special case handling that remains in
> - IsisTransactionManager#initOtherApplibServicesIfConfigured
> - IsisTransaction#closeOtherApplibServicesIfConfigured
> in ISIS-948, see that the special case handling for EventBusService was 
> removed by introducing a request-scoped service; hopefully something similar 
> could be done for Bulk.Interaction service.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-949) Refactor Bulk.Interaction to remove special case handling (make into a regular request-scoped service).

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-949:
-
Fix Version/s: (was: 3.0.0)
   2.0.0-M1

> Refactor Bulk.Interaction to remove special case handling (make into a 
> regular request-scoped service).
> ---
>
> Key: ISIS-949
> URL: https://issues.apache.org/jira/browse/ISIS-949
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: core-1.7.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.0-M1
>
>
> specifically, the special case handling that remains in
> - IsisTransactionManager#initOtherApplibServicesIfConfigured
> - IsisTransaction#closeOtherApplibServicesIfConfigured
> in ISIS-948, see that the special case handling for EventBusService was 
> removed by introducing a request-scoped service; hopefully something similar 
> could be done for Bulk.Interaction service.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ISIS-516) [DUPLICATE] Wicket: be able to invoke @Bulk on items within a parent collection (already supported for standalone collections)

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-516.
--
Resolution: Duplicate

see instead ISIS-1585

> [DUPLICATE] Wicket: be able to invoke @Bulk on items within a parent 
> collection (already supported for standalone collections)
> --
>
> Key: ISIS-516
> URL: https://issues.apache.org/jira/browse/ISIS-516
> Project: Isis
>  Issue Type: New Feature
>  Components: Core: Viewer: Wicket
>Affects Versions: viewer-wicket-1.2.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>
> could specify where=PARENTED_...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-516) [DUPLICATE] Wicket: be able to invoke @Bulk on items within a parent collection (already supported for standalone collections)

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-516:
-
Fix Version/s: (was: 3.0.0)
   1.16.1
  Summary: [DUPLICATE] Wicket: be able to invoke @Bulk on items within 
a parent collection (already supported for standalone collections)  (was: 
Wicket: be able to invoke @Bulk on items within a parent collection (already 
supported for standalone collections))

> [DUPLICATE] Wicket: be able to invoke @Bulk on items within a parent 
> collection (already supported for standalone collections)
> --
>
> Key: ISIS-516
> URL: https://issues.apache.org/jira/browse/ISIS-516
> Project: Isis
>  Issue Type: New Feature
>  Components: Core: Viewer: Wicket
>Affects Versions: viewer-wicket-1.2.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>
> could specify where=PARENTED_...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-514) [WON'T FIX] [DUPLICATE] Feature: Allow @Bulk actions to accept parameters

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-514:
-
Fix Version/s: (was: 3.0.0)
   1.16.1
  Summary: [WON'T FIX] [DUPLICATE] Feature: Allow @Bulk actions to 
accept parameters  (was: Feature: Allow @Bulk actions to accept parameters)

> [WON'T FIX] [DUPLICATE] Feature: Allow @Bulk actions to accept parameters
> -
>
> Key: ISIS-514
> URL: https://issues.apache.org/jira/browse/ISIS-514
> Project: Isis
>  Issue Type: New Feature
>  Components: Core: Viewer: Wicket
>Affects Versions: viewer-wicket-1.2.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ISIS-514) [WON'T FIX] [DUPLICATE] Feature: Allow @Bulk actions to accept parameters

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-514.
--
Resolution: Won't Fix

see instead ISIS-1585

> [WON'T FIX] [DUPLICATE] Feature: Allow @Bulk actions to accept parameters
> -
>
> Key: ISIS-514
> URL: https://issues.apache.org/jira/browse/ISIS-514
> Project: Isis
>  Issue Type: New Feature
>  Components: Core: Viewer: Wicket
>Affects Versions: viewer-wicket-1.2.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-1035) [DUPLICATE] Allow parented collections to have bulk actions associated with them...

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1035:
--
Fix Version/s: (was: 2.7.0)
   1.16.1
  Summary: [DUPLICATE] Allow parented collections to have bulk actions 
associated with them...  (was: Allow parented collections to have bulk actions 
associated with them...)

> [DUPLICATE] Allow parented collections to have bulk actions associated with 
> them...
> ---
>
> Key: ISIS-1035
> URL: https://issues.apache.org/jira/browse/ISIS-1035
> Project: Isis
>  Issue Type: New Feature
>  Components: Core, Core: Viewer: Wicket
>Affects Versions: core-1.7.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>
> ... so that they have checkboxes against them, and the invoked action is 
> called for each selected instance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ISIS-1035) [DUPLICATE] Allow parented collections to have bulk actions associated with them...

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-1035.
---
Resolution: Duplicate

see ISIS-1585

> [DUPLICATE] Allow parented collections to have bulk actions associated with 
> them...
> ---
>
> Key: ISIS-1035
> URL: https://issues.apache.org/jira/browse/ISIS-1035
> Project: Isis
>  Issue Type: New Feature
>  Components: Core, Core: Viewer: Wicket
>Affects Versions: core-1.7.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.16.1
>
>
> ... so that they have checkboxes against them, and the invoked action is 
> called for each selected instance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-689) [WON'T FIX] Bulk action take arguments

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-689:
-
Summary: [WON'T FIX] Bulk action take arguments  (was: Bulk action take 
arguments)

> [WON'T FIX] Bulk action take arguments
> --
>
> Key: ISIS-689
> URL: https://issues.apache.org/jira/browse/ISIS-689
> Project: Isis
>  Issue Type: New Feature
>  Components: Core: Viewer: Wicket
>Affects Versions: viewer-wicket-1.3.1
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-689) Bulk action take arguments

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-689:
-
Fix Version/s: (was: 2.6.0)
   1.16.1

> Bulk action take arguments
> --
>
> Key: ISIS-689
> URL: https://issues.apache.org/jira/browse/ISIS-689
> Project: Isis
>  Issue Type: New Feature
>  Components: Core: Viewer: Wicket
>Affects Versions: viewer-wicket-1.3.1
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-689) [WON'T FIX] Bulk action take arguments

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-689:
-
Description: see instead ISIS-1585 ... bulk actions deprecated

> [WON'T FIX] Bulk action take arguments
> --
>
> Key: ISIS-689
> URL: https://issues.apache.org/jira/browse/ISIS-689
> Project: Isis
>  Issue Type: New Feature
>  Components: Core: Viewer: Wicket
>Affects Versions: viewer-wicket-1.3.1
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>
> see instead ISIS-1585 ... bulk actions deprecated



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ISIS-689) [WON'T FIX] Bulk action take arguments

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-689.
--
Resolution: Won't Fix

> [WON'T FIX] Bulk action take arguments
> --
>
> Key: ISIS-689
> URL: https://issues.apache.org/jira/browse/ISIS-689
> Project: Isis
>  Issue Type: New Feature
>  Components: Core: Viewer: Wicket
>Affects Versions: viewer-wicket-1.3.1
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>
> see instead ISIS-1585 ... bulk actions deprecated



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ISIS-1395) [WON'T FIX] Bulk actions button is shown for a collection, even if not in table view (eg showing collection as a map)

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood updated ISIS-1395:
--
Summary: [WON'T FIX] Bulk actions button is shown for a collection, even if 
not in table view (eg showing collection as a map)  (was: Bulk actions button 
is shown for a collection, even if not in table view (eg showing collection as 
a map))

> [WON'T FIX] Bulk actions button is shown for a collection, even if not in 
> table view (eg showing collection as a map)
> -
>
> Key: ISIS-1395
> URL: https://issues.apache.org/jira/browse/ISIS-1395
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.12.1
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>
> Perhaps the collection components should have an API as to whether they 
> support the concept of selectable (ie checkboxes or equivalent mechanism).  
> Only show bulk action button for those that do.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ISIS-1395) [WON'T FIX] Bulk actions button is shown for a collection, even if not in table view (eg showing collection as a map)

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood resolved ISIS-1395.
---
   Resolution: Won't Fix
Fix Version/s: (was: 2.5.0)
   1.16.1

deprecating bulk actions.

> [WON'T FIX] Bulk actions button is shown for a collection, even if not in 
> table view (eg showing collection as a map)
> -
>
> Key: ISIS-1395
> URL: https://issues.apache.org/jira/browse/ISIS-1395
> Project: Isis
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.12.1
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>
> Perhaps the collection components should have an API as to whether they 
> support the concept of selectable (ie checkboxes or equivalent mechanism).  
> Only show bulk action button for those that do.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ISIS-1864) Refactor EntityModel and ScalarModel so that don't unnecessarily reset scalar model properties after action invocation.

[Dan Haywood (JIRA)]

Dan Haywood created ISIS-1864:
-

 Summary: Refactor EntityModel and ScalarModel so that don't 
unnecessarily reset scalar model properties after action invocation.
 Key: ISIS-1864
 URL: https://issues.apache.org/jira/browse/ISIS-1864
 Project: Isis
  Issue Type: Improvement
Affects Versions: 1.16.0
Reporter: Dan Haywood
 Fix For: 2.0.0


as per 
[https://lists.apache.org/thread.html/9924509e3d3e0398e230467d80370e2f9d6dc94641aaa402db56c24e@%3Cusers.isis.apache.org%3E]

 

I think that the parent EntityModel shouldnt' really have this responsibility 
of telling each of its child ScalarModel's to reset themselves. Rather, perhaps 
it should simply instruct the ScalarModels that they are now dirty, so that if 
and when the ScalarModels are next asked for their state (for re-rendering) 
they then will query the underlying domain object ... but not before.

 

Also, ScalarModel inherits from EntityModel, but I think that's not correct; 
should factor out a common supertype for both.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Reopened] (ISIS-1585) Allow objects in parented collections to be selected, automatically passed as defaults for collection parameter of associated actions. Also infer choices for both scalar

[Dan Haywood (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ISIS-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Haywood reopened ISIS-1585:
---

> Allow objects in parented collections to be selected, automatically passed as 
> defaults for collection parameter of associated actions.  Also infer choices 
> for both scalar and collection parameters.
> -
>
> Key: ISIS-1585
> URL: https://issues.apache.org/jira/browse/ISIS-1585
> Project: Isis
>  Issue Type: New Feature
>  Components: Core
>Affects Versions: 1.13.2.1
>Reporter: Dan Haywood
>Assignee: Dan Haywood
>Priority: Minor
> Fix For: 1.16.1
>
>
> This in effect deprecates the concept of bulk actions... instead use a view 
> model as a wrapper around a collection returned by an action.
> 
>  Currently we have the concept of a "bulk" action; this is one that operates 
> only on a standalone collection of objects (ie as returned by an action 
> invocation). When one or bulk actions are defined, then the viewer renders 
> the bulk actions' buttons above the collection.
> There's an example in the todoapp [1]. Run the app with the 
> ToDoAppAppManifestWithFixtures, then run ToDos > Not Yet Complete. You'll see 
> [2], with "Not Yet Completed" as one of the actions. This is because of the 
> code in [3], by way of @Action(invokeOn=OBJECT_AND_COLLECTION) [4]
> There are however some restrictions to this:
>  * bulk actions cannot take parameters
>  * it isn't possible to invoke actions on parented collections, only on 
> standalone collections.
> In 1.14.0-SNAPSHOT I recently added support for actions that accept 
> collections as parameters. This hasn't yet been released, but will be the 
> "headline" feature in 1.14.0. Building on that I see an opportunity to build 
> upon it to (a) lift both restrictions and (b) remove some code from the 
> framework.
> So, my idea is:
>  * add the ability to have selections on parented collections too
>  * for actions that are "associated" with a parented collection and that have 
> a collection parameter taking the type of that list, have the framework 
> automatically use the selected objects as the argument values.
>  * we deprecate the whole concept of bulk actions (ie @Action#invokeOn=...) 
> to remove in the future. Instead, the replacement would simply be a parented 
> collection of a view model.
> We currently associate actions with collections using @MemberOrder(...); or 
> this can be done using the .layout.xml file. So the coding model would be 
> something like:
> {code:java}
> public class ToDoAppDashboard {   // our existing view model for the home page
> public List getNotYetCompleted() { ... }// our parented 
> collection
> @MemberOrder(named="notYetCompleted", sequence="1")
> public ToDoAppDashboard markAsCompleted(
> List items,
> boolean 
> automaticallyDelete) { // an additional parameter, just to demonstrate 
> the point
> ...
> }
> }
> {code}
> and ideally this is all that would be needed. The user would select items 
> using checkboxes on the "notYetCompleted" collection, and the would be able 
> to invoke the "markAsCompleted" action with the first parameter already 
> populated/defaulted.
> Under the covers, the selected items would correspond to a DefaultedFacet for 
> the parameter, and there would be a DisabledFacet on the entire action if no 
> objects has been selected.
> I can see several steps to implement this. As well as the actual UI changes 
> to the Wicket viewer (CollectionAsContentsTable or something like that), 
> there will also be some metamodel stuff to add in, ie new FacetFactories.
> The support we currently have for lists of objects as parameters requires 
> that there's a ChoicesFacet for the parameter type. So initially the 
> framework would need to generate this facet behind the scenes; it's 
> implementation would be equivalent to:
> {code:java}
>  public List choices0MarkAsCompleted() { return 
> getNotYetCompleted(); }
> {code}
> For the actual selected items, I am thinking it would be useful to introduce 
> an internal domain service for use by the framework, called something like 
> SelectedItemService. You'll see that the framework has a whole bunch defined 
> in the metamodel module [5], and a bunch more in the runtime module [6]. 
> (Many of these are also exposed as formal API in the applib [7], but not all; 
> see also [8]).
> Anyway, so SelectedItemService (annotated with @RequestScoped, "obviously") 
> could be a way to provide the list of items currently selected. The 

Re: Merging maint-1.16.1 into master; checking status of our branches

[Dan Haywood]

Hi Andi,

I was drafting this a few days ago, didn't get around to sending...

within..


> - ISIS-1846_internal_utils -
>
> This branch introduces the new 'Internal API', a collection of code idioms
> frequently used in isis-core-applib. If we commit to using this Internal
> API, we should merge this branch into 2.0.0-M1 as soon as possible. (Not
> sure if a fast forward will work ... there's a lot of code being moved
> around, but you may definitely try.)
>
>
ok, I've merged this into master.  you are right, a fast-forward wasn't
possible, but there were only a couple of conflicts, easily fixed.





>
> - ISIS-1740_where_am_i - my recollection was this was close to being done
> and could be merged in (behind a config option?).
>
> Yes is ready, can be merged in. Only documentation is missing. We have
> config options to enable or disable this feature. It introduces a new
> annotation in applib: @Parent
>
>
also merged into master.

I have a question re the @Parent annotation, but I'll start a new thread
for this.




>
> - ISIS-1852_parallel_stream_patch - this looks like a bit of a spike to
> support some JEE use cases, should this be based on M2?
>
> No ISIS-1852 [1] is rather a severe issue, which also affects 1.16. (It
> prevents use of parallel streams on collections of domain objects.)
>
>
ok, I've rebased this on top of maint-1.16.1.  I've just cancelled the RC1
vote so we can release this in 1.16.1 after all.

I've also merged the branch into master so that - irrespective of what we
do with 1.16  - it will be part of 2.0.0 M1.




>
> We also have for M2:
>
> - dev/2.0.0-M2 which has the DN 5.1 and much more of the JEE stuff
> - ISIS-1779-jax-rs-2 ... hmm, looks like all of this branch except the
> very last commit (Transition to JAX-RS 2.0 Client API) was actually rebased
> onto dev/2.0.0-M2.  So, I think this last commit needs to be cherry-picked
> onto M2?
>
> Let's not worry about ISIS-1779-jax-rs-2 too much right now. The last
> commit [2] is kind of an experiment, and maybe I need to redo some of these
> ideas anyway.
>
>
(I mailed you separately on this also, but to reiterate...)

I went ahead and cherry-picked ISIS-1779-jax-rs-2 on top of dev/2.0.0-M2,
it was easy to do.

I then went ahead to rebase dev/2.0.0-M2 + ISIS-1779-jax-rs-2 on top of
master.  This threw up quite a few conflicts along the way which I resolved
as best I could, but in some cases you had made the code changes on both
sides of the conflict, so I wasn't 100% sure which way to go.

Once I'd finished rebasing I therefore decided to rename the branches to
dev/2.0.0-M2-rebased and ISIS-1779-jax-rs-2-rebased and pushed these.

Could you review these branches?  If they are ok then force push them to
replace origin/dev/2.0.0-M2 and origin/ISIS-1779-jax-rs-2.  If they aren't
ok, could you do the rebase yourself and push?

Thx
Dan




>
>
> thanks
> Dan
>
>
>
>
> [1] https://issues.apache.org/jira/browse/ISIS-1852
> [2]
> https://github.com/apache/isis/commit/fd8670e8337f99832f767bf24c26dde33bf34cc5
>

Re: [VOTE] Apache Isis Core release 1.16.1 RC1

[Dan Haywood]

Hi folks,

We have +2 on this, however there are a number of small issues@
- Kevin found an issue with the release instructions which should be tidied
up
- I learnt from Andi that it would be good to get ISIS-1852
(InheritableThreadLocal) as part of the release
- there's also an improvement that could be made to ISIS-1585 (checkboxes
on parented collections).

So, I'm gonna cancel this RC1, fix those issues, and go round the loop
again for an RC2.

Thx
Dan


On Thu, 15 Feb 2018 at 19:27 Kevin Meyer  wrote:

> Ok, I'll +1 but with reservations
>
> Comments:
> - I could only compile and install the core components by commenting out
> the "git-commit-id-plugin" sections in the root pom.xml
> - The instructions in the committers guide do not work:
> * mvn dependency:go-offline fails
> * All the offline "-o" instructions fail (there are always dependencies
> that need to be downloaded, and they *only* download successfully with an
> online compilation)
>
> Is it just me?
> Can someone else flush their repository:
> $ rm -rf ~/.m2/repostitory/[a-z]
> and check the first instructions:
> $ unzip isis-1.16.1-source-release.zip
> $ cd isis-1.16.1
> $ mvn dependency:go-offline
>
> Cheers,
> Kevin
>
> On Thu, February 15, 2018 19:46, Kevin Meyer wrote:
> > I get a build failure:
> >
> >
> > [INFO]
> > 
> > [INFO] BUILD FAILURE
> > [INFO]
> > 
> > [INFO] Total time: 13.391 s
> > [INFO] Finished at: 2018-02-15T19:44:04+01:00
> > [INFO] Final Memory: 33M/385M
> > [INFO]
> > 
> > [ERROR] Failed to execute goal
> > pl.project13.maven:git-commit-id-plugin:2.2.3:revision
> (get-the-git-infos)
> >  on project isis-core-schema: .git directory is not found! Please specify
> > a valid [dotGitDirectory] in your pom.xml -> [Help 1] [ERROR]
> > [ERROR] To see the full stack trace of the errors, re-run Maven with the
> > -e switch.
> > [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> > [ERROR]
> > [ERROR] For more information about the errors and possible solutions,
> > please read the following articles: [ERROR] [Help 1]
> > http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> > [ERROR]
> > [ERROR] After correcting the problems, you can resume the build with the
> > command [ERROR]   mvn  -rf :isis-core-schema
> >
> >
> > Any advice?
> >
> >
> > Cheers,
> > Kevin
> >
> >
> >
> > On Wed, February 14, 2018 11:10, Dan Haywood wrote:
> >
> >> I've cut a release for Apache Isis Core and the two archetypes:
> >>
> >>
> >>
> >> * Core 1.16.1
> >> * HelloWorld Archetype 1.16.1
> >> * SimpleApp Archetype 1.16.1
> >>
> >>
> >>
> >> The source code artifacts have been uploaded to staging repositories on
> >>  repository.apache.org:
> >>
> >>
> >>
> >> *
> >>
> http://repository.apache.org/content/repositories/orgapacheisis-1064/org
> >> /a
> >> pache/isis/core/isis/1.16.1/isis-1.16.1-source-release.zip *
> >> http://repository.apache.org/content/repositories/orgapacheisis-1065/or
> >> g/a
> >> pache/isis/archetype/helloworld-archetype/1.16.1/helloworld-archetype-1
> >> .1
> >> 6.1-source-release.zip
> >> *
> >>
> http://repository.apache.org/content/repositories/orgapacheisis-1065/org
> >> /a
> >> pache/isis/archetype/simpleapp-archetype/1.16.1/simpleapp-archetype-1.16
> >> .
> >> 1-source-release.zip
> >>
> >>
> >>
> >> For each zip there is a corresponding signature file (append .asc to
> >> the zip's url).
> >>
> >> In the source code repo the code has been tagged as isis-1.16.1-RC1,
> >> helloworld-archetype-1.16.1-RC1 and simpleapp-archetype-1.16.1-RC1; see
> >> https://github.com/apache/isis/tags
> >>
> >>
> >>
> >> For instructions on how to verify the release (build from binaries
> >> and/or use in Maven directly), see
> >> https://isis.apache.org/guides/cgcom/cgcom.html#_cgcom_verifying-releas
> >> es
> >>
> >>
> >> Please verify the release and cast your vote.  The vote will be open
> >> for a minimum of 72 hours.
> >>
> >> [ ] +1
> >> [ ]  0
> >> [ ] -1
> >>
> >>
> >>
> >
> >
>
>
> --
> Kevin Meyer
> Ljubljana, Slovenia
>
>
>