[jira] [Commented] (ISIS-2112) Use Spring Boot for 'Service Provisioning'
[ https://issues.apache.org/jira/browse/ISIS-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842578#comment-16842578 ] ASF subversion and git services commented on ISIS-2112: --- Commit d8be4a26fe27b289a8bf9e2914154b68c27f7467 in isis's branch refs/heads/2112_SpringBoot from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=d8be4a2 ] ISIS-2112: fixing the 'demo-app' - successfully deploys on tomcat - main menu and viewmodels seem to work - however, eventbus and mementos don't work yet Task-Url: https://issues.apache.org/jira/browse/ISIS-2112 > Use Spring Boot for 'Service Provisioning' > -- > > Key: ISIS-2112 > URL: https://issues.apache.org/jira/browse/ISIS-2112 > Project: Isis > Issue Type: Improvement > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2112) Use Spring Boot for 'Service Provisioning'
[ https://issues.apache.org/jira/browse/ISIS-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842579#comment-16842579 ] ASF subversion and git services commented on ISIS-2112: --- Commit d8be4a26fe27b289a8bf9e2914154b68c27f7467 in isis's branch refs/heads/2112_SpringBoot from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=d8be4a2 ] ISIS-2112: fixing the 'demo-app' - successfully deploys on tomcat - main menu and viewmodels seem to work - however, eventbus and mementos don't work yet Task-Url: https://issues.apache.org/jira/browse/ISIS-2112 > Use Spring Boot for 'Service Provisioning' > -- > > Key: ISIS-2112 > URL: https://issues.apache.org/jira/browse/ISIS-2112 > Project: Isis > Issue Type: Improvement > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2112) Use Spring Boot for 'Service Provisioning'
[ https://issues.apache.org/jira/browse/ISIS-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842428#comment-16842428 ] ASF subversion and git services commented on ISIS-2112: --- Commit f6c1efc55cbbdb553a1428d1627037cecb3bcea5 in isis's branch refs/heads/2112_SpringBoot from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=f6c1efc ] ISIS-2112: further fixes 'metamodel' provisioning for 'helloworld' - include helloworld's domain-objects with Springs component-scan Task-Url: https://issues.apache.org/jira/browse/ISIS-2112 > Use Spring Boot for 'Service Provisioning' > -- > > Key: ISIS-2112 > URL: https://issues.apache.org/jira/browse/ISIS-2112 > Project: Isis > Issue Type: Improvement > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2112) Use Spring Boot for 'Service Provisioning'
[ https://issues.apache.org/jira/browse/ISIS-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842427#comment-16842427 ] ASF subversion and git services commented on ISIS-2112: --- Commit f6c1efc55cbbdb553a1428d1627037cecb3bcea5 in isis's branch refs/heads/2112_SpringBoot from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=f6c1efc ] ISIS-2112: further fixes 'metamodel' provisioning for 'helloworld' - include helloworld's domain-objects with Springs component-scan Task-Url: https://issues.apache.org/jira/browse/ISIS-2112 > Use Spring Boot for 'Service Provisioning' > -- > > Key: ISIS-2112 > URL: https://issues.apache.org/jira/browse/ISIS-2112 > Project: Isis > Issue Type: Improvement > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2112) Use Spring Boot for 'Service Provisioning'
[ https://issues.apache.org/jira/browse/ISIS-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842413#comment-16842413 ] ASF subversion and git services commented on ISIS-2112: --- Commit 85ae4e069f48df7ad4e7feeb989c6510f13bfd89 in isis's branch refs/heads/2112_SpringBoot from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=85ae4e0 ] ISIS-2112: starting to fix metamodel discovery issue - simplifies spec loader code - extends the realm of classes to be scanned by Spring Task-Url: https://issues.apache.org/jira/browse/ISIS-2112 > Use Spring Boot for 'Service Provisioning' > -- > > Key: ISIS-2112 > URL: https://issues.apache.org/jira/browse/ISIS-2112 > Project: Isis > Issue Type: Improvement > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2112) Use Spring Boot for 'Service Provisioning'
[ https://issues.apache.org/jira/browse/ISIS-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842414#comment-16842414 ] ASF subversion and git services commented on ISIS-2112: --- Commit 85ae4e069f48df7ad4e7feeb989c6510f13bfd89 in isis's branch refs/heads/2112_SpringBoot from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=85ae4e0 ] ISIS-2112: starting to fix metamodel discovery issue - simplifies spec loader code - extends the realm of classes to be scanned by Spring Task-Url: https://issues.apache.org/jira/browse/ISIS-2112 > Use Spring Boot for 'Service Provisioning' > -- > > Key: ISIS-2112 > URL: https://issues.apache.org/jira/browse/ISIS-2112 > Project: Isis > Issue Type: Improvement > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ISIS-2056) Fix Sonar Findings
[ https://issues.apache.org/jira/browse/ISIS-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood resolved ISIS-2056. --- Resolution: Fixed > Fix Sonar Findings > -- > > Key: ISIS-2056 > URL: https://issues.apache.org/jira/browse/ISIS-2056 > Project: Isis > Issue Type: Improvement >Reporter: Jörg Rade >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1984) Extend RO representation to show property format or type in object members
[ https://issues.apache.org/jira/browse/ISIS-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1984: -- Fix Version/s: (was: 1.18.0) 2.0.3 > Extend RO representation to show property format or type in object members > -- > > Key: ISIS-1984 > URL: https://issues.apache.org/jira/browse/ISIS-1984 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.16.2 >Reporter: Dan Haywood >Priority: Minor > Fix For: 2.0.3 > > Attachments: contactnumber21.json > > > See attached json representation of a contact number > "x-isis-format": "string" > is present in string properties > however, this attribute is not on object properties. > It would be very benefitial to have all I need to render that property in > this page only. Ideally, something like > "x-isis-returntype" with the url to the domain-type (e.g. > [http://localhost:8080/restful/domain-types/org.incode.eurocommercial.contactapp.dom.number.ContactNumber/properties/owner]) > for now, I will render any non-string as a generic catch all object viewer > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1980) Unexpected error when accessing collection through wrapper.
[
https://issues.apache.org/jira/browse/ISIS-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-1980:
--
Fix Version/s: (was: 1.18.0)
2.1.4
> Unexpected error when accessing collection through wrapper.
> ---
>
> Key: ISIS-1980
> URL: https://issues.apache.org/jira/browse/ISIS-1980
> Project: Isis
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.16.2
>Reporter: Andi Huber
>Priority: Major
> Fix For: 2.1.4
>
>
> As reported by Gabriel Terwesten [1]
> Inside of integration tests i can’t seem to access collections through the
> getter if the object is wrapped. From the documentation I got the impression
> that that should be possible.
> This is the offending line:
> assertThat(wrap(food).getCustomUnits()).hasSize(1);
> {noformat}
> IllegalArgumentException: d.m.c.d.i.Food#customUnits: more than one
> ImperativeFacet for method getCustomUnits , with inconsistent intents: ...
> at o.a.i.c.m.facets.ImperativeFacet$Util.getIntent(ImperativeFacet.java:167)
> {noformat}
> [1]
> https://lists.apache.org/thread.html/cd92d8cd28ae877104fc965f83ca90b98e2e8188f464b65181e79a27@%3Cusers.isis.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ISIS-2004) Concurrent Modification Exception in grid service
[
https://issues.apache.org/jira/browse/ISIS-2004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-2004:
--
Fix Version/s: (was: 1.18.0)
2.1.4
> Concurrent Modification Exception in grid service
> -
>
> Key: ISIS-2004
> URL: https://issues.apache.org/jira/browse/ISIS-2004
> Project: Isis
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Trivial
> Fix For: 2.1.4
>
>
> This occurred when invoking "latestFastnetImportLog" within Estatio (having
> just restarted, in estatio-test - prototype mode)
> {code}
> 11:20:44,677 [RequestCycleExtra ] Handling the following exception
> org.apache.wicket.WicketRuntimeException: Error attaching this container for
> rendering: [RepeatingViewWithDynamicallyVisibleContent [Component id =
> tabGroups]]
> at
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1837)
> at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
> at
> org.apache.wicket.markup.repeater.AbstractRepeater.onBeforeRender(AbstractRepeater.java:143)
> at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
> at org.apache.wicket.Component.beforeRender(Component.java:1018)
> at
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
> at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
> at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
> at org.apache.wicket.Component.beforeRender(Component.java:1018)
> at
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
> at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
> at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
> at org.apache.wicket.Component.beforeRender(Component.java:1018)
> at
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
> at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
> at
> org.apache.wicket.markup.repeater.AbstractRepeater.onBeforeRender(AbstractRepeater.java:143)
> at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
> at org.apache.wicket.Component.beforeRender(Component.java:1018)
> at
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
> at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
> at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
> at org.apache.wicket.Component.beforeRender(Component.java:1018)
> at
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
> at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
> at
> org.apache.wicket.markup.repeater.AbstractRepeater.onBeforeRender(AbstractRepeater.java:143)
> at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
> at org.apache.wicket.Component.beforeRender(Component.java:1018)
> at
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
> at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
> at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
> at org.apache.wicket.Component.beforeRender(Component.java:1018)
> at
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
> at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
> at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
> at org.apache.wicket.Component.beforeRender(Component.java:1018)
> at
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
> at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
> at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
> at org.apache.wicket.Component.beforeRender(Component.java:1018)
> at
> org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1825)
> at org.apache.wicket.Component.onBeforeRender(Component.java:3916)
> at org.apache.wicket.Page.onBeforeRender(Page.java:801)
> at org.apache.wicket.Component.internalBeforeRender(Component.java:950)
> at org.apache.wicket.Component.beforeRender(Component.java:1018)
> at
> org.apache.wicket.Component.internalPrepareForRender(Component.java:2236)
> at org.apache.wicket.Page.internalPrepareForRender(Page.java:242)
> at org.apache.wicket.Component.render(Component.java:2325)
> at org.apache.wicket.Page.renderPage(Page.java:1018)
[jira] [Updated] (ISIS-1973) "republish" mixin - action button is rendered but attempting to invoke throws an exception
[
https://issues.apache.org/jira/browse/ISIS-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-1973:
--
Fix Version/s: (was: 1.18.0)
2.0.3
> "republish" mixin - action button is rendered but attempting to invoke throws
> an exception
> --
>
> Key: ISIS-1973
> URL: https://issues.apache.org/jira/browse/ISIS-1973
> Project: Isis
> Issue Type: Bug
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.0.3
>
>
> h2. To reproduce:
> * login with estatio-user-it, ensure has "estatio-user" role but doesn't
> have "estatio-superuser" role.
> - navigate to
> http://estatiotest.int.prd.ecpnv.com/wicket/entity/org.estatio.dom.invoice.Invoice:106874
> - the "republish" action (contributed from
> - when invoke, get an exception in the UI, with stack trace below:
>
> message shown to user:
> Reason: Not authorized to view. Identifier:
> org.isisaddons.module.publishmq.dom.jdo.events.PublishedEvent_republish#$$()
> stack trace:
> {code}
> Caused by: org.apache.isis.core.commons.exceptions.IsisApplicationException:
> org.apache.isis.applib.services.wrapper.HiddenException: Reason: Not
> authorized to view. Identifier:
> org.isisaddons.module.publishmq.dom.jdo.events.PublishedEvent_republish#$$()
> at
> org.apache.isis.core.commons.lang.ThrowableExtensions.throwWithinIsisException(ThrowableExtensions.java:55)
> at
> org.apache.isis.core.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract$2.execute(ActionInvocationFacetForDomainEventAbstract.java:303)
> at
> org.apache.isis.core.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract$2.execute(ActionInvocationFacetForDomainEventAbstract.java:222)
> at
> org.apache.isis.applib.services.iactn.Interaction.executeInternal(Interaction.java:173)
> at
> org.apache.isis.applib.services.iactn.Interaction.execute(Interaction.java:143)
> at
> org.apache.isis.core.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract.doInvoke(ActionInvocationFacetForDomainEventAbstract.java:310)
> at
> org.apache.isis.core.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract$1.execute(ActionInvocationFacetForDomainEventAbstract.java:164)
> at
> org.apache.isis.core.runtime.system.transaction.IsisTransactionManager.executeWithinTransaction(IsisTransactionManager.java:142)
> at
> org.apache.isis.core.runtime.system.transaction.IsisTransactionManager.executeWithinTransaction(IsisTransactionManager.java:132)
> at
> org.apache.isis.core.runtime.services.persistsession.PersistenceSessionServiceInternalDefault.executeWithinTransaction(PersistenceSessionServiceInternalDefault.java:192)
> at
> org.apache.isis.core.metamodel.facets.actions.action.invocation.ActionInvocationFacetForDomainEventAbstract.invoke(ActionInvocationFacetForDomainEventAbstract.java:160)
> at
> org.apache.isis.core.metamodel.specloader.specimpl.ObjectActionDefault.executeInternal(ObjectActionDefault.java:400)
> at
> org.apache.isis.core.metamodel.specloader.specimpl.ObjectActionMixedIn.execute(ObjectActionMixedIn.java:230)
> at
> org.apache.isis.core.metamodel.specloader.specimpl.ObjectActionDefault.executeWithRuleChecking(ObjectActionDefault.java:370)
> at
> org.apache.isis.viewer.wicket.model.models.ActionModel.executeAction(ActionModel.java:460)
> at
> org.apache.isis.viewer.wicket.model.models.ActionModel.load(ActionModel.java:439)
> at
> org.apache.isis.viewer.wicket.model.models.ActionModel.load(ActionModel.java:76)
> at
> org.apache.wicket.model.LoadableDetachableModel.getObject(LoadableDetachableModel.java:135)
> at
> org.apache.isis.viewer.wicket.model.models.ActionModel.execute(ActionModel.java:569)
> at
> org.apache.isis.viewer.wicket.ui.components.actions.ActionFormExecutorStrategy.obtainResultAdapter(ActionFormExecutorStrategy.java:71)
> at
> org.apache.isis.viewer.wicket.ui.panels.FormExecutorDefault.obtainResultAdapter(FormExecutorDefault.java:514)
> at
> org.apache.isis.viewer.wicket.ui.panels.FormExecutorDefault.executeAndProcessResults(FormExecutorDefault.java:147)
> at
> org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.ActionLinkFactoryAbstract.onClick(ActionLinkFactoryAbstract.java:214)
> at
> org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.ActionLinkFactoryAbstract.access$100(ActionLinkFactoryAbstract.java:71)
> at
> org.apache.isis.viewer.wicket.ui.components.widgets.linkandlabel.ActionLinkFactoryAbstract$1.performOnClick(ActionLinkFactoryAbstract.java:147)
> at
>
[jira] [Closed] (ISIS-1938) [WON'T FIX] Unable to specify FakeDataModule as a dependency using ModuleAbstract#withAdditionalDependencies
[
https://issues.apache.org/jira/browse/ISIS-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood closed ISIS-1938.
-
Resolution: Won't Fix
This is all being reworked for v2 / SB
> [WON'T FIX] Unable to specify FakeDataModule as a dependency using
> ModuleAbstract#withAdditionalDependencies
>
>
> Key: ISIS-1938
> URL: https://issues.apache.org/jira/browse/ISIS-1938
> Project: Isis
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> as a workaround, had to override getDependencies()
> {code:java}
> java.lang.IllegalArgumentException: Module domainapp.modules.PetClinicModule
> has returned class org.isisaddons.module.fakedata.FakeDataModule from
> getAdditionalModules(). This class implements 'Module' interface so should
> instead be returned from getDependencies()
> at
> org.apache.isis.applib.Module$Util.transitiveAdditionalModulesOf(Module.java:150)
> at
> org.apache.isis.applib.ModuleOrBuilderAbstract.withTransitiveFrom(ModuleOrBuilderAbstract.java:66)
> at
> org.apache.isis.applib.AppManifestAbstract2$Builder.(AppManifestAbstract2.java:99)
> at
> org.apache.isis.applib.AppManifestAbstract2$Builder.forModule(AppManifestAbstract2.java:92)
> at
> org.apache.isis.core.runtime.headless.IsisSystemBootstrapper.(IsisSystemBootstrapper.java:60)
> at
> org.apache.isis.core.runtime.headless.HeadlessWithBootstrappingAbstract.(HeadlessWithBootstrappingAbstract.java:94)
> at
> org.apache.isis.core.integtestsupport.IntegrationTestAbstract3.(IntegrationTestAbstract3.java:160)
> at
> org.apache.isis.core.integtestsupport.IntegrationTestAbstract3.(IntegrationTestAbstract3.java:154)
> at
> domainapp.modules.impl.PetClinicModuleIntegTestAbstract.(PetClinicModuleIntegTestAbstract.java:34)
> at
> domainapp.modules.impl.visits.integtests.Visit_enterOutcome_IntegTest.(Visit_enterOutcome_IntegTest.java:37)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.junit.runners.BlockJUnit4ClassRunner.createTest(BlockJUnit4ClassRunner.java:217)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.runReflectiveCall(BlockJUnit4ClassRunner.java:266)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.BlockJUnit4ClassRunner.methodBlock(BlockJUnit4ClassRunner.java:263)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ISIS-1938) [WON'T FIX] Unable to specify FakeDataModule as a dependency using ModuleAbstract#withAdditionalDependencies
[
https://issues.apache.org/jira/browse/ISIS-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-1938:
--
Summary: [WON'T FIX] Unable to specify FakeDataModule as a dependency using
ModuleAbstract#withAdditionalDependencies (was: Unable to specify
FakeDataModule as a dependency using ModuleAbstract#withAdditionalDependencies)
> [WON'T FIX] Unable to specify FakeDataModule as a dependency using
> ModuleAbstract#withAdditionalDependencies
>
>
> Key: ISIS-1938
> URL: https://issues.apache.org/jira/browse/ISIS-1938
> Project: Isis
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> as a workaround, had to override getDependencies()
> {code:java}
> java.lang.IllegalArgumentException: Module domainapp.modules.PetClinicModule
> has returned class org.isisaddons.module.fakedata.FakeDataModule from
> getAdditionalModules(). This class implements 'Module' interface so should
> instead be returned from getDependencies()
> at
> org.apache.isis.applib.Module$Util.transitiveAdditionalModulesOf(Module.java:150)
> at
> org.apache.isis.applib.ModuleOrBuilderAbstract.withTransitiveFrom(ModuleOrBuilderAbstract.java:66)
> at
> org.apache.isis.applib.AppManifestAbstract2$Builder.(AppManifestAbstract2.java:99)
> at
> org.apache.isis.applib.AppManifestAbstract2$Builder.forModule(AppManifestAbstract2.java:92)
> at
> org.apache.isis.core.runtime.headless.IsisSystemBootstrapper.(IsisSystemBootstrapper.java:60)
> at
> org.apache.isis.core.runtime.headless.HeadlessWithBootstrappingAbstract.(HeadlessWithBootstrappingAbstract.java:94)
> at
> org.apache.isis.core.integtestsupport.IntegrationTestAbstract3.(IntegrationTestAbstract3.java:160)
> at
> org.apache.isis.core.integtestsupport.IntegrationTestAbstract3.(IntegrationTestAbstract3.java:154)
> at
> domainapp.modules.impl.PetClinicModuleIntegTestAbstract.(PetClinicModuleIntegTestAbstract.java:34)
> at
> domainapp.modules.impl.visits.integtests.Visit_enterOutcome_IntegTest.(Visit_enterOutcome_IntegTest.java:37)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.junit.runners.BlockJUnit4ClassRunner.createTest(BlockJUnit4ClassRunner.java:217)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.runReflectiveCall(BlockJUnit4ClassRunner.java:266)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.BlockJUnit4ClassRunner.methodBlock(BlockJUnit4ClassRunner.java:263)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ISIS-1937) NPE when render domain entity for first time that has contributed action on contributed collection.
[
https://issues.apache.org/jira/browse/ISIS-1937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-1937:
--
Fix Version/s: (was: 1.18.0)
2.0.3
> NPE when render domain entity for first time that has contributed action on
> contributed collection.
> ---
>
> Key: ISIS-1937
> URL: https://issues.apache.org/jira/browse/ISIS-1937
> Project: Isis
> Issue Type: Bug
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.0.3
>
>
> for example
> [https://github.com/danhaywood/busydevtutorial]
> in Pets.layout.xml, remove the "visits" collection to reproduce. The
> contributed Pet_bookVisit action causes the issue because its "owner" is not
> declared and so returns null.
>
> {code:java}
> Caused by: java.lang.NullPointerException
> at
> org.apache.isis.core.metamodel.services.grid.bootstrap3.GridSystemServiceBS3.addActionTo(GridSystemServiceBS3.java:661)
> at
> org.apache.isis.core.metamodel.services.grid.bootstrap3.GridSystemServiceBS3.validateAndNormalize(GridSystemServiceBS3.java:529)
> at
> org.apache.isis.core.metamodel.services.grid.GridSystemServiceAbstract.normalize(GridSystemServiceAbstract.java:165)
> at
> org.apache.isis.core.metamodel.services.grid.GridServiceDefault.normalize(GridServiceDefault.java:102)
> at
> org.apache.isis.core.metamodel.facets.object.grid.GridFacetDefault.load(GridFacetDefault.java:75)
> at
> org.apache.isis.core.metamodel.facets.object.grid.GridFacetDefault.getGrid(GridFacetDefault.java:65)
> at
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.addPropertyColumnsIfRequired(CollectionContentsAsAjaxTablePanel.java:170)
> at
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.buildGui(CollectionContentsAsAjaxTablePanel.java:102)
> at
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel.onInitialize(CollectionContentsAsAjaxTablePanel.java:80)
> at org.apache.wicket.Component.fireInitialize(Component.java:878)
> at
> org.apache.wicket.MarkupContainer.internalInitialize(MarkupContainer.java:1070)
> at org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:1047)
> at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:241)
> at org.apache.wicket.MarkupContainer.addOrReplace(MarkupContainer.java:265)
> at{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ISIS-1936) FK exception on delete action not rendered to user correctly.
[ https://issues.apache.org/jira/browse/ISIS-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1936: -- Fix Version/s: (was: 1.18.0) 2.0.3 > FK exception on delete action not rendered to user correctly. > - > > Key: ISIS-1936 > URL: https://issues.apache.org/jira/browse/ISIS-1936 > Project: Isis > Issue Type: Bug >Affects Versions: 1.16.2 >Reporter: Dan Haywood >Priority: Major > Fix For: 2.0.3 > > > To reproduce: > * for simpleapp, introduce a child entity (not cascade) > * delete parent entity to force an FK exception (due to child entities still > present) > this results in a 500 html exception (RestartResponseException). the FK > exception messages are queued and only rendered subsequently. > (Also, see two exceptions queued, one warning - orange - and one error - red). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1926) Why do we create an ActionInvocationDto for a mixin property anyway ?
[ https://issues.apache.org/jira/browse/ISIS-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1926: -- Fix Version/s: (was: 1.18.0) 2.0.3 > Why do we create an ActionInvocationDto for a mixin property anyway ? > - > > Key: ISIS-1926 > URL: https://issues.apache.org/jira/browse/ISIS-1926 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.16.2 >Reporter: Dan Haywood >Priority: Minor > Fix For: 2.0.3 > > > see ISIS-1925 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1873) Resilience: if hideXxx, disableXxx or validateXxx method throws NPE, then assume veto and log a WARNing.
[
https://issues.apache.org/jira/browse/ISIS-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-1873:
--
Fix Version/s: (was: 1.18.0)
2.0.3
> Resilience: if hideXxx, disableXxx or validateXxx method throws NPE, then
> assume veto and log a WARNing.
>
>
> Key: ISIS-1873
> URL: https://issues.apache.org/jira/browse/ISIS-1873
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 1.16.1
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.0.3
>
>
> Currently the framework doesn't degrade gracefully.
> For example, had a coding error in a hideXxx() method.
> This resulted in the error page, rather than simply hide the relevant member.
> {code:java}
> org.eclipse.jetty.util.thread.QueuedThreadPool#runJob(QueuedThreadPool.java:672)
> org.eclipse.jetty.util.thread.QueuedThreadPool$2#run(QueuedThreadPool.java:590)
> java.lang.Thread#run(Thread.java:745)
> Caused by:
> java.lang.NullPointerException
> org.isisaddons.module.command.dom.CommandJdo#hideReplayStateFailureReason(CommandJdo.java:386)
> sun.reflect.NativeMethodAccessorImpl#invoke0(NativeMethodAccessorImpl.java:-2)
> sun.reflect.NativeMethodAccessorImpl#invoke(NativeMethodAccessorImpl.java:62)
> sun.reflect.DelegatingMethodAccessorImpl#invoke(DelegatingMethodAccessorImpl.java:43)
> java.lang.reflect.Method#invoke(Method.java:498)
> org.apache.isis.core.commons.lang.MethodExtensions#invoke(MethodExtensions.java:53)
> org.apache.isis.core.metamodel.adapter.ObjectAdapter$InvokeUtils#invoke(ObjectAdapter.java:38{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ISIS-1898) Use Joda Interval for LocalDate collection parameter
[
https://issues.apache.org/jira/browse/ISIS-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-1898:
--
Fix Version/s: (was: 1.18.0)
2.0.3
> Use Joda Interval for LocalDate collection parameter
>
>
> Key: ISIS-1898
> URL: https://issues.apache.org/jira/browse/ISIS-1898
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 1.16.1
>Reporter: Sander Ginn
>Priority: Major
> Fix For: 2.0.3
>
>
> {code:java}
> // code placeholder
> {code}
> To accommodate to the requirement of a {{choicesXxx}}/{{autoCompleteXxx}}
> method for a collection parameter on an action, it would be useful to be able
> to return a Joda Interval instead of a collection of LocalDates.
> Furthermore, it is desirable that the available options are offered through
> the date picker that is currently used for single LocalDate parameters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ISIS-1927) Invoking an action returning a non-null Blob via RO results in exception
[
https://issues.apache.org/jira/browse/ISIS-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-1927:
--
Fix Version/s: (was: 1.18.0)
2.0.3
> Invoking an action returning a non-null Blob via RO results in exception
>
>
> Key: ISIS-1927
> URL: https://issues.apache.org/jira/browse/ISIS-1927
> Project: Isis
> Issue Type: Bug
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.3
>
>
> Also as per Erik on users ml
> [https://lists.apache.org/thread.html/2055cf053e713d768c36d2cf25632c8bed74bf757a4be4d3ab540b05@%3Cusers.isis.apache.org%3E]
> the second issue he reports suggests that hitting an action returning a
> non-null Blob via RO results in an exception in OidUtils.
>
> {code:java}
> public static String getOidStr(final ObjectAdapter objectAdapter) {
> final Oid oid = objectAdapter.getOid();
> if (!(oid instanceof RootOid)) {
> throw new IllegalArgumentException("objectAdapter must be a root
> adapter");
> }
> return oid.enStringNoVersion();
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ISIS-1883) Validate that scalar reference parameters (not value types) have a choices or autoComplete.
[ https://issues.apache.org/jira/browse/ISIS-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1883: -- Fix Version/s: (was: 1.18.0) 2.0.3 > Validate that scalar reference parameters (not value types) have a choices or > autoComplete. > --- > > Key: ISIS-1883 > URL: https://issues.apache.org/jira/browse/ISIS-1883 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.16.1 >Reporter: Dan Haywood >Priority: Minor > Fix For: 2.0.3 > > > We do this for collection parameters already (see > ActionChoicesForCollectionParameterFacetFactory) but not for scalar reference > parameter. > NOTE: be careful to ignore scalar VALUE parameters (such as string or date); > obviously they *aren't* required to have a choices or autoComplete facet. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1815) Log URL for when we get Tomcat ClientConnection closed error (which we think is mostly due to slow response and users getting tired of waiting).
[ https://issues.apache.org/jira/browse/ISIS-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1815: -- Fix Version/s: (was: 1.18.0) 2.0.3 > Log URL for when we get Tomcat ClientConnection closed error (which we think > is mostly due to slow response and users getting tired of waiting). > > > Key: ISIS-1815 > URL: https://issues.apache.org/jira/browse/ISIS-1815 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.16.0 >Reporter: Dan Haywood >Priority: Minor > Fix For: 2.0.3 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1864) Refactor EntityModel and ScalarModel so that don't unnecessarily reset scalar model properties after action invocation.
[ https://issues.apache.org/jira/browse/ISIS-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1864: -- Fix Version/s: (was: 1.18.0) 2.0.3 > Refactor EntityModel and ScalarModel so that don't unnecessarily reset scalar > model properties after action invocation. > --- > > Key: ISIS-1864 > URL: https://issues.apache.org/jira/browse/ISIS-1864 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.16.0 >Reporter: Dan Haywood >Priority: Major > Fix For: 2.0.3 > > > as per > [https://lists.apache.org/thread.html/9924509e3d3e0398e230467d80370e2f9d6dc94641aaa402db56c24e@%3Cusers.isis.apache.org%3E] > > I think that the parent EntityModel shouldnt' really have this responsibility > of telling each of its child ScalarModel's to reset themselves. Rather, > perhaps it should simply instruct the ScalarModels that they are now dirty, > so that if and when the ScalarModels are next asked for their state (for > re-rendering) they then will query the underlying domain object ... but not > before. > > Also, ScalarModel inherits from EntityModel, but I think that's not correct; > should factor out a common supertype for both. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1734) Enhance TitleService, return an enhanced TitleBuffer that uses TitleService for new appendTitleOf(...)
[ https://issues.apache.org/jira/browse/ISIS-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1734: -- Fix Version/s: (was: 1.18.0) 2.0.3 > Enhance TitleService, return an enhanced TitleBuffer that uses TitleService > for new appendTitleOf(...) > -- > > Key: ISIS-1734 > URL: https://issues.apache.org/jira/browse/ISIS-1734 > Project: Isis > Issue Type: Improvement > Components: Core >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Priority: Major > Fix For: 2.0.3 > > > thus: > TitleBuffer buffer = titleService.newBuffer(); -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1663) Metamodel validatoor to check: any method annotated with @Property, @Collection or @Action should be public.
[ https://issues.apache.org/jira/browse/ISIS-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1663: -- Fix Version/s: (was: 1.18.0) 2.0.3 > Metamodel validatoor to check: any method annotated with @Property, > @Collection or @Action should be public. > > > Key: ISIS-1663 > URL: https://issues.apache.org/jira/browse/ISIS-1663 > Project: Isis > Issue Type: Improvement >Reporter: Dan Haywood >Priority: Minor > Fix For: 2.0.3 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1666) Inline prompt should show the name of the action
[ https://issues.apache.org/jira/browse/ISIS-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1666: -- Fix Version/s: (was: 1.18.0) 2.0.3 > Inline prompt should show the name of the action > > > Key: ISIS-1666 > URL: https://issues.apache.org/jira/browse/ISIS-1666 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.14.0 >Reporter: Dan Haywood >Priority: Minor > Fix For: 2.0.3 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1692) Should be more resilient if an implementation of TableColumnOrderingService returns a non-existent property name.
[
https://issues.apache.org/jira/browse/ISIS-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-1692:
--
Fix Version/s: (was: 1.18.0)
2.0.3
> Should be more resilient if an implementation of TableColumnOrderingService
> returns a non-existent property name.
> -
>
> Key: ISIS-1692
> URL: https://issues.apache.org/jira/browse/ISIS-1692
> Project: Isis
> Issue Type: Improvement
> Components: Core
>Affects Versions: 1.14.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.3
>
>
> at least in 1.15.0-SNAPSHOT, this gave me an NPE
> eg in Estatio, because of non-existent property in TableColumnOrderingService
> {code}
> @DomainService(nature = NatureOfService.DOMAIN)
> public static class TableColumnOrderServiceForCreditTransfer implements
> TableColumnOrderService {
> @Override
> public List orderParented(
> final Object parent,
> final String collectionId,
> final Class collectionType,
> final List propertyIds) {
> if(parent instanceof PaymentBatch &&
> CreditTransfer.class.isAssignableFrom(collectionType)) {
> return Lists.newArrayList(
> "endToEndId",
> "seller",
> "sellerBankAccount",
> "amount",
> "remittanceInformation"
> );
> }
> return null;
> }
> @Override
> public List orderStandalone(final Class collectionType,
> final List propertyIds) {
> return null;
> }
> }
> {code}
> resulted in stack trace:
> {code}
> java.lang.NullPointerException
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel#createObjectAdapterPropertyColumn(CollectionContentsAsAjaxTablePanel.java:256)
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel#addPropertyColumnsIfRequired(CollectionContentsAsAjaxTablePanel.java:208)
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel#buildGui(CollectionContentsAsAjaxTablePanel.java:102)
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.ajaxtable.CollectionContentsAsAjaxTablePanel#onInitialize(CollectionContentsAsAjaxTablePanel.java:80)
> org.apache.wicket.Component#fireInitialize(Component.java:878)
> org.apache.wicket.MarkupContainer#internalInitialize(MarkupContainer.java:1081)
> org.apache.wicket.MarkupContainer#addedComponent(MarkupContainer.java:1058)
> org.apache.wicket.MarkupContainer#add(MarkupContainer.java:241)
> org.apache.wicket.MarkupContainer#addOrReplace(MarkupContainer.java:265)
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.multiple.CollectionContentsMultipleViewsPanel#addUnderlyingViews(CollectionContentsMultipleViewsPanel.java:118)
> org.apache.isis.viewer.wicket.ui.components.collectioncontents.multiple.CollectionContentsMultipleViewsPanel#onInitialize(CollectionContentsMultipleViewsPanel.java:87)
> org.apache.wicket.Component#fireInitialize(Component.java:878)
> org.apache.wicket.MarkupContainer#internalInitialize(MarkupContainer.java:1081)
> org.apache.wicket.MarkupContainer#addedComponent(MarkupContainer.java:1058)
> org.apache.wicket.MarkupContainer#add(MarkupContainer.java:241)
> org.apache.wicket.MarkupContainer#addOrReplace(MarkupContainer.java:265)
> org.apache.isis.viewer.wicket.viewer.registries.components.ComponentFactoryRegistryDefault#addOrReplaceComponent(ComponentFactoryRegistryDefault.java:107)
> org.apache.isis.viewer.wicket.ui.components.collection.CollectionPanel#buildGui(CollectionPanel.java:87)
> org.apache.isis.viewer.wicket.ui.components.collection.CollectionPanel#onInitialize(CollectionPanel.java:83)
> org.apache.wicket.Component#fireInitialize(Component.java:878)
> org.apache.wicket.MarkupContainer$3#component(MarkupContainer.java:1087)
> org.apache.wicket.MarkupContainer$3#component(MarkupContainer.java:1083)
> org.apache.wicket.util.visit.Visits#visitChildren(Visits.java:144)
> org.apache.wicket.util.visit.Visits#visitChildren(Visits.java:123)
> org.apache.wicket.util.visit.Visits#visitChildren(Visits.java:192)
> org.apache.wicket.MarkupContainer#visitChildren(MarkupContainer.java:983)
> org.apache.wicket.MarkupContainer#internalInitialize(MarkupContainer.java:1082)
> org.apache.wicket.MarkupContainer#addedComponent(MarkupContainer.java:1058)
> org.apache.wicket.MarkupContainer#add(MarkupContainer.java:241)
>
[jira] [Updated] (ISIS-1704) BigDecimal properties are not right aligned in Wicket viewer when shown in read-only mode.
[ https://issues.apache.org/jira/browse/ISIS-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1704: -- Fix Version/s: (was: 1.18.0) 2.0.3 > BigDecimal properties are not right aligned in Wicket viewer when shown in > read-only mode. > -- > > Key: ISIS-1704 > URL: https://issues.apache.org/jira/browse/ISIS-1704 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.15.0 >Reporter: Dan Haywood >Priority: Minor > Fix For: 2.0.3 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1665) inline prompt for panel action should replace entire panel
[ https://issues.apache.org/jira/browse/ISIS-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1665: -- Fix Version/s: (was: 1.18.0) 2.0.3 > inline prompt for panel action should replace entire panel > -- > > Key: ISIS-1665 > URL: https://issues.apache.org/jira/browse/ISIS-1665 > Project: Isis > Issue Type: New Feature >Affects Versions: 1.14.0 >Reporter: Dan Haywood >Priority: Major > Fix For: 2.0.3 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1732) Document "hidden" as a supported method for services.
[
https://issues.apache.org/jira/browse/ISIS-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-1732:
--
Fix Version/s: (was: 1.18.0)
2.0.3
> Document "hidden" as a supported method for services.
> -
>
> Key: ISIS-1732
> URL: https://issues.apache.org/jira/browse/ISIS-1732
> Project: Isis
> Issue Type: Improvement
>Affects Versions: 1.15.0
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.3
>
>
> eg, in kitchensink, we have:
> {code}
> public abstract class RepositoryAbstract {
> private final Class cls;
> public RepositoryAbstract(Class cls, Visibility visibility) {
> this.cls = cls;
> this.visibility = visibility;
> }
> //region > visibility
> private final Visibility visibility;
> protected enum Visibility {
> VISIBLE,
> NOT_VISIBLE
> }
> public boolean hidden() {
> return this.visibility == Visibility.NOT_VISIBLE;
> }
> //endregion
>
> {code}
> and then:
> {code}
> @DomainService(
> repositoryFor = ChildObject.class
> )
> public class ChildObjects extends RepositoryAbstract {
> public ChildObjects() {
> super(ChildObject.class, Visibility.NOT_VISIBLE);
> }
> public ChildObject create(
> final String name,
> final ParentObject parentObject) {
> return repositoryService.persist(ChildObject.create(name,
> parentObject));
> }
> public List listAll() {
> return repositoryService.allInstances(ChildObject.class);
> }
> }
> {code}
> if use super(...VISIBLE) then this service appears in the menu. so,
> "hidden()" is a way of globally hiding an object (or a domain service, at
> least).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ISIS-1612) [WON'T FIX] Extend the programming model so that mixins can have multiple actions
[
https://issues.apache.org/jira/browse/ISIS-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-1612:
--
Summary: [WON'T FIX] Extend the programming model so that mixins can have
multiple actions (was: Extend the programming model so that mixins can have
multiple actions)
> [WON'T FIX] Extend the programming model so that mixins can have multiple
> actions
> -
>
> Key: ISIS-1612
> URL: https://issues.apache.org/jira/browse/ISIS-1612
> Project: Isis
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.14.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>
> I see this as a hybrid of a contributed service and a mixin.
> I quite like the idea of calling these "responsibilities", eg
> {code}
> @Responsibility
> public class Customer_orders {
> private final Customer customer;
> public List getOrders() { ... }
> public Customer addOrder(...) { ... }
> public Customer removeOrder(...) { ... }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (ISIS-1612) [WON'T FIX] Extend the programming model so that mixins can have multiple actions
[
https://issues.apache.org/jira/browse/ISIS-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood closed ISIS-1612.
-
Resolution: Won't Fix
non requirement - I agree with Andi
> [WON'T FIX] Extend the programming model so that mixins can have multiple
> actions
> -
>
> Key: ISIS-1612
> URL: https://issues.apache.org/jira/browse/ISIS-1612
> Project: Isis
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.14.0
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>
> I see this as a hybrid of a contributed service and a mixin.
> I quite like the idea of calling these "responsibilities", eg
> {code}
> @Responsibility
> public class Customer_orders {
> private final Customer customer;
> public List getOrders() { ... }
> public Customer addOrder(...) { ... }
> public Customer removeOrder(...) { ... }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ISIS-1562) Metamodel validator if forget to annotate @DomainObject(nature=ENTITY) with @PersistenceCapable
[
https://issues.apache.org/jira/browse/ISIS-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-1562:
--
Fix Version/s: (was: 1.18.0)
2.0.3
> Metamodel validator if forget to annotate @DomainObject(nature=ENTITY) with
> @PersistenceCapable
> ---
>
> Key: ISIS-1562
> URL: https://issues.apache.org/jira/browse/ISIS-1562
> Project: Isis
> Issue Type: Improvement
> Components: Core
>Affects Versions: 1.13.2
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 2.0.3
>
>
> Also, RepositoryService#persist(...) is a no-op if the domain object passed
> in is not an entity; this should probably fail-fast.
> This was originally prompted by an obscure message being thrown in
> Memento#updateFieldsAndResolveState(...), as the result of an entity being
> treated as transient, because (a) the @PersistenceCapable annotation was
> accidentally omitted, and (b) a call to RepositoryService#persist(...) just
> did nothing.
> So, this ticket would be a fail-fast for that scenario.
> {code}
> private void updateFieldsAndResolveState(final ObjectAdapter
> objectAdapter, final Data data) {
>
> boolean dataIsTransient = data.getOid().isTransient();
>
> if (!dataIsTransient) {
>...
> } else if (objectAdapter.isTransient() && dataIsTransient) {
>...
>
> } else if (objectAdapter.isParentedCollection()) {
>...
>
> } else {
>// THIS IS THE BRANCH THAT'S TRIGGERED IF @PersistenceCapable IS
> ACCIDENTALLY OMITTED.
> final ObjectData od = (ObjectData) data;
> if (od.containsField()) {
> throw new IsisException("Resolve state (for " + objectAdapter
> + ") inconsistent with fact that data exists for fields");
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ISIS-2058) Pre-render home page to avoid wait when first hit webapp after bootstrapping
[ https://issues.apache.org/jira/browse/ISIS-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-2058: -- Fix Version/s: (was: 1.18.0) 2.1.4 > Pre-render home page to avoid wait when first hit webapp after bootstrapping > > > Key: ISIS-2058 > URL: https://issues.apache.org/jira/browse/ISIS-2058 > Project: Isis > Issue Type: Improvement > Components: Core: Viewer: Wicket >Affects Versions: 1.16.2 >Reporter: Dan Haywood >Priority: Minor > Fix For: 2.1.4 > > > You can try by rendering the home page in a separate thread during the > bootstraping > You need to use ComponentRenderer#renderPage(app.getHomePage()) > you can do this for any of Isis' pages. You just need to provide their input > if they require such > > It is a static method and it creates an artificial RequestCycle for its needs > (so it doesn't need an HTTP thread) > [this is an cool idea for a small WicketStuff project that uses Wicket > IInitializer to render the home page in the background as soon as the app is > started] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-2063) Entering a string such as "10:45" for a joda LocalTime causes stack trace.
[ https://issues.apache.org/jira/browse/ISIS-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-2063: -- Fix Version/s: (was: 1.18.0) 2.0.3 > Entering a string such as "10:45" for a joda LocalTime causes stack trace. > -- > > Key: ISIS-2063 > URL: https://issues.apache.org/jira/browse/ISIS-2063 > Project: Isis > Issue Type: Bug > Components: Core: Viewer: Wicket >Affects Versions: 1.16.2 >Reporter: Dan Haywood >Priority: Major > Fix For: 2.0.3 > > > stack trace: > > * org.apache.wicket.WicketRuntimeException > * Method onRequest of interface org.apache.wicket.behavior.IBehaviorListener > targeted at > org.apache.isis.viewer.wicket.ui.components.scalars.ScalarPanelAbstract2$ScalarUpdatingBehavior@292c9c2f > on component [TextField [Component id = scalarValue]] threw an exception > * > org.apache.wicket.RequestListenerInterface#internalInvoke(RequestListenerInterface.java:268) > * > org.apache.wicket.RequestListenerInterface#invoke(RequestListenerInterface.java:241) > * > org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler#invokeListener(ListenerInterfaceRequestHandler.java:248) > * > org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler#respond(ListenerInterfaceRequestHandler.java:234) > * > org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor#respond(RequestCycle.java:895) > * > org.apache.wicket.request.RequestHandlerStack#execute(RequestHandlerStack.java:64) > * org.apache.wicket.request.cycle.RequestCycle#execute(RequestCycle.java:265) > * > org.apache.wicket.request.cycle.RequestCycle#processRequest(RequestCycle.java:222) > * > org.apache.wicket.request.cycle.RequestCycle#processRequestAndDetach(RequestCycle.java:293) > * > org.apache.wicket.protocol.http.WicketFilter#processRequestCycle(WicketFilter.java:261) > * > org.apache.wicket.protocol.http.WicketFilter#processRequest(WicketFilter.java:203) > * > org.apache.wicket.protocol.http.WicketFilter#doFilter(WicketFilter.java:284) > * > org.eclipse.jetty.servlet.ServletHandler$CachedChain#doFilter(ServletHandler.java:1621) > * > org.apache.isis.core.webapp.diagnostics.IsisLogOnExceptionFilter#doFilter(IsisLogOnExceptionFilter.java:52) > * > org.eclipse.jetty.servlet.ServletHandler$CachedChain#doFilter(ServletHandler.java:1621) > * > org.apache.shiro.web.servlet.AbstractShiroFilter#executeChain(AbstractShiroFilter.java:449) > * > org.apache.shiro.web.servlet.AbstractShiroFilter$1#call(AbstractShiroFilter.java:365) > * > org.apache.shiro.subject.support.SubjectCallable#doCall(SubjectCallable.java:90) > * > org.apache.shiro.subject.support.SubjectCallable#call(SubjectCallable.java:83) > * > org.apache.shiro.subject.support.DelegatingSubject#execute(DelegatingSubject.java:383) > * > org.apache.shiro.web.servlet.AbstractShiroFilter#doFilterInternal(AbstractShiroFilter.java:362) > * > org.apache.shiro.web.servlet.OncePerRequestFilter#doFilter(OncePerRequestFilter.java:125) > * > org.eclipse.jetty.servlet.ServletHandler$CachedChain#doFilter(ServletHandler.java:1613) > * org.eclipse.jetty.servlet.ServletHandler#doHandle(ServletHandler.java:541) > * > org.eclipse.jetty.server.handler.ScopedHandler#handle(ScopedHandler.java:143) > * org.eclipse.jetty.security.SecurityHandler#handle(SecurityHandler.java:548) > * > org.eclipse.jetty.server.handler.HandlerWrapper#handle(HandlerWrapper.java:132) > * > org.eclipse.jetty.server.handler.ScopedHandler#nextHandle(ScopedHandler.java:190) > * > org.eclipse.jetty.server.session.SessionHandler#doHandle(SessionHandler.java:1593) > * > org.eclipse.jetty.server.handler.ScopedHandler#nextHandle(ScopedHandler.java:188) > * > org.eclipse.jetty.server.handler.ContextHandler#doHandle(ContextHandler.java:1239) > * > org.eclipse.jetty.server.handler.ScopedHandler#nextScope(ScopedHandler.java:168) > * org.eclipse.jetty.servlet.ServletHandler#doScope(ServletHandler.java:481) > * > org.eclipse.jetty.server.session.SessionHandler#doScope(SessionHandler.java:1562) > * > org.eclipse.jetty.server.handler.ScopedHandler#nextScope(ScopedHandler.java:166) > * > org.eclipse.jetty.server.handler.ContextHandler#doScope(ContextHandler.java:1141) > * > org.eclipse.jetty.server.handler.ScopedHandler#handle(ScopedHandler.java:141) > * > org.eclipse.jetty.server.handler.HandlerWrapper#handle(HandlerWrapper.java:132) > * org.eclipse.jetty.server.Server#handle(Server.java:564) > * org.eclipse.jetty.server.HttpChannel#handle(HttpChannel.java:320) > * org.eclipse.jetty.server.HttpConnection#onFillable(HttpConnection.java:251) > * > org.eclipse.jetty.io.AbstractConnection$ReadCallback#succeeded(AbstractConnection.java:279) > *
[jira] [Closed] (ISIS-2071) [WON'T FIX] Backport suppression of "client connection abort" errors from v2
[
https://issues.apache.org/jira/browse/ISIS-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood closed ISIS-2071.
-
Resolution: Won't Fix
> [WON'T FIX] Backport suppression of "client connection abort" errors from v2
>
>
> Key: ISIS-2071
> URL: https://issues.apache.org/jira/browse/ISIS-2071
> Project: Isis
> Issue Type: Improvement
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> In ResourceCachingFilter.
>
> {code:java}
> ...
> // try to suppress java.io.IOException of kind 'client connection abort'
> // 1) the TCP protocol (by design) does not provide a means to check,
> whether a
> //connection has been closed by the client
> // 2) the exception thrown and the exception message text are specific to
> the
> //servlet-engine implementation, so we can only guess here
> try {
> chain.doFilter(servletRequest, servletResponse);
> } catch (IOException e) {
> FluentException.of(e)
> .suppressIf(this::isConnectionAbortException);
> }
> }
> // -- HELPER
> private boolean isConnectionAbortException(IOException e) {
> // tomcat 9
> if(e.getMessage().contains("An established connection was aborted by the
> software in your host machine")) {
> return true;
> }
> // payara 4
> if(e.getMessage().contains("Connection is closed")) {
> return true;
> }
> return false;
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ISIS-2060) Allow safe actions to be invoked if only have read-only access.
[ https://issues.apache.org/jira/browse/ISIS-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-2060: -- Fix Version/s: (was: 1.18.0) 2.0.3 > Allow safe actions to be invoked if only have read-only access. > --- > > Key: ISIS-2060 > URL: https://issues.apache.org/jira/browse/ISIS-2060 > Project: Isis > Issue Type: Improvement > Components: Core >Affects Versions: 1.16.2 >Reporter: Dan Haywood >Priority: Major > Fix For: 2.0.3 > > > Use a config property to enable this feature. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-2059) Allow Wicket viewer caching strategy (timestamp or digest) to be selected via config property.
[ https://issues.apache.org/jira/browse/ISIS-2059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-2059: -- Fix Version/s: (was: 1.18.0) 2.0.3 > Allow Wicket viewer caching strategy (timestamp or digest) to be selected via > config property. > -- > > Key: ISIS-2059 > URL: https://issues.apache.org/jira/browse/ISIS-2059 > Project: Isis > Issue Type: Improvement > Components: Core: Viewer: Wicket >Affects Versions: 1.16.2 >Reporter: Dan Haywood >Priority: Minor > Fix For: 2.0.3 > > > There is already some commented-out code in IsisWicketApplication. > // getResourceSettings().setCachingStrategy( > // new FilenameWithVersionResourceCachingStrategy( > // new CachingResourceVersion( > // new MessageDigestResourceVersion(; -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-2071) [WON'T FIX] Backport suppression of "client connection abort" errors from v2
[
https://issues.apache.org/jira/browse/ISIS-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-2071:
--
Summary: [WON'T FIX] Backport suppression of "client connection abort"
errors from v2 (was: Backport suppression of "client connection abort" errors
from v2)
> [WON'T FIX] Backport suppression of "client connection abort" errors from v2
>
>
> Key: ISIS-2071
> URL: https://issues.apache.org/jira/browse/ISIS-2071
> Project: Isis
> Issue Type: Improvement
>Reporter: Dan Haywood
>Priority: Minor
> Fix For: 1.18.0
>
>
> In ResourceCachingFilter.
>
> {code:java}
> ...
> // try to suppress java.io.IOException of kind 'client connection abort'
> // 1) the TCP protocol (by design) does not provide a means to check,
> whether a
> //connection has been closed by the client
> // 2) the exception thrown and the exception message text are specific to
> the
> //servlet-engine implementation, so we can only guess here
> try {
> chain.doFilter(servletRequest, servletResponse);
> } catch (IOException e) {
> FluentException.of(e)
> .suppressIf(this::isConnectionAbortException);
> }
> }
> // -- HELPER
> private boolean isConnectionAbortException(IOException e) {
> // tomcat 9
> if(e.getMessage().contains("An established connection was aborted by the
> software in your host machine")) {
> return true;
> }
> // payara 4
> if(e.getMessage().contains("Connection is closed")) {
> return true;
> }
> return false;
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (ISIS-1993) allow factory actions to be associated with both properties and parameters.
[
https://issues.apache.org/jira/browse/ISIS-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood reassigned ISIS-1993:
-
Assignee: (was: Dan Haywood)
> allow factory actions to be associated with both properties and parameters.
> ---
>
> Key: ISIS-1993
> URL: https://issues.apache.org/jira/browse/ISIS-1993
> Project: Isis
> Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 1.18.0
>
>
> See also ISIS-1509
>
> {code:java}
> @Property(createRepository=Supplier.Repository.class, createAction="create")
> @Getter @Setter Party supplier;{code}
> and
> {code:java}
> public IncomingInvoice edit(
> @Parameter(createRepository=Supplier.Repository.class,
> createAction="create")
> Party supplier,
> ...
> ) {
>...
> }{code}
>
> to invoke a nominated action "in-situ".
> This could be bound to a keystroke, eg "F3"
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ISIS-1993) allow factory actions to be associated with both properties and parameters.
[
https://issues.apache.org/jira/browse/ISIS-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-1993:
--
Fix Version/s: (was: 1.18.0)
2.0.3
> allow factory actions to be associated with both properties and parameters.
> ---
>
> Key: ISIS-1993
> URL: https://issues.apache.org/jira/browse/ISIS-1993
> Project: Isis
> Issue Type: New Feature
>Affects Versions: 1.16.2
>Reporter: Dan Haywood
>Priority: Major
> Fix For: 2.0.3
>
>
> See also ISIS-1509
>
> {code:java}
> @Property(createRepository=Supplier.Repository.class, createAction="create")
> @Getter @Setter Party supplier;{code}
> and
> {code:java}
> public IncomingInvoice edit(
> @Parameter(createRepository=Supplier.Repository.class,
> createAction="create")
> Party supplier,
> ...
> ) {
>...
> }{code}
>
> to invoke a nominated action "in-situ".
> This could be bound to a keystroke, eg "F3"
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ISIS-1995) Render collection of objects as panels
[ https://issues.apache.org/jira/browse/ISIS-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1995: -- Fix Version/s: (was: 1.18.0) 2.0.3 > Render collection of objects as panels > -- > > Key: ISIS-1995 > URL: https://issues.apache.org/jira/browse/ISIS-1995 > Project: Isis > Issue Type: New Feature >Affects Versions: 1.16.2 >Reporter: Dan Haywood >Priority: Major > Fix For: 2.0.3 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1994) Render collection of objects as tabs
[ https://issues.apache.org/jira/browse/ISIS-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1994: -- Fix Version/s: (was: 1.18.0) 2.0.3 > Render collection of objects as tabs > > > Key: ISIS-1994 > URL: https://issues.apache.org/jira/browse/ISIS-1994 > Project: Isis > Issue Type: New Feature >Reporter: Dan Haywood >Priority: Major > Fix For: 2.0.3 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1509) Extending Action Dialogs: new kind of Support Action to contribute to Action Parameters
[
https://issues.apache.org/jira/browse/ISIS-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-1509:
--
Fix Version/s: (was: 1.18.0)
2.0.3
> Extending Action Dialogs: new kind of Support Action to contribute to Action
> Parameters
> ---
>
> Key: ISIS-1509
> URL: https://issues.apache.org/jira/browse/ISIS-1509
> Project: Isis
> Issue Type: New Feature
> Components: Core
>Affects Versions: 1.13.0
>Reporter: Oscar Bou
>Priority: Major
> Fix For: 2.0.3
>
> Attachments: Slide1.PNG, Slide2.PNG, Slide3.PNG, factory-methods.pptx
>
>
> See also ISIS-1993
> ~~~
> Factory Methods should be able to be identified as that.
> It could be useful, for example, when executing any action.
> For any param of any type, Apache Isis could offer the option to create a new
> instance by executing an action that both return that type and has been
> identified as a Factory Method.
> An example of defining a Factory Method could be:
> {code:java}
> class Concert {
> @Action(factoryMethod=true)
> public Concert someAction() {
> return new Concert();
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ISIS-1998) Simplify syntax way for mixins, to better express intent using @Action, @Collection and @Property
[ https://issues.apache.org/jira/browse/ISIS-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1998: -- Fix Version/s: (was: 1.18.0) 2.0.3 > Simplify syntax way for mixins, to better express intent using @Action, > @Collection and @Property > - > > Key: ISIS-1998 > URL: https://issues.apache.org/jira/browse/ISIS-1998 > Project: Isis > Issue Type: New Feature >Affects Versions: 1.16.2 >Reporter: Dan Haywood >Priority: Major > Fix For: 2.0.3 > > > that is: > * for actions with @Action annotation at class level (replacing @Mixin), new > mixinMethod="act". Also allow @ActionLayout at top-level > * for collections, ditto @Collection, new mixinMethod="coll"; > @CollectionLayout > * for properties, ditto @Property, mixinMethod="prop" and @PropertyLayout -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1023) Allow actions to be invoked on entity when rendered within a table.
[ https://issues.apache.org/jira/browse/ISIS-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1023: -- Fix Version/s: (was: 1.18.0) 2.0.3 > Allow actions to be invoked on entity when rendered within a table. > --- > > Key: ISIS-1023 > URL: https://issues.apache.org/jira/browse/ISIS-1023 > Project: Isis > Issue Type: New Feature > Components: Core, Core: Viewer: Wicket >Affects Versions: viewer-wicket-1.7.0, core-1.7.0 >Reporter: Dan Haywood >Priority: Minor > Fix For: 2.0.3 > > > Enhance the Wicket viewer (with corresponding metadata annotations) to render > an entity's actions as drop-down menu when that entity is rendered as a row > of a table. > There's probably no need to introduce additional annotations; the > @ActionLayout(hidden=...) indicates whether an action is hidden in various > contexts, one of these being it being hidden (or not) within tables. > My idea therefore is that, unless every action of an entity is indicated as > hidden for a table, that there is an additional column that includes a > drop-down and that allows the actions to be invoked (bringing up the dialog). > Once the action is invoked (like bulk actions) the table should be reloaded > (rather than, say, navigate to the object returned by the action). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1350) Refactor/simplify ExceptionRecognitionService to follow chain-of-responsibility pattern.
[ https://issues.apache.org/jira/browse/ISIS-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-1350: -- Fix Version/s: (was: 1.18.0) 2.0.3 > Refactor/simplify ExceptionRecognitionService to follow > chain-of-responsibility pattern. > > > Key: ISIS-1350 > URL: https://issues.apache.org/jira/browse/ISIS-1350 > Project: Isis > Issue Type: Improvement > Components: Core >Affects Versions: 1.11.1 >Reporter: Dan Haywood >Priority: Minor > Fix For: 2.0.3 > > > To exploit the fact that we can inject List -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ISIS-1021) suppress/disable the link in the first column of a table (CollectionProperty)
[
https://issues.apache.org/jira/browse/ISIS-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Haywood updated ISIS-1021:
--
Fix Version/s: (was: 1.18.0)
2.0.3
> suppress/disable the link in the first column of a table (CollectionProperty)
> -
>
> Key: ISIS-1021
> URL: https://issues.apache.org/jira/browse/ISIS-1021
> Project: Isis
> Issue Type: New Feature
> Components: Core: Viewer: Wicket
>Affects Versions: viewer-wicket-1.7.0
>Reporter: ARI
>Priority: Major
> Fix For: 2.0.3
>
>
> Goal:
> Suppress/disable the link in the first column of a table (CollectionProperty)
> for marked DomainObjects.
> Proposal:
> - Add a new field to the @DomainObjectLayout like openable/viewable.
> - Special handling of title columns in CollectionContentsAsAjaxTablePanel /
> ObjectAdapterTitleColumn / EntityIconAndTitlePanel
> Background:
> I have a complex entity which is displayed in tables in different places.
> In one place I want to show a subset of properties only. For this
> projection I made a special in-memory object, which wraps the complex
> entity and has getters for the subset of properties only. How can I mark
> this inmemory object to be not openable, or with other words how do i
> suppress/disable the link in the first column.
> Dan/Martins "QuickFix" was:
> The column is added at
> https://github.com/apache/isis/blob/master/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/collectioncontents/ajaxtable/CollectionContentsAsAjaxTablePanel.java#L96
> and I see no way how to suppress the addition in current master branch.
> The column is marked with "title-column" CSS class so it is easy to hide
> with: visibility:hidden;, but I'm not sure how easy is to detect on which
> page to apply this CSS rule.
> If you use 1.8.0-SNAPSHOT then maybe you can combine it with the new
> #cssClass() special method that may be used to set a custom CSS class. See
> http://issues.apache.org/jira/browse/ISIS-1000
> Am 26.01.2015 um 23:11 schrieb Dan Haywood :
> +1 to Martin's answer, there is no configuration setting but it is possible
> to hack it using Javascript and CSS and the new #cssClass in 1.8.0-SNAPSHOT.
> For example, the todo app uses #cssClass() so that completed todo items are
> shown in a table with a strikethrough. This comes from the "done" CSS
> class:
> public String cssClass() { return !isComplete() ? "todo" : "done"; }
> In webapp/css/application.css, if we add:
> tr.done a {
> pointer-events: none;
> cursor: default;
> }
> and in webapp/scripts/application.js, if we add:
> $(document).ready(function() {
> $('tr.done a').click(function() { return false; });
> });
> then the icon for each completed item cannot be clicked.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ISIS-2086) Define beans for configuration, so that (eventually) can use Spring Boot's @ConfigurationProperties infrastructure.
[ https://issues.apache.org/jira/browse/ISIS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Haywood updated ISIS-2086: -- Fix Version/s: (was: 1.21.0) 2.0.0 Description: ie as per [https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#boot-features-external-config] Another benefit we will get from this is that SB has an annotation processor that generates some IDE config files to provide autocomplete when editing the application.properties file [https://docs.spring.io/spring-boot/docs/2.0.8.RELEASE/reference/html/configuration-metadata.html#configuration-metadata-annotation-processor] was: ie as per [https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#boot-features-external-config] However, it doesn't seem that Spring Boot itself exposes a standalone library that will consume its application.properties etc into config classes. So we might need to write some equivalent code (also for support on MicroProfile). ~~~ Another benefit we will get from this is that SB has an annotation processor that generates some IDE config files to provide autocomplete when editing the application.properties file [https://docs.spring.io/spring-boot/docs/2.0.8.RELEASE/reference/html/configuration-metadata.html#configuration-metadata-annotation-processor] This perhaps isn't mandatory for 2.0.0, but would improve the developer experience significantly, as well as our codebase. > Define beans for configuration, so that (eventually) can use Spring Boot's > @ConfigurationProperties infrastructure. > --- > > Key: ISIS-2086 > URL: https://issues.apache.org/jira/browse/ISIS-2086 > Project: Isis > Issue Type: Improvement >Affects Versions: 1.17.0 >Reporter: Dan Haywood >Priority: Major > Fix For: 2.0.0 > > > ie as per > [https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#boot-features-external-config] > Another benefit we will get from this is that SB has an annotation processor > that generates some IDE config files to provide autocomplete when editing the > application.properties file > [https://docs.spring.io/spring-boot/docs/2.0.8.RELEASE/reference/html/configuration-metadata.html#configuration-metadata-annotation-processor] > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2112) Use Spring Boot for 'Service Provisioning'
[ https://issues.apache.org/jira/browse/ISIS-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842241#comment-16842241 ] ASF subversion and git services commented on ISIS-2112: --- Commit ce3e58a0b0205113af3dba2cb64dc627d88512a6 in isis's branch refs/heads/2112_SpringBoot from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=ce3e58a ] ISIS-2112: let built-in @DomainService classes be managed by Spring - also cleaning up ugly code in BackgroundServiceDefault Task-Url: https://issues.apache.org/jira/browse/ISIS-2112 > Use Spring Boot for 'Service Provisioning' > -- > > Key: ISIS-2112 > URL: https://issues.apache.org/jira/browse/ISIS-2112 > Project: Isis > Issue Type: Improvement > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2112) Use Spring Boot for 'Service Provisioning'
[ https://issues.apache.org/jira/browse/ISIS-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842240#comment-16842240 ] ASF subversion and git services commented on ISIS-2112: --- Commit ce3e58a0b0205113af3dba2cb64dc627d88512a6 in isis's branch refs/heads/2112_SpringBoot from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=ce3e58a ] ISIS-2112: let built-in @DomainService classes be managed by Spring - also cleaning up ugly code in BackgroundServiceDefault Task-Url: https://issues.apache.org/jira/browse/ISIS-2112 > Use Spring Boot for 'Service Provisioning' > -- > > Key: ISIS-2112 > URL: https://issues.apache.org/jira/browse/ISIS-2112 > Project: Isis > Issue Type: Improvement > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2112) Use Spring Boot for 'Service Provisioning'
[ https://issues.apache.org/jira/browse/ISIS-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842128#comment-16842128 ] ASF subversion and git services commented on ISIS-2112: --- Commit e78b0eeffd0480f6bbd94bbad0c5e0b5301ad286 in isis's branch refs/heads/2112_SpringBoot from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=e78b0ee ] ISIS-2112: makes Isis' SecurityManagers managed by Spring - properly configures 'helloworld' to authenticate with Shiro Task-Url: https://issues.apache.org/jira/browse/ISIS-2112 > Use Spring Boot for 'Service Provisioning' > -- > > Key: ISIS-2112 > URL: https://issues.apache.org/jira/browse/ISIS-2112 > Project: Isis > Issue Type: Improvement > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2112) Use Spring Boot for 'Service Provisioning'
[ https://issues.apache.org/jira/browse/ISIS-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842127#comment-16842127 ] ASF subversion and git services commented on ISIS-2112: --- Commit e78b0eeffd0480f6bbd94bbad0c5e0b5301ad286 in isis's branch refs/heads/2112_SpringBoot from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=e78b0ee ] ISIS-2112: makes Isis' SecurityManagers managed by Spring - properly configures 'helloworld' to authenticate with Shiro Task-Url: https://issues.apache.org/jira/browse/ISIS-2112 > Use Spring Boot for 'Service Provisioning' > -- > > Key: ISIS-2112 > URL: https://issues.apache.org/jira/browse/ISIS-2112 > Project: Isis > Issue Type: Improvement > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2112) Use Spring Boot for 'Service Provisioning'
[ https://issues.apache.org/jira/browse/ISIS-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842096#comment-16842096 ] ASF subversion and git services commented on ISIS-2112: --- Commit 291f18612820964e2c1d37b7259fcf09de207240 in isis's branch refs/heads/2112_SpringBoot from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=291f186 ] ISIS-2112: properly implements 'isis-maven-plugin' to use Spring - adds home-brew package scanning prior to Spring Context initialization - however, whether the MoJos do what they are supposed to, needs to be tested still Task-Url: https://issues.apache.org/jira/browse/ISIS-2112 > Use Spring Boot for 'Service Provisioning' > -- > > Key: ISIS-2112 > URL: https://issues.apache.org/jira/browse/ISIS-2112 > Project: Isis > Issue Type: Improvement > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2112) Use Spring Boot for 'Service Provisioning'
[ https://issues.apache.org/jira/browse/ISIS-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842095#comment-16842095 ] ASF subversion and git services commented on ISIS-2112: --- Commit 291f18612820964e2c1d37b7259fcf09de207240 in isis's branch refs/heads/2112_SpringBoot from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=291f186 ] ISIS-2112: properly implements 'isis-maven-plugin' to use Spring - adds home-brew package scanning prior to Spring Context initialization - however, whether the MoJos do what they are supposed to, needs to be tested still Task-Url: https://issues.apache.org/jira/browse/ISIS-2112 > Use Spring Boot for 'Service Provisioning' > -- > > Key: ISIS-2112 > URL: https://issues.apache.org/jira/browse/ISIS-2112 > Project: Isis > Issue Type: Improvement > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2112) Use Spring Boot for 'Service Provisioning'
[ https://issues.apache.org/jira/browse/ISIS-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842030#comment-16842030 ] ASF subversion and git services commented on ISIS-2112: --- Commit 0ece2c5efc172ba34993e4fecadf86be92c42f9d in isis's branch refs/heads/2112_SpringBoot from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=0ece2c5 ] ISIS-2112: migrate 'isis-maven-plugin' to launch a Spring Context - just a stub yet, but a FIXME[2112] marker is in place - also making auth/bypass a convenient config bean -> IsisSecurityBoot - 'simpleapp' successfully builds now Task-Url: https://issues.apache.org/jira/browse/ISIS-2112 > Use Spring Boot for 'Service Provisioning' > -- > > Key: ISIS-2112 > URL: https://issues.apache.org/jira/browse/ISIS-2112 > Project: Isis > Issue Type: Improvement > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2112) Use Spring Boot for 'Service Provisioning'
[ https://issues.apache.org/jira/browse/ISIS-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842029#comment-16842029 ] ASF subversion and git services commented on ISIS-2112: --- Commit 0ece2c5efc172ba34993e4fecadf86be92c42f9d in isis's branch refs/heads/2112_SpringBoot from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=0ece2c5 ] ISIS-2112: migrate 'isis-maven-plugin' to launch a Spring Context - just a stub yet, but a FIXME[2112] marker is in place - also making auth/bypass a convenient config bean -> IsisSecurityBoot - 'simpleapp' successfully builds now Task-Url: https://issues.apache.org/jira/browse/ISIS-2112 > Use Spring Boot for 'Service Provisioning' > -- > > Key: ISIS-2112 > URL: https://issues.apache.org/jira/browse/ISIS-2112 > Project: Isis > Issue Type: Improvement > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2112) Use Spring Boot for 'Service Provisioning'
[ https://issues.apache.org/jira/browse/ISIS-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841947#comment-16841947 ] ASF subversion and git services commented on ISIS-2112: --- Commit a83e5915382a86758f27587c47f25df79192880a in isis's branch refs/heads/2112_SpringBoot from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=a83e591 ] ISIS-2112: fixes some (not all) 'simpleapp' build issues - DataNucleus' annotation-processor seems to stumble over lombok's @NonNull, so we removed this annotation from 'SimpleObject' - Profiles 'isis-validate' and 'swagger' still fail Task-Url: https://issues.apache.org/jira/browse/ISIS-2112 > Use Spring Boot for 'Service Provisioning' > -- > > Key: ISIS-2112 > URL: https://issues.apache.org/jira/browse/ISIS-2112 > Project: Isis > Issue Type: Improvement > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ISIS-2112) Use Spring Boot for 'Service Provisioning'
[ https://issues.apache.org/jira/browse/ISIS-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841948#comment-16841948 ] ASF subversion and git services commented on ISIS-2112: --- Commit a83e5915382a86758f27587c47f25df79192880a in isis's branch refs/heads/2112_SpringBoot from Andi Huber [ https://gitbox.apache.org/repos/asf?p=isis.git;h=a83e591 ] ISIS-2112: fixes some (not all) 'simpleapp' build issues - DataNucleus' annotation-processor seems to stumble over lombok's @NonNull, so we removed this annotation from 'SimpleObject' - Profiles 'isis-validate' and 'swagger' still fail Task-Url: https://issues.apache.org/jira/browse/ISIS-2112 > Use Spring Boot for 'Service Provisioning' > -- > > Key: ISIS-2112 > URL: https://issues.apache.org/jira/browse/ISIS-2112 > Project: Isis > Issue Type: Improvement > Components: Core >Reporter: Andi Huber >Assignee: Andi Huber >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
