[jira] [Commented] (JCRVLT-509) Make DocView import failures fail the whole installation
[
https://issues.apache.org/jira/browse/JCRVLT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298566#comment-17298566
]
Konrad Windszus commented on JCRVLT-509:
This is IMHO a bad design choice. Often packages are used to install code where
best effort is not enough. Also for content transfers best effort calls for
trouble as with big packages it is impossible to always check the log for
logged errors.
WDYT about changing the default of isStrict to true?
> Make DocView import failures fail the whole installation
>
>
> Key: JCRVLT-509
> URL: https://issues.apache.org/jira/browse/JCRVLT-509
> Project: Jackrabbit FileVault
> Issue Type: Improvement
>Affects Versions: 3.4.10
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.12
>
>
> Currently all ACL, authorizable and regular node exceptions are caught in
> https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L683
> and just logged. Afterwards the import of the package just continues. Only
> in case the ImportOptions.setStrict() is set to {{true}} it will lead to a
> PackageException in the end.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JCRVLT-509) Make DocView import failures fail the whole installation
[
https://issues.apache.org/jira/browse/JCRVLT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298462#comment-17298462
]
Tobias Bocanegra commented on JCRVLT-509:
-
we always tried to import a package best effort.
> Make DocView import failures fail the whole installation
>
>
> Key: JCRVLT-509
> URL: https://issues.apache.org/jira/browse/JCRVLT-509
> Project: Jackrabbit FileVault
> Issue Type: Improvement
>Affects Versions: 3.4.10
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.12
>
>
> Currently all ACL, authorizable and regular node exceptions are caught in
> https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L683
> and just logged. Afterwards the import of the package just continues. Only
> in case the ImportOptions.setStrict() is set to {{true}} it will lead to a
> PackageException in the end.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (JCRVLT-509) Make DocView import failures fail the whole installation
[
https://issues.apache.org/jira/browse/JCRVLT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298106#comment-17298106
]
Konrad Windszus edited comment on JCRVLT-509 at 3/9/21, 4:26 PM:
-
[~tripod] Do you remember why that lenient handling has been introduced as
default?
was (Author: kwin):
[~tripod] Do you remember why you treat those installation exceptions
differently from e.g. regular node installation exceptions?
> Make DocView import failures fail the whole installation
>
>
> Key: JCRVLT-509
> URL: https://issues.apache.org/jira/browse/JCRVLT-509
> Project: Jackrabbit FileVault
> Issue Type: Improvement
>Affects Versions: 3.4.10
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.12
>
>
> Currently all ACL, authorizable and regular node exceptions are caught in
> https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L683
> and just logged. Afterwards the import of the package just continues. Only
> in case the ImportOptions.setStrict() is set to {{true}} it will lead to a
> PackageException in the end.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (JCRVLT-509) Make DocView import failures fail the whole installation
[
https://issues.apache.org/jira/browse/JCRVLT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated JCRVLT-509:
---
Description: Currently all ACL, authorizable and regular node exceptions
are caught in
https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L683
and just logged. Afterwards the import of the package just continues. Only in
case the ImportOptions.setStrict() is set to {{true}} it will lead to a
PackageException in the end. (was: Currently all ACL and authorizable
exceptions are caught in
https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L683
and just logged. Afterwards the import of the package just continues.
As I consider a failure to install ACLs/authorizable fatal (i.e.
non-recoverable) it should lead to a PackageException.)
> Make DocView import failures fail the whole installation
>
>
> Key: JCRVLT-509
> URL: https://issues.apache.org/jira/browse/JCRVLT-509
> Project: Jackrabbit FileVault
> Issue Type: Improvement
>Affects Versions: 3.4.10
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.4.12
>
>
> Currently all ACL, authorizable and regular node exceptions are caught in
> https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L683
> and just logged. Afterwards the import of the package just continues. Only
> in case the ImportOptions.setStrict() is set to {{true}} it will lead to a
> PackageException in the end.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (JCRVLT-509) Make DocView import failures fail the whole installation
[ https://issues.apache.org/jira/browse/JCRVLT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated JCRVLT-509: --- Summary: Make DocView import failures fail the whole installation (was: Make authorizable and access control installation failures fail the whole installation) > Make DocView import failures fail the whole installation > > > Key: JCRVLT-509 > URL: https://issues.apache.org/jira/browse/JCRVLT-509 > Project: Jackrabbit FileVault > Issue Type: Improvement >Affects Versions: 3.4.10 >Reporter: Konrad Windszus >Priority: Major > Fix For: 3.4.12 > > > Currently all ACL and authorizable exceptions are caught in > https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L683 > and just logged. Afterwards the import of the package just continues. > As I consider a failure to install ACLs/authorizable fatal (i.e. > non-recoverable) it should lead to a PackageException. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JCRVLT-510) Clarify meaning of ImportOptions.isStrict()
[ https://issues.apache.org/jira/browse/JCRVLT-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated JCRVLT-510: --- Description: Currently there is no clear description what the strict flag (https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/ImportOptions.java#L130) means. The following places currently evaluate it: # Defer throwing non-fatal exception during import (https://github.com/apache/jackrabbit-filevault/blob/f785fcb24d4cbd01c734e9273310a925c29ae15b/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/ZipVaultPackage.java#L269), those non-fatal errors are ## Exception during recoverChildren: https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/ChildNodeStash.java#L161 ## Exception during import of DocView XML files: https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L690 ## SAXException in the GenericArtifactHandler: https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/GenericArtifactHandler.java#L106 ## When parent nodes are not found during import: https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L894 # When cyclic dependencies are detected: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L486 # During uninstallation of packages: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L990 # During installation of node types: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L531 # During installation of privileges: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L549 was: Currently there is no clear description what the strict flag (https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/ImportOptions.java#L130) means. The following places currently evaluate it: # Defer throwing non-fatal exception during import (https://github.com/apache/jackrabbit-filevault/blob/f785fcb24d4cbd01c734e9273310a925c29ae15b/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/ZipVaultPackage.java#L269), i.e. used with ACL/Authorizable import issues (compare with JCRVLT-509) # When cyclic dependencies are detected: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L486 # During uninstallation of packages: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L990 # During installation of node types: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L531 # During installation of privileges: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L549 > Clarify meaning of ImportOptions.isStrict() > --- > > Key: JCRVLT-510 > URL: https://issues.apache.org/jira/browse/JCRVLT-510 > Project: Jackrabbit FileVault > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > > Currently there is no clear description what the strict flag > (https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/ImportOptions.java#L130) > means. > The following places currently evaluate it: > # Defer throwing non-fatal exception during import > (https://github.com/apache/jackrabbit-filevault/blob/f785fcb24d4cbd01c734e9273310a925c29ae15b/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/ZipVaultPackage.java#L269), > those non-fatal errors are > ## Exception d
[jira] [Commented] (JCRVLT-510) Clarify meaning of ImportOptions.isStrict()
[
https://issues.apache.org/jira/browse/JCRVLT-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298126#comment-17298126
]
Konrad Windszus commented on JCRVLT-510:
IMHO {{strict}} should be deprecated and no longer be evaluated. Especially as
with {{PackageRegistry}} the {{ImportOptions}} can no longer be influenced and
the default value is {{false}}.
All exceptions should bubble up to the caller. A best effort installation is in
most cases not desired as it may lead to subtle errors which easily might not
get noticed.
> Clarify meaning of ImportOptions.isStrict()
> ---
>
> Key: JCRVLT-510
> URL: https://issues.apache.org/jira/browse/JCRVLT-510
> Project: Jackrabbit FileVault
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently there is no clear description what the strict flag
> (https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/ImportOptions.java#L130)
> means.
> The following places currently evaluate it:
> # Defer throwing non-fatal exception during import
> (https://github.com/apache/jackrabbit-filevault/blob/f785fcb24d4cbd01c734e9273310a925c29ae15b/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/ZipVaultPackage.java#L269),
> i.e. used with ACL/Authorizable import issues (compare with JCRVLT-509)
> # When cyclic dependencies are detected:
> https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L486
> # During uninstallation of packages:
> https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L990
> # During installation of node types:
> https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L531
> # During installation of privileges:
> https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L549
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (JCRVLT-510) Clarify meaning of ImportOptions.isStrict()
[ https://issues.apache.org/jira/browse/JCRVLT-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated JCRVLT-510: --- Description: Currently there is no clear description what the strict flag (https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/ImportOptions.java#L130) means. The following places currently evaluate it: # Defer throwing non-fatal exception during import (https://github.com/apache/jackrabbit-filevault/blob/f785fcb24d4cbd01c734e9273310a925c29ae15b/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/ZipVaultPackage.java#L269), i.e. used with ACL/Authorizable import issues (compare with JCRVLT-509) # When cyclic dependencies are detected: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L486 # During uninstallation of packages: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L990 # During installation of node types: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L531 # During installation of privileges: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L549 was: Currently there is no clear description what the strict flag (https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/ImportOptions.java#L130) means. The following places currently evaluate it: # Defer throwing non-fatal exception during import (https://github.com/apache/jackrabbit-filevault/blob/f785fcb24d4cbd01c734e9273310a925c29ae15b/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/ZipVaultPackage.java#L269), i.e. used with ACLs # When cyclic dependencies are detected: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L486 # During uninstallation of packages: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L990 # During installation of node types: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L531 # During installation of privileges: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L549 > Clarify meaning of ImportOptions.isStrict() > --- > > Key: JCRVLT-510 > URL: https://issues.apache.org/jira/browse/JCRVLT-510 > Project: Jackrabbit FileVault > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > > Currently there is no clear description what the strict flag > (https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/ImportOptions.java#L130) > means. > The following places currently evaluate it: > # Defer throwing non-fatal exception during import > (https://github.com/apache/jackrabbit-filevault/blob/f785fcb24d4cbd01c734e9273310a925c29ae15b/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/ZipVaultPackage.java#L269), > i.e. used with ACL/Authorizable import issues (compare with JCRVLT-509) > # When cyclic dependencies are detected: > https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L486 > # During uninstallation of packages: > https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L990 > # During installation of node types: > https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L531 > # During installation of privileges: > https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L549 -- This
[jira] [Created] (JCRVLT-510) Clarify meaning of ImportOptions.isStrict()
Konrad Windszus created JCRVLT-510: -- Summary: Clarify meaning of ImportOptions.isStrict() Key: JCRVLT-510 URL: https://issues.apache.org/jira/browse/JCRVLT-510 Project: Jackrabbit FileVault Issue Type: Improvement Reporter: Konrad Windszus Currently there is no clear description what the strict flag (https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/ImportOptions.java#L130) means. The following places currently evaluate it: # Defer throwing non-fatal exception during import (https://github.com/apache/jackrabbit-filevault/blob/f785fcb24d4cbd01c734e9273310a925c29ae15b/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/ZipVaultPackage.java#L269), i.e. used with ACLs # When cyclic dependencies are detected: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L486 # During uninstallation of packages: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L990 # During installation of node types: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L531 # During installation of privileges: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L549 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JCRVLT-509) Make authorizable and access control installation failures fail the whole installation
[ https://issues.apache.org/jira/browse/JCRVLT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated JCRVLT-509: --- Summary: Make authorizable and access control installation failures fail the whole installation (was: Make authorizable and access control installation failure make the whole installation fail) > Make authorizable and access control installation failures fail the whole > installation > -- > > Key: JCRVLT-509 > URL: https://issues.apache.org/jira/browse/JCRVLT-509 > Project: Jackrabbit FileVault > Issue Type: Improvement >Affects Versions: 3.4.10 >Reporter: Konrad Windszus >Priority: Major > Fix For: 3.4.12 > > > Currently all ACL and authorizable exceptions are caught in > https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L683 > and just logged. Afterwards the import of the package just continues. > As I consider a failure to install ACLs/authorizable fatal (i.e. > non-recoverable) it should lead to a PackageException. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (JCRVLT-509) Make authorizable and access control installation failure make the whole installation fail
[ https://issues.apache.org/jira/browse/JCRVLT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298106#comment-17298106 ] Konrad Windszus commented on JCRVLT-509: [~tripod] Do you remember why you treat those installation exceptions differently from e.g. regular node installation exceptions? > Make authorizable and access control installation failure make the whole > installation fail > -- > > Key: JCRVLT-509 > URL: https://issues.apache.org/jira/browse/JCRVLT-509 > Project: Jackrabbit FileVault > Issue Type: Improvement >Affects Versions: 3.4.10 >Reporter: Konrad Windszus >Priority: Major > Fix For: 3.4.12 > > > Currently all ACL and authorizable exceptions are caught in > https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L683 > and just logged. Afterwards the import of the package just continues. > As I consider a failure to install ACLs/authorizable fatal (i.e. > non-recoverable) it should lead to a PackageException. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (JCRVLT-509) Make authorizable and access control installation failure make the whole installation fail
Konrad Windszus created JCRVLT-509: -- Summary: Make authorizable and access control installation failure make the whole installation fail Key: JCRVLT-509 URL: https://issues.apache.org/jira/browse/JCRVLT-509 Project: Jackrabbit FileVault Issue Type: Improvement Affects Versions: 3.4.10 Reporter: Konrad Windszus Fix For: 3.4.12 Currently all ACL and authorizable exceptions are caught in https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L683 and just logged. Afterwards the import of the package just continues. As I consider a failure to install ACLs/authorizable fatal (i.e. non-recoverable) it should lead to a PackageException. -- This message was sent by Atlassian Jira (v8.3.4#803005)
March 2021 report: draft for review
Hi, The draft for the March 2021 board report is available here: https://jackrabbit.apache.org/jcr/status/board-report-2021-03.html Please review and let me know if something is missing or incorrect. I will submit the report tomorrow. Apologies for the short notice, but that's the due date :-/ Regards Marcel
[jira] [Resolved] (JCRVLT-221) document package types
[ https://issues.apache.org/jira/browse/JCRVLT-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved JCRVLT-221. Resolution: Duplicate > document package types > -- > > Key: JCRVLT-221 > URL: https://issues.apache.org/jira/browse/JCRVLT-221 > Project: Jackrabbit FileVault > Issue Type: Improvement > Components: Packaging >Affects Versions: 3.1.40 >Reporter: Tobias Bocanegra >Priority: Major > > add documentation for package types introduced in JCRVLT-170 -- This message was sent by Atlassian Jira (v8.3.4#803005)
