[ 
https://issues.apache.org/jira/browse/JCRVLT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298566#comment-17298566
 ] 

Konrad Windszus commented on JCRVLT-509:
----------------------------------------

This is IMHO a bad design choice. Often packages are used to install code where 
best effort is not enough. Also for content transfers best effort calls for 
trouble as with big packages it is impossible to always check the log for 
logged errors.

WDYT about changing the default of isStrict to true?

> Make DocView import failures fail the whole installation
> --------------------------------------------------------
>
>                 Key: JCRVLT-509
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-509
>             Project: Jackrabbit FileVault
>          Issue Type: Improvement
>    Affects Versions: 3.4.10
>            Reporter: Konrad Windszus
>            Priority: Major
>             Fix For: 3.4.12
>
>
> Currently all ACL, authorizable and regular node exceptions are caught in 
> https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L683
>  and just logged. Afterwards the import of the package just continues. Only 
> in case the ImportOptions.setStrict() is set to {{true}} it will lead to a 
> PackageException in the end.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to