[jira] [Commented] (JENA-1650) Retire Apache Jena CSV module.
[ https://issues.apache.org/jira/browse/JENA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722201#comment-16722201 ] ASF GitHub Bot commented on JENA-1650: -- GitHub user afs opened a pull request: https://github.com/apache/jena/pull/511 JENA-1650: Retire jena-csv Code removal, leaving only a `jena-csv/README.md`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/afs/jena retire-jena-csv Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/511.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #511 commit 0df04b459cade0786106c9ebe9d278875b8a6063 Author: Andy Seaborne Date: 2018-12-15T15:38:08Z JENA-1650: Retire jena-csv > Retire Apache Jena CSV module. > -- > > Key: JENA-1650 > URL: https://issues.apache.org/jira/browse/JENA-1650 > Project: Apache Jena > Issue Type: Task >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Critical > Fix For: Jena 3.10.0 > > > Retire jena-csv. > This an action from the dev@ discussion: > https://lists.apache.org/thread.html/b89873afba86864994d0515a4c49889c6356d1c91071964eaa1014d1@%3Cdev.jena.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1649) Retire Apache Jena Fuseki1 module.
[ https://issues.apache.org/jira/browse/JENA-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722200#comment-16722200 ] ASF GitHub Bot commented on JENA-1649: -- GitHub user afs opened a pull request: https://github.com/apache/jena/pull/510 JENA-1649: Retire jena-fuseki1 Code removal, leaving only a `jena-fuseki1/README.md`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/afs/jena retire-jena-fuseki1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/510.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #510 commit c8794d4e7e410b50aab3889a61300b72bc09e84b Author: Andy Seaborne Date: 2018-12-15T15:31:07Z JENA-1649: Retire jena-fuseki1 > Retire Apache Jena Fuseki1 module. > -- > > Key: JENA-1649 > URL: https://issues.apache.org/jira/browse/JENA-1649 > Project: Apache Jena > Issue Type: Task >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Critical > Fix For: Jena 3.10.0 > > > Retire Fuseki1. > This an action from the dev@ discussion: > https://lists.apache.org/thread.html/b89873afba86864994d0515a4c49889c6356d1c91071964eaa1014d1@%3Cdev.jena.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1649) Retire Apache Jena Fuseki1 module.
[ https://issues.apache.org/jira/browse/JENA-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722191#comment-16722191 ] ASF GitHub Bot commented on JENA-1649: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/508 > Retire Apache Jena Fuseki1 module. > -- > > Key: JENA-1649 > URL: https://issues.apache.org/jira/browse/JENA-1649 > Project: Apache Jena > Issue Type: Task >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Critical > Fix For: Jena 3.10.0 > > > Retire Fuseki1. > This an action from the dev@ discussion: > https://lists.apache.org/thread.html/b89873afba86864994d0515a4c49889c6356d1c91071964eaa1014d1@%3Cdev.jena.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1651) Improve the TDB internal consistency checking for safe replay.
[
https://issues.apache.org/jira/browse/JENA-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721423#comment-16721423
]
ASF GitHub Bot commented on JENA-1651:
--
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/509
> Improve the TDB internal consistency checking for safe replay.
> --
>
> Key: JENA-1651
> URL: https://issues.apache.org/jira/browse/JENA-1651
> Project: Apache Jena
> Issue Type: Task
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
>
> {{TransactionManager.checkReplaySafe}} reads two AtomicLongs but updated to
> these aren't coordinated so for a short time, they can be out of step.
> Updates happen just outside the true transaction start-finish in
> {{TSM_Counters}}.
> There should be one atomic operation to note whether there are active
> transaction or not.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1648) Make the result set text format a first-class ResultSetLang for output.
[ https://issues.apache.org/jira/browse/JENA-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721360#comment-16721360 ] ASF GitHub Bot commented on JENA-1648: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/507 > Make the result set text format a first-class ResultSetLang for output. > --- > > Key: JENA-1648 > URL: https://issues.apache.org/jira/browse/JENA-1648 > Project: Apache Jena > Issue Type: Improvement >Reporter: Andy Seaborne >Priority: Major > > See discussion on https://github.com/apache/jena/pull/473 . > Text special has special handling as it requires a prologue. > At he same time, integrate the "none" format. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1651) Improve the TDB internal consistency checking for safe replay.
[
https://issues.apache.org/jira/browse/JENA-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721339#comment-16721339
]
ASF GitHub Bot commented on JENA-1651:
--
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/509
JENA-1651: Specific counter for tracking active transactions.
This only happens occasionally even under high update load and is harmless,
only leading to a spurious log message.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena tdb1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/509.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #509
commit 124c7c631dd6b668b79d8628269aae8a56122b4b
Author: Andy Seaborne
Date: 2018-12-14T12:16:13Z
JENA-1651: Specific counter for tracking active transactions.
> Improve the TDB internal consistency checking for safe replay.
> --
>
> Key: JENA-1651
> URL: https://issues.apache.org/jira/browse/JENA-1651
> Project: Apache Jena
> Issue Type: Task
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
>
> {{TransactionManager.checkReplaySafe}} reads two AtomicLongs but updated to
> these aren't coordinated so for a short time, they can be out of step.
> Updates happen just outside the true transaction start-finish in
> {{TSM_Counters}}.
> There should be one atomic operation to note whether there are active
> transaction or not.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1649) Retire Apache Jena Fuseki1 module.
[ https://issues.apache.org/jira/browse/JENA-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720056#comment-16720056 ] ASF GitHub Bot commented on JENA-1649: -- GitHub user afs opened a pull request: https://github.com/apache/jena/pull/508 JENA-1649, JENA-1650: Remove jena-csv and jena-fuseki1 from the build This removed jena-csv and jena-fuseki1 from the top POM. You can merge this pull request into a Git repository by running: $ git pull https://github.com/afs/jena retire1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/508.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #508 commit 65728fb333642eed356532aae8a385bc0ca8fea7 Author: Andy Seaborne Date: 2018-12-13T11:10:12Z JENA-1649, JENA-1650: Remove jena-csv and jena-fuseki1 from the build > Retire Apache Jena Fuseki1 module. > -- > > Key: JENA-1649 > URL: https://issues.apache.org/jira/browse/JENA-1649 > Project: Apache Jena > Issue Type: Task >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Critical > Fix For: Jena 3.10.0 > > > Retire Fuseki1. > This an action from the dev@ discussion: > https://lists.apache.org/thread.html/b89873afba86864994d0515a4c49889c6356d1c91071964eaa1014d1@%3Cdev.jena.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1648) Make the result set text format a first-class ResultSetLang for output.
[ https://issues.apache.org/jira/browse/JENA-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719305#comment-16719305 ] ASF GitHub Bot commented on JENA-1648: -- GitHub user afs opened a pull request: https://github.com/apache/jena/pull/507 JENA-1648: First class text format for result sets. You can merge this pull request into a Git repository by running: $ git pull https://github.com/afs/jena text-format Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/507.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #507 commit 558e3a7e5e18e2f385b545281f1f2326810f5f5c Author: Andy Seaborne Date: 2018-12-12T18:43:13Z JENA-1648: First class text format for result sets. > Make the result set text format a first-class ResultSetLang for output. > --- > > Key: JENA-1648 > URL: https://issues.apache.org/jira/browse/JENA-1648 > Project: Apache Jena > Issue Type: Improvement >Reporter: Andy Seaborne >Priority: Major > > See discussion on https://github.com/apache/jena/pull/473 . > Text special has special handling as it requires a prologue. > At he same time, integrate the "none" format. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1647) Update jena-iri for RFC 8141 (revised URN RFC).
[
https://issues.apache.org/jira/browse/JENA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715099#comment-16715099
]
ASF GitHub Bot commented on JENA-1647:
--
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/505
> Update jena-iri for RFC 8141 (revised URN RFC).
> ---
>
> Key: JENA-1647
> URL: https://issues.apache.org/jira/browse/JENA-1647
> Project: Apache Jena
> Issue Type: Improvement
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
> Fix For: Jena 3.10.0
>
>
> RFC 8141 allows "/", "~" and "?" in the NSS part of a URN.
> "?" is only allowed as "?=" and "?+"
> {{urn:NID:NSS}}
> "?"is still excluded by jena-iri because it is used in URN resolution
> algorithms for r-component and q-component.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1645) Poor performance with full text search (Lucene)
[ https://issues.apache.org/jira/browse/JENA-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713074#comment-16713074 ] ASF GitHub Bot commented on JENA-1645: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/503 > Poor performance with full text search (Lucene) > --- > > Key: JENA-1645 > URL: https://issues.apache.org/jira/browse/JENA-1645 > Project: Apache Jena > Issue Type: Question > Components: Jena >Affects Versions: Jena 3.9.0 >Reporter: Vasyl Danyliuk >Priority: Major > Fix For: Jena 3.10.0 > > > Situation: half of a million of an indexed by Lucene documents(emails > actually), searching for emails by sender/receiver and some text. > If to put text filter in the start of SPARQL query it executes once but in a > case of very common words here are a lot of results(100 000+) that leads to > poor performance, limiting results count may and up with missed results. > If to put text search as the last condition it executes once per each already > found subject. That's completely OK but text search completely ignores > subject URI. > I found two methods in TextQueryPF class: variableSubject(...) for the first > case, and concreteSubject(...) for the second one. > The question is: why can't subject URI be used as a constraint in the text > search? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1647) Update jena-iri for RFC 8141 (revised URN RFC).
[
https://issues.apache.org/jira/browse/JENA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712695#comment-16712695
]
ASF GitHub Bot commented on JENA-1647:
--
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/505
JENA-1647: Allow '/' and '~' in URNs
Remove copies of XML files in in src/main/java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena urn-update
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/505.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #505
commit 40ededc3ce05d4b1c27b1b58ae13ad98aca74996
Author: Andy Seaborne
Date: 2018-12-07T11:13:38Z
JENA-1647: Allow '/' and '~' in URNs
Remove copies of XML files in in src/main/java
> Update jena-iri for RFC 8141 (revised URN RFC).
> ---
>
> Key: JENA-1647
> URL: https://issues.apache.org/jira/browse/JENA-1647
> Project: Apache Jena
> Issue Type: Improvement
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
> Fix For: Jena 3.10.0
>
>
> RFC 8141 allows "/", "~" and "?" in the NSS part of a URN.
> "?" is only allowed as "?=" and "?+"
> {{urn:NID:NSS}}
> "?"is still excluded by jena-iri because it is used in URN resolution
> algorithms for r-component and q-component.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1645) Poor performance with full text search (Lucene)
[ https://issues.apache.org/jira/browse/JENA-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712135#comment-16712135 ] ASF GitHub Bot commented on JENA-1645: -- Github user xristy commented on the issue: https://github.com/apache/jena/pull/503 I merged PR 503 into local master and pushed to https://git-wip-us.apache.org/repos/asf/jena.git with message: JEAN-1645 Merge commit 'refs/pull/503/head' of https://github.com/apache/jena. This closes #503 owing to the misspelling of JENA as JEAN programmatic resolving of the issue and closing of the PR has not happened. The code changes are in the ASF jena repo as expected. > Poor performance with full text search (Lucene) > --- > > Key: JENA-1645 > URL: https://issues.apache.org/jira/browse/JENA-1645 > Project: Apache Jena > Issue Type: Question > Components: Jena >Affects Versions: Jena 3.9.0 >Reporter: Vasyl Danyliuk >Priority: Major > > Situation: half of a million of an indexed by Lucene documents(emails > actually), searching for emails by sender/receiver and some text. > If to put text filter in the start of SPARQL query it executes once but in a > case of very common words here are a lot of results(100 000+) that leads to > poor performance, limiting results count may and up with missed results. > If to put text search as the last condition it executes once per each already > found subject. That's completely OK but text search completely ignores > subject URI. > I found two methods in TextQueryPF class: variableSubject(...) for the first > case, and concreteSubject(...) for the second one. > The question is: why can't subject URI be used as a constraint in the text > search? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1645) Poor performance with full text search (Lucene)
[ https://issues.apache.org/jira/browse/JENA-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710649#comment-16710649 ] ASF GitHub Bot commented on JENA-1645: -- Github user osma commented on the issue: https://github.com/apache/jena/pull/503 Looks good to me, based on a quick look at the diff. It took a while to figure out the way you use UnaryOperator but in the end it made sense. I'm currently travelling and haven't found time to actually run the code, but if it passes the existing unit tests and you're sure that they trigger the `concreteSubject` case, I'm fine with that. > Poor performance with full text search (Lucene) > --- > > Key: JENA-1645 > URL: https://issues.apache.org/jira/browse/JENA-1645 > Project: Apache Jena > Issue Type: Question > Components: Jena >Affects Versions: Jena 3.9.0 >Reporter: Vasyl Danyliuk >Priority: Major > > Situation: half of a million of an indexed by Lucene documents(emails > actually), searching for emails by sender/receiver and some text. > If to put text filter in the start of SPARQL query it executes once but in a > case of very common words here are a lot of results(100 000+) that leads to > poor performance, limiting results count may and up with missed results. > If to put text search as the last condition it executes once per each already > found subject. That's completely OK but text search completely ignores > subject URI. > I found two methods in TextQueryPF class: variableSubject(...) for the first > case, and concreteSubject(...) for the second one. > The question is: why can't subject URI be used as a constraint in the text > search? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1646) allow optional non-indexing of text:field
[
https://issues.apache.org/jira/browse/JENA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710588#comment-16710588
]
ASF GitHub Bot commented on JENA-1646:
--
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/504
> allow optional non-indexing of text:field
> -
>
> Key: JENA-1646
> URL: https://issues.apache.org/jira/browse/JENA-1646
> Project: Apache Jena
> Issue Type: Improvement
> Components: Jena
>Affects Versions: Jena 3.9.0
>Reporter: Code Ferret
>Assignee: Code Ferret
>Priority: Minor
> Labels: pull-request-available
> Fix For: Jena 3.10.0
>
>
> When using the Multilingual support, the field to search is generally the
> {{text:field}} with an appended {{text:lang}} field value:
> {code:java}
> altLabel_fr
> {code}
> In this usage, if queries are never performed against the {{text:field}}
> without a _language tag_ then some space and time can be saved by not
> indexing the {{text:field}} and this improvement adds a boolean option,
> {{text:noIndex}}, that is used in the {{text:map}} entries for those entries
> that should not have their {{text:field}} indexed. This only makes sense in
> the context of {{text:multilingualSupport true}} in the {{TextIndex}}.
> A pull request is available.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1646) allow optional non-indexing of text:field
[
https://issues.apache.org/jira/browse/JENA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710329#comment-16710329
]
ASF GitHub Bot commented on JENA-1646:
--
GitHub user xristy opened a pull request:
https://github.com/apache/jena/pull/504
JENA-1646 allow optional non-indexing
implements JENA-1646
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BuddhistDigitalResourceCenter/jena
JENA-1646-NoIndex
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/504.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #504
commit b757303a205386730888e00d0622ee7b80bb1d3b
Author: Code Ferret
Date: 2018-12-05T16:42:17Z
Merge dev NoIndex
> allow optional non-indexing of text:field
> -
>
> Key: JENA-1646
> URL: https://issues.apache.org/jira/browse/JENA-1646
> Project: Apache Jena
> Issue Type: Improvement
> Components: Jena
>Affects Versions: Jena 3.9.0
>Reporter: Code Ferret
>Assignee: Code Ferret
>Priority: Minor
> Labels: pull-request-available
> Fix For: Jena 3.10.0
>
>
> When using the Multilingual support, the field to search is generally the
> {{text:field}} with an appended {{text:lang}} field value:
> {code:java}
> altLabel_fr
> {code}
> In this usage, if queries are never performed against the {{text:field}}
> without a _language tag_ then some space and time can be saved by not
> indexing the {{text:field}} and this improvement adds a boolean option,
> {{text:noIndex}}, that is used in the {{text:map}} entries for those entries
> that should not have their {{text:field}} indexed. This only makes sense in
> the context of {{text:multilingualSupport true}} in the {{TextIndex}}.
> A pull request is available.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1645) Poor performance with full text search (Lucene)
[ https://issues.apache.org/jira/browse/JENA-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710288#comment-16710288 ] ASF GitHub Bot commented on JENA-1645: -- Github user xristy commented on the issue: https://github.com/apache/jena/pull/503 I'm looking at the PR and so far it looks good. I'm wanting to complete the PR for JENA-1646. > Poor performance with full text search (Lucene) > --- > > Key: JENA-1645 > URL: https://issues.apache.org/jira/browse/JENA-1645 > Project: Apache Jena > Issue Type: Question > Components: Jena >Affects Versions: Jena 3.9.0 >Reporter: Vasyl Danyliuk >Priority: Major > > Situation: half of a million of an indexed by Lucene documents(emails > actually), searching for emails by sender/receiver and some text. > If to put text filter in the start of SPARQL query it executes once but in a > case of very common words here are a lot of results(100 000+) that leads to > poor performance, limiting results count may and up with missed results. > If to put text search as the last condition it executes once per each already > found subject. That's completely OK but text search completely ignores > subject URI. > I found two methods in TextQueryPF class: variableSubject(...) for the first > case, and concreteSubject(...) for the second one. > The question is: why can't subject URI be used as a constraint in the text > search? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1645) Poor performance with full text search (Lucene)
[ https://issues.apache.org/jira/browse/JENA-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710281#comment-16710281 ] ASF GitHub Bot commented on JENA-1645: -- Github user rvesse commented on the issue: https://github.com/apache/jena/pull/503 cc @osma @xristy for review as main devs in this area > Poor performance with full text search (Lucene) > --- > > Key: JENA-1645 > URL: https://issues.apache.org/jira/browse/JENA-1645 > Project: Apache Jena > Issue Type: Question > Components: Jena >Affects Versions: Jena 3.9.0 >Reporter: Vasyl Danyliuk >Priority: Major > > Situation: half of a million of an indexed by Lucene documents(emails > actually), searching for emails by sender/receiver and some text. > If to put text filter in the start of SPARQL query it executes once but in a > case of very common words here are a lot of results(100 000+) that leads to > poor performance, limiting results count may and up with missed results. > If to put text search as the last condition it executes once per each already > found subject. That's completely OK but text search completely ignores > subject URI. > I found two methods in TextQueryPF class: variableSubject(...) for the first > case, and concreteSubject(...) for the second one. > The question is: why can't subject URI be used as a constraint in the text > search? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1645) Poor performance with full text search (Lucene)
[ https://issues.apache.org/jira/browse/JENA-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709803#comment-16709803 ] ASF GitHub Bot commented on JENA-1645: -- GitHub user DrBAXA opened a pull request: https://github.com/apache/jena/pull/503 JENA-1645: Use uri predicate in concrete subject query. Added URI predicate to the Lucene search in case of concrete subject search. Method added in TextIndex interface made default with a fallback to the previous implementation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/DrBAXA/jena master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/503.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #503 commit 52d959c7a654b03e525fad214b027b6ac6aba2b2 Author: vdanyliuk Date: 2018-12-05T09:10:49Z JENA-1645: Use uri predicate in concrete subject query. > Poor performance with full text search (Lucene) > --- > > Key: JENA-1645 > URL: https://issues.apache.org/jira/browse/JENA-1645 > Project: Apache Jena > Issue Type: Question > Components: Jena >Affects Versions: Jena 3.9.0 >Reporter: Vasyl Danyliuk >Priority: Major > > Situation: half of a million of an indexed by Lucene documents(emails > actually), searching for emails by sender/receiver and some text. > If to put text filter in the start of SPARQL query it executes once but in a > case of very common words here are a lot of results(100 000+) that leads to > poor performance, limiting results count may and up with missed results. > If to put text search as the last condition it executes once per each already > found subject. That's completely OK but text search completely ignores > subject URI. > I found two methods in TextQueryPF class: variableSubject(...) for the first > case, and concreteSubject(...) for the second one. > The question is: why can't subject URI be used as a constraint in the text > search? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1644) ParameterizedSparqlString Empty List fix
[ https://issues.apache.org/jira/browse/JENA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705140#comment-16705140 ] ASF GitHub Bot commented on JENA-1644: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/502 > ParameterizedSparqlString Empty List fix > > > Key: JENA-1644 > URL: https://issues.apache.org/jira/browse/JENA-1644 > Project: Apache Jena > Issue Type: Bug >Affects Versions: Jena 3.9.0 >Reporter: Greg Albiston >Priority: Minor > > ParameterizedSparqlString throws a StringIndexOutOfBoundsException when empty > list of values is provided. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1643) CLEAR and DROP do not work on inference graphs over TDB.
[
https://issues.apache.org/jira/browse/JENA-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705139#comment-16705139
]
ASF GitHub Bot commented on JENA-1643:
--
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/501
> CLEAR and DROP do not work on inference graphs over TDB.
>
>
> Key: JENA-1643
> URL: https://issues.apache.org/jira/browse/JENA-1643
> Project: Apache Jena
> Issue Type: Bug
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
> Fix For: Jena 3.10.0
>
>
> [Reported by
> email|https://lists.apache.org/thread.html/74e434ababc63419fe5abf141d88ea9101b8d7fc0ca7b860f400b4d9@%3Cusers.jena.apache.org%3E].
> {{BaseInfGraph}}.clear is not trigger transaction promoting in the
> graph-level transaction going through {{GraphTDB.clear}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1643) CLEAR and DROP do not work on inference graphs over TDB.
[
https://issues.apache.org/jira/browse/JENA-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704667#comment-16704667
]
ASF GitHub Bot commented on JENA-1643:
--
Github user afs commented on the issue:
https://github.com/apache/jena/pull/501
And review approvals?
> CLEAR and DROP do not work on inference graphs over TDB.
>
>
> Key: JENA-1643
> URL: https://issues.apache.org/jira/browse/JENA-1643
> Project: Apache Jena
> Issue Type: Bug
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
> Fix For: Jena 3.10.0
>
>
> [Reported by
> email|https://lists.apache.org/thread.html/74e434ababc63419fe5abf141d88ea9101b8d7fc0ca7b860f400b4d9@%3Cusers.jena.apache.org%3E].
> {{BaseInfGraph}}.clear is not trigger transaction promoting in the
> graph-level transaction going through {{GraphTDB.clear}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1644) ParameterizedSparqlString Empty List fix
[ https://issues.apache.org/jira/browse/JENA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704641#comment-16704641 ] ASF GitHub Bot commented on JENA-1644: -- GitHub user galbiston reopened a pull request: https://github.com/apache/jena/pull/502 JENA-1644 ParameterizedSparqlString Empty List fix ParameterizedSparqlString now accepts an empty list of values rather than throwing a StringIndexOutOfBoundsException. You can merge this pull request into a Git repository by running: $ git pull https://github.com/galbiston/jena query-values-empty-list-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/502.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #502 commit f65e9621f7dd1f0391fd742a0da8261ead665755 Author: Greg Albiston <4662258+galbiston@...> Date: 2018-11-30T11:40:16Z ARQ:ParameterizedSparqlString - now accepts an empty list of values rather than throwing a StringIndexOutOfBoundsException. > ParameterizedSparqlString Empty List fix > > > Key: JENA-1644 > URL: https://issues.apache.org/jira/browse/JENA-1644 > Project: Apache Jena > Issue Type: Bug >Affects Versions: Jena 3.9.0 >Reporter: Greg Albiston >Priority: Minor > > ParameterizedSparqlString throws a StringIndexOutOfBoundsException when empty > list of values is provided. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1644) ParameterizedSparqlString Empty List fix
[ https://issues.apache.org/jira/browse/JENA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704639#comment-16704639 ] ASF GitHub Bot commented on JENA-1644: -- Github user galbiston closed the pull request at: https://github.com/apache/jena/pull/502 > ParameterizedSparqlString Empty List fix > > > Key: JENA-1644 > URL: https://issues.apache.org/jira/browse/JENA-1644 > Project: Apache Jena > Issue Type: Bug >Affects Versions: Jena 3.9.0 >Reporter: Greg Albiston >Priority: Minor > > ParameterizedSparqlString throws a StringIndexOutOfBoundsException when empty > list of values is provided. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1643) CLEAR and DROP do not work on inference graphs over TDB.
[
https://issues.apache.org/jira/browse/JENA-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704635#comment-16704635
]
ASF GitHub Bot commented on JENA-1643:
--
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/501#discussion_r237839306
--- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/store/GraphTDB.java ---
@@ -171,7 +171,10 @@ protected final int graphBaseSize() {
@Override
public void clear() {
-getDatasetGraphTDB().deleteAny(getGraphName(), Node.ANY, Node.ANY,
Node.ANY) ;
+// Logically, this is "super.clear()" except the default
implementation
+// is a loop that materializes nodes. We want to call the dataset
directly
+// so that nodes don't get materialized, just deleted from indexes.
--- End diff --
Yes.
> CLEAR and DROP do not work on inference graphs over TDB.
>
>
> Key: JENA-1643
> URL: https://issues.apache.org/jira/browse/JENA-1643
> Project: Apache Jena
> Issue Type: Bug
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
> Fix For: Jena 3.10.0
>
>
> [Reported by
> email|https://lists.apache.org/thread.html/74e434ababc63419fe5abf141d88ea9101b8d7fc0ca7b860f400b4d9@%3Cusers.jena.apache.org%3E].
> {{BaseInfGraph}}.clear is not trigger transaction promoting in the
> graph-level transaction going through {{GraphTDB.clear}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1643) CLEAR and DROP do not work on inference graphs over TDB.
[
https://issues.apache.org/jira/browse/JENA-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704608#comment-16704608
]
ASF GitHub Bot commented on JENA-1643:
--
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/501#discussion_r237830232
--- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/store/GraphTDB.java ---
@@ -171,7 +171,10 @@ protected final int graphBaseSize() {
@Override
public void clear() {
-getDatasetGraphTDB().deleteAny(getGraphName(), Node.ANY, Node.ANY,
Node.ANY) ;
+// Logically, this is "super.clear()" except the default
implementation
+// is a loop that materializes nodes. We want to call the dataset
directly
+// so that nodes don't get materialized, just deleted from indexes.
--- End diff --
@afs Just for my education, what do you mean by "materialized" here?
> CLEAR and DROP do not work on inference graphs over TDB.
>
>
> Key: JENA-1643
> URL: https://issues.apache.org/jira/browse/JENA-1643
> Project: Apache Jena
> Issue Type: Bug
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
> Fix For: Jena 3.10.0
>
>
> [Reported by
> email|https://lists.apache.org/thread.html/74e434ababc63419fe5abf141d88ea9101b8d7fc0ca7b860f400b4d9@%3Cusers.jena.apache.org%3E].
> {{BaseInfGraph}}.clear is not trigger transaction promoting in the
> graph-level transaction going through {{GraphTDB.clear}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1643) CLEAR and DROP do not work on inference graphs over TDB.
[
https://issues.apache.org/jira/browse/JENA-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704613#comment-16704613
]
ASF GitHub Bot commented on JENA-1643:
--
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/jena/pull/501#discussion_r237831448
--- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/store/GraphTDB.java ---
@@ -171,7 +171,10 @@ protected final int graphBaseSize() {
@Override
public void clear() {
-getDatasetGraphTDB().deleteAny(getGraphName(), Node.ANY, Node.ANY,
Node.ANY) ;
+// Logically, this is "super.clear()" except the default
implementation
+// is a loop that materializes nodes. We want to call the dataset
directly
+// so that nodes don't get materialized, just deleted from indexes.
--- End diff --
Loaded from the node table into nodes in the cache I think?
> CLEAR and DROP do not work on inference graphs over TDB.
>
>
> Key: JENA-1643
> URL: https://issues.apache.org/jira/browse/JENA-1643
> Project: Apache Jena
> Issue Type: Bug
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
> Fix For: Jena 3.10.0
>
>
> [Reported by
> email|https://lists.apache.org/thread.html/74e434ababc63419fe5abf141d88ea9101b8d7fc0ca7b860f400b4d9@%3Cusers.jena.apache.org%3E].
> {{BaseInfGraph}}.clear is not trigger transaction promoting in the
> graph-level transaction going through {{GraphTDB.clear}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1643) CLEAR and DROP do not work on inference graphs over TDB.
[
https://issues.apache.org/jira/browse/JENA-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704607#comment-16704607
]
ASF GitHub Bot commented on JENA-1643:
--
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/501
JENA-1643: Use transactional dataset in clear().
The fix is the one line change in method `clear()`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena graphtdb-clear
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/501.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #501
commit 2c1b6c84b589b004aeab76099578aa0aee2bbab0
Author: Andy Seaborne
Date: 2018-11-30T11:15:09Z
JENA-1643: Use transactional dataset in clear().
> CLEAR and DROP do not work on inference graphs over TDB.
>
>
> Key: JENA-1643
> URL: https://issues.apache.org/jira/browse/JENA-1643
> Project: Apache Jena
> Issue Type: Bug
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
> Fix For: Jena 3.10.0
>
>
> [Reported by
> email|https://lists.apache.org/thread.html/74e434ababc63419fe5abf141d88ea9101b8d7fc0ca7b860f400b4d9@%3Cusers.jena.apache.org%3E].
> {{BaseInfGraph}}.clear is not trigger transaction promoting in the
> graph-level transaction going through {{GraphTDB.clear}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1641) Provide Iter.flatMap
[
https://issues.apache.org/jira/browse/JENA-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703520#comment-16703520
]
ASF GitHub Bot commented on JENA-1641:
--
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/499
> Provide Iter.flatMap
>
>
> Key: JENA-1641
> URL: https://issues.apache.org/jira/browse/JENA-1641
> Project: Apache Jena
> Issue Type: Improvement
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
> Fix For: Jena 3.10.0
>
>
> This is missing from {{Iter}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1642) Schemagen configuration option "header" throws exception
[ https://issues.apache.org/jira/browse/JENA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703521#comment-16703521 ] ASF GitHub Bot commented on JENA-1642: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/500 > Schemagen configuration option "header" throws exception > > > Key: JENA-1642 > URL: https://issues.apache.org/jira/browse/JENA-1642 > Project: Apache Jena > Issue Type: Bug > Components: Jena, Maven Tools >Affects Versions: Jena 3.6.0 >Reporter: Joseph Sarjeant >Priority: Minor > Original Estimate: 1h > Remaining Estimate: 1h > > When using Jena Schemagen from the maven plugin the configuration option for > `header` throws a `BadBooleanException`. Schemagen is checking for `isTrue` > for this option while the value specified is intended to be a String. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1642) Schemagen configuration option "header" throws exception
[ https://issues.apache.org/jira/browse/JENA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703513#comment-16703513 ] ASF GitHub Bot commented on JENA-1642: -- Github user afs commented on the issue: https://github.com/apache/jena/pull/500 > it appears that the maven tools are no being built as part of the main project. Is that the case? Yes, I'm afraid it is. Some tests fail when used with Apache parent >19 (I just checked with v21 - this is still the case). ``` [ERROR] The following builds failed: [ERROR] * schemagen-integration-1/pom.xml [ERROR] * schemagen-integration-4/pom.xml [ERROR] * schemagen-integration-2/pom.xml [ERROR] * schemagen-integration-0/pom.xml [ERROR] * schemagen-integration-3/pom.xml ``` > Schemagen configuration option "header" throws exception > > > Key: JENA-1642 > URL: https://issues.apache.org/jira/browse/JENA-1642 > Project: Apache Jena > Issue Type: Bug > Components: Jena, Maven Tools >Affects Versions: Jena 3.6.0 >Reporter: Joseph Sarjeant >Priority: Minor > Original Estimate: 1h > Remaining Estimate: 1h > > When using Jena Schemagen from the maven plugin the configuration option for > `header` throws a `BadBooleanException`. Schemagen is checking for `isTrue` > for this option while the value specified is intended to be a String. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1642) Schemagen configuration option "header" throws exception
[ https://issues.apache.org/jira/browse/JENA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700825#comment-16700825 ] ASF GitHub Bot commented on JENA-1642: -- GitHub user jsarjeant opened a pull request: https://github.com/apache/jena/pull/500 JENA-1642: Check has value for header instead of is true When using schemagen from the maven plugin the `header` option does not work. `header` is intended to be a template string and when `isTrue` is checked the string is cast to a boolean and the `BadBooleanException` is thrown. I believe we should check for existence here instead of "truthiness" Also, it appears that the maven tools are no being built as part of the main project. Is that the case? You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsarjeant/jena master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/500.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #500 commit 471d1f8511def353f1b64776c2a986d1e6d8ab45 Author: Joseph Sarjeant Date: 2018-11-27T18:08:43Z Check has value for header instead of is true > Schemagen configuration option "header" throws exception > > > Key: JENA-1642 > URL: https://issues.apache.org/jira/browse/JENA-1642 > Project: Apache Jena > Issue Type: Bug > Components: Jena, Maven Tools >Affects Versions: Jena 3.6.0 >Reporter: Joseph Sarjeant >Priority: Minor > Original Estimate: 1h > Remaining Estimate: 1h > > When using Jena Schemagen from the maven plugin the configuration option for > `header` throws a `BadBooleanException`. Schemagen is checking for `isTrue` > for this option while the value specified is intended to be a String. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1641) Provide Iter.flatMap
[
https://issues.apache.org/jira/browse/JENA-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700492#comment-16700492
]
ASF GitHub Bot commented on JENA-1641:
--
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/499
JENA-1641: Iter.flatMap.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena iter-flatmap
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/499.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #499
commit 7ac69b3ad7e2be3398b9daee72954ffa0efb36c3
Author: Andy Seaborne
Date: 2018-11-27T14:21:26Z
JENA-1641: Iter.flatMap.
> Provide Iter.flatMap
>
>
> Key: JENA-1641
> URL: https://issues.apache.org/jira/browse/JENA-1641
> Project: Apache Jena
> Issue Type: Improvement
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
> Fix For: Jena 3.10.0
>
>
> This is missing from {{Iter}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1640) Extendable versions of classes for printing result sets
[
https://issues.apache.org/jira/browse/JENA-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698827#comment-16698827
]
ASF GitHub Bot commented on JENA-1640:
--
Github user afs commented on the issue:
https://github.com/apache/jena/pull/473
Recorded as https://issues.apache.org/jira/browse/JENA-1640.
> Extendable versions of classes for printing result sets
> ---
>
> Key: JENA-1640
> URL: https://issues.apache.org/jira/browse/JENA-1640
> Project: Apache Jena
> Issue Type: Improvement
> Components: ARQ
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
> Fix For: Jena 3.10.0
>
>
> This records [PR #473|https://github.com/apache/jena/pull/473].
> {quote}
> This PR modifies the classes CSVOutput and TSVOutput to make it possible to
> extend them and override their behavior in subclasses.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1639) Add Model.getList and Statement.getList.
[
https://issues.apache.org/jira/browse/JENA-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698795#comment-16698795
]
ASF GitHub Bot commented on JENA-1639:
--
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/498
> Add Model.getList and Statement.getList.
>
>
> Key: JENA-1639
> URL: https://issues.apache.org/jira/browse/JENA-1639
> Project: Apache Jena
> Issue Type: Improvement
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
>
> Methods {{Model.getList}} and {{Statement.getList}} don't exist while
> {{getSeq}} etc do; the application has to call {{as(RDFList.class)}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1639) Add Model.getList and Statement.getList.
[
https://issues.apache.org/jira/browse/JENA-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698299#comment-16698299
]
ASF GitHub Bot commented on JENA-1639:
--
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/498
Ah, I _always_ get `ModelCon` and `ModelCom` (impl) confused. Cool!
> Add Model.getList and Statement.getList.
>
>
> Key: JENA-1639
> URL: https://issues.apache.org/jira/browse/JENA-1639
> Project: Apache Jena
> Issue Type: Improvement
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
>
> Methods {{Model.getList}} and {{Statement.getList}} don't exist while
> {{getSeq}} etc do; the application has to call {{as(RDFList.class)}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1639) Add Model.getList and Statement.getList.
[
https://issues.apache.org/jira/browse/JENA-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698302#comment-16698302
]
ASF GitHub Bot commented on JENA-1639:
--
Github user afs commented on the issue:
https://github.com/apache/jena/pull/498
Ditto!
> Add Model.getList and Statement.getList.
>
>
> Key: JENA-1639
> URL: https://issues.apache.org/jira/browse/JENA-1639
> Project: Apache Jena
> Issue Type: Improvement
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
>
> Methods {{Model.getList}} and {{Statement.getList}} don't exist while
> {{getSeq}} etc do; the application has to call {{as(RDFList.class)}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1639) Add Model.getList and Statement.getList.
[
https://issues.apache.org/jira/browse/JENA-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698292#comment-16698292
]
ASF GitHub Bot commented on JENA-1639:
--
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/498#discussion_r236089837
--- Diff: jena-core/src/main/java/org/apache/jena/rdf/model/ModelCon.java
---
@@ -111,38 +111,62 @@
* It is in effect an unsafe downcast.
*
* Subsequent operations on the returned Alt may modify this model.
- * The bag is assumed to already exist in the model. If it does not,
+ * The Alt is assumed to already exist in the model. If it does not,
* createAlt should be used instead.
* @return an Alt instance
* @param r an untyped Resource instance
*/
Alt getAlt(Resource r) ;
+
/** Return a Seq instance in this model.
*
- * Subsequent operations on the returned bag may modify this model.
+ * Subsequent operations on the returned sequence may modify this
model.
* The seq is assumed to already exist in the model. If it does not,
* createSeq should be used instead.
* @return a seq instance
* @param uri the URI of the seq
*/
Seq getSeq(String uri) ;
-
+
/** Return a Seq instance based on a given resource.
*
* This method enables an application to treat any resource as a Seq.
* It is in effect an unsafe downcast.
*
* Subsequent operations on the returned Seq may modify this model.
* The Seq is assumed to already exist in the model. If it does not,
- * createAlt should be used instead.
- * @return an Alt instance
+ * createSeq should be used instead.
+ * @return an Seq instance
* @param r an untyped Resource instance
*/
Seq getSeq(Resource r) ;
+/** Return a RDF List instance in this model.
+ *
+ * Subsequent operations on the returned list may modify this model.
+ * The list is assumed to already exist in the model. If it does not,
+ * createList should be used instead.
+ * @return a list instance
+ * @param uri the URI of the list
+ */
+RDFList getList(String uri) ;
+
+/** Return a RDF List based on a given resource.
+ *
+ * This method enables an application to treat any resource as a list.
+ * It is in effect an unsafe downcast.
+ *
+ * Subsequent operations on the returned list may modify this model.
+ * The list is assumed to already exist in the model. If it does not,
+ * createList should be used instead.
+ * @return a list instance
+ * @param r the resource of the list
+ */
+ RDFList getList(Resource r) ;
--- End diff --
Here.
> Add Model.getList and Statement.getList.
>
>
> Key: JENA-1639
> URL: https://issues.apache.org/jira/browse/JENA-1639
> Project: Apache Jena
> Issue Type: Improvement
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
>
> Methods {{Model.getList}} and {{Statement.getList}} don't exist while
> {{getSeq}} etc do; the application has to call {{as(RDFList.class)}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1639) Add Model.getList and Statement.getList.
[
https://issues.apache.org/jira/browse/JENA-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698293#comment-16698293
]
ASF GitHub Bot commented on JENA-1639:
--
Github user afs commented on the issue:
https://github.com/apache/jena/pull/498
`interface Model extends ModelCon`
(I think to put many of the convenience wrappings in a different place i.e.
`ModelCon`)
> Add Model.getList and Statement.getList.
>
>
> Key: JENA-1639
> URL: https://issues.apache.org/jira/browse/JENA-1639
> Project: Apache Jena
> Issue Type: Improvement
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
>
> Methods {{Model.getList}} and {{Statement.getList}} don't exist while
> {{getSeq}} etc do; the application has to call {{as(RDFList.class)}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1639) Add Model.getList and Statement.getList.
[
https://issues.apache.org/jira/browse/JENA-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698279#comment-16698279
]
ASF GitHub Bot commented on JENA-1639:
--
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/498
I'm probably confused, but where is `Model::getList` being added? I just
see a change to `createList` and `getList` is only added to `ModelCon`.
> Add Model.getList and Statement.getList.
>
>
> Key: JENA-1639
> URL: https://issues.apache.org/jira/browse/JENA-1639
> Project: Apache Jena
> Issue Type: Improvement
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
>
> Methods {{Model.getList}} and {{Statement.getList}} don't exist while
> {{getSeq}} etc do; the application has to call {{as(RDFList.class)}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1639) Add Model.getList and Statement.getList.
[
https://issues.apache.org/jira/browse/JENA-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698242#comment-16698242
]
ASF GitHub Bot commented on JENA-1639:
--
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/498
JENA-1639: Model.getList and Statement.getList
Attempted to use the local code style at each addition point.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena rdf-list
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/498.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #498
commit d914372597d1d2b0296d8fb01e1d95989f42c670
Author: Andy Seaborne
Date: 2018-11-25T18:19:34Z
JENA-1639: Model.getList and Statement.getList
> Add Model.getList and Statement.getList.
>
>
> Key: JENA-1639
> URL: https://issues.apache.org/jira/browse/JENA-1639
> Project: Apache Jena
> Issue Type: Improvement
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
>
> Methods {{Model.getList}} and {{Statement.getList}} don't exist while
> {{getSeq}} etc do; the application has to call {{as(RDFList.class)}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1637) RIOT commands don't default the language correctly.
[
https://issues.apache.org/jira/browse/JENA-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697463#comment-16697463
]
ASF GitHub Bot commented on JENA-1637:
--
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/497
> RIOT commands don't default the language correctly.
> ---
>
> Key: JENA-1637
> URL: https://issues.apache.org/jira/browse/JENA-1637
> Project: Apache Jena
> Issue Type: Bug
> Components: RIOT
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
> Fix For: Jena 3.10.0
>
>
> Commends such as {{turtle}} are not defaulting the language hint correctly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1637) RIOT commands don't default the language correctly.
[
https://issues.apache.org/jira/browse/JENA-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697251#comment-16697251
]
ASF GitHub Bot commented on JENA-1637:
--
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/497
JENA-1637: Default hint language for the by-lang parse commands.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena cmd-lang
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/497.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #497
commit 2f655c0e3ba110478a8bd0050f40362dcb11db41
Author: Andy Seaborne
Date: 2018-11-23T13:47:51Z
JENA-1637: Default hint language for the by-lang parse commands.
> RIOT commands don't default the language correctly.
> ---
>
> Key: JENA-1637
> URL: https://issues.apache.org/jira/browse/JENA-1637
> Project: Apache Jena
> Issue Type: Bug
> Components: RIOT
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Minor
> Fix For: Jena 3.10.0
>
>
> Commends such as {{turtle}} are not defaulting the language hint correctly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1632) https support in SOH
[ https://issues.apache.org/jira/browse/JENA-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697250#comment-16697250 ] ASF GitHub Bot commented on JENA-1632: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/495 > https support in SOH > > > Key: JENA-1632 > URL: https://issues.apache.org/jira/browse/JENA-1632 > Project: Apache Jena > Issue Type: Improvement >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Minor > Fix For: Jena 3.10.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1633) Seeing incorrect answers to a specific SPARQL 1.1 MINUS query with some datasets
[
https://issues.apache.org/jira/browse/JENA-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697218#comment-16697218
]
ASF GitHub Bot commented on JENA-1633:
--
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/493
> Seeing incorrect answers to a specific SPARQL 1.1 MINUS query with some
> datasets
>
>
> Key: JENA-1633
> URL: https://issues.apache.org/jira/browse/JENA-1633
> Project: Apache Jena
> Issue Type: Bug
> Components: Jena
>Affects Versions: Jena 3.4.0, Jena 3.9.0
>Reporter: Julian Dolby
>Assignee: Andy Seaborne
>Priority: Major
>
> We appear to be seeing incorrect answers when the following query is
> applied to some datasets but not others:
> {noformat}
> PREFIX foaf:
> .
>
> "some bad page" .
>
> "num1"^^ .
>
> .
>
> "some bad page" .
> {noformat}
> and the result is empty. This is surely wrong because the first
> triple of the dataset matches the first triple in the query, and
> nothing matches the optional part, indeed, there are no foaf:member
> triples at all. Given that, the minus part cannot possibly match
> because ?band is unbound and hence the dom() relations of the two
> parts must be disjoint. So surely there should be one result?
> We run this test using the following simple driver program:
> {noformat}
> public class JenaRunner {
>
> public static void main(String[] args) throws MalformedURLException,
> IOException {
> Query ast = JenaUtil.parse(args[0]);
> Dataset dataset = RDFDataMgr.loadDataset(args[1]);
> QueryExecution exec = QueryExecutionFactory.create(ast, dataset);
> ResultSet results = exec.execSelect();
> ResultSetFormatter.output(
> System.out,
> results,
> ResultsFormat.FMT_RDF_TURTLE);
> }
> }
> {noformat}
> This problem is possibly quite subtle, since we do get correct results
> for some other datasets like the following:
> {noformat}
> .
>
> "lit0"^^ .
>
> "lit0"^^ .
> _:BX5FX3Ablank0 "num2"^^ .
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1638) Fuseki clean-up
[
https://issues.apache.org/jira/browse/JENA-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697214#comment-16697214
]
ASF GitHub Bot commented on JENA-1638:
--
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/496
JENA-1638: Fuseki cleanup.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena fuseki-misc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/496.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #496
commit cd42e6a8501b2d071c8336e194cbd78a92ca9cb1
Author: Andy Seaborne
Date: 2018-11-23T13:53:12Z
JENA-1638: Add /$/status as synonym for /$/server.
commit a29429dd7713824f1dd95c18fbdf4c47d3864654
Author: Andy Seaborne
Date: 2018-11-23T13:54:31Z
JENA-1638: Ping and stats server endpoints.
Command line: --withPing and --withStats
Config: "fuseki:pingEP true" "fuseki:statsEP true"
> Fuseki clean-up
> ---
>
> Key: JENA-1638
> URL: https://issues.apache.org/jira/browse/JENA-1638
> Project: Apache Jena
> Issue Type: Improvement
>Reporter: Andy Seaborne
>Priority: Major
>
> Following discussions on users@, there are some minor fixes and clea-ups:
> * Support {{/$/status}} as a server endpoint.
> * Support {{/$/ping}} and {{/$/stats}} in Fuseki Main command line and config
> files.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1623) Fuseki: Provide server and service access control.
[ https://issues.apache.org/jira/browse/JENA-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695814#comment-16695814 ] ASF GitHub Bot commented on JENA-1623: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/492 > Fuseki: Provide server and service access control. > -- > > Key: JENA-1623 > URL: https://issues.apache.org/jira/browse/JENA-1623 > Project: Apache Jena > Issue Type: Task > Components: Fuseki >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Major > Fix For: Jena 3.10.0 > > > Provide password-controlled access to server as whole and also on a > per-service basis. > This should include "any logged in user" as well as named users. > This goes along JENA-1595 which is graph-level access control - that already > assumes authentication to get the user. > This is for Fuseki main, not Fuseki webapp. Fuseki webapp is suitable when > the webapp container (e.g. tomcat) is providing the authentication and access > control. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1632) https support in SOH
[ https://issues.apache.org/jira/browse/JENA-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695800#comment-16695800 ] ASF GitHub Bot commented on JENA-1632: -- GitHub user afs opened a pull request: https://github.com/apache/jena/pull/495 JENA-1632: https support in SOH scripts This version of SOH should work with https endpoints. However, it does not follow redirections so http->https does not work. You can merge this pull request into a Git repository by running: $ git pull https://github.com/afs/jena soh Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/495.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #495 commit 3044c61f5188505e78b67d6c6071d65ac4056424 Author: Andy Seaborne Date: 2018-11-22T11:42:56Z JENA-1632: https support in SOH scripts > https support in SOH > > > Key: JENA-1632 > URL: https://issues.apache.org/jira/browse/JENA-1632 > Project: Apache Jena > Issue Type: Improvement >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Minor > Fix For: Jena 3.10.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1623) Fuseki: Provide server and service access control.
[
https://issues.apache.org/jira/browse/JENA-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694870#comment-16694870
]
ASF GitHub Bot commented on JENA-1623:
--
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/492#discussion_r235441879
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/build/FusekiBuilder.java
---
@@ -70,16 +69,42 @@ public static void populateStdServices(DataService
dataService, boolean allowUpd
/** Add an operation to a {@link DataService} with a given endpoint
name */
public static void addServiceEP(DataService dataService, Operation
operation, String endpointName) {
-dataService.addEndpoint(operation, endpointName) ;
+dataService.addEndpoint(operation, endpointName) ;
+}
+
+/** Add an operation to a {@link DataService} with a given endpoint
name */
+public static void addServiceEP(DataService dataService, Operation
operation, String endpointName, AuthPolicy requestAuth) {
+dataService.addEndpoint(operation, endpointName, requestAuth) ;
}
public static void addServiceEP(DataService dataService, Operation
operation, Resource svc, Property property) {
String p = "<"+property.getURI()+">" ;
ResultSet rs = FusekiBuildLib.query("SELECT * { ?svc " + p + "
?ep}", svc.getModel(), "svc", svc) ;
for ( ; rs.hasNext() ; ) {
QuerySolution soln = rs.next() ;
-String epName = soln.getLiteral("ep").getLexicalForm() ;
-addServiceEP(dataService, operation, epName);
+AuthPolicy requestAuth = null;
--- End diff --
Yes - the authorization setup needs to be passed out of the "else" arm of
the if it is found, otherwise it is "no AuthPolicy". Java scope issue. "null"
means "no value seen in the configuration".
An alternative would have been to always have an executable AuthPolicy even
if it's "anyone, unauthenticated or not".
For keeping track of setup, which can be become quite complicated, I found
it slightly easier to use a null as "this hasn't been set" rather than use a
marker AuthPolicy.
Comment added.
> Fuseki: Provide server and service access control.
> --
>
> Key: JENA-1623
> URL: https://issues.apache.org/jira/browse/JENA-1623
> Project: Apache Jena
> Issue Type: Task
> Components: Fuseki
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
> Fix For: Jena 3.10.0
>
>
> Provide password-controlled access to server as whole and also on a
> per-service basis.
> This should include "any logged in user" as well as named users.
> This goes along JENA-1595 which is graph-level access control - that already
> assumes authentication to get the user.
> This is for Fuseki main, not Fuseki webapp. Fuseki webapp is suitable when
> the webapp container (e.g. tomcat) is providing the authentication and access
> control.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1623) Fuseki: Provide server and service access control.
[
https://issues.apache.org/jira/browse/JENA-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694747#comment-16694747
]
ASF GitHub Bot commented on JENA-1623:
--
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/jena/pull/492#discussion_r235398663
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/build/FusekiBuilder.java
---
@@ -70,16 +69,42 @@ public static void populateStdServices(DataService
dataService, boolean allowUpd
/** Add an operation to a {@link DataService} with a given endpoint
name */
public static void addServiceEP(DataService dataService, Operation
operation, String endpointName) {
-dataService.addEndpoint(operation, endpointName) ;
+dataService.addEndpoint(operation, endpointName) ;
+}
+
+/** Add an operation to a {@link DataService} with a given endpoint
name */
+public static void addServiceEP(DataService dataService, Operation
operation, String endpointName, AuthPolicy requestAuth) {
+dataService.addEndpoint(operation, endpointName, requestAuth) ;
}
public static void addServiceEP(DataService dataService, Operation
operation, Resource svc, Property property) {
String p = "<"+property.getURI()+">" ;
ResultSet rs = FusekiBuildLib.query("SELECT * { ?svc " + p + "
?ep}", svc.getModel(), "svc", svc) ;
for ( ; rs.hasNext() ; ) {
QuerySolution soln = rs.next() ;
-String epName = soln.getLiteral("ep").getLexicalForm() ;
-addServiceEP(dataService, operation, epName);
+AuthPolicy requestAuth = null;
--- End diff --
Looks like `FusekiBuilder` populates this at a later stage so maybe a
comment to that effect here?
> Fuseki: Provide server and service access control.
> --
>
> Key: JENA-1623
> URL: https://issues.apache.org/jira/browse/JENA-1623
> Project: Apache Jena
> Issue Type: Task
> Components: Fuseki
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
> Fix For: Jena 3.10.0
>
>
> Provide password-controlled access to server as whole and also on a
> per-service basis.
> This should include "any logged in user" as well as named users.
> This goes along JENA-1595 which is graph-level access control - that already
> assumes authentication to get the user.
> This is for Fuseki main, not Fuseki webapp. Fuseki webapp is suitable when
> the webapp container (e.g. tomcat) is providing the authentication and access
> control.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1623) Fuseki: Provide server and service access control.
[
https://issues.apache.org/jira/browse/JENA-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694745#comment-16694745
]
ASF GitHub Bot commented on JENA-1623:
--
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/jena/pull/492#discussion_r235395467
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/build/FusekiBuilder.java
---
@@ -70,16 +69,42 @@ public static void populateStdServices(DataService
dataService, boolean allowUpd
/** Add an operation to a {@link DataService} with a given endpoint
name */
public static void addServiceEP(DataService dataService, Operation
operation, String endpointName) {
-dataService.addEndpoint(operation, endpointName) ;
+dataService.addEndpoint(operation, endpointName) ;
+}
+
+/** Add an operation to a {@link DataService} with a given endpoint
name */
+public static void addServiceEP(DataService dataService, Operation
operation, String endpointName, AuthPolicy requestAuth) {
+dataService.addEndpoint(operation, endpointName, requestAuth) ;
}
public static void addServiceEP(DataService dataService, Operation
operation, Resource svc, Property property) {
String p = "<"+property.getURI()+">" ;
ResultSet rs = FusekiBuildLib.query("SELECT * { ?svc " + p + "
?ep}", svc.getModel(), "svc", svc) ;
for ( ; rs.hasNext() ; ) {
QuerySolution soln = rs.next() ;
-String epName = soln.getLiteral("ep").getLexicalForm() ;
-addServiceEP(dataService, operation, epName);
+AuthPolicy requestAuth = null;
--- End diff --
Should this be getting populated with a non-null value here? Or is the
intention to set to `null` by default and then potentially load in the auth
policy later elsewhere?
> Fuseki: Provide server and service access control.
> --
>
> Key: JENA-1623
> URL: https://issues.apache.org/jira/browse/JENA-1623
> Project: Apache Jena
> Issue Type: Task
> Components: Fuseki
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
> Fix For: Jena 3.10.0
>
>
> Provide password-controlled access to server as whole and also on a
> per-service basis.
> This should include "any logged in user" as well as named users.
> This goes along JENA-1595 which is graph-level access control - that already
> assumes authentication to get the user.
> This is for Fuseki main, not Fuseki webapp. Fuseki webapp is suitable when
> the webapp container (e.g. tomcat) is providing the authentication and access
> control.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1623) Fuseki: Provide server and service access control.
[
https://issues.apache.org/jira/browse/JENA-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694729#comment-16694729
]
ASF GitHub Bot commented on JENA-1623:
--
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/jena/pull/492#discussion_r235394477
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/auth/AuthPolicy.java
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.jena.fuseki.auth;
+
+/**
+ * Policy for authorization to a resource.
+ * Assumes the user has already been authenticated.
+ */
+public interface AuthPolicy {
+/**
+ * Is the use authorized for this resource?
+ */
+public boolean isAllowed(String user);
+
+/**
+ * Is the use denied for this resource? Both {@linkplain #isAllowed}
and
+ * {@linkplain #isDenied} could be false if the policy does not knwo
one way of the
--- End diff --
Typo - `knwo` -> `know`
> Fuseki: Provide server and service access control.
> --
>
> Key: JENA-1623
> URL: https://issues.apache.org/jira/browse/JENA-1623
> Project: Apache Jena
> Issue Type: Task
> Components: Fuseki
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
> Fix For: Jena 3.10.0
>
>
> Provide password-controlled access to server as whole and also on a
> per-service basis.
> This should include "any logged in user" as well as named users.
> This goes along JENA-1595 which is graph-level access control - that already
> assumes authentication to get the user.
> This is for Fuseki main, not Fuseki webapp. Fuseki webapp is suitable when
> the webapp container (e.g. tomcat) is providing the authentication and access
> control.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1630) store literals only once in lucene docs for jena-text w/ multilingual configs
[ https://issues.apache.org/jira/browse/JENA-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690649#comment-16690649 ] ASF GitHub Bot commented on JENA-1630: -- Github user afs commented on the issue: https://github.com/apache/jena/pull/489 This is what I see (I'm not the PR contributor presumably that's the difference):  > store literals only once in lucene docs for jena-text w/ multilingual configs > - > > Key: JENA-1630 > URL: https://issues.apache.org/jira/browse/JENA-1630 > Project: Apache Jena > Issue Type: Improvement > Components: Text >Affects Versions: Jena 3.9.0 >Reporter: Code Ferret >Assignee: Code Ferret >Priority: Major > Labels: easyfix, performance, pull-request-available > Fix For: Jena 3.10.0 > > > We can save some space in the Lucene db for jena-text when using multilingual > configurations by only storing the incoming literal once rather than for each > field's language tag variant. > A PR is ready -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1635) Invalid Automatic-Module-Names in fuseki2 modules
[ https://issues.apache.org/jira/browse/JENA-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690638#comment-16690638 ] ASF GitHub Bot commented on JENA-1635: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/490 > Invalid Automatic-Module-Names in fuseki2 modules > - > > Key: JENA-1635 > URL: https://issues.apache.org/jira/browse/JENA-1635 > Project: Apache Jena > Issue Type: Improvement > Components: Fuseki >Affects Versions: Jena 3.9.0 >Reporter: Aaron Coburn >Assignee: Aaron Coburn >Priority: Major > Fix For: Jena 3.10.0 > > > The maven configuration for some of the fuseki2 modules produces > syntactically invalid Automatic-Module-Name values (dashes are not permitted). > For instance, org.apache.jena.jena-fuseki-main would need to be changed to > org.apache.jena.fuseki2.main -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1623) Fuseki: Provide server and service access control.
[ https://issues.apache.org/jira/browse/JENA-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690637#comment-16690637 ] ASF GitHub Bot commented on JENA-1623: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/486 > Fuseki: Provide server and service access control. > -- > > Key: JENA-1623 > URL: https://issues.apache.org/jira/browse/JENA-1623 > Project: Apache Jena > Issue Type: Task > Components: Fuseki >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Major > Fix For: Jena 3.10.0 > > > Provide password-controlled access to server as whole and also on a > per-service basis. > This should include "any logged in user" as well as named users. > This goes along JENA-1595 which is graph-level access control - that already > assumes authentication to get the user. > This is for Fuseki main, not Fuseki webapp. Fuseki webapp is suitable when > the webapp container (e.g. tomcat) is providing the authentication and access > control. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1630) store literals only once in lucene docs for jena-text w/ multilingual configs
[ https://issues.apache.org/jira/browse/JENA-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689910#comment-16689910 ] ASF GitHub Bot commented on JENA-1630: -- Github user xristy commented on the issue: https://github.com/apache/jena/pull/489 Odd. Here's what I see on this page:  In any event I went through the procedure for PR #491 and realized that after the ``git merge --squash`` I should have done a commit. I'm pretty sure that's why the the unmerged commits. indication. > store literals only once in lucene docs for jena-text w/ multilingual configs > - > > Key: JENA-1630 > URL: https://issues.apache.org/jira/browse/JENA-1630 > Project: Apache Jena > Issue Type: Improvement > Components: Text >Affects Versions: Jena 3.9.0 >Reporter: Code Ferret >Assignee: Code Ferret >Priority: Major > Labels: easyfix, performance, pull-request-available > Fix For: Jena 3.10.0 > > > We can save some space in the Lucene db for jena-text when using multilingual > configurations by only storing the incoming literal once rather than for each > field's language tag variant. > A PR is ready -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1630) store literals only once in lucene docs for jena-text w/ multilingual configs
[ https://issues.apache.org/jira/browse/JENA-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689897#comment-16689897 ] ASF GitHub Bot commented on JENA-1630: -- Github user afs commented on the issue: https://github.com/apache/jena/pull/489 I don't see that message. May be it has to do with how the Apache master sync's with the GH mirror. The commit message with the close happens first, while the commits themselves haven't yet fully gone into the repo. > store literals only once in lucene docs for jena-text w/ multilingual configs > - > > Key: JENA-1630 > URL: https://issues.apache.org/jira/browse/JENA-1630 > Project: Apache Jena > Issue Type: Improvement > Components: Text >Affects Versions: Jena 3.9.0 >Reporter: Code Ferret >Assignee: Code Ferret >Priority: Major > Labels: easyfix, performance, pull-request-available > Fix For: Jena 3.10.0 > > > We can save some space in the Lucene db for jena-text when using multilingual > configurations by only storing the incoming literal once rather than for each > field's language tag variant. > A PR is ready -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1630) store literals only once in lucene docs for jena-text w/ multilingual configs
[ https://issues.apache.org/jira/browse/JENA-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689814#comment-16689814 ] ASF GitHub Bot commented on JENA-1630: -- Github user xristy commented on the issue: https://github.com/apache/jena/pull/489 Thanks Andy. I see now that I haven't been pulling the PR from github. I just need to replace steps 11-12 & 14 above by: 11) ``git pull github-jena pull/489/head --no-ff`` w/ the appropriate comment info and then continue w/ testing and the push to ``apache-jena``. The [Commit Workflow page](https://cwiki.apache.org/confluence/display/JENA/Commit+Workflow+for+Github-ASF) is silent about what _local_ branch should be used, but it seems that master would be appropriate. I was referring to the _Closed message_ at the bottom of the PR page just below the last comment > store literals only once in lucene docs for jena-text w/ multilingual configs > - > > Key: JENA-1630 > URL: https://issues.apache.org/jira/browse/JENA-1630 > Project: Apache Jena > Issue Type: Improvement > Components: Text >Affects Versions: Jena 3.9.0 >Reporter: Code Ferret >Assignee: Code Ferret >Priority: Major > Labels: easyfix, performance, pull-request-available > Fix For: Jena 3.10.0 > > > We can save some space in the Lucene db for jena-text when using multilingual > configurations by only storing the incoming literal once rather than for each > field's language tag variant. > A PR is ready -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1635) Invalid Automatic-Module-Names in fuseki2 modules
[ https://issues.apache.org/jira/browse/JENA-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689771#comment-16689771 ] ASF GitHub Bot commented on JENA-1635: -- Github user acoburn commented on the issue: https://github.com/apache/jena/pull/490 @afs feel free to pull this into #486. I used `fuseki2` because that's what was used [here](https://github.com/apache/jena/blob/master/jena-fuseki2/pom.xml#L57), but I'd also prefer just `fuseki`, as you suggest. > Invalid Automatic-Module-Names in fuseki2 modules > - > > Key: JENA-1635 > URL: https://issues.apache.org/jira/browse/JENA-1635 > Project: Apache Jena > Issue Type: Improvement > Components: Fuseki >Affects Versions: Jena 3.9.0 >Reporter: Aaron Coburn >Assignee: Aaron Coburn >Priority: Major > Fix For: Jena 3.10.0 > > > The maven configuration for some of the fuseki2 modules produces > syntactically invalid Automatic-Module-Name values (dashes are not permitted). > For instance, org.apache.jena.jena-fuseki-main would need to be changed to > org.apache.jena.fuseki2.main -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1630) store literals only once in lucene docs for jena-text w/ multilingual configs
[ https://issues.apache.org/jira/browse/JENA-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689762#comment-16689762 ] ASF GitHub Bot commented on JENA-1630: -- Github user afs commented on the issue: https://github.com/apache/jena/pull/489 Where do you get "unmerged commits"? Just specualtion: The workflow at https://cwiki.apache.org/confluence/display/JENA/Commit+Workflow+for+Github-ASF has the PR pulled from the github PR. Is that happening in the sequence above? > store literals only once in lucene docs for jena-text w/ multilingual configs > - > > Key: JENA-1630 > URL: https://issues.apache.org/jira/browse/JENA-1630 > Project: Apache Jena > Issue Type: Improvement > Components: Text >Affects Versions: Jena 3.9.0 >Reporter: Code Ferret >Assignee: Code Ferret >Priority: Major > Labels: easyfix, performance, pull-request-available > Fix For: Jena 3.10.0 > > > We can save some space in the Lucene db for jena-text when using multilingual > configurations by only storing the incoming literal once rather than for each > field's language tag variant. > A PR is ready -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1635) Invalid Automatic-Module-Names in fuseki2 modules
[ https://issues.apache.org/jira/browse/JENA-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689705#comment-16689705 ] ASF GitHub Bot commented on JENA-1635: -- Github user afs commented on the issue: https://github.com/apache/jena/pull/490 PR #473 touches on these modules. Do you mind if I merge this PR into PR #473? And "fuseki", not "fuseki2" as Fuseki1 is now well and truly legacy only? > Invalid Automatic-Module-Names in fuseki2 modules > - > > Key: JENA-1635 > URL: https://issues.apache.org/jira/browse/JENA-1635 > Project: Apache Jena > Issue Type: Improvement > Components: Fuseki >Affects Versions: Jena 3.9.0 >Reporter: Aaron Coburn >Assignee: Aaron Coburn >Priority: Major > Fix For: Jena 3.10.0 > > > The maven configuration for some of the fuseki2 modules produces > syntactically invalid Automatic-Module-Name values (dashes are not permitted). > For instance, org.apache.jena.jena-fuseki-main would need to be changed to > org.apache.jena.fuseki2.main -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1635) Invalid Automatic-Module-Names in fuseki2 modules
[ https://issues.apache.org/jira/browse/JENA-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689655#comment-16689655 ] ASF GitHub Bot commented on JENA-1635: -- GitHub user acoburn opened a pull request: https://github.com/apache/jena/pull/490 JENA-1635 Fix invalid Automatic-Module-Name values The jena-fuseki-access, jena-fuseki-core and jena-fuseki-main modules have invalid data for Automatic-Module-Name. This aligns the data from those modules with the existing fuseki2 module. You can merge this pull request into a Git repository by running: $ git pull https://github.com/acoburn/jena JENA-1635 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/490.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #490 commit 24742db2d697def1057b27a0d3f29300185bac84 Author: Aaron Coburn Date: 2018-11-16T16:43:40Z JENA-1635 Fix invalid Automatic-Module-Name values The jena-fuseki-access, jena-fuseki-core and jena-fuseki-main modules have invalid data for Automatic-Module-Name. This aligns the data from those modules with the existing fuseki2 module. > Invalid Automatic-Module-Names in fuseki2 modules > - > > Key: JENA-1635 > URL: https://issues.apache.org/jira/browse/JENA-1635 > Project: Apache Jena > Issue Type: Improvement > Components: Fuseki >Affects Versions: Jena 3.9.0 >Reporter: Aaron Coburn >Priority: Major > Fix For: Jena 3.10.0 > > > The maven configuration for some of the fuseki2 modules produces > syntactically invalid Automatic-Module-Name values (dashes are not permitted). > For instance, org.apache.jena.jena-fuseki-main would need to be changed to > org.apache.jena.fuseki2.main -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1630) store literals only once in lucene docs for jena-text w/ multilingual configs
[ https://issues.apache.org/jira/browse/JENA-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689553#comment-16689553 ] ASF GitHub Bot commented on JENA-1630: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/489 > store literals only once in lucene docs for jena-text w/ multilingual configs > - > > Key: JENA-1630 > URL: https://issues.apache.org/jira/browse/JENA-1630 > Project: Apache Jena > Issue Type: Improvement > Components: Text >Affects Versions: Jena 3.9.0 >Reporter: Code Ferret >Assignee: Code Ferret >Priority: Major > Labels: easyfix, performance, pull-request-available > Fix For: Jena 3.10.0 > > > We can save some space in the Lucene db for jena-text when using multilingual > configurations by only storing the incoming literal once rather than for each > field's language tag variant. > A PR is ready -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1630) store literals only once in lucene docs for jena-text w/ multilingual configs
[ https://issues.apache.org/jira/browse/JENA-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686783#comment-16686783 ] ASF GitHub Bot commented on JENA-1630: -- Github user xristy commented on the issue: https://github.com/apache/jena/pull/489 @rvesse, that's correct. Some of our configurations have 4 or 5 language tagged fields for different encodings, e.g., sa-x-iast, sa-alalc97, sa-x-aux-ndia, an so forth. Our dataset of ~33M triples shows a savings in the Lucene index of ~15% > store literals only once in lucene docs for jena-text w/ multilingual configs > - > > Key: JENA-1630 > URL: https://issues.apache.org/jira/browse/JENA-1630 > Project: Apache Jena > Issue Type: Improvement > Components: Text >Affects Versions: Jena 3.9.0 >Reporter: Code Ferret >Assignee: Code Ferret >Priority: Major > Labels: easyfix, performance, pull-request-available > Fix For: Jena 3.10.0 > > > We can save some space in the Lucene db for jena-text when using multilingual > configurations by only storing the incoming literal once rather than for each > field's language tag variant. > A PR is ready -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1630) store literals only once in lucene docs for jena-text w/ multilingual configs
[ https://issues.apache.org/jira/browse/JENA-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686755#comment-16686755 ] ASF GitHub Bot commented on JENA-1630: -- Github user rvesse commented on the issue: https://github.com/apache/jena/pull/489 So basically this is just avoiding redundantly storing the literal value multiple times. The actual literal value is always stored at least once but may be indexed multiple times in many non-stored fields with different analysers for different languages? > store literals only once in lucene docs for jena-text w/ multilingual configs > - > > Key: JENA-1630 > URL: https://issues.apache.org/jira/browse/JENA-1630 > Project: Apache Jena > Issue Type: Improvement > Components: Text >Affects Versions: Jena 3.9.0 >Reporter: Code Ferret >Assignee: Code Ferret >Priority: Major > Labels: easyfix, performance, pull-request-available > Fix For: Jena 3.10.0 > > > We can save some space in the Lucene db for jena-text when using multilingual > configurations by only storing the incoming literal once rather than for each > field's language tag variant. > A PR is ready -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1630) store literals only once in lucene docs for jena-text w/ multilingual configs
[ https://issues.apache.org/jira/browse/JENA-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686726#comment-16686726 ] ASF GitHub Bot commented on JENA-1630: -- GitHub user xristy opened a pull request: https://github.com/apache/jena/pull/489 Merged store literals once for JENA-1630 Store literals only once per Lucene document for multilingual jena-text configurations. Include lucene-backward-codecs dependency for jena/fuseki installs with Lucene indexes older than Lucene 7.x You can merge this pull request into a Git repository by running: $ git pull https://github.com/BuddhistDigitalResourceCenter/jena JENA-1630-store-literals-once Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/489.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #489 commit d12919e3e4c849ddec2ada4af08cc5afe04cf4f6 Author: Code Ferret Date: 2018-11-14T15:31:11Z Merged ReduceLuceneIndex > store literals only once in lucene docs for jena-text w/ multilingual configs > - > > Key: JENA-1630 > URL: https://issues.apache.org/jira/browse/JENA-1630 > Project: Apache Jena > Issue Type: Improvement > Components: Text >Affects Versions: Jena 3.9.0 >Reporter: Code Ferret >Assignee: Code Ferret >Priority: Major > Labels: easyfix, performance, pull-request-available > Fix For: Jena 3.10.0 > > > We can save some space in the Lucene db for jena-text when using multilingual > configurations by only storing the incoming literal once rather than for each > field's language tag variant. > A PR is ready -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1621) Upgrade Lucene to 7.5.x
[ https://issues.apache.org/jira/browse/JENA-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677222#comment-16677222 ] ASF GitHub Bot commented on JENA-1621: -- Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/488 I've seen that happen when I've forgotten to rebase over master before merging, but I don't know if that's what's happening here... > Upgrade Lucene to 7.5.x > --- > > Key: JENA-1621 > URL: https://issues.apache.org/jira/browse/JENA-1621 > Project: Apache Jena > Issue Type: Improvement > Components: Text >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1621) Upgrade Lucene to 7.5.x
[ https://issues.apache.org/jira/browse/JENA-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677200#comment-16677200 ] ASF GitHub Bot commented on JENA-1621: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/488 > Upgrade Lucene to 7.5.x > --- > > Key: JENA-1621 > URL: https://issues.apache.org/jira/browse/JENA-1621 > Project: Apache Jena > Issue Type: Improvement > Components: Text >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1621) Upgrade Lucene to 7.5.x
[
https://issues.apache.org/jira/browse/JENA-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676650#comment-16676650
]
ASF GitHub Bot commented on JENA-1621:
--
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/488#discussion_r231081048
--- Diff: jena-text-es/pom.xml ---
@@ -140,12 +140,13 @@
com.github.alexcojocaru
elasticsearch-maven-plugin
-5.2
+6.8
elasticsearch
9500
9400
${es.startup.timeout}
+ 6.4.2
--- End diff --
Can this be the property ver.elasticsearch?
> Upgrade Lucene to 7.5.x
> ---
>
> Key: JENA-1621
> URL: https://issues.apache.org/jira/browse/JENA-1621
> Project: Apache Jena
> Issue Type: Improvement
> Components: Text
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1621) Upgrade Lucene to 7.5.x
[ https://issues.apache.org/jira/browse/JENA-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675756#comment-16675756 ] ASF GitHub Bot commented on JENA-1621: -- GitHub user xristy opened a pull request: https://github.com/apache/jena/pull/488 Merged Lucene upgrade. This resolves JENA-1621 Updates ``jena-text`` and ``jena-text-es`` to **Lucene 7.4.0** and **ElasticSearch 6.4.2** You can merge this pull request into a Git repository by running: $ git pull https://github.com/BuddhistDigitalResourceCenter/jena JENA-1621-Lucene-7.4.0 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/488.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #488 commit 63525085be7927567a8d963586b15269416e1b90 Author: Code Ferret Date: 2018-11-05T20:56:14Z Merged Lucene upgrade. This resolves JENA-1621 > Upgrade Lucene to 7.5.x > --- > > Key: JENA-1621 > URL: https://issues.apache.org/jira/browse/JENA-1621 > Project: Apache Jena > Issue Type: Improvement > Components: Text >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1624) Update plugin versions
[ https://issues.apache.org/jira/browse/JENA-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675019#comment-16675019 ] ASF GitHub Bot commented on JENA-1624: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/487 > Update plugin versions > -- > > Key: JENA-1624 > URL: https://issues.apache.org/jira/browse/JENA-1624 > Project: Apache Jena > Issue Type: Task > Components: Build >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Major > Fix For: Jena 3.10.0 > > > and fix for SUREFIRE-1588 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1624) Update plugin versions
[ https://issues.apache.org/jira/browse/JENA-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674484#comment-16674484 ] ASF GitHub Bot commented on JENA-1624: -- GitHub user afs opened a pull request: https://github.com/apache/jena/pull/487 JENA-1624: Update plugins; surefire workaround You can merge this pull request into a Git repository by running: $ git pull https://github.com/afs/jena plugin-updates Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/487.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #487 commit b1e73bad32dba795fd9c190b3fcc702024196d57 Author: Andy Seaborne Date: 2018-11-04T19:32:34Z JENA-1624: Update plugins; surefire workaround > Update plugin versions > -- > > Key: JENA-1624 > URL: https://issues.apache.org/jira/browse/JENA-1624 > Project: Apache Jena > Issue Type: Task > Components: Build >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Major > Fix For: Jena 3.10.0 > > > and fix for SUREFIRE-1588 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1623) Fuseki: Provide server and service access control.
[
https://issues.apache.org/jira/browse/JENA-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674211#comment-16674211
]
ASF GitHub Bot commented on JENA-1623:
--
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/486
JENA-1623 : Fuseki server and service access control
Includes authentication support. This is packaging up the Jetty facilities
to make them more accessible for typical usage in Fuseki.
Not included in this PR: https support (again, packaging of what is
available in Jetty).
With JENA-1595, the access control options are:
* server access control by user/password
* per-service (i.e. `rdf:type fuseki:Service`) access control
* graph-visibility level control for a read-only dataset; SPARQL Query,
including FROM/FROM NAMED, and Graph Store Protocol, including (it can be
updated by a different service, different access control, sharing the same
database). Works for all storage; it works efficiently with TDB1 and TDB2 to
filter quads coming out of the database.
Not provided (yet):
* endpoint access control (i.e. a particular operation within a service)
* per graph update (graph level access currently blocks update)
At the time of PR submission: there is one missing case yet to be done
which `SELECT * FROM { ?s ?p ?o }` and other special
graphs. The more correct/useful `GRAPH ` does work
correctly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena fuseki-access
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/486.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #486
commit df9f849122f18fc28d7ffa5704fcd0fb653b18cd
Author: Andy Seaborne
Date: 2018-10-31T10:33:01Z
Removed deprecated constructors in favour of the builder pattern.
commit 0a12d4e446c21b2272b1356cd204dfa52793286f
Author: Andy Seaborne
Date: 2018-11-01T09:37:10Z
Refactor the do-nothing DatasetGraphs.
commit 616072ed8547a5a353913556b8d70a27423ddd47
Author: Andy Seaborne
Date: 2018-11-01T18:46:06Z
Tidy up and maintenance.
commit 2c46f9af17585530902c949ea3220639e3243016
Author: Andy Seaborne
Date: 2018-11-01T18:46:56Z
Cope with non-existent graphs in "GRAPH ?g" loop.
commit 213677f50cdabb2b29f561d9dace11e1d8742ebd
Author: Andy Seaborne
Date: 2018-11-01T19:55:42Z
JENA-1594: Add authentication support (digest or basic).
Add support for FROM handling with graph-access-controlled datasets.
Code cleaning.
commit 35fa63eaece862271c661fb6e0bf4df2509d4037
Author: Andy Seaborne
Date: 2018-11-01T20:44:50Z
Merge branch 'master' into fuseki-access
Overlapping changes in SPARQL_QueryGeneral.java
commit 3790008a014ce6bf34961e052f0a11f95e3f1051
Author: Andy Seaborne
Date: 2018-11-02T12:03:31Z
Remove unused import.
commit 52f4edd7e5e1d633a84e37596c8ee0815425c0b0
Author: Andy Seaborne
Date: 2018-11-02T14:46:34Z
Maintainence.
commit 7f72fbf62a6b1268f42743bafd5f31ddb9f36c20
Author: Andy Seaborne
Date: 2018-11-02T17:15:04Z
JENA-1594: Add filtering for all operations.
commit d12b6e3fda14f8400144b2a2d5c492c6c2f1c536
Author: Andy Seaborne
Date: 2018-11-02T17:21:19Z
JENA-1623: Service authorization by HTTP authentication.
commit 2bb97e4e70a1fba5663772796a50cca2502860c7
Author: Andy Seaborne
Date: 2018-11-02T18:17:58Z
Refactor parsing and processing Fuseki configuration files.
commit b4bc12a9c6f2070e84ca55a526eeab1dfa675846
Author: Andy Seaborne
Date: 2018-11-02T18:18:18Z
Rename FusekiSystem as FusekiWebapp.
commit c66c263cf92bc3fee3b86146628b175745e4b8bb
Author: Andy Seaborne
Date: 2018-11-03T16:57:13Z
JENA-1623: Server authorization by HTTP authentication.
> Fuseki: Provide server and service access control.
> --
>
> Key: JENA-1623
> URL: https://issues.apache.org/jira/browse/JENA-1623
> Project: Apache Jena
> Issue Type: Task
> Components: Fuseki
>Affects Versions: Jena 3.9.0
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Major
> Fix For: Jena 3.10.0
>
>
> Provide password-controlled access to server as whole and also on a
> per-service basis.
> This should include "any logged in user" as well as named users.
> This goes along JENA-1595 which is graph-level access control - that already
> assumes authentication to get the user.
> This is for Fuseki main, not Fuseki webapp. Fuseki webapp is suitable when
> the webapp container (e.g. tomcat) is providing the authentication and access
> control.
--
This message was sent by Atlassian JIRA
[jira] [Commented] (JENA-1620) Protocol timeouts setting improvements.
[ https://issues.apache.org/jira/browse/JENA-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672106#comment-16672106 ] ASF GitHub Bot commented on JENA-1620: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/483 > Protocol timeouts setting improvements. > --- > > Key: JENA-1620 > URL: https://issues.apache.org/jira/browse/JENA-1620 > Project: Apache Jena > Issue Type: Improvement >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Major > Fix For: Jena 3.10.0 > > > * Should accept "last,last" syntax > * Should respect the server/dataset existing limits and only be able to > reduce them. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1622) Jena-text highlight feature fails for complex multi-language configs
[
https://issues.apache.org/jira/browse/JENA-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671874#comment-16671874
]
ASF GitHub Bot commented on JENA-1622:
--
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/485
> Jena-text highlight feature fails for complex multi-language configs
>
>
> Key: JENA-1622
> URL: https://issues.apache.org/jira/browse/JENA-1622
> Project: Apache Jena
> Issue Type: Bug
> Components: Text
>Affects Versions: Jena 3.9.0
>Reporter: Code Ferret
>Assignee: Code Ferret
>Priority: Minor
> Labels: pull-request-available
> Fix For: Jena 3.10.0
>
>
> The recently released jena-text Highlight feature fails to highlight properly
> when using the {{text:auxIndex}} feature for _lenient_ searches.
> A PR is ready will be issued today.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1622) Jena-text highlight feature fails for complex multi-language configs
[
https://issues.apache.org/jira/browse/JENA-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667619#comment-16667619
]
ASF GitHub Bot commented on JENA-1622:
--
GitHub user xristy opened a pull request:
https://github.com/apache/jena/pull/485
Merged hilightdebug
Fix JENA-1622
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BuddhistDigitalResourceCenter/jena
JENA-1622-hilightbug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/485.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #485
commit 3175cbe6db9c7c85f31fa859dd73a0097e8249fc
Author: Chris Tomlinson
Date: 2018-10-29T19:04:50Z
Merged hilightdebug
> Jena-text highlight feature fails for complex multi-language configs
>
>
> Key: JENA-1622
> URL: https://issues.apache.org/jira/browse/JENA-1622
> Project: Apache Jena
> Issue Type: Bug
> Components: Text
>Affects Versions: Jena 3.9.0
>Reporter: Code Ferret
>Assignee: Code Ferret
>Priority: Minor
> Labels: pull-request-available
> Fix For: Jena 3.10.0
>
>
> The recently released jena-text Highlight feature fails to highlight properly
> when using the {{text:auxIndex}} feature for _lenient_ searches.
> A PR is ready will be issued today.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1620) Protocol timeouts setting improvements.
[ https://issues.apache.org/jira/browse/JENA-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1135#comment-1135 ] ASF GitHub Bot commented on JENA-1620: -- GitHub user afs opened a pull request: https://github.com/apache/jena/pull/483 JENA-1620: Protocol timeouts You can merge this pull request into a Git repository by running: $ git pull https://github.com/afs/jena fuseki-timeout Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/483.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #483 commit d6645286a01d680b1572dab5b015dcdccedf7041 Author: Andy Seaborne Date: 2018-10-26T14:00:32Z JENA-1620: Clean up timeout processing. commit 7d2213079c5f86a5c0b2ec5a8490c227e8232299 Author: Andy Seaborne Date: 2018-10-26T14:35:27Z JENA-1620: Support N,M (in seconds) in the HTTP protocol setting. > Protocol timeouts setting improvements. > --- > > Key: JENA-1620 > URL: https://issues.apache.org/jira/browse/JENA-1620 > Project: Apache Jena > Issue Type: Improvement >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Major > Fix For: Jena 3.10.0 > > > * Should accept "last,last" syntax > * Should respect the server/dataset existing limits and only be able to > reduce them. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1619) TransactionException for large query results
[
https://issues.apache.org/jira/browse/JENA-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16664014#comment-16664014
]
ASF GitHub Bot commented on JENA-1619:
--
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/482
> TransactionException for large query results
>
>
> Key: JENA-1619
> URL: https://issues.apache.org/jira/browse/JENA-1619
> Project: Apache Jena
> Issue Type: Bug
> Components: TDB2
>Affects Versions: Jena 3.9.0
> Environment: MacOS 10.14
> Java 1.8.0_161 (Oracle)
>Reporter: Damien Obrist
>Priority: Major
> Attachments: jena-transaction-exception-master.zip
>
>
> When querying a TDB2 dataset, I'm observing a suspicious
> {{TransactionException}}, even though the query results have been copied so
> they can be used outside of a transaction. The exception only seems to occur
> when there are many results.
> h3. Reproduction steps
> * Sample dataset containing 1'000'000 triples
> * Query all triples:
> {code:java}
> SELECT * WHERE { ?s ?p ?o . }{code}
> * Copy query results for use outside of transaction:
> {code:java}
> ResultSetFactory.copyResults(queryExecution.execSelect());{code}
> * Get any variable of the first result
> All variables are {{null}} and the log shows the following exception:
> {noformat}
> org.apache.jena.dboe.transaction.txn.TransactionException: Not in a
> transaction
> at
> org.apache.jena.dboe.transaction.txn.TransactionalComponentLifecycle.checkTxn(TransactionalComponentLifecycle.java:417)
> at
> org.apache.jena.dboe.trans.data.TransBinaryDataFile.read(TransBinaryDataFile.java:182)
> at
> org.apache.jena.tdb2.store.nodetable.TReadAppendFileTransport.read(TReadAppendFileTransport.java:71)
> at org.apache.thrift.transport.TTransport.readAll(TTransport.java:86)
> at
> org.apache.thrift.protocol.TCompactProtocol.readByte(TCompactProtocol.java:637)
> at
> org.apache.thrift.protocol.TCompactProtocol.readFieldBegin(TCompactProtocol.java:543)
> at org.apache.thrift.TUnion$TUnionStandardScheme.read(TUnion.java:222)
> at org.apache.thrift.TUnion$TUnionStandardScheme.read(TUnion.java:213)
> at org.apache.thrift.TUnion.read(TUnion.java:138)
> at
> org.apache.jena.tdb2.store.nodetable.NodeTableTRDF.readNodeFromTable(NodeTableTRDF.java:80)
> at
> org.apache.jena.tdb2.store.nodetable.NodeTableNative._retrieveNodeByNodeId(NodeTableNative.java:103)
> at
> org.apache.jena.tdb2.store.nodetable.NodeTableNative.getNodeForNodeId(NodeTableNative.java:52)
> at
> org.apache.jena.tdb2.store.nodetable.NodeTableCache._retrieveNodeByNodeId(NodeTableCache.java:197)
> at
> org.apache.jena.tdb2.store.nodetable.NodeTableCache.getNodeForNodeId(NodeTableCache.java:108)
> at
> org.apache.jena.tdb2.store.nodetable.NodeTableWrapper.getNodeForNodeId(NodeTableWrapper.java:52)
> at
> org.apache.jena.tdb2.store.nodetable.NodeTableInline.getNodeForNodeId(NodeTableInline.java:66)
> at org.apache.jena.tdb2.solver.BindingTDB.get1(BindingTDB.java:126)
> at
> org.apache.jena.sparql.engine.binding.BindingBase.get(BindingBase.java:104)
> at org.apache.jena.sparql.core.ResultBinding._get(ResultBinding.java:57)
> at
> org.apache.jena.sparql.core.QuerySolutionBase.get(QuerySolutionBase.java:33)
> at TransactionException.main(TransactionException.java:27)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.codehaus.mojo.exec.ExecJavaMojo$1.run(ExecJavaMojo.java:282)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> I have created a minimal example available on
> [GitHub|https://github.com/dobrist/jena-transaction-exception] and attached
> to this issue.
> h3. Findings
> * The exception doesn't occur for smaller query results
> * This seems to be a regression as it works as expected with Jena 3.8.0
> * Using {{git bisect}} I have identified the commit where this starts to
> happen:
> [9a60253|https://github.com/apache/jena/commit/9a60253c00aec6763adbb0253588fe4dc0b484d4]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1619) TransactionException for large query results
[
https://issues.apache.org/jira/browse/JENA-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662346#comment-16662346
]
ASF GitHub Bot commented on JENA-1619:
--
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/482
JENA-1619: Completely detach results by copying a binding.
cd75e6c fixes the presenting problem.
c89ed12 removes a related non-working feature in TDB1/TDB2.
4dc260e is reformatting.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena binding-copy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/482.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #482
commit cd75e6c1597db5da1adf2eb3decd5bd59877b266
Author: Andy Seaborne
Date: 2018-10-24T13:31:36Z
JENA-1619: Completely detach a binding by doing a copy.
commit c89ed1238bcee69918e7aeedaf52637c66ff315c
Author: Andy Seaborne
Date: 2018-10-24T13:34:05Z
JENA-1619: Don't materialize bindings.
No need to materialize.
Bindings aren't safe outside a transaction anyway.
commit 4dc260eeb2f627f724f6a382f42819f3c9b51cd6
Author: Andy Seaborne
Date: 2018-10-24T13:34:26Z
Cleanup formatting.
> TransactionException for large query results
>
>
> Key: JENA-1619
> URL: https://issues.apache.org/jira/browse/JENA-1619
> Project: Apache Jena
> Issue Type: Bug
> Components: TDB2
>Affects Versions: Jena 3.9.0
> Environment: MacOS 10.14
> Java 1.8.0_161 (Oracle)
>Reporter: Damien Obrist
>Priority: Major
> Attachments: jena-transaction-exception-master.zip
>
>
> When querying a TDB2 dataset, I'm observing a suspicious
> {{TransactionException}}, even though the query results have been copied so
> they can be used outside of a transaction. The exception only seems to occur
> when there are many results.
> h3. Reproduction steps
> * Sample dataset containing 1'000'000 triples
> * Query all triples:
> {code:java}
> SELECT * WHERE { ?s ?p ?o . }{code}
> * Copy query results for use outside of transaction:
> {code:java}
> ResultSetFactory.copyResults(queryExecution.execSelect());{code}
> * Get any variable of the first result
> All variables are {{null}} and the log shows the following exception:
> {noformat}
> org.apache.jena.dboe.transaction.txn.TransactionException: Not in a
> transaction
> at
> org.apache.jena.dboe.transaction.txn.TransactionalComponentLifecycle.checkTxn(TransactionalComponentLifecycle.java:417)
> at
> org.apache.jena.dboe.trans.data.TransBinaryDataFile.read(TransBinaryDataFile.java:182)
> at
> org.apache.jena.tdb2.store.nodetable.TReadAppendFileTransport.read(TReadAppendFileTransport.java:71)
> at org.apache.thrift.transport.TTransport.readAll(TTransport.java:86)
> at
> org.apache.thrift.protocol.TCompactProtocol.readByte(TCompactProtocol.java:637)
> at
> org.apache.thrift.protocol.TCompactProtocol.readFieldBegin(TCompactProtocol.java:543)
> at org.apache.thrift.TUnion$TUnionStandardScheme.read(TUnion.java:222)
> at org.apache.thrift.TUnion$TUnionStandardScheme.read(TUnion.java:213)
> at org.apache.thrift.TUnion.read(TUnion.java:138)
> at
> org.apache.jena.tdb2.store.nodetable.NodeTableTRDF.readNodeFromTable(NodeTableTRDF.java:80)
> at
> org.apache.jena.tdb2.store.nodetable.NodeTableNative._retrieveNodeByNodeId(NodeTableNative.java:103)
> at
> org.apache.jena.tdb2.store.nodetable.NodeTableNative.getNodeForNodeId(NodeTableNative.java:52)
> at
> org.apache.jena.tdb2.store.nodetable.NodeTableCache._retrieveNodeByNodeId(NodeTableCache.java:197)
> at
> org.apache.jena.tdb2.store.nodetable.NodeTableCache.getNodeForNodeId(NodeTableCache.java:108)
> at
> org.apache.jena.tdb2.store.nodetable.NodeTableWrapper.getNodeForNodeId(NodeTableWrapper.java:52)
> at
> org.apache.jena.tdb2.store.nodetable.NodeTableInline.getNodeForNodeId(NodeTableInline.java:66)
> at org.apache.jena.tdb2.solver.BindingTDB.get1(BindingTDB.java:126)
> at
> org.apache.jena.sparql.engine.binding.BindingBase.get(BindingBase.java:104)
> at org.apache.jena.sparql.core.ResultBinding._get(ResultBinding.java:57)
> at
> org.apache.jena.sparql.core.QuerySolutionBase.get(QuerySolutionBase.java:33)
> at TransactionException.main(TransactionException.java:27)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>
[jira] [Commented] (JENA-1515) Values added to subQuery are stripped by QueryBuilder
[ https://issues.apache.org/jira/browse/JENA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649336#comment-16649336 ] ASF GitHub Bot commented on JENA-1515: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/479 > Values added to subQuery are stripped by QueryBuilder > - > > Key: JENA-1515 > URL: https://issues.apache.org/jira/browse/JENA-1515 > Project: Apache Jena > Issue Type: Bug > Components: QueryBuilder >Affects Versions: Jena 3.6.0, Jena 3.7.0 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > If values are added to a subQuery via the addValue methods the values are > stripped when the subquery is added to the outer query. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1515) Values added to subQuery are stripped by QueryBuilder
[
https://issues.apache.org/jira/browse/JENA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648494#comment-16648494
]
ASF GitHub Bot commented on JENA-1515:
--
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/479#discussion_r224923241
--- Diff:
jena-extras/jena-querybuilder/src/main/java/org/apache/jena/arq/querybuilder/rewriters/ElementRewriter.java
---
@@ -103,17 +103,13 @@ public void visit(ElementBind el) {
@Override
public void visit(ElementData el) {
ElementData retval = new ElementData();
- Iterator vars = el.getVars().iterator();
- Iterator bindings = el.getRows().iterator();
- while (vars.hasNext()) {
- Var v = vars.next();
- if (values.containsKey(v)) {
- bindings.next(); // skip the binding
- } else {
- retval.add(v);
- retval.add(rewrite(bindings.next()));
- }
+ for (Var v : el.getVars()) {
+ retval.add(v);
}
+ for (Binding binding : el.getRows())
+ {
--- End diff --
Code layout. Some of same-line { , some next line {
> Values added to subQuery are stripped by QueryBuilder
> -
>
> Key: JENA-1515
> URL: https://issues.apache.org/jira/browse/JENA-1515
> Project: Apache Jena
> Issue Type: Bug
> Components: QueryBuilder
>Affects Versions: Jena 3.6.0, Jena 3.7.0
>Reporter: Claude Warren
>Assignee: Claude Warren
>Priority: Minor
>
> If values are added to a subQuery via the addValue methods the values are
> stripped when the subquery is added to the outer query.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1515) Values added to subQuery are stripped by QueryBuilder
[
https://issues.apache.org/jira/browse/JENA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648471#comment-16648471
]
ASF GitHub Bot commented on JENA-1515:
--
Github user Claudenw commented on a diff in the pull request:
https://github.com/apache/jena/pull/479#discussion_r224920678
--- Diff:
jena-extras/jena-querybuilder/src/main/java/org/apache/jena/arq/querybuilder/rewriters/ElementRewriter.java
---
@@ -103,17 +103,13 @@ public void visit(ElementBind el) {
@Override
public void visit(ElementData el) {
ElementData retval = new ElementData();
- Iterator vars = el.getVars().iterator();
- Iterator bindings = el.getRows().iterator();
- while (vars.hasNext()) {
- Var v = vars.next();
- if (values.containsKey(v)) {
- bindings.next(); // skip the binding
- } else {
- retval.add(v);
- retval.add(rewrite(bindings.next()));
- }
+ for (Var v : el.getVars()) {
+ retval.add(v);
}
+ for (Binding binding : el.getRows())
+ {
--- End diff --
not sure what this comment means. The style of the looping is different
and has a different result.
> Values added to subQuery are stripped by QueryBuilder
> -
>
> Key: JENA-1515
> URL: https://issues.apache.org/jira/browse/JENA-1515
> Project: Apache Jena
> Issue Type: Bug
> Components: QueryBuilder
>Affects Versions: Jena 3.6.0, Jena 3.7.0
>Reporter: Claude Warren
>Assignee: Claude Warren
>Priority: Minor
>
> If values are added to a subQuery via the addValue methods the values are
> stripped when the subquery is added to the outer query.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1602) Update builder has no mechanism to add inserts or deletes based on model or triple collections
[ https://issues.apache.org/jira/browse/JENA-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648429#comment-16648429 ] ASF GitHub Bot commented on JENA-1602: -- Github user Claudenw commented on a diff in the pull request: https://github.com/apache/jena/pull/480#discussion_r224911048 --- Diff: jena-extras/jena-querybuilder/.gitignore --- @@ -0,0 +1 @@ +/.project_old --- End diff -- Checked in by error -- removed > Update builder has no mechanism to add inserts or deletes based on model or > triple collections > -- > > Key: JENA-1602 > URL: https://issues.apache.org/jira/browse/JENA-1602 > Project: Apache Jena > Issue Type: Improvement > Components: QueryBuilder >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > Currently the query builder allows insert/delete of single triples, this > change would be to accept a model as a collection of triples to > insert/delete. In addition a collection of could be > added/deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1612) TDB2 Loader Plan for large data/constrained RAM.
[ https://issues.apache.org/jira/browse/JENA-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646739#comment-16646739 ] ASF GitHub Bot commented on JENA-1612: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/478 > TDB2 Loader Plan for large data/constrained RAM. > > > Key: JENA-1612 > URL: https://issues.apache.org/jira/browse/JENA-1612 > Project: Apache Jena > Issue Type: Improvement > Components: TDB2 >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Minor > Fix For: Jena 3.10.0 > > > This adds an expeirmental loaded plan that is between purely sequential and > parallel schemes (phased or fully parallel). It may improve performance when > index size is larger than available RAM. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1610) Clear up version recording and reporting
[ https://issues.apache.org/jira/browse/JENA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643684#comment-16643684 ] ASF GitHub Bot commented on JENA-1610: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/477 > Clear up version recording and reporting > > > Key: JENA-1610 > URL: https://issues.apache.org/jira/browse/JENA-1610 > Project: Apache Jena > Issue Type: Bug >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Minor > Fix For: Jena 3.10.0 > > > 1/ There are two versions of the Metadata class. > 2/ No need to report subsystem versions for"–version" because they are all > the same. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1612) TDB2 Loader Plan for large data/constrained RAM.
[ https://issues.apache.org/jira/browse/JENA-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643676#comment-16643676 ] ASF GitHub Bot commented on JENA-1612: -- Github user afs commented on the issue: https://github.com/apache/jena/pull/478 Includes [JENA-1616](https://issues.apache.org/jira/browse/JENA-1616). Working on the JENA-1612 "light" loader, I noticed the logging output was not right for multiple file loads. > TDB2 Loader Plan for large data/constrained RAM. > > > Key: JENA-1612 > URL: https://issues.apache.org/jira/browse/JENA-1612 > Project: Apache Jena > Issue Type: Improvement > Components: TDB2 >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Minor > Fix For: Jena 3.10.0 > > > This adds an expeirmental loaded plan that is between purely sequential and > parallel schemes (phased or fully parallel). It may improve performance when > index size is larger than available RAM. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1615) Compaction leaks file descriptors
[
https://issues.apache.org/jira/browse/JENA-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16643243#comment-16643243
]
ASF GitHub Bot commented on JENA-1615:
--
GitHub user dobrist opened a pull request:
https://github.com/apache/jena/pull/481
JENA-1615 - Compaction leaks file descriptors
Close file channel when closing a block to release open file descriptors
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dobrist/jena JENA-1615
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/481.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #481
commit 199d4f267a70627b6a79f5a3081b37ca88224921
Author: damienobrist
Date: 2018-10-09T12:12:43Z
JENA-1615: Close file channel when closing a block
This is necessary to release open file descriptors
> Compaction leaks file descriptors
> -
>
> Key: JENA-1615
> URL: https://issues.apache.org/jira/browse/JENA-1615
> Project: Apache Jena
> Issue Type: Bug
> Components: Core, TDB2
>Affects Versions: Jena 3.8.0
> Environment: I reproduced the issue on the following environments:
> * OS / Java:
> ** MacOS 10.13.5
> Java 1.8.0_161 (Oracle)
> ** Debian 9.5
> Java 1.8.0_181 (OpenJDK)
> * Jena version 3.8.0
> * TDB2 mode: mapped
>Reporter: Damien Obrist
>Priority: Major
> Attachments: open_files_after_compaction_after_gc.png,
> open_files_after_compaction_before_gc.png, open_files_before_compaction.png
>
>
> h3. Context
> I'm using a TDB2 dataset in a long-running Scala application, in which the
> dataset gets compacted regularly. After compactions, the application removes
> the {{Data-}} folder of the previous generation. However, the
> corresponding disk space isn't properly returned back to the OS, but is still
> reported as being used by {{df}}. Indeed, {{lsof}} shows that the application
> keeps open file descriptors that point to the old generation's files. Only
> stopping / restarting the JVM frees the disk space for good.
> h3. Reproduction steps
> * Connect to an existing TDB2 dataset
> {code}
> val dataset = TDB2Factory.connectDataset("sample"){code}
> * Check open files
> [^open_files_before_compaction.png]
> * Compact the dataset
> {code}DatabaseMgr.compact(dataset.asDatasetGraph){code}
> * Check open files (before garbage collection)
> [^open_files_after_compaction_before_gc.png]
> * Check open files (after garbage collection)
> [^open_files_after_compaction_after_gc.png]
> The last sceenshot shows that, even after garbage collection, there are still
> open file descriptors pointing to the old generation {{Data-0001}}.
> h3. Impact
> Depending on how disk usage is being reported, this can be quite problematic.
> In our case, we're running on an OpenShift infrastructure with limited
> storage. After only a handful of compactions, the storage is considered full
> and cannot be used anymore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1515) Values added to subQuery are stripped by QueryBuilder
[
https://issues.apache.org/jira/browse/JENA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641101#comment-16641101
]
ASF GitHub Bot commented on JENA-1515:
--
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/479#discussion_r223217292
--- Diff:
jena-extras/jena-querybuilder/src/main/java/org/apache/jena/arq/querybuilder/rewriters/ElementRewriter.java
---
@@ -103,17 +103,13 @@ public void visit(ElementBind el) {
@Override
public void visit(ElementData el) {
ElementData retval = new ElementData();
- Iterator vars = el.getVars().iterator();
- Iterator bindings = el.getRows().iterator();
- while (vars.hasNext()) {
- Var v = vars.next();
- if (values.containsKey(v)) {
- bindings.next(); // skip the binding
- } else {
- retval.add(v);
- retval.add(rewrite(bindings.next()));
- }
+ for (Var v : el.getVars()) {
+ retval.add(v);
}
+ for (Binding binding : el.getRows())
+ {
--- End diff --
Minor: different style. There is more of this later.
> Values added to subQuery are stripped by QueryBuilder
> -
>
> Key: JENA-1515
> URL: https://issues.apache.org/jira/browse/JENA-1515
> Project: Apache Jena
> Issue Type: Bug
> Components: QueryBuilder
>Affects Versions: Jena 3.6.0, Jena 3.7.0
>Reporter: Claude Warren
>Assignee: Claude Warren
>Priority: Minor
>
> If values are added to a subQuery via the addValue methods the values are
> stripped when the subquery is added to the outer query.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JENA-1602) Update builder has no mechanism to add inserts or deletes based on model or triple collections
[ https://issues.apache.org/jira/browse/JENA-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641098#comment-16641098 ] ASF GitHub Bot commented on JENA-1602: -- Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/480#discussion_r223217155 --- Diff: jena-maven-tools/pom.xml --- @@ -20,7 +20,6 @@ 4.0.0 jena-maven-tools maven-plugin - 3.7.0-SNAPSHOT --- End diff -- There have been some problems in the past which is why the top POM has this module commented out. ``` ``` Does jena-maven-tools now work in the build? It would be great if it did. > Update builder has no mechanism to add inserts or deletes based on model or > triple collections > -- > > Key: JENA-1602 > URL: https://issues.apache.org/jira/browse/JENA-1602 > Project: Apache Jena > Issue Type: Improvement > Components: QueryBuilder >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > Currently the query builder allows insert/delete of single triples, this > change would be to accept a model as a collection of triples to > insert/delete. In addition a collection of could be > added/deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1602) Update builder has no mechanism to add inserts or deletes based on model or triple collections
[ https://issues.apache.org/jira/browse/JENA-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641100#comment-16641100 ] ASF GitHub Bot commented on JENA-1602: -- Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/480#discussion_r223217083 --- Diff: jena-extras/jena-querybuilder/.gitignore --- @@ -0,0 +1 @@ +/.project_old --- End diff -- This seem to be some issue, not for the codebase. > Update builder has no mechanism to add inserts or deletes based on model or > triple collections > -- > > Key: JENA-1602 > URL: https://issues.apache.org/jira/browse/JENA-1602 > Project: Apache Jena > Issue Type: Improvement > Components: QueryBuilder >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > Currently the query builder allows insert/delete of single triples, this > change would be to accept a model as a collection of triples to > insert/delete. In addition a collection of could be > added/deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1602) Update builder has no mechanism to add inserts or deletes based on model or triple collections
[ https://issues.apache.org/jira/browse/JENA-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641099#comment-16641099 ] ASF GitHub Bot commented on JENA-1602: -- Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/480#discussion_r223217180 --- Diff: jena-maven-tools/pom.xml --- @@ -30,7 +29,7 @@ org.apache.jena jena -3.7.0-SNAPSHOT +3.9.0-SNAPSHOT --- End diff -- Any reason not to have 3.10.0-SNAPSHOT? > Update builder has no mechanism to add inserts or deletes based on model or > triple collections > -- > > Key: JENA-1602 > URL: https://issues.apache.org/jira/browse/JENA-1602 > Project: Apache Jena > Issue Type: Improvement > Components: QueryBuilder >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > Currently the query builder allows insert/delete of single triples, this > change would be to accept a model as a collection of triples to > insert/delete. In addition a collection of could be > added/deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1602) Update builder has no mechanism to add inserts or deletes based on model or triple collections
[ https://issues.apache.org/jira/browse/JENA-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641073#comment-16641073 ] ASF GitHub Bot commented on JENA-1602: -- GitHub user Claudenw opened a pull request: https://github.com/apache/jena/pull/480 JENA-1602 - added mechanism to add inserts or deletes based on model or triple collections Fix for JENA-1602 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Claudenw/jena 1602-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/480.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #480 commit ee62b6540f795ddeb7ef7ee2eed2f2ac0d223d5b Author: Claude Warren Date: 2018-09-30T10:01:22Z closes JENA=1602 commit 311843dd22bc5ea2b11d10ae9011645f797c504d Author: Claude Warren Date: 2018-10-07T12:10:53Z Merge branch 'master' into 1602-fix commit 27691564775e52da291e3ae18c8b5989415ea9b8 Author: Claude Warren Date: 2018-10-07T14:09:56Z added license and removed dead code > Update builder has no mechanism to add inserts or deletes based on model or > triple collections > -- > > Key: JENA-1602 > URL: https://issues.apache.org/jira/browse/JENA-1602 > Project: Apache Jena > Issue Type: Improvement > Components: QueryBuilder >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > Currently the query builder allows insert/delete of single triples, this > change would be to accept a model as a collection of triples to > insert/delete. In addition a collection of could be > added/deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1515) Values added to subQuery are stripped by QueryBuilder
[ https://issues.apache.org/jira/browse/JENA-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641040#comment-16641040 ] ASF GitHub Bot commented on JENA-1515: -- GitHub user Claudenw opened a pull request: https://github.com/apache/jena/pull/479 1515/fix closes JENA-1515 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Claudenw/jena 1515/fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/479.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #479 commit 439f6ba0d690923cdcbb86c0780f6f8d0f5d6cd7 Author: Claude Warren Date: 2018-09-30T11:18:08Z added subquery values test commit a499b58a76704125f63a8407ffb2795b03e4d213 Author: Claude Warren Date: 2018-09-30T11:53:31Z fixes JENA-1515 commit e736bdfb1851a1069bd2dbd2d14c6eae1e259a97 Author: Claude Warren Date: 2018-10-07T11:24:17Z Merge branch 'master' into 1515/fix > Values added to subQuery are stripped by QueryBuilder > - > > Key: JENA-1515 > URL: https://issues.apache.org/jira/browse/JENA-1515 > Project: Apache Jena > Issue Type: Bug > Components: QueryBuilder >Affects Versions: Jena 3.6.0, Jena 3.7.0 >Reporter: Claude Warren >Assignee: Claude Warren >Priority: Minor > > If values are added to a subQuery via the addValue methods the values are > stripped when the subquery is added to the outer query. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1612) TDB2 Loader Plan for large data/constrained RAM.
[ https://issues.apache.org/jira/browse/JENA-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640765#comment-16640765 ] ASF GitHub Bot commented on JENA-1612: -- GitHub user afs opened a pull request: https://github.com/apache/jena/pull/478 JENA-1612: A lightly parallel loader plan. You can merge this pull request into a Git repository by running: $ git pull https://github.com/afs/jena load-light Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/478.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #478 commit f40e8a7bd95faab185858cb6c297606200d33bb7 Author: Andy Seaborne Date: 2018-10-06T16:15:22Z JENA-1612: A lightly parallel loader plan. > TDB2 Loader Plan for large data/constrained RAM. > > > Key: JENA-1612 > URL: https://issues.apache.org/jira/browse/JENA-1612 > Project: Apache Jena > Issue Type: Improvement > Components: TDB2 >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Minor > Fix For: Jena 3.10.0 > > > This adds an expeirmental loaded plan that is between purely sequential and > parallel schemes (phased or fully parallel). It may improve performance when > index size is larger than available RAM. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1610) Clear up version recording and reporting
[ https://issues.apache.org/jira/browse/JENA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640757#comment-16640757 ] ASF GitHub Bot commented on JENA-1610: -- GitHub user afs opened a pull request: https://github.com/apache/jena/pull/477 JENA-1610: One "Metadata" class. Command line tools: Report Jena version, not subsystems. You can merge this pull request into a Git repository by running: $ git pull https://github.com/afs/jena version-info Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/477.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #477 commit 1579f2d0a1e1bde3a342388fa461b5b6f690a840 Author: Andy Seaborne Date: 2018-10-06T15:51:56Z JENA-1610: One "Metadata" class. jena-cmd: Report Jena version, not subsystems. > Clear up version recording and reporting > > > Key: JENA-1610 > URL: https://issues.apache.org/jira/browse/JENA-1610 > Project: Apache Jena > Issue Type: Bug >Affects Versions: Jena 3.9.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Minor > > 1/ There are two versions of the Metadata class. > 2/ No need to report subsystem versions for"–version" because they are all > the same. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1609) Jena master does not build under JDK10
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637968#comment-16637968 ] ASF GitHub Bot commented on JENA-1609: -- Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/476 > Jena master does not build under JDK10 > -- > > Key: JENA-1609 > URL: https://issues.apache.org/jira/browse/JENA-1609 > Project: Apache Jena > Issue Type: Improvement > Components: Build, Documentation > Environment: Apache Maven 3.5.4 > (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00) > Maven home: /usr/local/Cellar/maven/3.5.4/libexec > Java version: 10.0.2, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" >Reporter: Lewis John McGibbney >Priority: Major > Fix For: Jena 3.9.0 > > > When I attempt build under Oracle JDK 10 there are several issues which cause > the build to fail. The following PR addresses these issues and enables me to > build and run Jena master under JDK 10. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1609) Jena master does not build under JDK10
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637414#comment-16637414 ] ASF GitHub Bot commented on JENA-1609: -- Github user afs commented on the issue: https://github.com/apache/jena/pull/474 I've picked out the .gitignore changes (not for `META-INF` - that's needed) and added them. > Jena master does not build under JDK10 > -- > > Key: JENA-1609 > URL: https://issues.apache.org/jira/browse/JENA-1609 > Project: Apache Jena > Issue Type: Improvement > Components: Build, Documentation > Environment: Apache Maven 3.5.4 > (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00) > Maven home: /usr/local/Cellar/maven/3.5.4/libexec > Java version: 10.0.2, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" >Reporter: Lewis John McGibbney >Priority: Major > Fix For: Jena 3.9.0 > > > When I attempt build under Oracle JDK 10 there are several issues which cause > the build to fail. The following PR addresses these issues and enables me to > build and run Jena master under JDK 10. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1609) Jena master does not build under JDK10
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637407#comment-16637407 ] ASF GitHub Bot commented on JENA-1609: -- Github user afs commented on the issue: https://github.com/apache/jena/pull/476 Looks good. A Java 10.0.2 build `mvn clean install` gets passed `jena-jdbc`: ``` [ERROR] Failed to execute goal on project jena-elephas-common: Could not resolve dependencies for project org.apache.jena:jena-elephas-common:jar:3.10.0-SNAPSHOT: Could not find artifact jdk.tools:jdk.tools:jar:1.6 at specified path /usr/lib/jvm/java-11-openjdk-amd64/../lib/tools.jar -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :jena-elephas-common ``` > Jena master does not build under JDK10 > -- > > Key: JENA-1609 > URL: https://issues.apache.org/jira/browse/JENA-1609 > Project: Apache Jena > Issue Type: Improvement > Components: Build, Documentation > Environment: Apache Maven 3.5.4 > (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00) > Maven home: /usr/local/Cellar/maven/3.5.4/libexec > Java version: 10.0.2, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" >Reporter: Lewis John McGibbney >Priority: Major > Fix For: Jena 3.9.0 > > > When I attempt build under Oracle JDK 10 there are several issues which cause > the build to fail. The following PR addresses these issues and enables me to > build and run Jena master under JDK 10. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1609) Jena master does not build under JDK10
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637369#comment-16637369 ] ASF GitHub Bot commented on JENA-1609: -- Github user lewismc closed the pull request at: https://github.com/apache/jena/pull/474 > Jena master does not build under JDK10 > -- > > Key: JENA-1609 > URL: https://issues.apache.org/jira/browse/JENA-1609 > Project: Apache Jena > Issue Type: Improvement > Components: Build, Documentation > Environment: Apache Maven 3.5.4 > (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00) > Maven home: /usr/local/Cellar/maven/3.5.4/libexec > Java version: 10.0.2, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" >Reporter: Lewis John McGibbney >Priority: Major > Fix For: Jena 3.9.0 > > > When I attempt build under Oracle JDK 10 there are several issues which cause > the build to fail. The following PR addresses these issues and enables me to > build and run Jena master under JDK 10. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1609) Jena master does not build under JDK10
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637368#comment-16637368 ] ASF GitHub Bot commented on JENA-1609: -- Github user lewismc commented on the issue: https://github.com/apache/jena/pull/474 Closing in favor of #476 > Jena master does not build under JDK10 > -- > > Key: JENA-1609 > URL: https://issues.apache.org/jira/browse/JENA-1609 > Project: Apache Jena > Issue Type: Improvement > Components: Build, Documentation > Environment: Apache Maven 3.5.4 > (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00) > Maven home: /usr/local/Cellar/maven/3.5.4/libexec > Java version: 10.0.2, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" >Reporter: Lewis John McGibbney >Priority: Major > Fix For: Jena 3.9.0 > > > When I attempt build under Oracle JDK 10 there are several issues which cause > the build to fail. The following PR addresses these issues and enables me to > build and run Jena master under JDK 10. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JENA-1609) Jena master does not build under JDK10
[ https://issues.apache.org/jira/browse/JENA-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637367#comment-16637367 ] ASF GitHub Bot commented on JENA-1609: -- Github user lewismc commented on the issue: https://github.com/apache/jena/pull/476 Tried it locally and apart from the -html Javadoc WARNING's this LGTM. @rvesse > Jena master does not build under JDK10 > -- > > Key: JENA-1609 > URL: https://issues.apache.org/jira/browse/JENA-1609 > Project: Apache Jena > Issue Type: Improvement > Components: Build, Documentation > Environment: Apache Maven 3.5.4 > (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00) > Maven home: /usr/local/Cellar/maven/3.5.4/libexec > Java version: 10.0.2, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" >Reporter: Lewis John McGibbney >Priority: Major > Fix For: Jena 3.9.0 > > > When I attempt build under Oracle JDK 10 there are several issues which cause > the build to fail. The following PR addresses these issues and enables me to > build and run Jena master under JDK 10. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
