buildbot success in on jmeter-nightly

2017-12-10 Thread buildbot 
The Buildbot has detected a restored build on builder jmeter-nightly while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-nightly/builds/867

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_1604_test_ubuntu

Build Reason: forced: by IRC user  on channel #asftest: testing rat 
upload
Build Source Stamp: HEAD
Blamelist: 

Build succeeded!

Sincerely,
 -The Buildbot

Re: BoundaryExtractor#extract method

2017-12-10 Thread Philippe Mouawad 
On Sun, Dec 10, 2017 at 1:05 PM, Felix Schumacher <
felix.schumac...@internetallee.de> wrote:

> Hi all,
>
> a few questions on the extract method.
>
> Does it have to be public? It seems to be called in
> extractMatchingStrings, only.
>

It wasn't initially. It was made public for RenderAsBoundaryExtractor the
Boundary renderer in View Results Tree

>
> If it stays public, shouldn't it have tests?
>
Yes

>
> Is the condition "matchNumber <= 0 || newFound != matchNumber" the correct
> one? What happens when found is given with a number bigger than
> matchNumber? Should we collect all matches? I think this should be
> "newFound < matchNumber", that way we extract at most matchNumber (-1)
> fragments.
>
Looks you're right. Feel free to fix it.
Thanks

>
> Felix
>
>


-- 
Cordialement.
Philippe Mouawad.

Re: Release a 4.0 (second try)

2017-12-10 Thread Philippe Mouawad 
Hello,
I was accessing the link on Mobile so couldn't zoom.
Now I see it.

Do windows owner reproduce the issue ?

On mac it looks good and on a Windows 10 I tested it was also good.
Regards

On Sun, Dec 10, 2017 at 2:46 PM, Ralf Roeber  wrote:

> Attached screen
>
> El 10 dic. 2017 2:07 p. m., "Rainer Jung" 
> escribió:
>
>> Hi Philippe,
>>
>> Am 10.12.2017 um 11:03 schrieb Philippe Mouawad:
>>
>>> Thanks but screenshot is still unreadable for me.
>>>
>>
>> I think that's just the resolution shown on that web site. When I look at
>> it, it shows a little plus sign and clicking on the image it enlarges it. I
>> can click multiple times until it looks readable, so the image resolution
>> is good.
>>
>> Regards,
>>
>> Rainer
>>
>> On Sunday, December 10, 2017, jmeter tea  wrote:
>>>
>>> Add new image:
 https://imgur.com/t35J8c3
 I selected a disable element and it can't be seen

 OS: Windows 7
 Screen Resolution: 1920 x 1080
 Java: 8

 On Sun, Dec 10, 2017 at 11:56 AM, Philippe Mouawad <
 philippe.moua...@gmail.com> wrote:

 Hi,
> The screenshot is bot very clear.
> Can you make it bigger and highlight what is bad ?
>
> Also what are you using :
> - OS
> - Screen definition
> - Java version
>
> Thank you
>
> On Sunday, December 10, 2017, jmeter tea  wrote:
>
> The disable/enable color are very similar and hard to distinguish
>>
> between

> them.
>> IMHO make enable element more whiter
>> Also when moving from Nimbus to Dracula the disabled elements can't be
>> seen. see https://imgur.com/37stPt9
>>
>> On Sun, Dec 10, 2017 at 11:07 AM, Philippe Mouawad <
>> p.moua...@ubik-ingenierie.com> wrote:
>>
>> Hello,
>>> I think we have now a stable version , I am not aware of any
>>>
>> remaining

> issue on nightly.
>>>
>>> So I propose that we release a new version before end of year.
>>>
>>> Thoughts ?
>>>
>>> Regards
>>> Philippe M.
>>> @philmdot
>>>
>>>
>>
>
> --
> Cordialement.
> Philippe Mouawad.
>



-- 
Cordialement.
Philippe Mouawad.

Menu item ordering

2017-12-10 Thread Graham Russell 
Hi all

Currently the menus are ordered alphabetically, which is fine for
small menus, and better than not at all for the large ones, however I
think we can do better.

If the menu has more than 4-5 items in it I think we should split it
up into chunks of 5-7 with the most popular (e.g. HTTP Request
Sampler) at the top. I hope this would ease a bit of RSI for users and
help improve the usability.

Any thoughts?

Having looked at the code it seems the menus are built by looking at
the classes, does adding an annotation with "sort order" and maybe
"group" make sense or is there a better way to dictate the order of
items in the menus?

Thanks

Graham

[GitHub] jmeter issue #354: Corrected spelling and spacing and some wording in messag...

2017-12-10 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/354
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/354?src=pr&el=h1) 
Report
> Merging 
[#354](https://codecov.io/gh/apache/jmeter/pull/354?src=pr&el=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/427907f9d2ca45f8077acf9398a140834d75e3bd?src=pr&el=desc)
 will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/354/graphs/tree.svg?width=650&token=6Q7CI1wFSh&height=150&src=pr)](https://codecov.io/gh/apache/jmeter/pull/354?src=pr&el=tree)

```diff
@@Coverage Diff@@
##  trunk #354   +/-   ##
=
  Coverage 58.19%   58.19%   
  Complexity1021010210   
=
  Files  1161 1161   
  Lines 7418974189   
  Branches   7322 7322   
=
  Hits  4317443174   
  Misses2851728517   
  Partials   2498 2498
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/354?src=pr&el=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...mpler/hc/JMeterPoolingClientConnectionManager.java](https://codecov.io/gh/apache/jmeter/pull/354/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL2hjL0pNZXRlclBvb2xpbmdDbGllbnRDb25uZWN0aW9uTWFuYWdlci5qYXZh)
 | `27.77% <0%> (-3.18%)` | `10% <0%> (-1%)` | |
| 
[...apache/jmeter/extractor/TestBoundaryExtractor.java](https://codecov.io/gh/apache/jmeter/pull/354/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL1Rlc3RCb3VuZGFyeUV4dHJhY3Rvci5qYXZh)
 | `97.88% <0%> (ø)` | `17% <0%> (ø)` | :arrow_down: |
| 
[...ocol/jms/org/apache/jmeter/protocol/jms/Utils.java](https://codecov.io/gh/apache/jmeter/pull/354/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2ptcy9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9qbXMvVXRpbHMuamF2YQ==)
 | `56.98% <0%> (+2.15%)` | `15% <0%> (ø)` | :arrow_down: |
| 
[...s/org/apache/jmeter/timers/PoissonRandomTimer.java](https://codecov.io/gh/apache/jmeter/pull/354/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdGltZXJzL1BvaXNzb25SYW5kb21UaW1lci5qYXZh)
 | `78.37% <0%> (+5.4%)` | `10% <0%> (+1%)` | :arrow_up: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/354?src=pr&el=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/354?src=pr&el=footer). Last 
update 
[427907f...060f658](https://codecov.io/gh/apache/jmeter/pull/354?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[GitHub] jmeter pull request #354: Corrected spelling and spacing and some wording in...

2017-12-10 Thread ham1 
GitHub user ham1 opened a pull request:

https://github.com/apache/jmeter/pull/354

Corrected spelling and spacing and some wording in messages



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ham1/jmeter messages

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/354.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #354


commit 060f658333ce14290cd1de8df951b47650933e9e
Author: Graham Russell 
Date:   2017-12-10T17:20:37Z

Corrected spelling and spacing and some wording




---

Jenkins build is back to normal : JMeter Ubuntu #338

2017-12-10 Thread Apache Jenkins Server 
See

Re: Release a 4.0 (second try)

2017-12-10 Thread Ralf Roeber 
Attached screen

El 10 dic. 2017 2:07 p. m., "Rainer Jung" 
escribió:

> Hi Philippe,
>
> Am 10.12.2017 um 11:03 schrieb Philippe Mouawad:
>
>> Thanks but screenshot is still unreadable for me.
>>
>
> I think that's just the resolution shown on that web site. When I look at
> it, it shows a little plus sign and clicking on the image it enlarges it. I
> can click multiple times until it looks readable, so the image resolution
> is good.
>
> Regards,
>
> Rainer
>
> On Sunday, December 10, 2017, jmeter tea  wrote:
>>
>> Add new image:
>>> https://imgur.com/t35J8c3
>>> I selected a disable element and it can't be seen
>>>
>>> OS: Windows 7
>>> Screen Resolution: 1920 x 1080
>>> Java: 8
>>>
>>> On Sun, Dec 10, 2017 at 11:56 AM, Philippe Mouawad <
>>> philippe.moua...@gmail.com> wrote:
>>>
>>> Hi,
 The screenshot is bot very clear.
 Can you make it bigger and highlight what is bad ?

 Also what are you using :
 - OS
 - Screen definition
 - Java version

 Thank you

 On Sunday, December 10, 2017, jmeter tea  wrote:

 The disable/enable color are very similar and hard to distinguish
>
 between
>>>
 them.
> IMHO make enable element more whiter
> Also when moving from Nimbus to Dracula the disabled elements can't be
> seen. see https://imgur.com/37stPt9
>
> On Sun, Dec 10, 2017 at 11:07 AM, Philippe Mouawad <
> p.moua...@ubik-ingenierie.com> wrote:
>
> Hello,
>> I think we have now a stable version , I am not aware of any
>>
> remaining
>>>
 issue on nightly.
>>
>> So I propose that we release a new version before end of year.
>>
>> Thoughts ?
>>
>> Regards
>> Philippe M.
>> @philmdot
>>
>>
>

 --
 Cordialement.
 Philippe Mouawad.

>>>

Build failed in Jenkins: JMeter Ubuntu #337

2017-12-10 Thread Apache Jenkins Server 
See 

--
[...truncated 148.92 KB...]
   [jmeter] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   [jmeter] SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/Bug50898.jmx
   [jmeter] Starting the test @ Sun Dec 10 13:15:08 UTC 2017 (1512911708506)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary =  2 in 00:00:01 =3.0/s Avg:   262 Min:   187 Max:  
 338 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sun Dec 10 13:15:09 UTC 2017 (1512911709758)
   [jmeter] ... end of run
 [echo] Bug50898 output files compared OK

batchtest:
 [echo] Starting Bug56243 with file Bug56243.jmx using -X -Jdummy=dummy
   [jmeter] SLF4J: Class path contains multiple SLF4J bindings.
   [jmeter] SLF4J: Found binding in 
[jar:
   [jmeter] SLF4J: Found binding in 
[jar:
   [jmeter] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   [jmeter] SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/Bug56243.jmx
   [jmeter] Starting the test @ Sun Dec 10 13:15:12 UTC 2017 (1512911712103)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary =  9 in 00:00:00 =   39.8/s Avg: 1 Min: 0 Max:  
   9 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sun Dec 10 13:15:12 UTC 2017 (1512911712996)
   [jmeter] ... end of run
 [echo] Bug56243 output files compared OK

batchtest:
 [echo] Starting Bug54685 with file Bug54685.jmx using -X 
-Jsample_variables=REFERENCE,JSESSIONID
   [jmeter] SLF4J: Class path contains multiple SLF4J bindings.
   [jmeter] SLF4J: Found binding in 
[jar:
   [jmeter] SLF4J: Found binding in 
[jar:
   [jmeter] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   [jmeter] SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/Bug54685.jmx
   [jmeter] Starting the test @ Sun Dec 10 13:15:15 UTC 2017 (1512911715170)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary =  1 in 00:00:00 =3.8/s Avg:   122 Min:   122 Max:  
 122 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sun Dec 10 13:15:16 UTC 2017 (1512911716017)
   [jmeter] ... end of run
 [echo] Bug54685 output files compared OK

batchtest:
 [echo] Starting Bug55375 with file Bug55375.jmx using -X -Jdummy=dummy
   [jmeter] SLF4J: Class path contains multiple SLF4J bindings.
   [jmeter] SLF4J: Found binding in 
[jar:
   [jmeter] SLF4J: Found binding in 
[jar:
   [jmeter] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   [jmeter] SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/Bug55375.jmx
   [jmeter] Starting the test @ Sun Dec 10 13:15:18 UTC 2017 (1512911718273)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary =  1 in 00:00:00 =3.0/s Avg:   189 Min:   189 Max:  
 189 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Sun Dec 10 13:15:19 UTC 2017 (1512911719216)
   [jmeter] ... end of run
 [echo] Bug55375 output files compared OK

batchtestserver:
   [server] SLF4J: Class path contains multiple SLF4J bindings.
   [server] SLF4J: Found binding in 
[jar:
   [server] SLF4J: Found binding in 
[jar:
   [server] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an

Re: Release a 4.0 (second try)

2017-12-10 Thread Rainer Jung 

Hi Philippe,

Am 10.12.2017 um 11:03 schrieb Philippe Mouawad:

Thanks but screenshot is still unreadable for me.


I think that's just the resolution shown on that web site. When I look 
at it, it shows a little plus sign and clicking on the image it enlarges 
it. I can click multiple times until it looks readable, so the image 
resolution is good.


Regards,

Rainer


On Sunday, December 10, 2017, jmeter tea  wrote:


Add new image:
https://imgur.com/t35J8c3
I selected a disable element and it can't be seen

OS: Windows 7
Screen Resolution: 1920 x 1080
Java: 8

On Sun, Dec 10, 2017 at 11:56 AM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:


Hi,
The screenshot is bot very clear.
Can you make it bigger and highlight what is bad ?

Also what are you using :
- OS
- Screen definition
- Java version

Thank you

On Sunday, December 10, 2017, jmeter tea  wrote:


The disable/enable color are very similar and hard to distinguish

between

them.
IMHO make enable element more whiter
Also when moving from Nimbus to Dracula the disabled elements can't be
seen. see https://imgur.com/37stPt9

On Sun, Dec 10, 2017 at 11:07 AM, Philippe Mouawad <
p.moua...@ubik-ingenierie.com> wrote:


Hello,
I think we have now a stable version , I am not aware of any

remaining

issue on nightly.

So I propose that we release a new version before end of year.

Thoughts ?

Regards
Philippe M.
@philmdot






--
Cordialement.
Philippe Mouawad.

buildbot failure in on jmeter-trunk

2017-12-10 Thread buildbot 
The Buildbot has detected a new failure on builder jmeter-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3345

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1817699
Blamelist: fschumacher

BUILD FAILED: failed shell_3

Sincerely,
 -The Buildbot

buildbot success in on jmeter-trunk

2017-12-10 Thread buildbot 
The Buildbot has detected a restored build on builder jmeter-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3346

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1817706
Blamelist: fschumacher

Build succeeded!

Sincerely,
 -The Buildbot

BoundaryExtractor#extract method

2017-12-10 Thread Felix Schumacher 

Hi all,

a few questions on the extract method.

Does it have to be public? It seems to be called in 
extractMatchingStrings, only.


If it stays public, shouldn't it have tests?

Is the condition "matchNumber <= 0 || newFound != matchNumber" the 
correct one? What happens when found is given with a number bigger than 
matchNumber? Should we collect all matches? I think this should be 
"newFound < matchNumber", that way we extract at most matchNumber (-1) 
fragments.


Felix

Re: Release a 4.0 (second try)

2017-12-10 Thread Philippe Mouawad 
Thanks but screenshot is still unreadable for me.


On Sunday, December 10, 2017, jmeter tea  wrote:

> Add new image:
> https://imgur.com/t35J8c3
> I selected a disable element and it can't be seen
>
> OS: Windows 7
> Screen Resolution: 1920 x 1080
> Java: 8
>
> On Sun, Dec 10, 2017 at 11:56 AM, Philippe Mouawad <
> philippe.moua...@gmail.com> wrote:
>
> > Hi,
> > The screenshot is bot very clear.
> > Can you make it bigger and highlight what is bad ?
> >
> > Also what are you using :
> > - OS
> > - Screen definition
> > - Java version
> >
> > Thank you
> >
> > On Sunday, December 10, 2017, jmeter tea  wrote:
> >
> > > The disable/enable color are very similar and hard to distinguish
> between
> > > them.
> > > IMHO make enable element more whiter
> > > Also when moving from Nimbus to Dracula the disabled elements can't be
> > > seen. see https://imgur.com/37stPt9
> > >
> > > On Sun, Dec 10, 2017 at 11:07 AM, Philippe Mouawad <
> > > p.moua...@ubik-ingenierie.com> wrote:
> > >
> > > > Hello,
> > > > I think we have now a stable version , I am not aware of any
> remaining
> > > > issue on nightly.
> > > >
> > > > So I propose that we release a new version before end of year.
> > > >
> > > > Thoughts ?
> > > >
> > > > Regards
> > > > Philippe M.
> > > > @philmdot
> > > >
> > >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
> >
>


-- 
Cordialement.
Philippe Mouawad.

Re: Release a 4.0 (second try)

2017-12-10 Thread jmeter tea 
Add new image:
https://imgur.com/t35J8c3
I selected a disable element and it can't be seen

OS: Windows 7
Screen Resolution: 1920 x 1080
Java: 8

On Sun, Dec 10, 2017 at 11:56 AM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:

> Hi,
> The screenshot is bot very clear.
> Can you make it bigger and highlight what is bad ?
>
> Also what are you using :
> - OS
> - Screen definition
> - Java version
>
> Thank you
>
> On Sunday, December 10, 2017, jmeter tea  wrote:
>
> > The disable/enable color are very similar and hard to distinguish between
> > them.
> > IMHO make enable element more whiter
> > Also when moving from Nimbus to Dracula the disabled elements can't be
> > seen. see https://imgur.com/37stPt9
> >
> > On Sun, Dec 10, 2017 at 11:07 AM, Philippe Mouawad <
> > p.moua...@ubik-ingenierie.com> wrote:
> >
> > > Hello,
> > > I think we have now a stable version , I am not aware of any remaining
> > > issue on nightly.
> > >
> > > So I propose that we release a new version before end of year.
> > >
> > > Thoughts ?
> > >
> > > Regards
> > > Philippe M.
> > > @philmdot
> > >
> >
>
>
> --
> Cordialement.
> Philippe Mouawad.
>

Re: Release a 4.0 (second try)

2017-12-10 Thread Philippe Mouawad 
Hi,
The screenshot is bot very clear.
Can you make it bigger and highlight what is bad ?

Also what are you using :
- OS
- Screen definition
- Java version

Thank you

On Sunday, December 10, 2017, jmeter tea  wrote:

> The disable/enable color are very similar and hard to distinguish between
> them.
> IMHO make enable element more whiter
> Also when moving from Nimbus to Dracula the disabled elements can't be
> seen. see https://imgur.com/37stPt9
>
> On Sun, Dec 10, 2017 at 11:07 AM, Philippe Mouawad <
> p.moua...@ubik-ingenierie.com> wrote:
>
> > Hello,
> > I think we have now a stable version , I am not aware of any remaining
> > issue on nightly.
> >
> > So I propose that we release a new version before end of year.
> >
> > Thoughts ?
> >
> > Regards
> > Philippe M.
> > @philmdot
> >
>


-- 
Cordialement.
Philippe Mouawad.

Re: Release a 4.0 (second try)

2017-12-10 Thread jmeter tea 
The disable/enable color are very similar and hard to distinguish between
them.
IMHO make enable element more whiter
Also when moving from Nimbus to Dracula the disabled elements can't be
seen. see https://imgur.com/37stPt9

On Sun, Dec 10, 2017 at 11:07 AM, Philippe Mouawad <
p.moua...@ubik-ingenierie.com> wrote:

> Hello,
> I think we have now a stable version , I am not aware of any remaining
> issue on nightly.
>
> So I propose that we release a new version before end of year.
>
> Thoughts ?
>
> Regards
> Philippe M.
> @philmdot
>

Release a 4.0 (second try)

2017-12-10 Thread Philippe Mouawad 
Hello,
I think we have now a stable version , I am not aware of any remaining
issue on nightly.

So I propose that we release a new version before end of year.

Thoughts ?

Regards
Philippe M.
@philmdot