[GitHub] jmeter pull request #309: Bug61039 - CSV data set config : Add browser butto...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/309 Bug61039 - CSV data set config : Add browser button to Filename field Better screenchot later You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/309.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #309 commit af3142ca0efc0ec85fa90bb4e722d9f0438e1fcc Author: ra77 <ra0...@gmail.com> Date: 2017-09-15T18:53:55Z Bug61525 : OS Process Sampler : Add browser button to Command and Working directory fields commit d9fcb768fc6c0aefabcf492f6d815eabfba81d90 Author: ra77 <ra0...@gmail.com> Date: 2017-09-16T19:47:05Z Merge branch 'trunk' of https://github.com/apache/jmeter into trunk commit c0d56ce401dc21e2db5ced9aa7367b922bc70947 Author: ra77 <ra0...@gmail.com> Date: 2017-09-16T20:42:59Z Bug 61039 : CSV data set config : Add browser button to Filename field ---
[GitHub] jmeter pull request #307: Bug61525 : OS Process Sampler : Add browser button...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/307 Bug61525 : OS Process Sampler : Add browser button to Command and Wor⦠â¦king directory fields You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/307.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #307 commit af3142ca0efc0ec85fa90bb4e722d9f0438e1fcc Author: ra77 <ra0...@gmail.com> Date: 2017-09-15T18:53:55Z Bug61525 : OS Process Sampler : Add browser button to Command and Working directory fields ---
[GitHub] jmeter pull request #303: Add a random date within a specific date range fun...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/303 Add a random date within a specific date range function Hi, I have make a new function called RandomDate which allow to generate a random date within a specific date range Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/303.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #303 commit eeaecb1dc8a121cacca061e6c7138a32d35d285e Author: ra77 <ra0...@gmail.com> Date: 2017-08-10T16:15:39Z Add a random date within a specific date range function --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #278: Documenting log4j2 related changes since 3.2.
Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/278 Hi, get-started.html don't need to be in the patch because it's a generated file Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #256: Bug60637 better statistics summary report
Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/256 Hi Philippe, Thanks to your feedback I will integrate your modification. If it's ok for all, I will modify the documentation and merge it One question, do I need to modify the release note with a screenshot? Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #256: Bug60637 better statistics summary report
Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/256 Before  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #251: Bug 60595 - add a SpashScreen at the start of JMeter GUI
Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/251 Hi, Thanks to your PR I think your IDE have reformated the code in src/core/org/apache/jmeter/JMeter.java and we can't easily check your modification. Can you upgrade the file with the original format? Thank Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #231: WIP: timer that produces poisson arrivals with given cons...
Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/231 Hi, In my test plan I have 3 http request and one Exponential Timer at the same level When I run my script, only first http request are executed whereas with "Constant Throughput Timer", I don't have this problem    Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #231: WIP: timer that produces poisson arrivals with given cons...
Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/231 Yes I have read it but I have some strange behavior in some test It's why I would like to know how do you use it Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #231: WIP: timer that produces poisson arrivals with given cons...
Github user ra0077 commented on the issue:
https://github.com/apache/jmeter/pull/231
Hi Vladimir,
No idea for the UI
Anybody have the answer?
To help me to understand how to use it, can you provide me some JMeter jmx
file for each goal ("Specific number of iterations per hour", "Bursty
load") with a short description (in comment)?
Thank
Antonio
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #231: WIP: timer that produces poisson arrivals with given cons...
Github user ra0077 commented on the issue:
https://github.com/apache/jmeter/pull/231
Hi,
My opinion is that the GUI is too complex because :
Too much parameter
You try to make too much different things in it
And these things
1) "Specific number of iterations per hour".
-> I think the GUI need to be like "Constant Throughput Timer", or better
in Thread Group (and I think "Constant Throughput Timer" need to be in Thread
Group too)
2) "Bursty load"
I don't know which parameter to use
3) "Repeatable test profile"
I don't know which parameter to use
4) "Avoid all thread groups"
In my opinion, need to be in Thread Group
In my opinion if you want to have all this functionality in only one
element, a new GUI is necessary.
e.g. A list to choose the goal ("Specific number of iterations per hour",
"Bursty load", "Repeatable test profile","Avoid all thread groups" and Custom
(like today))
When we select one, only needed parameter are displayed
I have made some basic tests and I am impressed by the precision :-)
Do you plan to make some docs/examples ?
Antonio
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #231: WIP: timer that produces poisson arrivals with given cons...
Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/231 Thank to the quick answer "so "test duration" parameter allows the timer to account for the expected test duration." And if "test duration" parameter is not equal to expected test duration? E.G. if I define a Loop count and not a Duration in the thread group I think it's a GUI too complex and I search how to simplify it I will do more test asap Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #231: WIP: timer that produces poisson arrivals with given cons...
Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/231 Hi, Thanks for the patch too. I don't understand how to use "Test duration" parameter Thank Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Github user ra0077 closed the pull request at: https://github.com/apache/jmeter/pull/223 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/223 PR commited --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #182: Bug 59281 testTimeDurationGUI
Github user ra0077 closed the pull request at: https://github.com/apache/jmeter/pull/182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #225: BUG59951_BetterScriptLanguageChooseDisplayJSR223
Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/225 I close the PR because some JMeter's users use this feature Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #225: BUG59951_BetterScriptLanguageChooseDisplayJSR223
Github user ra0077 closed the pull request at: https://github.com/apache/jmeter/pull/225 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/223 Hi all, I have check in JMeter source code if this "problem" (take a default solution if nothing is setted in GUI) and I have find "CSS/JQuery Extractor" element If you check the documentation (https://jmeter.apache.org/usermanual/component_reference.html#CSS/JQuery_Extractor), we can read "If selector is set to empty, default implementation(JSoup) will be used" I have check the source code and make a test and when selector is set to empty, there is no log written. I propose to make the same thing to this PR (remove log to avoid performance problem + have a clear documentation) Are you ok? Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #225: BUG59951_BetterScriptLanguageChooseDisplayJSR223
Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/225 Hi Philippe, My opinion is that it's not interesting for the majority of users. Is it possible to put these information in an other part of JMeter (log, ...)? Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #225: BUG59951_BetterScriptLanguageChooseDisplayJSR223
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/225 BUG59951_BetterScriptLanguageChooseDisplayJSR223 Hi, In my opinion, bundle don't need to be display in "script language choice" list in JSR223 elements It's useless for the majority of users Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter BUG59951_BetterScriptLanguageChooseDisplayJSR223 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/225.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #225 commit ba11e9fd1d618271746346ac6c1414cac20e4641 Author: ra0077 <ra0...@gmail.com> Date: 2016-08-05T14:54:24Z BUG59951_BetterScriptLanguageChooseDisplayJSR223 Hi, In my opinion, bundle don't need to be display in "script language choice" list in JSR223 elements It's useless for the majority of users Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Github user ra0077 commented on the issue:
https://github.com/apache/jmeter/pull/223
It's don't work :-(
protected ScriptEngine getScriptEngine() throws ScriptException {
String lang = getScriptLanguage();
if (StringUtils.isEmpty(lang)) {
lang = DEFAULT_SCRIPT_LANGUAGE;
setScriptLanguage(lang);
log.warn("Script language has not been chosen on the UI:
"+getName()+", the script will be interpreted as a groovy script");
}
ScriptEngine scriptEngine = getInstance().getEngineByName(lang);
if (scriptEngine == null) {
throw new ScriptException("Cannot find engine named:
'"+lang+"', ensure you set language field in JSR223 Test Element: "+getName());
}
return scriptEngine;
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/223 Hi ubikloadpack, Your solution seem good I will implement it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #224: Bug59948 html formated render
Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/224 Hi, HTML render display the HTML and not the source code of HTML If we add a checkbox, it can be only for Text render (and not for the other)? In my opinion, it will be complex to add it in a beautiful/friendly way But if you have a good idea, please advice me Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/223 Hi vladimir, Can you give me more details to avoid logging a warning on each sampler execution? I don't know how to implement Thanks Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/223 Bug59945_DefaultGroovyEngineToJSR223ElementsV2 Hi, If the script language has not been chosen on the GUI, I propose to add a WARN message into the log to inform that the script will be interpreted as a groovy script It's avoid message like "ERROR - jmeter.protocol.java.sampler.JSR223Sampler: Problem in JSR223 script Echantillon JSR223, message:javax.script.ScriptException: Cannot find engine named: '', ensure you set language field in JSR223 Test Element:Echantillon JSR223" and allow to execute the script Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59945_DefaultGroovyEngineToJSR223Elements Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/223.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #223 commit 8fe20ff7e9cb864b118ec650a854873de19abbac Author: ra0077 <ra0...@gmail.com> Date: 2016-08-04T21:12:59Z Bug59945_DefaultGroovyEngineToJSR223ElementsV2 Hi, If the script language has not been chosen on the GUI, I propose to add a WARN message into the log to inform that the script will be interpreted as a groovy script It's avoid message like "ERROR - jmeter.protocol.java.sampler.JSR223Sampler: Problem in JSR223 script Echantillon JSR223, message:javax.script.ScriptException: Cannot find engine named: '', ensure you set language field in JSR223 Test Element:Echantillon JSR223" and allow to execute the script Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #209: Bug59620_BrowserFileAndDirectory
Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/209 Hi Philippe, New patch commited Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter issue #209: Bug59620_BrowserFileAndDirectory
Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/209 Hi, I will re work the patch Thanks Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59620_BrowserFileAndDirectory
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/209 Bug59620_BrowserFileAndDirectory Hi, Some time we need to choose a directory and not a file with Browse button For example in "JMS Publisher -> Random File from folder specified below" button browse Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59620_BrowserFileAndDirectory Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/209.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #209 commit db3296b74dfcb3347191d885c6496109679f8b02 Author: ra0077 <ra0...@gmail.com> Date: 2016-05-23T20:41:40Z Bug59620_BrowserFileAndDirectory Hi, Some time we need to choose a directory and not a file with Browse button For example in "JMS Publisher -> Random File from folder specified below" button browse Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59385_SpellCorrectionToComponentReference
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/208 Bug59385_SpellCorrectionToComponentReference Hi, There are some typo in component_reference.xml file Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59385_SpellCorrectionToComponentReference Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/208.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #208 commit 7f0e8370a66c713d9f3941c4bba7cf7f74820b7e Author: ra0077 <ra0...@gmail.com> Date: 2016-04-27T12:21:26Z Bug59385_SpellCorrectionToComponentReference Hi, There are some typo in component_reference.xml file Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59381_BetterFileDialogFilterInJMSPublisher
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/207 Bug59381_BetterFileDialogFilterInJMSPublisher Hi, In JMSPublisher sampler, by default when you want to load a file (which contain the message body) the filter is set to *.* But it don't work and it's useless I propose to remove the filter Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59381_BetterFileDialogFilterInJMSPublisher Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/207.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #207 commit 1e6050beb38b147709ad2b96d83100eb69a552c9 Author: ra0077 <ra0...@gmail.com> Date: 2016-04-26T18:03:44Z Bug59381_BetterFileDialogFilterInJMSPublisher Hi, In JMSPublisher sampler, by default when you want to load a file (which contain the message body) the filter is set to *.* But it don't work and it's useless I propose to remove the filter Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59380_BetterLogJMSPublisher
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/206 Bug59380_BetterLogJMSPublisher Hi, I propose to modify the error message log for JMSPuclisher to include the name of the file that the script try to load It will help user to debug his script Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59380_BetterLogJMSPublisher Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/206.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #206 commit 0d8c07f75c321db67b416fab3c3b8ea3f77d5bed Author: ra0077 <ra0...@gmail.com> Date: 2016-04-26T17:54:27Z Bug59380_BetterLogJMSPublisher Hi, I propose to modify the error message log for JMSPuclisher to include the name of the file that the script try to load It will help user to debug his script Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59375_PublisherSampler.jms_random_file.bet...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/204 Bug59375_PublisherSampler.jms_random_file.betterLabel Hi, The label for jms_random_file in PublisherSampler are not understandable (for English) and incomplete dor French) I propose better label Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59375_PublisherSampler.jms_random_file.betterLabel Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/204.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #204 commit 2f60a3f8bbb686f6cc6dbca6b9c37d597041b302 Author: ra0077 <ra0...@gmail.com> Date: 2016-04-25T20:11:26Z Bug59375_PublisherSampler.jms_random_file.betterLabel Hi, The label for jms_random_file in PublisherSampler are not understandable (for English) and incomplete dor French) I propose better label Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59353_NewPartInChanges.html
Github user ra0077 closed the pull request at: https://github.com/apache/jmeter/pull/203 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59353_NewPartInChanges.html
Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/203#issuecomment-213097486 Merge by Milamber This closes #203 Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59351_BetterErrorMessageInIncludeControlle...
Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/202#issuecomment-212154513 Hi Philippe, Like you can see in https://docs.oracle.com/javase/7/docs/api/java/io/File.html#canRead%28%29 "Returns: true if and only if the file specified by this abstract pathname exists and can be read by the application; false otherwise" canRead() test if the file exists and can be read With this modification we have a better error message if the file can't be read Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59353_NewPartInChanges.html
Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/203#issuecomment-212153353 Hi Philippe, My title of PR is not good I have modified xdocs/changes.xml file and not the html file Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59353_NewPartInChanges.html
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/203 Bug59353_NewPartInChanges.html Hi, I propose to have a dedicated part called "Deprecated and removed elements" in "Incompatible changes" part in changes.xml Like that it will be more visible for user I have add Spline Visualizer listener and Distribution Graph listener which are not mentioned in changes.xml Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59353_NewPartInChanges.html Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/203.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #203 commit c212b3eb1d507374de24a2715315c8cf381a8fca Author: ra0077 <ra0...@gmail.com> Date: 2016-04-19T07:16:09Z Bug59353_NewPartInChanges.html Hi, I propose to have a dedicated part called "Deprecated and removed elements" in "Incompatible changes" part in changes.xml Like that it will be more visible for user I have add Spline Visualizer listener and Distribution Graph listener which are not mentioned in changes.xml Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59351_BetterErrorMessageInIncludeControlle...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/202 Bug59351_BetterErrorMessageInIncludeControllerForFileNotFound Hi, When JMeter try to load a file which don't exist in InludeController we have this log 2016/04/18 22:22:12 INFO - jmeter.services.FileServer: Set new base='C:\Util\0_JMX' 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -- try to load included module: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -Attempting to read it from: C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 ERROR - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -- try to load included module: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -Attempting to read it from: C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 ERROR - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:34:12 WARN - jmeter.control.IncludeController: Unexpected error java.io.IOException: loadIncludedElements -failed for: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx and C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx at org.apache.jmeter.control.IncludeController.loadIncludedElements(IncludeController.java:135) at org.apache.jmeter.control.IncludeController.resolveReplacementSubTree(IncludeController.java:111) at org.apache.jmeter.control.IncludeController.clone(IncludeController.java:64) at org.apache.jmeter.gui.action.CheckDirty.addNode(CheckDirty.java:162) and a popup box with useless message to user (see attached screenshot) I propose to have a more usefull log and error message. Ant to check that the file can be read Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59351_BetterErrorMessageInIncludeControllerForFileNotFound Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/202.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #202 commit aef98d759f25745201f338c0cb73cdac6a929ae9 Author: ra0077 <ra0...@gmail.com> Date: 2016-04-18T21:30:04Z Bug59351_BetterErrorMessageInIncludeControllerForFileNotFound Hi, When JMeter try to load a file which don't exist in InludeController we have this log 2016/04/18 22:22:12 INFO - jmeter.services.FileServer: Set new base='C:\Util\0_JMX' 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -- try to load included module: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -Attempting to read it from: C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 ERROR - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -- try to load included module: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\apache-jmeter-3.0\bin\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 INFO - jmeter.control.IncludeController: loadIncludedElements -Attempting to read it from: C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:22:13 ERROR - jmeter.control.IncludeController: loadIncludedElements -failed for: C:\Util\0_JMX\ C:\Util\0_JMX\IncludeSRCFragment.jmx 2016/04/18 22:34:1
[GitHub] jmeter pull request: Bug59350_WritingLogFileTo
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/201 Bug59350_WritingLogFileTo Hi, When JMeter start it's display a message like: Writing log file to:C:\Util\apache-jmeter-3.0\bin\jmeter.log I propose to add a space after to: Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59350_WritngLogFileTo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/201.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #201 commit 6fcc4975064ae76ffc033ee2d229016995fb2bd6 Author: ra0077 <ra0...@gmail.com> Date: 2016-04-18T20:19:48Z Bug59350_WritngLogFileTo Hi, When JMeter start it's display a message like: Writing log file to:C:\Util\apache-jmeter-3.0\bin\jmeter.log I propose to add a space after to: Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59346_SizeOfreport_statistics.pngv2
Github user ra0077 closed the pull request at: https://github.com/apache/jmeter/pull/199 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59346_SizeOfreport_statistics.pngv2
Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/199#issuecomment-211548294 Fixed by Philippe This closes #199 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59349_IncludeControllerFilenameTrim
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/200 Bug59349_IncludeControllerFilenameTrim Hi, Like I have proposed in "Bug 56877 - CSVDataSet does not trim spaces in .csv", I split this issue into different PR/Issues to merge fix step by step With this fix I propose to trim spaces in input filename in IncludeController. Without this fix, if the user put a space at the beginning of the input filename, we have an exception It's added to "Bug 59329 - Trim spaces in input filename in CSVDataSet". Very soon next PR to complete Bug 56877 Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59349_IncludeControllerFilenameTrim Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/200.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #200 commit 4514a27433b8c70b6ca4e3eb5672390712168573 Author: ra0077 <ra0...@gmail.com> Date: 2016-04-18T14:43:09Z Bug59349_IncludeControllerFilenameTrim Hi, Like I have proposed in "Bug 56877 - CSVDataSet does not trim spaces in .csv", I split this issue into different PR/Issues to merge fix step by step With this fix I propose to trim spaces in input filename in IncludeController. Without this fix, if the user put a space at the beginning of the input filename, we have an exception It's added to "Bug 59329 - Trim spaces in input filename in CSVDataSet". Very soon next PR to complete Bug 56877 Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59346_SizeOfreport_statistics.pngv2
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/199 Bug59346_SizeOfreport_statistics.pngv2 Hi, I have fix the problem of size of report_statistics.png Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59346_SizeOfreport_statistics.pngv2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/199.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #199 commit 2c8c89c377b16f9dbc5da79d32b621aaee9d6996 Author: ra0077 <ra0...@gmail.com> Date: 2016-04-18T10:07:20Z Bug59346_SizeOfreport_statistics.pngv2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 59281 testTimeDurationGUI
Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/182#issuecomment-210493454 Hi Philippe, I have ask to a UX Expert about this part (no time to audit all JMeter GUI) I should have an answer next week Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59329_CSVDataSetTrimFilenamev2
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/196 Bug59329_CSVDataSetTrimFilenamev2 Hi, Like I have proposed in "Bug 56877 - CSVDataSet does not trim spaces in .csv", I split this issue into different PR/Issues to merge fix step by step With this fix I propose to trim spaces in input filename in CSVDataSet. Without this fix, if the user put a space at the beginning of the input filename, we have an illegal argument exception Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59329_CSVDataSetTrimFilenamev2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/196.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #196 commit 8436e18fde7841d74cda06759319d09be2574555 Author: ra0077 <ra0...@gmail.com> Date: 2016-04-14T20:35:20Z Bug59329_CSVDataSetTrimFilenamev2 Hi, Like I have proposed in "Bug 56877 - CSVDataSet does not trim spaces in .csv", I split this issue into different PR/Issues to merge fix step by step With this fix I propose to trim spaces in input filename in CSVDataSet. Without this fix, if the user put a space at the beginning of the input filename, we have an illegal argument exception Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59328_BetterLabelAndToolTipInCSVDataSetVar...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/195 Bug59328_BetterLabelAndToolTipInCSVDataSetVariableNames Hi, in CSVDataSet if the variable name field is empty, then the first line of the file is read and interpreted as the list of column names. It's a great feature but we need to read the doc to have the information. I propose to put this information in the tooltip. Second modification is to remove "Separate by commas" because this information is already in the display name. Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59328_BetterLabelAndToolTipInCSVDataSetVariableNames Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/195.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #195 commit fb2cac12a69a24a83cf7cbb3ea3dd095a979a82e Author: ra0077 <ra0...@gmail.com> Date: 2016-04-14T20:11:31Z Bug59328_BetterLabelAndToolTipInCSVDataSetVariableNames Hi, in CSVDataSet if the variable name field is empty, then the first line of the file is read and interpreted as the list of column names. It's a great feature but we need to read the doc to have the information. I propose to put this information in the tooltip. Second modification is to remove "Separate by commas" because this information is already in the display name. Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59305DefaultReportHTMLStatisticsColumnSort
Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/193#issuecomment-210115536 Hi, My opinion is "I want to see all my results in Statistics table sorted by transaction. And after that I want to sort it in response time and/or error%" It's why I think it's better to have this sort The other benefit (If I have used a well-named transaction name) is that with this sort I can check easily the number of transactions at the end of the load test (I need only check the last transaction with the right column) Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 59281 testTimeDurationGUI
Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/182#issuecomment-210112763 Hi, My opinion is that it's not well integrated with the JMeter GUI. I prefer before (like I have made it with my PR) And because we don't must run laod test with the GUI, be visible is less important. If you wan I can ask to a UX expert Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59320 generic gui tooltipsv2
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/194 Bug59320 generic gui tooltipsv2 Hi, When you use GenericTestBeanCustomizer to create your GUI, the tooltip in French and Enflish have not the same form (in english we have a line breack and not in French) The second problem is that the tooltip contain desc.getName + desc.getShortDescription Or desc.getName is not translated and, in my opinion, useless My proposition is to remove desc.getName from the tooltip Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59320_GenericGUITooltipsv2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/194.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #194 commit afc3b275980d4ddb277dc2a69a45902add136ddf Author: ra0077 <ra0...@gmail.com> Date: 2016-04-14T12:57:13Z Bug59320_GenericGUITooltipsv2 Hi, When you use GenericTestBeanCustomizer to create your GUI, the tooltip in French and Enflish have not the same form (in english we have a line breack and not in French) The second problem is that the tooltip contain desc.getName + desc.getShortDescription Or desc.getName is not translated and, in my opinion, useless My proposition is to remove desc.getName from the tooltip Antonio commit 5775d40af6c5e2b140013564a174146671086251 Author: ra0077 <ra0...@gmail.com> Date: 2016-04-14T13:10:24Z Fix problem with English tooltip --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59305DefaultReportHTMLStatisticsColumnSort
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/193 Bug59305DefaultReportHTMLStatisticsColumnSort Hi, By default in HTML report statistics, it's the column Error% which is sorted I think it's better to sort the table with label column Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59305DefaultReportHTMLStatisticsColumnSort Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #193 commit 9fa5b28b4d9cd3c3920e03ac797f3eec1a31d56f Author: ra0077 <ra0...@gmail.com> Date: 2016-04-11T21:23:37Z Bug59305DefaultReportHTMLStatisticsColumnSort Hi, By default in HTML report statistics, it's the column Error% which is sorted I think it's better to sort the table with label column Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59304_Hamonize2labelsinHTMLReport
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/192 Bug59304_Hamonize2labelsinHTMLReport Hi, In HTML report, reportgenerator_summary_apdex_samplers and reportgenerator_summary_statistics_label display the same data but with a different label I propose to harmonize the two labels Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59304_Hamonize2labelsinHTMLReport Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/192.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #192 commit a3c9b6f1eb18c214243d2cdf5d888bc57d932c94 Author: ra0077 <ra0...@gmail.com> Date: 2016-04-11T20:55:38Z Bug59304_Hamonize2labelsinHTMLReport Hi, In HTML report, reportgenerator_summary_apdex_samplers and reportgenerator_summary_statistics_label display the same data but with a different label I propose to harmonize the two labels Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59303_NewDefaultResponseTimeDistributionGr...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/191 Bug59303_NewDefaultResponseTimeDistributionGranularity Hi, By default the response time distribution granularity in HTML report is 1000ms jmeter.reportgenerator.graph.responseTimeDistribution.property.set_granularity=1000 I think is too high I propose to have a lower value like 500ms Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59303_NewDefaultResponseTimeDistributionGranularity Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/191.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #191 commit 3f87fbbac92aae4d3100309495d2725ea77a95d7 Author: ra0077 <ra0...@gmail.com> Date: 2016-04-11T20:11:46Z Bug59303_NewDefaultResponseTimeDistributionGranularity Hi, By default the response time distribution granularity in HTML report is 1000ms jmeter.reportgenerator.graph.responseTimeDistribution.property.set_granularity=1000 I think is too high I propose to have a lower value like 500ms Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59294_BetterPercentileLabelv3
Github user ra0077 commented on a diff in the pull request: https://github.com/apache/jmeter/pull/187#discussion_r59141868 --- Diff: src/core/org/apache/jmeter/resources/messages_fr.properties --- @@ -853,7 +853,7 @@ reportgenerator_summary_statistics_kbytes=Ko/sec reportgenerator_summary_statistics_label=Libell\u00E9 reportgenerator_summary_statistics_max=Max reportgenerator_summary_statistics_min=Min -reportgenerator_summary_statistics_percentile_fmt=%d%% Ligne +reportgenerator_summary_statistics_percentile_fmt=%de percentile --- End diff -- Hi Milamber, I have compare HTML report with other listener and find another difference (in % error) I have commit it in https://github.com/apache/jmeter/pull/190 because percentil PR (PR 187) modify also a java file and not only properties files Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59298_BetterReportgenerator_summary_statis...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/190 Bug59298_BetterReportgenerator_summary_statistics_error_percentLabel Hi, I have modified label of reportgenerator_summary_statistics_error_percent to be like the other listener (aggregate report...) Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59298_BetterReportgenerator_summary_statistics_error_percentLabel Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/190.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #190 commit d190b51e5b010e39c0c08d98e447722b62eea903 Author: ra0077 <ra0...@gmail.com> Date: 2016-04-10T21:28:02Z Bug59298_BetterReportgenerator_summary_statistics_error_percentLabel Hi, I have modified label of reportgenerator_summary_statistics_error_percent to be like the other listener (aggregate report...) Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59297_FixUTF8InReport
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/189 Bug59297_FixUTF8InReport [reply] [â] Description Antonio Gomes Rodrigues 2016-04-10 19:47:04 UTC Created attachment 33744 [details] problem with accent in the French HTML report Hi, There is a problem with accent in the French HTML report The problem come from the encod of content\js\dashboard.js file (no UTF-8) Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59297FixUTF8 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/189.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #189 commit c5802496b447f4ad38969aa2b1d9056eeaad1d94 Author: ra0077 <ra0...@gmail.com> Date: 2016-04-10T19:50:36Z Bug59297_FixUTF8InReport [reply] [â] Description Antonio Gomes Rodrigues 2016-04-10 19:47:04 UTC Created attachment 33744 [details] problem with accent in the French HTML report Hi, There is a problem with accent in the French HTML report The problem come from the encod of content\js\dashboard.js file (no UTF-8) Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59294_BetterPercentileLabelv3
Github user ra0077 commented on a diff in the pull request: https://github.com/apache/jmeter/pull/187#discussion_r59132248 --- Diff: src/core/org/apache/jmeter/resources/messages_fr.properties --- @@ -853,7 +853,7 @@ reportgenerator_summary_statistics_kbytes=Ko/sec reportgenerator_summary_statistics_label=Libell\u00E9 reportgenerator_summary_statistics_max=Max reportgenerator_summary_statistics_min=Min -reportgenerator_summary_statistics_percentile_fmt=%d%% Ligne +reportgenerator_summary_statistics_percentile_fmt=%de percentile --- End diff -- Ok no problem I will compare aggregate graph/aggregate report with HTML to use the same words Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59294_BetterPercentileLabelv3
Github user ra0077 commented on a diff in the pull request: https://github.com/apache/jmeter/pull/187#discussion_r59111828 --- Diff: src/core/org/apache/jmeter/resources/messages_fr.properties --- @@ -853,7 +853,7 @@ reportgenerator_summary_statistics_kbytes=Ko/sec reportgenerator_summary_statistics_label=Libell\u00E9 reportgenerator_summary_statistics_max=Max reportgenerator_summary_statistics_min=Min -reportgenerator_summary_statistics_percentile_fmt=%d%% Ligne +reportgenerator_summary_statistics_percentile_fmt=%de percentile --- End diff -- Hi Milamber, I am ok with your but in wikipedia (https://fr.wikipedia.org/wiki/Centile) I have seen that percentile is also accepted I quoted wikipedia: "En statistique descriptive <https://fr.wikipedia.org/wiki/Statistique_descriptive>, un *centile* est chacune des 99 valeurs qui divisent les données triées en 100 parts égales, de sorte que chaque partie représente 1/100 de l'échantillon de population. (La dénomination anglaise <https://fr.wikipedia.org/wiki/Anglais> â *percentile*, avec une prononciation francisée, est parfois utilisée)." It's why I have prefered percentile instead of centile But if you prefer centile, it's ok for me too Antonio <https://www.avast.com/sig-email?utm_medium=email_source=link_campaign=sig-email_content=webmail_term=oa-2200-c> Garanti sans virus. www.avast.com <https://www.avast.com/sig-email?utm_medium=email_source=link_campaign=sig-email_content=webmail_term=oa-2200-c> <#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2> 2016-04-09 9:23 GMT+02:00 Milamber <notificati...@github.com>: > In src/core/org/apache/jmeter/resources/messages_fr.properties > <https://github.com/apache/jmeter/pull/187#discussion_r59111727>: > > > @@ -853,7 +853,7 @@ reportgenerator_summary_statistics_kbytes=Ko/sec > > reportgenerator_summary_statistics_label=Libell\u00E9 > > reportgenerator_summary_statistics_max=Max > > reportgenerator_summary_statistics_min=Min > > -reportgenerator_summary_statistics_percentile_fmt=%d%% Ligne > > +reportgenerator_summary_statistics_percentile_fmt=%de percentile > > In French, percentile is translate by the word "centile" > https://fr.wikipedia.org/wiki/Centile > > For example : "99e centile" > > â > You are receiving this because you authored the thread. > Reply to this email directly or view it on GitHub > <https://github.com/apache/jmeter/pull/187/files/0165352fa09a2771b19290c72f5425a875cf1513#r59111727> > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 59291 - Fix typo in generating-dashboard....
Github user ra0077 closed the pull request at: https://github.com/apache/jmeter/pull/183 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59291_FixDuplicateLineIngenerating-dashboa...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/188 Bug59291_FixDuplicateLineIngenerating-dashboardDocumentation Hi, There is a typo in generating-dashboard.html I have remove the duplicate line (# Indicates which graph series are filtered (regular expression)) in generating-dashboard.xml This new PR fix problem I have in my editor to have a better PR Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59291_FixDuplicateLineIngenerating-dashboardDocumentation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/188.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #188 commit d25f732f993f9fa2a7f48a4f740d213f24e2d66b Author: ra0077 <ra0...@gmail.com> Date: 2016-04-09T07:07:23Z Bug59291_FixDuplicateLineIngenerating-dashboardDocumentation Hi, There is a typo in generating-dashboard.html I have remove the duplicate line (# Indicates which graph series are filtered (regular expression)) in generating-dashboard.xml This new PR fix problem I have in my editor to have a better PR Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59294_BetterPercentileLabel
Github user ra0077 closed the pull request at: https://github.com/apache/jmeter/pull/186 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59294_BetterPercentileLabel
Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/186#issuecomment-207730046 Hi, I have a problem with my editor Check Bug59294_BetterPercentileLabelv3 #187 to the correct fix Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59294_BetterPercentileLabelv3
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/187 Bug59294_BetterPercentileLabelv3 Hi, I propose better percentile label : new and better label same in Response Time Per Sample and Dashboard statistics New release with the right properties files Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59294_BetterPercentileLabelv3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/187.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #187 commit 0165352fa09a2771b19290c72f5425a875cf1513 Author: ra0077 <ra0...@gmail.com> Date: 2016-04-09T06:55:50Z Bug59294_BetterPercentileLabelv3 Hi, I propose better percentile label : new and better label same in Response Time Per Sample and Dashboard statistics New release with the right properties files Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59293_AddAvgInAxisToLatenciesOverTimeRepor...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/185 Bug59293_AddAvgInAxisToLatenciesOverTimeReport Hi, Not enough info in Axis to Latencies over Time graph in report I propose to add average Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59293_AddAvgInAxisToLatenciesOverTimeReport Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/185.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #185 commit 68e266d0540ae2cf27272ad0553c7ec9e92e6385 Author: ra0077 <ra0...@gmail.com> Date: 2016-04-08T21:31:49Z Bug59293_AddAvgInAxisToLatenciesOverTimeReport Hi, Not enough info in Axis to Latencies over Time graph in report I propose to add average Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59292_AddAvgInAxisToResponseTimeOverTimeRe...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/184 Bug59292_AddAvgInAxisToResponseTimeOverTimeReport Hi, Not enough info in Axis to Response time over Time graph in report I propose to add average Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59292_AddAvgInAxisToResponseTimeOverTimeReport Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/184.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #184 commit 300ccaaf9c25ff029d28967a6a70cb5a397ece81 Author: ra0077 <ra0...@gmail.com> Date: 2016-04-08T21:23:54Z Bug59292_AddAvgInAxisToResponseTimeOverTimeReport Hi, Not enough info in Axis to Response time over Time graph in report I propose to add average Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 59291 - Fix typo in generating-dashboard....
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/183 Bug 59291 - Fix typo in generating-dashboard.html documentation Hi, There is a typo in generating-dashboard.html I have remove the duplicate line (426 (# Indicates which graph series are filtered (regular expression)) in generating-dashboard.xml Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59291_FixTypoIngenerating-dashboard.html Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/183.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #183 commit 5c92120782a59d2311432dc0471910e678aaea35 Author: ra0077 <ra0...@gmail.com> Date: 2016-04-08T20:31:16Z Bug 59291 - Fix typo in generating-dashboard.html documentation Hi, There is a typo in generating-dashboard.html Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: bug59225_runningIndicatorWithoutSetContentAre...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/173 bug59225_runningIndicatorWithoutSetContentAreaFilledToFalse Hi Put setContentAreaFilled to false in runningIndicator has been forget This PR add it Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter bug59225_runningIndicatorWithoutSetContentAreaFilledToFalse Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/173.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #173 commit b6f9ef8af2a5a019a9ee75df7eb108e7d6fa2419 Author: ra0077 <ra0...@gmail.com> Date: 2016-03-23T22:18:30Z bug59225_runningIndicatorWithoutSetContentAreaFilledToFalse Hi Put setContentAreaFilled to false in runningIndicator has been forget Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59207_ChangeColorErrorsOrFatalsLabel.setTo...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/172 Bug59207_ChangeColorErrorsOrFatalsLabel.setToolTipTextTranslationErro⦠Hi, I think it will be great to change the color font of errorsOrFatalsLabel to red when a error occur Like that it will have more visibility and help the user when an error occur (like in my previous PR https://bz.apache.org/bugzilla/show_bug.cgi?id=59153) Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59207_ChangeColorErrorsOrFatalsLabel.setToolTipTextTranslationErrorToRed Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/172.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #172 commit a223b9544f4846d8f2e95b3bb86ef7c0859cd98d Author: ra0077 <ra0...@gmail.com> Date: 2016-03-21T22:19:32Z Bug59207_ChangeColorErrorsOrFatalsLabel.setToolTipTextTranslationErrorToRed Hi, I think it will be great to change the color font of errorsOrFatalsLabel to red when a error occur Like that it will have more visibility and help the user when an error occur (like in my previous PR https://bz.apache.org/bugzilla/show_bug.cgi?id=59153) Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug59190_BetterProxyExcludesSuggestedCaseSens...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/169 Bug59190_BetterProxyExcludesSuggestedCaseSensitive Hi, I have modified the suggested excludes to be no case sensitive like in Templates Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59190_BetterProxyExcludesSuggestedCaseSensitive Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/169.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #169 commit f1dd3030f3d5d84651cb6544e7281f80e0be180a Author: ra0077 <ra0...@gmail.com> Date: 2016-03-17T14:05:51Z Bug59190_BetterProxyExcludesSuggestedCaseSensitive Hi, I have modified the suggested excludes to be no case sensitive like in Templates Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: bug59153_CSVDataSetFilesExceptions
Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/167#issuecomment-197735103 New commit with formating and swap else branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: bug59153_ExceptionInCSVDataSetWithEmptyFilena...
Github user ra0077 commented on the pull request:
https://github.com/apache/jmeter/pull/162#issuecomment-196740857
I have swap it and remove formating to be easy to read it
What I do is:
check if the user have put a file name
if not
log it to allow easy debuging
stop the test
if yes
no modification
It allow to easy debug (a clear message in log) and avoid to have an
exception to user
The diff with the trunk:
--- a/src/components/org/apache/jmeter/config/CSVDataSet.java
+++ b/src/components/org/apache/jmeter/config/CSVDataSet.java
@@ -146,6 +146,11 @@ public class CSVDataSet extends ConfigTestElement
@Override
public void iterationStart(LoopIterationEvent iterEvent) {
+String _fileName = getFilename();
+if (_fileName.isEmpty()) {
+log.error("No filename setup in CSV Data Set Config:
"+this.getName());
+throw new JMeterStopThreadException("No filename setup in CSV
Data Set Config: "+this.getName());
+} else {
FileServer server = FileServer.getFileServer();
final JMeterContext context = getThreadContext();
String delim = getDelimiter();
@@ -156,7 +161,6 @@ public class CSVDataSet extends ConfigTestElement
delim=",";
}
if (vars == null) {
-String _fileName = getFilename();
String mode = getShareMode();
int modeInt = CSVDataSetBeanInfo.getShareModeAsInt(mode);
switch(modeInt){
@@ -212,6 +216,7 @@ public class CSVDataSet extends ConfigTestElement
threadVars.put(var, EOFVALUE);
}
}
+}
}
Antonio
Cet e-mail a été envoyé depuis un ordinateur protégé par Avast.
www.avast.com
<https://www.avast.com/fr-fr/lp-safe-emailing?utm_medium=email_source=link_campaign=sig-email_content=webmail_term=OA-2109-A>
<#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
2016-03-15 9:13 GMT+01:00 Vladimir Sitnikov <notificati...@github.com>:
> I don't have modify these lines.
>
> @ra0077 <https://github.com/ra0077>, can you please rework the PR without
> reformatting the whole method?
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub:
> https://github.com/apache/jmeter/pull/162#issuecomment-196710977
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: bug59153_ExceptionInCSVDataSetWithEmptyFilena...
Github user ra0077 commented on the pull request:
https://github.com/apache/jmeter/pull/162#issuecomment-196740926
I have swap it and remove formating to be easy to read it
What I do is:
check if the user have put a file name
if not
log it to allow easy debuging
stop the test
if yes
no modification
It allow to easy debug (a clear message in log) and avoid to have an
exception to user
The diff with the trunk:
--- a/src/components/org/apache/jmeter/config/CSVDataSet.java
+++ b/src/components/org/apache/jmeter/config/CSVDataSet.java
@@ -146,6 +146,11 @@ public class CSVDataSet extends ConfigTestElement
@Override
public void iterationStart(LoopIterationEvent iterEvent) {
+String _fileName = getFilename();
+if (_fileName.isEmpty()) {
+log.error("No filename setup in CSV Data Set Config:
"+this.getName());
+throw new JMeterStopThreadException("No filename setup in CSV
Data Set Config: "+this.getName());
+} else {
FileServer server = FileServer.getFileServer();
final JMeterContext context = getThreadContext();
String delim = getDelimiter();
@@ -156,7 +161,6 @@ public class CSVDataSet extends ConfigTestElement
delim=",";
}
if (vars == null) {
-String _fileName = getFilename();
String mode = getShareMode();
int modeInt = CSVDataSetBeanInfo.getShareModeAsInt(mode);
switch(modeInt){
@@ -212,6 +216,7 @@ public class CSVDataSet extends ConfigTestElement
threadVars.put(var, EOFVALUE);
}
}
+}
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: bug59153_ExceptionInCSVDataSetWithEmptyFilena...
Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/162#issuecomment-196710362 Hi, I don't have modify these lines. But I think that CSV Data Set need more work to be ok Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: bug59153_ExceptionInCSVDataSetWithEmptyFilena...
Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/162#issuecomment-195361482 Hi, JMeter not skip the missing filename silently (like previously) But now instead of having an FileNotFoundException exception + stacktrace we have a clear error message + JMeterStopThreadException Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: bug59153_ExceptionInCSVDataSetWithEmptyFilena...
Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/162#issuecomment-194528887 Hi Philippe, I was training a colleague to JMeter and I have add a CSV DataSet to use it later in the test plan. I run the test to check it before fill the CSV DataSet and I have this exception And it's not the first time I have it (when I work wit people who are not expert I like to add all the element I want he will use it without fill all of them) To answer your question, I add a CSV DataSet with empty file name to: tell to someone to use it use it later when my test plan will be checked With my use, the test will not failed and stop but continue (maybe with a warning like I have implemented) In all cases the need to ckeck the log to see the exception to understand why the script don't start is not a good solution Regards Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: bug59153_ExceptionInCSVDataSetWithEmptyFilena...
Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/162#issuecomment-194521601 New commit Formatting fixed I have add a warning message (log.warn) to not skip the missing filename silently Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: bug59153_ExceptionInCSVDataSetWithEmptyFilena...
Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/162#issuecomment-194441610 Hi, I can fix the formatting. About the second comments, what do you want I do? Do I need to log it in debug? Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: bug59153_ExceptionInCSVDataSetWithEmptyFilena...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/162 bug59153_ExceptionInCSVDataSetWithEmptyFilename Hi, When you add a CSV Data Set Config in your test plan and you don't fill the filename field we have an exception ERROR - jmeter.threads.JMeterThread: Test failed! java.lang.IllegalArgumentException: Could not read file header line at org.apache.jmeter.services.FileServer.reserveFile(FileServer.java:280) at org.apache.jmeter.config.CSVDataSet.iterationStart(CSVDataSet.java:178) at org.apache.jmeter.control.GenericController.fireIterationStart(GenericController.java:405) at org.apache.jmeter.control.GenericController.fireIterEvents(GenericController.java:397) at org.apache.jmeter.control.GenericController.next(GenericController.java:158) at org.apache.jmeter.control.LoopController.next(LoopController.java:123) at org.apache.jmeter.threads.AbstractThreadGroup.next(AbstractThreadGroup.java:87) at org.apache.jmeter.threads.JMeterThread.run(JMeterThread.java:238) at java.lang.Thread.run(Unknown Source) Caused by: java.io.FileNotFoundException: C:\X (Accès refusé) at java.io.FileInputStream.open0(Native Method) at java.io.FileInputStream.open(Unknown Source) at java.io.FileInputStream.(Unknown Source) at org.apache.jmeter.services.FileServer.createBufferedReader(FileServer.java:419) at org.apache.jmeter.services.FileServer.readLine(FileServer.java:345) at org.apache.jmeter.services.FileServer.readLine(FileServer.java:329) at org.apache.jmeter.services.FileServer.reserveFile(FileServer.java:277) ... 8 more Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter bug59153_ExceptionInCSVDataSetWithEmptyFilename Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/162.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #162 commit 53df603da71262acccb5eaac4c7b1a2db6597c7b Author: ra0077 <ra0...@gmail.com> Date: 2016-03-09T12:57:48Z Hi, Whe you add a CSV Data Set Config in your test plan and you don't fill the filename field we have an exception ERROR - jmeter.threads.JMeterThread: Test failed! java.lang.IllegalArgumentException: Could not read file header line at org.apache.jmeter.services.FileServer.reserveFile(FileServer.java:280) at org.apache.jmeter.config.CSVDataSet.iterationStart(CSVDataSet.java:178) at org.apache.jmeter.control.GenericController.fireIterationStart(GenericController.java:405) at org.apache.jmeter.control.GenericController.fireIterEvents(GenericController.java:397) at org.apache.jmeter.control.GenericController.next(GenericController.java:158) at org.apache.jmeter.control.LoopController.next(LoopController.java:123) at org.apache.jmeter.threads.AbstractThreadGroup.next(AbstractThreadGroup.java:87) at org.apache.jmeter.threads.JMeterThread.run(JMeterThread.java:238) at java.lang.Thread.run(Unknown Source) Caused by: java.io.FileNotFoundException: C:\X (Accès refusé) at java.io.FileInputStream.open0(Native Method) at java.io.FileInputStream.open(Unknown Source) at java.io.FileInputStream.(Unknown Source) at org.apache.jmeter.services.FileServer.createBufferedReader(FileServer.java:419) at org.apache.jmeter.services.FileServer.readLine(FileServer.java:345) at org.apache.jmeter.services.FileServer.readLine(FileServer.java:329) at org.apache.jmeter.services.FileServer.reserveFile(FileServer.java:277) ... 8 more Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: bug 59152: Change default Thread Group -> Act...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/161 bug 59152: Change default Thread Group -> Action to be taken after a Sample Error value from "Continue" to "Start Next thread loop" Hi, This patch (for bug 59152) change default Thread Group -> Action to be taken after a Sample Error value from "Continue" to "Start Next thread loop" I think it's better to start next thread loop instead of continuing without take into account the error because continue if there is an error makes no sense (it's not realistic) Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59152_ChangeDefaultOnErrorThreadGroup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/161.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #161 commit 5ec28d8544c70b456f83f743841bd9fcba017e8c Author: ra0077 <ra0...@gmail.com> Date: 2016-03-09T12:23:48Z Hi, This patch change default Thread Group -> Action to be taken after a Sample Error value from "Continue" to "Start Next thread loop" I think it's better to start next thread loop instead of continuing without take into account the error because continue if there is an error makes no sense (it's not realistic) Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 59116
Github user ra0077 closed the pull request at: https://github.com/apache/jmeter/pull/156 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 59116
Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/156#issuecomment-192354635 Problem with tab --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: PR for BUG 59116 without tab
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/158 PR for BUG 59116 without tab Hi, I have add a new option in proxy recorder to add a prefix in sampler name recorded by the proxy. It allow to be more productive (less work to rename samplers after a recording) and complete the regex in backend listener I have add previously This new PR fix the tab Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug59116_ProxyRecorderHTTPNamePrefix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/158.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #158 commit 8e384c8850432b5b128a078430ee4289852c1bea Author: ra0077 <ra0...@gmail.com> Date: 2016-03-04T16:38:06Z PR for BUG 59116 without tab --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 59118 - Add comment in recorded thik time...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/157 Bug 59118 - Add comment in recorded thik time by proxy recorder Hi, To complete my previous PR about adding a new template "recording with think time" I have made a new PR. This PR add a comment in the recorded timer like "Recorded think time: XXXms" It will allow to: differentiate recorded timer from other have the original think time duration Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter AddCommentsInThinkTimeRecorded Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/157.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #157 commit e2589591e78f8664fa0a98d77ee5b95efee4c040 Author: ra0077 <ra0...@gmail.com> Date: 2016-03-04T15:13:15Z Bug 59118 - Add comment in recorded thik time by proxy recorder Hi, To complete my previous PR about adding a new template "recording with think time" I have made a new PR. This PR add a comment in the recorded timer like "Recorded think time: XXXms" It will allow to: differentiate recorded timer from other have the original think time duration Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 59116
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/156 Bug 59116 Hi, I have add a new option in proxy recorder to add a prefix in sampler name recorded by the proxy. It allow to be more productive (less work to rename samplers after a recording) and complete the regex in backend listener I have add previously Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter ProxyRecorderHTTPNamePrefix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/156.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #156 commit 49163c46678c031052b0190aa2eef713d52a85dc Author: ra0077 <ra0...@gmail.com> Date: 2016-03-04T14:39:01Z Bug 59116 Hi, I have add a new option in proxy recorder to add a prefix in sampler name recorded by the proxy. It allow to be more productive (less work to rename samplers after a recording) and complete the regex in backend listener I have add previously Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Bug 59099 _ Add the possibility to use reg ex...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/151 Bug 59099 _ Add the possibility to use reg ex in Backend listener Hi, This PR add the possibility to use reg ex in Backend listener It will allow to be more productive Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter UseRegexpForSamplerListInGraphiteBackendListener Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/151.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #151 commit 46112a0f656a1b0c56b6af1b18625ebce671a05b Author: ra0077 <ra0...@gmail.com> Date: 2016-03-02T14:04:08Z Add the possibility to use reg ex in Backend listener --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Remove "Building a Web Test Plan" template
Github user ra0077 closed the pull request at: https://github.com/apache/jmeter/pull/92 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Remove "Building a Web Test Plan" template
Github user ra0077 commented on the pull request: https://github.com/apache/jmeter/pull/92#issuecomment-184206593 Hi, No problem to keep it if you use it Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Change the default port for the Proxy recorde...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/124 Change the default port for the Proxy recorder to from 8080 Now it's the same as the template recording is better than 8080 because 8080 is used for a lot of other tools like Tomcat Bug 59006 Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter Bug_59006_DefaultProxyRecorderPort Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/124.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #124 commit 3cfd58aaa0d7fd316f2408d34590919b13b65a6b Author: ra0077 <ra0...@gmail.com> Date: 2016-02-15T13:17:59Z Change the default port for the Proxy recorder to from 8080 Now it's the same as the template recording is better than 8080 because 8080 is used for a lot of other tools like Tomcat Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Remove "Building an Advanced Web Test Plan" t...
Github user ra0077 closed the pull request at: https://github.com/apache/jmeter/pull/93 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Template to record script with think time
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/109 Template to record script with think time Add a new template to allow to record script with think time included You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter RecordThinkTime Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/109.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #109 commit dd41da7086e6d5ff227a827ad530bd913ece6e17 Author: Antonio <> Date: 2016-01-28T14:59:02Z Hi, Remove "Building an Advanced Web Test Plan" template Everyone use the recorder to create a Web test plan. The documentation is enough Antonio commit f5e02e65c53278d48349bf195d5d0d2f230fe4bc Author: Antonio <antonio@octo> Date: 2016-01-28T21:56:01Z Hi, Add a template called "Record with think time" It allow to record think time in an Uniform Random Timer Antonio commit 812a49736965ed5f5e531e52985c3f6bed42fdc6 Author: Antonio <antonio@octo> Date: 2016-01-28T22:09:57Z commit b6307b27ffbb38504d66cbf133958f7916b9a399 Author: Antonio <antonio@octo> Date: 2016-01-28T22:13:57Z commit b98fcb4f14c15e2486b4d77fc1c9466b33bacc56 Author: Antonio <antonio@octo> Date: 2016-02-04T10:09:21Z Add a new template to allow to record script with think time included --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Remove "Building a Web Test Plan" template
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/92 Remove "Building a Web Test Plan" template Hi, Everyone use the recorder to create a Web test plan. The documentation is enough Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter RemoveTemplateBuildingAWebTestPlan Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/92.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #92 commit 7d5ba78ce449578599c581a112a4eba718ce7e51 Author: Antonio <> Date: 2016-01-28T14:50:33Z Remove "Building a Web Test Plan" template Everyone use the recorder to create a Web test plan. The documentation is enough --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jmeter pull request: Remove "Building an Advanced Web Test Plan" t...
GitHub user ra0077 opened a pull request: https://github.com/apache/jmeter/pull/93 Remove "Building an Advanced Web Test Plan" template Hi, Remove "Building an Advanced Web Test Plan" template Everyone use the recorder to create a Web test plan. The documentation is enough Antonio You can merge this pull request into a Git repository by running: $ git pull https://github.com/ra0077/jmeter trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jmeter/pull/93.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #93 commit dd41da7086e6d5ff227a827ad530bd913ece6e17 Author: Antonio <> Date: 2016-01-28T14:59:02Z Hi, Remove "Building an Advanced Web Test Plan" template Everyone use the recorder to create a Web test plan. The documentation is enough Antonio --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
