[jira] [Commented] (JOSHUA-274) Use another HTTPServer other than Suns
[ https://issues.apache.org/jira/browse/JOSHUA-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313173#comment-15313173 ] Thamme Gowda commented on JOSHUA-274: - Kellen, yes lets keep the translation core library as minimal as possible. +1 for pointing out the issue. An option would be to setup submodule for this maven project to contain a Joshua REST service . 1. it will allow us to use Joshua from non-JVM languages. 2. since the language packs/models are huge, its not good idea to use JOSHUA from command line when we are making too many calls (since loading takes plenty of time for each CLI call) > Use another HTTPServer other than Suns > -- > > Key: JOSHUA-274 > URL: https://issues.apache.org/jira/browse/JOSHUA-274 > Project: Joshua > Issue Type: Improvement > Components: decoders >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Priority: Critical > Fix For: 6.1 > > > This issue concerns the use of the > [HttpServer|https://github.com/apache/incubator-joshua/blob/master/src/joshua/decoder/JoshuaDecoder.java#L31] > within JoshuaDecoder.java. > We should replace the com.sun.net.httpserver.HttpServer implementation and > other Sun classes with ones from the Java API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-274) Use another HTTPServer other than Suns
[ https://issues.apache.org/jira/browse/JOSHUA-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307685#comment-15307685 ] Matt Post commented on JOSHUA-274: -- Kellen, this is an interesting idea. In this model, if you wanted a server-based Joshua (with any kind of interface), you'd have to start an external server that just used this as a library. That would move a lot of the dependencies and complexity of multi-multi-threading (my term for round-robin multithreading across connections) outside core Joshua. I like this and think it might be the route to go, but want to think about it a bit more and discuss it. In any case, I'd want to postpone this change until after we merge JOSHUA-252 and possibly JOSHUA-273. > Use another HTTPServer other than Suns > -- > > Key: JOSHUA-274 > URL: https://issues.apache.org/jira/browse/JOSHUA-274 > Project: Joshua > Issue Type: Improvement > Components: decoders >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Priority: Critical > Fix For: 6.1 > > > This issue concerns the use of the > [HttpServer|https://github.com/apache/incubator-joshua/blob/master/src/joshua/decoder/JoshuaDecoder.java#L31] > within JoshuaDecoder.java. > We should replace the com.sun.net.httpserver.HttpServer implementation and > other Sun classes with ones from the Java API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-274) Use another HTTPServer other than Suns
[ https://issues.apache.org/jira/browse/JOSHUA-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307596#comment-15307596 ] Kellen Sunderland commented on JOSHUA-274: -- I would propose we don't put anything web server specific in the core Joshua jar. In my mind the Joshua package should really contain just a translation library. We could provide other jars with CLIs and a Restful service consuming this library (maybe even built by default). My reasoning is that if you are consuming Joshua strictly as a translation library you may prefer there be no web-service code there. If you're already hosting this code in your own web service it could be quite confusing to have similar functionality in the library you are exposing. Worse would be the case where through a configuration error you accidentally turn on a second web service (maybe on a different port). The other point I'd make is that by including http functionality in the main package we're adding a bunch of dependancies on things like json libs, etc. These dependancies could conflict with anyone wanting to use the package as a service. > Use another HTTPServer other than Suns > -- > > Key: JOSHUA-274 > URL: https://issues.apache.org/jira/browse/JOSHUA-274 > Project: Joshua > Issue Type: Improvement > Components: decoders >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Priority: Critical > Fix For: 6.1 > > > This issue concerns the use of the > [HttpServer|https://github.com/apache/incubator-joshua/blob/master/src/joshua/decoder/JoshuaDecoder.java#L31] > within JoshuaDecoder.java. > We should replace the com.sun.net.httpserver.HttpServer implementation and > other Sun classes with ones from the Java API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-274) Use another HTTPServer other than Suns
[ https://issues.apache.org/jira/browse/JOSHUA-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304890#comment-15304890 ] Thamme Gowda commented on JOSHUA-274: - +1 for embedded Tomcat or jetty > Use another HTTPServer other than Suns > -- > > Key: JOSHUA-274 > URL: https://issues.apache.org/jira/browse/JOSHUA-274 > Project: Joshua > Issue Type: Improvement > Components: decoders >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Priority: Critical > Fix For: 6.1 > > > This issue concerns the use of the > [HttpServer|https://github.com/apache/incubator-joshua/blob/master/src/joshua/decoder/JoshuaDecoder.java#L31] > within JoshuaDecoder.java. > We should replace the com.sun.net.httpserver.HttpServer implementation and > other Sun classes with ones from the Java API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
