[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[Matt Post (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572425#comment-15572425
 ] 

Matt Post commented on JOSHUA-299:
--

This was almost entirely completed, and we are marking it done. It has been 
completed on the 7 branch.

> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>  Time Spent: 2m
>  Remaining Estimate: 0h
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529664#comment-15529664
 ] 

Hudson commented on JOSHUA-299:
---

FAILURE: Integrated in Jenkins build joshua_master #122 (See 
[https://builds.apache.org/job/joshua_master/122/])
JOSHUA-299 Move regression tests to proper unit tests (lewis.mcgibbney: rev 
5dd80a37217f4f61ca00aedd256947a412e13771)
* (delete) src/test/java/org/apache/joshua/packed/test.sh
* (add) src/test/java/org/apache/joshua/decoder/package-info.java
* (edit) pom.xml
* (add) src/test/java/org/apache/joshua/decoder/TestTranslation.java
* (delete) src/test/java/org/apache/joshua/packed/VocabTest.java
* (edit) src/main/java/org/apache/joshua/decoder/segment_file/Sentence.java
* (edit) src/test/resources/decoder/moses-compat/output.expected
* (edit) src/main/java/org/apache/joshua/decoder/Translation.java


> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>  Time Spent: 2m
>  Remaining Estimate: 0h
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529492#comment-15529492
 ] 

ASF GitHub Bot commented on JOSHUA-299:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/67


> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>  Time Spent: 2m
>  Remaining Estimate: 0h
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510410#comment-15510410
 ] 

ASF GitHub Bot commented on JOSHUA-299:
---

Github user lewismc commented on the issue:

https://github.com/apache/incubator-joshua/pull/67
  
ack ;)


> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>  Time Spent: 2m
>  Remaining Estimate: 0h
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510376#comment-15510376
 ] 

ASF GitHub Bot commented on JOSHUA-299:
---

Github user KellenSunderland commented on the issue:

https://github.com/apache/incubator-joshua/pull/67
  
Looks good to me.  Some nice cleanup there as well.  I can't comment on the 
change to the output format except to say that i don't really understand what 
was there previously. #


> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>  Time Spent: 2m
>  Remaining Estimate: 0h
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510179#comment-15510179
 ] 

ASF GitHub Bot commented on JOSHUA-299:
---

GitHub user lewismc opened a pull request:

https://github.com/apache/incubator-joshua/pull/67

JOSHUA-299 Move regression tests to proper unit tests

Hi folks, this is one stage closer to us addressing 
https://issues.apache.org/jira/browse/JOSHUA-299

Of note here, I manually constructed the decoder output from essentially 
concatenating various output from a StructuredTranslation. What should be noted 
here is that we actually seem to loose some accuracy note the old file 
provided decoder output of ```0 ||| help ||| tm_glue_0=1.000 ||| 0.000``` 
whereas now we provide ```0 ||| help ||| tm_glue_0=1.0 ||| 0.0```

Any comments?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lewismc/incubator-joshua JOSHUA-299

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/67.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #67


commit 5dd80a37217f4f61ca00aedd256947a412e13771
Author: Lewis John McGibbney 
Date:   2016-09-21T14:53:21Z

JOSHUA-299 Move regression tests to proper unit tests




> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490103#comment-15490103
 ] 

ASF GitHub Bot commented on JOSHUA-299:
---

Github user mjpost commented on the issue:

https://github.com/apache/incubator-joshua/pull/54
  
Progress on JOSHUA-299.


> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[lewis john mcgibbney (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477498#comment-15477498
 ] 

lewis john mcgibbney commented on JOSHUA-299:
-

Mvn clean test is the way to go




-- 
http://home.apache.org/~lewismc/
@hectorMcSpector
http://www.linkedin.com/in/lmcgibbney


> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[Max Thomas (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477421#comment-15477421
 ] 

Max Thomas commented on JOSHUA-299:
---

I'm still getting about 50% failures - this is with everything set per the 
readme ($JOSHUA, ran download-deps.sh, etc.). do you want me to wait until 
these all pass, convert the successful ones, something else? 

I should be able to do this some time tonight. 

> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[Matt Post (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473794#comment-15473794
 ] 

Matt Post commented on JOSHUA-299:
--

[~maxthomas], here's some information on how to convert these, in case you have 
some time to do it today and tomorrow.

1. Change to $JOSHUA/src/test/resources, and run "bash run-all-tests.sh". This 
searches for all files test*.sh under the current directory, runs those tests, 
and reports success for ones that return 0 to the shell.

2. It should be clear what each test is doing, from the test script itself, and 
from an optional README. If not, you can leave those alone and I'll handle them.

3. As you convert each, commit the new test, and remove the shell script and 
associated extra files. If you could do each test conversion (creation of Java 
file, removal of no-longer-needed files) as its own git commit, it would help 
in tracking what's been done. This will all have to be merged into the 7 branch.

matt

> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[lewis john mcgibbney (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471850#comment-15471850
 ] 

lewis john mcgibbney commented on JOSHUA-299:
-

Nope did not sorry. Please progress!




-- 
http://home.apache.org/~lewismc/
@hectorMcSpector
http://www.linkedin.com/in/lmcgibbney


> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[Lewis John McGibbney (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432062#comment-15432062
 ] 

Lewis John McGibbney commented on JOSHUA-299:
-

I'll scope this issue tomorrow [~post] and see if I can get a PR together.

> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)