[jira] [Commented] (KAFKA-1566) Kafka environment configuration (kafka-env.sh)
[
https://issues.apache.org/jira/browse/KAFKA-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084788#comment-14084788
]
Cosmin Lehene commented on KAFKA-1566:
--
Somehow related: KAFKA_LOG_DIR would be better than setting KAFKA_LOG4J_OPTS.
kafka-run-class.sh would check for this
{code}
LOG_DIR=${KAFKA_LOG_DIR:-"$base_dir/logs"}
{code}
Perhaps a new issue may be useful (otherwise I could just add them to this
patch).
> Kafka environment configuration (kafka-env.sh)
> --
>
> Key: KAFKA-1566
> URL: https://issues.apache.org/jira/browse/KAFKA-1566
> Project: Kafka
> Issue Type: Improvement
> Components: tools
>Reporter: Cosmin Lehene
>Assignee: Cosmin Lehene
> Labels: newbie
> Fix For: 0.8.2, 0.9.0
>
>
> It would be useful (especially for automated deployments) to have an
> environment configuration file that could be sourced from the launcher files
> (e.g. kafka-run-server.sh).
> This is how this could look like kafka-env.sh
> {code}
> export KAFKA_JVM_PERFORMANCE_OPTS="-XX:+UseCompressedOops
> -XX:+DisableExplicitGC -Djava.awt.headless=true \ -XX:+UseG1GC
> -XX:PermSize=48m -XX:MaxPermSize=48m -XX:MaxGCPauseMillis=20
> -XX:InitiatingHeapOccupancyPercent=35' %>"
> export KAFKA_HEAP_OPTS="'-Xmx1G -Xms1G' %>"
> export KAFKA_LOG4J_OPTS="-Dkafka.logs.dir=/var/log/kafka"
> {code}
> kafka-server-start.sh
> {code}
> ...
> source $base_dir/config/kafka-env.sh
> ...
> {code}
> This approach is consistent with Hadoop and HBase. However the idea here is
> to be able to set these values in a single place without having to edit
> startup scripts.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (KAFKA-1566) Kafka environment configuration (kafka-env.sh)
[
https://issues.apache.org/jira/browse/KAFKA-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084778#comment-14084778
]
Cosmin Lehene commented on KAFKA-1566:
--
The convention is to have it in conf/
We can have an env variable for it's location.
We generate these files at deploy time (they are Puppet .erb templates in our
case) based on some versioned configuration.
> Kafka environment configuration (kafka-env.sh)
> --
>
> Key: KAFKA-1566
> URL: https://issues.apache.org/jira/browse/KAFKA-1566
> Project: Kafka
> Issue Type: Improvement
> Components: tools
>Reporter: Cosmin Lehene
>Assignee: Cosmin Lehene
> Labels: newbie
> Fix For: 0.8.2, 0.9.0
>
>
> It would be useful (especially for automated deployments) to have an
> environment configuration file that could be sourced from the launcher files
> (e.g. kafka-run-server.sh).
> This is how this could look like kafka-env.sh
> {code}
> export KAFKA_JVM_PERFORMANCE_OPTS="-XX:+UseCompressedOops
> -XX:+DisableExplicitGC -Djava.awt.headless=true \ -XX:+UseG1GC
> -XX:PermSize=48m -XX:MaxPermSize=48m -XX:MaxGCPauseMillis=20
> -XX:InitiatingHeapOccupancyPercent=35' %>"
> export KAFKA_HEAP_OPTS="'-Xmx1G -Xms1G' %>"
> export KAFKA_LOG4J_OPTS="-Dkafka.logs.dir=/var/log/kafka"
> {code}
> kafka-server-start.sh
> {code}
> ...
> source $base_dir/config/kafka-env.sh
> ...
> {code}
> This approach is consistent with Hadoop and HBase. However the idea here is
> to be able to set these values in a single place without having to edit
> startup scripts.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (KAFKA-1566) Kafka environment configuration (kafka-env.sh)
[
https://issues.apache.org/jira/browse/KAFKA-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cosmin Lehene updated KAFKA-1566:
-
Description:
It would be useful (especially for automated deployments) to have an
environment configuration file that could be sourced from the launcher files
(e.g. kafka-run-server.sh).
This is how this could look like kafka-env.sh
{code}
export KAFKA_JVM_PERFORMANCE_OPTS="-XX:+UseCompressedOops
-XX:+DisableExplicitGC -Djava.awt.headless=true \ -XX:+UseG1GC -XX:PermSize=48m
-XX:MaxPermSize=48m -XX:MaxGCPauseMillis=20
-XX:InitiatingHeapOccupancyPercent=35' %>"
export KAFKA_HEAP_OPTS="'-Xmx1G -Xms1G' %>"
export KAFKA_LOG4J_OPTS="-Dkafka.logs.dir=/var/log/kafka"
{code}
kafka-server-start.sh
{code}
...
source $base_dir/config/kafka-env.sh
...
{code}
This approach is consistent with Hadoop and HBase. However the idea here is to
be able to set these values in a single place without having to edit startup
scripts.
was:
It would be useful (especially for automated deployments) to have an
environment configuration file that could be sourced from the launcher files
(e.g. kafka-run-server.sh).
This is how this could look like kafka-env.sh
{code}
export KAFKA_JVM_PERFORMANCE_OPTS="-XX:+UseCompressedOops
-XX:+DisableExplicitGC -Djava.awt.headless=true \ -XX:+UseG1GC -XX:PermSize=48m
-XX:MaxPermSize=48m -XX:MaxGCPauseMillis=20
-XX:InitiatingHeapOccupancyPercent=35' %>" export KAFKA_HEAP_OPTS="'-Xmx1G
-Xms1G' %>" export KAFKA_LOG4J_OPTS="-Dkafka.logs.dir=/var/log/kafka"
{code}
kafka-server-start.sh
{code}
...
source $base_dir/config/kafka-env.sh
...
{code}
This approach is consistent with Hadoop and HBase. However the idea here is to
be able to set these values in a single place without having to edit startup
scripts.
> Kafka environment configuration (kafka-env.sh)
> --
>
> Key: KAFKA-1566
> URL: https://issues.apache.org/jira/browse/KAFKA-1566
> Project: Kafka
> Issue Type: Improvement
> Components: tools
>Reporter: Cosmin Lehene
>Assignee: Cosmin Lehene
> Fix For: 0.8.2, 0.9.0
>
>
> It would be useful (especially for automated deployments) to have an
> environment configuration file that could be sourced from the launcher files
> (e.g. kafka-run-server.sh).
> This is how this could look like kafka-env.sh
> {code}
> export KAFKA_JVM_PERFORMANCE_OPTS="-XX:+UseCompressedOops
> -XX:+DisableExplicitGC -Djava.awt.headless=true \ -XX:+UseG1GC
> -XX:PermSize=48m -XX:MaxPermSize=48m -XX:MaxGCPauseMillis=20
> -XX:InitiatingHeapOccupancyPercent=35' %>"
> export KAFKA_HEAP_OPTS="'-Xmx1G -Xms1G' %>"
> export KAFKA_LOG4J_OPTS="-Dkafka.logs.dir=/var/log/kafka"
> {code}
> kafka-server-start.sh
> {code}
> ...
> source $base_dir/config/kafka-env.sh
> ...
> {code}
> This approach is consistent with Hadoop and HBase. However the idea here is
> to be able to set these values in a single place without having to edit
> startup scripts.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (KAFKA-1566) Kafka environment configuration (kafka-env.sh)
Cosmin Lehene created KAFKA-1566:
Summary: Kafka environment configuration (kafka-env.sh)
Key: KAFKA-1566
URL: https://issues.apache.org/jira/browse/KAFKA-1566
Project: Kafka
Issue Type: Improvement
Components: tools
Reporter: Cosmin Lehene
Assignee: Cosmin Lehene
Fix For: 0.8.2, 0.9.0
It would be useful (especially for automated deployments) to have an
environment configuration file that could be sourced from the launcher files
(e.g. kafka-run-server.sh).
This is how this could look like kafka-env.sh
{code}
export KAFKA_JVM_PERFORMANCE_OPTS="-XX:+UseCompressedOops
-XX:+DisableExplicitGC -Djava.awt.headless=true \ -XX:+UseG1GC -XX:PermSize=48m
-XX:MaxPermSize=48m -XX:MaxGCPauseMillis=20
-XX:InitiatingHeapOccupancyPercent=35' %>" export KAFKA_HEAP_OPTS="'-Xmx1G
-Xms1G' %>" export KAFKA_LOG4J_OPTS="-Dkafka.logs.dir=/var/log/kafka"
{code}
kafka-server-start.sh
{code}
...
source $base_dir/config/kafka-env.sh
...
{code}
This approach is consistent with Hadoop and HBase. However the idea here is to
be able to set these values in a single place without having to edit startup
scripts.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (KAFKA-854) Upgrade dependencies for 0.8
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941783#comment-13941783 ] Cosmin Lehene commented on KAFKA-854: - We've upgraded our internal branch to 3.4.5 back then. it's been running fine (in production). We'll soon upgrade to the recently released 3.4.6 probably. > Upgrade dependencies for 0.8 > > > Key: KAFKA-854 > URL: https://issues.apache.org/jira/browse/KAFKA-854 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.8.0 >Reporter: Scott Carey > Attachments: 0001-KAFKA-854-Upgrade-Deps-to-latest.patch, > KAFKA-854.patch, KAFKA-854.patch, KAFKA-854.patch > > > Many of the dependencies that Kafka 0.8 uses are old. It would be a good > idea to upgrade all of these where possible. > log4j is set to 1.2.15, but the latest is 1.2.17 > zookeeper is at 3.3.4, , there is 3.3.6 (August 2012), and 3.4.5 (Nov 2012. > 3.4.x includes several major enhancements and fixes over the 3.3.x line. > org.slf4j is at 1.6.4, there is 1.6.6 (June 2012) and 1.7.5 (March 2013) > net.sf.jopt-simple is at 3.2, there is 3.3 (May 2011) and 4.4 (Jan 2013) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-347) change number of partitions of a topic online
[ https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13730616#comment-13730616 ] Cosmin Lehene commented on KAFKA-347: - Is there some operational documentation on how to use this? > change number of partitions of a topic online > - > > Key: KAFKA-347 > URL: https://issues.apache.org/jira/browse/KAFKA-347 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 0.8 >Reporter: Jun Rao >Assignee: Sriram Subramanian > Labels: features > Fix For: 0.8.1 > > Attachments: kafka-347.patch, kafka-347-v2.patch, > KAFKA-347-v2-rebased.patch, KAFKA-347-v3.patch, KAFKA-347-v4.patch, > KAFKA-347-v5.patch > > > We will need an admin tool to change the number of partitions of a topic > online. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-960) Upgrade Metrics to 3.x
[ https://issues.apache.org/jira/browse/KAFKA-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699785#comment-13699785 ] Cosmin Lehene commented on KAFKA-960: - [~jkreps] That might make sense. I spent a few hours yesterday fixing runtime errors and then hunting lib conflicts and dealing with Maven exclusion quirks. > Upgrade Metrics to 3.x > -- > > Key: KAFKA-960 > URL: https://issues.apache.org/jira/browse/KAFKA-960 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.8 >Reporter: Cosmin Lehene > Fix For: 0.8 > > > Now that metrics 3.0 has been released > (http://metrics.codahale.com/about/release-notes/) we can upgrade back -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-960) Upgrade Metrics to 3.x
[ https://issues.apache.org/jira/browse/KAFKA-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699389#comment-13699389 ] Cosmin Lehene commented on KAFKA-960: - [~jjkoshy] I was going to set it back on 3.x on our internal branch. Are you aware of any issues with 3.x that would make it advisable not to? > Upgrade Metrics to 3.x > -- > > Key: KAFKA-960 > URL: https://issues.apache.org/jira/browse/KAFKA-960 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.8 >Reporter: Cosmin Lehene > Fix For: 0.8 > > > Now that metrics 3.0 has been released > (http://metrics.codahale.com/about/release-notes/) we can upgrade back -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699191#comment-13699191 ] Cosmin Lehene commented on KAFKA-826: - https://issues.apache.org/jira/browse/KAFKA-960 > Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x > - > > Key: KAFKA-826 > URL: https://issues.apache.org/jira/browse/KAFKA-826 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.8 >Reporter: Neha Narkhede >Assignee: Dragos Manolescu >Priority: Blocker > Labels: build, kafka-0.8, metrics > Fix For: 0.8 > > Attachments: kafka-fix-for-826-complete.patch, > kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch > > > In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since > metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (KAFKA-960) Upgrade Metrics to 3.x
Cosmin Lehene created KAFKA-960: --- Summary: Upgrade Metrics to 3.x Key: KAFKA-960 URL: https://issues.apache.org/jira/browse/KAFKA-960 Project: Kafka Issue Type: Improvement Affects Versions: 0.8 Reporter: Cosmin Lehene Fix For: 0.8 Now that metrics 3.0 has been released (http://metrics.codahale.com/about/release-notes/) we can upgrade back -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698935#comment-13698935 ] Cosmin Lehene edited comment on KAFKA-826 at 7/3/13 1:13 PM: - Now that metrics 3.0 has been released (http://metrics.codahale.com/about/release-notes/) perhaps we should consider upgrading it back? was (Author: clehene): Now that metrics 3.0 has been relesed (http://metrics.codahale.com/about/release-notes/) perhaps we should consider upgrading it back? > Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x > - > > Key: KAFKA-826 > URL: https://issues.apache.org/jira/browse/KAFKA-826 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.8 >Reporter: Neha Narkhede >Assignee: Dragos Manolescu >Priority: Blocker > Labels: build, kafka-0.8, metrics > Fix For: 0.8 > > Attachments: kafka-fix-for-826-complete.patch, > kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch > > > In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since > metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698935#comment-13698935 ] Cosmin Lehene commented on KAFKA-826: - Now that metrics 3.0 has been relesed (http://metrics.codahale.com/about/release-notes/) perhaps we should consider upgrading it back? > Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x > - > > Key: KAFKA-826 > URL: https://issues.apache.org/jira/browse/KAFKA-826 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.8 >Reporter: Neha Narkhede >Assignee: Dragos Manolescu >Priority: Blocker > Labels: build, kafka-0.8, metrics > Fix For: 0.8 > > Attachments: kafka-fix-for-826-complete.patch, > kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch > > > In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since > metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-843) Re-add the release-zip sbt target
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cosmin Lehene updated KAFKA-843: Attachment: 0001-KAFKA-843-Addendum-comply-with-Semantic-Versioning-2.patch Added new patch that fixes: - extra zip in target dir - IO.zip hangs if zip file already there - proper path filtering for zip target > Re-add the release-zip sbt target > - > > Key: KAFKA-843 > URL: https://issues.apache.org/jira/browse/KAFKA-843 > Project: Kafka > Issue Type: Sub-task > Components: packaging >Affects Versions: 0.8 >Reporter: Cosmin Lehene >Assignee: Cosmin Lehene > Fix For: 0.8 > > Attachments: > 0001-KAFKA-843-Addendum-comply-with-Semantic-Versioning-2.patch, > 0001-KAFKA-843-Addendum-comply-with-Semantic-Versioning-2.patch, > KAFKA-843.patch, KAFKA-843.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > This target has been removed a while ago. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-843) Re-add the release-zip sbt target
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632656#comment-13632656 ] Cosmin Lehene commented on KAFKA-843: - [~junrao] Is the last patch ok? > Re-add the release-zip sbt target > - > > Key: KAFKA-843 > URL: https://issues.apache.org/jira/browse/KAFKA-843 > Project: Kafka > Issue Type: Sub-task > Components: packaging >Affects Versions: 0.8 >Reporter: Cosmin Lehene >Assignee: Cosmin Lehene > Fix For: 0.8 > > Attachments: > 0001-KAFKA-843-Addendum-comply-with-Semantic-Versioning-2.patch, > KAFKA-843.patch, KAFKA-843.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > This target has been removed a while ago. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (KAFKA-843) Re-add the release-zip sbt target
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630955#comment-13630955 ] Cosmin Lehene edited comment on KAFKA-843 at 4/13/13 6:01 AM: -- Attached an addendum (applies over 0.8 with previous patch) that includes the discussed changes. It complies to Semantic Versioning 2.0.0-rc.1 (http://semver.org/) Changes: * version includes major minor and patch and pre-release version, hence it's 0.8.0-SNAPSHOT * build number is optional and is appended with a plus sign, hence if build number is 199 the full version will be 0.8.0-SNAPSHOT+199 I suggest sticking to semantic versioning. It's not anything new, it's just very clear and easy to explain and rely on. Also, handling versioning should probably be done using a release plugin like sbt-release (https://github.com/sbt/sbt-release) so we avoid cluttering the Build.scala file. was (Author: clehene): Attached an addendum (applies over 0.8 with previous patch) that includes the discussed changes. It complies to Semantic Versioning 2.0.0-rc.1 (http://semver.org/) Changes: * version includes major minor and patch and pre-release version, hence it's 0.8.0-SNAPSHOT * build number is optional and is appended with a plus sign, hence if build number is 199 the full version will be 0.8.0-SNAPSHOT+199 I suggest sticking to semantic versioning. It's not anything new, it's just very clear and easy to explain and rely on. Also, handling versioning should probably be done using a release plugin like [https://github.com/sbt/sbt-release|sbt-release] so we avoid cluttering the Build.scala file. > Re-add the release-zip sbt target > - > > Key: KAFKA-843 > URL: https://issues.apache.org/jira/browse/KAFKA-843 > Project: Kafka > Issue Type: Sub-task > Components: packaging >Affects Versions: 0.8 >Reporter: Cosmin Lehene >Assignee: Cosmin Lehene > Fix For: 0.8 > > Attachments: > 0001-KAFKA-843-Addendum-comply-with-Semantic-Versioning-2.patch, > KAFKA-843.patch, KAFKA-843.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > This target has been removed a while ago. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (KAFKA-843) Re-add the release-zip sbt target
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630955#comment-13630955 ] Cosmin Lehene edited comment on KAFKA-843 at 4/13/13 6:00 AM: -- Attached an addendum (applies over 0.8 with previous patch) that includes the discussed changes. It complies to Semantic Versioning 2.0.0-rc.1 (http://semver.org/) Changes: * version includes major minor and patch and pre-release version, hence it's 0.8.0-SNAPSHOT * build number is optional and is appended with a plus sign, hence if build number is 199 the full version will be 0.8.0-SNAPSHOT+199 I suggest sticking to semantic versioning. It's not anything new, it's just very clear and easy to explain and rely on. Also, handling versioning should probably be done using a release plugin like [https://github.com/sbt/sbt-release|sbt-release] so we avoid cluttering the Build.scala file. was (Author: clehene): Attached an addendum (applies over 0.8 with previous patch) that includes the discussed changes. It complies to Semantic Versioning 2.0.0-rc.1 (http://semver.org/) Changes: # version includes major minor and patch and pre-release version, hence it's 0.8.0-SNAPSHOT # build number is optional and is appended with a plus sign, hence if build number is 199 the full version will be 0.8.0-SNAPSHOT+199 I suggest sticking to semantic versioning. It's not anything new, it's just very clear and easy to explain and rely on. Also, handling versioning should probably be done using a release plugin like [sbt-release|https://github.com/sbt/sbt-release] so we avoid cluttering the Build.scala file. > Re-add the release-zip sbt target > - > > Key: KAFKA-843 > URL: https://issues.apache.org/jira/browse/KAFKA-843 > Project: Kafka > Issue Type: Sub-task > Components: packaging >Affects Versions: 0.8 >Reporter: Cosmin Lehene >Assignee: Cosmin Lehene > Fix For: 0.8 > > Attachments: > 0001-KAFKA-843-Addendum-comply-with-Semantic-Versioning-2.patch, > KAFKA-843.patch, KAFKA-843.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > This target has been removed a while ago. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-843) Re-add the release-zip sbt target
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cosmin Lehene updated KAFKA-843: Attachment: 0001-KAFKA-843-Addendum-comply-with-Semantic-Versioning-2.patch Attached an addendum (applies over 0.8 with previous patch) that includes the discussed changes. It complies to Semantic Versioning 2.0.0-rc.1 (http://semver.org/) Changes: # version includes major minor and patch and pre-release version, hence it's 0.8.0-SNAPSHOT # build number is optional and is appended with a plus sign, hence if build number is 199 the full version will be 0.8.0-SNAPSHOT+199 I suggest sticking to semantic versioning. It's not anything new, it's just very clear and easy to explain and rely on. Also, handling versioning should probably be done using a release plugin like [sbt-release|https://github.com/sbt/sbt-release] so we avoid cluttering the Build.scala file. > Re-add the release-zip sbt target > - > > Key: KAFKA-843 > URL: https://issues.apache.org/jira/browse/KAFKA-843 > Project: Kafka > Issue Type: Sub-task > Components: packaging >Affects Versions: 0.8 >Reporter: Cosmin Lehene >Assignee: Cosmin Lehene > Fix For: 0.8 > > Attachments: > 0001-KAFKA-843-Addendum-comply-with-Semantic-Versioning-2.patch, > KAFKA-843.patch, KAFKA-843.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > This target has been removed a while ago. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-843) Re-add the release-zip sbt target
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629422#comment-13629422 ] Cosmin Lehene commented on KAFKA-843: - We have a Puppet based deployment so we'll end up deploying multiple snapshots on the testing environments, we use build number to track those. Here are some ideas on both why you'd want additional information with the version as well as how you may do it right http://semver.org/ > Re-add the release-zip sbt target > - > > Key: KAFKA-843 > URL: https://issues.apache.org/jira/browse/KAFKA-843 > Project: Kafka > Issue Type: Sub-task > Components: packaging >Affects Versions: 0.8 >Reporter: Cosmin Lehene >Assignee: Cosmin Lehene > Fix For: 0.8 > > Attachments: KAFKA-843.patch, KAFKA-843.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > This target has been removed a while ago. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-843) Re-add the release-zip sbt target
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629417#comment-13629417 ] Cosmin Lehene commented on KAFKA-843: - Perhaps, then, append -buildNumber if build.number non empty and leve it as is if absent? > Re-add the release-zip sbt target > - > > Key: KAFKA-843 > URL: https://issues.apache.org/jira/browse/KAFKA-843 > Project: Kafka > Issue Type: Sub-task > Components: packaging >Affects Versions: 0.8 >Reporter: Cosmin Lehene >Assignee: Cosmin Lehene > Fix For: 0.8 > > Attachments: KAFKA-843.patch, KAFKA-843.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > This target has been removed a while ago. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (KAFKA-843) Re-add the release-zip sbt target
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629417#comment-13629417 ] Cosmin Lehene edited comment on KAFKA-843 at 4/11/13 9:27 PM: -- Perhaps, then, append -buildNumber if build.number non empty and leave it as is if absent? was (Author: clehene): Perhaps, then, append -buildNumber if build.number non empty and leve it as is if absent? > Re-add the release-zip sbt target > - > > Key: KAFKA-843 > URL: https://issues.apache.org/jira/browse/KAFKA-843 > Project: Kafka > Issue Type: Sub-task > Components: packaging >Affects Versions: 0.8 >Reporter: Cosmin Lehene >Assignee: Cosmin Lehene > Fix For: 0.8 > > Attachments: KAFKA-843.patch, KAFKA-843.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > This target has been removed a while ago. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-843) Re-add the release-zip sbt target
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629238#comment-13629238 ] Cosmin Lehene commented on KAFKA-843: - [~scott_carey] fi an empty build number is passed it will set it to SNAPSHOT. The build number is used by various CI servers (e.g. Jenkins) by setting the BUILD_NUMBER environment variable. This is passed through the sbt script (-Dbuild.number=$BUILD_NUMBER) Here's an example of a plugin that does something similar https://github.com/guardian/sbt-version-info-plugin > Re-add the release-zip sbt target > - > > Key: KAFKA-843 > URL: https://issues.apache.org/jira/browse/KAFKA-843 > Project: Kafka > Issue Type: Sub-task > Components: packaging >Affects Versions: 0.8 >Reporter: Cosmin Lehene >Assignee: Cosmin Lehene > Fix For: 0.8 > > Attachments: KAFKA-843.patch, KAFKA-843.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > This target has been removed a while ago. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-843) Re-add the release-zip sbt target
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629123#comment-13629123 ] Cosmin Lehene commented on KAFKA-843: - Jun, I posted the question to the sbt mailing lists about the tasks. It may be an sbt issue. Can we go ahead with it? Thanks, Cosmin > Re-add the release-zip sbt target > - > > Key: KAFKA-843 > URL: https://issues.apache.org/jira/browse/KAFKA-843 > Project: Kafka > Issue Type: Sub-task > Components: packaging >Affects Versions: 0.8 >Reporter: Cosmin Lehene > Fix For: 0.8 > > Attachments: KAFKA-843.patch, KAFKA-843.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > This target has been removed a while ago. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-843) Re-add the release-zip sbt target
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cosmin Lehene updated KAFKA-843: Attachment: KAFKA-843.patch Changed the patch so that both zip and tar are created in the target/RELEASE dir. I wasn't able to make the taks show up with ./sbt tasks > Re-add the release-zip sbt target > - > > Key: KAFKA-843 > URL: https://issues.apache.org/jira/browse/KAFKA-843 > Project: Kafka > Issue Type: Sub-task > Components: packaging >Affects Versions: 0.8 >Reporter: Cosmin Lehene > Fix For: 0.8 > > Attachments: KAFKA-843.patch, KAFKA-843.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > This target has been removed a while ago. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (KAFKA-854) Upgrade dependencies for 0.8
[ https://issues.apache.org/jira/browse/KAFKA-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627725#comment-13627725 ] Cosmin Lehene edited comment on KAFKA-854 at 4/10/13 12:25 PM: --- See KAFKA-843 for release-zip / release-tar tasks it may conflict :) was (Author: clehene): release-zip / release-tar tasks it may conflict :) > Upgrade dependencies for 0.8 > > > Key: KAFKA-854 > URL: https://issues.apache.org/jira/browse/KAFKA-854 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.8 >Reporter: Scott Carey > Attachments: 0001-KAFKA-854-Upgrade-Deps-to-latest.patch, > KAFKA-854.patch, KAFKA-854.patch > > > Many of the dependencies that Kafka 0.8 uses are old. It would be a good > idea to upgrade all of these where possible. > log4j is set to 1.2.15, but the latest is 1.2.17 > zookeeper is at 3.3.4, , there is 3.3.6 (August 2012), and 3.4.5 (Nov 2012. > 3.4.x includes several major enhancements and fixes over the 3.3.x line. > org.slf4j is at 1.6.4, there is 1.6.6 (June 2012) and 1.7.5 (March 2013) > net.sf.jopt-simple is at 3.2, there is 3.3 (May 2011) and 4.4 (Jan 2013) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (KAFKA-843) Re-add the release-zip sbt target
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627720#comment-13627720 ] Cosmin Lehene edited comment on KAFKA-843 at 4/10/13 12:22 PM: --- added release, release-zip, release-tar tasks along with the possibility to take the build number (defaults to SNAPSHOT) from BUILD_NUMBER environment variable (common with jenkins and other build servers) There are several plugins that are related (sbt/sbt-release, sbt/sbt-native-packager, guardian/sbt-dist-plugin, guardian/sbt-version-info-plugin, twitter/sbt-package-dist). I initially tried sbt-package-dist, but it has to be rebuilt in order to work with sbt 0.12 and it seems to be more or less dead. This was my first encounter with sbt so it might not be as idiomatic as it should be. was (Author: clehene): added release, release-zip, release-tar tasks along with the possibility to take the build number from BUILD_NUMBER environment variable (common with jenkins and other build servers) There are several plugins that are related (sbt/sbt-release, sbt/sbt-native-packager, guardian/sbt-dist-plugin, guardian/sbt-version-info-plugin, twitter/sbt-package-dist). I initially tried sbt-package-dist, but it has to be rebuilt in order to work with sbt 0.12 and it seems to be more or less dead. This was my first encounter with sbt so it might not be as idiomatic as it should be. > Re-add the release-zip sbt target > - > > Key: KAFKA-843 > URL: https://issues.apache.org/jira/browse/KAFKA-843 > Project: Kafka > Issue Type: Sub-task > Components: packaging >Affects Versions: 0.8 >Reporter: Cosmin Lehene > Fix For: 0.8 > > Attachments: KAFKA-843.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > This target has been removed a while ago. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-843) Re-add the release-zip sbt target
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cosmin Lehene updated KAFKA-843: Affects Version/s: 0.8 Status: Patch Available (was: Open) added release, release-zip, release-tar tasks along with the possibility to take the build number from BUILD_NUMBER environment variable (common with jenkins and other build servers) There are several plugins that are related (sbt/sbt-release, sbt/sbt-native-packager, guardian/sbt-dist-plugin, guardian/sbt-version-info-plugin, twitter/sbt-package-dist). I initially tried sbt-package-dist, but it has to be rebuilt in order to work with sbt 0.12 and it seems to be more or less dead. This was my first encounter with sbt so it might not be as idiomatic as it should be. > Re-add the release-zip sbt target > - > > Key: KAFKA-843 > URL: https://issues.apache.org/jira/browse/KAFKA-843 > Project: Kafka > Issue Type: Sub-task > Components: packaging >Affects Versions: 0.8 >Reporter: Cosmin Lehene > Fix For: 0.8 > > Attachments: KAFKA-843.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > This target has been removed a while ago. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-843) Re-add the release-zip sbt target
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cosmin Lehene updated KAFKA-843: Attachment: KAFKA-843.patch > Re-add the release-zip sbt target > - > > Key: KAFKA-843 > URL: https://issues.apache.org/jira/browse/KAFKA-843 > Project: Kafka > Issue Type: Sub-task > Components: packaging >Affects Versions: 0.8 >Reporter: Cosmin Lehene > Fix For: 0.8 > > Attachments: KAFKA-843.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > This target has been removed a while ago. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (KAFKA-835) Update 0.8 configs on the website
[ https://issues.apache.org/jira/browse/KAFKA-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619743#comment-13619743 ] Cosmin Lehene edited comment on KAFKA-835 at 4/2/13 12:29 PM: -- What exactly needs to be updated (wiki or something in the source repo)? One change that I noticed was brokerid renamed to broker.id was (Author: clehene): What exactly needs to be updated (wiki or something in the source repo)? One change I noticed was brokerid renamed to broker.id > Update 0.8 configs on the website > - > > Key: KAFKA-835 > URL: https://issues.apache.org/jira/browse/KAFKA-835 > Project: Kafka > Issue Type: Sub-task >Affects Versions: 0.8 >Reporter: Neha Narkhede > > We renamed existing configs and also added new configs in 0.8. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-835) Update 0.8 configs on the website
[ https://issues.apache.org/jira/browse/KAFKA-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619743#comment-13619743 ] Cosmin Lehene commented on KAFKA-835: - What exactly needs to be updated (wiki or something in the source repo)? One change I noticed was brokerid renamed to broker.id > Update 0.8 configs on the website > - > > Key: KAFKA-835 > URL: https://issues.apache.org/jira/browse/KAFKA-835 > Project: Kafka > Issue Type: Sub-task >Affects Versions: 0.8 >Reporter: Neha Narkhede > > We renamed existing configs and also added new configs in 0.8. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (KAFKA-843) Re-add the release-zip sbt target
Cosmin Lehene created KAFKA-843: --- Summary: Re-add the release-zip sbt target Key: KAFKA-843 URL: https://issues.apache.org/jira/browse/KAFKA-843 Project: Kafka Issue Type: Sub-task Components: packaging Reporter: Cosmin Lehene Fix For: 0.8 This target has been removed a while ago. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
