[GitHub] kafka pull request #4120: Make CONSOLE_OUTPUT_FILE configurable
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/4120 Make CONSOLE_OUTPUT_FILE configurable Even if Kafka is not configured without the console appender the CONSOLE_OUTPUT_FILE is generated. Allowing for this to be configurable offers more flexibility including redirecting `nohup.out` or the resulting redirect to `/dev/null` You can merge this pull request into a Git repository by running: $ git pull https://github.com/rnpridgeon/kafka patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4120.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4120 commit 7f675114c7d9b335ab38066f411a06735f74fdf3 Author: Ryan P <ryan.n.pridg...@gmail.com> Date: 2017-10-23T14:45:57Z Make CONSOLE_OUTPUT_FILE configurable Even if Kafka is not configured without the console appender the CONSOLE_OUTPUT_FILE is generated. Allowing for this to be configurable offers more flexibility including redirecting `nohup.out` or the resulting redirect to `/dev/null` ---
[GitHub] kafka pull request #3608: KAFKA-5691- handle NOAUTH in zkUtils.CreateRecursi...
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/3608 KAFKA-5691- handle NOAUTH in zkUtils.CreateRecursive Currently old consumers are unable to register with secure ZK installations. Handling NOAUTH prevents failures when checking /consumers You can merge this pull request into a Git repository by running: $ git pull https://github.com/rnpridgeon/kafka trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3608.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3608 commit 55a4be21e95b5499272e00e0f9f430bde0a9724a Author: rnpridgeon <ryan.n.pridg...@gmail.com> Date: 2017-08-02T03:20:11Z KAFKA-5691- handle NOAUTH in zkUtils.CreateRecursive --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2714: Fix ZKSec Migrate example
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/2714 Fix ZKSec Migrate example Incorrect option in example https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/admin/ZkSecurityMigrator.scala#L71 You can merge this pull request into a Git repository by running: $ git pull https://github.com/rnpridgeon/kafka patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2714.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2714 commit 2b8d43f4e3760dcda038cb81526f5c66e9c8889c Author: Ryan P <ryan.n.pridg...@gmail.com> Date: 2017-03-20T17:08:02Z Fix ZKSec Migrate example Incorrect option in example https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/admin/ZkSecurityMigrator.scala#L71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2533: Checking the Timestamp is insufficient
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/2533 Checking the Timestamp is insufficient My understanding is that the record format allots 1 bit for the timestamp type field. As a result it can be either 1 or 0 and never -1. This means Connect's timestamp type validation is insufficient. Instead the records timestamp value itself should be checked. Technically the timestamp value should never be another negative value but while we are being defensive we may as well go all the way. Doing so inside Connect takes the burden off Connector developers which I think is a good thing. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rnpridgeon/kafka no_timestamp Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2533.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2533 commit cd4d8130ce2fa3a5f864bf65c7b610aaf72d4d0d Author: rnpridgeon <ryan.n.pridg...@gmail.com> Date: 2017-02-10T11:17:38Z Checking the Timestamp is insufficient --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2334: subset of KAFKA-4353: Add uuid
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/2334 subset of KAFKA-4353: Add uuid Alternatively I am open to using Avro's 'Fixed' type with a 16 byte size. However most requests I have seen received wish to see UUID represented as type String so I went with that to start. Also I just realized that Intellij's 'optimized imports' squashed the import list. Follow-up commit soon to follow with expanded import list You can merge this pull request into a Git repository by running: $ git pull https://github.com/rnpridgeon/kafka add_uuid Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2334.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2334 commit 8413f7d558e6c9b1a4bfe580c6557e4fc337ed97 Author: rnpridgeon <ryan.n.pridg...@gmail.com> Date: 2017-01-09T11:28:24Z Add UUID logical type commit fdbce61dd1eefcaf08276a19d3e424e33d78cbba Author: rnpridgeon <ryan.n.pridg...@gmail.com> Date: 2017-01-09T11:49:19Z Add UUID logical type (fix tests) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2248: add instrumentation to follower local time
Github user rnpridgeon closed the pull request at: https://github.com/apache/kafka/pull/2248 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2248: add instrumentation to follower local time
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/2248 add instrumentation to follower local time You can merge this pull request into a Git repository by running: $ git pull https://github.com/junrao/kafka instrument-0.9.0 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2248.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2248 commit 04ffe1abe877201b52c928392ecac8ce8e31bef6 Author: Jun Rao <jun...@gmail.com> Date: 2016-12-12T21:48:32Z add instrumentation to follower local time --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2115: KAFKA-4364: Remove secrets from DEBUG logging
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/2115 KAFKA-4364: Remove secrets from DEBUG logging leverage fix from KAFKA-2690 to remove secrets from task logging You can merge this pull request into a Git repository by running: $ git pull https://github.com/rnpridgeon/kafka KAFKA-4364 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2115.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2115 commit fe1f1f2cca6cd1b3255ef89eac2d6062a17e7079 Author: rnpridgeon <ryan.n.pridg...@gmail.com> Date: 2016-11-08T23:35:09Z KAFKA-4364: Remove secrets from DEBUG logging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1856: Allow underscores in hostname
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/1856 Allow underscores in hostname Technically this does not strictly adhere to RFC-952 however it is valid for domain names, urls and uris so we should loosen the requirements a tad. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rnpridgeon/kafka KAFKA-3719 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1856.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1856 commit 75a4441bdca0b603f1590150040cad82e0dd11f0 Author: rnpridgeon <ryan.n.pridg...@gmail.com> Date: 2016-09-14T19:51:25Z Allow underscores for increased flexibility despite compliance issues with RFC-RFC-952 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1658: Kafka 3689 - process only distinct connectionIds w...
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/1658 Kafka 3689 - process only distinct connectionIds within processDisconnected() @ijuma discovered a possible scenario in which connectionQuotas may be [doubly-decremented](https://issues.apache.org/jira/browse/KAFKA-3689?focusedCommentId=15385962=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15385962) This PR intends to remove that possibility by first filtering out any duplicate connectionIds. This way each You can merge this pull request into a Git repository by running: $ git pull https://github.com/rnpridgeon/kafka KAFKA-3689 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1658.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1658 commit 59077eff1e26eb6bae590188d9d1d6fa1166cfe9 Author: rnpridgeon <ryan.n.pridg...@gmail.com> Date: 2016-07-21T22:09:47Z KAFKA-3983 - Add additional information to debug logging to aid in debugging efforts commit 35e85eb4871a4b76f3bb2141a971c92140a0c338 Author: rnpridgeon <ryan.n.pridg...@gmail.com> Date: 2016-07-22T14:29:25Z Edits per review in pull 1648 commit 44a1b0dce6c8f0948ed24ae23d35ce0f16fff860 Author: rnpridgeon <ryan.n.pridg...@gmail.com> Date: 2016-07-23T13:11:25Z Merge remote-tracking branch 'upstream/trunk' into trunk commit a2d8acf96d470319542ca9db3e5260220c27d22c Author: rnpridgeon <ryan.n.pridg...@gmail.com> Date: 2016-07-24T12:54:26Z KAFKA-3689 - process only distinct connectionIds within processDisconnected() --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1657: Kafka 3986
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/1657 Kafka 3986 Add null check to guard against the unlikely event where a channel has been closed but not yet removed from completedReceives You can merge this pull request into a Git repository by running: $ git pull https://github.com/rnpridgeon/kafka KAFKA-3986 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1657.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1657 commit 59077eff1e26eb6bae590188d9d1d6fa1166cfe9 Author: rnpridgeon <ryan.n.pridg...@gmail.com> Date: 2016-07-21T22:09:47Z KAFKA-3983 - Add additional information to debug logging to aid in debugging efforts commit 35e85eb4871a4b76f3bb2141a971c92140a0c338 Author: rnpridgeon <ryan.n.pridg...@gmail.com> Date: 2016-07-22T14:29:25Z Edits per review in pull 1648 commit 44a1b0dce6c8f0948ed24ae23d35ce0f16fff860 Author: rnpridgeon <ryan.n.pridg...@gmail.com> Date: 2016-07-23T13:11:25Z Merge remote-tracking branch 'upstream/trunk' into trunk commit 7dc33c2643e9ff7385fe8a3964f4060b61507a1f Author: rnpridgeon <ryan.n.pridg...@gmail.com> Date: 2016-07-23T13:15:51Z KAFKA-3986 Add null check in the event that a channel has been closed but not yet removed from completedReceives --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1648: KAFKA-3983 - Add additional information to debug
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/1648 KAFKA-3983 - Add additional information to debug Add additional information to Acceptor debug message upon connection acceptance You can merge this pull request into a Git repository by running: $ git pull https://github.com/rnpridgeon/kafka trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1648.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1648 commit 59077eff1e26eb6bae590188d9d1d6fa1166cfe9 Author: rnpridgeon <ryan.n.pridg...@gmail.com> Date: 2016-07-21T22:09:47Z KAFKA-3983 - Add additional information to debug logging to aid in debugging efforts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3754 Add GC log retention policy to limi...
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/1431 KAFKA-3754 Add GC log retention policy to limit size of log Add a default log retention policy to keep GC logs from growing too large You can merge this pull request into a Git repository by running: $ git pull https://github.com/rnpridgeon/kafka KAFKA-3754 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1431.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1431 commit 9732f5fe45ce35d32783669683ac65ac34e4c889 Author: Ryan P <ryan.n.pridg...@gmail.com> Date: 2016-05-25T21:48:08Z Add GC log retention policy to limit size of log --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3667:
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/1384 KAFKA-3667: By default Kafka is configured to allow ssl communication without hostname verification. This docs has been amended to include instructions on how to set that up in the event clients would like to take a more conservative approach. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rnpridgeon/kafka KAFKA-3667 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1384.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1384 commit 0df7d8c5ca42191118a05ff7cfbbc259df88ed5a Author: Ryan P <ryan.n.pridg...@gmail.com> Date: 2016-05-13T23:25:36Z KAFKA-3667: Improve documentation to include instructions on how to enable hostname verifcation with TLS enabled. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3533: Incorrect logic
Github user rnpridgeon closed the pull request at: https://github.com/apache/kafka/pull/1205 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3533: Incorrect logic
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/1205 KAFKA-3533: Incorrect logic Incorrect logic in Config Validation for KafkaConsumer. https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L556-L557 From what I can tell the error message is correct and the logic is not. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rnpridgeon/kafka KAFKA-3533 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1205.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1205 commit a90723c31a3757bb5bdf32278242cf7c3c677aa7 Author: Ryan P <ryan.n.pridg...@gmail.com> Date: 2016-04-08T18:18:44Z KAFKA-3533: Incorrect logic in Config Validation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3445
GitHub user rnpridgeon opened a pull request: https://github.com/apache/kafka/pull/1132 KAFKA-3445 Currently the property TASKS_MAX_CONFIG is not validated against nonsensical values such as 0. This patch leverages the Range.atLeast() method to ensure value is at least 1. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rnpridgeon/kafka KAFKA-3445 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1132.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1132 commit 8617218300d5af70a4dc62ac4de77f443291b5ed Author: Ryan P <ryan.n.pridg...@gmail.com> Date: 2016-03-24T14:56:11Z KAFKA-3445 add validator to TASKS_MAX_CONFIG --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
