Re: [VOTE] KIP-537: Increase default zookeeper session timeout

2019-10-24 Thread Jason Gustafson
Closing this vote. The total is +9 with +4 binding. Thanks everyone!

-Jason

On Wed, Oct 23, 2019 at 2:31 AM Mickael Maison 
wrote:

> +1 (non binding)
> Thanks for the KIP
>
> On Wed, Oct 23, 2019 at 12:02 AM Harsha Chintalapani 
> wrote:
> >
> > +1 (binding).
> > Thanks,
> > Harsha
> >
> > On Tue, Oct 22, 2019 at 3:20 PM Colin McCabe  wrote:
> >
> > > +1 (binding).
> > >
> > > Thanks, Jason.
> > >
> > > best,
> > > Colin
> > >
> > >
> > > On Mon, Oct 21, 2019, at 17:27, Jason Gustafson wrote:
> > > > I'd like to start a vote for KIP-537:
> > > >
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-537%3A+Increase+default+zookeeper+session+timeout
> > > > .
> > > >
> > > > +1 from me
> > > >
> > > > Thanks,
> > > > Jason
> > > >
> > >
>


Re: [VOTE] KIP-537: Increase default zookeeper session timeout

2019-10-23 Thread Mickael Maison
+1 (non binding)
Thanks for the KIP

On Wed, Oct 23, 2019 at 12:02 AM Harsha Chintalapani  wrote:
>
> +1 (binding).
> Thanks,
> Harsha
>
> On Tue, Oct 22, 2019 at 3:20 PM Colin McCabe  wrote:
>
> > +1 (binding).
> >
> > Thanks, Jason.
> >
> > best,
> > Colin
> >
> >
> > On Mon, Oct 21, 2019, at 17:27, Jason Gustafson wrote:
> > > I'd like to start a vote for KIP-537:
> > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-537%3A+Increase+default+zookeeper+session+timeout
> > > .
> > >
> > > +1 from me
> > >
> > > Thanks,
> > > Jason
> > >
> >


Re: [VOTE] KIP-537: Increase default zookeeper session timeout

2019-10-22 Thread Harsha Chintalapani
+1 (binding).
Thanks,
Harsha

On Tue, Oct 22, 2019 at 3:20 PM Colin McCabe  wrote:

> +1 (binding).
>
> Thanks, Jason.
>
> best,
> Colin
>
>
> On Mon, Oct 21, 2019, at 17:27, Jason Gustafson wrote:
> > I'd like to start a vote for KIP-537:
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-537%3A+Increase+default+zookeeper+session+timeout
> > .
> >
> > +1 from me
> >
> > Thanks,
> > Jason
> >
>


Re: [VOTE] KIP-537: Increase default zookeeper session timeout

2019-10-22 Thread Colin McCabe
+1 (binding).

Thanks, Jason.

best,
Colin


On Mon, Oct 21, 2019, at 17:27, Jason Gustafson wrote:
> I'd like to start a vote for KIP-537:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-537%3A+Increase+default+zookeeper+session+timeout
> .
> 
> +1 from me
> 
> Thanks,
> Jason
>


Re: [VOTE] KIP-537: Increase default zookeeper session timeout

2019-10-22 Thread Satish Duggana
Thanks Jason for the KIP.
+1 (non-binding).

I assume this change will be added to the upgrade notes as the new
values are effective for clusters that were using earlier defaults.
Cluster may get into the race condition of having lower
replica.lag.time.max.ms  on a leader than zookeeper.session.timeout on
a follower replica till all the brokers are upgraded but that would
not break any semantics.

On Tue, Oct 22, 2019 at 2:20 PM M. Manna  wrote:
>
> +1 binding. This kip will possibly fix a lot of extra line of configuration.
>
> Thanks,
>
> On Tue, 22 Oct 2019 at 09:06, Stanislav Kozlovski 
> wrote:
>
> > Solid KIP. This also has the side-effect of bumping
> > zookeeper.connection.timeout.ms to a more reasonable default (the 18s
> > session timeout). Perhaps worth mentioning
> >
> > +1 (non-binding)
> >
> > On Tue, Oct 22, 2019 at 5:47 AM Ismael Juma  wrote:
> >
> > > +1 (binding)
> > >
> > > On Mon, Oct 21, 2019, 5:28 PM Jason Gustafson 
> > wrote:
> > >
> > > > I'd like to start a vote for KIP-537:
> > > >
> > > >
> > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-537%3A+Increase+default+zookeeper+session+timeout
> > > > .
> > > >
> > > > +1 from me
> > > >
> > > > Thanks,
> > > > Jason
> > > >
> > >
> >
> >
> > --
> > Best,
> > Stanislav
> >


Re: [VOTE] KIP-537: Increase default zookeeper session timeout

2019-10-22 Thread M. Manna
+1 binding. This kip will possibly fix a lot of extra line of configuration.

Thanks,

On Tue, 22 Oct 2019 at 09:06, Stanislav Kozlovski 
wrote:

> Solid KIP. This also has the side-effect of bumping
> zookeeper.connection.timeout.ms to a more reasonable default (the 18s
> session timeout). Perhaps worth mentioning
>
> +1 (non-binding)
>
> On Tue, Oct 22, 2019 at 5:47 AM Ismael Juma  wrote:
>
> > +1 (binding)
> >
> > On Mon, Oct 21, 2019, 5:28 PM Jason Gustafson 
> wrote:
> >
> > > I'd like to start a vote for KIP-537:
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-537%3A+Increase+default+zookeeper+session+timeout
> > > .
> > >
> > > +1 from me
> > >
> > > Thanks,
> > > Jason
> > >
> >
>
>
> --
> Best,
> Stanislav
>


Re: [VOTE] KIP-537: Increase default zookeeper session timeout

2019-10-22 Thread Stanislav Kozlovski
Solid KIP. This also has the side-effect of bumping
zookeeper.connection.timeout.ms to a more reasonable default (the 18s
session timeout). Perhaps worth mentioning

+1 (non-binding)

On Tue, Oct 22, 2019 at 5:47 AM Ismael Juma  wrote:

> +1 (binding)
>
> On Mon, Oct 21, 2019, 5:28 PM Jason Gustafson  wrote:
>
> > I'd like to start a vote for KIP-537:
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-537%3A+Increase+default+zookeeper+session+timeout
> > .
> >
> > +1 from me
> >
> > Thanks,
> > Jason
> >
>


-- 
Best,
Stanislav


Re: [VOTE] KIP-537: Increase default zookeeper session timeout

2019-10-21 Thread Ismael Juma
+1 (binding)

On Mon, Oct 21, 2019, 5:28 PM Jason Gustafson  wrote:

> I'd like to start a vote for KIP-537:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-537%3A+Increase+default+zookeeper+session+timeout
> .
>
> +1 from me
>
> Thanks,
> Jason
>


Re: [VOTE] KIP-537: Increase default zookeeper session timeout

2019-10-21 Thread Mitchell
+1(non-binding). This is such an easy default quality of life change

On Mon, Oct 21, 2019, 7:28 PM Jason Gustafson  wrote:

> I'd like to start a vote for KIP-537:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-537%3A+Increase+default+zookeeper+session+timeout
> .
>
> +1 from me
>
> Thanks,
> Jason
>


[VOTE] KIP-537: Increase default zookeeper session timeout

2019-10-21 Thread Jason Gustafson
I'd like to start a vote for KIP-537:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-537%3A+Increase+default+zookeeper+session+timeout
.

+1 from me

Thanks,
Jason