[jira] [Commented] (KAFKA-2167) ZkUtils updateEphemeralPath JavaDoc (spelling and correctness)
[
https://issues.apache.org/jira/browse/KAFKA-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583009#comment-15583009
]
Andrew Musselman commented on KAFKA-2167:
-
Looks like this ticket should be closed.
> ZkUtils updateEphemeralPath JavaDoc (spelling and correctness)
> --
>
> Key: KAFKA-2167
> URL: https://issues.apache.org/jira/browse/KAFKA-2167
> Project: Kafka
> Issue Type: Bug
>Reporter: Jon Bringhurst
> Labels: newbie
>
> I'm not 100% sure on this, but it seems like "persistent" should instead say
> "ephemeral" in the JavaDoc. Also, note that "parrent" is misspelled.
> {noformat}
> /**
>* Update the value of a persistent node with the given path and data.
>* create parrent directory if necessary. Never throw NodeExistException.
>*/
> def updateEphemeralPath(client: ZkClient, path: String, data: String): Unit
> = {
> try {
> client.writeData(path, data)
> }
> catch {
> case e: ZkNoNodeException => {
> createParentPath(client, path)
> client.createEphemeral(path, data)
> }
> case e2 => throw e2
> }
> }
> {noformat}
> should be:
> {noformat}
> /**
>* Update the value of an ephemeral node with the given path and data.
>* create parent directory if necessary. Never throw NodeExistException.
>*/
> def updateEphemeralPath(client: ZkClient, path: String, data: String): Unit
> = {
> try {
> client.writeData(path, data)
> }
> catch {
> case e: ZkNoNodeException => {
> createParentPath(client, path)
> client.createEphemeral(path, data)
> }
> case e2 => throw e2
> }
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-2167) ZkUtils updateEphemeralPath JavaDoc (spelling and correctness)
[
https://issues.apache.org/jira/browse/KAFKA-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542308#comment-14542308
]
Neelesh Srinivas Salian commented on KAFKA-2167:
Updated fix version from 0.8.2 to 0.8.3
> ZkUtils updateEphemeralPath JavaDoc (spelling and correctness)
> --
>
> Key: KAFKA-2167
> URL: https://issues.apache.org/jira/browse/KAFKA-2167
> Project: Kafka
> Issue Type: Bug
>Reporter: Jon Bringhurst
>Assignee: Neelesh Srinivas Salian
> Labels: newbie
> Fix For: 0.8.3
>
>
> I'm not 100% sure on this, but it seems like "persistent" should instead say
> "ephemeral" in the JavaDoc. Also, note that "parrent" is misspelled.
> {noformat}
> /**
>* Update the value of a persistent node with the given path and data.
>* create parrent directory if necessary. Never throw NodeExistException.
>*/
> def updateEphemeralPath(client: ZkClient, path: String, data: String): Unit
> = {
> try {
> client.writeData(path, data)
> }
> catch {
> case e: ZkNoNodeException => {
> createParentPath(client, path)
> client.createEphemeral(path, data)
> }
> case e2 => throw e2
> }
> }
> {noformat}
> should be:
> {noformat}
> /**
>* Update the value of an ephemeral node with the given path and data.
>* create parent directory if necessary. Never throw NodeExistException.
>*/
> def updateEphemeralPath(client: ZkClient, path: String, data: String): Unit
> = {
> try {
> client.writeData(path, data)
> }
> catch {
> case e: ZkNoNodeException => {
> createParentPath(client, path)
> client.createEphemeral(path, data)
> }
> case e2 => throw e2
> }
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-2167) ZkUtils updateEphemeralPath JavaDoc (spelling and correctness)
[
https://issues.apache.org/jira/browse/KAFKA-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540782#comment-14540782
]
ASF GitHub Bot commented on KAFKA-2167:
---
Github user nssalian closed the pull request at:
https://github.com/apache/kafka/pull/63
> ZkUtils updateEphemeralPath JavaDoc (spelling and correctness)
> --
>
> Key: KAFKA-2167
> URL: https://issues.apache.org/jira/browse/KAFKA-2167
> Project: Kafka
> Issue Type: Bug
>Reporter: Jon Bringhurst
>Assignee: Neelesh Srinivas Salian
> Labels: newbie
>
> I'm not 100% sure on this, but it seems like "persistent" should instead say
> "ephemeral" in the JavaDoc. Also, note that "parrent" is misspelled.
> {noformat}
> /**
>* Update the value of a persistent node with the given path and data.
>* create parrent directory if necessary. Never throw NodeExistException.
>*/
> def updateEphemeralPath(client: ZkClient, path: String, data: String): Unit
> = {
> try {
> client.writeData(path, data)
> }
> catch {
> case e: ZkNoNodeException => {
> createParentPath(client, path)
> client.createEphemeral(path, data)
> }
> case e2 => throw e2
> }
> }
> {noformat}
> should be:
> {noformat}
> /**
>* Update the value of an ephemeral node with the given path and data.
>* create parent directory if necessary. Never throw NodeExistException.
>*/
> def updateEphemeralPath(client: ZkClient, path: String, data: String): Unit
> = {
> try {
> client.writeData(path, data)
> }
> catch {
> case e: ZkNoNodeException => {
> createParentPath(client, path)
> client.createEphemeral(path, data)
> }
> case e2 => throw e2
> }
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-2167) ZkUtils updateEphemeralPath JavaDoc (spelling and correctness)
[
https://issues.apache.org/jira/browse/KAFKA-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540779#comment-14540779
]
ASF GitHub Bot commented on KAFKA-2167:
---
GitHub user nssalian opened a pull request:
https://github.com/apache/kafka/pull/64
Kafka 2167
Changed ZkUtils.scala for KAFKA-2167
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nssalian/kafka KAFKA-2167
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/64.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #64
commit 904af08e2437d2ddf57017a3f3f1decc2087c491
Author: Neelesh Srinivas Salian
Date: 2015-05-12T05:17:42Z
KAFKA-2167
commit aa86ba400eab8d1511418ef7fea5f3d06db03b18
Author: Neelesh Srinivas Salian
Date: 2015-05-12T21:09:01Z
Revert "KAFKA-2167"
This reverts commit 904af08e2437d2ddf57017a3f3f1decc2087c491.
commit 61cbb120e12c60fc952b2e2fdb96db5111e1551a
Author: Neelesh Srinivas Salian
Date: 2015-05-12T21:20:06Z
Changed ZkUtils.scala
> ZkUtils updateEphemeralPath JavaDoc (spelling and correctness)
> --
>
> Key: KAFKA-2167
> URL: https://issues.apache.org/jira/browse/KAFKA-2167
> Project: Kafka
> Issue Type: Bug
>Reporter: Jon Bringhurst
>Assignee: Neelesh Srinivas Salian
> Labels: newbie
>
> I'm not 100% sure on this, but it seems like "persistent" should instead say
> "ephemeral" in the JavaDoc. Also, note that "parrent" is misspelled.
> {noformat}
> /**
>* Update the value of a persistent node with the given path and data.
>* create parrent directory if necessary. Never throw NodeExistException.
>*/
> def updateEphemeralPath(client: ZkClient, path: String, data: String): Unit
> = {
> try {
> client.writeData(path, data)
> }
> catch {
> case e: ZkNoNodeException => {
> createParentPath(client, path)
> client.createEphemeral(path, data)
> }
> case e2 => throw e2
> }
> }
> {noformat}
> should be:
> {noformat}
> /**
>* Update the value of an ephemeral node with the given path and data.
>* create parent directory if necessary. Never throw NodeExistException.
>*/
> def updateEphemeralPath(client: ZkClient, path: String, data: String): Unit
> = {
> try {
> client.writeData(path, data)
> }
> catch {
> case e: ZkNoNodeException => {
> createParentPath(client, path)
> client.createEphemeral(path, data)
> }
> case e2 => throw e2
> }
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-2167) ZkUtils updateEphemeralPath JavaDoc (spelling and correctness)
[
https://issues.apache.org/jira/browse/KAFKA-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539267#comment-14539267
]
ASF GitHub Bot commented on KAFKA-2167:
---
GitHub user neeleshCloud opened a pull request:
https://github.com/apache/kafka/pull/63
Corrected the Changes in ZkUtils.scala - KAFKA-2167
Corrected Spelling errors.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neeleshCloud/kafka 0.8.2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/63.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #63
commit 904af08e2437d2ddf57017a3f3f1decc2087c491
Author: Neelesh Srinivas Salian
Date: 2015-05-12T05:17:42Z
KAFKA-2167
> ZkUtils updateEphemeralPath JavaDoc (spelling and correctness)
> --
>
> Key: KAFKA-2167
> URL: https://issues.apache.org/jira/browse/KAFKA-2167
> Project: Kafka
> Issue Type: Bug
>Reporter: Jon Bringhurst
>Assignee: Neelesh Srinivas Salian
> Labels: newbie
>
> I'm not 100% sure on this, but it seems like "persistent" should instead say
> "ephemeral" in the JavaDoc. Also, note that "parrent" is misspelled.
> {noformat}
> /**
>* Update the value of a persistent node with the given path and data.
>* create parrent directory if necessary. Never throw NodeExistException.
>*/
> def updateEphemeralPath(client: ZkClient, path: String, data: String): Unit
> = {
> try {
> client.writeData(path, data)
> }
> catch {
> case e: ZkNoNodeException => {
> createParentPath(client, path)
> client.createEphemeral(path, data)
> }
> case e2 => throw e2
> }
> }
> {noformat}
> should be:
> {noformat}
> /**
>* Update the value of an ephemeral node with the given path and data.
>* create parent directory if necessary. Never throw NodeExistException.
>*/
> def updateEphemeralPath(client: ZkClient, path: String, data: String): Unit
> = {
> try {
> client.writeData(path, data)
> }
> catch {
> case e: ZkNoNodeException => {
> createParentPath(client, path)
> client.createEphemeral(path, data)
> }
> case e2 => throw e2
> }
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
