[jira] [Commented] (KAFKA-2970) Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint class
[ https://issues.apache.org/jira/browse/KAFKA-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15174705#comment-15174705 ] Guozhang Wang commented on KAFKA-2970: -- [~ijuma] Makes sense, we probably should make them in `o.a.k.common.internals`. > Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint > class > --- > > Key: KAFKA-2970 > URL: https://issues.apache.org/jira/browse/KAFKA-2970 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.9.0.0 >Reporter: Grant Henke >Assignee: chen zhu > > Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint > class which contain the same information. These should be consolidated for > simplicity and inter-opt. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2970) Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint class
[ https://issues.apache.org/jira/browse/KAFKA-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157821#comment-15157821 ] Ismael Juma commented on KAFKA-2970: >From a protocol perspective, it's probably OK to go that way. One concern I have is about API compatibility guarantees. Maybe these classes should live under an internal package so that we can actually change them if we have to? `o.a.k.common` classes are public API. > Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint > class > --- > > Key: KAFKA-2970 > URL: https://issues.apache.org/jira/browse/KAFKA-2970 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.9.0.0 >Reporter: Grant Henke >Assignee: chen zhu > > Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint > class which contain the same information. These should be consolidated for > simplicity and inter-opt. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2970) Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint class
[ https://issues.apache.org/jira/browse/KAFKA-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157728#comment-15157728 ] Guozhang Wang commented on KAFKA-2970: -- I merged in the patch of KAFKA-2757 which actually get rid of the classes not being aware it is intentional. Personally I feel we do not need to use two separate classes but can use the o.a.k.common.Endpoint class given that we are confident (at least for now) these fields will not change in the future, or they will always change together if they will ever change. But we should get back to this issue when this assumption is broken. [~ijuma] thoughts? > Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint > class > --- > > Key: KAFKA-2970 > URL: https://issues.apache.org/jira/browse/KAFKA-2970 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.9.0.0 >Reporter: Grant Henke >Assignee: chen zhu > > Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint > class which contain the same information. These should be consolidated for > simplicity and inter-opt. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2970) Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint class
[ https://issues.apache.org/jira/browse/KAFKA-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048498#comment-15048498 ] Ismael Juma commented on KAFKA-2970: This was intentional. Each Request and Response type defines their own types so that they can evolve separately. There are pros and cons for each approach, but just wanted to raise this before we change it. > Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint > class > --- > > Key: KAFKA-2970 > URL: https://issues.apache.org/jira/browse/KAFKA-2970 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.9.0.0 >Reporter: Grant Henke > > Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint > class which contain the same information. These should be consolidated for > simplicity and inter-opt. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
