Re: [VOTE] Release Apache Karaf 2.4.0

2014-09-18 Thread Freeman Fang
+1 (binding)
-
Freeman(Yue) Fang

Red Hat, Inc. 
FuseSource is now part of Red Hat



On 2014-9-17, at 下午11:43, Jamie G. wrote:

 Hi,
 
 We resolved 441 issues in this release:
 http://svn.apache.org/viewvc/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.4.0-release.page?view=markup
 
 A Dependencies table will be created to track changes on the 2.4.x series.
 
 Staging repository:
 https://repository.apache.org/content/repositories/orgapachekaraf-1011/
 
 Git tag:
 karaf-2.4.0
 
 Please vote to approve this release:
 
 [ ] +1 Approve the release
 [ ] -1 Veto the release (please provide specific comments)
 
 This vote will be open for 72 hours.



Re: [VOTE] Release Apache Karaf 2.4.0

2014-09-18 Thread Grzegorz Grzybek
Hello

-1 (non-binding)

I did a full build from `karaf-2.4.0` tag using JDK8. It wouldn't be
however possible with this diff:

```
diff --git a/tooling/features-maven-plugin/pom.xml
b/tooling/features-maven-plugin/pom.xml
index 8d9d46d..42cc35b 100644
--- a/tooling/features-maven-plugin/pom.xml
+++ b/tooling/features-maven-plugin/pom.xml
@@ -59,6 +59,11 @@
 artifactIdmaven-bundle-plugin/artifactId
 /dependency
 dependency
+groupIdorg.apache.felix/groupId
+artifactIdorg.apache.felix.fileinstall/artifactId
+scopeprovided/scope
+/dependency
+dependency
 groupIdorg.apache.karaf.features/groupId
 artifactIdorg.apache.karaf.features.core/artifactId
 exclusions

```

I had to add this provided dependency, because the same dependency from
`org.apache.karaf.deployer.kar` artifact is not transitive and not visible
during compilation of `features-maven-plugin` artifact.

I was using Maven 3.2.3.

After the fix in dependencies entire build and all tests passed OK.

regards
Grzegorz Grzybek

2014-09-17 21:55 GMT+02:00 Achim Nierbeck bcanh...@googlemail.com:

 +1 (binding)

 regards, Achim


 2014-09-17 19:57 GMT+02:00 Krzysztof Sobkowiak krzys.sobkow...@gmail.com
 :

  +1 (non-binding). Good job
 
  Regards
  Krzysztof
 
  On 17.09.2014 17:43, Jamie G. wrote:
   Hi,
  
   We resolved 441 issues in this release:
  
 
 http://svn.apache.org/viewvc/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.4.0-release.page?view=markup
  
   A Dependencies table will be created to track changes on the 2.4.x
  series.
  
   Staging repository:
  
 https://repository.apache.org/content/repositories/orgapachekaraf-1011/
  
   Git tag:
   karaf-2.4.0
  
   Please vote to approve this release:
  
   [ ] +1 Approve the release
   [ ] -1 Veto the release (please provide specific comments)
  
   This vote will be open for 72 hours.
 
 
  --
  Krzysztof Sobkowiak
 
  JEE  OSS Architect | Senior Solution Architect @ Capgemini | Committer
  @ ASF
  Capgemini http://www.pl.capgemini.com/ | Software Solutions Center
  http://www.pl.capgemini-sdm.com/ | Wroclaw
  e-mail: krzys.sobkow...@gmail.com mailto:krzys.sobkow...@gmail.com |
  Twitter: @KSobkowiak
  Calendar: http://goo.gl/yvsebC
 



 --

 Apache Member
 Apache Karaf http://karaf.apache.org/ Committer  PMC
 OPS4J Pax Web http://wiki.ops4j.org/display/paxweb/Pax+Web/ Committer 
 Project Lead
 blog http://notizblog.nierbeck.de/

 Software Architect / Project Manager / Scrum Master



Re: [VOTE] Release Apache Karaf 2.4.0

2014-09-18 Thread Jean-Baptiste Onofré

Good point,

However, the first target is JDK7 and Maven 3.0.x (JDK8 and Maven 3.2 is 
on Karaf 3.0.x).


So I'm OK to fix that for Karaf 2.4.1 but I would release 2.4.0 like this.

WDYT ?

Regards
JB

On 09/18/2014 10:11 AM, Grzegorz Grzybek wrote:

Hello

-1 (non-binding)

I did a full build from `karaf-2.4.0` tag using JDK8. It wouldn't be
however possible with this diff:

```
diff --git a/tooling/features-maven-plugin/pom.xml
b/tooling/features-maven-plugin/pom.xml
index 8d9d46d..42cc35b 100644
--- a/tooling/features-maven-plugin/pom.xml
+++ b/tooling/features-maven-plugin/pom.xml
@@ -59,6 +59,11 @@
  artifactIdmaven-bundle-plugin/artifactId
  /dependency
  dependency
+groupIdorg.apache.felix/groupId
+artifactIdorg.apache.felix.fileinstall/artifactId
+scopeprovided/scope
+/dependency
+dependency
  groupIdorg.apache.karaf.features/groupId
  artifactIdorg.apache.karaf.features.core/artifactId
  exclusions

```

I had to add this provided dependency, because the same dependency from
`org.apache.karaf.deployer.kar` artifact is not transitive and not visible
during compilation of `features-maven-plugin` artifact.

I was using Maven 3.2.3.

After the fix in dependencies entire build and all tests passed OK.

regards
Grzegorz Grzybek

2014-09-17 21:55 GMT+02:00 Achim Nierbeck bcanh...@googlemail.com:


+1 (binding)

regards, Achim


2014-09-17 19:57 GMT+02:00 Krzysztof Sobkowiak krzys.sobkow...@gmail.com

:



+1 (non-binding). Good job

Regards
Krzysztof

On 17.09.2014 17:43, Jamie G. wrote:

Hi,

We resolved 441 issues in this release:




http://svn.apache.org/viewvc/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.4.0-release.page?view=markup


A Dependencies table will be created to track changes on the 2.4.x

series.


Staging repository:


https://repository.apache.org/content/repositories/orgapachekaraf-1011/


Git tag:
karaf-2.4.0

Please vote to approve this release:

[ ] +1 Approve the release
[ ] -1 Veto the release (please provide specific comments)

This vote will be open for 72 hours.



--
Krzysztof Sobkowiak

JEE  OSS Architect | Senior Solution Architect @ Capgemini | Committer
@ ASF
Capgemini http://www.pl.capgemini.com/ | Software Solutions Center
http://www.pl.capgemini-sdm.com/ | Wroclaw
e-mail: krzys.sobkow...@gmail.com mailto:krzys.sobkow...@gmail.com |
Twitter: @KSobkowiak
Calendar: http://goo.gl/yvsebC





--

Apache Member
Apache Karaf http://karaf.apache.org/ Committer  PMC
OPS4J Pax Web http://wiki.ops4j.org/display/paxweb/Pax+Web/ Committer 
Project Lead
blog http://notizblog.nierbeck.de/

Software Architect / Project Manager / Scrum Master





--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com


Re: [VOTE] Release Apache Karaf 2.4.0

2014-09-18 Thread Jean-Baptiste Onofré

By the way,

https://issues.apache.org/jira/browse/KARAF-3239

Regards
JB

On 09/18/2014 10:11 AM, Grzegorz Grzybek wrote:

  dependency
+groupIdorg.apache.felix/groupId
+artifactIdorg.apache.felix.fileinstall/artifactId
+scopeprovided/scope
+/dependency


--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com


Re: [VOTE] Release Apache Karaf 2.4.0

2014-09-18 Thread Guillaume Nodet
+1

2014-09-17 17:43 GMT+02:00 Jamie G. jamie.goody...@gmail.com:

 Hi,

 We resolved 441 issues in this release:

 http://svn.apache.org/viewvc/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.4.0-release.page?view=markup

 A Dependencies table will be created to track changes on the 2.4.x series.

 Staging repository:
 https://repository.apache.org/content/repositories/orgapachekaraf-1011/

 Git tag:
 karaf-2.4.0

 Please vote to approve this release:

 [ ] +1 Approve the release
 [ ] -1 Veto the release (please provide specific comments)

 This vote will be open for 72 hours.



Re: [VOTE] Release Apache Karaf 2.3.8

2014-09-18 Thread Guillaume Nodet
+1

2014-09-16 9:56 GMT+02:00 Jamie G. jamie.goody...@gmail.com:

 Hi,

 We resolved 9 issues in this release:

 http://svn.apache.org/viewvc/karaf/site/trunk/src/main/webapp/index/community/download/karaf-2.3.8-release.page?view=markup

 Dependency changes can be reviewed here:

 http://svn.apache.org/viewvc/karaf/site/trunk/src/main/webapp/index/documentation/karaf-dependencies/karaf-deps-2.3.x.page?revision=1613719view=markup

 Staging repository:
 https://repository.apache.org/content/repositories/orgapachekaraf-1010/

 Git tag:
 karaf-2.3.8

 Please vote to approve this release:

 [ ] +1 Approve the release
 [ ] -1 Veto the release (please provide specific comments)

 This vote will be open for 72 hours.