Re: Review Request 39127: LENS-807: Priority is not getting set in QueryContext. It's always NORMAL

2015-10-13 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39127/#review102412
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Oct. 12, 2015, 8:22 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39127/
> ---
> 
> (Updated Oct. 12, 2015, 8:22 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-807
> https://issues.apache.org/jira/browse/LENS-807
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> small bug
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 4561ccf3424958b251b8eb31c649341bae8104c9 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  2cb3736d45d51fd2172e99ca086843fc6ce50079 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  ac942077d78515404b83f4a02f841b73dd39e3df 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java
>  3d38eab9a37410468694a8954e45f497f23d1072 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
>  847d12a7e25e2db68d5f7fba910aa1027882ec27 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/MockQueryCostCalculator.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/priority/MockQueryPriorityDecider.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java
>  caee12f4a39388c39eac656949e9c16bf4dfdea7 
>   
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 
> e266ef223e463791e26b6a7a59818e7495bc0235 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
>  3bb90efc9c2a859d1c339e6b21a4048a2bef 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> 6218882facf93216211c50d264e2e6e9cf64a122 
> 
> Diff: https://reviews.apache.org/r/39127/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.175s]
> [INFO] Lens .. SUCCESS [2.947s]
> [INFO] Lens API .. SUCCESS [23.439s]
> [INFO] Lens API for server and extensions  SUCCESS [20.441s]
> [INFO] Lens Cube . SUCCESS [6:11.745s]
> [INFO] Lens DB storage ... SUCCESS [22.402s]
> [INFO] Lens Query Library  SUCCESS [18.196s]
> [INFO] Lens Hive Driver .. SUCCESS [3:06.859s]
> [INFO] Lens Driver for JDBC .. SUCCESS [35.658s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.347s]
> [INFO] Lens Server ... SUCCESS [8:17.698s]
> [INFO] Lens client ... SUCCESS [34.376s]
> [INFO] Lens CLI .. SUCCESS [2:36.033s]
> [INFO] Lens Examples . SUCCESS [9.886s]
> [INFO] Lens Distribution . SUCCESS [8.592s]
> [INFO] Lens ML Lib ... SUCCESS [1:19.730s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.106s]
> [INFO] Lens Regression ... SUCCESS [11.178s]
> [INFO] Lens UI ... SUCCESS [22.051s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 25:23.999s
> [INFO] Finished at: Thu Oct 08 12:59:09 UTC 2015
> [INFO] Final Memory: 194M/2044M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: [DISCUSS] Sushil Mohanty as Lens committer

2015-10-13 Thread Jean-Baptiste Onofré 

+1

Regards
JB

On 10/13/2015 09:18 AM, Rajat Khandelwal wrote:

Hi all

I'd like to propose Sushil be made committer for Apache Lens.
His contributions on GitHub

He's worked on 32 issues

so
far and has 12 more issues

assigned
to him.

He has been instrumental in driving the JDBC driver. His other significant
work has been on moving the Hive error codes to Lens.

I feel he's earned this and it's time he should be made a committer.


Thoughts?



--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Re: Review Request 39127: LENS-807: Priority is not getting set in QueryContext. It's always NORMAL

2015-10-13 Thread Rajat Khandelwal 


> On Oct. 13, 2015, 1:37 p.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java,
> >  line 207
> > 
> >
> > Can we avoid opening up the constructor?

Have made MockQueryContext extend QueryContext instead of AbstractQueryContext. 
One constructor had to be opened up. Can make it protected if you'd like. 
package local is still not `public` though.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39127/#review102408
---


On Oct. 12, 2015, 1:52 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39127/
> ---
> 
> (Updated Oct. 12, 2015, 1:52 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-807
> https://issues.apache.org/jira/browse/LENS-807
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> small bug
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 4561ccf3424958b251b8eb31c649341bae8104c9 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  2cb3736d45d51fd2172e99ca086843fc6ce50079 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  ac942077d78515404b83f4a02f841b73dd39e3df 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java
>  3d38eab9a37410468694a8954e45f497f23d1072 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
>  847d12a7e25e2db68d5f7fba910aa1027882ec27 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/MockQueryCostCalculator.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/priority/MockQueryPriorityDecider.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java
>  caee12f4a39388c39eac656949e9c16bf4dfdea7 
>   
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 
> e266ef223e463791e26b6a7a59818e7495bc0235 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
>  3bb90efc9c2a859d1c339e6b21a4048a2bef 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> 6218882facf93216211c50d264e2e6e9cf64a122 
> 
> Diff: https://reviews.apache.org/r/39127/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.175s]
> [INFO] Lens .. SUCCESS [2.947s]
> [INFO] Lens API .. SUCCESS [23.439s]
> [INFO] Lens API for server and extensions  SUCCESS [20.441s]
> [INFO] Lens Cube . SUCCESS [6:11.745s]
> [INFO] Lens DB storage ... SUCCESS [22.402s]
> [INFO] Lens Query Library  SUCCESS [18.196s]
> [INFO] Lens Hive Driver .. SUCCESS [3:06.859s]
> [INFO] Lens Driver for JDBC .. SUCCESS [35.658s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.347s]
> [INFO] Lens Server ... SUCCESS [8:17.698s]
> [INFO] Lens client ... SUCCESS [34.376s]
> [INFO] Lens CLI .. SUCCESS [2:36.033s]
> [INFO] Lens Examples . SUCCESS [9.886s]
> [INFO] Lens Distribution . SUCCESS [8.592s]
> [INFO] Lens ML Lib ... SUCCESS [1:19.730s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.106s]
> [INFO] Lens Regression ... SUCCESS [11.178s]
> [INFO] Lens UI ... SUCCESS [22.051s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 25:23.999s
> [INFO] Finished at: Thu Oct 08 12:59:09 UTC 2015
> [INFO] Final Memory: 194M/2044M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Commented] (LENS-807) Priority is not getting set in QueryContext. It's always NORMAL

2015-10-13 Thread Rajat Khandelwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14954603#comment-14954603
 ] 

Rajat Khandelwal commented on LENS-807:
---

Taking patch from reviewboard and attaching

> Priority is not getting set in QueryContext. It's always NORMAL
> ---
>
> Key: LENS-807
> URL: https://issues.apache.org/jira/browse/LENS-807
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-807.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39127: LENS-807: Priority is not getting set in QueryContext. It's always NORMAL

2015-10-13 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39127/#review102408
---



lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 (line 207)


Can we avoid opening up the constructor?


- Amareshwari Sriramadasu


On Oct. 12, 2015, 8:22 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39127/
> ---
> 
> (Updated Oct. 12, 2015, 8:22 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-807
> https://issues.apache.org/jira/browse/LENS-807
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> small bug
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 4561ccf3424958b251b8eb31c649341bae8104c9 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  2cb3736d45d51fd2172e99ca086843fc6ce50079 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  ac942077d78515404b83f4a02f841b73dd39e3df 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java
>  3d38eab9a37410468694a8954e45f497f23d1072 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
>  847d12a7e25e2db68d5f7fba910aa1027882ec27 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/MockQueryCostCalculator.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/priority/MockQueryPriorityDecider.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java
>  caee12f4a39388c39eac656949e9c16bf4dfdea7 
>   
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 
> e266ef223e463791e26b6a7a59818e7495bc0235 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
>  3bb90efc9c2a859d1c339e6b21a4048a2bef 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> 6218882facf93216211c50d264e2e6e9cf64a122 
> 
> Diff: https://reviews.apache.org/r/39127/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.175s]
> [INFO] Lens .. SUCCESS [2.947s]
> [INFO] Lens API .. SUCCESS [23.439s]
> [INFO] Lens API for server and extensions  SUCCESS [20.441s]
> [INFO] Lens Cube . SUCCESS [6:11.745s]
> [INFO] Lens DB storage ... SUCCESS [22.402s]
> [INFO] Lens Query Library  SUCCESS [18.196s]
> [INFO] Lens Hive Driver .. SUCCESS [3:06.859s]
> [INFO] Lens Driver for JDBC .. SUCCESS [35.658s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.347s]
> [INFO] Lens Server ... SUCCESS [8:17.698s]
> [INFO] Lens client ... SUCCESS [34.376s]
> [INFO] Lens CLI .. SUCCESS [2:36.033s]
> [INFO] Lens Examples . SUCCESS [9.886s]
> [INFO] Lens Distribution . SUCCESS [8.592s]
> [INFO] Lens ML Lib ... SUCCESS [1:19.730s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.106s]
> [INFO] Lens Regression ... SUCCESS [11.178s]
> [INFO] Lens UI ... SUCCESS [22.051s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 25:23.999s
> [INFO] Finished at: Thu Oct 08 12:59:09 UTC 2015
> [INFO] Final Memory: 194M/2044M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Commented] (LENS-816) ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries and getQueryCount

2015-10-13 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14954618#comment-14954618
 ] 

Hadoop QA commented on LENS-816:


Applied patch: 
[LENS-816.02.patch|https://issues.apache.org/jira/secure/attachment/12766288/LENS-816.02.patch]
 and ran command: mvn clean install. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/113/

> ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries 
> and getQueryCount
> --
>
> Key: LENS-816
> URL: https://issues.apache.org/jira/browse/LENS-816
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-816.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

2015-10-13 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102403
---



lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (line 69)


I think it should be @BeforeTest instead of @BeforeClass


- Amareshwari Sriramadasu


On Oct. 12, 2015, 11:27 p.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 12, 2015, 11:27 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 38521: LENS-607: Fix Test failures in java8

2015-10-13 Thread Raju Bairishetti 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38521/
---

(Updated Oct. 13, 2015, 10:54 a.m.)


Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.


Changes
---

Add lens-cube test dependency


Bugs: LENS-607
https://issues.apache.org/jira/browse/LENS-607


Repository: lens


Description
---

Iterators in java7 and java8 are returning elements in different order. All 
most all failures are because of this case.

Changes:
TestBaseCubeQueries: Changed driver supported storages to single storage 
instead of multiple
TestCubeRewriter: Returning diffrent orders in the joins. Separated join part 
from the actaul query part and verified join part and remaining query part 
separately.
TestStorageUtil: Multiple sets can answer the given partitions. Changed asserts 
accordingly.
TestTimeRangeResolver: Changed asserts to cover all the errors.

*ColumnSQLRewriter* : Changed all data structures to *Linked* datastructures 
(Arraylist --> LinkedList, HashSet to LinkedHashSet, HashMap to LinkedHashMap) 
to return the elements in insertion order.

TestColumnSQLRewriter: Changed the order of columns in queries.


Diffs (updated)
-

  lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java b553739 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
0f76c76 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
a58f5fe 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
 bde4edd 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 
493b8d6 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java 
PRE-CREATION 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java 
81f515b 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
cb27d50 
  lens-driver-jdbc/pom.xml 7c1a5c7 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 295b476 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
 db09a4b 

Diff: https://reviews.apache.org/r/38521/diff/


Testing
---

Tested on both java7 and java8. Build is successful. Will post the build 
artifact summary soon.

c1mng0pxdty3:lens raju.bairishetti$ java -version
**java version "1.8.0_40"**

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules .. SUCCESS [  4.849 s]
[INFO] Lens ... SUCCESS [  5.806 s]
[INFO] Lens API ... SUCCESS [ 31.562 s]
[INFO] Lens API for server and extensions . SUCCESS [ 23.200 s]
[INFO] Lens Cube .. SUCCESS [06:19 min]
[INFO] Lens DB storage  SUCCESS [ 23.015 s]
[INFO] Lens Query Library . SUCCESS [ 18.249 s]
[INFO] Lens Hive Driver ... SUCCESS [03:11 min]
[INFO] Lens Driver for JDBC ... SUCCESS [ 41.094 s]
[INFO] Lens Elastic Search Driver . SUCCESS [ 26.188 s]
[INFO] Lens Server  SUCCESS [12:38 min]
[INFO] Lens client  SUCCESS [ 44.951 s]
[INFO] Lens CLI ... SUCCESS [04:57 min]
[INFO] Lens Examples .. SUCCESS [ 11.491 s]
[INFO] Lens Distribution .. SUCCESS [ 19.483 s]
[INFO] Lens ML Lib  SUCCESS [02:35 min]
[INFO] Lens ML Ext Distribution ... SUCCESS [  7.919 s]
[INFO] Lens Regression  SUCCESS [ 11.523 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 34:13 min
[INFO] Finished at: 2015-09-19T12:13:27+05:30
[INFO] Final Memory: 158M/1483M
[INFO] 


JDK-7:  **sun-jdk-1.7.0_55**

regression-2.4.0-beta-SNAPSHOT-tests.jar
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.999s]
[INFO] Lens .. SUCCESS [2.816s]
[INFO] Lens API .. SUCCESS [23.685s]
[INFO] Lens API for server and extensions  SUCCESS [20.093s]
[INFO] Lens Cube . SUCCESS [5:02.073s]

[jira] [Commented] (LENS-607) Test Failures on java8

2015-10-13 Thread Raju Bairishetti (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14954990#comment-14954990
 ] 

Raju Bairishetti commented on LENS-607:
---

Thanks [~prongs] for detailed review :) .

> Test Failures on java8
> --
>
> Key: LENS-607
> URL: https://issues.apache.org/jira/browse/LENS-607
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: test
>Reporter: Raju Bairishetti
>Assignee: Raju Bairishetti
> Fix For: 2.4
>
> Attachments: LENS-607.patch
>
>
> There are some test failures on lens-cube test module. Did not verify other 
> modules yet.
> Ex: TestBaseCubeQueries, TestExpressionResolver and few more tests are 
> failing on java8
> Tests are failing while comparing the expected query with rewritten query.  
> Rewritten query and expected query are same but the **joining of tables are 
> not in the same order**.
> In some tests, queries are hitting the fact tables form different cube than 
> expected in the test(i.e. fact tables from multiple cubes can answer the 
> query). I think we should either fix the tests in comparing with all the 
> possibilities or fix the order of querying the cube tables.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39161: LENS-292 : Query result retention policy

2015-10-13 Thread Deepak Barr 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39161/
---

(Updated Oct. 13, 2015, 11:48 a.m.)


Review request for lens.


Changes
---

Updated the diff with the suggestions.

1. Took the ResultPurger class outside of QueryExecutionServiceImpl
2. By default, purge is disabled.
3. Fixed comments.


Bugs: LENS-292
https://issues.apache.org/jira/browse/LENS-292


Repository: lens


Description
---

Added query result purge policy on both Driver persisted and Lens persisted 
resultset. Default retention of 1 day. Purging can be turned off with a setting.


Diffs (updated)
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
f202603 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 73179e1 
  lens-server/src/main/java/org/apache/lens/server/query/QueryResultPurger.java 
PRE-CREATION 
  lens-server/src/main/resources/lensserver-default.xml 1e6bd10 

Diff: https://reviews.apache.org/r/39161/diff/


Testing
---

Yes.

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .. SUCCESS [  2.785 s]
[INFO] Lens ... SUCCESS [  5.339 s]
[INFO] Lens API ... SUCCESS [ 28.950 s]
[INFO] Lens API for server and extensions . SUCCESS [ 28.187 s]
[INFO] Lens Cube .. SUCCESS [07:05 min]
[INFO] Lens DB storage  SUCCESS [ 28.169 s]
[INFO] Lens Query Library . SUCCESS [ 22.031 s]
[INFO] Lens Hive Driver ... SUCCESS [04:13 min]
[INFO] Lens Driver for JDBC ... SUCCESS [ 49.452 s]
[INFO] Lens Elastic Search Driver . SUCCESS [ 22.865 s]
[INFO] Lens Server  SUCCESS [10:58 min]
[INFO] Lens client  SUCCESS [ 47.198 s]
[INFO] Lens CLI ... SUCCESS [03:44 min]
[INFO] Lens Examples .. SUCCESS [ 11.516 s]
[INFO] Lens Distribution .. SUCCESS [ 12.779 s]
[INFO] Lens ML Lib  SUCCESS [02:00 min]
[INFO] Lens ML Ext Distribution ... SUCCESS [  3.212 s]
[INFO] Lens Regression  SUCCESS [ 15.624 s]
[INFO] Lens UI  SUCCESS [  3.415 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 32:45 min
[INFO] Finished at: 2015-10-07T23:19:44+05:30
[INFO] Final Memory: 218M/2795M
[INFO] 


Thanks,

Deepak Barr

Re: Review Request 38521: LENS-607: Fix Test failures in java8

2015-10-13 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38521/#review102442
---

Ship it!


Ship It!

- Rajat Khandelwal


On Oct. 13, 2015, 6:16 p.m., Raju Bairishetti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38521/
> ---
> 
> (Updated Oct. 13, 2015, 6:16 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Bugs: LENS-607
> https://issues.apache.org/jira/browse/LENS-607
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Iterators in java7 and java8 are returning elements in different order. All 
> most all failures are because of this case.
> 
> Changes:
> TestBaseCubeQueries: Changed driver supported storages to single storage 
> instead of multiple
> TestCubeRewriter: Returning diffrent orders in the joins. Separated join part 
> from the actaul query part and verified join part and remaining query part 
> separately.
> TestStorageUtil: Multiple sets can answer the given partitions. Changed 
> asserts accordingly.
> TestTimeRangeResolver: Changed asserts to cover all the errors.
> 
> *ColumnSQLRewriter* : Changed all data structures to *Linked* datastructures 
> (Arraylist --> LinkedList, HashSet to LinkedHashSet, HashMap to 
> LinkedHashMap) to return the elements in insertion order.
> 
> TestColumnSQLRewriter: Changed the order of columns in queries.
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 
> b553739 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> 0f76c76 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> a58f5fe 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
>  bde4edd 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
>  493b8d6 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java 
> PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java 
> 81f515b 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
> cb27d50 
>   lens-driver-jdbc/pom.xml 7c1a5c7 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  295b476 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
>  db09a4b 
> 
> Diff: https://reviews.apache.org/r/38521/diff/
> 
> 
> Testing
> ---
> 
> Tested on both java7 and java8. Build is successful. Will post the build 
> artifact summary soon.
> 
> c1mng0pxdty3:lens raju.bairishetti$ java -version
> **java version "1.8.0_40"**
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules .. SUCCESS [  4.849 
> s]
> [INFO] Lens ... SUCCESS [  5.806 
> s]
> [INFO] Lens API ... SUCCESS [ 31.562 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 23.200 
> s]
> [INFO] Lens Cube .. SUCCESS [06:19 
> min]
> [INFO] Lens DB storage  SUCCESS [ 23.015 
> s]
> [INFO] Lens Query Library . SUCCESS [ 18.249 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [03:11 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 41.094 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 26.188 
> s]
> [INFO] Lens Server  SUCCESS [12:38 
> min]
> [INFO] Lens client  SUCCESS [ 44.951 
> s]
> [INFO] Lens CLI ... SUCCESS [04:57 
> min]
> [INFO] Lens Examples .. SUCCESS [ 11.491 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 19.483 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:35 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  7.919 
> s]
> [INFO] Lens Regression  SUCCESS [ 11.523 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 34:13 min
> [INFO] Finished at: 2015-09-19T12:13:27+05:30
> [INFO] Final Memory: 158M/1483M
> [INFO] 
> 
> 
> 
> JDK-7:

[jira] [Commented] (LENS-607) Test Failures on java8

2015-10-13 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14955278#comment-14955278
 ] 

Hadoop QA commented on LENS-607:


Applied patch: 
[LENS-607.patch|https://issues.apache.org/jira/secure/attachment/12766334/LENS-607.patch]
 and ran command: mvn clean install. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/117/

> Test Failures on java8
> --
>
> Key: LENS-607
> URL: https://issues.apache.org/jira/browse/LENS-607
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: test
>Reporter: Raju Bairishetti
>Assignee: Raju Bairishetti
> Fix For: 2.4
>
> Attachments: LENS-607.patch
>
>
> There are some test failures on lens-cube test module. Did not verify other 
> modules yet.
> Ex: TestBaseCubeQueries, TestExpressionResolver and few more tests are 
> failing on java8
> Tests are failing while comparing the expected query with rewritten query.  
> Rewritten query and expected query are same but the **joining of tables are 
> not in the same order**.
> In some tests, queries are hitting the fact tables form different cube than 
> expected in the test(i.e. fact tables from multiple cubes can answer the 
> query). I think we should either fix the tests in comparing with all the 
> possibilities or fix the order of querying the cube tables.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-607) Test Failures on java8

2015-10-13 Thread Raju Bairishetti (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raju Bairishetti updated LENS-607:
--
Status: Patch Available  (was: In Progress)

> Test Failures on java8
> --
>
> Key: LENS-607
> URL: https://issues.apache.org/jira/browse/LENS-607
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: test
>Reporter: Raju Bairishetti
>Assignee: Raju Bairishetti
> Fix For: 2.4
>
> Attachments: LENS-607.patch
>
>
> There are some test failures on lens-cube test module. Did not verify other 
> modules yet.
> Ex: TestBaseCubeQueries, TestExpressionResolver and few more tests are 
> failing on java8
> Tests are failing while comparing the expected query with rewritten query.  
> Rewritten query and expected query are same but the **joining of tables are 
> not in the same order**.
> In some tests, queries are hitting the fact tables form different cube than 
> expected in the test(i.e. fact tables from multiple cubes can answer the 
> query). I think we should either fix the tests in comparing with all the 
> possibilities or fix the order of querying the cube tables.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 39286: LENS-817 : No need to persist metadata class information in DB after LENS-576 fix

2015-10-13 Thread Deepak Barr 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39286/
---

Review request for lens.


Repository: lens


Description
---

Removed the persistence of metadata class along with other references.


Diffs
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java
 8308198 
  lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 
8a2ac19 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 d57812f 
  lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 
708afe5 

Diff: https://reviews.apache.org/r/39286/diff/


Testing
---

Yes. Tested the query status and resultset related APIs after the query is 
purged to DB.

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .. SUCCESS [  2.592 s]
[INFO] Lens ... SUCCESS [  3.872 s]
[INFO] Lens API ... SUCCESS [ 28.298 s]
[INFO] Lens API for server and extensions . SUCCESS [ 27.500 s]
[INFO] Lens Cube .. SUCCESS [07:04 min]
[INFO] Lens DB storage  SUCCESS [ 26.356 s]
[INFO] Lens Query Library . SUCCESS [ 22.843 s]
[INFO] Lens Hive Driver ... SUCCESS [04:13 min]
[INFO] Lens Driver for JDBC ... SUCCESS [ 50.457 s]
[INFO] Lens Elastic Search Driver . SUCCESS [ 21.378 s]
[INFO] Lens Server  SUCCESS [10:52 min]
[INFO] Lens client  SUCCESS [ 47.565 s]
[INFO] Lens CLI ... SUCCESS [03:46 min]
[INFO] Lens Examples .. SUCCESS [ 12.484 s]
[INFO] Lens Distribution .. SUCCESS [ 12.654 s]
[INFO] Lens ML Lib  SUCCESS [02:01 min]
[INFO] Lens ML Ext Distribution ... SUCCESS [  3.704 s]
[INFO] Lens Regression  SUCCESS [ 18.117 s]
[INFO] Lens UI  SUCCESS [ 46.465 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 33:24 min
[INFO] Finished at: 2015-10-13T19:33:57+05:30
[INFO] Final Memory: 206M/2383M
[INFO] 


Thanks,

Deepak Barr

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

2015-10-13 Thread Gabor Liptak 


> On Oct. 13, 2015, 8:08 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, 
> > lines 281-291
> > 
> >
> > Data providers. You can look at 
> > org.apache.lens.cube.metadata.TestTimePartition  and 
> > org.apache.lens.cube.metadata.UpdatePeriodTest for examples.

Thank you for the pointers


- Gabor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102406
---


On Oct. 12, 2015, 11:27 p.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 12, 2015, 11:27 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>