Re: Next Lens Meetup

[Ankeet Maini]

+1 for Friday!

On Mon, Oct 26, 2015 at 6:22 PM, Amruth Sampath 
wrote:

> +1 for friday!
>
> On Mon, Oct 26, 2015 at 6:21 PM, Vikas Singh (Tech - VS) <
> vikas.si...@flipkart.com> wrote:
>
>> Hi, I will be available on Friday.
>>
>> On Mon, Oct 26, 2015 at 3:58 PM, Deepak Kumar Barr (Tech_BLR) <
>> deepak.b...@flipkart.com> wrote:
>>
>>> Yes for friday.
>>>
>>> Regards,
>>> Deepak Kumar Barr
>>> Bigfoot-Apps
>>>
>>> On Mon, Oct 26, 2015 at 3:35 PM, amareshwarisr . 
>>> wrote:
>>>
 Friday works for me.

 On Mon, Oct 26, 2015 at 3:32 PM, Sharad Agarwal 
 wrote:

> We can have on 30th Friday evening starting say 3 PM or so.
> Or can have on 31st Sat starting 10 AM
>
> Preferences ?
>
> On Fri, Oct 23, 2015 at 11:17 AM, Raju Bairishetti  >
> wrote:
>
> > Thanks Sharad & flipkart for hosting meetup :).
> >
> > On Fri, Oct 23, 2015 at 9:55 AM, Sharad Agarwal 
> wrote:
> >
> >> We can shoot for 30th Oct. I will check with folks @flipkart and
> confirm
> >> by monday.
> >>
> >> On Fri, Oct 23, 2015 at 8:05 AM, Raju Bairishetti 
> >> wrote:
> >>
> >>> Any thoughts on having the meetup in the next two weeks. I would
> prefer
> >>> meetup on weekends (30th october or 6th Nov).
> >>>
> >>> On Fri, Oct 9, 2015 at 3:24 PM, Yash Sharma 
> wrote:
> >>>
> >>> > Also let me know the dates as early so that I can book tickets
> and get
> >>> > stickers printed :)
> >>> >
> >>> > Do share stickers ideas as well.
> >>> >
> >>> > - Via mobile. Excuse brevity.
> >>> > On 9 Oct 2015 3:17 pm, "Yash Sharma"  wrote:
> >>> >
> >>> >> Not google hangout maybe since there is a limit of 10 people.
> We can
> >>> >> probably think something like youtube live stream.
> >>> >> Has anyone got past experience in webinar?
> >>> >>
> >>> >> - Via mobile. Excuse brevity.
> >>> >> On 9 Oct 2015 3:11 pm, "Raju Bairishetti" 
> wrote:
> >>> >>
> >>> >>> @Ankeet, Sounds great.
> >>> >>>
> >>> >>> @Sharad, Agree. We can have meetup week after Dusshera
> holidays. It
> >>> would
> >>> >>> be nice to have google hangout session also for every meetup
> :) .
> >>> >>>
> >>> >>> On Fri, Oct 9, 2015 at 2:49 PM, Ankeet Maini <
> ankeet.ma...@gmail.com
> >>> >
> >>> >>> wrote:
> >>> >>>
> >>> >>> > +1 for the meet up! We should've a demo of the new UI ;)
> >>> >>> > --
> >>> >>> > From: Deepak Kumar Barr (Tech_BLR)  >
> >>> >>> > Sent: ‎09-‎10-‎2015 12:51 PM
> >>> >>> > To: u...@lens.apache.org
> >>> >>> > Cc: dev 
> >>> >>> > Subject: Re: Next Lens Meetup
> >>> >>> >
> >>> >>> > +1 for meetup. But we can different dates. 22nd is dussehra,
> people
> >>> >>> might
> >>> >>> > be on vacations.
> >>> >>> >
> >>> >>> > Regards,
> >>> >>> > Deepak Kumar Barr
> >>> >>> > Bigfoot-Apps
> >>> >>> >
> >>> >>> > On Fri, Oct 9, 2015 at 12:37 PM, Raju Bairishetti <
> r...@apache.org
> >>> >
> >>> >>> wrote:
> >>> >>> >
> >>> >>> > > Hello all,
> >>> >>> > >
> >>> >>> > > Its been quite a long time we had a meetup. Shall we have
> one
> >>> between
> >>> >>> > > october 17th and 23rd?
> >>> >>> > >
> >>> >>> > > If you are looking forward to hear anything in the meetup,
> please
> >>> >>> reply
> >>> >>> > > here.
> >>> >>> > >
> >>> >>> > > Thanks,
> >>> >>> > > Raju Bairishetti
> >>> >>> > >
> >>> >>> >
> >>> >>>
> >>> >>>
> >>> >>>
> >>> >>> --
> >>> >>> Thanks
> >>> >>> Raju Bairishetti,
> >>> >>>
> >>> >>> www.inmobi.com
> >>> >>>
> >>> >>>
> >>> >>>
> >>> >>>
> >>> >>> *2012 ME Best Mobile Ad Network Award Winner
> >>> >>>
> >>> >>> [image:
> http://www.inmobi.com/press-releases/files/2013/02/MIT.png]
> >>> >>>
> >>> >>
> >>>
> >>
> >>
> >
> >
> > --
> > Thanks
> > Raju Bairishetti,
> >
> > www.inmobi.com
> >
> >
> >
> >
> > *2012 ME Best Mobile Ad Network Award Winner
> >
> > [image: http://www.inmobi.com/press-releases/files/2013/02/MIT.png]
> >
> >
> >
>


>>>
>>
>
>
> --
> Amruth S
> (09486075517)
>



-- 
*Ankeet Maini*
*"Just when the caterpillar thought the world was over, it became a
butterfly!"*

[jira] [Created] (LENS-848) Allow JDBC driver to take connection properties in configuration

[Rajat Khandelwal (JIRA)]

Rajat Khandelwal created LENS-848:
-

 Summary: Allow JDBC driver to take connection properties in 
configuration
 Key: LENS-848
 URL: https://issues.apache.org/jira/browse/LENS-848
 Project: Apache Lens
  Issue Type: Improvement
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39680/
---

(Updated Oct. 27, 2015, 1:38 p.m.)


Review request for lens.


Bugs: LENS-848
https://issues.apache.org/jira/browse/LENS-848


Repository: lens


Description (updated)
---

Will plan to separate properties later. Keeping them for backward compatibility.


Diffs
-

  lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java PRE-CREATION 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 ccb2b7fdf1fe297b7240ce1efcb1646303e1236d 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
 b14835a3c40eabd9b0939e9be19e41852e5f99c4 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
 70815bbb8d89685fd2f3faf14230b8b458270ff1 
  lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
163ed42daf49a182ead3eca048b3ada6e53e2c0b 

Diff: https://reviews.apache.org/r/39680/diff/


Testing (updated)
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [2.414s]
[INFO] Lens .. SUCCESS [3.298s]
[INFO] Lens API .. SUCCESS [27.005s]
[INFO] Lens API for server and extensions  SUCCESS [25.469s]
[INFO] Lens Cube . SUCCESS [5:46.494s]
[INFO] Lens DB storage ... SUCCESS [22.510s]
[INFO] Lens Query Library  SUCCESS [19.621s]
[INFO] Lens Hive Driver .. SUCCESS [2:57.116s]
[INFO] Lens Driver for JDBC .. SUCCESS [40.236s]
[INFO] Lens Elastic Search Driver  SUCCESS [19.414s]
[INFO] Lens Server ... SUCCESS [8:21.803s]
[INFO] Lens client ... SUCCESS [36.730s]
[INFO] Lens CLI .. SUCCESS [54.984s]
[INFO] Lens Examples . SUCCESS [10.850s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.867s]
[INFO] Lens Distribution . SUCCESS [9.404s]
[INFO] Lens ML Lib ... SUCCESS [1:24.110s]
[INFO] Lens ML Ext Distribution .. SUCCESS [1.979s]
[INFO] Lens Regression ... SUCCESS [13.230s]
[INFO] Lens UI ... SUCCESS [27.486s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 23:47.270s
[INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
[INFO] Final Memory: 179M/1101M
[INFO] 


Thanks,

Rajat Khandelwal

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39680/#review104152
---



lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 (line 180)


We can remove new HashMap<>()



lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml (line 33)


Move to tests?


Can you include unit test?

- Amareshwari Sriramadasu


On Oct. 27, 2015, 8:08 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39680/
> ---
> 
> (Updated Oct. 27, 2015, 8:08 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-848
> https://issues.apache.org/jira/browse/LENS-848
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Will plan to separate properties later. Keeping them for backward 
> compatibility.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
> PRE-CREATION 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  ccb2b7fdf1fe297b7240ce1efcb1646303e1236d 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
>  b14835a3c40eabd9b0939e9be19e41852e5f99c4 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
>  70815bbb8d89685fd2f3faf14230b8b458270ff1 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
> 163ed42daf49a182ead3eca048b3ada6e53e2c0b 
> 
> Diff: https://reviews.apache.org/r/39680/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.414s]
> [INFO] Lens .. SUCCESS [3.298s]
> [INFO] Lens API .. SUCCESS [27.005s]
> [INFO] Lens API for server and extensions  SUCCESS [25.469s]
> [INFO] Lens Cube . SUCCESS [5:46.494s]
> [INFO] Lens DB storage ... SUCCESS [22.510s]
> [INFO] Lens Query Library  SUCCESS [19.621s]
> [INFO] Lens Hive Driver .. SUCCESS [2:57.116s]
> [INFO] Lens Driver for JDBC .. SUCCESS [40.236s]
> [INFO] Lens Elastic Search Driver  SUCCESS [19.414s]
> [INFO] Lens Server ... SUCCESS [8:21.803s]
> [INFO] Lens client ... SUCCESS [36.730s]
> [INFO] Lens CLI .. SUCCESS [54.984s]
> [INFO] Lens Examples . SUCCESS [10.850s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.867s]
> [INFO] Lens Distribution . SUCCESS [9.404s]
> [INFO] Lens ML Lib ... SUCCESS [1:24.110s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.979s]
> [INFO] Lens Regression ... SUCCESS [13.230s]
> [INFO] Lens UI ... SUCCESS [27.486s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 23:47.270s
> [INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
> [INFO] Final Memory: 179M/1101M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Next Lens Meetup

[Balasugavaneswaran Nathan]

Works for me

On Tue, Oct 27, 2015 at 12:49 PM, Pranav Kumar Agarwal 
wrote:

> +1 for friday
>
> On 26/10/15 6:22 pm, Amruth Sampath wrote:
>
>> +1 for friday!
>>
>> On Mon, Oct 26, 2015 at 6:21 PM, Vikas Singh (Tech - VS) <
>> vikas.si...@flipkart.com > wrote:
>>
>> Hi, I will be available on Friday.
>>
>> On Mon, Oct 26, 2015 at 3:58 PM, Deepak Kumar Barr (Tech_BLR)
>> > wrote:
>>
>> Yes for friday.
>>
>> Regards,
>> Deepak Kumar Barr
>> Bigfoot-Apps
>>
>> On Mon, Oct 26, 2015 at 3:35 PM, amareshwarisr .
>> > wrote:
>>
>> Friday works for me.
>>
>> On Mon, Oct 26, 2015 at 3:32 PM, Sharad Agarwal
>> > wrote:
>>
>> We can have on 30th Friday evening starting say 3 PM
>> or so.
>> Or can have on 31st Sat starting 10 AM
>>
>> Preferences ?
>>
>> On Fri, Oct 23, 2015 at 11:17 AM, Raju Bairishetti
>> >
>> wrote:
>>
>> > Thanks Sharad & flipkart for hosting meetup :).
>> >
>> > On Fri, Oct 23, 2015 at 9:55 AM, Sharad Agarwal
>> > wrote:
>> >
>> >> We can shoot for 30th Oct. I will check with folks
>> @flipkart and confirm
>> >> by monday.
>> >>
>> >> On Fri, Oct 23, 2015 at 8:05 AM, Raju Bairishetti
>> >
>> >> wrote:
>> >>
>> >>> Any thoughts on having the meetup in the next two
>> weeks. I would prefer
>> >>> meetup on weekends (30th october or 6th Nov).
>> >>>
>> >>> On Fri, Oct 9, 2015 at 3:24 PM, Yash Sharma
>> > wrote:
>> >>>
>> >>> > Also let me know the dates as early so that I
>> can book tickets and get
>> >>> > stickers printed :)
>> >>> >
>> >>> > Do share stickers ideas as well.
>> >>> >
>> >>> > - Via mobile. Excuse brevity.
>> >>> > On 9 Oct 2015 3:17 pm, "Yash Sharma"
>> > wrote:
>> >>> >
>> >>> >> Not google hangout maybe since there is a limit
>> of 10 people. We can
>> >>> >> probably think something like youtube live stream.
>> >>> >> Has anyone got past experience in webinar?
>> >>> >>
>> >>> >> - Via mobile. Excuse brevity.
>> >>> >> On 9 Oct 2015 3:11 pm, "Raju Bairishetti"
>> > wrote:
>> >>> >>
>> >>> >>> @Ankeet, Sounds great.
>> >>> >>>
>> >>> >>> @Sharad, Agree. We can have meetup week after
>> Dusshera holidays. It
>> >>> would
>> >>> >>> be nice to have google hangout session also
>> for every meetup :) .
>> >>> >>>
>> >>> >>> On Fri, Oct 9, 2015 at 2:49 PM, Ankeet Maini
>> 
>> >>> >
>> >>> >>> wrote:
>> >>> >>>
>> >>> >>> > +1 for the meet up! We should've a demo of
>> the new UI ;)
>> >>> >>> > --
>> >>> >>> > From: Deepak Kumar Barr (Tech_BLR)
>> > >
>> >>> >>> > Sent: ‎09-‎10-‎2015 12:51 PM
>> >>> >>> > To: u...@lens.apache.org
>> 
>> >>> >>> > Cc: dev > >
>> >>> >>> > Subject: Re: Next Lens Meetup
>> >>> >>> >
>> >>> >>> > +1 for meetup. But we can different dates.
>> 22nd is dussehra, people
>> >>> >>> might
>> >>> >>> > be on vacations.
>> >>> >>> >
>> >>> >>> > Regards,
>> >>> >>> > Deepak Kumar Barr
>> >>> >>> > Bigfoot-Apps
>> >>> >>> >
>> >>> >>> > On Fri, Oct 9, 2015 at 12:37 PM, Raju
>>   

[jira] [Commented] (LENS-848) Allow JDBC driver to take connection properties in configuration

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975875#comment-14975875
 ] 

Rajat Khandelwal commented on LENS-848:
---

Created https://reviews.apache.org/r/39680/

> Allow JDBC driver to take connection properties in configuration
> 
>
> Key: LENS-848
> URL: https://issues.apache.org/jira/browse/LENS-848
> Project: Apache Lens
>  Issue Type: Improvement
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work started] (LENS-848) Allow JDBC driver to take connection properties in configuration

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-848 started by Rajat Khandelwal.
-
> Allow JDBC driver to take connection properties in configuration
> 
>
> Key: LENS-848
> URL: https://issues.apache.org/jira/browse/LENS-848
> Project: Apache Lens
>  Issue Type: Improvement
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39680/
---

Review request for lens.


Bugs: LENS-848
https://issues.apache.org/jira/browse/LENS-848


Repository: lens


Description
---


Diffs
-

  lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java PRE-CREATION 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 ccb2b7fdf1fe297b7240ce1efcb1646303e1236d 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
 b14835a3c40eabd9b0939e9be19e41852e5f99c4 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
 70815bbb8d89685fd2f3faf14230b8b458270ff1 

Diff: https://reviews.apache.org/r/39680/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Updated] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-849:
-
Attachment: LENS-849.patch

Patch with fix, uploading for pre-commit tests

> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 39685: LENS-850 Queries with column name alias like "year" fails on some DBs

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39685/
---

Review request for lens.


Bugs: LENS-850
https://issues.apache.org/jira/browse/LENS-850


Repository: lens


Description
---

Changes for **LENS-850** 

-Back quoted column alias in all cases. This is required since some alias 
values can match DB keywords(example : year as alias) and in such case queries 
can fail on certain DBs if the alias in not back quoted

-Fixed Test cases where query was being checked for aliases


Diffs
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 1964e32 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
e6c3be0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
f5ff49a 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 
b2a15a0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java b0b2e88 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 
7580541 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
 d4d812f 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java 
d8c2f63 

Diff: https://reviews.apache.org/r/39685/diff/


Testing
---

[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules .. SUCCESS [  4.889 s]
[INFO] Lens ... SUCCESS [  4.539 s]
[INFO] Lens API ... SUCCESS [ 12.173 s]
[INFO] Lens API for server and extensions . SUCCESS [ 13.739 s]
[INFO] Lens Cube .. SUCCESS [ 17.653 s]
[INFO] Lens DB storage  SUCCESS [  1.731 s]
[INFO] Lens Query Library . SUCCESS [  2.545 s]
[INFO] Lens Hive Driver ... SUCCESS [  3.868 s]
[INFO] Lens Driver for JDBC ... SUCCESS [  5.935 s]
[INFO] Lens Elastic Search Driver . SUCCESS [  3.859 s]
[INFO] Lens Server  SUCCESS [ 32.874 s]
[INFO] Lens client  SUCCESS [  3.589 s]
[INFO] Lens CLI ... SUCCESS [  6.192 s]
[INFO] Lens Examples .. SUCCESS [  1.819 s]
[INFO] Lens Ship Jars to Distributed Cache  SUCCESS [  2.703 s]
[INFO] Lens Distribution .. SUCCESS [ 12.766 s]
[INFO] Lens ML Lib  SUCCESS [  5.735 s]
[INFO] Lens ML Ext Distribution ... SUCCESS [  5.241 s]
[INFO] Lens Regression  SUCCESS [  5.171 s]
[INFO] Lens UI  SUCCESS [ 10.216 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 02:38 min
[INFO] Finished at: 2015-10-27T18:52:05+05:30
[INFO] Final Memory: 188M/1572M


Thanks,

Puneet Gupta

Re: Review Request 39652: LENS-847 Columnar JDBC Rewriter in incorrectly pushing filter against wrong alias when fact columns map to a single dimension

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39652/#review104163
---

Ship it!


Ship It!

- Rajat Khandelwal


On Oct. 27, 2015, 12:17 a.m., Srikanth Sundarrajan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39652/
> ---
> 
> (Updated Oct. 27, 2015, 12:17 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-847
> https://issues.apache.org/jira/browse/LENS-847
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Columnar JDBC Rewriter in incorrectly pushing filter against wrong alias when 
> fact columns map to a single dimension
> 
> 
> Diffs
> -
> 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  ccb2b7f 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
>  d4d812f 
> 
> Diff: https://reviews.apache.org/r/39652/diff/
> 
> 
> Testing
> ---
> 
> Added tests to verify the fix.
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>

[jira] [Created] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Amareshwari Sriramadasu (JIRA)]

Amareshwari Sriramadasu created LENS-849:


 Summary: NPE with CandidateTableResolver with expression dimensions
 Key: LENS-849
 URL: https://issues.apache.org/jira/browse/LENS-849
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Amareshwari Sriramadasu
Assignee: Amareshwari Sriramadasu
 Fix For: 2.5


{noformat}
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-850) Queries with column name alias like "year" fails on some DBs

[Puneet Gupta (JIRA)]

Puneet Gupta created LENS-850:
-

 Summary: Queries with column name alias like "year" fails on some 
DBs
 Key: LENS-850
 URL: https://issues.apache.org/jira/browse/LENS-850
 Project: Apache Lens
  Issue Type: Improvement
Affects Versions: 2.3, 2.1, 2.0
Reporter: Puneet Gupta


"Select column_year year from Test_Table" 
fails on some DBs.

Reason: 
This is because "year" is a keyword in some DBs and the query needs to be 
rewritten with alias name quoted before it is executed.
"Select coulm_year as `year` from Test_Table"

 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39680/#review104162
---



lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
(line 705)


JDBC_DB_URI is added twice and JDBC_DRIVER_CLASS is removed


- Amareshwari Sriramadasu


On Oct. 27, 2015, 12:38 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39680/
> ---
> 
> (Updated Oct. 27, 2015, 12:38 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-848
> https://issues.apache.org/jira/browse/LENS-848
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Will plan to separate properties later. Keeping them for backward 
> compatibility.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
> PRE-CREATION 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  ccb2b7fdf1fe297b7240ce1efcb1646303e1236d 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
>  b14835a3c40eabd9b0939e9be19e41852e5f99c4 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> 777f73a7bf9f30c0035b90689de9a83c908a1402 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
>  70815bbb8d89685fd2f3faf14230b8b458270ff1 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
> 163ed42daf49a182ead3eca048b3ada6e53e2c0b 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
>  9041709554d67ca1b047e6db24be9cd52127ac5d 
>   lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml 
> 5594fbfac9d2da6c5a1116db41bfcbedbcf19130 
> 
> Diff: https://reviews.apache.org/r/39680/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.414s]
> [INFO] Lens .. SUCCESS [3.298s]
> [INFO] Lens API .. SUCCESS [27.005s]
> [INFO] Lens API for server and extensions  SUCCESS [25.469s]
> [INFO] Lens Cube . SUCCESS [5:46.494s]
> [INFO] Lens DB storage ... SUCCESS [22.510s]
> [INFO] Lens Query Library  SUCCESS [19.621s]
> [INFO] Lens Hive Driver .. SUCCESS [2:57.116s]
> [INFO] Lens Driver for JDBC .. SUCCESS [40.236s]
> [INFO] Lens Elastic Search Driver  SUCCESS [19.414s]
> [INFO] Lens Server ... SUCCESS [8:21.803s]
> [INFO] Lens client ... SUCCESS [36.730s]
> [INFO] Lens CLI .. SUCCESS [54.984s]
> [INFO] Lens Examples . SUCCESS [10.850s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.867s]
> [INFO] Lens Distribution . SUCCESS [9.404s]
> [INFO] Lens ML Lib ... SUCCESS [1:24.110s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.979s]
> [INFO] Lens Regression ... SUCCESS [13.230s]
> [INFO] Lens UI ... SUCCESS [27.486s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 23:47.270s
> [INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
> [INFO] Final Memory: 179M/1101M
> [INFO] 
> 
> jdbc driver test cases and checkstyle passed
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Updated] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-849:
-
Status: Patch Available  (was: Open)

> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 39686: LENS-849 : Fix NPE in CandidateTableResolver with expression dimension

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39686/
---

Review request for lens.


Bugs: LENS-849
https://issues.apache.org/jira/browse/LENS-849


Repository: lens


Description
---

Added regression test with fix. Also fixed comparison in TestQuery for non-join 
queries.


Diffs
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 
f81f3d5 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 705f19b 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 
b2a15a0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java 2707c4c 

Diff: https://reviews.apache.org/r/39686/diff/


Testing
---

All lens-cube tests succeeded


Thanks,

Amareshwari Sriramadasu

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39680/
---

(Updated Oct. 27, 2015, 6 p.m.)


Review request for lens.


Bugs: LENS-848
https://issues.apache.org/jira/browse/LENS-848


Repository: lens


Description
---

Will plan to separate properties later. Keeping them for backward compatibility.


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java PRE-CREATION 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 ccb2b7fdf1fe297b7240ce1efcb1646303e1236d 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
 b14835a3c40eabd9b0939e9be19e41852e5f99c4 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
777f73a7bf9f30c0035b90689de9a83c908a1402 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
 70815bbb8d89685fd2f3faf14230b8b458270ff1 
  lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
163ed42daf49a182ead3eca048b3ada6e53e2c0b 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
9041709554d67ca1b047e6db24be9cd52127ac5d 
  lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml 
5594fbfac9d2da6c5a1116db41bfcbedbcf19130 

Diff: https://reviews.apache.org/r/39680/diff/


Testing (updated)
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [2.414s]
[INFO] Lens .. SUCCESS [3.298s]
[INFO] Lens API .. SUCCESS [27.005s]
[INFO] Lens API for server and extensions  SUCCESS [25.469s]
[INFO] Lens Cube . SUCCESS [5:46.494s]
[INFO] Lens DB storage ... SUCCESS [22.510s]
[INFO] Lens Query Library  SUCCESS [19.621s]
[INFO] Lens Hive Driver .. SUCCESS [2:57.116s]
[INFO] Lens Driver for JDBC .. SUCCESS [40.236s]
[INFO] Lens Elastic Search Driver  SUCCESS [19.414s]
[INFO] Lens Server ... SUCCESS [8:21.803s]
[INFO] Lens client ... SUCCESS [36.730s]
[INFO] Lens CLI .. SUCCESS [54.984s]
[INFO] Lens Examples . SUCCESS [10.850s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.867s]
[INFO] Lens Distribution . SUCCESS [9.404s]
[INFO] Lens ML Lib ... SUCCESS [1:24.110s]
[INFO] Lens ML Ext Distribution .. SUCCESS [1.979s]
[INFO] Lens Regression ... SUCCESS [13.230s]
[INFO] Lens UI ... SUCCESS [27.486s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 23:47.270s
[INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
[INFO] Final Memory: 179M/1101M
[INFO] 
jdbc driver test cases and checkstyle passed


Thanks,

Rajat Khandelwal

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39680/
---

(Updated Oct. 27, 2015, 6:08 p.m.)


Review request for lens.


Bugs: LENS-848
https://issues.apache.org/jira/browse/LENS-848


Repository: lens


Description
---

Will plan to separate properties later. Keeping them for backward compatibility.


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java PRE-CREATION 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 ccb2b7fdf1fe297b7240ce1efcb1646303e1236d 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
 b14835a3c40eabd9b0939e9be19e41852e5f99c4 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
777f73a7bf9f30c0035b90689de9a83c908a1402 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
 70815bbb8d89685fd2f3faf14230b8b458270ff1 
  lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
163ed42daf49a182ead3eca048b3ada6e53e2c0b 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
9041709554d67ca1b047e6db24be9cd52127ac5d 
  lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml 
5594fbfac9d2da6c5a1116db41bfcbedbcf19130 

Diff: https://reviews.apache.org/r/39680/diff/


Testing
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [2.414s]
[INFO] Lens .. SUCCESS [3.298s]
[INFO] Lens API .. SUCCESS [27.005s]
[INFO] Lens API for server and extensions  SUCCESS [25.469s]
[INFO] Lens Cube . SUCCESS [5:46.494s]
[INFO] Lens DB storage ... SUCCESS [22.510s]
[INFO] Lens Query Library  SUCCESS [19.621s]
[INFO] Lens Hive Driver .. SUCCESS [2:57.116s]
[INFO] Lens Driver for JDBC .. SUCCESS [40.236s]
[INFO] Lens Elastic Search Driver  SUCCESS [19.414s]
[INFO] Lens Server ... SUCCESS [8:21.803s]
[INFO] Lens client ... SUCCESS [36.730s]
[INFO] Lens CLI .. SUCCESS [54.984s]
[INFO] Lens Examples . SUCCESS [10.850s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.867s]
[INFO] Lens Distribution . SUCCESS [9.404s]
[INFO] Lens ML Lib ... SUCCESS [1:24.110s]
[INFO] Lens ML Ext Distribution .. SUCCESS [1.979s]
[INFO] Lens Regression ... SUCCESS [13.230s]
[INFO] Lens UI ... SUCCESS [27.486s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 23:47.270s
[INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
[INFO] Final Memory: 179M/1101M
[INFO] 
jdbc driver test cases and checkstyle passed


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-850) Queries with column name alias like "year" fails on some DBs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976527#comment-14976527
 ] 

Hadoop QA commented on LENS-850:


Applied patch: 
[lens-850.patch|https://issues.apache.org/jira/secure/attachment/12768988/lens-850.patch]
 and ran command: mvn clean install. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/155/

> Queries with column name alias like "year" fails on some DBs
> 
>
> Key: LENS-850
> URL: https://issues.apache.org/jira/browse/LENS-850
> Project: Apache Lens
>  Issue Type: Improvement
>Affects Versions: 2.0, 2.1, 2.3
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.5
>
> Attachments: lens-850.patch
>
>
> "Select column_year year from Test_Table" 
> fails on some DBs.
> Reason: 
> This is because "year" is a keyword in some DBs and the query needs to be 
> rewritten with alias name quoted before it is executed.
> "Select coulm_year as `year` from Test_Table"
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-849:
-
Attachment: LENS-849.4.patch

Patch rebased to master

> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849.2.patch, LENS-849.3.patch, LENS-849.4.patch, 
> LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-847) Columnar JDBC Rewriter in incorrectly pushing filter against wrong alias when fact columns map to a single dimension

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976494#comment-14976494
 ] 

Hudson commented on LENS-847:
-

SUCCESS: Integrated in Lens-Commit #1117 (See 
[https://builds.apache.org/job/Lens-Commit/1117/])
LENS-847: Columnar JDBC Rewriter in incorrectly pushing filter against 
(rajatgupta59: rev ccf71332f90f7dd36eac0a84c3b32f9ff76d2812)
* 
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
* 
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java


> Columnar JDBC Rewriter in incorrectly pushing filter against wrong alias when 
> fact columns map to a single dimension
> 
>
> Key: LENS-847
> URL: https://issues.apache.org/jira/browse/LENS-847
> Project: Apache Lens
>  Issue Type: Bug
>  Components: driver-jdbc
>Affects Versions: 2.3, 2.4, 2.5
>Reporter: Srikanth Sundarrajan
>Assignee: Srikanth Sundarrajan
> Fix For: 2.4, 2.5
>
> Attachments: LEN-847-V1.patch, LEN-847.patch
>
>
> Columnar JDBC Rewriter in incorrectly pushing filter against wrong alias when 
> fact columns map to a single dimension.
> Ex:
> select fact.time_key, time_dim.day_of_week, location_dim_a.location_name, 
> other_location_dim.location_name, sum(fact.dollars_sold) from sales_fact fact 
> inner join time_dim time_dim on fact.time_key = time_dim.time_key inner join 
> location_dim location_dim_a on fact.location_key = 
> location_dim_a.location_key inner join location_dim other_location_dim on 
> fact.other_location_key = other_location_dim.location_key where 
> time_dim.time_key between '2013-01-01' and '2013-01-31' and 
> location_dim_a.location_key = 'some-loc' group by fact.time_key, 
> location_dim_a.location_key, other_location_dim.location_key
> is being rewritten to 
> select ( sales_fact___fact . time_key ), ( time_dim___time_dim . day_of_week 
> ), ( location_dim___location_dim_a . location_name ), ( 
> location_dim___other_location_dim . location_name ), sum(alias1) from  
> (select sales_fact___fact.time_key, sales_fact___fact.location_key, 
> sales_fact___fact.other_location_key,sum(( sales_fact___fact . dollars_sold 
> )) as alias1 from sales_fact sales_fact___fact where 
> sales_fact___fact.time_key in  (  select time_dim .time_key from time_dim 
> where ( time_dim. time_key ) between  '2013-01-01'  and  '2013-01-31'  ) and 
> sales_fact___fact.location_key in  (  select location_dim .location_key from 
> location_dim where (( location_dim. location_key ) =  'some-loc' ) ) and 
> {{sales_fact___fact.other_location_key in  (  select location_dim 
> .location_key from location_dim where (( location_dim. location_key ) =  
> 'some-loc' ) )}}  group by sales_fact___fact.time_key, 
> sales_fact___fact.location_key, sales_fact___fact.other_location_key) 
> sales_fact___fact  inner join (select time_key,day_of_week from time_dim) 
> time_dim___time_dim on (( sales_fact___fact . time_key ) = ( 
> time_dim___time_dim . time_key ))  inner join (select 
> location_key,location_name from location_dim) location_dim___location_dim_a 
> on (( sales_fact___fact . location_key ) = ( location_dim___location_dim_a . 
> location_key ))  inner join (select location_key,location_name from 
> location_dim) location_dim___other_location_dim on (( sales_fact___fact . 
> other_location_key ) = ( location_dim___other_location_dim . location_key ))  
> where (( time_dim___time_dim . time_key ) between  '2013-01-01'  and  
> '2013-01-31'  and (( location_dim___location_dim_a . location_key ) =  
> 'some-loc' )) group by ( sales_fact___fact . time_key ), ( 
> location_dim___location_dim_a . location_key ), ( 
> location_dim___other_location_dim . location_key )



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39680/
---

(Updated Oct. 27, 2015, 8:37 p.m.)


Review request for lens.


Bugs: LENS-848
https://issues.apache.org/jira/browse/LENS-848


Repository: lens


Description
---

Will plan to separate properties later. Keeping them for backward compatibility.


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java PRE-CREATION 
  lens-api/src/test/java/org/apache/lens/api/util/CommonUtilsTest.java 
PRE-CREATION 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 825a039d1de808e85a9909b18865c1989c486743 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
 b14835a3c40eabd9b0939e9be19e41852e5f99c4 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
777f73a7bf9f30c0035b90689de9a83c908a1402 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
 70815bbb8d89685fd2f3faf14230b8b458270ff1 
  lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
163ed42daf49a182ead3eca048b3ada6e53e2c0b 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDataSourceConnectionProvider.java
 21e5f50dcbcabe4d93b9cfac45191f8f4c129a1e 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
9041709554d67ca1b047e6db24be9cd52127ac5d 
  lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml 
5594fbfac9d2da6c5a1116db41bfcbedbcf19130 
  src/site/apt/admin/config.apt 76cbff07ad72f9a43de62f1166c1f0331b3038c0 
  src/site/apt/admin/jdbcdriver-config.apt 
7b42309fb2a3c0d3478c6d0f472f782c69f76f85 

Diff: https://reviews.apache.org/r/39680/diff/


Testing
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [2.414s]
[INFO] Lens .. SUCCESS [3.298s]
[INFO] Lens API .. SUCCESS [27.005s]
[INFO] Lens API for server and extensions  SUCCESS [25.469s]
[INFO] Lens Cube . SUCCESS [5:46.494s]
[INFO] Lens DB storage ... SUCCESS [22.510s]
[INFO] Lens Query Library  SUCCESS [19.621s]
[INFO] Lens Hive Driver .. SUCCESS [2:57.116s]
[INFO] Lens Driver for JDBC .. SUCCESS [40.236s]
[INFO] Lens Elastic Search Driver  SUCCESS [19.414s]
[INFO] Lens Server ... SUCCESS [8:21.803s]
[INFO] Lens client ... SUCCESS [36.730s]
[INFO] Lens CLI .. SUCCESS [54.984s]
[INFO] Lens Examples . SUCCESS [10.850s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.867s]
[INFO] Lens Distribution . SUCCESS [9.404s]
[INFO] Lens ML Lib ... SUCCESS [1:24.110s]
[INFO] Lens ML Ext Distribution .. SUCCESS [1.979s]
[INFO] Lens Regression ... SUCCESS [13.230s]
[INFO] Lens UI ... SUCCESS [27.486s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 23:47.270s
[INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
[INFO] Final Memory: 179M/1101M
[INFO] 
jdbc driver test cases and checkstyle passed


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976553#comment-14976553
 ] 

Hadoop QA commented on LENS-849:


Patch does not apply. Build job: 
https://builds.apache.org/job/PreCommit-Lens-Build/157/

> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849.2.patch, LENS-849.3.patch, LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976579#comment-14976579
 ] 

Rajat Khandelwal commented on LENS-849:
---

Committed. Thanks [~amareshwari]

> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849.2.patch, LENS-849.3.patch, LENS-849.4.patch, 
> LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-850) Queries with column name alias like "year" fails on some DBs

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976602#comment-14976602
 ] 

Hudson commented on LENS-850:
-

SUCCESS: Integrated in Lens-Commit-Java8 #28 (See 
[https://builds.apache.org/job/Lens-Commit-Java8/28/])
LENS-850: Queries with column name alias like "year" fails on some DBs 
(rajatgupta59: rev 6c4dba51bfebba2bd019508d2e44850ef964d150)
* lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java
* 
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java


> Queries with column name alias like "year" fails on some DBs
> 
>
> Key: LENS-850
> URL: https://issues.apache.org/jira/browse/LENS-850
> Project: Apache Lens
>  Issue Type: Improvement
>Affects Versions: 2.0, 2.1, 2.3
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.5
>
> Attachments: lens-850.patch
>
>
> "Select column_year year from Test_Table" 
> fails on some DBs.
> Reason: 
> This is because "year" is a keyword in some DBs and the query needs to be 
> rewritten with alias name quoted before it is executed.
> "Select coulm_year as `year` from Test_Table"
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-849:
-
Status: Open  (was: Patch Available)

> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849.2.patch, LENS-849.3.patch, LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-848) Allow JDBC driver to take connection properties in configuration

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976609#comment-14976609
 ] 

Hadoop QA commented on LENS-848:


Applied patch: 
[LENS-848.09.patch|https://issues.apache.org/jira/secure/attachment/12769011/LENS-848.09.patch]
 and ran command: mvn clean install. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/158/

> Allow JDBC driver to take connection properties in configuration
> 
>
> Key: LENS-848
> URL: https://issues.apache.org/jira/browse/LENS-848
> Project: Apache Lens
>  Issue Type: Improvement
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-848.09.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-850) Queries with column name alias like "year" fails on some DBs

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976617#comment-14976617
 ] 

Hudson commented on LENS-850:
-

SUCCESS: Integrated in Lens-Commit #1118 (See 
[https://builds.apache.org/job/Lens-Commit/1118/])
LENS-850: Queries with column name alias like "year" fails on some DBs 
(rajatgupta59: rev 6c4dba51bfebba2bd019508d2e44850ef964d150)
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
* lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
* 
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java


> Queries with column name alias like "year" fails on some DBs
> 
>
> Key: LENS-850
> URL: https://issues.apache.org/jira/browse/LENS-850
> Project: Apache Lens
>  Issue Type: Improvement
>Affects Versions: 2.0, 2.1, 2.3
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.5
>
> Attachments: lens-850.patch
>
>
> "Select column_year year from Test_Table" 
> fails on some DBs.
> Reason: 
> This is because "year" is a keyword in some DBs and the query needs to be 
> rewritten with alias name quoted before it is executed.
> "Select coulm_year as `year` from Test_Table"
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976641#comment-14976641
 ] 

Hudson commented on LENS-849:
-

UNSTABLE: Integrated in Lens-Commit-Java8 #29 (See 
[https://builds.apache.org/job/Lens-Commit-Java8/29/])
LENS-849: NPE with CandidateTableResolver with expression dimensions 
(rajatgupta59: rev 09419a577f6b4d4ac8890be10de7ddf256ef616b)
* 
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java


> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849.2.patch, LENS-849.3.patch, LENS-849.4.patch, 
> LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976574#comment-14976574
 ] 

Hadoop QA commented on LENS-849:


Applied patch: 
[LENS-849.3.patch|https://issues.apache.org/jira/secure/attachment/12769002/LENS-849.3.patch]
 and ran command: mvn clean install. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/156/

> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849.2.patch, LENS-849.3.patch, LENS-849.4.patch, 
> LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-850) Queries with column name alias like "year" fails on some DBs

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976533#comment-14976533
 ] 

Rajat Khandelwal commented on LENS-850:
---

Committed. Thanks [~puneet884]

> Queries with column name alias like "year" fails on some DBs
> 
>
> Key: LENS-850
> URL: https://issues.apache.org/jira/browse/LENS-850
> Project: Apache Lens
>  Issue Type: Improvement
>Affects Versions: 2.0, 2.1, 2.3
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.5
>
> Attachments: lens-850.patch
>
>
> "Select column_year year from Test_Table" 
> fails on some DBs.
> Reason: 
> This is because "year" is a keyword in some DBs and the query needs to be 
> rewritten with alias name quoted before it is executed.
> "Select coulm_year as `year` from Test_Table"
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-850) Queries with column name alias like "year" fails on some DBs

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-850:
--
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Queries with column name alias like "year" fails on some DBs
> 
>
> Key: LENS-850
> URL: https://issues.apache.org/jira/browse/LENS-850
> Project: Apache Lens
>  Issue Type: Improvement
>Affects Versions: 2.0, 2.1, 2.3
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.5
>
> Attachments: lens-850.patch
>
>
> "Select column_year year from Test_Table" 
> fails on some DBs.
> Reason: 
> This is because "year" is a keyword in some DBs and the query needs to be 
> rewritten with alias name quoted before it is executed.
> "Select coulm_year as `year` from Test_Table"
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-849:
-
Status: Patch Available  (was: Open)

> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849.2.patch, LENS-849.3.patch, LENS-849.4.patch, 
> LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-849:
-
Attachment: LENS-849.3.patch

> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849.2.patch, LENS-849.3.patch, LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-849:
--
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849.2.patch, LENS-849.3.patch, LENS-849.4.patch, 
> LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-848) Allow JDBC driver to take connection properties in configuration

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-848:
--
Status: Patch Available  (was: In Progress)

> Allow JDBC driver to take connection properties in configuration
> 
>
> Key: LENS-848
> URL: https://issues.apache.org/jira/browse/LENS-848
> Project: Apache Lens
>  Issue Type: Improvement
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-848.09.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-848) Allow JDBC driver to take connection properties in configuration

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-848:
--
Attachment: LENS-848.09.patch

> Allow JDBC driver to take connection properties in configuration
> 
>
> Key: LENS-848
> URL: https://issues.apache.org/jira/browse/LENS-848
> Project: Apache Lens
>  Issue Type: Improvement
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-848.09.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39680/
---

(Updated Oct. 27, 2015, 9:16 p.m.)


Review request for lens.


Bugs: LENS-848
https://issues.apache.org/jira/browse/LENS-848


Repository: lens


Description
---

Will plan to separate properties later. Keeping them for backward compatibility.


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java PRE-CREATION 
  lens-api/src/test/java/org/apache/lens/api/util/CommonUtilsTest.java 
PRE-CREATION 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 825a039d1de808e85a9909b18865c1989c486743 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
 b14835a3c40eabd9b0939e9be19e41852e5f99c4 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
777f73a7bf9f30c0035b90689de9a83c908a1402 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
 70815bbb8d89685fd2f3faf14230b8b458270ff1 
  lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
163ed42daf49a182ead3eca048b3ada6e53e2c0b 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDataSourceConnectionProvider.java
 21e5f50dcbcabe4d93b9cfac45191f8f4c129a1e 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
9041709554d67ca1b047e6db24be9cd52127ac5d 
  lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml 
5594fbfac9d2da6c5a1116db41bfcbedbcf19130 
  src/site/apt/admin/config.apt 76cbff07ad72f9a43de62f1166c1f0331b3038c0 
  src/site/apt/admin/jdbcdriver-config.apt 
7b42309fb2a3c0d3478c6d0f472f782c69f76f85 

Diff: https://reviews.apache.org/r/39680/diff/


Testing
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [2.414s]
[INFO] Lens .. SUCCESS [3.298s]
[INFO] Lens API .. SUCCESS [27.005s]
[INFO] Lens API for server and extensions  SUCCESS [25.469s]
[INFO] Lens Cube . SUCCESS [5:46.494s]
[INFO] Lens DB storage ... SUCCESS [22.510s]
[INFO] Lens Query Library  SUCCESS [19.621s]
[INFO] Lens Hive Driver .. SUCCESS [2:57.116s]
[INFO] Lens Driver for JDBC .. SUCCESS [40.236s]
[INFO] Lens Elastic Search Driver  SUCCESS [19.414s]
[INFO] Lens Server ... SUCCESS [8:21.803s]
[INFO] Lens client ... SUCCESS [36.730s]
[INFO] Lens CLI .. SUCCESS [54.984s]
[INFO] Lens Examples . SUCCESS [10.850s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.867s]
[INFO] Lens Distribution . SUCCESS [9.404s]
[INFO] Lens ML Lib ... SUCCESS [1:24.110s]
[INFO] Lens ML Ext Distribution .. SUCCESS [1.979s]
[INFO] Lens Regression ... SUCCESS [13.230s]
[INFO] Lens UI ... SUCCESS [27.486s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 23:47.270s
[INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
[INFO] Final Memory: 179M/1101M
[INFO] 
jdbc driver test cases and checkstyle passed


Thanks,

Rajat Khandelwal

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39680/#review104171
---



lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
 (line 195)


Seems a wrong property setting even earlier


- Amareshwari Sriramadasu


On Oct. 27, 2015, 2:53 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39680/
> ---
> 
> (Updated Oct. 27, 2015, 2:53 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-848
> https://issues.apache.org/jira/browse/LENS-848
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Will plan to separate properties later. Keeping them for backward 
> compatibility.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
> PRE-CREATION 
>   lens-api/src/test/java/org/apache/lens/api/util/CommonUtilsTest.java 
> PRE-CREATION 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  825a039d1de808e85a9909b18865c1989c486743 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
>  b14835a3c40eabd9b0939e9be19e41852e5f99c4 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> 777f73a7bf9f30c0035b90689de9a83c908a1402 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
>  70815bbb8d89685fd2f3faf14230b8b458270ff1 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
> 163ed42daf49a182ead3eca048b3ada6e53e2c0b 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDataSourceConnectionProvider.java
>  21e5f50dcbcabe4d93b9cfac45191f8f4c129a1e 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
>  9041709554d67ca1b047e6db24be9cd52127ac5d 
>   lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml 
> 5594fbfac9d2da6c5a1116db41bfcbedbcf19130 
>   src/site/apt/admin/config.apt 76cbff07ad72f9a43de62f1166c1f0331b3038c0 
>   src/site/apt/admin/jdbcdriver-config.apt 
> 7b42309fb2a3c0d3478c6d0f472f782c69f76f85 
> 
> Diff: https://reviews.apache.org/r/39680/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.414s]
> [INFO] Lens .. SUCCESS [3.298s]
> [INFO] Lens API .. SUCCESS [27.005s]
> [INFO] Lens API for server and extensions  SUCCESS [25.469s]
> [INFO] Lens Cube . SUCCESS [5:46.494s]
> [INFO] Lens DB storage ... SUCCESS [22.510s]
> [INFO] Lens Query Library  SUCCESS [19.621s]
> [INFO] Lens Hive Driver .. SUCCESS [2:57.116s]
> [INFO] Lens Driver for JDBC .. SUCCESS [40.236s]
> [INFO] Lens Elastic Search Driver  SUCCESS [19.414s]
> [INFO] Lens Server ... SUCCESS [8:21.803s]
> [INFO] Lens client ... SUCCESS [36.730s]
> [INFO] Lens CLI .. SUCCESS [54.984s]
> [INFO] Lens Examples . SUCCESS [10.850s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.867s]
> [INFO] Lens Distribution . SUCCESS [9.404s]
> [INFO] Lens ML Lib ... SUCCESS [1:24.110s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.979s]
> [INFO] Lens Regression ... SUCCESS [13.230s]
> [INFO] Lens UI ... SUCCESS [27.486s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 23:47.270s
> [INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
> [INFO] Final Memory: 179M/1101M
> [INFO] 
> 
> jdbc driver test cases and checkstyle passed
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39680/
---

(Updated Oct. 27, 2015, 8:23 p.m.)


Review request for lens.


Bugs: LENS-848
https://issues.apache.org/jira/browse/LENS-848


Repository: lens


Description
---

Will plan to separate properties later. Keeping them for backward compatibility.


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java PRE-CREATION 
  lens-api/src/test/java/org/apache/lens/api/util/CommonUtilsTest.java 
PRE-CREATION 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 825a039d1de808e85a9909b18865c1989c486743 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
 b14835a3c40eabd9b0939e9be19e41852e5f99c4 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
777f73a7bf9f30c0035b90689de9a83c908a1402 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
 70815bbb8d89685fd2f3faf14230b8b458270ff1 
  lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
163ed42daf49a182ead3eca048b3ada6e53e2c0b 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDataSourceConnectionProvider.java
 21e5f50dcbcabe4d93b9cfac45191f8f4c129a1e 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
9041709554d67ca1b047e6db24be9cd52127ac5d 
  lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml 
5594fbfac9d2da6c5a1116db41bfcbedbcf19130 
  src/site/apt/admin/config.apt 76cbff07ad72f9a43de62f1166c1f0331b3038c0 
  src/site/apt/admin/jdbcdriver-config.apt 
7b42309fb2a3c0d3478c6d0f472f782c69f76f85 

Diff: https://reviews.apache.org/r/39680/diff/


Testing
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [2.414s]
[INFO] Lens .. SUCCESS [3.298s]
[INFO] Lens API .. SUCCESS [27.005s]
[INFO] Lens API for server and extensions  SUCCESS [25.469s]
[INFO] Lens Cube . SUCCESS [5:46.494s]
[INFO] Lens DB storage ... SUCCESS [22.510s]
[INFO] Lens Query Library  SUCCESS [19.621s]
[INFO] Lens Hive Driver .. SUCCESS [2:57.116s]
[INFO] Lens Driver for JDBC .. SUCCESS [40.236s]
[INFO] Lens Elastic Search Driver  SUCCESS [19.414s]
[INFO] Lens Server ... SUCCESS [8:21.803s]
[INFO] Lens client ... SUCCESS [36.730s]
[INFO] Lens CLI .. SUCCESS [54.984s]
[INFO] Lens Examples . SUCCESS [10.850s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.867s]
[INFO] Lens Distribution . SUCCESS [9.404s]
[INFO] Lens ML Lib ... SUCCESS [1:24.110s]
[INFO] Lens ML Ext Distribution .. SUCCESS [1.979s]
[INFO] Lens Regression ... SUCCESS [13.230s]
[INFO] Lens UI ... SUCCESS [27.486s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 23:47.270s
[INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
[INFO] Final Memory: 179M/1101M
[INFO] 
jdbc driver test cases and checkstyle passed


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976687#comment-14976687
 ] 

Hudson commented on LENS-849:
-

UNSTABLE: Integrated in Lens-Commit #1119 (See 
[https://builds.apache.org/job/Lens-Commit/1119/])
LENS-849: NPE with CandidateTableResolver with expression dimensions 
(rajatgupta59: rev 09419a577f6b4d4ac8890be10de7ddf256ef616b)
* lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java
* 
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java


> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849.2.patch, LENS-849.3.patch, LENS-849.4.patch, 
> LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-849:
-
Attachment: LENS-849-test.patch

Patch with test failures fixed

> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849-test.patch, LENS-849.2.patch, LENS-849.3.patch, 
> LENS-849.4.patch, LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: lens eclipse setup

[Puneet Gupta]

Hi

I have noted a few points that I followed while making eclipse setup for
lens few months ago. Listing them below ( Your problem should be solved by
point 5)

1. Use Eclipse Luna or below. Eclipse Mars does not support lombok library
as plugin/agent which is used in lens.
2. Lombok needs to be used a javaagent while running eclipse for lombok
based code to compile in eclipse. This can be done in two ways

   -  Manually edit eclipse.ini by adding below entry

  "-javaagent:lombok.jar" Entry should be added to eclipse.ini


   -   OR run lombok jar as java app (java -jar lombo.jar) and point to
   eclipse.ini in the app GUI . This will update eclipse.ini (make sure
   eclipse is not running)

   [image: Inline image 1]


3.For easy project setup in eclipse, use lens as a Maven project inside
eclipse(rather than a simple java project). For this M2Eclipse plugin is
required in eclipse (It can be installed ineclipse via "Install new
software" --> Add plugin .url
*http://download.eclipse.org/technology/m2e/releases
*).

4. Once plugin is installed. Import lens directory as Existing Maven
Project .

[image: Inline image 1]


5. Ignore any errors (Approx 6 errors) of type "Plugin execution not
covered by lifecycle configuration:
org.apache.maven.plugins:maven-dependency-plugin". This can be done by
selecting quick fix (option1 preferably as it will not update pom file) in
eclipse.
More on this in
*https://www.eclipse.org/m2e/documentation/m2e-execution-not-covered.html
*


Thanks,
Puneet Gupta

On Tue, Oct 27, 2015 at 10:42 PM, amareshwarisr . 
wrote:

> We have seen issues with eclipse setup. Puneet would help with this.
>
> Thanks
> Amareshwari
>
> On Tue, Oct 27, 2015 at 10:37 AM, Sandeep  wrote:
>
> > hi,
> > I am trying to setup lens code on eclipse, by importing a maven project
> > from the root folder.
> > I am getting this error (attached).
> > do you know why? is there any documentation to help setup IDE.
> >
> >
> > -Sandeep
> >
>

-- 
_
The information contained in this communication is intended solely for the 
use of the individual or entity to whom it is addressed and others 
authorized to receive it. It may contain confidential or legally privileged 
information. If you are not the intended recipient you are hereby notified 
that any disclosure, copying, distribution or taking any action in reliance 
on the contents of this information is strictly prohibited and may be 
unlawful. If you have received this communication in error, please notify 
us immediately by responding to this email and then delete it from your 
system. The firm is neither liable for the proper and complete transmission 
of the information contained in this communication nor for any delay in its 
receipt.

Re: lens eclipse setup

[amareshwarisr .]

We have seen issues with eclipse setup. Puneet would help with this.

Thanks
Amareshwari

On Tue, Oct 27, 2015 at 10:37 AM, Sandeep  wrote:

> hi,
> I am trying to setup lens code on eclipse, by importing a maven project
> from the root folder.
> I am getting this error (attached).
> do you know why? is there any documentation to help setup IDE.
>
>
> -Sandeep
>

Re: lens eclipse setup

[Yash Sharma]

Hi Puneet,
Thanks for the tips.
For images could you please upload images to public image hosting site like
imgur and post the links.

Kind Regards

On Tue, Oct 27, 2015 at 10:54 PM, Puneet Gupta 
wrote:

> Hi
>
> I have noted a few points that I followed while making eclipse setup for
> lens few months ago. Listing them below ( Your problem should be solved by
> point 5)
>
> 1. Use Eclipse Luna or below. Eclipse Mars does not support lombok
> library as plugin/agent which is used in lens.
> 2. Lombok needs to be used a javaagent while running eclipse for lombok
> based code to compile in eclipse. This can be done in two ways
>
>-  Manually edit eclipse.ini by adding below entry
>
>   "-javaagent:lombok.jar" Entry should be added to eclipse.ini
>
>
>-   OR run lombok jar as java app (java -jar lombo.jar) and point
>to eclipse.ini in the app GUI . This will update eclipse.ini (make
>sure eclipse is not running)
>
>[image: Inline image 1]
>
>
> 3.For easy project setup in eclipse, use lens as a Maven project inside
> eclipse(rather than a simple java project). For this M2Eclipse plugin is
> required in eclipse (It can be installed ineclipse via "Install new
> software" --> Add plugin .url 
> *http://download.eclipse.org/technology/m2e/releases
> *).
>
> 4. Once plugin is installed. Import lens directory as Existing Maven
> Project .
>
> [image: Inline image 1]
>
>
> 5. Ignore any errors (Approx 6 errors) of type "Plugin execution not
> covered by lifecycle configuration:
> org.apache.maven.plugins:maven-dependency-plugin". This can be done by
> selecting quick fix (option1 preferably as it will not update pom file) in
> eclipse.
> More on this in 
> *https://www.eclipse.org/m2e/documentation/m2e-execution-not-covered.html
> *
>
>
>
> Thanks,
> Puneet Gupta
>
> On Tue, Oct 27, 2015 at 10:42 PM, amareshwarisr . 
> wrote:
>
>> We have seen issues with eclipse setup. Puneet would help with this.
>>
>> Thanks
>> Amareshwari
>>
>> On Tue, Oct 27, 2015 at 10:37 AM, Sandeep  wrote:
>>
>> > hi,
>> > I am trying to setup lens code on eclipse, by importing a maven project
>> > from the root folder.
>> > I am getting this error (attached).
>> > do you know why? is there any documentation to help setup IDE.
>> >
>> >
>> > -Sandeep
>> >
>>
>
>
> _
> The information contained in this communication is intended solely for the
> use of the individual or entity to whom it is addressed and others
> authorized to receive it. It may contain confidential or legally privileged
> information. If you are not the intended recipient you are hereby notified
> that any disclosure, copying, distribution or taking any action in reliance
> on the contents of this information is strictly prohibited and may be
> unlawful. If you have received this communication in error, please notify
> us immediately by responding to this email and then delete it from your
> system. The firm is neither liable for the proper and complete transmission
> of the information contained in this communication nor for any delay in its
> receipt.

[jira] [Commented] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977026#comment-14977026
 ] 

Hadoop QA commented on LENS-849:


Applied patch: 
[LENS-849-test.patch|https://issues.apache.org/jira/secure/attachment/12769046/LENS-849-test.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/159/

> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849-test.patch, LENS-849.2.patch, LENS-849.3.patch, 
> LENS-849.4.patch, LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: lens eclipse setup

[amareshwarisr .]

I'm not sure running server from eclipse will work. Right now, we use only
command-line. But you can try what Puneet is suggesting.

Puneet, it would be good to document above details on cwiki at
https://cwiki.apache.org/confluence/display/LENS/Apache+Lens+Home . Would
be useful for new contributors as well.

Thanks
Amareshwari

On Wed, Oct 28, 2015 at 8:01 AM, Puneet Gupta 
wrote:

> Hi Sandeep,
>
> Many of us use intellij idea. I am still on eclipse. I mostly run the
> server from outside eclipse and remote debug via eclipse if required (java
> remote debug parameters to be added to lesn-ctl script file where jvm is
> lauched during server start). Some idea user can comment on this as well
> from their perspective.
>
> I feel it should be possible to run the server via eclipse too ( have a
> look at the script file in bin directory : lens-ctl. Check the lens-server
> start part and echo the final call to JVM. Simulate the same via eclipse
> and add required jars to class-path. The main class is
> org.apache.lens.server.LensServer)
> Do share the details if you are able to run it successfully via eclipse.
>
> One more point (which i missed in my earlier mail), Install TestNG plugin
> for eclipse (http://testng.org/doc/download.html) to run the test cases
> from eclipse.
>
> Thanks,
> Puneet Gupta
>
> On Wed, Oct 28, 2015 at 1:38 AM, Sandeep  wrote:
>
>> Thanks puneet,
>> This was helpful.
>> Do you guys run lens server directly from eclipse or do you only use it
>> for changing the code?
>>
>> Thanks
>> sandeep
>>
>>
>> On Tue, Oct 27, 2015 at 10:24 AM, Puneet Gupta 
>> wrote:
>>
>>> Hi
>>>
>>> I have noted a few points that I followed while making eclipse setup for
>>> lens few months ago. Listing them below ( Your problem should be solved by
>>> point 5)
>>>
>>> 1. Use Eclipse Luna or below. Eclipse Mars does not support lombok
>>> library as plugin/agent which is used in lens.
>>> 2. Lombok needs to be used a javaagent while running eclipse for lombok
>>> based code to compile in eclipse. This can be done in two ways
>>>
>>>-  Manually edit eclipse.ini by adding below entry
>>>
>>>   "-javaagent:lombok.jar" Entry should be added to eclipse.ini
>>>
>>>
>>>-   OR run lombok jar as java app (java -jar lombo.jar) and
>>>point to eclipse.ini in the app GUI . This will update eclipse.ini
>>>(make sure eclipse is not running)
>>>
>>>[image: Inline image 1]
>>>
>>>
>>> 3.For easy project setup in eclipse, use lens as a Maven project inside
>>> eclipse(rather than a simple java project). For this M2Eclipse plugin
>>> is required in eclipse (It can be installed ineclipse via "Install new
>>> software" --> Add plugin .url 
>>> *http://download.eclipse.org/technology/m2e/releases
>>> *).
>>>
>>> 4. Once plugin is installed. Import lens directory as Existing Maven
>>> Project .
>>>
>>> [image: Inline image 1]
>>>
>>>
>>> 5. Ignore any errors (Approx 6 errors) of type "Plugin execution not
>>> covered by lifecycle configuration:
>>> org.apache.maven.plugins:maven-dependency-plugin". This can be done by
>>> selecting quick fix (option1 preferably as it will not update pom file) in
>>> eclipse.
>>> More on this in 
>>> *https://www.eclipse.org/m2e/documentation/m2e-execution-not-covered.html
>>> *
>>>
>>>
>>>
>>> Thanks,
>>> Puneet Gupta
>>>
>>> On Tue, Oct 27, 2015 at 10:42 PM, amareshwarisr . >> > wrote:
>>>
 We have seen issues with eclipse setup. Puneet would help with this.

 Thanks
 Amareshwari

 On Tue, Oct 27, 2015 at 10:37 AM, Sandeep  wrote:

 > hi,
 > I am trying to setup lens code on eclipse, by importing a maven
 project
 > from the root folder.
 > I am getting this error (attached).
 > do you know why? is there any documentation to help setup IDE.
 >
 >
 > -Sandeep
 >

>>>
>>>
>>> _
>>> The information contained in this communication is intended solely for
>>> the use of the individual or entity to whom it is addressed and others
>>> authorized to receive it. It may contain confidential or legally privileged
>>> information. If you are not the intended recipient you are hereby notified
>>> that any disclosure, copying, distribution or taking any action in reliance
>>> on the contents of this information is strictly prohibited and may be
>>> unlawful. If you have received this communication in error, please notify
>>> us immediately by responding to this email and then delete it from your
>>> system. The firm is neither liable for the proper and complete transmission
>>> of the information contained in this communication nor for any delay in its
>>> receipt.
>>
>>
>>
>
> 

[jira] [Commented] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977749#comment-14977749
 ] 

Hudson commented on LENS-849:
-

SUCCESS: Integrated in Lens-Commit-Java8 #30 (See 
[https://builds.apache.org/job/Lens-Commit-Java8/30/])
LENS-849 : Fix test failures because of merge with LENS-850 (amareshwari: rev 
e264e53f3a338961a34478b158c7980591280c0f)
* 
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java


> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849-test.patch, LENS-849.2.patch, LENS-849.3.patch, 
> LENS-849.4.patch, LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-849:
-
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849-test.patch, LENS-849.2.patch, LENS-849.3.patch, 
> LENS-849.4.patch, LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-848) Allow JDBC driver to take connection properties in configuration

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-848:
-
Component/s: driver-jdbc

> Allow JDBC driver to take connection properties in configuration
> 
>
> Key: LENS-848
> URL: https://issues.apache.org/jira/browse/LENS-848
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: driver-jdbc
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-848.09.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39680/#review104244
---



lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java (line 30)


would it be possible to add a comment with example input and output ?


- Puneet Gupta


On Oct. 27, 2015, 3:46 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39680/
> ---
> 
> (Updated Oct. 27, 2015, 3:46 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-848
> https://issues.apache.org/jira/browse/LENS-848
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Will plan to separate properties later. Keeping them for backward 
> compatibility.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
> PRE-CREATION 
>   lens-api/src/test/java/org/apache/lens/api/util/CommonUtilsTest.java 
> PRE-CREATION 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  825a039d1de808e85a9909b18865c1989c486743 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
>  b14835a3c40eabd9b0939e9be19e41852e5f99c4 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> 777f73a7bf9f30c0035b90689de9a83c908a1402 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
>  70815bbb8d89685fd2f3faf14230b8b458270ff1 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
> 163ed42daf49a182ead3eca048b3ada6e53e2c0b 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDataSourceConnectionProvider.java
>  21e5f50dcbcabe4d93b9cfac45191f8f4c129a1e 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
>  9041709554d67ca1b047e6db24be9cd52127ac5d 
>   lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml 
> 5594fbfac9d2da6c5a1116db41bfcbedbcf19130 
>   src/site/apt/admin/config.apt 76cbff07ad72f9a43de62f1166c1f0331b3038c0 
>   src/site/apt/admin/jdbcdriver-config.apt 
> 7b42309fb2a3c0d3478c6d0f472f782c69f76f85 
> 
> Diff: https://reviews.apache.org/r/39680/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.414s]
> [INFO] Lens .. SUCCESS [3.298s]
> [INFO] Lens API .. SUCCESS [27.005s]
> [INFO] Lens API for server and extensions  SUCCESS [25.469s]
> [INFO] Lens Cube . SUCCESS [5:46.494s]
> [INFO] Lens DB storage ... SUCCESS [22.510s]
> [INFO] Lens Query Library  SUCCESS [19.621s]
> [INFO] Lens Hive Driver .. SUCCESS [2:57.116s]
> [INFO] Lens Driver for JDBC .. SUCCESS [40.236s]
> [INFO] Lens Elastic Search Driver  SUCCESS [19.414s]
> [INFO] Lens Server ... SUCCESS [8:21.803s]
> [INFO] Lens client ... SUCCESS [36.730s]
> [INFO] Lens CLI .. SUCCESS [54.984s]
> [INFO] Lens Examples . SUCCESS [10.850s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.867s]
> [INFO] Lens Distribution . SUCCESS [9.404s]
> [INFO] Lens ML Lib ... SUCCESS [1:24.110s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.979s]
> [INFO] Lens Regression ... SUCCESS [13.230s]
> [INFO] Lens UI ... SUCCESS [27.486s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 23:47.270s
> [INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
> [INFO] Final Memory: 179M/1101M
> [INFO] 
> 
> jdbc driver test cases and checkstyle passed
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Commented] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977743#comment-14977743
 ] 

Hudson commented on LENS-849:
-

SUCCESS: Integrated in Lens-Commit #1120 (See 
[https://builds.apache.org/job/Lens-Commit/1120/])
LENS-849 : Fix test failures because of merge with LENS-850 (amareshwari: rev 
e264e53f3a338961a34478b158c7980591280c0f)
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java
* 
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java


> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849-test.patch, LENS-849.2.patch, LENS-849.3.patch, 
> LENS-849.4.patch, LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-849:
-
Attachment: LENS-849.2.patch

> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849.2.patch, LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39685: LENS-850 Queries with column name alias like "year" fails on some DBs

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39685/#review104164
---

Ship it!


Ship It!

- Rajat Khandelwal


On Oct. 27, 2015, 7 p.m., Puneet Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39685/
> ---
> 
> (Updated Oct. 27, 2015, 7 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-850
> https://issues.apache.org/jira/browse/LENS-850
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Changes for **LENS-850** 
> 
> -Back quoted column alias in all cases. This is required since some alias 
> values can match DB keywords(example : year as alias) and in such case 
> queries can fail on certain DBs if the alias in not back quoted
> 
> -Fixed Test cases where query was being checked for aliases
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 1964e32 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> e6c3be0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> f5ff49a 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
>  b2a15a0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 
> b0b2e88 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 
> 7580541 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
>  d4d812f 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java 
> d8c2f63 
> 
> Diff: https://reviews.apache.org/r/39685/diff/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules .. SUCCESS [  4.889 
> s]
> [INFO] Lens ... SUCCESS [  4.539 
> s]
> [INFO] Lens API ... SUCCESS [ 12.173 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 13.739 
> s]
> [INFO] Lens Cube .. SUCCESS [ 17.653 
> s]
> [INFO] Lens DB storage  SUCCESS [  1.731 
> s]
> [INFO] Lens Query Library . SUCCESS [  2.545 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [  3.868 
> s]
> [INFO] Lens Driver for JDBC ... SUCCESS [  5.935 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [  3.859 
> s]
> [INFO] Lens Server  SUCCESS [ 32.874 
> s]
> [INFO] Lens client  SUCCESS [  3.589 
> s]
> [INFO] Lens CLI ... SUCCESS [  6.192 
> s]
> [INFO] Lens Examples .. SUCCESS [  1.819 
> s]
> [INFO] Lens Ship Jars to Distributed Cache  SUCCESS [  2.703 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 12.766 
> s]
> [INFO] Lens ML Lib  SUCCESS [  5.735 
> s]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  5.241 
> s]
> [INFO] Lens Regression  SUCCESS [  5.171 
> s]
> [INFO] Lens UI  SUCCESS [ 10.216 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 02:38 min
> [INFO] Finished at: 2015-10-27T18:52:05+05:30
> [INFO] Final Memory: 188M/1572M
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>

[jira] [Updated] (LENS-847) Columnar JDBC Rewriter in incorrectly pushing filter against wrong alias when fact columns map to a single dimension

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-847:
--
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Columnar JDBC Rewriter in incorrectly pushing filter against wrong alias when 
> fact columns map to a single dimension
> 
>
> Key: LENS-847
> URL: https://issues.apache.org/jira/browse/LENS-847
> Project: Apache Lens
>  Issue Type: Bug
>  Components: driver-jdbc
>Affects Versions: 2.3, 2.4, 2.5
>Reporter: Srikanth Sundarrajan
>Assignee: Srikanth Sundarrajan
> Fix For: 2.4, 2.5
>
> Attachments: LEN-847-V1.patch, LEN-847.patch
>
>
> Columnar JDBC Rewriter in incorrectly pushing filter against wrong alias when 
> fact columns map to a single dimension.
> Ex:
> select fact.time_key, time_dim.day_of_week, location_dim_a.location_name, 
> other_location_dim.location_name, sum(fact.dollars_sold) from sales_fact fact 
> inner join time_dim time_dim on fact.time_key = time_dim.time_key inner join 
> location_dim location_dim_a on fact.location_key = 
> location_dim_a.location_key inner join location_dim other_location_dim on 
> fact.other_location_key = other_location_dim.location_key where 
> time_dim.time_key between '2013-01-01' and '2013-01-31' and 
> location_dim_a.location_key = 'some-loc' group by fact.time_key, 
> location_dim_a.location_key, other_location_dim.location_key
> is being rewritten to 
> select ( sales_fact___fact . time_key ), ( time_dim___time_dim . day_of_week 
> ), ( location_dim___location_dim_a . location_name ), ( 
> location_dim___other_location_dim . location_name ), sum(alias1) from  
> (select sales_fact___fact.time_key, sales_fact___fact.location_key, 
> sales_fact___fact.other_location_key,sum(( sales_fact___fact . dollars_sold 
> )) as alias1 from sales_fact sales_fact___fact where 
> sales_fact___fact.time_key in  (  select time_dim .time_key from time_dim 
> where ( time_dim. time_key ) between  '2013-01-01'  and  '2013-01-31'  ) and 
> sales_fact___fact.location_key in  (  select location_dim .location_key from 
> location_dim where (( location_dim. location_key ) =  'some-loc' ) ) and 
> {{sales_fact___fact.other_location_key in  (  select location_dim 
> .location_key from location_dim where (( location_dim. location_key ) =  
> 'some-loc' ) )}}  group by sales_fact___fact.time_key, 
> sales_fact___fact.location_key, sales_fact___fact.other_location_key) 
> sales_fact___fact  inner join (select time_key,day_of_week from time_dim) 
> time_dim___time_dim on (( sales_fact___fact . time_key ) = ( 
> time_dim___time_dim . time_key ))  inner join (select 
> location_key,location_name from location_dim) location_dim___location_dim_a 
> on (( sales_fact___fact . location_key ) = ( location_dim___location_dim_a . 
> location_key ))  inner join (select location_key,location_name from 
> location_dim) location_dim___other_location_dim on (( sales_fact___fact . 
> other_location_key ) = ( location_dim___other_location_dim . location_key ))  
> where (( time_dim___time_dim . time_key ) between  '2013-01-01'  and  
> '2013-01-31'  and (( location_dim___location_dim_a . location_key ) =  
> 'some-loc' )) group by ( sales_fact___fact . time_key ), ( 
> location_dim___location_dim_a . location_key ), ( 
> location_dim___other_location_dim . location_key )



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-847) Columnar JDBC Rewriter in incorrectly pushing filter against wrong alias when fact columns map to a single dimension

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-847:
--
Fix Version/s: 2.4

> Columnar JDBC Rewriter in incorrectly pushing filter against wrong alias when 
> fact columns map to a single dimension
> 
>
> Key: LENS-847
> URL: https://issues.apache.org/jira/browse/LENS-847
> Project: Apache Lens
>  Issue Type: Bug
>  Components: driver-jdbc
>Affects Versions: 2.3, 2.4, 2.5
>Reporter: Srikanth Sundarrajan
>Assignee: Srikanth Sundarrajan
> Fix For: 2.4, 2.5
>
> Attachments: LEN-847-V1.patch, LEN-847.patch
>
>
> Columnar JDBC Rewriter in incorrectly pushing filter against wrong alias when 
> fact columns map to a single dimension.
> Ex:
> select fact.time_key, time_dim.day_of_week, location_dim_a.location_name, 
> other_location_dim.location_name, sum(fact.dollars_sold) from sales_fact fact 
> inner join time_dim time_dim on fact.time_key = time_dim.time_key inner join 
> location_dim location_dim_a on fact.location_key = 
> location_dim_a.location_key inner join location_dim other_location_dim on 
> fact.other_location_key = other_location_dim.location_key where 
> time_dim.time_key between '2013-01-01' and '2013-01-31' and 
> location_dim_a.location_key = 'some-loc' group by fact.time_key, 
> location_dim_a.location_key, other_location_dim.location_key
> is being rewritten to 
> select ( sales_fact___fact . time_key ), ( time_dim___time_dim . day_of_week 
> ), ( location_dim___location_dim_a . location_name ), ( 
> location_dim___other_location_dim . location_name ), sum(alias1) from  
> (select sales_fact___fact.time_key, sales_fact___fact.location_key, 
> sales_fact___fact.other_location_key,sum(( sales_fact___fact . dollars_sold 
> )) as alias1 from sales_fact sales_fact___fact where 
> sales_fact___fact.time_key in  (  select time_dim .time_key from time_dim 
> where ( time_dim. time_key ) between  '2013-01-01'  and  '2013-01-31'  ) and 
> sales_fact___fact.location_key in  (  select location_dim .location_key from 
> location_dim where (( location_dim. location_key ) =  'some-loc' ) ) and 
> {{sales_fact___fact.other_location_key in  (  select location_dim 
> .location_key from location_dim where (( location_dim. location_key ) =  
> 'some-loc' ) )}}  group by sales_fact___fact.time_key, 
> sales_fact___fact.location_key, sales_fact___fact.other_location_key) 
> sales_fact___fact  inner join (select time_key,day_of_week from time_dim) 
> time_dim___time_dim on (( sales_fact___fact . time_key ) = ( 
> time_dim___time_dim . time_key ))  inner join (select 
> location_key,location_name from location_dim) location_dim___location_dim_a 
> on (( sales_fact___fact . location_key ) = ( location_dim___location_dim_a . 
> location_key ))  inner join (select location_key,location_name from 
> location_dim) location_dim___other_location_dim on (( sales_fact___fact . 
> other_location_key ) = ( location_dim___other_location_dim . location_key ))  
> where (( time_dim___time_dim . time_key ) between  '2013-01-01'  and  
> '2013-01-31'  and (( location_dim___location_dim_a . location_key ) =  
> 'some-loc' )) group by ( sales_fact___fact . time_key ), ( 
> location_dim___location_dim_a . location_key ), ( 
> location_dim___other_location_dim . location_key )



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39686: LENS-849 : Fix NPE in CandidateTableResolver with expression dimension

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39686/
---

(Updated Oct. 27, 2015, 2:04 p.m.)


Review request for lens.


Bugs: LENS-849
https://issues.apache.org/jira/browse/LENS-849


Repository: lens


Description
---

Added regression test with fix. Also fixed comparison in TestQuery for non-join 
queries.


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 
f81f3d5 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 705f19b 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 
b2a15a0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java 2707c4c 

Diff: https://reviews.apache.org/r/39686/diff/


Testing
---

All lens-cube tests succeeded


Thanks,

Amareshwari Sriramadasu

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39680/
---

(Updated Oct. 27, 2015, 7:07 p.m.)


Review request for lens.


Bugs: LENS-848
https://issues.apache.org/jira/browse/LENS-848


Repository: lens


Description
---

Will plan to separate properties later. Keeping them for backward compatibility.


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java PRE-CREATION 
  lens-api/src/test/java/org/apache/lens/api/util/CommonUtilsTest.java 
PRE-CREATION 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 ccb2b7fdf1fe297b7240ce1efcb1646303e1236d 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
 b14835a3c40eabd9b0939e9be19e41852e5f99c4 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
777f73a7bf9f30c0035b90689de9a83c908a1402 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
 70815bbb8d89685fd2f3faf14230b8b458270ff1 
  lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
163ed42daf49a182ead3eca048b3ada6e53e2c0b 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
9041709554d67ca1b047e6db24be9cd52127ac5d 
  lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml 
5594fbfac9d2da6c5a1116db41bfcbedbcf19130 
  src/site/apt/admin/config.apt 76cbff07ad72f9a43de62f1166c1f0331b3038c0 
  src/site/apt/admin/jdbcdriver-config.apt 
7b42309fb2a3c0d3478c6d0f472f782c69f76f85 

Diff: https://reviews.apache.org/r/39680/diff/


Testing
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [2.414s]
[INFO] Lens .. SUCCESS [3.298s]
[INFO] Lens API .. SUCCESS [27.005s]
[INFO] Lens API for server and extensions  SUCCESS [25.469s]
[INFO] Lens Cube . SUCCESS [5:46.494s]
[INFO] Lens DB storage ... SUCCESS [22.510s]
[INFO] Lens Query Library  SUCCESS [19.621s]
[INFO] Lens Hive Driver .. SUCCESS [2:57.116s]
[INFO] Lens Driver for JDBC .. SUCCESS [40.236s]
[INFO] Lens Elastic Search Driver  SUCCESS [19.414s]
[INFO] Lens Server ... SUCCESS [8:21.803s]
[INFO] Lens client ... SUCCESS [36.730s]
[INFO] Lens CLI .. SUCCESS [54.984s]
[INFO] Lens Examples . SUCCESS [10.850s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.867s]
[INFO] Lens Distribution . SUCCESS [9.404s]
[INFO] Lens ML Lib ... SUCCESS [1:24.110s]
[INFO] Lens ML Ext Distribution .. SUCCESS [1.979s]
[INFO] Lens Regression ... SUCCESS [13.230s]
[INFO] Lens UI ... SUCCESS [27.486s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 23:47.270s
[INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
[INFO] Final Memory: 179M/1101M
[INFO] 
jdbc driver test cases and checkstyle passed


Thanks,

Rajat Khandelwal

[jira] [Updated] (LENS-850) Queries with column name alias like "year" fails on some DBs

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-850:
--
Attachment: lens-850.patch

LENS-850 changes

> Queries with column name alias like "year" fails on some DBs
> 
>
> Key: LENS-850
> URL: https://issues.apache.org/jira/browse/LENS-850
> Project: Apache Lens
>  Issue Type: Improvement
>Affects Versions: 2.0, 2.1, 2.3
>Reporter: Puneet Gupta
> Fix For: 2.5
>
> Attachments: lens-850.patch
>
>
> "Select column_year year from Test_Table" 
> fails on some DBs.
> Reason: 
> This is because "year" is a keyword in some DBs and the query needs to be 
> rewritten with alias name quoted before it is executed.
> "Select coulm_year as `year` from Test_Table"
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39680/#review104166
---



lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
 (line 113)


Can we use the constant strings from config? Otherwise let us create 
constants.



lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
 (line 124)


Remove this


- Amareshwari Sriramadasu


On Oct. 27, 2015, 1:37 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39680/
> ---
> 
> (Updated Oct. 27, 2015, 1:37 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-848
> https://issues.apache.org/jira/browse/LENS-848
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Will plan to separate properties later. Keeping them for backward 
> compatibility.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java 
> PRE-CREATION 
>   lens-api/src/test/java/org/apache/lens/api/util/CommonUtilsTest.java 
> PRE-CREATION 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  ccb2b7fdf1fe297b7240ce1efcb1646303e1236d 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java
>  b14835a3c40eabd9b0939e9be19e41852e5f99c4 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> 777f73a7bf9f30c0035b90689de9a83c908a1402 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
>  70815bbb8d89685fd2f3faf14230b8b458270ff1 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 
> 163ed42daf49a182ead3eca048b3ada6e53e2c0b 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
>  9041709554d67ca1b047e6db24be9cd52127ac5d 
>   lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml 
> 5594fbfac9d2da6c5a1116db41bfcbedbcf19130 
>   src/site/apt/admin/config.apt 76cbff07ad72f9a43de62f1166c1f0331b3038c0 
>   src/site/apt/admin/jdbcdriver-config.apt 
> 7b42309fb2a3c0d3478c6d0f472f782c69f76f85 
> 
> Diff: https://reviews.apache.org/r/39680/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.414s]
> [INFO] Lens .. SUCCESS [3.298s]
> [INFO] Lens API .. SUCCESS [27.005s]
> [INFO] Lens API for server and extensions  SUCCESS [25.469s]
> [INFO] Lens Cube . SUCCESS [5:46.494s]
> [INFO] Lens DB storage ... SUCCESS [22.510s]
> [INFO] Lens Query Library  SUCCESS [19.621s]
> [INFO] Lens Hive Driver .. SUCCESS [2:57.116s]
> [INFO] Lens Driver for JDBC .. SUCCESS [40.236s]
> [INFO] Lens Elastic Search Driver  SUCCESS [19.414s]
> [INFO] Lens Server ... SUCCESS [8:21.803s]
> [INFO] Lens client ... SUCCESS [36.730s]
> [INFO] Lens CLI .. SUCCESS [54.984s]
> [INFO] Lens Examples . SUCCESS [10.850s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.867s]
> [INFO] Lens Distribution . SUCCESS [9.404s]
> [INFO] Lens ML Lib ... SUCCESS [1:24.110s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.979s]
> [INFO] Lens Regression ... SUCCESS [13.230s]
> [INFO] Lens UI ... SUCCESS [27.486s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 23:47.270s
> [INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015
> [INFO] Final Memory: 179M/1101M
> [INFO] 
> 
> jdbc driver test cases and checkstyle passed
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Updated] (LENS-849) NPE with CandidateTableResolver with expression dimensions

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-849:
-
Status: Open  (was: Patch Available)

> NPE with CandidateTableResolver with expression dimensions
> --
>
> Key: LENS-849
> URL: https://issues.apache.org/jira/browse/LENS-849
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.5
>
> Attachments: LENS-849.patch
>
>
> {noformat}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)