[jira] [Commented] (LENS-1371) Add a substring based retry policy for failures

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611897#comment-15611897
 ] 

Hadoop QA commented on LENS-1371:
-

Applied patch: 
[0001-Retry-patch.patch|https://issues.apache.org/jira/secure/attachment/12835575/0001-Retry-patch.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1141/

> Add a substring based retry policy for failures
> ---
>
> Key: LENS-1371
> URL: https://issues.apache.org/jira/browse/LENS-1371
> Project: Apache Lens
>  Issue Type: New Feature
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: 0001-Retry-patch.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1371) Add a substring based retry policy for failures

[Lavkesh Lahngir (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1371:
--
Attachment: 0001-Retry-patch.patch

> Add a substring based retry policy for failures
> ---
>
> Key: LENS-1371
> URL: https://issues.apache.org/jira/browse/LENS-1371
> Project: Apache Lens
>  Issue Type: New Feature
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: 0001-Retry-patch.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1371) Add a substring based retry policy for failures

[Lavkesh Lahngir (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1371:
--
Status: Patch Available  (was: Open)

> Add a substring based retry policy for failures
> ---
>
> Key: LENS-1371
> URL: https://issues.apache.org/jira/browse/LENS-1371
> Project: Apache Lens
>  Issue Type: New Feature
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: 0001-Retry-patch.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1352) Write JDBC driver Retry policy to recover queries lost after lens restart

[Lavkesh Lahngir (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1352:
--
Issue Type: Sub-task  (was: Task)
Parent: LENS-1371

> Write JDBC driver Retry policy to recover queries lost after lens restart
> -
>
> Key: LENS-1352
> URL: https://issues.apache.org/jira/browse/LENS-1352
> Project: Apache Lens
>  Issue Type: Sub-task
>Reporter: Rajat Khandelwal
>Assignee: Lavkesh Lahngir
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1353) Write HiveDriver retry policy to recover queries lost due to hive server restart

[Lavkesh Lahngir (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1353:
--
Issue Type: Sub-task  (was: Task)
Parent: LENS-1371

> Write HiveDriver retry policy to recover queries lost due to hive server 
> restart
> 
>
> Key: LENS-1353
> URL: https://issues.apache.org/jira/browse/LENS-1353
> Project: Apache Lens
>  Issue Type: Sub-task
>Reporter: Rajat Khandelwal
>Assignee: Lavkesh Lahngir
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-1371) Add a substring based retry policy for failures

[Lavkesh Lahngir (JIRA)]

Lavkesh Lahngir created LENS-1371:
-

 Summary: Add a substring based retry policy for failures
 Key: LENS-1371
 URL: https://issues.apache.org/jira/browse/LENS-1371
 Project: Apache Lens
  Issue Type: New Feature
Reporter: Lavkesh Lahngir
Assignee: Lavkesh Lahngir






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 53059: Druid sql rewriter changes

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53059/#review153996
---




lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java (lines 
89 - 103)


Date manipulations can be avoided. As mentioned in another comment

```
next():
return new FactPartition(getPartCol(), getTimePartition().next(), 
getContainingPart(), getStorageTables())

previous():
return new FactPartition(getPartCol(), getTimePartition().previous(), 
getContainingPart(), getStorageTables())
```



lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 
(lines 110 - 111)


The names might be confusing, leading the end user to believe these are the 
bound types for `time_range_in` function. We need to make it clear that these 
are only used for time range writer. Can we change names to something like 
`lens.cube.query.time.range.writer.start.bound.type` and 
`lens.cube.query.time.range.writer.end.bound.type` ?



lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java
 (lines 139 - 141)


I don't understand how this is working. First line is supposed to return 
something that depends on `startBoundType` and `endBoundType`, second line 
doesn't take those into account while validating. With 4 different values of 
(startBoundType,endBoundType), `whereClause` will be different. How is 
validateBetweenOpenClose passing for four differnet values of the first 
argument while keeping rest 3 arguments same?



lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java
 (line 152)


Does this function name need `OpenClose` in the name?



lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java
 (lines 161 - 170)


We should not change existing test. By default having and orderby are both 
supported by the jdbc driver. We need to have test cases for that.



lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java
 (line 254)


there is no dataprovider by name "getData"



lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java
 (line 255)


We need positive tests too, i.e. if `having` is not supported, but `order 
by` is, then `orderby` queries that don't have `having` should succeed.



lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
(line 681)


We need to test for the opposite scenario too, if skip warnings is set to 
false, is validate/prepare failing?


- Rajat Khandelwal


On Oct. 27, 2016, 3:42 p.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53059/
> ---
> 
> (Updated Oct. 27, 2016, 3:42 p.m.)
> 
> 
> Review request for lens and Rajat Khandelwal.
> 
> 
> Bugs: LENS-1350
> https://issues.apache.org/jira/browse/LENS-1350
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Fix for bug : Lens-1350
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 
> 355a1f0 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java
>  046149b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 
> f20f105 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java
>  07852a0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 
> 3417031 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DruidSQLRewriter.java
>  eb1d69c 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> 7ce1a97 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
>  f4e0451 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java
>  c4cc91d 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
>  6291021 
>   lens-driver-jdbc/src/test/resources/drivers/jdbc/druid/jdbcdriver-site.xml 
> e4fad23 
>   src/site/apt/user/cli.apt cf9657a 
> 
> Diff: https://reviews.apache.org/r/53059/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: Review Request 52982: Adding a message based retry policy

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52982/#review153995
---


Ship it!




Ship It!

- Rajat Khandelwal


On Oct. 26, 2016, 6:17 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52982/
> ---
> 
> (Updated Oct. 26, 2016, 6:17 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> If any one of the configured messages are found then the retry will happen
> 
> 
> Diffs
> -
> 
>   lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  3ae59c6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/retry/BackOffRetryHandler.java
>  5ea5710 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/retry/FibonacciExponentialBackOffRetryHandler.java
>  01da25d 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/retry/ImmediateRetryHandler.java
>  c1c0126 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/retry/SubstringMessagePolicyDecider.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/retry/TestSubStringMessagePolicyDecider.java
>  PRE-CREATION 
>   src/site/apt/admin/hivedriver-config.apt b1a25c3 
>   src/site/apt/admin/jdbcdriver-config.apt c64d6ee 
> 
> Diff: https://reviews.apache.org/r/52982/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 53059: Druid sql rewriter changes

[Rajitha R]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53059/
---

(Updated Oct. 27, 2016, 10:12 a.m.)


Review request for lens and Rajat Khandelwal.


Bugs: LENS-1350
https://issues.apache.org/jira/browse/LENS-1350


Repository: lens


Description
---

Fix for bug : Lens-1350


Diffs (updated)
-

  lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 
355a1f0 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java 
046149b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 
f20f105 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java
 07852a0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 
3417031 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DruidSQLRewriter.java
 eb1d69c 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
7ce1a97 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
 f4e0451 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java
 c4cc91d 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
6291021 
  lens-driver-jdbc/src/test/resources/drivers/jdbc/druid/jdbcdriver-site.xml 
e4fad23 
  src/site/apt/user/cli.apt cf9657a 

Diff: https://reviews.apache.org/r/53059/diff/


Testing
---


Thanks,

Rajitha R

[jira] [Commented] (LENS-968) Monitor run time for queries and terminate long running queries

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611351#comment-15611351
 ] 

Hadoop QA commented on LENS-968:


Applied patch: 
[LENS-968.patch|https://issues.apache.org/jira/secure/attachment/12835491/LENS-968.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1140/

> Monitor run time for queries and terminate long running queries
> ---
>
> Key: LENS-968
> URL: https://issues.apache.org/jira/browse/LENS-968
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.7
>
> Attachments: LENS-968.patch
>
>
> server should be able to kill queries that are taking more than x number of 
> hours in RUNNING state and intimate the user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 53217: LENS-968 : Timeout long running queries

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53217/
---

(Updated Oct. 27, 2016, 9:04 a.m.)


Review request for lens.


Bugs: LENS-968
https://issues.apache.org/jira/browse/LENS-968


Repository: lens


Description
---

Adds configurable timeout for queries, which is overridable at driver level and 
even at query level.
Adds a period checker which checks if any of queries timedout and canel them.


Diffs
-

  lens-driver-es/src/main/resources/esdriver-default.xml 5bd56b3 
  lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
3ae59c6 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 64c7145 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 
2a2963f 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 b5e996f 
  lens-server/src/main/resources/lensserver-default.xml 8e5fe8a 
  lens-server/src/main/resources/lenssession-default.xml 9a8f9da 
  
lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 
5a8d5e6 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
ecbd689 
  lens-server/src/test/resources/lens-site.xml d96659f 
  lens-server/src/test/resources/logback.xml 6b91a77 
  src/site/apt/admin/config.apt f22fc0c 
  src/site/apt/admin/esdriver-config.apt ce952ae 
  src/site/apt/admin/jdbcdriver-config.apt c64d6ee 
  src/site/apt/admin/session-config.apt d480f88 

Diff: https://reviews.apache.org/r/53217/diff/


Testing (updated)
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.484s]
[INFO] Lens .. SUCCESS [2.843s]
[INFO] Lens API .. SUCCESS [21.049s]
[INFO] Lens API for server and extensions  SUCCESS [19.230s]
[INFO] Lens Cube . SUCCESS [14:06.805s]
[INFO] Lens DB storage ... SUCCESS [16.439s]
[INFO] Lens Query Library  SUCCESS [12.739s]
[INFO] Lens Hive Driver .. SUCCESS [1:15.184s]
[INFO] Lens Driver for JDBC .. SUCCESS [39.351s]
[INFO] Lens Elastic Search Driver  SUCCESS [19.958s]
[INFO] Lens Server ... SUCCESS [16:28.932s]
[INFO] Lens client ... SUCCESS [1:21.876s]
[INFO] Lens CLI .. SUCCESS [1:12.501s]
[INFO] Lens Examples . SUCCESS [8.167s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.618s]
[INFO] Lens Distribution . SUCCESS [8.981s]
[INFO] Lens ML Lib ... SUCCESS [1:02.132s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.106s]
[INFO] Lens Regression ... SUCCESS [12.315s]
[INFO] Lens UI ... SUCCESS [30.001s]
[INFO] Lens Contrib .. SUCCESS [0.328s]
[INFO] Lens Contributed Clients .. SUCCESS [0.325s]
[INFO] Lens Python Client  SUCCESS [0.334s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 38:44.416s
[INFO] Finished at: Thu Oct 27 07:21:56 UTC 2016
[INFO] Final Memory: 272M/3119M
[INFO] 


Thanks,

Amareshwari Sriramadasu

[jira] [Commented] (LENS-1370) Queries persisted before retry framework upgrade are not getting purged

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611222#comment-15611222
 ] 

Hadoop QA commented on LENS-1370:
-

Applied patch: 
[LENS-1370.2016-10-27_13:00:23.patch|https://issues.apache.org/jira/secure/attachment/12835503/LENS-1370.2016-10-27_13%3A00%3A23.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1139/

> Queries persisted before retry framework upgrade are not getting purged
> ---
>
> Key: LENS-1370
> URL: https://issues.apache.org/jira/browse/LENS-1370
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1370.2016-10-27_13:00:23.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1370) Queries persisted before retry framework upgrade are not getting purged

[Amareshwari Sriramadasu (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611213#comment-15611213
 ] 

Amareshwari Sriramadasu commented on LENS-1370:
---

+1

> Queries persisted before retry framework upgrade are not getting purged
> ---
>
> Key: LENS-1370
> URL: https://issues.apache.org/jira/browse/LENS-1370
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1370.2016-10-27_13:00:23.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-968) Monitor run time for queries and terminate long running queries

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611197#comment-15611197
 ] 

Hadoop QA commented on LENS-968:


Applied patch: 
[LENS-968.patch|https://issues.apache.org/jira/secure/attachment/12835491/LENS-968.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1138/

> Monitor run time for queries and terminate long running queries
> ---
>
> Key: LENS-968
> URL: https://issues.apache.org/jira/browse/LENS-968
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.7
>
> Attachments: LENS-968.patch
>
>
> server should be able to kill queries that are taking more than x number of 
> hours in RUNNING state and intimate the user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1370) Queries persisted before retry framework upgrade are not getting purged

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1370:
---
Attachment: LENS-1370.2016-10-27_13:00:23.patch

> Queries persisted before retry framework upgrade are not getting purged
> ---
>
> Key: LENS-1370
> URL: https://issues.apache.org/jira/browse/LENS-1370
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1370.2016-10-27_13:00:23.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1370) Queries persisted before retry framework upgrade are not getting purged

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611028#comment-15611028
 ] 

Rajat Khandelwal commented on LENS-1370:


Small enough diff. Attaching directly

> Queries persisted before retry framework upgrade are not getting purged
> ---
>
> Key: LENS-1370
> URL: https://issues.apache.org/jira/browse/LENS-1370
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1370.2016-10-27_13:00:23.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-1370) Queries persisted before retry framework upgrade are not getting purged

[Rajat Khandelwal (JIRA)]

Rajat Khandelwal created LENS-1370:
--

 Summary: Queries persisted before retry framework upgrade are not 
getting purged
 Key: LENS-1370
 URL: https://issues.apache.org/jira/browse/LENS-1370
 Project: Apache Lens
  Issue Type: Bug
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-968) Monitor run time for queries and terminate long running queries

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611013#comment-15611013
 ] 

Hadoop QA commented on LENS-968:


Applied patch: 
[LENS-968.patch|https://issues.apache.org/jira/secure/attachment/12835491/LENS-968.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1137/

> Monitor run time for queries and terminate long running queries
> ---
>
> Key: LENS-968
> URL: https://issues.apache.org/jira/browse/LENS-968
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.7
>
> Attachments: LENS-968.patch
>
>
> server should be able to kill queries that are taking more than x number of 
> hours in RUNNING state and intimate the user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-968) Monitor run time for queries and terminate long running queries

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-968:
-
Attachment: LENS-968.patch

Patch with changes required. Review request at 
https://reviews.apache.org/r/53217/

> Monitor run time for queries and terminate long running queries
> ---
>
> Key: LENS-968
> URL: https://issues.apache.org/jira/browse/LENS-968
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.7
>
> Attachments: LENS-968.patch
>
>
> server should be able to kill queries that are taking more than x number of 
> hours in RUNNING state and intimate the user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-968) Monitor run time for queries and terminate long running queries

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-968:
-
Fix Version/s: 2.7
   Status: Patch Available  (was: Open)

> Monitor run time for queries and terminate long running queries
> ---
>
> Key: LENS-968
> URL: https://issues.apache.org/jira/browse/LENS-968
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.7
>
> Attachments: LENS-968.patch
>
>
> server should be able to kill queries that are taking more than x number of 
> hours in RUNNING state and intimate the user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 53217: LENS-968 : Timeout long running queries

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53217/
---

Review request for lens.


Bugs: LENS-968
https://issues.apache.org/jira/browse/LENS-968


Repository: lens


Description
---

Adds configurable timeout for queries, which is overridable at driver level and 
even at query level.
Adds a period checker which checks if any of queries timedout and canel them.


Diffs
-

  lens-driver-es/src/main/resources/esdriver-default.xml 5bd56b3 
  lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
3ae59c6 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 64c7145 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 
2a2963f 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 b5e996f 
  lens-server/src/main/resources/lensserver-default.xml 8e5fe8a 
  lens-server/src/main/resources/lenssession-default.xml 9a8f9da 
  
lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 
5a8d5e6 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
ecbd689 
  lens-server/src/test/resources/lens-site.xml d96659f 
  lens-server/src/test/resources/logback.xml 6b91a77 
  src/site/apt/admin/config.apt f22fc0c 
  src/site/apt/admin/esdriver-config.apt ce952ae 
  src/site/apt/admin/jdbcdriver-config.apt c64d6ee 
  src/site/apt/admin/session-config.apt d480f88 

Diff: https://reviews.apache.org/r/53217/diff/


Testing
---

Running org.apache.lens.server.query.TestQueryService
Tests run: 68, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 382.464 sec - 
in org.apache.lens.server.query.TestQueryService

Results :

Tests run: 68, Failures: 0, Errors: 0, Skipped: 0


Thanks,

Amareshwari Sriramadasu