----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53059/#review153996 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java (lines 89 - 103) <https://reviews.apache.org/r/53059/#comment223514> Date manipulations can be avoided. As mentioned in another comment ``` next(): return new FactPartition(getPartCol(), getTimePartition().next(), getContainingPart(), getStorageTables()) previous(): return new FactPartition(getPartCol(), getTimePartition().previous(), getContainingPart(), getStorageTables()) ``` lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java (lines 110 - 111) <https://reviews.apache.org/r/53059/#comment223515> The names might be confusing, leading the end user to believe these are the bound types for `time_range_in` function. We need to make it clear that these are only used for time range writer. Can we change names to something like `lens.cube.query.time.range.writer.start.bound.type` and `lens.cube.query.time.range.writer.end.bound.type` ? lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java (lines 139 - 141) <https://reviews.apache.org/r/53059/#comment223516> I don't understand how this is working. First line is supposed to return something that depends on `startBoundType` and `endBoundType`, second line doesn't take those into account while validating. With 4 different values of (startBoundType,endBoundType), `whereClause` will be different. How is validateBetweenOpenClose passing for four differnet values of the first argument while keeping rest 3 arguments same? lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java (line 152) <https://reviews.apache.org/r/53059/#comment223517> Does this function name need `OpenClose` in the name? lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java (lines 161 - 170) <https://reviews.apache.org/r/53059/#comment223518> We should not change existing test. By default having and orderby are both supported by the jdbc driver. We need to have test cases for that. lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java (line 254) <https://reviews.apache.org/r/53059/#comment223521> there is no dataprovider by name "getData" lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java (line 255) <https://reviews.apache.org/r/53059/#comment223523> We need positive tests too, i.e. if `having` is not supported, but `order by` is, then `orderby` queries that don't have `having` should succeed. lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java (line 681) <https://reviews.apache.org/r/53059/#comment223522> We need to test for the opposite scenario too, if skip warnings is set to false, is validate/prepare failing? - Rajat Khandelwal On Oct. 27, 2016, 3:42 p.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53059/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2016, 3:42 p.m.) > > > Review request for lens and Rajat Khandelwal. > > > Bugs: LENS-1350 > https://issues.apache.org/jira/browse/LENS-1350 > > > Repository: lens > > > Description > ------- > > Fix for bug : Lens-1350 > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java > 355a1f0 > > lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java > 046149b > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > f20f105 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java > 07852a0 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java > 3417031 > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DruidSQLRewriter.java > eb1d69c > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 7ce1a97 > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java > f4e0451 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java > c4cc91d > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > 6291021 > lens-driver-jdbc/src/test/resources/drivers/jdbc/druid/jdbcdriver-site.xml > e4fad23 > src/site/apt/user/cli.apt cf9657a > > Diff: https://reviews.apache.org/r/53059/diff/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
