[jira] [Commented] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries

2017-08-30 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147436#comment-16147436
 ] 

Hadoop QA commented on LENS-1468:
-

Applied patch: 
[LENS-1468.02.patch|https://issues.apache.org/jira/secure/attachment/12884487/LENS-1468.02.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1423/

> Expressions in having clauses are not getting rewritten properly for join 
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1468.01.patch, LENS-1468.02.patch
>
>
> The issue is not seen in test cases yet since somehow the order of child 
> candidates in {{JoinCandidate}} has been fixed. We have observed the order 
> being non-deterministic in production. And in one ordering, having clause 
> works fine and in another it doesn't. Will be adding test cases to reproduce 
> this issue and the fix as well. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 61938: Fix for time_range_in clause not resolving in rewrite

2017-08-30 Thread Rajitha R 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61938/
---

(Updated Aug. 30, 2017, 3:11 p.m.)


Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.


Repository: lens


Description
---

Fix for time_range_in clause not resolving in rewrite


Diffs (updated)
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
2b1add3 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java 
855f54a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 0366e56 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
bc0fa2e 
  lens-cube/src/test/resources/schema/cubes/base/testcube.xml 9d2bb02 
  lens-cube/src/test/resources/schema/facts/summary5.xml PRE-CREATION 
  lens-cube/src/test/resources/schema/storages/c98.xml PRE-CREATION 


Diff: https://reviews.apache.org/r/61938/diff/2/

Changes: https://reviews.apache.org/r/61938/diff/1-2/


Testing
---


Thanks,

Rajitha R

Re: Review Request 61938: Fix for time_range_in clause not resolving in rewrite

2017-08-30 Thread Rajitha R 


> On Aug. 29, 2017, 10:26 a.m., Puneet Gupta wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
> > Lines 937 (patched)
> > 
> >
> > We should make sure participatingUpdatePeriods does not have any update 
> > period that has zero partitions. Should line 536 " 
> > this.participatingUpdatePeriods.add(maxInterval);" be deleted ?

I tried do to this but test cases started failing.


- Rajitha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61938/#review184040
---


On Aug. 28, 2017, 11:38 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61938/
> ---
> 
> (Updated Aug. 28, 2017, 11:38 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Fix for time_range_in clause not resolving in rewrite
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> 2b1add3 
> 
> 
> Diff: https://reviews.apache.org/r/61938/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: Review Request 61938: Fix for time_range_in clause not resolving in rewrite

2017-08-30 Thread Rajitha R 


> On Aug. 29, 2017, 5:27 a.m., Amareshwari Sriramadasu wrote:
> > Can you add a testcase?

Done


> On Aug. 29, 2017, 5:27 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
> > Line 936 (original), 936 (patched)
> > 
> >
> > Line above is truncating partitions, isnt get Partitions here empty 
> > always?

No it isn't empty in case of look ahead partitions being available


- Rajitha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61938/#review184022
---


On Aug. 28, 2017, 11:38 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61938/
> ---
> 
> (Updated Aug. 28, 2017, 11:38 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Fix for time_range_in clause not resolving in rewrite
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> 2b1add3 
> 
> 
> Diff: https://reviews.apache.org/r/61938/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

[jira] [Commented] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries

2017-08-30 Thread Rajat Khandelwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147361#comment-16147361
 ] 

Rajat Khandelwal commented on LENS-1468:


Taking patch from reviewboard and attaching

> Expressions in having clauses are not getting rewritten properly for join 
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1468.01.patch, LENS-1468.02.patch
>
>
> The issue is not seen in test cases yet since somehow the order of child 
> candidates in {{JoinCandidate}} has been fixed. We have observed the order 
> being non-deterministic in production. And in one ordering, having clause 
> works fine and in another it doesn't. Will be adding test cases to reproduce 
> this issue and the fix as well. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries

2017-08-30 Thread Rajat Khandelwal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1468:
---
Attachment: LENS-1468.02.patch

> Expressions in having clauses are not getting rewritten properly for join 
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1468.01.patch, LENS-1468.02.patch
>
>
> The issue is not seen in test cases yet since somehow the order of child 
> candidates in {{JoinCandidate}} has been fixed. We have observed the order 
> being non-deterministic in production. And in one ordering, having clause 
> works fine and in another it doesn't. Will be adding test cases to reproduce 
> this issue and the fix as well. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 61992: LENS-1468: Expressions in having clauses are not getting rewritten properly for join queries

2017-08-30 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61992/
---

(Updated Aug. 30, 2017, 8:22 p.m.)


Review request for lens.


Bugs: LENS-1468
https://issues.apache.org/jira/browse/LENS-1468


Repository: lens


Description
---

The issue is not seen in test cases yet since somehow the order of child 
candidates in {{JoinCandidate}} has been fixed. We have observed the order 
being non-deterministic in production. And in one ordering, having clause works 
fine and in another it doesn't. Will be adding test cases to reproduce this 
issue and the fix as well.


Diffs (updated)
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
8906fae1915e71a38e18f42145825afcfe1a1d0b 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java
 993aa4cbf26d4771bbe714c95abc471534802780 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
9dc7ee67deb7495f99b53b01839722fb42446d03 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
cf29dff9058aa98bccff9d986fb3756438b50b83 
  lens-cube/src/test/resources/schema/cubes/base/basecube.xml 
6bb5eb9c0cefbec3bf85bf245a3d25b9b4c67b6e 
  lens-cube/src/test/resources/schema/cubes/derived/der2.xml 
337e7f450f96a3b1459556655680388ae2445f25 


Diff: https://reviews.apache.org/r/61992/diff/2/

Changes: https://reviews.apache.org/r/61992/diff/1-2/


Testing
---

This is the output of the newly added test case after reverting code fixes:

```
java.lang.AssertionError: having1: HAVING (((sum((basecube.alias1)) + 
sum((basecube.alias3)) + sum((basecube.alias4))) > 0) and 
((floor(sum((basecube.alias1))) + 0) > 10))
having2: HAVING (((sum((basecube.alias1)) + sum((basecube.alias1)) + 
sum((basecube.alias1))) > 0) and ((floor(sum((basecube.alias5))) + 0) > 10)) 
expected [HAVING (((sum((basecube.alias1)) + sum((basecube.alias1)) + 
sum((basecube.alias1))) > 0) and ((floor(sum((basecube.alias5))) + 0) > 10))] 
but found [HAVING (((sum((basecube.alias1)) + sum((basecube.alias3)) + 
sum((basecube.alias4))) > 0) and ((floor(sum((basecube.alias1))) + 0) > 10))]
Expected :HAVING (((sum((basecube.alias1)) + sum((basecube.alias1)) + 
sum((basecube.alias1))) > 0) and ((floor(sum((basecube.alias5))) + 0) > 10))
Actual   :HAVING (((sum((basecube.alias1)) + sum((basecube.alias3)) + 
sum((basecube.alias4))) > 0) and ((floor(sum((basecube.alias1))) + 0) > 10))

```


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries

2017-08-30 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147356#comment-16147356
 ] 

Hadoop QA commented on LENS-1468:
-

Applied patch: 
[LENS-1468.01.patch|https://issues.apache.org/jira/secure/attachment/12884485/LENS-1468.01.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1422/

> Expressions in having clauses are not getting rewritten properly for join 
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1468.01.patch
>
>
> The issue is not seen in test cases yet since somehow the order of child 
> candidates in {{JoinCandidate}} has been fixed. We have observed the order 
> being non-deterministic in production. And in one ordering, having clause 
> works fine and in another it doesn't. Will be adding test cases to reproduce 
> this issue and the fix as well. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 61992: LENS-1468: Expressions in having clauses are not getting rewritten properly for join queries

2017-08-30 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61992/
---

(Updated Aug. 30, 2017, 8:03 p.m.)


Review request for lens.


Bugs: LENS-1468
https://issues.apache.org/jira/browse/LENS-1468


Repository: lens


Description
---

The issue is not seen in test cases yet since somehow the order of child 
candidates in {{JoinCandidate}} has been fixed. We have observed the order 
being non-deterministic in production. And in one ordering, having clause works 
fine and in another it doesn't. Will be adding test cases to reproduce this 
issue and the fix as well.


Diffs
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
8906fae1915e71a38e18f42145825afcfe1a1d0b 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java
 993aa4cbf26d4771bbe714c95abc471534802780 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
9dc7ee67deb7495f99b53b01839722fb42446d03 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
cf29dff9058aa98bccff9d986fb3756438b50b83 
  lens-cube/src/test/resources/schema/cubes/base/basecube.xml 
6bb5eb9c0cefbec3bf85bf245a3d25b9b4c67b6e 
  lens-cube/src/test/resources/schema/cubes/derived/der2.xml 
337e7f450f96a3b1459556655680388ae2445f25 


Diff: https://reviews.apache.org/r/61992/diff/1/


Testing (updated)
---

This is the output of the newly added test case after reverting code fixes:

```
java.lang.AssertionError: having1: HAVING (((sum((basecube.alias1)) + 
sum((basecube.alias3)) + sum((basecube.alias4))) > 0) and 
((floor(sum((basecube.alias1))) + 0) > 10))
having2: HAVING (((sum((basecube.alias1)) + sum((basecube.alias1)) + 
sum((basecube.alias1))) > 0) and ((floor(sum((basecube.alias5))) + 0) > 10)) 
expected [HAVING (((sum((basecube.alias1)) + sum((basecube.alias1)) + 
sum((basecube.alias1))) > 0) and ((floor(sum((basecube.alias5))) + 0) > 10))] 
but found [HAVING (((sum((basecube.alias1)) + sum((basecube.alias3)) + 
sum((basecube.alias4))) > 0) and ((floor(sum((basecube.alias1))) + 0) > 10))]
Expected :HAVING (((sum((basecube.alias1)) + sum((basecube.alias1)) + 
sum((basecube.alias1))) > 0) and ((floor(sum((basecube.alias5))) + 0) > 10))
Actual   :HAVING (((sum((basecube.alias1)) + sum((basecube.alias3)) + 
sum((basecube.alias4))) > 0) and ((floor(sum((basecube.alias1))) + 0) > 10))

```


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries

2017-08-30 Thread Rajat Khandelwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147317#comment-16147317
 ] 

Rajat Khandelwal commented on LENS-1468:


Taking patch from reviewboard and attaching

> Expressions in having clauses are not getting rewritten properly for join 
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1468.01.patch
>
>
> The issue is not seen in test cases yet since somehow the order of child 
> candidates in {{JoinCandidate}} has been fixed. We have observed the order 
> being non-deterministic in production. And in one ordering, having clause 
> works fine and in another it doesn't. Will be adding test cases to reproduce 
> this issue and the fix as well. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries

2017-08-30 Thread Rajat Khandelwal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1468:
---
Attachment: LENS-1468.01.patch

> Expressions in having clauses are not getting rewritten properly for join 
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1468.01.patch
>
>
> The issue is not seen in test cases yet since somehow the order of child 
> candidates in {{JoinCandidate}} has been fixed. We have observed the order 
> being non-deterministic in production. And in one ordering, having clause 
> works fine and in another it doesn't. Will be adding test cases to reproduce 
> this issue and the fix as well. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries

2017-08-30 Thread Rajat Khandelwal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1468:
---
Status: Patch Available  (was: In Progress)

> Expressions in having clauses are not getting rewritten properly for join 
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1468.01.patch
>
>
> The issue is not seen in test cases yet since somehow the order of child 
> candidates in {{JoinCandidate}} has been fixed. We have observed the order 
> being non-deterministic in production. And in one ordering, having clause 
> works fine and in another it doesn't. Will be adding test cases to reproduce 
> this issue and the fix as well. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Work started] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries

2017-08-30 Thread Rajat Khandelwal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1468 started by Rajat Khandelwal.
--
> Expressions in having clauses are not getting rewritten properly for join 
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> The issue is not seen in test cases yet since somehow the order of child 
> candidates in {{JoinCandidate}} has been fixed. We have observed the order 
> being non-deterministic in production. And in one ordering, having clause 
> works fine and in another it doesn't. Will be adding test cases to reproduce 
> this issue and the fix as well. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries

2017-08-30 Thread Rajat Khandelwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147315#comment-16147315
 ] 

Rajat Khandelwal commented on LENS-1468:


Created https://reviews.apache.org/r/61992/

> Expressions in having clauses are not getting rewritten properly for join 
> queries
> -
>
> Key: LENS-1468
> URL: https://issues.apache.org/jira/browse/LENS-1468
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> The issue is not seen in test cases yet since somehow the order of child 
> candidates in {{JoinCandidate}} has been fixed. We have observed the order 
> being non-deterministic in production. And in one ordering, having clause 
> works fine and in another it doesn't. Will be adding test cases to reproduce 
> this issue and the fix as well. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (LENS-1468) Expressions in having clauses are not getting rewritten properly for join queries

2017-08-30 Thread Rajat Khandelwal (JIRA) 
Rajat Khandelwal created LENS-1468:
--

 Summary: Expressions in having clauses are not getting rewritten 
properly for join queries
 Key: LENS-1468
 URL: https://issues.apache.org/jira/browse/LENS-1468
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal


The issue is not seen in test cases yet since somehow the order of child 
candidates in {{JoinCandidate}} has been fixed. We have observed the order 
being non-deterministic in production. And in one ordering, having clause works 
fine and in another it doesn't. Will be adding test cases to reproduce this 
issue and the fix as well. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

2017-08-30 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147095#comment-16147095
 ] 

Hudson commented on LENS-1467:
--

UNSTABLE: Integrated in Jenkins build Lens-Commit #1435 (See 
[https://builds.apache.org/job/Lens-Commit/1435/])
LENS-1467: CubeQueryContext.getAllFilters is returning incorrect list of 
(rajatgupta59: rev ef6e59c61d9b281332911a5d282723d29cd700c3)
* (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java
* (edit) 
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java
* (add) 
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeQueryContextTest.java
* (edit) 
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java


> CubeQueryContext.getAllFilters is returning incorrect list of filters in case 
> there is an "OR" in the filters
> -
>
> Key: LENS-1467
> URL: https://issues.apache.org/jira/browse/LENS-1467
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1467.01.patch, LENS-1467.02.patch, 
> LENS-1467.03.patch
>
>
> "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed 
> together, which is wrong. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1465) Sync queries blocking threads

2017-08-30 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147094#comment-16147094
 ] 

Hudson commented on LENS-1465:
--

UNSTABLE: Integrated in Jenkins build Lens-Commit #1435 (See 
[https://builds.apache.org/job/Lens-Commit/1435/])
LENS-1465: Sync queries blocking threads (rajatgupta59: rev 
f4fdab01395357159b2c641c8e6aa88223551838)
* (edit) 
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java


> Sync queries blocking threads
> -
>
> Key: LENS-1465
> URL: https://issues.apache.org/jira/browse/LENS-1465
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1465.01.patch
>
>
> Sync queries taking more time than timeout are blocking threads due to a 
> deadlock. Each sync query is blocking one thread from jdbc execution pool and 
> one thread from query completion pool. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

2017-08-30 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147093#comment-16147093
 ] 

Hudson commented on LENS-1464:
--

UNSTABLE: Integrated in Jenkins build Lens-Commit #1435 (See 
[https://builds.apache.org/job/Lens-Commit/1435/])
LENS-1464: One or two queued queries failing with (rajatgupta59: rev 
806703ef2d8180a3baee21a6f27a3b7bdc1f2f79)
* (edit) lens-server/pom.xml
* (edit) 
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java


> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1464.01.patch, LENS-1464.02.patch, 
> LENS-1464.03.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

2017-08-30 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147067#comment-16147067
 ] 

Hadoop QA commented on LENS-1467:
-

Applied patch: 
[LENS-1467.03.patch|https://issues.apache.org/jira/secure/attachment/12884447/LENS-1467.03.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1417/

> CubeQueryContext.getAllFilters is returning incorrect list of filters in case 
> there is an "OR" in the filters
> -
>
> Key: LENS-1467
> URL: https://issues.apache.org/jira/browse/LENS-1467
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1467.01.patch, LENS-1467.02.patch, 
> LENS-1467.03.patch
>
>
> "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed 
> together, which is wrong. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

2017-08-30 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147055#comment-16147055
 ] 

Hadoop QA commented on LENS-1464:
-

Applied patch: 
[LENS-1464.03.patch|https://issues.apache.org/jira/secure/attachment/12884439/LENS-1464.03.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1418/

> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1464.01.patch, LENS-1464.02.patch, 
> LENS-1464.03.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

2017-08-30 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147050#comment-16147050
 ] 

Hadoop QA commented on LENS-1464:
-

Applied patch: 
[LENS-1464.03.patch|https://issues.apache.org/jira/secure/attachment/12884439/LENS-1464.03.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1421/

> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1464.01.patch, LENS-1464.02.patch, 
> LENS-1464.03.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

2017-08-30 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147049#comment-16147049
 ] 

Hadoop QA commented on LENS-1467:
-

Applied patch: 
[LENS-1467.03.patch|https://issues.apache.org/jira/secure/attachment/12884447/LENS-1467.03.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1416/

> CubeQueryContext.getAllFilters is returning incorrect list of filters in case 
> there is an "OR" in the filters
> -
>
> Key: LENS-1467
> URL: https://issues.apache.org/jira/browse/LENS-1467
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1467.01.patch, LENS-1467.02.patch, 
> LENS-1467.03.patch
>
>
> "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed 
> together, which is wrong. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

2017-08-30 Thread Rajat Khandelwal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1467:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> CubeQueryContext.getAllFilters is returning incorrect list of filters in case 
> there is an "OR" in the filters
> -
>
> Key: LENS-1467
> URL: https://issues.apache.org/jira/browse/LENS-1467
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1467.01.patch, LENS-1467.02.patch, 
> LENS-1467.03.patch
>
>
> "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed 
> together, which is wrong. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

2017-08-30 Thread Rajat Khandelwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147048#comment-16147048
 ] 

Rajat Khandelwal commented on LENS-1467:


Committed myself.

> CubeQueryContext.getAllFilters is returning incorrect list of filters in case 
> there is an "OR" in the filters
> -
>
> Key: LENS-1467
> URL: https://issues.apache.org/jira/browse/LENS-1467
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1467.01.patch, LENS-1467.02.patch, 
> LENS-1467.03.patch
>
>
> "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed 
> together, which is wrong. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

2017-08-30 Thread Rajat Khandelwal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1467:
---
Fix Version/s: 2.7

> CubeQueryContext.getAllFilters is returning incorrect list of filters in case 
> there is an "OR" in the filters
> -
>
> Key: LENS-1467
> URL: https://issues.apache.org/jira/browse/LENS-1467
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1467.01.patch, LENS-1467.02.patch, 
> LENS-1467.03.patch
>
>
> "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed 
> together, which is wrong. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

2017-08-30 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147047#comment-16147047
 ] 

Hadoop QA commented on LENS-1467:
-

Applied patch: 
[LENS-1467.03.patch|https://issues.apache.org/jira/secure/attachment/12884447/LENS-1467.03.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1419/

> CubeQueryContext.getAllFilters is returning incorrect list of filters in case 
> there is an "OR" in the filters
> -
>
> Key: LENS-1467
> URL: https://issues.apache.org/jira/browse/LENS-1467
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1467.01.patch, LENS-1467.02.patch, 
> LENS-1467.03.patch
>
>
> "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed 
> together, which is wrong. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1465) Sync queries blocking threads

2017-08-30 Thread Rajat Khandelwal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1465:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Sync queries blocking threads
> -
>
> Key: LENS-1465
> URL: https://issues.apache.org/jira/browse/LENS-1465
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1465.01.patch
>
>
> Sync queries taking more time than timeout are blocking threads due to a 
> deadlock. Each sync query is blocking one thread from jdbc execution pool and 
> one thread from query completion pool. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1465) Sync queries blocking threads

2017-08-30 Thread Rajat Khandelwal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1465:
---
Fix Version/s: 2.7

> Sync queries blocking threads
> -
>
> Key: LENS-1465
> URL: https://issues.apache.org/jira/browse/LENS-1465
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1465.01.patch
>
>
> Sync queries taking more time than timeout are blocking threads due to a 
> deadlock. Each sync query is blocking one thread from jdbc execution pool and 
> one thread from query completion pool. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1465) Sync queries blocking threads

2017-08-30 Thread Rajat Khandelwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147046#comment-16147046
 ] 

Rajat Khandelwal commented on LENS-1465:


Committed myself.

> Sync queries blocking threads
> -
>
> Key: LENS-1465
> URL: https://issues.apache.org/jira/browse/LENS-1465
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1465.01.patch
>
>
> Sync queries taking more time than timeout are blocking threads due to a 
> deadlock. Each sync query is blocking one thread from jdbc execution pool and 
> one thread from query completion pool. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

2017-08-30 Thread Rajat Khandelwal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1464:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1464.01.patch, LENS-1464.02.patch, 
> LENS-1464.03.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

2017-08-30 Thread Rajat Khandelwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147043#comment-16147043
 ] 

Rajat Khandelwal commented on LENS-1464:


Committed myself.

> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1464.01.patch, LENS-1464.02.patch, 
> LENS-1464.03.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

2017-08-30 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147027#comment-16147027
 ] 

Hadoop QA commented on LENS-1464:
-

Applied patch: 
[LENS-1464.03.patch|https://issues.apache.org/jira/secure/attachment/12884439/LENS-1464.03.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1415/

> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1464.01.patch, LENS-1464.02.patch, 
> LENS-1464.03.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

2017-08-30 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147021#comment-16147021
 ] 

Hadoop QA commented on LENS-1467:
-

Applied patch: 
[LENS-1467.03.patch|https://issues.apache.org/jira/secure/attachment/12884447/LENS-1467.03.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1414/

> CubeQueryContext.getAllFilters is returning incorrect list of filters in case 
> there is an "OR" in the filters
> -
>
> Key: LENS-1467
> URL: https://issues.apache.org/jira/browse/LENS-1467
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1467.01.patch, LENS-1467.02.patch, 
> LENS-1467.03.patch
>
>
> "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed 
> together, which is wrong. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

2017-08-30 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146992#comment-16146992
 ] 

Hadoop QA commented on LENS-1464:
-

Applied patch: 
[LENS-1464.03.patch|https://issues.apache.org/jira/secure/attachment/12884439/LENS-1464.03.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1413/

> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1464.01.patch, LENS-1464.02.patch, 
> LENS-1464.03.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

2017-08-30 Thread Rajat Khandelwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146971#comment-16146971
 ] 

Rajat Khandelwal commented on LENS-1467:


Taking patch from reviewboard and attaching

> CubeQueryContext.getAllFilters is returning incorrect list of filters in case 
> there is an "OR" in the filters
> -
>
> Key: LENS-1467
> URL: https://issues.apache.org/jira/browse/LENS-1467
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1467.01.patch, LENS-1467.02.patch, 
> LENS-1467.03.patch
>
>
> "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed 
> together, which is wrong. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

2017-08-30 Thread Rajat Khandelwal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1467:
---
Attachment: LENS-1467.03.patch

> CubeQueryContext.getAllFilters is returning incorrect list of filters in case 
> there is an "OR" in the filters
> -
>
> Key: LENS-1467
> URL: https://issues.apache.org/jira/browse/LENS-1467
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1467.01.patch, LENS-1467.02.patch, 
> LENS-1467.03.patch
>
>
> "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed 
> together, which is wrong. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 61942: LENS-1467: CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

2017-08-30 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61942/
---

(Updated Aug. 30, 2017, 3:11 p.m.)


Review request for lens.


Bugs: LENS-1467
https://issues.apache.org/jira/browse/LENS-1467


Repository: lens


Description
---

"a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed together, 
which is wrong.


Diffs (updated)
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
8b9583aa62ce3fc0ed94b2b849f12ee48fa16a9b 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java
 494b08e3b04bcdfea3de449f3740589cc481ba38 
  lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java 
866149641fbc2d00263fbe9679b1e89f5325e601 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeQueryContextTest.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/61942/diff/3/

Changes: https://reviews.apache.org/r/61942/diff/2-3/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Updated] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

2017-08-30 Thread Rajat Khandelwal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1464:
---
Attachment: LENS-1464.03.patch

> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1464.01.patch, LENS-1464.02.patch, 
> LENS-1464.03.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

2017-08-30 Thread Rajat Khandelwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146945#comment-16146945
 ] 

Rajat Khandelwal commented on LENS-1464:


Taking patch from reviewboard and attaching

> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1464.01.patch, LENS-1464.02.patch, 
> LENS-1464.03.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 61934: LENS-1464: One or two queued queries failing with ConcurrentModificationException on restart

2017-08-30 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61934/
---

(Updated Aug. 30, 2017, 2:53 p.m.)


Review request for lens.


Bugs: LENS-1464
https://issues.apache.org/jira/browse/LENS-1464


Repository: lens


Description
---

Happens because of synchronizations issues. If two queries are simultaneously 
launching, both try to add resources to hive driver. One of those queries can 
fail then.


Diffs (updated)
-

  lens-server/pom.xml 34a781953918816f68ae51778bacb01996e2483e 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 e70d2905a435f696f62239b1dc30eaa476dc229c 


Diff: https://reviews.apache.org/r/61934/diff/3/

Changes: https://reviews.apache.org/r/61934/diff/2-3/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Closed] (LENS-1279) Improve Scheduler API messages

2017-08-30 Thread Divakar Tomar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divakar Tomar closed LENS-1279.
---

verified

> Improve Scheduler API messages  
> 
>
> Key: LENS-1279
> URL: https://issues.apache.org/jira/browse/LENS-1279
> Project: Apache Lens
>  Issue Type: Improvement
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: Scheduler-API-fixes.patch
>
>
> This patch includes more clearer scheduler APIs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (LENS-1286) Handle Lens server restart

2017-08-30 Thread Divakar Tomar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Divakar Tomar closed LENS-1286.
---

verified

> Handle Lens server restart
> --
>
> Key: LENS-1286
> URL: https://issues.apache.org/jira/browse/LENS-1286
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: restart.patch
>
>
> Scheduled events which are generated by AlarmService for scheduling are 
> processed by a SchedulerEventListener thread.
> These steps are performed after receiving a scheduled event:
> 1. Get the job stored in the SchedulerDAO
> 2. Create a session with job owner and fill the session conf.
> 3. Create the instance if it is not a rerun otherwise get the instance from 
> the store. 
> 4. Create a Run instance. 
> 5. Store instance (if not present) and run to the store.
> 6. Launch the query.
> 7. Update the run with the latest information.
> 8. If there is a failure in query launch then update the run status to be 
> failed.
> While EventListener is processing the event, it can be closed during the 
> shutdown of scheduler service. Closing the thread can cause operations to be 
> incomplete.
> There are these stages where the thread can be interrupted:
> 1. Shutdown just after the alarm Event is fired and received:
> In this case, we won't have any entry for the instance run in the store. This 
> will cause a hole in the list of instances.
> 2. Shutdown before query launch. 
> In this case, at least we will have an entry in the table and status as NEW.
> 3. Shutdown after query launch. 
> In this case, the status won't be updated, and even if the query is launched 
> we will have no information about the handle. When this happens the 
> scheduled status will remain NEW
> Of all the scenarios above, the first one is kind of annoying because there 
> is no way to generate the event from Alarm Service again if it is already 
> triggered. 
> Second and third scenarios can be handled manually by killing the instance 
> and re-running it.
> Apart from the scheduler event listener thread, we have another thread which 
> processes the query end event which works as follows:
> 1. Receive the event and check if this is a scheduled query.
> 2. Check the final status of the query and set it as the instance status.
> If a shutdown happens after receiving the query end event, it will cause the 
> status to remain as RUNNING.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)