from:"Amruth Sampath"

Re: Review Request 39897: LENS-860 : Updating committer documentation

2015-11-05 Thread Amruth Sampath

HI all, Is this good to go?

On Wed, Nov 4, 2015 at 1:52 PM, Amruth Sampath <amruthkesa...@gmail.com>
wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39897/
> ---
>
> (Updated Nov. 4, 2015, 8:22 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Changes
> ---
>
> Corrected PPMC to PMC at all places in pom.xml
>
>
> Repository: lens
>
>
> Description
> ---
>
> Have updated the documentation
>
>
> Diffs (updated)
> -
>
>   pom.xml 5e8f046
>   src/site/apt/developer/commit.apt f908925
>
> Diff: https://reviews.apache.org/r/39897/diff/
>
>
> Testing
> ---
>
> No code changes to test.
>
>
> Thanks,
>
> Amruth Sampath
>
>


-- 
Amruth S
(09486075517)

Re: Review Request 39897: LENS-860 : Updating committer documentation

2015-11-04 Thread Amruth Sampath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39897/
---

(Updated Nov. 4, 2015, 8:22 a.m.)


Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.


Changes
---

Corrected PPMC to PMC at all places in pom.xml


Repository: lens


Description
---

Have updated the documentation


Diffs (updated)
-

  pom.xml 5e8f046 
  src/site/apt/developer/commit.apt f908925 

Diff: https://reviews.apache.org/r/39897/diff/


Testing
---

No code changes to test.


Thanks,

Amruth Sampath

Review Request 39897: LENS-860 : Updating committer documentation

2015-11-03 Thread Amruth Sampath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39897/
---

Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.


Repository: lens


Description
---

Have updated the documentation


Diffs
-

  src/site/apt/developer/commit.apt f908925 

Diff: https://reviews.apache.org/r/39897/diff/


Testing
---

No code changes to test.


Thanks,

Amruth Sampath

Re: Question regarding commits

2015-11-03 Thread Amruth Sampath

Sure. What about the commit message template for new developer.

Should I just say "Changes to pom.xml New developer - 1st commit" ?

On Tue, Nov 3, 2015 at 5:05 PM, amareshwarisr . <amareshw...@gmail.com>
wrote:

> Hello Amruth,
>
> Yes, example and pom.xml needs fixing.
> It should also say PMC instead of PPMC, as we are not incubating any more.
>
> And we should update documentation to mention, if you are invited as
> committer - role is committer. If you are invited as PMC, role would say
> both PMC and Committer.
>
> Can you do above changes and also add youself as committer?
>
> Thanks
> Amareshwari
>
> On Tue, Nov 3, 2015 at 4:39 PM, Amruth Sampath <amrut...@flipkart.com>
> wrote:
>
> > Hi i am following these steps for committing
> > https://lens.apache.org/developer/commit.html
> > <
> >
> https://www.google.com/url?q=https%3A%2F%2Flens.apache.org%2Fdeveloper%2Fcommit.html=D=1=AFQjCNEvYBFxMM70I1W963kzKQuk2pwXIQ
> > >
> > It says i ll have to add developer tag... but the example seem to have
> > something called 'PPMC' role. Should I remove that?
> >
> > Also should I make this as a separate commit? If yes, what is the message
> > template?
> >
> > Thanks,
> > --
> > Amruth S
> > (09486075517)
> >
>



-- 
Amruth S
(09486075517)

Question regarding commits

2015-11-03 Thread Amruth Sampath

Hi i am following these steps for committing
https://lens.apache.org/developer/commit.html

It says i ll have to add developer tag... but the example seem to have
something called 'PPMC' role. Should I remove that?

Also should I make this as a separate commit? If yes, what is the message
template?

Thanks,
-- 
Amruth S
(09486075517)

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-11 Thread Amruth Sampath



> On Sept. 11, 2015, 7:03 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java,
> >  lines 73-74
> > <https://reviews.apache.org/r/37934/diff/6-7/?file=1066468#file1066468line73>
> >
> > Can't these be made static so that they can be used in `@DefaultValue`?

Only static final inline declarations can be used in @DefaultValue. I can 
initialize this only in the constructor. Nevertheless I have made defaultStart 
as static final and have used it with @DefaultValue


- Amruth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98567
---


On Sept. 10, 2015, 6:50 p.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> ---
> 
> (Updated Sept. 10, 2015, 6:50 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
> Khandelwal, and sharad agarwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
> 754e6e1 
>   lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java
>  PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java 
> PRE-CREATION 
>   lens-api/src/main/resources/lens-errors.conf 5428041 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  fb11f93 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
>  PRE-CREATION 
>   lens-server/enunciate.xml 94b5199 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/java/org/apache/le

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-11 Thread Amruth Sampath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/
---

(Updated Sept. 11, 2015, 10:10 a.m.)


Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
Khandelwal, and sharad agarwal.


Changes
---

Adding syntax error back to lens-errors.conf


Repository: lens


Description
---

Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
(Note : Sharing and CLI are not a part of this patch)


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
754e6e1 
  lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java 
PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java 
PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
 PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java 
PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java
 PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java
 PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java 
PRE-CREATION 
  lens-api/src/main/resources/lens-errors.conf 5428041 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
fb11f93 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
 PRE-CREATION 
  lens-server/enunciate.xml 94b5199 
  
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java
 PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
5d77eb7 
  lens-server/src/main/resources/lensserver-default.xml 5d33eda 
  
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java
 PRE-CREATION 
  lens-server/src/test/resources/lens-site.xml 4cf94d5 
  src/site/apt/admin/config.apt b163a3a 
  src/site/apt/user/index.apt 6a86b1b 

Diff: https://reviews.apache.org/r/37934/diff/


Testing
---

Have added unit test cases for parsing, resolution of parameter and service 
testing.


Thanks,

Amruth Sampath

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-10 Thread Amruth Sampath

12-113
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066451#file1066451line112>
> >
> > Validations should be on constructor level.

Again this is possible if I can have user facing entities for every model 
entity I have and let JAXB do the marsh/unmarsh for user facing entities. I can 
convert user facing entity to model entity internally. Should I proceed doing 
these changes?


- Amruth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98361
---


On Sept. 9, 2015, 7:23 p.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> ---
> 
> (Updated Sept. 9, 2015, 7:23 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
> Khandelwal, and sharad agarwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
> 754e6e1 
>   lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java
>  PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java 
> PRE-CREATION 
>   lens-api/src/main/resources/lens-errors.conf 5428041 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  fb11f93 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
>  PRE-CREATION 
>   lens-server/enunciate.xml 94b5199 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
> 5d77eb7 
>   lens-server/src/main/resources/lensserver-default.xml 5d33eda 
>   
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java
>  PRE-CREATION 
>   lens-server/src/test/resources/lens-site.xml 4cf94d5 
>   src/site/apt/admin/config.apt b163a3a 
>   src/site/apt/user/index.apt 6a86b1b 
> 
> Diff: https://reviews.apache.org/r/37934/diff/
> 
> 
> Testing
> ---
> 
> Have added unit test cases for parsing, resolution of parameter and service 
> testing.
> 
> 
> Thanks,
> 
> Amruth Sampath
> 
>

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-10 Thread Amruth Sampath



> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java,
> >  line 42
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066454#file1066454line42>
> >
> > can we pass error info object to super instead of just a message?

As I see LensErrorInfo object has code, weight and name. 
ParameterCollectionException and ValueEncodeException are too low level 
exceptions (like SQLException) where error code might not make sense. I am 
catching them and throwing a ParameverValueException and then calling super 
with lens error info object (with mapped error code)


- Amruth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98361
---


On Sept. 9, 2015, 7:23 p.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> ---
> 
> (Updated Sept. 9, 2015, 7:23 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
> Khandelwal, and sharad agarwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
> 754e6e1 
>   lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java
>  PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java 
> PRE-CREATION 
>   lens-api/src/main/resources/lens-errors.conf 5428041 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  fb11f93 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
>  PRE-CREATION 
>   lens-server/enunciate.xml 94b5199 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
>  PRE-CREATION 
>   
> lens-serve

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-10 Thread Amruth Sampath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/
---

(Updated Sept. 10, 2015, 6:50 p.m.)


Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
Khandelwal, and sharad agarwal.


Changes
---

- Configurable page size and offset
- Validations handled better (through JAXB callback)
- Error code refactoring (same names as in the standard)


Repository: lens


Description
---

Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
(Note : Sharing and CLI are not a part of this patch)


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
754e6e1 
  lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java 
PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java 
PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
 PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java 
PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java
 PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java
 PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java 
PRE-CREATION 
  lens-api/src/main/resources/lens-errors.conf 5428041 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
fb11f93 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
 PRE-CREATION 
  lens-server/enunciate.xml 94b5199 
  
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java
 PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
5d77eb7 
  lens-server/src/main/resources/lensserver-default.xml 5d33eda 
  
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java
 PRE-CREATION 
  lens-server/src/test/resources/lens-site.xml 4cf94d5 
  src/site/apt/admin/config.apt b163a3a 
  src/site/apt/user/index.apt 6a86b1b 

Diff: https://reviews.apache.org/r/37934/diff/


Testing
---

Have added unit test cases for parsing, resolution of parameter and service 
testing.


Thanks,

Amruth Sampath

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-10 Thread Amruth Sampath



> On Sept. 10, 2015, 11:02 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java,
> >  line 74
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066468#file1066468line74>
> >
> > Make default pagination configurable.
> 
> Amruth Sampath wrote:
> I was using @DefaultValue annotation to inject default values in service 
> calls
> 
> @DefaultValue(defaultStart) @QueryParam("start") int start,
> 
> If I make this configurable, I need to remove this annotation and do the 
> check inside the function (@DefaultValue takes only final static inline 
> declared values)

have made this configurable


- Amruth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98369
-------


On Sept. 9, 2015, 7:23 p.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> ---
> 
> (Updated Sept. 9, 2015, 7:23 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
> Khandelwal, and sharad agarwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
> 754e6e1 
>   lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java
>  PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java 
> PRE-CREATION 
>   lens-api/src/main/resources/lens-errors.conf 5428041 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  fb11f93 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
>  PRE-CREATION 
>   lens-server/enunciate.xml 94b5199 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/quer

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-10 Thread Amruth Sampath



> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java,
> >  line 118
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066451#file1066451line118>
> >
> > Can we reuse `LensJAXBValidationException` here?

Validation happens immediately post un marshalling. removed this code.


> On Sept. 10, 2015, 7:49 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java,
> >  lines 112-113
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066451#file1066451line112>
> >
> > Validations should be on constructor level.
> 
> Amruth Sampath wrote:
> Again this is possible if I can have user facing entities for every model 
> entity I have and let JAXB do the marsh/unmarsh for user facing entities. I 
> can convert user facing entity to model entity internally. Should I proceed 
> doing these changes?
> 
> Rajat Khandelwal wrote:
> I don't suppose there's a way to impose restrictions purely thorugh java 
> annotations. If something can be found, that'd be great.

There is a way to validate as soon as the unmarshalling is done by JAXB. 
Removing these.


- Amruth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98361
---


On Sept. 9, 2015, 7:23 p.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> ---
> 
> (Updated Sept. 9, 2015, 7:23 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
> Khandelwal, and sharad agarwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
> 754e6e1 
>   lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java
>  PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java 
> PRE-CREATION 
>   lens-api/src/main/resources/lens-errors.conf 5428041 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  fb11f93 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/jav

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-09 Thread Amruth Sampath



On Sept. 9, 2015, 10:46 a.m., Amruth Sampath wrote:
> > Overall changes look fine.
> > Can you add one section in user doc explaining the feature ?

Sure. Where is the user doc?


- Amruth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98163
---


On Sept. 8, 2015, 6:11 p.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> ---
> 
> (Updated Sept. 8, 2015, 6:11 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
> Khandelwal, and sharad agarwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
> 754e6e1 
>   lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java
>  PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java 
> PRE-CREATION 
>   lens-api/src/main/resources/lens-errors.conf 3fb191e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 0dfd7da 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  720825a 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java
>  PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
> 5d77eb7 
>   lens-server/src/main/resources/lensserver-default.xml 5d33eda 
>   
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
>  2189eb8 
>   
> len

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-07 Thread Amruth Sampath



> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java,
> >  line 31
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064152#file1064152line31>
> >
> > Same as above - If this requires interaction with user/client, it 
> > should be lens-api package.
> 
> Amruth Sampath wrote:
> The ParameterDataType and ParameterCollectionType throws some exceptions 
> which are extending from LensException (so that error code mapping is done 
> automatically). 
> 
> Moving this to lens-api would mean LensException is not vissible anymore. 
> Should I rather create wrapper around these exceptions @ lens-server-api?
> 
> Amareshwari Sriramadasu wrote:
> Exceptions cannot be thrown from REST api request/response elements. If 
> you want to pass payload to clients, have a look at 
> FieldsCannotBeQueriedTogetherException to see how payload can be passed. If 
> no sending payload is required, leaving the exceptions in server-api and 
> server side classes throwing exception is good enough - clients would get 
> appropriate error with error code mapped correctly.

Sure. My problem is the classes like ParameterDataType and 
ParameterCollectionType was itself throwing exceptions that were extending 
LensException. Would it be better if I not extend from LensException for these 
and wrap it up in lens-server?


- Amruth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review97907
-------


On Sept. 4, 2015, 5:25 p.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> ---
> 
> (Updated Sept. 4, 2015, 5:25 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
> Khandelwal, and sharad agarwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
> 754e6e1 
>   lens-api/src/main/resources/lens-errors.conf 3fb191e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 0dfd7da 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParserResponse.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/savedquer

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-07 Thread Amruth Sampath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/
---

(Updated Sept. 7, 2015, 8:49 p.m.)


Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
Khandelwal, and sharad agarwal.


Changes
---

1) Moving api classes to lens-api
2) Restructuring rest apis
3) Added javadoc to all API and service classes
4) Other refactorings pointed out in the review


Repository: lens


Description
---

Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
(Note : Sharing and CLI are not a part of this patch)


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
754e6e1 
  lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java 
PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java 
PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
 PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java 
PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java
 PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java
 PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java 
PRE-CREATION 
  lens-api/src/main/resources/lens-errors.conf 3fb191e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
0dfd7da 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
720825a 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java
 PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
5d77eb7 
  lens-server/src/main/resources/lensserver-default.xml 5d33eda 
  
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
 2189eb8 
  
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java
 PRE-CREATION 
  lens-server/src/test/resources/lens-site.xml 4cf94d5 

Diff: https://reviews.apache.org/r/37934/diff/


Testing
---

Have added unit test cases for parsing, resolution of parameter and service 
testing.


Thanks,

Amruth Sampath

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-07 Thread Amruth Sampath



> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/lens-errors.conf, line 58
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064148#file1064148line58>
> >
> > Should user name also go in error message?
> > 
> > Will "%s access" say admin/read/write access ?
> > 
> > What is %s:%s ? Should that be single param %s ?

The format is 

User does not have {priv} access to {resource_type}:{resource_identifier}

priv -> create/read/write/delete
resource_type -> saved_query/schedule etc
resource_identifier -> id of the resource.


I thought user name wont be needed as the exception is anyways returned to the 
concerned users.


> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java,
> >  line 31
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064152#file1064152line31>
> >
> > Same as above - If this requires interaction with user/client, it 
> > should be lens-api package.

The ParameterDataType and ParameterCollectionType throws some exceptions which 
are extending from LensException (so that error code mapping is done 
automatically). 

Moving this to lens-api would mean LensException is not vissible anymore. 
Should I rather create wrapper around these exceptions @ lens-server-api?


> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java,
> >  line 264
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064170#file1064170line264>
> >
> > what is this Result handler for? Can you add comments?

Sure. This was for getting the last inserted id from the saved queries table 
(Needed when an creates a saved query. ID has to be sent back as a response).


> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/resources/lens-site.xml, lines 141-152
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064177#file1064177line141>
> >
> > Need to be removed?

yes.. Will remove it:)


> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java,
> >  line 53
> > <https://reviews.apache.org/r/37934/diff/3/?file=1064171#file1064171line53>
> >
> > should we have this under queryapi/ itself?
> > 
> > I'm thinking 'yes'. What do you think? 
> > 
> > Making this path /queryapi will cause any issue with other query 
> > resource? I'm hoping it should not, not sure though.

Yes it will work. We just have to ensure that there are no ambiguity in the 
paths. I have tested it now.

I also think it makes more sense under queryapi/. Ill make the changes.


- Amruth


-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review97907
---


On Sept. 4, 2015, 5:25 p.m., Amruth Sampath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> ---
> 
> (Updated Sept. 4, 2015, 5:25 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
> Khandelwal, and sharad agarwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
> 754e6e1 
>   lens-api/src/main/resources/lens-errors.conf 3fb191e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 0dfd7da 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParserResponse.java
>  PRE-CREATION 
>   
&

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-04 Thread Amruth Sampath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/
---

(Updated Sept. 4, 2015, 5:25 p.m.)


Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
Khandelwal, and sharad agarwal.


Changes
---

- Moving "SyntaxError" to LensCommonErrorCode
- Adding validation for saved query api


Repository: lens


Description
---

Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
(Note : Sharing and CLI are not a part of this patch)


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
754e6e1 
  lens-api/src/main/resources/lens-errors.conf 3fb191e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
0dfd7da 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParserResponse.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
 PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java
 PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
5d77eb7 
  lens-server/src/main/resources/lensserver-default.xml 5d33eda 
  
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
 2189eb8 
  
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java
 PRE-CREATION 
  lens-server/src/test/resources/lens-site.xml 4cf94d5 

Diff: https://reviews.apache.org/r/37934/diff/


Testing
---

Have added unit test cases for parsing, resolution of parameter and service 
testing.


Thanks,

Amruth Sampath

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-02 Thread Amruth Sampath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/
---

(Updated Sept. 2, 2015, 11:39 a.m.)


Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat 
Khandelwal, and sharad agarwal.


Changes
---

- Extending lens exception and mapping the error codes
- Removed syntax error code and added more meaningful codes
- Using lensserver db for saving the queries
- Updated utility methods to produce a pooling data source

(All test cases working fine)


Repository: lens


Description
---

Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
(Note : Sharing and CLI are not a part of this patch)


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 
754e6e1 
  lens-api/src/main/resources/lens-errors.conf 3fb191e 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/QueryValidatorResponse.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/ParameterParserTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/save/ParameterResolutionTest.java
 PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java
 PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
5d77eb7 
  lens-server/src/main/resources/lensserver-default.xml 5d33eda 
  
lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java
 PRE-CREATION 
  lens-server/src/test/resources/lens-site.xml 4cf94d5 

Diff: https://reviews.apache.org/r/37934/diff/


Testing
---

Have added unit test cases for parsing, resolution of parameter and service 
testing.


Thanks,

Amruth Sampath

Marshalling LensAPIResult to json

2015-09-01 Thread Amruth Sampath

I am facing issue while trying to get LensAPIResult as a json (works
fine as XML).

When the accept headers are set to "application/json" in the client,
all the APIs that expose LensAPIResult fail with an internal server
error that says

javax.ws.rs.WebApplicationException: HTTP 500 Internal Server Error
at 
org.eclipse.persistence.jaxb.rs.MOXyJsonProvider.writeTo(MOXyJsonProvider.java:810)
~[org.eclipse.persistence.moxy-2.5.0.jar:na]
at 
org.glassfish.jersey.message.internal.WriterInterceptorExecutor$TerminalWriterInterceptor.invokeWriteTo(WriterInterceptorExecutor.java:243)
~[jersey-common-2.3.1.jar:na]
at 
org.glassfish.jersey.message.internal.WriterInterceptorExecutor$TerminalWriterInterceptor.aroundWriteTo(WriterInterceptorExecutor.java:230)
~[jersey-common-2.3.1.jar:na]
at 
org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:149)
~[jersey-common-2.3.1.jar:na]
at 
org.glassfish.jersey.filter.LoggingFilter.aroundWriteTo(LoggingFilter.java:268)
~[jersey-common-2.3.1.jar:na]
at 
org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:149)
~[jersey-common-2.3.1.jar:na]
at 
org.glassfish.jersey.server.internal.JsonWithPaddingInterceptor.aroundWriteTo(JsonWithPaddingInterceptor.java:103)
~[jersey-server-2.3.1.jar:na]
at 
org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:149)
~[jersey-common-2.3.1.jar:na]
at 
org.glassfish.jersey.server.internal.MappableExceptionWrapperInterceptor.aroundWriteTo(MappableExceptionWrapperInterceptor.java:88)
~[jersey-server-2.3.1.jar:na]
at 
org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:149)
~[jersey-common-2.3.1.jar:na]
at 
org.glassfish.jersey.message.internal.MessageBodyFactory.writeTo(MessageBodyFactory.java:1139)
~[jersey-common-2.3.1.jar:na]
at 
org.glassfish.jersey.server.ServerRuntime$Responder.writeResponse(ServerRuntime.java:562)
~[jersey-server-2.3.1.jar:na]
at 
org.glassfish.jersey.server.ServerRuntime$Responder.processResponse(ServerRuntime.java:357)
~[jersey-server-2.3.1.jar:na]
at 
org.glassfish.jersey.server.ServerRuntime$Responder.process(ServerRuntime.java:347)
~[jersey-server-2.3.1.jar:na]
at org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:258)
~[jersey-server-2.3.1.jar:na]
at org.glassfish.jersey.internal.Errors$1.call(Errors.java:271)
[jersey-common-2.3.1.jar:na]
at org.glassfish.jersey.internal.Errors$1.call(Errors.java:267)
[jersey-common-2.3.1.jar:na]
at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
[jersey-common-2.3.1.jar:na]
at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
[jersey-common-2.3.1.jar:na]
at org.glassfish.jersey.internal.Errors.process(Errors.java:267)
[jersey-common-2.3.1.jar:na]
at 
org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:318)
[jersey-common-2.3.1.jar:na]
at org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:235)
[jersey-server-2.3.1.jar:na]
at 
org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:983)
[jersey-server-2.3.1.jar:na]
at 
org.glassfish.jersey.grizzly2.httpserver.GrizzlyHttpContainer.service(GrizzlyHttpContainer.java:330)
[jersey-container-grizzly2-http-2.3.1.jar:na]
at org.glassfish.grizzly.http.server.HttpHandler$1.run(HttpHandler.java:212)
[grizzly-http-server-2.3.6.jar:2.3.6]
at 
org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:565)
[grizzly-framework-2.3.6.jar:2.3.6]
at 
org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:545)
[grizzly-framework-2.3.6.jar:2.3.6]
at java.lang.Thread.run(Thread.java:745) [na:1.8.0_25]
Caused by: javax.xml.bind.MarshalException: null
at org.eclipse.persistence.jaxb.JAXBMarshaller.marshal(JAXBMarshaller.java:403)
~[org.eclipse.persistence.moxy-2.5.0.jar:na]
at 
org.eclipse.persistence.jaxb.rs.MOXyJsonProvider.writeTo(MOXyJsonProvider.java:808)
~[org.eclipse.persistence.moxy-2.5.0.jar:na]
... 27 common frames omitted
Caused by: org.eclipse.persistence.exceptions.XMLMarshalException:
Exception Description: An error occurred marshalling the object
Internal Exception: Exception [EclipseLink-25007] (Eclipse Persistence
Services - 2.5.0.v20130507-3faac2b):
org.eclipse.persistence.exceptions.XMLMarshalException
Exception Description: A descriptor for class
org.apache.lens.api.result.LensAPIResult was not found in the project.
For JAXB, if the JAXBContext was bootstrapped using TypeMappingInfo[]
you must call a marshal method that accepts TypeMappingInfo as an
input parameter.
at 
org.eclipse.persistence.exceptions.XMLMarshalException.marshalException(XMLMarshalException.java:97)
~[org.eclipse.persistence.core-2.5.0.jar:na]
at 
org.eclipse.persistence.internal.oxm.XMLMarshaller.marshal(XMLMarshaller.java:911)
~[org.eclipse.persistence.core-2.5.0.jar:na]
at

Re: Marshalling LensAPIResult to json

2015-09-01 Thread Amruth Sampath

Hi Raju, Tried that, still getting the same error.

I think the context provided by LensJAXBContextResolver is not
respected by MOXyJsonProvider.

MOXyJsonProvider creates its own context with just LensAPIResult. The
Type class seem to get missed in the context leading to an exception -
 "the class or any of its super class is not known to the context".

On Tue, Sep 1, 2015 at 11:55 AM, Raju Bairishetti
<raju.bairishe...@inmobi.com> wrote:
> @Amruth, Can you try by adding this dependency in lens-api?
>
>   
>
> org.glassfish.jersey.media
>
> jersey-media-moxy
>
> ${jersey.version}
>
>   
>
> On Tue, Sep 1, 2015 at 11:52 AM, amareshwarisr . <amareshw...@gmail.com>
> wrote:
>
>> Not aware of issue, please go ahead and create jira.
>>
>> On Tue, Sep 1, 2015 at 11:43 AM, Amruth Sampath <amrut...@flipkart.com>
>> wrote:
>>
>> > I am facing issue while trying to get LensAPIResult as a json (works
>> > fine as XML).
>> >
>> > When the accept headers are set to "application/json" in the client,
>> > all the APIs that expose LensAPIResult fail with an internal server
>> > error that says
>> >
>> > javax.ws.rs.WebApplicationException: HTTP 500 Internal Server Error
>> > at
>> >
>> org.eclipse.persistence.jaxb.rs.MOXyJsonProvider.writeTo(MOXyJsonProvider.java:810)
>> > ~[org.eclipse.persistence.moxy-2.5.0.jar:na]
>> > at
>> >
>> org.glassfish.jersey.message.internal.WriterInterceptorExecutor$TerminalWriterInterceptor.invokeWriteTo(WriterInterceptorExecutor.java:243)
>> > ~[jersey-common-2.3.1.jar:na]
>> > at
>> >
>> org.glassfish.jersey.message.internal.WriterInterceptorExecutor$TerminalWriterInterceptor.aroundWriteTo(WriterInterceptorExecutor.java:230)
>> > ~[jersey-common-2.3.1.jar:na]
>> > at
>> >
>> org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:149)
>> > ~[jersey-common-2.3.1.jar:na]
>> > at
>> >
>> org.glassfish.jersey.filter.LoggingFilter.aroundWriteTo(LoggingFilter.java:268)
>> > ~[jersey-common-2.3.1.jar:na]
>> > at
>> >
>> org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:149)
>> > ~[jersey-common-2.3.1.jar:na]
>> > at
>> >
>> org.glassfish.jersey.server.internal.JsonWithPaddingInterceptor.aroundWriteTo(JsonWithPaddingInterceptor.java:103)
>> > ~[jersey-server-2.3.1.jar:na]
>> > at
>> >
>> org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:149)
>> > ~[jersey-common-2.3.1.jar:na]
>> > at
>> >
>> org.glassfish.jersey.server.internal.MappableExceptionWrapperInterceptor.aroundWriteTo(MappableExceptionWrapperInterceptor.java:88)
>> > ~[jersey-server-2.3.1.jar:na]
>> > at
>> >
>> org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:149)
>> > ~[jersey-common-2.3.1.jar:na]
>> > at
>> >
>> org.glassfish.jersey.message.internal.MessageBodyFactory.writeTo(MessageBodyFactory.java:1139)
>> > ~[jersey-common-2.3.1.jar:na]
>> > at
>> >
>> org.glassfish.jersey.server.ServerRuntime$Responder.writeResponse(ServerRuntime.java:562)
>> > ~[jersey-server-2.3.1.jar:na]
>> > at
>> >
>> org.glassfish.jersey.server.ServerRuntime$Responder.processResponse(ServerRuntime.java:357)
>> > ~[jersey-server-2.3.1.jar:na]
>> > at
>> >
>> org.glassfish.jersey.server.ServerRuntime$Responder.process(ServerRuntime.java:347)
>> > ~[jersey-server-2.3.1.jar:na]
>> > at
>> org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:258)
>> > ~[jersey-server-2.3.1.jar:na]
>> > at org.glassfish.jersey.internal.Errors$1.call(Errors.java:271)
>> > [jersey-common-2.3.1.jar:na]
>> > at org.glassfish.jersey.internal.Errors$1.call(Errors.java:267)
>> > [jersey-common-2.3.1.jar:na]
>> > at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
>> > [jersey-common-2.3.1.jar:na]
>> > at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
>> > [jersey-common-2.3.1.jar:na]
>> > at org.glassfish.jersey.internal.Errors.process(Errors.java:267)
>> > [jersey-common-2.3.1.jar:na]
>> > at
>> >
>> org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:318)
>> > [jersey-common-2.3.1.jar:na]
>> >

Re: Review Request 39897: LENS-860 : Updating committer documentation

Re: Review Request 39897: LENS-860 : Updating committer documentation

Review Request 39897: LENS-860 : Updating committer documentation

Re: Question regarding commits

Question regarding commits

Re: Review Request 37934: LENS-742 Saved query and parameterization

Re: Review Request 37934: LENS-742 Saved query and parameterization

Re: Review Request 37934: LENS-742 Saved query and parameterization

Re: Review Request 37934: LENS-742 Saved query and parameterization

Re: Review Request 37934: LENS-742 Saved query and parameterization

Re: Review Request 37934: LENS-742 Saved query and parameterization

Re: Review Request 37934: LENS-742 Saved query and parameterization

Re: Review Request 37934: LENS-742 Saved query and parameterization

Re: Review Request 37934: LENS-742 Saved query and parameterization

Re: Review Request 37934: LENS-742 Saved query and parameterization

Re: Review Request 37934: LENS-742 Saved query and parameterization

Re: Review Request 37934: LENS-742 Saved query and parameterization

Re: Review Request 37934: LENS-742 Saved query and parameterization

Marshalling LensAPIResult to json

Re: Marshalling LensAPIResult to json

20 matches

Site Navigation

Mail list logo

Footer information